[Openvpn-devel] [XS] Change in openvpn[master]: Document tls-exit option mainly as test option

2023-12-01 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/447?usp=email ) Change subject: Document tls-exit option mainly as test option .. Patch

[Openvpn-devel] [XS] Change in openvpn[master]: Remove dead remains of extract_x509_field_test

2023-12-01 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/462?usp=email ) Change subject: Remove dead remains of extract_x509_field_test .. Patch

[Openvpn-devel] [S] Change in openvpn[master]: Remove unused/unneeded/add missing defines from configure/cmake

2023-12-01 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/443?usp=email ) Change subject: Remove unused/unneeded/add missing defines from configure/cmake

[Openvpn-devel] [PATCH v1] Remove dead remains of extract_x509_field_test

2023-12-01 Thread Frank Lichtenheld
From: Arne Schwabe This removes some leftover references to extract_x509_field_test that was removed 15 years ago in commit 564cbab5f. Change-Id: Ie511a586cf022afcab9d67891ff80676ac7d47b9 Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld --- This change was reviewed on Gerrit and

[Openvpn-devel] [PATCH v1] Replace character_class_debug with proper unit test

2023-12-01 Thread Frank Lichtenheld
From: Arne Schwabe Change-Id: Ib2aa85b9c34d0a0b8b1dfb9f477f56c9a6b705d0 Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL:

[Openvpn-devel] [PATCH v1] GHA: clean up libressl builds with newer libressl

2023-12-01 Thread Frank Lichtenheld
- Update to latest stable release - Work-around patches not required anymore - Official URL of repo has changed Change-Id: I9b8e69f2b9838cea4cb9001f4e8960b8a39724ef Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe --- This change was reviewed on Gerrit and approved by at least one

[Openvpn-devel] [M] Change in openvpn[master]: Replace character_class_debug with proper unit test

2023-12-01 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/464?usp=email ) Change subject: Replace character_class_debug with proper unit test ..

[Openvpn-devel] [PATCH v2] Change default of "topology" to "subnet"

2023-12-01 Thread Frank Lichtenheld
Change-Id: Iede3e7c028cbb715e28bc88c7e583f84dadc02c8 Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/421 This mail reflects

[Openvpn-devel] [PATCH v3] Document tls-exit option mainly as test option

2023-12-01 Thread Frank Lichtenheld
From: Arne Schwabe Change-Id: I93afff2372c4150d6bddc8c07fd4ebc8bfb0cc3e Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL:

[Openvpn-devel] [M] Change in openvpn[master]: Check PRF availability on initialisation and add --force-tls-key-mate...

2023-12-01 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/460?usp=email ) Change subject: Check PRF availability on initialisation and add --force-tls-key-material-export

[Openvpn-devel] [M] Change in openvpn[master]: Check PRF availability on initialisation and add --force-tls-key-mate...

2023-12-01 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/460?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review-1 by

[Openvpn-devel] [XS] Change in openvpn[master]: Extend the error message when TLS 1.0 PRF fails

2023-12-01 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/456?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Code-Review-1 by

[Openvpn-devel] [XS] Change in openvpn[master]: Extend the error message when TLS 1.0 PRF fails

2023-12-01 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/456?usp=email ) Change subject: Extend the error message when TLS 1.0 PRF fails ..

[Openvpn-devel] [PATCH v1] Remove TEST_GET_DEFAULT_GATEWAY as it duplicates --show-gateway

2023-12-01 Thread Frank Lichtenheld
From: Arne Schwabe This debug code is not very useful as it is outdated and the same functionality is provided by --show-gateway Change-Id: Ie7fd59cc84e2eb024086c28c2ec2a5606a2b2e7c Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld --- This change was reviewed on Gerrit and approved by

[Openvpn-devel] [PATCH v5] Remove unused/unneeded/add missing defines from configure/cmake

2023-12-01 Thread Frank Lichtenheld
From: Arne Schwabe Change-Id: Ifd0376b36d4050dc22bc93b8fcf7ed29faef0021 Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL:

[Openvpn-devel] [S] Change in openvpn[master]: Remove TEST_GET_DEFAULT_GATEWAY as it duplicates --show-gateway

2023-12-01 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/463?usp=email ) Change subject: Remove TEST_GET_DEFAULT_GATEWAY as it duplicates --show-gateway

[Openvpn-devel] [M] Change in openvpn[master]: Check PRF availability on initialisation and add --force-tls-key-mate...

2023-12-01 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/460?usp=email ) Change subject: Check PRF availability on initialisation and add --force-tls-key-material-export

[Openvpn-devel] [M] Change in openvpn[master]: Implement generating TLS 1.0 PRF using new OpenSSL 3.0 APIs

2023-12-01 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/457?usp=email ) Change subject: Implement generating TLS 1.0 PRF using new OpenSSL 3.0 APIs

[Openvpn-devel] [M] Change in openvpn[master]: Check PRF availability on initialisation and add --force-tls-key-mate...

2023-12-01 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/460?usp=email ) Change subject: Check PRF availability on initialisation and add --force-tls-key-material-export

[Openvpn-devel] [XS] Change in openvpn[master]: Extend the error message when TLS 1.0 PRF fails

2023-12-01 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/456?usp=email ) Change subject: Extend the error message when TLS 1.0 PRF fails ..

[Openvpn-devel] [S] Change in openvpn[master]: Make it more explicit and visible when pkg-config is not found

2023-12-01 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/465?usp=email ) Change subject: Make it more explicit and visible when pkg-config is not found

[Openvpn-devel] [S] Change in openvpn[master]: Make it more explicit and visible when pkg-config is not found

2023-12-01 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/465?usp=email to review the following change. Change subject: Make it more explicit and visible when pkg-config is not found