[Openvpn-devel] [L] Change in openvpn[master]: Implement support for larger packet counter sizes

2024-03-27 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/507?usp=email ) Change subject: Implement support for larger packet counter sizes ..

[Openvpn-devel] IRC community meeting summary

2024-03-27 Thread Johan Draaisma
Meeting summary for 27 March 2024: * *New: when to deprecate weak ciphers* /Weak ciphers like 3DES and BF-CBC - what to do with them and when?/ /Originally it looks like it was planned to remove in 2.7 but that may be too soon./ /For example OpenVPN Inc. still sees customers with

[Openvpn-devel] [S] Change in openvpn[master]: crypto_backend: fix type of enc parameter

2024-03-27 Thread flichtenheld (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/548?usp=email to look at the new patch set (#3). Change subject: crypto_backend: fix type of enc parameter

[Openvpn-devel] [S] Change in openvpn[master]: crypto_backend: fix type of enc parameter

2024-03-27 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/548?usp=email ) Change subject: crypto_backend: fix type of enc parameter ..

[Openvpn-devel] [S] Change in openvpn[master]: crypto_backend: fix type of enc parameter

2024-03-27 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/548?usp=email ) Change subject: crypto_backend: fix type of enc parameter .. Patch Set

[Openvpn-devel] [S] Change in openvpn[master]: crypto_backend: fix type of enc parameter

2024-03-27 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld, ordex. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/548?usp=email ) Change subject: crypto_backend: fix type of enc parameter ..

[Openvpn-devel] [S] Change in openvpn[master]: crypto_backend: fix type of enc parameter

2024-03-27 Thread flichtenheld (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/548?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review-1 by

[Openvpn-devel] [XS] Change in openvpn[master]: mbedtls: avoid warning with GCC 13+

2024-03-27 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/548?usp=email ) Change subject: mbedtls: avoid warning with GCC 13+ .. Patch Set 1:

[Openvpn-devel] [L] Change in openvpn[master]: Remove openvpn_snprintf and similar functions

2024-03-27 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/547?usp=email ) Change subject: Remove openvpn_snprintf and similar functions ..

[Openvpn-devel] [L] Change in openvpn[master]: Implement support for larger packet counter sizes

2024-03-27 Thread plaisthos (Code Review)
Attention is currently required from: plaisthos. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/507?usp=email to look at the new patch set (#4). Change subject: Implement support for larger packet counter sizes

[Openvpn-devel] [M] Change in openvpn[master]: Implement support for AEAD tag at the end

2024-03-27 Thread plaisthos (Code Review)
Attention is currently required from: plaisthos. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/506?usp=email to look at the new patch set (#4). The change is no longer submittable: checks~ChecksSubmitRule is unsatisfied now.

[Openvpn-devel] [L] Change in openvpn[master]: Implement support for larger packet counter sizes

2024-03-27 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/507?usp=email ) Change subject: Implement support for larger packet counter sizes ..

[Openvpn-devel] [S] Change in openvpn[master]: crypto_backend: fix type of enc parameter

2024-03-27 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/548?usp=email ) Change subject: crypto_backend: fix type of enc parameter ..

[Openvpn-devel] [S] Change in openvpn[master]: crypto_backend: fix type of enc parameter

2024-03-27 Thread flichtenheld (Code Review)
Attention is currently required from: ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/548?usp=email ) Change subject: crypto_backend: fix type of enc parameter ..

[Openvpn-devel] [S] Change in openvpn[master]: crypto_backend: fix type of enc parameter

2024-03-27 Thread flichtenheld (Code Review)
Attention is currently required from: ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/548?usp=email ) Change subject: crypto_backend: fix type of enc parameter ..

[Openvpn-devel] [PATCH v3] crypto_backend: fix type of enc parameter

2024-03-27 Thread Frank Lichtenheld
We had parts of a abstraction, but it wasn't consistent. GCC 13 now complains about the type mismatch with mbedtls now: crypto_mbedtls.c:568:1: error: conflicting types for ‘cipher_ctx_init’ due to enum/integer mismatch; have ‘void(mbedtls_cipher_context_t *, const uint8_t *, const char *, const

[Openvpn-devel] [S] Change in openvpn[master]: crypto_backend: fix type of enc parameter

2024-03-27 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld, ordex. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/548?usp=email ) Change subject: crypto_backend: fix type of enc parameter ..