[Openvpn-devel] [M] Change in openvpn[master]: Check PRF availability on initialisation and add --force-tls-key-mate...

2023-12-13 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/460?usp=email ) Change subject: Check PRF availability on initialisation and add --force-tls-key-material-export

[Openvpn-devel] [S] Change in openvpn[master]: tests: disable automake serial_tests

2023-12-13 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/477?usp=email ) Change subject: tests: disable automake serial_tests .. Patch Set 2:

[Openvpn-devel] [M] Change in openvpn[master]: tests: fork default automake test-driver

2023-12-13 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/478?usp=email ) Change subject: tests: fork default automake test-driver .. Patch Set

[Openvpn-devel] [M] Change in openvpn[master]: Move get_tmp_dir to win32-util.c and error out on failure

2023-12-13 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/481?usp=email ) Change subject: Move get_tmp_dir to win32-util.c and error out on failure

[Openvpn-devel] [L] Change in openvpn[release/2.6]: Backport mbed TLS 3 support to OpenVPN 2.6

2023-12-13 Thread plaisthos (Code Review)
Attention is currently required from: MaxF, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/404?usp=email ) Change subject: Backport mbed TLS 3 support to OpenVPN 2.6 ..

[Openvpn-devel] [PATCH] documentation: improve documentation of --x509-track

2023-12-13 Thread Frank Lichtenheld
In the current state it was completely unclear to me how you would use this. Extended the description based on reading the code and experimentation. Change-Id: Ibf728f9d624e64ecda094d66fa562bd3916829d2 Signed-off-by: Frank Lichtenheld --- doc/man-sections/script-options.rst | 3 +++

[Openvpn-devel] [M] Change in openvpn[master]: Implement the --tls-export-cert feature

2023-12-13 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/466?usp=email ) Change subject: Implement the --tls-export-cert feature .. Patch

[Openvpn-devel] [M] Change in openvpn[master]: Move get_tmp_dir to win32-util.c and error out on failure

2023-12-13 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/481?usp=email ) Change subject: Move get_tmp_dir to win32-util.c and error out on failure

[Openvpn-devel] [L] Change in openvpn[master]: Add test_ssl unit test and test export of PEM to file

2023-12-13 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/471?usp=email ) Change subject: Add test_ssl unit test and test export of PEM to file ..

[Openvpn-devel] [L] Change in openvpn[master]: Add test_ssl unit test and test export of PEM to file

2023-12-13 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/471?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review-1

[Openvpn-devel] [M] Change in openvpn[master]: Move get_tmp_dir to win32-util.c and error out on failure

2023-12-13 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/481?usp=email to review the following change. Change subject: Move get_tmp_dir to win32-util.c and error out on failure

[Openvpn-devel] IRC community meeting summary

2023-12-13 Thread Johan Draaisma
Meeting summary for 13 December 2023: * *Updated: OpenVPN 2.6.9 release* /In discussion with community members looks like next week would be a good time for a 2.6.9 release./ * *Updated: forums topics* /Pippin_ and novaflash reported lots of spam on the forums. rob0 got into

[Openvpn-devel] [PATCH v2] Make it more explicit and visible when pkg-config is not found

2023-12-13 Thread Frank Lichtenheld
From: Arne Schwabe Users seem to struggle to read the full error message. This adds an indication if pkg-config is actually found to the warning/error message that use pkg-config. When found: configure: error: libnl-genl-3.0 package not found or too old. Is the development package and

[Openvpn-devel] [PATCH v8] Extend the error message when TLS 1.0 PRF fails

2023-12-13 Thread Frank Lichtenheld
From: Arne Schwabe This error will probably become more and more common in the future when more and more systems will drop TLS 1.0 PRF support. We are already seeing people stumbling upon this (see GitHub issue #460) The current error messages TLS Error: PRF calcuation failed TLS Error:

[Openvpn-devel] [XS] Change in openvpn[master]: Extend the error message when TLS 1.0 PRF fails

2023-12-13 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/456?usp=email ) Change subject: Extend the error message when TLS 1.0 PRF fails ..

[Openvpn-devel] [XS] Change in openvpn[master]: forked-test-driver: Show test output always

2023-12-13 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/479?usp=email ) Change subject: forked-test-driver: Show test output always .. Patch