[Openvpn-devel] [PATCH applied] Re: script-options.rst: Update ifconfig_* variables

2024-03-26 Thread Gert Doering
Acked-by: Gert Doering We're so bad at times at updating documentation... verified that the newly documented options exist and do what it says. Confusing code... Your patch has been applied to the master and release/2.6 branch (doc). commit a94226cdc8ed037a6763675aa47e6c821983f174 (master)

[Openvpn-devel] [XS] Change in openvpn[master]: Add bracket in fingerprint message and do not warn about missing veri...

2024-03-26 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/546?usp=email ) Change subject: Add bracket in fingerprint message and do not warn about missing verification .. Add bracket in fingerprint message and

[Openvpn-devel] [XS] Change in openvpn[master]: Add bracket in fingerprint message and do not warn about missing veri...

2024-03-26 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#2) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/546?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by flichtenheld Change subject: Add bracket in fingerprint message and do not warn

[Openvpn-devel] [PATCH applied] Re: Add bracket in fingerprint message and do not warn about missing verification

2024-03-26 Thread Gert Doering
Added the Github reference to #516 Your patch has been applied to the master and release/2.6 branch (bugfix). commit 4b95656536be1f402a55ef5dffe140fa78e7eb51 (master) commit e36359aa7e5193ad002768e90ae660896a5a0fa6 (release/2.6) Author: Arne Schwabe Date: Tue Mar 26 11:38:53 2024 +0100

[Openvpn-devel] [PATCH applied] Re: Fix snprintf/swnprintf related compiler warnings

2024-03-26 Thread Gert Doering
Lightly stared at code and ran client side tests (that excercise proxy). Your patch has been applied to the master branch. commit 6889d9e2f1458272ded4c035df40378ace3d7395 (master) Author: Arne Schwabe Date: Tue Mar 26 11:41:01 2024 +0100 Fix snprintf/swnprintf related compiler warnings

[Openvpn-devel] [S] Change in openvpn[master]: Fix snprintf/swnprintf related compiler warnings

2024-03-26 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/549?usp=email ) Change subject: Fix snprintf/swnprintf related compiler warnings .. Fix snprintf/swnprintf related compiler warnings When

[Openvpn-devel] [S] Change in openvpn[master]: Fix snprintf/swnprintf related compiler warnings

2024-03-26 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#2) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/549?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by flichtenheld Change subject: Fix snprintf/swnprintf related compiler warnings

[Openvpn-devel] [PATCH v1] Fix snprintf/swnprintf related compiler warnings

2024-03-26 Thread Frank Lichtenheld
From: Arne Schwabe When openvpn_snprintf is replaced by snprintf the GCC/MSVC compiler will perform additional checks that the result is not truncated. This warning can be avoid by either explicitly checking the return value of snprintf (proxy) or ensuring that it is never truncated(tls crypt)

[Openvpn-devel] [PATCH v1] Add bracket in fingerprint message and do not warn about missing verification

2024-03-26 Thread Frank Lichtenheld
From: Arne Schwabe Change-Id: Ia73d53002f4ba2658af18c17cce1b68f79de5781 Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL:

[Openvpn-devel] [S] Change in openvpn[master]: Fix snprintf/swnprintf related compiler warnings

2024-03-26 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/549?usp=email ) Change subject: Fix snprintf/swnprintf related compiler warnings ..