Re: [ovs-dev] [BUG] ovs-ofctl version 2.5.0 will crash with OFPFMFC_BAD_COMMAND

I can reproduce this problem with the script supported by vguntaka in both ovs version 2.5 and ovs version 2.6. 1. Add bridge ovs-vsctl add-br br0 2. Add vm port ovs-vsctl add-port br0 tap0 – set interface tap0 type=internal ip netns add ns0 ip link set dev tap0 netns ns0

Re: [ovs-dev] [PATCH] datapath-windows: Set Version correctly for OVSExt

Sorry I cut a bit to much. Like the following (also attached): --- datapath-windows/ovsext/ovsext.rc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/datapath-windows/ovsext/ovsext.rc b/datapath-windows/ovsext/ovsext.rc index a7cf0a7..20e54bf 100644 ---

Re: [ovs-dev] [PATCH] bridge: Fix controller status update

On Fri, May 12, 2017 at 12:07 PM, Andy Zhou wrote: > On Thu, May 11, 2017 at 8:35 PM, Greg Rose wrote: >> On Thu, 2017-05-11 at 16:16 -0700, Andy Zhou wrote: >>> When multiple bridges connects to the same controller, the controller >>> status should be

Re: [ovs-dev] [PATCH] datapath-windows: Set Version correctly for OVSExt

Alin, that will not work I guess, because the ProductVersion property should have the version in "x.x.x.x" format, not comma separated. Thanks, Shashank From: Alin Serdean Sent: Monday, May 15, 2017 1:59:58 PM To: Alin

Re: [ovs-dev] [PATCH] datapath-windows: Set Version correctly for OVSExt

I think the same effect can be achieved using this incremental: --- datapath-windows/ovsext/ovsext.rc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/datapath-windows/ovsext/ovsext.rc b/datapath-windows/ovsext/ovsext.rc index a7cf0a7..8896256 100644 ---

Re: [ovs-dev] [PATCH] datapath-windows: Set Version correctly for OVSExt

Hi Alin, thanks for the review. Will send out an updated patch. VER_TO_STR applied to both the FileVersion as well as ProductVersion entry in the "VarFileInfo" block. The FILEVERSION property does not require a string literal, so it gets generated fine. However, note that the FileVersion

Re: [ovs-dev] [PATCH] datapath-windows: Set Version correctly for OVSExt

Thanks a lot for the patch. I had to double look the changes. It may be worth adding to the commit message that this impacts the way the "ovsext.sys" product version will be generated. At the moment, only the file version of the sys attributes will be generated correctly. The product version

[ovs-dev] [PATCH 5/5] ofp-util: Fix tun_metadata processing in pakcet-out

Pass tun_table to ofputil_handle_packet_out() to correctly decode tunnel metadata in packet-out messages. Signed-off-by: Yi-Hung Wei --- include/openvswitch/ofp-util.h | 1 + lib/ofp-print.c| 2 +- lib/ofp-util.c | 3 ++- ofproto/ofproto.c

[ovs-dev] [PATCH 4/5] ofp-parse: Parse pipeline fields in OF1.5 packet-out

This patch adds support for parsing the pipeline match fields of OpenFlow 1.5 packet-out messages. With this patch, we can use ovs-ofctl to specify pipeline fileds for a packet-out message. Signed-off-by: Yi-Hung Wei --- lib/ofp-parse.c | 14 ++

[ovs-dev] [PATCH 3/5] ofproto: Add pipeline fields support for OF 1.5 packet-out

This patch decodes pipeline fields from a packet-out message, and populates the pipeline fields into datapath. Error OFPERR_OFPBRC_PIPELINE_FIELDS_ONLY is returned if the match field of a packet-out messages contains any non pipeline fields. Currently, the supported pipeline fields are as

[ovs-dev] [PATCH 2/5] ofp-util: Add OpenFlow 1.5 packet-out support

This patch implements the encoding and decoding of the new packet-out format defined in OpenFlow 1.5. Test cases are provided to verify the encoding and decoding. This patch is based on [1] and [2]. [1] https://github.com/jean2/openvswitch/commits/jean/ext-427 [2]

[ovs-dev] [PATCH 1/5] ofp-util: Add flow metadata to ofputil_packet_out

This patch adds flow metadata to ofputil_packet_out. It does not make any functional change. The flow metadata will be useful to support new packet-out message format in OpenFlow 1.5. Signed-off-by: Yi-Hung Wei --- include/openvswitch/ofp-util.h | 2 +-

[ovs-dev] [PATCH 0/5] Support OpenFlow 1.5 packet-out

This patch series add support to OpenFlow 1.5 packet-out messages that enable setting pipeline fields. v2: - Add support for tunnel and register pipeline fields. - Pull out common part of patch 2 in v1 and [1]. - Use 'struct match' instead of 'struct flow' for flow metadata in 'struct

Re: [ovs-dev] [PATCH 4/5] dpif-netdev: Fix comments for dp_netdev_pmd_thread struct.

>> >> >>How about something like this ? >> >>+ * Each struct has its own flow cache and classifier per managed inport. >>Packets >>+ *received from managed ports are looked up in the corresponding pmd >>+ * thread's flow cache and corresponding classifier, if the flow >>cache misses.

[ovs-dev] [PATCH] dpif-netdev: Fix comments for dp_netdev_pmd_thread struct.

The sorted subtable ranking patch introduced a classifier instance per ingress port with its subtables ranked on the frequency of hits. The PMD thread can have more classifier instances now and solely depends on the number of ingress ports currently handled by the pmd thread. Fixes: 3453b4d62a98

[ovs-dev] [PATCH v2] python ovs: Fix SSL exceptions with pyOpenSSL v0.13

From: Numan Siddique Centos provides pyOpenSSL version pyOpenSSL-0.13.1-3.el7.x86_64. There are 2 issues using this version, which this patch fixes - The test case "simple idl verify notify - SSL" is skipped. This is because "python -m OpenSSL.SSL" is used to detect the

Re: [ovs-dev] [PATCH] python ovs: Fix SSL exceptions with pyOpenSSL v0.13

On Mon, May 15, 2017 at 8:46 PM, Lance Richardson wrote: > > From: nusid...@redhat.com > > To: d...@openvswitch.org > > Sent: Monday, 15 May, 2017 11:03:47 AM > > Subject: [ovs-dev] [PATCH] python ovs: Fix SSL exceptions with > pyOpenSSL v0.13 > > > > From: Numan

Re: [ovs-dev] [PATCH] python ovs: Fix SSL exceptions with pyOpenSSL v0.13

> From: nusid...@redhat.com > To: d...@openvswitch.org > Sent: Monday, 15 May, 2017 11:03:47 AM > Subject: [ovs-dev] [PATCH] python ovs: Fix SSL exceptions with pyOpenSSL > v0.13 > > From: Numan Siddique > > Centos provides pyOpenSSL version

[ovs-dev] [PATCH] python ovs: Fix SSL exceptions with pyOpenSSL v0.13

From: Numan Siddique Centos provides pyOpenSSL version pyOpenSSL-0.13.1-3.el7.x86_64. There are 2 issues using this version, which this patch fixes - The test case "simple idl verify notify - SSL" is skipped. This is because "python -m OpenSSL.SSL" is used to detect the

Re: [ovs-dev] [PATCH] dpif-netdev: emc comments

Hi Darrell, Thanks for reviewing. I considered doing a little bit of ascii art to detail what was going but they are not used in the ovs code anywhere else, so instead I settled for illustrating the general case via a specific case. I felt that the extra commentary here was useful as it makes

Re: [ovs-dev] [RFC] packets: Do not initialize ct_orig_tuple.

>Commit daf4d3c18da4("odp: Support conntrack orig tuple key.") introduced >new fields in struct 'pkt_metadata'. pkt_metadata_init() is called for every >packet in the userspace datapath. When testing a simple single flow case with >DPDK, we observe a lower throughput after the above commit (it

Re: [ovs-dev] [RFC PATCH] netdev-dpdk: Add Tx intermediate queue for vhost ports.

Hi Eelco, > > This commit adds the intermediate queue for vHost-user ports. It > >improves the throughput in multiple virtual machines deployments and > also >in cases with VM doing packet forwarding in kernel stack. > > > > This patch is aligned with intermediate queue implementation for dpdk

[ovs-dev] [RFC PATCH v2 0/1] netdev-dpdk: multi-segment mbuf jumbo frame support

This RFC introduces an approach for implementing jumbo frame support for OvS-DPDK with multi-segment mbufs. == Overview == Currently, jumbo frame support for OvS-DPDK is implemented by increasing the size of mbufs within a mempool, such that each mbuf within the pool is large enough to contain

[ovs-dev] [RFC PATCH v2 1/1] netdev-dpdk: enable multi-segment jumbo frames

Currently, jumbo frame support for OvS-DPDK is implemented by increasing the size of mbufs within a mempool, such that each mbuf within the pool is large enough to contain an entire jumbo frame of a user-defined size. Typically, for each user-defined MTU 'requested_mtu', a new mempool is created,

Re: [ovs-dev] (no subject)

Whoops - please disregard; I'll send an updated version with the correct subject line. Cheers, Mark >-Original Message- >From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org] >On Behalf Of >Mark Kavanagh >Sent: Monday, May 15, 2017 11:00 AM >To:

Re: [ovs-dev] [PATCH] ovn: increase size of ingress and egress pipelines

On Fri, May 12, 2017 at 12:06 AM, Mickey Spiegel wrote: > The OVN ingress pipeline for a logical switch is maxed out at 16 stages. > > This patch takes the simple approach of starting the ingress pipeline at > table 8 rather than table 16, and starting the egress pipeline

[ovs-dev] [RFC PATCH 1/1] netdev-dpdk: enable multi-segment jumbo frames

Currently, jumbo frame support for OvS-DPDK is implemented by increasing the size of mbufs within a mempool, such that each mbuf within the pool is large enough to contain an entire jumbo frame of a user-defined size. Typically, for each user-defined MTU 'requested_mtu', a new mempool is created,

[ovs-dev] [RFC PATCH 0/1] netdev-dpdk: multi-segment mbuf jumbo frame support

This RFC introduces an approach for implementing jumbo frame support for OvS-DPDK with multi-segment mbufs. == Overview == Currently, jumbo frame support for OvS-DPDK is implemented by increasing the size of mbufs within a mempool, such that each mbuf within the pool is large enough to contain

[ovs-dev] (no subject)

Added missing 'signed-off-by' tag. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v5 5/6] ovn-controller: add 'put_nd_ra_addr_mode' and 'put_nd_opt_*' actions support

On Sat, May 6, 2017 at 10:10 AM, Ben Pfaff wrote: > On Thu, May 04, 2017 at 08:43:54PM +0530, nusid...@redhat.com wrote: > > From: Zong Kai LI > > > > This patch adds action 'nd_ra' specific inner actions > 'put_nd_ra_addr_mode', > > 'put_nd_opt_prefix',

Re: [ovs-dev] [PATCH ovs V8 02/26] netdev: Adding a new netdev api to be used for offloading flows

On 09/05/2017 21:12, Flavio Leitner wrote: On Wed, May 03, 2017 at 06:07:53PM +0300, Roi Dayan wrote: From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman ---

Re: [ovs-dev] [PATCH ovs V8 02/26] netdev: Adding a new netdev api to be used for offloading flows

On 08/05/2017 15:28, Simon Horman wrote: On Wed, May 03, 2017 at 06:07:53PM +0300, Roi Dayan wrote: From: Paul Blakey Please add some text to the changelog. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon