Re: [ovs-dev] [bug] failed to add ovs bridge

I don't plan to pursue this because it only triggers when you do something that I don't think makes sense. It could be a bug in the Linux bridge, or in OVS, or in their interaction, or in libvirt. If you narrow down the problem, or find a fix, please let us know. On Thu, May 18, 2017 at

Re: [ovs-dev] [RFC] packets: Do not initialize ct_orig_tuple.

On 17 May 2017 at 16:26, Darrell Ball wrote: > > > On 5/17/17, 2:19 PM, "Joe Stringer" wrote: > > On 16 May 2017 at 21:01, Darrell Ball wrote: > > > > > > On 5/15/17, 6:00 AM, "ovs-dev-boun...@openvswitch.org on behalf of >

Re: [ovs-dev] [bug] failed to add ovs bridge

No. I just hit this in the situation. Do you think this is a bug? What's your next plan? > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Wednesday, May 17, 2017 11:55 PM > To: fukaige > Cc: d...@openvswitch.org > Subject: Re: [bug] failed to add ovs bridge > > Do

[ovs-dev] [PATCH branch-2.7 2/2] NEWS: Describe libopenvswitch-X.Y change.

The previous commit renamed libopenvswitch-X to libopenvswitch-X.Y to allow ABI breakage to be expressed through libtool numbering. Document this change. Signed-off-by: Joe Stringer --- NEWS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/NEWS b/NEWS index

[ovs-dev] [PATCH branch-2.7 1/2] libopenvswitch: Rename to libfoo-X.Y.

The current intent for Open vSwitch is to maintain libopenvswitch ABI stability for minor versions, for example each release within the 2.7.z series. According to the following documentation, no changes to exported headers should be made.

Re: [ovs-dev] [RFC 0/2] Rename libopenvswitch to include MAJOR.MINOR number.

On 4 May 2017 at 13:14, Ben Pfaff wrote: > On Wed, Apr 26, 2017 at 04:08:01PM -0700, Joe Stringer wrote: >> I have recently been looking into backporting a fix for variable-length >> metadata fields from master to branch-2.7. Unfortunately, the fix makes >> several >> changes to

Re: [ovs-dev] [RFC] packets: Do not initialize ct_orig_tuple.

On 5/17/17, 2:19 PM, "Joe Stringer" wrote: On 16 May 2017 at 21:01, Darrell Ball wrote: > > > On 5/15/17, 6:00 AM, "ovs-dev-boun...@openvswitch.org on behalf of Bodireddy, Bhanuprakash"

[ovs-dev] [PATCH] ovn-controller: Fix log conditions for unexpected openflow messages.

Currently in pinctrl.c and ofctrl.c there are similar logic to log ignored messages, which is somehow inaccurate and confusing. For example, OFPTYPE_PACKET_IN is handled only in pinctrl.c but in ofctrl.c it is listed as expected input and not logged as "ignored" messages, while it is in fact

Re: [ovs-dev] [branch-2.7 0/4] Backport of variable length metaflow field fixes.

On 15 March 2017 at 16:01, Joe Stringer wrote: > Commit 04f48a68c428 ("ofp-actions: Fix variable length meta-flow OXMs."), on > branch-2.7 as 9554b03d6ab7, attempted to address incorrect encode and decode > of > variable length metaflow fields where the OXM/NXM encoding of the

Re: [ovs-dev] [patch_v3] tests: Native Tunneling.

On 10 May 2017 at 14:45, Darrell Ball wrote: > Add a test that checks that native tunneling flow > matching is working. The test verifies that outer L2 and L3 > flow fields populated in the overlay bridge can be > matched in the underlay bridge. > > Signed-off-by: William Tu

Re: [ovs-dev] [RFC] packets: Do not initialize ct_orig_tuple.

On 16 May 2017 at 21:01, Darrell Ball wrote: > > > On 5/15/17, 6:00 AM, "ovs-dev-boun...@openvswitch.org on behalf of Bodireddy, > Bhanuprakash" bhanuprakash.bodire...@intel.com> wrote: > > >Commit daf4d3c18da4("odp: Support

Re: [ovs-dev] [PATCH] tests: Fix timing dependency bridge - multiple bridges share a controller

On Wed, May 17, 2017 at 1:43 PM, Joe Stringer wrote: > On 17 May 2017 at 13:16, Andy Zhou wrote: >> On Wed, May 17, 2017 at 12:33 PM, Joe Stringer wrote: >>> On 17 May 2017 at 11:37, Andy Zhou wrote: Without the fix, this test

Re: [ovs-dev] [PATCH] tests: Fix timing dependency bridge - multiple bridges share a controller

On 17 May 2017 at 11:37, Andy Zhou wrote: > Without the fix, this test currently consistently fail when running > on Travis CI. Connecting to the controller can take more time than > running locally. Because the exact connecting time is variable, the > exact output should not be

Re: [ovs-dev] [PATCH] tests: Fix timing dependency bridge - multiple bridges share a controller

On 17 May 2017 at 12:09, Greg Rose wrote: > On Wed, May 17, 2017 at 11:37 AM, Andy Zhou wrote: >> Without the fix, this test currently consistently fail when running >> on Travis CI. Connecting to the controller can take more time than >> running locally.

Re: [ovs-dev] [PATCH] tests: Fix timing dependency bridge - multiple bridges share a controller

On Wed, May 17, 2017 at 11:37 AM, Andy Zhou wrote: > Without the fix, this test currently consistently fail when running > on Travis CI. Connecting to the controller can take more time than > running locally. Because the exact connecting time is variable, the > exact output should

Re: [ovs-dev] [PATCH] datapath-windows: Report success for conntrack actions over frags

Hi Alin, Thank you for identifying and fixing issue in fragmenatation. Acked-by: Anand Kumar Regards, Anand Kumar On 5/17/17, 6:43 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean"

[ovs-dev] [PATCH] tests: Fix timing dependency bridge - multiple bridges share a controller

Without the fix, this test currently consistently fail when running on Travis CI. Connecting to the controller can take more time than running locally. Because the exact connecting time is variable, the exact output should not be used for correctness checking. Fixes: 85c55772a453(bridge: Fix

Re: [ovs-dev] [PATCH] datapath-windows: Fix alignment in actions

Acked-by: Anand Kumar Thanks, Anand Kumar On 5/17/17, 5:57 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" wrote: Found by inspection. Signed-off-by: Alin

Re: [ovs-dev] [PATCH] datapath-windows: Fix possible null dereference in ipfragment

Thanks for identifying and fixing this. Acked-by: Anand Kumar Regards, Anand Kumar On 5/17/17, 6:54 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" wrote: Found using

Re: [ovs-dev] [PATCH] datapath-windows: Update the key after defragmentation

Acked-by: Anand Kumar kumaran...@vmware.com Thanks, Anand Kumar On 5/17/17, 6:49 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" wrote: Update the key used by the actions which follow up

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

On 17 May 2017 at 04:37, Zoltán Balogh wrote: > Hi Joe > > I started to rework my patch based on your comments and suggestions. I had > some > difficulties with the last one. Let us focus on this below. > >> >> > if (credit_counts) { >> >> > +uint64_t

[ovs-dev] [PATCH] ovn-ctl: Fix help message for option ovn-controller-priority

Signed-off-by: Han Zhou --- ovn/utilities/ovn-ctl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn/utilities/ovn-ctl b/ovn/utilities/ovn-ctl index a3bdad1..accf2ba 100755 --- a/ovn/utilities/ovn-ctl +++ b/ovn/utilities/ovn-ctl @@ -394,7 +394,7 @@

Re: [ovs-dev] [PATCH v7 2/4] datapath-windows: Add NAT module in conntrack

Hi Yin, Thanks for clarifying the comments. I will ack the next version. @Alin - will you have sometime to review the changes? Thanks, Sairam On 5/16/17, 5:11 PM, "Yin Lin" wrote: >Thanks Sai for the review! I fixed most of them and explained the remaining >ones in the

Re: [ovs-dev] [PATCH v4 3/7] dpif-netlink: Support rtnetlink port creation.

On 17 May 2017 at 09:55, Eric Garver wrote: > On Tue, May 16, 2017 at 06:16:03PM -0700, Joe Stringer wrote: >> On 7 May 2017 at 06:43, Eric Garver wrote: >> > In order to be able to add those tunnels, we need to add code to create >> > the tunnels and add them as

[ovs-dev] [PATCH 6/6] OF1.5/EXT-334 OXS/Flow Removal -2

From: Harivelam Lavanya Since FLOW_REMOVED is not supported in OF1.5 version, testing has been done by adding test case in ofproto.at. While doing make check after adding test case we are able to see OFPT_FLOW_REMOVED (OF1.5) message has sent successfully. But make

[ovs-dev] [PATCH 5/6] OF1.5/EXT-334 OXS/Flow Removal -1

From: SatyaValli OXS support for FLOW REMOVED messages Signed-off-by: Satya Valli Co-authored-by: Harivelam Lavanya --- include/openflow/openflow-1.5.h | 11 +++ include/openvswitch/ofp-msgs.h | 3 +++

[ovs-dev] [PATCH 4/6] OF1.5/EXT-334 OXS/Aggregate Flow Statistics -2

From: Muttamsetty surya Signed-off-by: Muttamsetty Surya Co-authored-by: Satya Valli --- lib/ofp-util.c | 18 ++- lib/ox-stat.c | 166 +

[ovs-dev] [PATCH 3/6] OF1.5/EXT-334 OXS/Aggregate Flow Statistics -1

From: SatyaValli OXS support Aggregate Multipart Statistiscs Signed-off-by: Satya Valli Co-authored-by: Muttamsetty Surya --- include/openvswitch/ofp-msgs.h | 6 ++ lib/ofp-print.c| 6 ++

Re: [ovs-dev] [PATCH v4 3/7] dpif-netlink: Support rtnetlink port creation.

On Tue, May 16, 2017 at 06:16:03PM -0700, Joe Stringer wrote: > On 7 May 2017 at 06:43, Eric Garver wrote: > > In order to be able to add those tunnels, we need to add code to create > > the tunnels and add them as NETDEV vports. And when there is no support > > to create them, we

[ovs-dev] [PATCH 2/6] OF1.5/EXT-334 OXS/Individal Flow Statistics -2

From: Harivelam Lavanya Changes in ofproto.at and ofproto-dpif.at :- For 1.5 version "flags" variable has been removed from flow_stats_reply structure. For avoiding the make check failures for OF1.5 version add-flow with flags, below test cases has been modified

[ovs-dev] [PATCH 1/6] OF1.5/EXT-334 OXS/Individal Flow Statistics -1

From: SatyaValli OpenFlow 1.5 introduces the Extensible Statistics (OXS) by redefining the existing flow entry statistics with OXS Fields. This Patch provides implementation for OXS fields encoding in TLV format. To support this implementation below two messages are

Re: [ovs-dev] [bug] failed to add ovs bridge

Do you still see failures when the Linux bridge is not involved at all? On Wed, May 17, 2017 at 03:52:54AM +, fukaige wrote: > I start a vm with its backend tap device "vnet0" attached to a Linux bridge, > then delete the bridge and vm. > Next time, vm will start failed. this is as expected.

[ovs-dev] [PATCH] Supporting ovn-northd service HA depend on OVNDB-HA

From: Zhengwei Gao As ovn-northd servcie parse network element between ovnnb_db and ovnsb_db, it ensures ovn-northd service connecting to ovnnb_db and ovnsb_db. OVNDB-HA was supported with pacemaker, ovn-northd service will be failover fllowing OVNDB-HA. --- This was posted

Re: [ovs-dev] [PATCH v2 1/3] netdev-dpdk: Fix double attaching of virtual devices.

On 5/17/17, 4:16 AM, "Ilya Maximets" wrote: On 17.05.2017 08:53, Ilya Maximets wrote: > Hi Darrell, > > Good catch. Thanks. One comment inline. > > Best regards, Ilya Maximets. > > On 16.05.2017 20:14, Darrell Ball wrote: >> I

Re: [ovs-dev] [PATCH 3/3] netdev-dpdk: Use uint8_t for port_id.

I guess, we need some more opinions about this. My comments inline. Best regards, Ilya Maximets. On 13.05.2017 07:00, Darrell Ball wrote: > > > On 5/12/17, 8:04 AM, "Ilya Maximets" wrote: > > On 05.04.2017 22:34, Darrell Ball wrote: > > > > > > On

[ovs-dev] [PATCH v3 3/3] netdev-dpdk: Use uint8_t for port_id.

Currently, signed integer is used for 'port_id' variable and '-1' as identifier of bad or uninitialized 'port_id'. This inconsistent with dpdk library and, also, in few cases, leads to passing '-1' to dpdk functions where uint8_t expected. Such behaviour doesn't produce any issues, but it's

[ovs-dev] [PATCH v3 2/3] netdev-dpdk: Fix device leak on port deletion.

Currently, once created device in dpdk will exist forever even after del-port operation untill we manually call 'ovs-appctl netdev-dpdk/detach ', where is not the port's name but the name of dpdk eth device or pci address. Few issues with current implementation: 1. Different API for

[ovs-dev] [PATCH v3 1/3] netdev-dpdk: Fix double attaching of virtual devices.

'devargs' for virtual devices contains not only name but also a list of arguments like this: 'net_pcap0,rx_pcap=file_rx.pcap,tx_pcap=file_tx.pcap' or 'eth_af_packet0,iface=eth0' We must cut off the arguments from this string before calling 'rte_eth_dev_get_port_by_name()'

[ovs-dev] [PATCH v3 0/3] Hotplug fixes & port_id refactoring

Version 3: * 1st patch: Fixed memory leak on error path. (Darrell Ball) (bad initial patch split) * Discussion about patch #3 goes in replies to v1. Re-sent for now (rebased on modified patch #1). Version 2: * 1st patch: 'index' --> 'strcspn'

[ovs-dev] [PATCH] datapath-windows: Fix possible null dereference in ipfragment

Found using static analysis tools. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/IpFragment.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath-windows/ovsext/IpFragment.c b/datapath-windows/ovsext/IpFragment.c index

[ovs-dev] [PATCH] datapath-windows: Update the key after defragmentation

Update the key used by the actions which follow up defragmentation, with no fragment set in the IP header. Found while testing OVN with two VMs on the same host. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Actions.c | 1 + 1 file changed, 1

[ovs-dev] [PATCH] datapath-windows: Report success for conntrack actions over frags

When a conntrack action is applied over an IP fragment we pend the fragment which will be consumed later. This should be transparent to the userspace. Report that the action was applied successfully so it does not spam the ovs-vswitchd log. Signed-off-by: Alin Gabriel Serdean

[ovs-dev] [PATCH] datapath-windows: Fix alignment in actions

Found by inspection. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Actions.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/datapath-windows/ovsext/Actions.c b/datapath-windows/ovsext/Actions.c

Re: [ovs-dev] [PATCH v2] datapath-windows: Set Version correctly for OVSExt

Just one small nit if you want to fix it (but not necessarily needed): no newline at the end of file. This is because editing the file via the GUI strips down eol. Acked-by: Alin Gabriel Serdean > -Original Message- > From:

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

Hi Joe I started to rework my patch based on your comments and suggestions. I had some difficulties with the last one. Let us focus on this below. > >> > if (credit_counts) { > >> > +uint64_t stats_n_bytes = 0; > >> > + > >> > +if (rule->truncated_packet_size) { > >> > +

Re: [ovs-dev] [PATCH v2 1/3] netdev-dpdk: Fix double attaching of virtual devices.

On 17.05.2017 08:53, Ilya Maximets wrote: > Hi Darrell, > > Good catch. Thanks. One comment inline. > > Best regards, Ilya Maximets. > > On 16.05.2017 20:14, Darrell Ball wrote: >> I applied the following incremental to fix a missing free on error, but >> otherwise is fine >> Can you fold in

[ovs-dev] Out-of-order packets when using userplance ovs with dpdkr interface

Hi, I have a simple setup in one machine and use userplane OVS-2.7 with DPDK-16.11.1. 27afd0dc-cdac-4bb4-947c-65e13df66e99 Bridge "br0" Controller "tcp:10.1.2.2" is_connected: true fail_mode: secure Port "dpdkr2" Interface "dpdkr2"

Re: [ovs-dev] [PATCH] dpif-netdev: Fix insertion probability

On 05/17/2017 09:28 AM, Ciara Loftus wrote: > emc_conditional_insert uses pmd->last_cycles and the packet's RSS hash > to generate a random number used to determine whether or not an emc > entry should be inserted. This works for single-packet bursts as > last_cycles is updated for each burst.

Re: [ovs-dev] [PATCH v2 1/3] netdev-dpdk: Fix Rx checksum reconfigure.

Regards _Sugesh > -Original Message- > From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Wednesday, May 17, 2017 10:10 AM > To: Chandran, Sugesh > Cc: d...@openvswitch.org > Subject: Re: [PATCH v2 1/3] netdev-dpdk: Fix Rx checksum reconfigure. > > On

Re: [ovs-dev] [PATCH 4.4-only] openvswitch: clear sender cpu before forwarding packets

On 17/05/17 09:19, Greg KH wrote: Why is this a non-upstream patch? What commit in Linus's tree fixed this? Why not just backport that? thanks, greg k-h Agreed, I think it is sensible to backport 52bd2d62ce67 "net: better skb->sender_cpu and skb->napi_id cohabitation" to 4.4, rather than

[ovs-dev] Invitation: Good morning, @ Wed May 17, 2017 5:30am - 6:30am (EDT) (d...@openvswitch.org)

You have been invited to the following event. Title: Good morning, Good morning, I hope you are fine today? I don't know if you might be interested in a business proposal which am about to reveal to you considering that we haven't met in person. Its all about US$(Ten Million, One Hundred

Re: [ovs-dev] [PATCH v2 1/3] netdev-dpdk: Fix Rx checksum reconfigure.

On 05/16/2017 05:48 PM, Chandran, Sugesh wrote: > Hi Kevin, > Thank you for sending out this patch series. > Have you tested the tunneling decap usecase with checksum offload? I am > seeing weird behavior when I testing the tunneling with Rx checksum offload > ON and OFF.(Seeing the same

Re: [ovs-dev] [PATCH 4.4-only] openvswitch: clear sender cpu before forwarding packets

On Tue, May 16, 2017 at 03:25:10PM +0100, Anoob Soman wrote: > Similar to commit c29390c6dfee ("xps: must clear sender_cpu before > forwarding") the skb->sender_cpu needs to be cleared before forwarding > packets. > > Fixes: 2bd82484bb4c ("xps: fix xps for stacked devices") > Signed-off-by: Anoob

[ovs-dev] [PATCH v2] ovn: increase size of ingress and egress pipelines

The OVN ingress pipeline for a logical switch is maxed out at 16 stages. This patch takes the simple approach of starting the ingress pipeline at table 8 rather than table 16, and starting the egress pipeline at table 40 rather than table 48. v1->v2: Bumped range of Logical_Flow.table_id column