Re: [ovs-dev] [PATCH] Supporting ovn-northd service HA depend on OVNDB-HA

Hi Numan, Thank you very much, I had pushed the patch new version https://github.com/openvswitch/ovs/pull/178 Thanks Zhengwei multi_t...@163.com From: Numan Siddique Date: 2017-05-22 15:33 To: 高正伟 CC: Ben Pfaff; ovs dev Subject: Re: Re: [ovs-dev] [PATCH] Supporting ovn-northd service HA

Re: [ovs-dev] [PATCH 1/2] ovn pacemaker: Fix return code errors in start/stop action

On Tue, May 23, 2017 at 5:21 AM, Andy Zhou wrote: > On Sun, May 21, 2017 at 6:35 PM, wrote: > > From: Numan Siddique > > > > start action returns OCF_RUNNING_MASTER in certain scenarios. > > But as per the OCF guidelines, status code

Re: [ovs-dev] [PATCH] checkpatch: Check for stdlib usage.

On 22 May 2017 at 17:53, Ben Pfaff wrote: > On Mon, May 22, 2017 at 03:51:39PM -0700, Joe Stringer wrote: >> Many standard library functions are wrapped in OVS, so check for usage >> of the original versions and suggest that authors replace them with the >> OVS versions. >> >>

Re: [ovs-dev] [PATCH] checkpatch: Check for stdlib usage.

On Mon, May 22, 2017 at 03:51:39PM -0700, Joe Stringer wrote: > Many standard library functions are wrapped in OVS, so check for usage > of the original versions and suggest that authors replace them with the > OVS versions. > > Signed-off-by: Joe Stringer Thanks for working to

Re: [ovs-dev] [PATCH] checkpatch: Check for stdlib usage.

On Mon, 2017-05-22 at 15:51 -0700, Joe Stringer wrote: > Many standard library functions are wrapped in OVS, so check for usage > of the original versions and suggest that authors replace them with the > OVS versions. > > Signed-off-by: Joe Stringer > --- > utilities/checkpatch.py

Re: [ovs-dev] [PATCH 1/2] ovn pacemaker: Fix return code errors in start/stop action

On Sun, May 21, 2017 at 6:35 PM, wrote: > From: Numan Siddique > > start action returns OCF_RUNNING_MASTER in certain scenarios. > But as per the OCF guidelines, status code OCF_RUNNING_MASTER shoud > be returned only in monitor action [1]. > > Whenever

Re: [ovs-dev] [PATCH 1/3] dpif-netlink-rtnl: Tidy up some code.

On 19 May 2017 at 15:47, Greg Rose wrote: > On Fri, 2017-05-19 at 13:27 -0700, Joe Stringer wrote: >> Simplify and refactor a couple of bits of code for improved readability. >> >> Signed-off-by: Joe Stringer >> --- >> lib/dpif-netlink-rtnl.c | 20

Re: [ovs-dev] [patch_v1] flow.c: refactor ct_orig_tuple check in miniflow_extract.

On 20 May 2017 at 11:09, Darrell Ball wrote: > The checks to populate ct_orig_tuple in miniflow_extract > includes recirc_id being non-zero. This is changed here > to populate the ct_orig_tuple fields based only on ct_state > per the logic of the design. > > Signed-off-by:

Re: [ovs-dev] [PATCH] tests: fix hanging test on windows

On 22 May 2017 at 05:18, Alin Serdean wrote: > 'multiple bridges share a controller' hangs on windows because it is > lacking the exit information (it will hang when the test has finished) > > Introduce a pidfile to 'ovs-testcontroller' and end it on exit based on

[ovs-dev] [PATCH] checkpatch: Check for stdlib usage.

Many standard library functions are wrapped in OVS, so check for usage of the original versions and suggest that authors replace them with the OVS versions. Signed-off-by: Joe Stringer --- utilities/checkpatch.py | 31 +++ 1 file changed, 31

[ovs-dev] Oakley Sunglass Warehouse

From: Oakley Sunglass Warehouse Email: ovs-dev@openvswitch.org -- Hi It's our birthday and we are celebrating 2 years of our outlet. We'd like to offer you only 19.95 USD for all styles of Oakley and Ray Ban Sunglasses. Please visit our

Re: [ovs-dev] [PATCH 3/3] dpif-netlink-rtnl: Use OVS_NOT_REACHED in verify.

On Fri, May 19, 2017 at 01:27:36PM -0700, Joe Stringer wrote: > The vport_type_to_kind() call at the top of dpif_netlink_rtnl_verify() > ensures that these cases can never be hit, so use OVS_NOT_REACHED() > instead of setting the err to EOPNOTSUPP. > > Signed-off-by: Joe Stringer >

Re: [ovs-dev] [PATCH 2/3] dpif-netlink-rtnl: Use getlink() in common verify path.

On Fri, May 19, 2017 at 01:27:35PM -0700, Joe Stringer wrote: > The calls here were duplicated across each tunnel protocol. > > Signed-off-by: Joe Stringer > --- > lib/dpif-netlink-rtnl.c | 100 > +--- > 1 file changed, 43

Re: [ovs-dev] [PATCH 1/3] dpif-netlink-rtnl: Tidy up some code.

On Fri, May 19, 2017 at 01:27:34PM -0700, Joe Stringer wrote: > Simplify and refactor a couple of bits of code for improved readability. > > Signed-off-by: Joe Stringer > --- > lib/dpif-netlink-rtnl.c | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) >

Re: [ovs-dev] [PATCH] Debian: Install libraries in Multi-Arch format

Pleas don’t apply this. It turns out more work is required. —Ben > On May 18, 2017, at 4:49 PM, b...@skyportsystems.com wrote: > > From: Ben Warren > > The Debian 'Multi-Arch' feature moves all library files (*.a, *.so) to > an architecture-specific directory. This

Re: [ovs-dev] [RFC PATCH 0/6] Change dpdk rxq scheduling to incorporate rxq processing cycles.

>> Thanks for working on this. This work is important and would also solve OvS- >DPDK scaling issue. >> I have reviewed the patch series but haven't tested this yet with traffic. I >would stick to comments on high level design at his stage. >> >> With this series, rxqs are sorted based on cycles

Re: [ovs-dev] [RFC PATCH 0/6] Change dpdk rxq scheduling to incorporate rxq processing cycles.

Hi Kevin, Thanks a lot for addressing this very important limitation of OVS-DPDK multi-core scalability in cloud contexts such as OpenStack. This is highly appreciated! We have not started testing this, so for the time being just some high-level comments: I would really like to see a new

Re: [ovs-dev] [PATCH] dpif-netdev: Fix insertion probability

Thanks for the fix: Acked-by: Jan Scheurich > -Original Message- > From: ovs-dev-boun...@openvswitch.org > [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Ciara Loftus > Sent: Wednesday, 17 May, 2017 10:29 > To: d...@openvswitch.org > Subject: [ovs-dev]

Re: [ovs-dev] [PATCH v6 5/5] userspace: add vxlan gpe support to vport

I had a similar comment to avoid bit-fields in the nsh_hdr struct in the NSH patch series. @Yi: Have a look at the restructured nsh.h in my new branch. I suggest you just add any required vxlan-gpe specific items to the VXLAN section in lib/packets.h rather than creating a new header file for

Re: [ovs-dev] [PATCH v6 4/5] ofproto-dpif-xlate: refactor compose_output_action__

Thanks for merging this! I do agree that we should continue to try to simplify this further. Perhaps we can have a look at it in the new attempt to upstream our previously reverted patch to avoid recirculation at TX to tunnel port, which refactors some of the patch-port ("output to peer")

Re: [ovs-dev] [PATCH v2] netflow: Fix memory leak in netflow_unref.

On Mon, 2017-05-22 at 12:55 +0800, Yunjian Wang wrote: > The memory leak was triggered each time on calling netflow_unref() with > containing netflow_flows. And flows need to be removed and destroyed. > > Signed-off-by: Yunjian Wang > --- > ofproto/netflow.c | 7 +++

Re: [ovs-dev] [PATCH v6 2/5] userspace: L3 tunnel support for GRE and LISP

> I think that parse_gre_header() should perhaps be pickier about the > Ethertypes it accepts, since values below 0x600 are not valid > Ethertypes and sometimes they are used for special purposes, for example > OpenFlow uses 0x5ff to mean that the frame lacks an Ethertype. I agree. OVS could just

Re: [ovs-dev] [RFC PATCH 0/6] Change dpdk rxq scheduling to incorporate rxq processing cycles.

Hi Bhanu, On 05/21/2017 10:25 PM, Bodireddy, Bhanuprakash wrote: > Hello Kevin, > >> >> Rxqs are scheduled to be handled across available pmds in round robin order >> with no weight or priority. >> >> It can happen that some very busy queues are handled by one pmd which >> does not have enough

[ovs-dev] [PATCH] tests: fix hanging test on windows

'multiple bridges share a controller' hangs on windows because it is lacking the exit information (it will hang when the test has finished) Introduce a pidfile to 'ovs-testcontroller' and end it on exit based on the pidfile. Signed-off-by: Alin Gabriel Serdean

[ovs-dev] [PATCH v3 3/3] build-windows: cccl fail compilation on Wimplicit-function-declaration

From: Alin Serdean Gcc compiler argument -Wall contains -Wimplicit-function-declaration which gives warnings when a function is used before declared. Map VStudio compiler error C4013 to it. More info on C4013:

[ovs-dev] [PATCH v3 1/3] windows: add definition of getpid and getcwd

From: Alin Serdean getcwd - is used in lib/util.c. getcwd is deprecated on Windows but has _getcwd which is defined in : https://msdn.microsoft.com/en-us/library/sf98bd4y(v=vs.120).aspx getpid - is used in several files (i.e. lib/vlog.c). getpid is also and

[ovs-dev] [PATCH v3 2/3] windows: add includes to daemon-windows

From: Alin Serdean Add fatal-signal.h include since it uses: fatal_signal_atexit_handler and fatal_signal_add_hook Use the defined getpid() function and also include since it is defined in include/windows/unistd.h . Signed-off-by: Alin Gabriel Serdean

[ovs-dev] Fwd: [PATCH] bfd: Detect Multiplier configuration

Hi, hereby I'm sending an implementation of configurable BFD Detect Multiplier. Mult value (bfd.DetectMult in RFC5880) is hard-coded and equal to 3 in current openvswitch. As a consequence remote and local mult is the same. In this commit the mult (Detect Multiplier/bfd.DetectMult/Detect Mult)

[ovs-dev] [PATCH] ovn-northd: Fix ping failure of vlan networks.

There are two computer node, each have one vm. And the two vms in indifferent vlan networks. The ping between the vms is not success. The reason is that, acl of to-localnet port or from-localnet port is signed to contrack. So the pair of icmp request and reply have different zone id in one ovs

[ovs-dev] Viable partnership request.

Compliment of the day, I have access to very vital information that can be used to move a huge amount of money. I have done my homework very well and i have the machineries in place to get it done. Ultimately I need an honest person to play an important role in the completion of this

Re: [ovs-dev] [PATCH] Supporting ovn-northd service HA depend on OVNDB-HA

On Fri, May 19, 2017 at 7:21 AM, 高正伟 wrote: > Thanks Numan > > I think that supporting OVNDB and ovn-northd HA depend on one pacemaker > is an idea, In case of thinking OVN-HA, user will not individually care > about OVNDB or ovn-northd HA. > > Hi Zhangwei, I do agree