[ovs-dev] [PATCH] patch: Check the right variable for null.

This function tried to check 'iface_peer' for null, but it actually checked its always-nonnull 'peer' argument instead. This fixes the problem. Found by Coverity. Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14763064=4305294=179852 Signed-off-by: Ben Pfaff

Re: [ovs-dev] [PATCH] ofproto: Use shash_find_and_delete() in ofport_destroy__().

On Fri, May 26, 2017 at 10:50:52PM -0700, Ben Pfaff wrote: > This is shorter and slightly safer than combining calls to shash_find() > and shash_delete(). > > Found by Coverity. > > Reported-at: > https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14762983=4305289=179850 >

[ovs-dev] [PATCH v2] ofproto: Use shash_find_and_delete() in ofport_destroy__().

This is shorter and slightly safer than combining calls to shash_find() and shash_delete(). Found by Coverity. Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14762983=4305289=179850 Signed-off-by: Ben Pfaff --- v1->v2: Fix build error.

[ovs-dev] [PATCH] ofproto: Use shash_find_and_delete() in ofport_destroy__().

This is shorter and slightly safer than combining calls to shash_find() and shash_delete(). Found by Coverity. Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14762983=4305289=179850 Signed-off-by: Ben Pfaff --- ofproto/ofproto.c | 3 +-- 1 file

[ovs-dev] null deref in build_ipam?

Coverity points out the following code in build_ipam() in ovn-northd.c: if (is_dynamic_lsp_address(nbsp->addresses[j]) && !nbsp->dynamic_addresses) { if (!ipam_allocate_addresses(od, op, nbsp->addresses[j]) ||

[ovs-dev] [PATCH] ovn-northd: Avoid null deref for missing outport in build_static_route_flow().

Found by Coverity. Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14763080=4305186=179788 Signed-off-by: Ben Pfaff --- ovn/northd/ovn-northd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn/northd/ovn-northd.c

[ovs-dev] [PATCH] meta-flow: Remove dead condition in mf_set().

mf_set() always takes a nonnull mask, but the MFF_CT_LABEL case checked whether it was nonnull. Found by Coverity. Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14762941=4304057=179568 Signed-off-by: Ben Pfaff --- lib/meta-flow.c | 2 +- 1 file

[ovs-dev] revalidate_ukey__() and netflow

Coverity says that, in this test at the end of revalidate_ukey__(), 'netflow' is always NULL: if (netflow && result == UKEY_DELETE) { netflow_flow_clear(netflow, ); } I suspect that it is right. This is from

Re: [ovs-dev] [PATCH] ofproto-dpif-ipfix: Fix severe memory leak in ipfix_send_template_msgs().

On Fri, May 26, 2017 at 09:14:21PM -0700, Ben Pfaff wrote: > This fixes a seemingly severe memory leak in ipfix_send_template_msgs(). > This function was setting up a buffer with a stub, but only the first 4 > or 8 bytes of the stub were actually used because the "sizeof" call used > to size it

[ovs-dev] [PATCH] ovsdb-client: Use correct operand to 'sizeof' in do_dump().

When copying an object, one must calculate the size of the object itself, not of its address. No visible effect, though, since both the object and its address are pointers in this case. Found by Coverity. Reported-at:

[ovs-dev] [PATCH] test-cmap: Avoid shift by full width of type in find_batch().

In C, it is undefined to shift an N-bit value by N. This fixes the problem in find_batch() for the case where i == 0. Found by Coverity. Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14763098=4304031=68209 Signed-off-by: Ben Pfaff ---

[ovs-dev] [PATCH] ovn: Fix encoding of large logical output ports for STT.

put_encapsulation() is meant to load the logical output port into bits 24 to 40 of the tunnel ID metadata field, but 'outport << 24' did not have that effect because outport has type uint16_t. This fixes the problem. Found by Coverity. Reported-at:

[ovs-dev] [PATCH] ofproto-dpif-ipfix: Fix severe memory leak in ipfix_send_template_msgs().

This fixes a seemingly severe memory leak in ipfix_send_template_msgs(). This function was setting up a buffer with a stub, but only the first 4 or 8 bytes of the stub were actually used because the "sizeof" call used to size it was actually getting the size of a pointer. It never freed the

[ovs-dev] [PATCH] extract-ofp-errors: Avoid unintentional sign extension in generated code.

Code generated by this program includes constructs like this: switch (((uint64_t) vendor << 32) | (type << 16) | code) with variables uint32_t vendor, uint16_t type, uint16_t code. By C rules, "type << 16" has type "int", which means that it will be sign-extended to 64 bits when ORed with

[ovs-dev] [PATCH] ovsdb: Check null before deref in ovsdb_monitor_table_condition_update().

I believe that this would trigger an ovsdb-server crash if a client created a plain RFC 7047 "monitor" and later attempted to update its condition. Found by Coverity. Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14763017=4305336=180412 Signed-off-by: Ben

[ovs-dev] [PATCH 2/2] xlate: Use datapath clone action for patch port translation

When available, use datapath 'clone' for patch port translation. Clone provides a stronger guarantee that packet will be restored after going through a patch port, Even in case the packet is NAT'd by the bridge behind the patch port. Signed-off-by: Andy Zhou ---

[ovs-dev] [PATCH 1/2] xlate: Add datapath clone generation API

There are three methods of translating openflow layer clone action. Using datapath clone action, datapath sample action or using actions to negating the any changes within a clone. Xlate logic selects a specific method depends on datapath features detected at the boot time. Currently only

[ovs-dev] [PATCH] ovn-nbctl, ovn-sbctl, ovs-vsctl: Remove gratuitous NULL checks.

These functions all set txn and do not un-set it within their main command execution function, so it's gratuitous to check it along this path. Found by Coverity. Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14763082=4305338=180417 Signed-off-by: Ben Pfaff

[ovs-dev] [PATCH] ofp-util: Mask config value as intended in ofputil_decode_port_mod().

The code in ofputil_decode_port_mod() was originally meant to mask the returned 'config' value against 'mask'. That is, only bits that are marked in 'mask' as to be modified can be set to 1-bits in the returned 'config' value; it doesn't really entirely make sense otherwise. The actual code to

[ovs-dev] [PATCH] ofp-util: Remove dead code from ofputil_encode_get_async_reply().

Found by Coverity. Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14762682=4304823=180423 Signed-off-by: Ben Pfaff --- lib/ofp-util.c | 4 1 file changed, 4 deletions(-) diff --git a/lib/ofp-util.c b/lib/ofp-util.c index

[ovs-dev] [PATCH] dpif-netlink: Fix multiple-free and fd leak on error path.

This function attempts to open a bunch of new handlers. If it fails, it attempts to close all the handlers that have already been opened. Unfortunately, the loop to close the opened handlers used the wrong array index: 'i' instead of 'j'. This fixes the problem. Found by Coverity. Reported-at:

[ovs-dev] [PATCH] ovs-lldp: Remove dead store to TTL configuration.

Apparently this has always used LLDP_CHASSIS_TTL as a fixed TTL, so we might as well delete the statement just before that tries to dynamically calculate it. Found by Coverity. CC: Dennis Flynn Reported-at:

[ovs-dev] [PATCH] ofp-print: Avoid array overread in print_table_instruction_features().

If a switch claimed to support an instruction that OVS does not know about, then print_table_instruction_features() would read past the end of the array of instruction names. This fixes the problem. None of the other uses of print_table_instruction_features() appear to have the same problem.

Re: [ovs-dev] [PATCH v3] Replace most uses of and references to "ifconfig" by "ip".

On Fri, May 26, 2017 at 11:46 PM, Ben Pfaff wrote: > It's becoming more common that OSes include "ip" but not "ifconfig", so > it's best to avoid using the latter. This commit removes most references > to "ifconfig" and replaces them by "ip". It also adds a build-time check > to

Re: [ovs-dev] [RFC PATCH v2 0/1] netdev-dpdk: multi-segment mbuf jumbo frame support

Hi Sugesh, The reason should be the code base has been changed, some new patches has been merged I think. 2017/5/27 3:06, Chandran, Sugesh : Hi Mark, Thank you for working on this! For some reason it was failing for me while trying to apply the first set of patches from Michael. I tried

Re: [ovs-dev] [PATCH v2] netflow: Fix memory leak in netflow_unref.

> -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Greg Rose > Sent: Friday, May 26, 2017 11:51 PM > To: ovs-dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v2] netflow: Fix memory leak in > netflow_unref. > > On

[ovs-dev] 答复: 答复: Query for missing function

Hi Darrell, I indeed observed IP fragment scenario in our other product deployment, and resulted some critical issue. Then I am wondering how to handle it in OVS+DPDK alternative solution. Typical cases are: 1) VxLan segmented packet reaches Vswitch and need to pop the VxLan header for

[ovs-dev] [PATCH] flow: Fix buffer overread in flow_hash_symmetric_l3l4().

IPv6 addresses have 2 64-bit parts, but this code thought they have 4. Found by Coverity. Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14762918=4304099=179866 Signed-off-by: Ben Pfaff --- lib/flow.c | 2 +- 1 file changed, 1 insertion(+), 1

[ovs-dev] [PATCH] ofp-actions: Fix memory leak on error path in parse_CT().

Found by Coverity. Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14762959=4305310=180392 Signed-off-by: Ben Pfaff --- lib/ofp-actions.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c

[ovs-dev] [PATCH] ofp-parse: Fix memory leak on error path in parse_ofp_group_mod_file().

Found by Coverity. Reported-by: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14762655=4305334=180394 Signed-off-by: Ben Pfaff --- lib/ofp-parse.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/ofp-parse.c b/lib/ofp-parse.c

[ovs-dev] [PATCH] actions: Fix memory leak on error path in parse_ct_lb_action().

Found by Coverity. Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14763031=4305318=180399 Signed-off-by: Ben Pfaff --- ovn/lib/actions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ovn/lib/actions.c b/ovn/lib/actions.c index

[ovs-dev] [PATCH] test-packets: Check that ipv6_parse_masked() is successful.

Otherwise it returns an allocated string that we should print and free. Found by Coverity. Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14763114=4305332=180408 Signed-off-by: Ben Pfaff --- tests/test-packets.c | 10 +- 1 file changed,

[ovs-dev] [PATCH] bridge: Fix memory leak in bridge_aa_update_trunks().

Found by Coverity. Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14763131=4305313=180411 Signed-off-by: Ben Pfaff --- vswitchd/bridge.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c index

[ovs-dev] [PATCH] ovs-ofctl: Close pcap file at end of ofctl_ofp_parse_pcap().

Seem wise even if not mandatory. Found by Coverity. Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14763047=4305314=180420 Signed-off-by: Ben Pfaff --- utilities/ovs-ofctl.c | 1 + 1 file changed, 1 insertion(+) diff --git

[ovs-dev] [PATCH] ovn-northd: Fix uninitialized reference in build_static_route_flow().

It was apparently possible for lrp_addr_s to be uninitialized in a logical router with no ports. Found by Coverity. Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14763080=4304818=180426 Signed-off-by: Ben Pfaff --- ovn/northd/ovn-northd.c | 2

[ovs-dev] [PATCH] dpif-netdev: Fix use-after-free error in reconfigure_datapath().

Found by Coverity. Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14762915=4305352=180430 Signed-off-by: Ben Pfaff --- lib/dpif-netdev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/dpif-netdev.c

Re: [ovs-dev] [PATCH] packets: Remove unnecessary "packed" annotations.

On 25 May 2017 at 13:52, Ben Pfaff wrote: > I know of two reasons to mark a structure as "packed". The first is > because the structure must match some defined interface and therefore > compiler-inserted padding between or after members would cause its layout > to diverge from that

Re: [ovs-dev] [PATCH 2/2] faq: Expand on answer about OVS meter action support

On Fri, May 26, 2017 at 11:41 AM, Ben Pfaff wrote: > On Fri, May 26, 2017 at 11:36:53AM -0700, Andy Zhou wrote: >> Signed-off-by: Andy Zhou > > For both: > Acked-by: Ben Pfaff > > Thank you! Thanks Ben. Pushed to master.

Re: [ovs-dev] [PATCH] checkpatch: Be more careful about checking function names.

On 26 May 2017 at 11:32, Ben Pfaff wrote: > This code would complain about the use of ovs_strerror because it > matches [^x]strerror, and the same was true in many other similar cases. > > Signed-off-by: Ben Pfaff Ah, good catch. I think this will match on mentions

[ovs-dev] [PATCH] ofp-print: Don't abort on unknown reason in role status message.

A buggy or malicious switch could send a role status message with a bad reason code, which if printed by OVS would cause it to abort. This fixes the problem. Reported-by: Bhargava Shastry Signed-off-by: Ben Pfaff --- lib/ofp-print.c | 3 ++- 1

[ovs-dev] [PATCH] ofp-util: Check length of buckets in ofputil_pull_ofp15_group_mod().

This code blindly read forward for the number of bytes specified by the message without checking that it was in range. This bug is part of OpenFlow 1.5 support. Open vSwitch does not enable OpenFlow 1.5 support by default. Reported-by: Bhargava Shastry

Re: [ovs-dev] [RFC PATCH v2 1/1] netdev-dpdk: enable multi-segment jumbo frames

Regards _Sugesh > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Mark Kavanagh > Sent: Monday, May 15, 2017 11:17 AM > To: ovs-dev@openvswitch.org; qiud...@chinac.com > Subject: [ovs-dev] [RFC PATCH v2 1/1]

Re: [ovs-dev] [RFC PATCH v2 0/1] netdev-dpdk: multi-segment mbuf jumbo frame support

Hi Mark, Thank you for working on this! For some reason it was failing for me while trying to apply the first set of patches from Michael. I tried the latest patches from the patchwork. Here are few high level comments as below. Regards _Sugesh > -Original Message- > From:

Re: [ovs-dev] 答复: Query for missing function

On 5/26/17, 2:00 AM, "王志克" wrote: Hi Darrell, Ben, Thanks for your reply. Glad to hear that we are approaching useful candidate patch. What is the plan for disassemble and fragment for OVS+DPDK? Like 1, received underlay vxlan fragmented packets,

Re: [ovs-dev] [PATCH 2/2] faq: Expand on answer about OVS meter action support

On Fri, May 26, 2017 at 11:36:53AM -0700, Andy Zhou wrote: > Signed-off-by: Andy Zhou For both: Acked-by: Ben Pfaff Thank you! ___ dev mailing list d...@openvswitch.org

[ovs-dev] [PATCH 2/2] faq: Expand on answer about OVS meter action support

Signed-off-by: Andy Zhou --- Documentation/faq/qos.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/faq/qos.rst b/Documentation/faq/qos.rst index 65a14eb9f3b2..ad3d95bf4fc0 100644 --- a/Documentation/faq/qos.rst +++

[ovs-dev] [PATCH 1/2] news: Add userspace meter action support.

Signed-off-by: Andy Zhou --- NEWS | 1 + 1 file changed, 1 insertion(+) diff --git a/NEWS b/NEWS index 25eb477a8910..1c3035145724 100644 --- a/NEWS +++ b/NEWS @@ -94,6 +94,7 @@ v2.7.0 - 21 Feb 2017 * The "sample" action now supports "ingress" and "egress" options. *

[ovs-dev] [PATCH] checkpatch: Be more careful about checking function names.

This code would complain about the use of ovs_strerror because it matches [^x]strerror, and the same was true in many other similar cases. Signed-off-by: Ben Pfaff --- utilities/checkpatch.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[ovs-dev] [PATCH] checkpatch: Also check switch, HMAP_FOR_EACH, etc.

The switch statement and our FOR_EACH macro iteration constructs have the same rules as if, for, and while. Signed-off-by: Ben Pfaff --- utilities/checkpatch.py | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/utilities/checkpatch.py

Re: [ovs-dev] [PATCH] ofproto-dpif: Include EthType in ct_orig_tuple feature probe

On 24 May 2017 at 23:20, Sairam Venugopal wrote: > Set flow->dl_type to either ETH_TYPE_IP or ETH_TYPE_IPV6 when probing for > ct_orig_tuple feature support. This can be expanded later on to check for > both IPv4 and IPv6 support. > > Signed-off-by: Sairam Venugopal

[ovs-dev] [PATCH] checkpatch: Implement -f option more usefully.

A lot of checkpatch warnings are only enabled for particular kinds of files, e.g. C warnings only apply to C source and header files. The -f option didn't pass the file name to the code that determines what kinds of warnings to report, so only generic warnings were actually reported. This fixes

Re: [ovs-dev] [PATCH] datapath-windows: Add validations in fragmentation module

On 25 May 2017 at 16:21, Anand Kumar wrote: > - Minimum valid fragment size is 400 bytes, any fragment smaller > is likely to be intentionally crafted. This seems arbitrary and surprising. Is there some reference to argue why this is a good idea? Even if this makes sense

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

Thank you Joe for the response. Regards _Sugesh > -Original Message- > From: Joe Stringer [mailto:j...@ovn.org] > Sent: Friday, May 26, 2017 7:02 PM > To: Chandran, Sugesh > Cc: Zoltán Balogh ; Andy Zhou > ; William

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

On 26 May 2017 at 10:42, Chandran, Sugesh wrote: > > > Regards > _Sugesh > > >> -Original Message- >> From: Zoltán Balogh [mailto:zoltan.bal...@ericsson.com] >> Sent: Friday, May 26, 2017 3:01 PM >> To: Joe Stringer >> Cc: Chandran, Sugesh

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

On 26 May 2017 at 07:00, Zoltán Balogh wrote: > > Hi Joe, > >> Backing up a bit for context, the stats attribution goes roughly like this: >> * First upcall, handler thread calls through the translate code with a >> packet. The resubmit_stats are derived from that

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

Regards _Sugesh > -Original Message- > From: Zoltán Balogh [mailto:zoltan.bal...@ericsson.com] > Sent: Friday, May 26, 2017 3:01 PM > To: Joe Stringer > Cc: Chandran, Sugesh ; Andy Zhou > ; William Tu ; >

Re: [ovs-dev] [patch_v1] flow.c: refactor ct_orig_tuple check in miniflow_extract.

On 25 May 2017 at 18:53, Darrell Ball wrote: > > > On 5/22/17, 4:44 PM, "ovs-dev-boun...@openvswitch.org on behalf of Joe > Stringer" wrote: > > On 20 May 2017 at 11:09, Darrell Ball wrote: >

[ovs-dev] [OVN] SFC Day in the Life of Packet (with markdown)

At the request of several people I have put together a few use cases for day in the life of a packet for the service chain approach. I have written it up in markdown format as it is easier to review standalone (IMHO). Once everyone is happy with it I will move in to XML in

Re: [ovs-dev] [PATCH] ovn-ctl: Add commands to manage OVN DB ovsdb-servers individually

On Fri, May 26, 2017 at 4:48 AM, Numan Siddique wrote: > > > On Fri, May 26, 2017 at 3:30 AM, Andy Zhou wrote: >> >> On Thu, May 25, 2017 at 1:55 AM, wrote: >> > From: Numan Siddique >> > >> > This patch adds the

[ovs-dev] [OVN] SFC Day in the Life of Packet

At the request of several people I have put together a few use cases for day in the life of a packet for the service chain approach. I have written it up in markdown format as it is easier to review standalone (IMHO). Once everyone is happy with it I will move in to XML in

Re: [ovs-dev] [PATCH 3/4] dpif-netdev: Avoid port's reconfiguration on pmd-cpu-mask changes.

On 05/26/2017 03:55 PM, Ilya Maximets wrote: > On 10.03.2017 07:27, Daniele Di Proietto wrote: >> 2017-02-21 6:49 GMT-08:00 Ilya Maximets : >>> Reconfiguration of HW NICs may lead to packet drops. >>> In current model all physical ports will be reconfigured each >>> time

Re: [ovs-dev] [PATCH v3] Replace most uses of and references to "ifconfig" by "ip".

On Fri, 2017-05-26 at 08:46 -0700, Ben Pfaff wrote: > It's becoming more common that OSes include "ip" but not "ifconfig", so > it's best to avoid using the latter. This commit removes most references > to "ifconfig" and replaces them by "ip". It also adds a build-time check > to make it harder

Re: [ovs-dev] [PATCH v2] Replace most uses of and references to "ifconfig" by "ip".

On Fri, 2017-05-26 at 08:56 -0700, Ben Pfaff wrote: > On Fri, May 26, 2017 at 08:52:15AM -0700, Greg Rose wrote: > > On Fri, 2017-05-26 at 08:46 -0700, Ben Pfaff wrote: > > > On Fri, May 26, 2017 at 10:53:32AM -0400, Russell Bryant wrote: > > > > On Fri, May 26, 2017 at 12:49 AM, Ben Pfaff

Re: [ovs-dev] [patch_v1] flow.c: refactor ct_orig_tuple check in miniflow_extract.

On Fri, 2017-05-26 at 15:09 +, Darrell Ball wrote: > http://openvswitch.org/support/dist-docs/ovs-ofctl.8.pdf > > > “resubmit([port],[table],ct) > Re-searches this OpenFlow flow table (or the table whose number is specified > by table) > with the in_port field replaced by port (if port is

Re: [ovs-dev] [PATCH v2] Replace most uses of and references to "ifconfig" by "ip".

On Fri, May 26, 2017 at 08:52:15AM -0700, Greg Rose wrote: > On Fri, 2017-05-26 at 08:46 -0700, Ben Pfaff wrote: > > On Fri, May 26, 2017 at 10:53:32AM -0400, Russell Bryant wrote: > > > On Fri, May 26, 2017 at 12:49 AM, Ben Pfaff wrote: > > > > It's becoming more common that OSes

Re: [ovs-dev] [PATCH v2] Replace most uses of and references to "ifconfig" by "ip".

On Fri, 2017-05-26 at 08:46 -0700, Ben Pfaff wrote: > On Fri, May 26, 2017 at 10:53:32AM -0400, Russell Bryant wrote: > > On Fri, May 26, 2017 at 12:49 AM, Ben Pfaff wrote: > > > It's becoming more common that OSes include "ip" but not "ifconfig", so > > > it's best to avoid using

Re: [ovs-dev] [PATCH v2] netflow: Fix memory leak in netflow_unref.

On Thu, 2017-05-25 at 21:05 -0700, Greg Rose wrote: > On Thu, 2017-05-25 at 09:53 -0700, Greg Rose wrote: > > On Mon, 2017-05-22 at 07:40 -0700, Greg Rose wrote: > > > On Mon, 2017-05-22 at 12:55 +0800, Yunjian Wang wrote: > > > > The memory leak was triggered each time on calling netflow_unref()

Re: [ovs-dev] [PATCH v2] Replace most uses of and references to "ifconfig" by "ip".

On Fri, May 26, 2017 at 10:53:32AM -0400, Russell Bryant wrote: > On Fri, May 26, 2017 at 12:49 AM, Ben Pfaff wrote: > > It's becoming more common that OSes include "ip" but not "ifconfig", so > > it's best to avoid using the latter. This commit removes most references > > to

[ovs-dev] [PATCH v3] Replace most uses of and references to "ifconfig" by "ip".

It's becoming more common that OSes include "ip" but not "ifconfig", so it's best to avoid using the latter. This commit removes most references to "ifconfig" and replaces them by "ip". It also adds a build-time check to make it harder to introduce new uses of "ifconfig". Signed-off-by: Ben

Re: [ovs-dev] Openvswitch linux nat issue (ver 2.7.0 and linux 4.9.x)

Hi Aaron I tried the first approach and it is not working. i am able to receive the packet from LAN to veth1 but no more further So it seems iptables not applying within netns "test" Please advise Thanks On Thu, May 25, 2017 at 10:43 PM, akshay6 agarwal < akshayagarwal2...@gmail.com> wrote: >

Re: [ovs-dev] [patch_v1] flow.c: refactor ct_orig_tuple check in miniflow_extract.

http://openvswitch.org/support/dist-docs/ovs-ofctl.8.pdf “resubmit([port],[table],ct) Re-searches this OpenFlow flow table (or the table whose number is specified by table) with the in_port field replaced by port (if port is specified) and the packet 5-tuple fields swapped with the

Re: [ovs-dev] [patch_v1] flow.c: refactor ct_orig_tuple check in miniflow_extract.

On Fri, 2017-05-26 at 01:53 +, Darrell Ball wrote: > > On 5/22/17, 4:44 PM, "ovs-dev-boun...@openvswitch.org on behalf of Joe > Stringer" wrote: > > On 20 May 2017 at 11:09, Darrell Ball wrote: > > The

Re: [ovs-dev] [PATCH 3/4] dpif-netdev: Avoid port's reconfiguration on pmd-cpu-mask changes.

On 10.03.2017 07:27, Daniele Di Proietto wrote: > 2017-02-21 6:49 GMT-08:00 Ilya Maximets : >> Reconfiguration of HW NICs may lead to packet drops. >> In current model all physical ports will be reconfigured each >> time number of PMD threads changed. Since we not stopping

Re: [ovs-dev] [PATCH v2] Replace most uses of and references to "ifconfig" by "ip".

On Fri, May 26, 2017 at 12:49 AM, Ben Pfaff wrote: > It's becoming more common that OSes include "ip" but not "ifconfig", so > it's best to avoid using the latter. This commit removes most references > to "ifconfig" and replaces them by "ip". It also adds a build-time check > to

Re: [ovs-dev] [RFC PATCH] netdev-dpdk: Add Tx intermediate queue for vhost ports.

> > This commit adds the intermediate queue for vHost-user ports. It > improves the throughput in multiple virtual machines deployments and > also in cases with VM doing packet forwarding in kernel stack. > > This patch is aligned with intermediate queue implementation for dpdk > ports that can

Re: [ovs-dev] [PATCH v3] netdev-dpdk: Implement Tx intermediate queue for dpdk ports.

> > After packet classification, packets are queued in to batches depending > on the matching netdev flow. Thereafter each batch is processed to > execute the related actions. This becomes particularly inefficient if > there are few packets in each batch as rte_eth_tx_burst() incurs expensive >

Re: [ovs-dev] [PATCH v8] netdev-dpdk: Increase pmd thread priority

Hi Billy, >Hi Bhanu, > >This patch no longer applies cleanly. Thanks for looking in to this patch. It's pretty old patch and should be rebased. > >$git apply ... >error: Documentation/intro/install/dpdk-advanced.rst: No such file or >directory >error: patch failed: lib/ovs-numa.h:56 >error:

Re: [ovs-dev] [PATCH v6 2/5] userspace: L3 tunnel support for GRE and LISP

On Thu, 2017-05-25 at 09:22 -0700, Ben Pfaff wrote: > On Mon, May 22, 2017 at 01:43:25PM +, Jan Scheurich wrote: > > > I think that parse_gre_header() should perhaps be pickier about > > > the > > > Ethertypes it accepts, since values below 0x600 are not valid > > > Ethertypes and sometimes

Re: [ovs-dev] [PATCH v4] dpif-netdev: Change definitions of 'idle' & 'processing' cycles

> Instead of counting all polling cycles as processing cycles, only count > the cycles where packets were received from the polling. > > Signed-off-by: Georg Schmuecking > Signed-off-by: Ciara Loftus > Co-authored-by: Georg Schmuecking

[ovs-dev] [PATCH 1/2] docs: Clarify the superiority of dpdkvhostuserclient

Apparently dpdkvhostuser interfaces are inferior to dpdkvhostuserclient. Explain why. Signed-off-by: Stephen Finucane Cc: Ciara Loftus Cc: Kevin Traynor --- I'd like to note what happens to traffic when OVS or a VM is restarted

[ovs-dev] [PATCH 2/2] docs: Document dpdkr ports

I has an idea what these were but that idea was somewhat incorrect and out-of-date. Add a minimal guide to fill in these gaps, along with a warning about how useless these things generally are now (yay, vhost-user). Signed-off-by: Stephen Finucane Cc: Ciara Loftus

Re: [ovs-dev] [PATCH v8] netdev-dpdk: Increase pmd thread priority

On Tue, Jan 03, 2017 at 03:08:11PM -0500, Aaron Conole wrote: > Bhanuprakash Bodireddy writes: > > > Increase the DPDK pmd thread scheduling priority by lowering the nice > > value. This will advise the kernel scheduler to prioritize pmd thread > > over other

Re: [ovs-dev] [PATCH v2 1/3] netdev-dpdk: Fix Rx checksum reconfigure.

Regards _Sugesh > -Original Message- > From: Chandran, Sugesh > Sent: Wednesday, May 17, 2017 10:50 AM > To: Kevin Traynor > Cc: d...@openvswitch.org > Subject: RE: [PATCH v2 1/3] netdev-dpdk: Fix Rx checksum reconfigure. > > > > Regards > _Sugesh > > >

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

Hi Joe, > Backing up a bit for context, the stats attribution goes roughly like this: > * First upcall, handler thread calls through the translate code with a > packet. The resubmit_stats are derived from that packet. This goes > through xlate_actions(). > * First dump of flow from revalidator

Re: [ovs-dev] [PATCH v4 2/3] netdev-dpdk: Fix device leak on port deletion.

Oops the patch series is probably the reason. > -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Friday, May 26, 2017 2:51 PM > To: O Mahony, Billy ; d...@openvswitch.org; > Daniele Di Proietto ; Darrell Ball >

Re: [ovs-dev] [PATCH v4 2/3] netdev-dpdk: Fix device leak on port deletion.

On 26.05.2017 16:38, O Mahony, Billy wrote: > Hi Ilya, > > This patch does not apply to head of master, currently "c899576 > build-windows: cccl fail compilation on Wimplicit-function-declaration". Hmm. I'm able to apply it using 'git am'. Have you applied first patch of this series? > I'll

Re: [ovs-dev] [PATCH v4 2/3] netdev-dpdk: Fix device leak on port deletion.

Hi Ilya, This patch does not apply to head of master, currently "c899576 build-windows: cccl fail compilation on Wimplicit-function-declaration". I'll don't have any comments on the code right now but if you can tell me the commit it's based on I'll check it out. Thanks, Billy >

Re: [ovs-dev] [PATCH v8] netdev-dpdk: Increase pmd thread priority

Hi Bhanu, This patch no longer applies cleanly. $git apply ... error: Documentation/intro/install/dpdk-advanced.rst: No such file or directory error: patch failed: lib/ovs-numa.h:56 error: lib/ovs-numa.h: patch does not apply Also some more information on the rationale behind such a change

Re: [ovs-dev] [PATCH v4 1/3] netdev-dpdk: Fix double attaching of virtual devices.

Tested-by: Billy O'Mahony Acked-by: Billy O'Mahony > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Ilya Maximets > Sent: Friday, May 19, 2017 2:38 PM > To:

Re: [ovs-dev] [PATCH v4 3/3] netdev-dpdk: Use uint8_t for port_id.

>From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org] >On Behalf Of >Ilya Maximets >Sent: Friday, May 19, 2017 2:38 PM >To: d...@openvswitch.org; Daniele Di Proietto ; Darrell >Ball > >Cc: Ilya Maximets ;

Re: [ovs-dev] [PATCH v4] OVN localport type support

Hi Ben, Thanks for proposing this optimization. I've tried it and it works. These flows are inserted in table 32 when I have a logical switch with two logical ports and one localport: cookie=0x0, duration=528.253s, table=32, n_packets=416, n_bytes=17584, idle_age=1,

[ovs-dev] [PATCH v5] OVN localport type support

This patch introduces a new type of OVN ports called "localport". These ports will be present in every hypervisor and may have the same IP/MAC addresses. They are not bound to any chassis and traffic to these ports will never go through a tunnel. Its main use case is the OpenStack metadata API

[ovs-dev] Digital Notice board

Hi, Greetings of the Day, Digital Notice Board is a connector, communicator and motivator to viewer. Through Digital Notice Board, government facilities can improve internal communications, increase workforce awareness of key initiatives, policies and goals, enhance way findings and visitor

Re: [ovs-dev] [PATCH] ovn-ctl: Add commands to manage OVN DB ovsdb-servers individually

On Fri, May 26, 2017 at 3:30 AM, Andy Zhou wrote: > On Thu, May 25, 2017 at 1:55 AM, wrote: > > From: Numan Siddique > > > > This patch adds the following functions > > - start_nb_ovsdb, stop_nb_ovsdb, restart_nb_ovsdb to start, stop

Re: [ovs-dev] [RFC PATCH v1 3/3] Docs: Update releases with IPsec feature support info.

LGTM Regards _Sugesh > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Ian Stokes > Sent: Thursday, May 18, 2017 10:16 AM > To: d...@openvswitch.org > Subject: [ovs-dev] [RFC PATCH v1 3/3] Docs: Update releases with

Re: [ovs-dev] [RFC PATCH v1 2/3] Docs: Add userspace-ipsec how to guide.

I have given some comments for previous patch that has been addressed in this. So please ignore them accordingly. Regards _Sugesh > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Ian Stokes > Sent: Thursday, May 18,

Re: [ovs-dev] FW: [PATCH 3/4] dpif-netdev: Avoid port's reconfiguration on pmd-cpu-mask changes.

On 26.05.2017 12:49, Stokes, Ian wrote: >> 2017-02-21 6:49 GMT-08:00 Ilya Maximets : >>> Reconfiguration of HW NICs may lead to packet drops. >>> In current model all physical ports will be reconfigured each time >>> number of PMD threads changed. Since we not stopping threads on >>>

Re: [ovs-dev] [RFC PATCH v1 1/3] vswitch.xml: Detail ipsec user interface.

Regards _Sugesh > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Ian Stokes > Sent: Thursday, May 18, 2017 10:16 AM > To: d...@openvswitch.org > Subject: [ovs-dev] [RFC PATCH v1 1/3] vswitch.xml: Detail ipsec user >

Re: [ovs-dev] [RFC PATCH v1 0/3] RFC for Userspace IPsec Interface

Hi Ian, Thank you for working on this! Good initiative and its definitely very useful. Few high level comments as below. Have added some more comments in the following patches as well. Regards _Sugesh > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- >

Re: [ovs-dev] [PATCH] conntrack : Use Rx checksum offload feature on DPDK ports for conntrack.

Hi Sugesh, it looks good to me, it makes sense to leverage the csum info when present. I've tested it with the firewall rules - see below for details - I saw a ~+3% improvement in my testbench with 10 UDP connections. Traffic Gen: IXIA IxExplorer 10 UDP different flows, 64B pkts Original OvS:

  1   2   >