[ovs-dev] [PATCH] netdev: fix crash when ifa_netmask is null

The ifa_netmask is null when failed to call ioctl in getifaddrs Signed-off-by: Haifeng Lin --- lib/netdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/netdev.c b/lib/netdev.c index a7840a8..c731b80 100644 --- a/lib/netdev.c +++

Re: [ovs-dev] [PATCH] dpif-netilnk: convert packet_type netlink attribute

Zoltan, I tested this patch for net-next, it will result in failure by ovs_assert, in addition, we need to handle OVS_FLOW_ATTR_MASK and OVS_FLOW_ATTR_KEY differently, to be important, we need to verify it in kernel mode. From my test and verification, this patch can't work, instead, it can

Re: [ovs-dev] [PATCH v2] dp-packet: Copy trunc flag on batch clone.

On Fri, Jun 30, 2017 at 4:00 AM, Ilya Maximets wrote: > Without this applying of the cutlen action will not work > on copied batch. Cutlen works for linux and dummy netdevs > only because they tries to apply it per-packet inside > send function. > > Cutlen action doesn't

Re: [ovs-dev] [PATCH v1] docs: Use DPDK 16.11.2 stable release.

Hi Ian Do you have a good link to the 16.11.2 release notes ? I have been looking around and found some links but may not be the best and I am not sure new functionality is not being enabled with 16.11.2 ? What specifically do we want from 16.11.2 ? Thanks Darrell On 7/3/17, 1:01 PM,

[ovs-dev] [PATCH 20/20] Documentation: Update DPDK doc with Keepalive feature.

Keepalive feature is aimed at achieving Fastpath Service Assurance in OVS-DPDK deployments. It adds support for monitoring the packet processing cores(PMD thread cores) by dispatching heartbeats at regular intervals. Incase of heartbeat misses additional health checks are enabled on the PMD thread

[ovs-dev] [PATCH 19/20] keepalive: Display extended Keepalive status.

This commit adds support to display the extended keepalive status. The status can be displayed as follows. $ ovs-appctl keepalive/pmd-xstats-show keepAlive Status : Enabled keepAlive Interval: 1000 ms PMD threads : 3 pmd64 PMD core_id : 0 PMD thread id

[ovs-dev] [PATCH 18/20] netdev-dpdk: Enable PMD health checks on heartbeat failure.

The keepalive thread sends heartbeats to PMD thread and when PMD fails to respond to successive heartbeats the PMD is potentially stalled. The PMD state transition is as below: ALIVE -> MISSING -> DEAD -> GONE This commit enables PMD healthchecks when PMD doesn't respond to heartbeats. This is

[ovs-dev] [PATCH 17/20] keepalive: Check the PMD cycle stats as part of PMD health checks.

This commit adds the support to check the PMD cycle stats. If the cycles aren't changing for a duration of time this can be flagged as possible PMD stall. Signed-off-by: Bhanuprakash Bodireddy --- lib/dpif-netdev.c | 16 +--- lib/dpif-netdev.h | 6

[ovs-dev] [PATCH 16/20] keepalive: Check the packet statistics as part of PMD health checks.

This commit adds the support to check the packet statistics on the port polled by PMD thread. If the packets aren't processed due to PMD thread stall/deadlock the statistics wont update and this can be used by monitoring framework to confirm PMD failure. This mechanism has limitation with MQ

[ovs-dev] [PATCH 15/20] keepalive: Check the link status as part of PMD health checks.

This commit adds the initial support in to performing PMD health checks. The ports handled by the PMD threads are checked for the link status and the same is updated in to keepalive info structure. Signed-off-by: Bhanuprakash Bodireddy --- lib/dpif-netdev.c |

[ovs-dev] [PATCH 14/20] dpif-netdev: Add additional datapath health checks.

This commit enables additional datapath health checks. The checks are enabled only on a PMD heartbeat failure. On missing three successive heartbeats additional health checks needs to be performed on respective PMD thread to confirm the failure. The datapath health is monitored periodically from

[ovs-dev] [PATCH 13/20] keepalive: Add support to query keepalive status.

This commit adds support to query if keepalive status is enabled/disabled. $ ovs-appctl keepalive/status keepAlive Status: Enabled Signed-off-by: Bhanuprakash Bodireddy --- lib/keepalive.c | 15 +++ 1 file changed, 15 insertions(+) diff

[ovs-dev] [PATCH 12/20] keepalive: Add support to query keepalive statistics.

This commit adds support to query keepalive statistics. Datapath health status can be retrieved as follows: $ ovs-appctl keepalive/pmd-health-show Keepalive status keepalive status : Enabled keepalive interval: 1000 ms PMD threads : 8 PMDCORESTATE

[ovs-dev] [PATCH 11/20] bridge: Update keepalive status in OVSDB

This commit allows vswitchd thread to update the OVSDB with the status of all registered PMD threads. The status can be monitored using ovsdb-client and the sample output is below. $ ovsdb-client monitor Open_vSwitch Open_vSwitch keepalive rowaction keepalive

[ovs-dev] [PATCH 09/20] dpif-netdev: Enable heartbeats for DPDK datapath.

This commit adds heartbeat mechanism support for DPDK datapath. Heartbeats are sent to registered PMD threads at predefined intervals (as set in ovsdb with 'keepalive-interval'). The heartbeats are only enabled when there is atleast one port added to the bridge and with active PMD thread polling

[ovs-dev] [PATCH 08/20] dpif-netdev: Register packet processing cores to KA framework.

This commit registers the packet processing PMD cores to keepalive framework. Only PMDs that have rxqs mapped will be registered and actively monitored by KA framework. This commit spawns a keepalive thread that will dispatch heartbeats to PMD cores. The pmd threads respond to heartbeats by

[ovs-dev] [PATCH 07/20] dpif-netdev: Add helper function to store datapath tids.

This commit adds an API to store the PMD thread ids in to KA info struct. The thread ids shall be used to check false positives and for status and statistics reporting. Signed-off-by: Bhanuprakash Bodireddy --- lib/dpif-netdev.c | 3 +++ lib/keepalive.c | 13

[ovs-dev] [PATCH 06/20] keepalive: Add more helper functions to KA framework.

This commit introduces helper functions in 'keepalive' module that are needed to register/unregister PMD threads to KA framework. Also introduce APIs to mark the PMD core states. Signed-off-by: Bhanuprakash Bodireddy --- lib/keepalive.c | 51

[ovs-dev] [PATCH 05/20] Keepalive: Add initial keepalive support.

This commit introduces the initial keepalive support by adding 'keepalive' module and also helper and initialization functions that will be invoked by later commits. This commit adds new ovsdb column "keepalive" that shows the status of the datapath threads. This is implemented for DPDK datapath

[ovs-dev] [PATCH 04/20] process: Add helper function to retrieve process status.

Implement helper function to retrieve the process status. This commit also enables the fields relating to process name, state and core the process was last scheduled. The APIs will be used by keepalive monitoring framework in future commits. Signed-off-by: Bhanuprakash Bodireddy

[ovs-dev] [PATCH 03/20] process: Avoid warnings compiling process.c

This commit fixes the following "sparse" warning: lib/process.c:439:16: error: use of assignment suppression and length modifier together in gnu_scanf format [-Werror=format=]. This fix doesn't need any other changes as the fields aren't used for now. Signed-off-by: Bhanuprakash Bodireddy

[ovs-dev] [PATCH 02/20] dpdk: Add helper functions for DPDK datapath keepalive.

Introduce helper functions in 'dpdk' module that are needed for DPDK keepalive functionality. Also add dummy functions in 'dpdk-stub' module that are needed when DPDK datapath is not available. Signed-off-by: Bhanuprakash Bodireddy --- lib/dpdk-stub.c | 24

[ovs-dev] [PATCH 01/20] process: Consolidate process related APIs.

As part of retrieving system statistics, process status APIs along with helper functions were implemented. Some of them are very generic and can be reused by other subsystems. Move the APIs in system-stats.c to process.c and util.c and make them available. This patch doesn't change any

[ovs-dev] [PATCH 00/20] Add OVS DPDK keep-alive functionality.

Keepalive feature is aimed at achieving Fastpath Service Assurance in OVS-DPDK deployments. It adds support for monitoring the packet processing cores(PMD thread cores) by dispatching heartbeats at regular intervals. Incase of heartbeat misses additional health checks are enabled on the PMD thread

Re: [ovs-dev] [PATCH] dpif-netilnk: convert packet_type netlink attribute

On Mon, Jul 03, 2017 at 02:27:18PM +, Zoltán Balogh wrote: > By introducing packet type-aware pipeline, match on ethertype was > removed when packet type is not Ethernet. As pointed out by Eric Garver, > this could have a side effect on the kernel datapath: >

Re: [ovs-dev] [PATCH] odp: Fix crash in parse_8021q_onward().

On Fri, Jun 16, 2017 at 04:51:04AM -0700, nickcooper-zhangtonghao wrote: > When we use the 'ovs-appctl ofproto/trace' to send packets, > which include the 'vlan' field, but exclude the 'encap', > the ovs-vswitchd will crash. We should check 'encap' field > in parse_8021q_onward(), before using it.

Re: [ovs-dev] [branch-2.7 1/2] Set release date for 2.7.1.

> On Jul 3, 2017, at 7:56 AM, Flavio Leitner wrote: > > On Sat, Jul 01, 2017 at 04:34:34PM -0700, Justin Pettit wrote: >> >>> On Jun 28, 2017, at 11:43 AM, Flavio Leitner wrote: >>> >>> On Wed, Jun 28, 2017 at 09:47:19AM -0700, Justin Pettit wrote:

Re: [ovs-dev] [branch-2.7 1/2] Set release date for 2.7.1.

> On Jul 3, 2017, at 12:58 PM, Stokes, Ian wrote: > >>> On Jul 3, 2017, at 3:22 AM, Stokes, Ian wrote: >>> >>> I have a small documentation and travis patch that I would like to see >> get into 2.7.1. >>> >>>

Re: [ovs-dev] [PATCH v1] docs: Use DPDK 16.11.2 stable release.

Hi All, I would like to see this go into the OVS 2.7.1 branch to ensure users are using the latest stable DPDK 16.11 release. If anyone has time to review this patch I would be grateful. I've been using 16.11.2 myself for the last number of weeks and have not encountered any issues. Thanks

Re: [ovs-dev] [branch-2.7 1/2] Set release date for 2.7.1.

> > On Jul 3, 2017, at 3:22 AM, Stokes, Ian wrote: > > > > I have a small documentation and travis patch that I would like to see > get into 2.7.1. > > > > https://patchwork.ozlabs.org/patch/778288/ > > > > It just updates the docs and travis to point to DPDK 16.11.2 instead

Re: [ovs-dev] [branch-2.7 1/2] Set release date for 2.7.1.

> On Jul 3, 2017, at 3:22 AM, Stokes, Ian wrote: > > I have a small documentation and travis patch that I would like to see get > into 2.7.1. > > https://patchwork.ozlabs.org/patch/778288/ > > It just updates the docs and travis to point to DPDK 16.11.2 instead of >

Re: [ovs-dev] [PATCH] dpif-netilnk: convert packet_type netlink attribute

On Mon, Jul 03, 2017 at 02:27:18PM +, Zoltán Balogh wrote: > By introducing packet type-aware pipeline, match on ethertype was > removed when packet type is not Ethernet. As pointed out by Eric Garver, > this could have a side effect on the kernel datapath: >

Re: [ovs-dev] [PATCH 0/3] Output packet batching.

On 7/3/17, 7:31 AM, "ovs-dev-boun...@openvswitch.org on behalf of Jan Scheurich" wrote: I like this generic approach to collect the packets to be output per port for each Rx batch in dpif-netdev. It is indeed

Re: [ovs-dev] [PATCH v3] netdev-dpdk: use rte_eth_dev_set_mtu

Hi Mark, Regards _Sugesh > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Mark Kavanagh > Sent: Wednesday, June 28, 2017 3:52 PM > To: ovs-dev@openvswitch.org; Varghese, Vipin > ;

Re: [ovs-dev] [branch-2.7 1/2] Set release date for 2.7.1.

On Sat, Jul 01, 2017 at 04:34:34PM -0700, Justin Pettit wrote: > > > On Jun 28, 2017, at 11:43 AM, Flavio Leitner wrote: > > > > On Wed, Jun 28, 2017 at 09:47:19AM -0700, Justin Pettit wrote: > >> Signed-off-by: Justin Pettit > >> --- > > > > Acked-by: Flavio

Re: [ovs-dev] [PATCH] packet_type: Force _ETHERTYPE mask in netlink messages

On Mon, Jul 03, 2017 at 01:22:30PM +, Jan Scheurich wrote: > Hi Eric, > > Thanks for the catch. We seem to have overlooked this side effect on > the kernel datapath when removing the conceptually incorrect match on > eth_type in the datapath when packet_type != PT_ETH. > > Instead of

Re: [ovs-dev] [PATCH] packet_type: Force _ETHERTYPE mask in netlink messages

Hi Eric, I sent out the patch mentioned by Jan to the dev list: https://patchwork.ozlabs.org/patch/783509/ Could you review it, please? Best regards, Zoltan > -Original Message- > From: Jan Scheurich > Sent: Monday, July 03, 2017 3:23 PM > To: Eric Garver ;

Re: [ovs-dev] [PATCH 0/3] Output packet batching.

I like this generic approach to collect the packets to be output per port for each Rx batch in dpif-netdev. It is indeed simpler than the approach in [1]. However, [1] originally had a larger scope, namely to buffer packets in an intermediate queue per netdev tx queue *across* multiple rx

[ovs-dev] [PATCH] dpif-netilnk: convert packet_type netlink attribute

By introducing packet type-aware pipeline, match on ethertype was removed when packet type is not Ethernet. As pointed out by Eric Garver, this could have a side effect on the kernel datapath: https://patchwork.ozlabs.org/patch/782991/ This patch does approach the problem from a different

Re: [ovs-dev] [PATCH 0/3] Output packet batching.

On 03.07.2017 13:15, Bodireddy, Bhanuprakash wrote: >> This patch-set inspired by [1] from Bhanuprakash Bodireddy. >> Implementation of [1] looks very complex and introduces many pitfalls for >> later code modifications like possible packet stucks. >> >> This version targeted to make simple and

Re: [ovs-dev] [PATCH] packet_type: Force _ETHERTYPE mask in netlink messages

Hi Eric, Thanks for the catch. We seem to have overlooked this side effect on the kernel datapath when removing the conceptually incorrect match on eth_type in the datapath when packet_type != PT_ETH. Instead of re-introducing the unconditional match on eth_type in all megaflow entries, we

Re: [ovs-dev] [PATCH] openvswitch: fix mis-ordered comment lines for ovs_skb_cb

From: Daniel Axtens Date: Mon, 3 Jul 2017 21:46:43 +1000 > I was trying to wrap my head around meaning of mru, and realised > that the second line of the comment defining it had somehow > ended up after the line defining cutlen, leading to much confusion. > > Reorder the lines

[ovs-dev] [PATCH] openvswitch: fix mis-ordered comment lines for ovs_skb_cb

I was trying to wrap my head around meaning of mru, and realised that the second line of the comment defining it had somehow ended up after the line defining cutlen, leading to much confusion. Reorder the lines to make sense. Signed-off-by: Daniel Axtens ---

Re: [ovs-dev] [branch-2.7 1/2] Set release date for 2.7.1.

> -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Justin Pettit > Sent: Sunday, July 2, 2017 12:35 AM > To: Flavio Leitner > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [branch-2.7 1/2] Set release

Re: [ovs-dev] [PATCH 0/3] Output packet batching.

>This patch-set inspired by [1] from Bhanuprakash Bodireddy. >Implementation of [1] looks very complex and introduces many pitfalls for >later code modifications like possible packet stucks. > >This version targeted to make simple and flexible output packet batching on >higher level without

[ovs-dev] UPS issue #05685432: unable to delivery parcel

Dear Customer, Your item has arrived at the UPS Post Office at June 29, but the courier was unable to deliver parcel to you. Postal label is enclosed to this e-mail. Please check the attachment! With thanks and appreciation, , UPS Senior Office Manager.

[ovs-dev] Forward new flows to another OVS port

Hi everyone, Can someone take a look at the question I posted on StackOverflow [1]? It is about sending newly arrived flows to another OVS bridge port while keeping the existing flows on the same port. Thanks, - Nodir [1]