Re: [ovs-dev] [PATCH v2 2/3] ovn-controller: Add a new action - 'put_nd_ra_opts'

On Fri, Jul 14, 2017 at 10:01:08AM +0530, Numan Siddique wrote: > On Fri, Jul 14, 2017 at 5:31 AM, Ben Pfaff wrote: > > > On Tue, Jul 11, 2017 at 08:14:45PM +0530, nusid...@redhat.com wrote: > > > From: Numan Siddique > > > > > > This patch adds a new OVN

[ovs-dev] [PATCH] ovs-vsctl-bashcomp: Make compatible with busybox "awk".

It seems that awk in busybox doesn't think that an empty string is part of a larger string, but that GNU awk does. This commit adds an extra test to make _ovs_vsctl_check_startswith_string work either way. This allows the following tests to pass with busybox awk: vsctl bashcomp unit tests 7:

[ovs-dev] [PATCH 35/40] datapath-windows: Treat TCP_HDR_LEN static analysis warnings

Using the shift operator in macros makes the static analyzer on WDK 8.1 confused. Switch to multiplication when trying to get the data offset of the TCP header. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/NetProto.h | 2 +- 1 file changed,

[ovs-dev] [PATCH 37/40] datapath-windows: Add annotation for OvsIpFragmentEntryCleaner

Make the function `OvsIpFragmentEntryCleaner` aware it is a kstart_routine. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/IpFragment.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath-windows/ovsext/IpFragment.c

[ovs-dev] [PATCH 40/40] datapath-windows: Fix static analysis warnings around ovsInstanceListLock

Check for return value when trying to initialize ovsInstanceListLock. Also return the status back to caller of `OvsInitIpHelper`. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/IpHelper.c | 10 +++--- 1 file changed, 7 insertions(+), 3

[ovs-dev] [PATCH 32/40] datapath-windows: fix excessive stack usage in iphelper

`OvsGetOrResolveIPNeigh` uses a stack over 1024 bytes. Switch one parameter to be a pointer. Found using WDK 8.1 static code analysis. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/IpHelper.c | 15 +++ 1 file changed, 7

[ovs-dev] [PATCH 38/40] datapath-windows: Fix shared variables which use Interlocked functions

Instead of assigning a value directly to the variable use `InterlockedAdd` with 0. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Switch.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/datapath-windows/ovsext/Switch.c

[ovs-dev] [PATCH 39/40] datapath-windows: Fix static analysis warnings in OvsGetTcpPayloadLength

This fixes the static code analysis over the function 'OvsGetTcpPayloadLength'. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Conntrack.h | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git

[ovs-dev] [PATCH 36/40] datapath-windows: Add annotation for OvsCtRelatedEntryCleaner

Make the function `OvsCtRelatedEntryCleaner` aware it is a kstart_routine. Also, the function is not compliant with the coding standard. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Conntrack-related.c | 7 --- 1 file changed, 4

[ovs-dev] [PATCH 33/40] datapath-windows: Check return status when using APIs

Check the return status of `ConvertInterfaceLuidToAlias` and `RtlStringCbLengthW` and treat them accordingly. Also remove unneeded initialization for `interfaceName`. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/IpHelper.c | 19

[ovs-dev] [PATCH 34/40] datapath-windows: Vport check RtlStringCbLengthW return value

The result of `RtlStringCbLengthW` is not currently checked and triggers a warning using the WDK 8.1 static analysis. This patch treats the result of `RtlStringCbLengthW`. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Vport.c | 9 +++-- 1

[ovs-dev] [PATCH 31/40] datapath-windows: prettify logging in iphelper

Found by inspection. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/IpHelper.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/datapath-windows/ovsext/IpHelper.c b/datapath-windows/ovsext/IpHelper.c index

[ovs-dev] [PATCH 30/40] datapath-windows: Add dummy parameter for NotifyRouteChange2

Add a dummy parameter when using `NotifyRouteChange2` to keep static static analysis happy. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/IpHelper.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[ovs-dev] [PATCH 26/40] datapath-windows: Use annotations instead for macros

We can safely use function annotations to instead of defining out own macros. Nuke implementation of `OVS_VERIFY_IRQL_LE` and OVS_VERIFY_IRQL (unused). Add function annotations to the functions which were using OVS_VERIFY_IRQL_LE`. Signed-off-by: Alin Gabriel Serdean

[ovs-dev] [PATCH 19/40] datapath-windows: Add function annotations for OvsTunnelFilterCancelIrp

The function should be aware that it is cancel routine. This patch adds annotation for that. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/TunnelFilter.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[ovs-dev] [PATCH 29/40] datapath-windows: Suppress warning in jhash

Suppress overflow warning to keep static code analysis happy. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Jhash.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/datapath-windows/ovsext/Jhash.c b/datapath-windows/ovsext/Jhash.c index

[ovs-dev] [PATCH 01/40] datapath-windows: Use only non executable memory

Use only non-executable memory when using MmGetSystemAddressForMdlSafe. Introduce a new function called OvsGetMdlWithLowPrio for readability. Found using WDK 10 static code analysis. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/BufferMgmt.c

[ovs-dev] [PATCH 28/40] datapath-windows: Fix possible NULL deference in OvsFullCopyNBL

Check if the first net buffer exists before trying to copy it. Found using WDK 10 static code analysis. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/BufferMgmt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[ovs-dev] [PATCH 21/40] datapath-windows: Add function annotations for OvsAcquireEventQueueLock

The function should be aware that it raises the dispatch level, saves the dispatch level and acquires a lock. This patch adds annotation for that. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Event.c | 3 +++ 1 file changed, 3 insertions(+)

[ovs-dev] [PATCH 25/40] datapath-windows: Fix spelling for OvsTunnelFilterSetIrpContext

Found by inspection. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/TunnelFilter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath-windows/ovsext/TunnelFilter.c b/datapath-windows/ovsext/TunnelFilter.c index

[ovs-dev] [PATCH 27/40] datapath-windows: Add assert in OvsPartialCopyNBL

`srcNb` should never be NULL since it was copied over from another nbl. Add an assertion just in case and to keep static analysis happy. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/BufferMgmt.c | 1 + 1 file changed, 1 insertion(+) diff

[ovs-dev] [PATCH 24/40] datapath-windows: Add annotations for OvsAcquirePidHashLock

Add annotations to the function ` OvsAcquirePidHashLock`. We make it aware that it raises the dispatch level, where it saves the dispatch level and it acquires a lock. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/User.c | 3 +++ 1 file

[ovs-dev] [PATCH 18/40] datapath-windows: Add function annotations for OvsCancelIrp

The function should be aware that it is cancel routine. This patch adds annotation for that. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Event.c | 1 + 1 file changed, 1 insertion(+) diff --git a/datapath-windows/ovsext/Event.c

[ovs-dev] [PATCH 23/40] datapath-windows: Add annotations for OvsReleasePidHashLock

Add function annotations for ` OvsReleasePidHashLock`. We make it aware that it requires a certain dispatch level, that it restores the dispatch level, that it requires a lock held and releases a lock. Signed-off-by: Alin Gabriel Serdean ---

[ovs-dev] [PATCH 16/40] datapath-windows: Add function annotations for OvsAcquireDatapathWrite

The function should be aware that it raises the dispatch level, saves the dispatch level and acquires a lock. This patch adds annotation for that. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Switch.h | 3 +++ 1 file changed, 3 insertions(+)

[ovs-dev] [PATCH 22/40] datapath-windows: Add annotations for OvsReleaseEventQueueLock

Add function annotations for ` OvsReleaseEventQueueLock`. We make it aware that it requires a certain dispatch level, that it restores the dispatch level, that it requires a lock held and releases a lock. Signed-off-by: Alin Gabriel Serdean ---

[ovs-dev] [PATCH 14/40] datapath-windows: Remove function declarations from Tunnel.c

`OvsAcquireDatapathRead`, `OvsAcquireDatapathWrite`, `OvsReleaseDatapath` are defined and implemented in Switch.h which is already included. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Tunnel.c | 10 -- 1 file changed, 10 deletions(-)

[ovs-dev] [PATCH 20/40] datapath-windows: Add function annotations for OvsCancelIrpDatapath

The function should be aware that it is cancel routine. This patch adds annotation for that. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/User.c | 1 + 1 file changed, 1 insertion(+) diff --git a/datapath-windows/ovsext/User.c

[ovs-dev] [PATCH 17/40] datapath-windows: Add function annotations for OvsReleaseDatapath

The function should be aware that it requires a certain dispatch level, restores the dispatch level, requires lock held and releases a lock. This patch adds annotation for that. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Switch.h | 4

[ovs-dev] [PATCH 12/40] datapath-windows: Add annotations for OvsAcquireCtrlLock

Add annotations to the function `OvsAcquireCtrlLock`. We make it aware that it raises the dispatch level, where it saves the dispatch level and it acquires a lock. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Datapath.c | 1 +

[ovs-dev] [PATCH 15/40] datapath-windows: Add function annotations for OvsAcquireDatapathRead

The function should be aware that it raises the dispatch level, saves the dispatch level and acquires a lock. This patch adds annotation for that. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Switch.h | 3 +++ 1 file changed, 3 insertions(+)

[ovs-dev] [PATCH 13/40] datapath-windows: Add annotations for OvsReleaseCtrlLock

Add function annotations for `OvsReleaseCtrlLock`. We make it aware that it requires a certain dispatch level, that it restores the dispatch level, that it requires a lock held and release a lock. Signed-off-by: Alin Gabriel Serdean ---

[ovs-dev] [PATCH 07/40] datapath-windows: Add asserts to Stt

Unfortunately the WDK 10 static code analysis can't see this one clearly. Add an ASSERT to silence the warning. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Stt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[ovs-dev] [PATCH 09/40] datapath-windows: Fix possible NULL dereference in BufferMgmt

The mdl can be NULL. Found using WDK 10 static code analysis. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/BufferMgmt.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/datapath-windows/ovsext/BufferMgmt.c

[ovs-dev] [PATCH 11/40] datapath-windows: Add an assert in recirculation

`ovsFwdCtx.switchContext` can't be null since it is passed from actions. Add an assert to keep the static analyzer happy. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Actions.c | 1 + 1 file changed, 1 insertion(+) diff --git

[ovs-dev] [PATCH 05/40] datapath-windows: Fix possible NULL dereference in IpFragment

If we can't allocate the NBL just return. Found using WDK 10 static code analysis. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/IpFragment.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[ovs-dev] [PATCH 08/40] datapath-windows: Suppress PAGED_CODE warnings

Suppress static code analysis around PAGED_CODE(). The macro is useful only in checked builds. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Datapath.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/datapath-windows/ovsext/Datapath.c

[ovs-dev] [PATCH 10/40] datapath-windows: Fix possible NULL deference

`ethHdr` may be NULL while trying to push mpls lables. Found with WDK 10 static code analysis. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Actions.c | 4 1 file changed, 4 insertions(+) diff --git a/datapath-windows/ovsext/Actions.c

[ovs-dev] [PATCH 06/40] datapath-windows: Fix aligment in Stt

Found by inspection. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Stt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/datapath-windows/ovsext/Stt.c b/datapath-windows/ovsext/Stt.c index 5490062..7726470 100644 ---

[ovs-dev] [PATCH 03/40] datapath-windows: Remove annotations in Switch.c

There are no annotations defined for `OvsExtDetach` and `OvsExtRestart`. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Switch.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/datapath-windows/ovsext/Switch.c

[ovs-dev] [PATCH 04/40] datapath-windows: interfaceName overflow in IpHelper

Bump the size of interfaceName so an overflow cannot occur when using `ConvertInterfaceLuidToAlias`. Found using WDK 10 static code analysis. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/IpHelper.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[ovs-dev] [PATCH 02/40] datapath-windows: Use non-executable memory when allocating memory

Use non-executable memory when using ExAllocatePoolWithTagPriority. Found using WDK 10 static code analysis. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[ovs-dev] [PATCH 00/40] Fix static code analysis warnings.

The following patches are fixes found with the WDK 8.1 and 10 static code analysis. Alin Serdean (40): Found with WDK 10 datapath-windows: Use only non executable memory datapath-windows: Use non-executable memory when allocating memory datapath-windows: Remove annotations in Switch.c

Re: [ovs-dev] [PATCH v2 2/3] ovn-controller: Add a new action - 'put_nd_ra_opts'

On Fri, Jul 14, 2017 at 5:31 AM, Ben Pfaff wrote: > On Tue, Jul 11, 2017 at 08:14:45PM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > This patch adds a new OVN action 'put_nd_ra_opts' to support native > > IPv6 Router Advertisement in OVN.

Re: [ovs-dev] [PATCH] rstp: Show root bridge info.

On Fri, Jul 14, 2017 at 10:30:52AM +0800, nickcooper-zhangtonghao wrote: > > > On Jul 14, 2017, at 7:05 AM, Ben Pfaff wrote: > > > > This change makes me nervous about dereferencing a null 'p'. I think > > that it will not do so, for a root bridge, but it takes some study to > >

Re: [ovs-dev] [PATCH] rstp: Show root bridge info.

> On Jul 14, 2017, at 7:05 AM, Ben Pfaff wrote: > > This change makes me nervous about dereferencing a null 'p'. I think > that it will not do so, for a root bridge, but it takes some study to > see that. > > How about this, instead? It has a small amount of code duplication,

[ovs-dev] [PATCH 1/2] ovn-controller: fix vlan_trunk bug

The bug description is as follow: Neutron configure a trunk-sub port. The parent-port and sub-port located in different network. there is a vm attached to parent port. And no vm attached to the network of sub-port in the same chassis. In this situation, the ovn-controller can not get the

[ovs-dev] [PATCH 2/2] ovn-controller: fix vlan_trunk bug

The bug description is as follow: Neutron configure a trunk-sub port. The parent-port and sub-port located in different network. there is a vm attached to parent port. And no vm attached to the network of sub-port in the same chassis. In this situation, the ovn-controller can not get the

Re: [ovs-dev] When did vlan tag add into packet in ovs and ovs-dpdk?

Sorry, Add a question: 3. I start to capture packets in b2 port on br_t07, when I use vm(121) to ping vm(120), I could not capture any packets(including arp); when I use vm(121) to ping vm(220), I could capture it; when I use vm(121) to ping unknown host like 123, I could not capture any thing.

Re: [ovs-dev] [PATCH 1/4] Add OF actions for generic encap and decap

Jan, here is ALIGNED_CAST macro /* Given ATTR, and TYPE, cast the ATTR to TYPE by first casting ATTR to * (void *). This is to suppress the alignment warning issued by clang. */ #define ALIGNED_CAST(TYPE, ATTR) ((TYPE) (void *) (ATTR)) It is just for suppressing the error message Ben saw, so we

Re: [ovs-dev] When did vlan tag add into packet in ovs and ovs-dpdk?

For hardware switch, a port with vlan 1020, it's behavior is: 1. packet come into port will set vlan tag 1020 in switch, and then send it. 2. only packet with vlan 1020 will come out from this port. So I don't know if ovs works like this? 2017-07-14 9:46 GMT+08:00 Sam : >

Re: [ovs-dev] [PATCH 1/4] Add OF actions for generic encap and decap

I also tried it with 32 bit build on 64 bit machine by a simple c program with " -m32 -Werror -Wcast-align" options, but I can't reproduce this error information. The error message is saying char pointer or uint8 pointer may be any address (non-alignment to 4 or 8 bytes boundary), but struct

[ovs-dev] When did vlan tag add into packet in ovs and ovs-dpdk?

Hi all, I'm testing vlan in both ovs and ovs-dpdk. My topology is: vm(121) vm(120) vm(220) | | | ----- br_t07| b2

Re: [ovs-dev] [PATCH v1 0/2] Add GTP vport based on upstream datapath

Hi Joe, > It's neat to see new tunnel implementations being introduced, and also > quite cool that it doesn't require significant code changes to OVS to > make this happen. Thanks for looking into this :-) Thanks :) > I mentioned on the netdev thread that we should work towards using the >

Re: [ovs-dev] [PATCH net-next v1 2/3] gtp: Support creating flow-based gtp net_device

Hi Harald, > On 7/13/17, 12:35 AM, "Harald Welte" wrote: > > > +static int gtp_dev_open(struct net_device *dev) > > +{ > > + struct gtp_dev *gtp = netdev_priv(dev); > > + struct net *net = gtp->net; > > + struct socket *sock1u; > > + struct socket *sock0; > > +

Re: [ovs-dev] [PATCH net-next v1 1/3] gtp: refactor to support flow-based gtp encap and decap

Hi Harald, > On 7/13/17, 12:26 AM, "Harald Welte" wrote: >· > > static inline void gtp_set_pktinfo_ipv4(struct gtp_pktinfo *pktinfo, > > struct sock *sk, struct iphdr *iph, > > - struct pdp_ctx *pctx, struct rtable *rt, > > - struct flowi4 *fl4, >

Re: [ovs-dev] [PATCH] Fixes: 3f5b5f7b4115 ("db-ctl-base: Always support all tables in schema.")

On Tue, Jul 11, 2017 at 02:32:57PM -0400, Aaron Conole wrote: > Hi ZhiPeng, > > ZhiPeng Lu writes: > > > This fixes an assertion failure in command "ovs-vsctl list netflow br0", > > if bridge br0 without any netflows. > > $ovs-vsctl list netflow br0 > > ovs-vsctl:

Re: [ovs-dev] [PATCH] Fixes: 3f5b5f7b4115 ("db-ctl-base: Always support all tables in schema.")

On Tue, Jul 11, 2017 at 08:47:10AM +0800, ZhiPeng Lu wrote: > This fixes an assertion failure in command "ovs-vsctl list netflow br0", > if bridge br0 without any netflows. > $ovs-vsctl list netflow br0 > ovs-vsctl: lib/ovsdb-idl.c:2407: assertion column_idx < class->n_columns > failed > in

Re: [ovs-dev] [PATCH] acinclude: netdev-dpdk: use pkg-config of libdpdk

On Tue, Jul 11, 2017 at 04:34:04PM +0200, Christian Ehrhardt wrote: > Ping - any update on this thread - anybody looked into considering the > config change? I don't object to this myself. I'm not a big fan of pkg-config but it's a lot better than most home-grown ways to find libraries and

Re: [ovs-dev] [PATCH v2 1/3] ovn util: Refactor dhcp_opts_map to make it generic

On Tue, Jul 11, 2017 at 08:14:26PM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > Renamed 'struct dhcp_opts_map' to 'struct gen_opts_map' and > renamed ovn-dhcp.h to ovn-l7.h. An upcoming commit to support IPv6 > Router Advertisement, will make use of the

Re: [ovs-dev] [PATCH] appveyor: Bump OpenSSL version

On Thu, Jul 13, 2017 at 10:30:35PM +, Alin Serdean wrote: > The URL https://slproweb.com/download/Win32OpenSSL-1_0_2k.exe is > no longer valid. > > Bump the version of OpenSSL to 1_0_2l. > > Signed-off-by: Alin Gabriel Serdean Thanks, I applied this to

Re: [ovs-dev] [PATCH] datapath: Fix for force/commit action failures

On 13 July 2017 at 15:38, Greg Rose wrote: > On 07/13/2017 11:03 AM, Joe Stringer wrote: >> >> On 13 July 2017 at 11:01, Greg Rose wrote: >>> >>> On 07/13/2017 10:46 AM, Joe Stringer wrote: On 13 July 2017 at 09:25, Greg Rose

Re: [ovs-dev] [PATCH net-next v1 0/3] Flow Based GTP Tunneling

Hi Harald and Jeo, Thank you for the code review. They are really helpful! > On 7/13/17, 11:14 AM, "Joe Stringer" wrote: > > On 13 July 2017 at 00:12, Harald Welte wrote: >> I'm not familiar with the details here, but does this imply that you >>

Re: [ovs-dev] (no subject)

I AM SGT HEATHER J LYNN I NEED YOUR ASSISTANCE FOR BUSINESS PROPOSAL OUTLINE, CAN WE TALK FOR MORE DETAILS Confidentiality Notice This email including all attachments is confidential and intended solely for the use of the individual or entity to which it is

[ovs-dev] [PATCH v3 2/2] ovn-controller: Use separate thread for packet-in processing.

This patch introduces multi-threading for ovn-controller and use dedicated thread for packet-in processing as a start. It decouples packet-in processing and ovs flow computing, so that packet-in inputs won't trigger flow recomputing, and flow computing won't block packet-in processing. In large

[ovs-dev] [PATCH v3 1/2] ovn-controller: readonly mode binding_run and get_br_int

This change is to prepare for the future change for multi-threading. Both binding_run() and get_br_int() are needed by pinctrl thread, but we don't want to update SB DB or create bridges in that scenario, so need "readonly" mode for these functions. Signed-off-by: Han Zhou

Re: [ovs-dev] [PATCH v5 3/4] ovsdb-idl: idl compound indexes implementation

> From: "Rodriguez Betancourt, Esteban" > To: "Lance Richardson" , "Ben Pfaff" > Cc: d...@openvswitch.org, "Javier Albornoz" , > "Arnoldo Lutz" > Sent: Thursday, 13 July, 2017 5:22:42 PM

Re: [ovs-dev] [PATCH] submitting-patches: Update test and documentation recommendations.

On Fri, Jul 07, 2017 at 12:18:43AM +, Darrell Ball wrote: > > > On 5/18/17, 5:32 AM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff" > wrote: > > Rationale: > > - "make distcheck" is not as necessary anymore

Re: [ovs-dev] [PATCH] datapath: Fix for force/commit action failures

On 07/13/2017 11:03 AM, Joe Stringer wrote: On 13 July 2017 at 11:01, Greg Rose wrote: On 07/13/2017 10:46 AM, Joe Stringer wrote: On 13 July 2017 at 09:25, Greg Rose wrote: When there is an established connection in direction A->B, it is

Re: [ovs-dev] [PATCH] dpif-netdev: Fix few comments.

On Thu, Jul 06, 2017 at 02:12:00PM +0300, Ilya Maximets wrote: > Signed-off-by: Ilya Maximets Thanks, applied to master. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] socket-util: Avoid using sendmsg on Windows

On Thu, Jul 13, 2017 at 08:54:08PM +, Alin Serdean wrote: > Sendmsg is not used under Windows. > > While it does have a sort of equivalent called `WSASendMsg` > (https://msdn.microsoft.com/en-us/library/windows/desktop/ms741692(v=vs.85).aspx) > it uses a different structure `WSAMSG` instead

[ovs-dev] [PATCH] appveyor: Bump OpenSSL version

The URL https://slproweb.com/download/Win32OpenSSL-1_0_2k.exe is no longer valid. Bump the version of OpenSSL to 1_0_2l. Signed-off-by: Alin Gabriel Serdean --- appveyor.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/appveyor.yml

Re: [ovs-dev] [patch_v4 7/8] System tests: Add a few passive ftp tests.

On 13 July 2017 at 15:22, Ben Pfaff wrote: > On Wed, Jul 05, 2017 at 09:32:25PM -0700, Darrell Ball wrote: >> In order to have full coverage of ALGs for the userspace >> datapath, it is necessary to add 4 new tests. Three of these will >> cover passive ftp, including basic V6

Re: [ovs-dev] [patch_v4 8/8] NEWS: Announce userspace datapath ALG support.

On Wed, Jul 05, 2017 at 09:32:26PM -0700, Darrell Ball wrote: > Signed-off-by: Darrell Ball > --- > NEWS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/NEWS b/NEWS > index 0f2604f..fc5c8f4 100644 > --- a/NEWS > +++ b/NEWS > @@ -29,6 +29,7 @@ Post-v2.7.0 >

Re: [ovs-dev] [patch_v4 7/8] System tests: Add a few passive ftp tests.

On Wed, Jul 05, 2017 at 09:32:25PM -0700, Darrell Ball wrote: > In order to have full coverage of ALGs for the userspace > datapath, it is necessary to add 4 new tests. Three of these will > cover passive ftp, including basic V6 passive ftp, V4 passive ftp > with NAT and sequence skew and V6

Re: [ovs-dev] [patch_v4 6/8] System tests: Enable ALGs for userspace.

On Wed, Jul 05, 2017 at 09:32:24PM -0700, Darrell Ball wrote: > Signed-off-by: Darrell Ball Looks good to me (I didn't test it). ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [patch_v4 5/8] Userspace Datapath: Add TFTP support.

On Wed, Jul 05, 2017 at 09:32:23PM -0700, Darrell Ball wrote: > Both ipv4 and ipv6 are supported. Also, NAT support is included. > > Signed-off-by: Darrell Ball Thanks for adding TFTP support! The new is_tftp_ctl() function is very similar to is_ftp_ctl(). I suggest

Re: [ovs-dev] [patch_v4 4/8] Userspace Datapath: Add ALG infra and FTP.

On Wed, Jul 05, 2017 at 09:32:22PM -0700, Darrell Ball wrote: > ALG infra and FTP (both V4 and V6) support is added to the userspace > datapath. Also, NAT support is included. > > Signed-off-by: Darrell Ball Thanks a lot for working on this. It will be a valuable feature

Re: [ovs-dev] [PATCH v5 3/4] ovsdb-idl: idl compound indexes implementation

Hello, The UUID comparison was added to guarantee that always rows with the same keys are sorted in the same way (between executions of a command, for example). Before that we used the pointer comparison (which gives us some randomness in sorting) but we kept it to be really really sure that

Re: [ovs-dev] [PATCH] socket-util: Avoid using sendmsg on Windows

From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Thursday, July 13, 2017 1:54 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH] socket-util: Avoid using

[ovs-dev] [PATCH] socket-util: Avoid using sendmsg on Windows

Sendmsg is not used under Windows. While it does have a sort of equivalent called `WSASendMsg` (https://msdn.microsoft.com/en-us/library/windows/desktop/ms741692(v=vs.85).aspx) it uses a different structure `WSAMSG` instead of the normal msghdr which in turn will have to be mapped properly (this

Re: [ovs-dev] [PATCH] ofproto-dpif-ipfix: add Exporting Process Reliability Statistics

On Wed, Jul 05, 2017 at 02:54:18PM +0100, Przemyslaw Szczerbik wrote: > This patch adds support for The Exporting Process Reliability Statistics > Option Template, which is defined in RFC 5101, Section 4.3. For now, this > Option Template includes only exporting process ID scope field and a >

Re: [ovs-dev] [PATCH v5 3/4] ovsdb-idl: idl compound indexes implementation

- Original Message - > From: "Ben Pfaff" > To: "Lance Richardson" > Cc: d...@openvswitch.org, esteb...@hpe.com, "javier albornoz" > , "jorge sauma" > , "arnoldo lutz guevara"

Re: [ovs-dev] [PATCH v2] odp-execute: Reuse rss hash in OVS_ACTION_ATTR_HASH.

On Thu, Jul 13, 2017 at 8:07 AM, Ilya Maximets wrote: > If RSS hash exists in a packet it can be reused instead of > 5 tuple hash re-calculation in OVS_ACTION_ATTR_HASH. This > leads to increasing the performance of sending packets to > the OVS bonding in userspace

Re: [ovs-dev] [PATCH v1 0/2] Add GTP vport based on upstream datapath

On 12 July 2017 at 17:45, Jiannan Ouyang wrote: > This patch series depends on the Linux net-next patch set > [PATCH net-next] Flow Based GTP Tunneling > > With flow based GTP tunneling supported in the upstream datapath, we can > create a gtp vport associated with a flow based

Re: [ovs-dev] [patch_v4 3/8] Userspace Datapath: Add missed lock annotations.

On 7/13/17, 11:48 AM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff" wrote: On Wed, Jul 05, 2017 at 09:32:21PM -0700, Darrell Ball wrote: > Fixes: a489b16854b5 ("conntrack: New userspace connection tracker.") >

Re: [ovs-dev] [PATCH 1/4] Add OF actions for generic encap and decap

Here are some tests of the below proposal: ovs-ofctl -Oopenflow13 add-flow br0 "in_port=1,ip,actions=decap(),set_field:1.1.1.1->nw_dst" ovs-ofctl -Oopenflow13 add-flow br0 "in_port=1,packet_type=(1,0x800),actions=decap(),set_field:1.1.1.1->nw_dst"

Re: [ovs-dev] how to get packet information in ovs-dpdk?

Now I see that you're reporting a bug in "ovs-dpdk", not in Open vSwitch. You should report that bug to an ovs-dpdk mailing list. On Thu, Jul 13, 2017 at 03:24:40PM +0800, Sam wrote: > Yes it is. > > I'm also confused, as when I use normal kernel based ovs-2.3.0, `ovs-ofctl > snoop br0` works

Re: [ovs-dev] ofport = -1?

On Thu, Jul 13, 2017 at 01:44:24PM +0200, Krzysztof Wojciechowski wrote: > If openvswitch thinks that interface is bad (but its, working - we have a > lot of interfaces looking like this on XenServer), how to get ofport number > provided by "ovs-ofctl show (bridge name)" using python? I don't

Re: [ovs-dev] [patch_v4 3/8] Userspace Datapath: Add missed lock annotations.

On Wed, Jul 05, 2017 at 09:32:21PM -0700, Darrell Ball wrote: > Fixes: a489b16854b5 ("conntrack: New userspace connection tracker.") > Fixes: 286de2729955 ("dpdk: Userspace Datapath: Introduce NAT Support.") > Signed-off-by: Darrell Ball Thanks for the patches. I applied

Re: [ovs-dev] ovs deleting flows issue

On 13 July 2017 at 04:10, Roi Dayan wrote: > Hi, > > We encountered an issue with deleting flows using dpctl del-flow and > del-flows that after deleting a flow it cannot be added again. For what it's worth, we don't really try to support this case. OVS assumes that it has

Re: [ovs-dev] Fail to netdev_open internal iface with error "File exists"

On Wed, Jul 05, 2017 at 05:03:06PM +0200, Eelco Chaudron wrote: > On 23/06/17 10:37, Eelco Chaudron wrote: > >On 06/23/2017 02:12 AM, Ben Pfaff wrote: > >>On Thu, Jun 22, 2017 at 04:04:44PM -0300, Flavio Leitner wrote: > >>>On Thu, Jun 22, 2017 at 01:04:59AM +0800, Huanle Han wrote: > Hi,all >

Re: [ovs-dev] [PATCH] ovn-controller: fix vlan_trunk bug

On Tue, Jul 04, 2017 at 06:14:09PM +0800, wang.qia...@zte.com.cn wrote: > The bug description is as follow: > > Neutron configure a trunk-sub port. The parent-port and sub-port located > in different network. there is a vm attached to parent port. And no vm > attached to the network of sub-port

Re: [ovs-dev] [PATCH 1/4] Add OF actions for generic encap and decap

Hi Ben, > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Tuesday, 11 July, 2017 23:46 > > What is your plan for handling ofpact_check__() with decap actions? > In general a decap() action reveals an inner packet that requires reparsing before any subsequent actions

Re: [ovs-dev] [PATCH net-next v1 0/3] Flow Based GTP Tunneling

On 13 July 2017 at 00:12, Harald Welte wrote: > hi Jiannan, > > net-next si closed, as it has been pointed out already by Joe. > > On Wed, Jul 12, 2017 at 05:44:52PM -0700, Jiannan Ouyang wrote: >> ovs-ofctl add-flow br0 >> "in_port=2,tun_src=192.168.60.141,tun_id=123, \

Re: [ovs-dev] [PATCH] netdev: fix missing shifts of VXLAN_EXT_GPE

On Fri, Jun 30, 2017 at 04:27:45PM -0400, Eric Garver wrote: > Contrary to the comment by the enum value, these are actually regular > enum values that need shifted. VXLAN_EXT_GBP for example is used as a > netlink value for vports. > > Fixes: 875ab13020b1 ("userspace: Handling of versatile

Re: [ovs-dev] [PATCH] datapath: Fix for force/commit action failures

On 13 July 2017 at 11:01, Greg Rose wrote: > On 07/13/2017 10:46 AM, Joe Stringer wrote: >> >> On 13 July 2017 at 09:25, Greg Rose wrote: >>> >>> When there is an established connection in direction A->B, it is >>> possible to receive a packet on port

Re: [ovs-dev] [PATCH net-next v1 2/3] gtp: Support creating flow-based gtp net_device

On 12 July 2017 at 17:44, Jiannan Ouyang wrote: > Add the gtp_create_flow_based_dev() interface to create flow-based gtp > net_device, which sets gtp->collect_md. Under flow-based mode, UDP sockets are > created and maintained in kernel. > > Signed-off-by: Jiannan Ouyang

Re: [ovs-dev] [PATCH] datapath: Fix for force/commit action failures

On 07/13/2017 10:46 AM, Joe Stringer wrote: On 13 July 2017 at 09:25, Greg Rose wrote: When there is an established connection in direction A->B, it is possible to receive a packet on port B which then executes ct(commit,force) without first performing ct() - ie, a

Re: [ovs-dev] [PATCH] ctags: include symbols with locking annotations.

On Mon, Jun 26, 2017 at 09:55:50PM -0300, Flavio Leitner wrote: > OVS uses extensively clang annotations for thread safety > checks. The ctags tool can't parse them, so they are not > included in the tag file. > > This patch improves the configure script to generate a list > of identifiers from

  1   2   >