Re: [ovs-dev] [PATCH 4/6] testsuite: Drain the list of jobs in the shell

2017-07-14 Thread Ben Pfaff
On Sat, Jul 15, 2017 at 11:23:04AM +0900, Takashi YAMAMOTO wrote: > Hi, > > 2017/07/15 6:55 "Ben Pfaff" : > > On Sat, Jul 15, 2017 at 02:39:44AM +0900, YAMAMOTO Takashi wrote: > > SUS says: > > When jobs reports the termination status of a job, > > the shell removes its

Re: [ovs-dev] incorrect revalidated action for igmp

2017-07-14 Thread Huanle Han
This patch can slove the problem. But I think wc->masks.tp_src should not be masked in userspace as igmp type is not supported in datapath. Otherwise, flow_wildcards_has_extra() in revalidate_ukey__ always return true for igmp megaflow, and igmp flow is never kept in datapath. Thanks, Huanle On

[ovs-dev] Your Consignment Boxes Delivery.

2017-07-14 Thread Mr. Grant Watson
MR GRANT WATSON UNITED NATION INSPECTION AGENCY HARTS FIELD-JACKSON INTERNATIONAL AIRPORT. ATLANTA, GEORGIA. I am GRANT WATSON Inspection Agency in Harts field-Jackson International Airport Atlanta, Georgia. During our investigation, I discovered an abandoned shipment through a Diplomat from

Re: [ovs-dev] [PATCH 4/6] testsuite: Drain the list of jobs in the shell

2017-07-14 Thread Takashi YAMAMOTO
Hi, 2017/07/15 6:55 "Ben Pfaff" : On Sat, Jul 15, 2017 at 02:39:44AM +0900, YAMAMOTO Takashi wrote: > SUS says: > When jobs reports the termination status of a job, > the shell removes its process ID from the list of those > "known in the current shell execution

Re: [ovs-dev] Fix up to the ovn-northd sync

2017-07-14 Thread Russell Bryant
On Thu, Jul 13, 2017 at 9:13 AM, Miguel Angel Ajo wrote: > This is a fixup and regression test I've written for the l3ha series > for an issue I found while restarting ovn-controllers around. > > I hope it looks good, it can be concatenated to the series, or I can > squash it

Re: [ovs-dev] [PATCH v5 1/8] ovn: l3ha, add extra check on distributed gateway ports

2017-07-14 Thread Russell Bryant
On Thu, Jul 13, 2017 at 1:02 PM, Miguel Angel Ajo wrote: > Check that removing the options:redirect-chassis in NBDB is > going to remove the cr-${port} in the SBDB. > > This is introduced to avoid any regression of this behaviour > on the l3ha series. > > Signed-off-by:

Re: [ovs-dev] [PATCH] tests: Disable no-format-truncation warnings

2017-07-14 Thread Russell Bryant
On Fri, Jul 14, 2017 at 4:46 AM, Timothy M. Redaelli wrote: > On 07/13/2017 07:21 PM, Ben Pfaff wrote: >> On Thu, Jul 13, 2017 at 04:29:33PM +0200, Timothy Redaelli wrote: >>> test_snprintf function (tests/test-util.c) tests snprintf with shorter >>> length, >>> but this

Re: [ovs-dev] [PATCH v2 4/4] tunneling: Avoid datapath-recirc by combining recirc actions at xlate.

2017-07-14 Thread Joe Stringer
On 4 July 2017 at 02:46, Sugesh Chandran wrote: > This patch set removes the recirculation of encapsulated tunnel packets > if possible. It is done by computing the post tunnel actions at the time of > translation. The combined nested action set are programmed in the

Re: [ovs-dev] [PATCH v2 2/4] xlate: Clear tunnel mask along with other fields while combine actions.

2017-07-14 Thread Joe Stringer
On 4 July 2017 at 02:46, Sugesh Chandran wrote: > The tunnel mask in the translation state should be cleared along with other > context fields. It is necessary in 'apply_nested_clone_actions' as it will be > used to combine post tunnel output actions with tunnel push.

Re: [ovs-dev] [PATCH v2 3/4] tunneling: Calculate and update packet l4_offset in tunnel push.

2017-07-14 Thread Joe Stringer
On 4 July 2017 at 02:46, Sugesh Chandran wrote: > The following tunnel combine patch series avoids the packets recirculation > after the tunnel push. So it is necessary to populate all relevant packet meta > data fields for the following combined action-set. > >

Re: [ovs-dev] [PATCH v2 1/4] xlate: Refactor translation of patch port output actions.

2017-07-14 Thread Joe Stringer
On 4 July 2017 at 02:46, Sugesh Chandran wrote: > Outputting to a patch port is translated by its peer patch port actions. > Refactoring the translation part to use later in the patch series for the > tunnel push. > > Signed-off-by: Sugesh Chandran

Re: [ovs-dev] [PATCH v2 1/3] ofproto-dpif-xlate: drop L3 packets on L2 legacy port

2017-07-14 Thread Ben Pfaff
On Fri, Jul 14, 2017 at 09:24:29PM +0200, Zoltán Balogh wrote: > From: Zoltán Balogh > > This commit drops packet during xlate if it is a L3 packet and output > port packet_type is legacy_l2. New PTAP unit test is added. > > Signed-off-by: Zoltán Balogh

Re: [ovs-dev] [PATCH] sparse: Add missing protoype for sendmmsg.

2017-07-14 Thread Ben Pfaff
On Fri, Jul 14, 2017 at 03:04:47PM -0700, Joe Stringer wrote: > On 14 July 2017 at 14:20, Ben Pfaff wrote: > > Reported-by: Joe Stringer > > Signed-off-by: Ben Pfaff > > Fixes: 00f5565c7eed ("socket-util: Fix recursion issue in sendmmsg") > > --- > >

Re: [ovs-dev] [PATCH] sparse: Add missing protoype for sendmmsg.

2017-07-14 Thread Joe Stringer
On 14 July 2017 at 14:20, Ben Pfaff wrote: > Reported-by: Joe Stringer > Signed-off-by: Ben Pfaff > Fixes: 00f5565c7eed ("socket-util: Fix recursion issue in sendmmsg") > --- Thanks for the quick response! Acked-by: Joe Stringer

Re: [ovs-dev] [PATCH v5 3/4] ovsdb-idl: idl compound indexes implementation

2017-07-14 Thread Lance Richardson
> From: "Rodriguez Betancourt, Esteban" > To: "Lance Richardson" > Cc: "Ben Pfaff" , d...@openvswitch.org, "Javier Albornoz" > , "Arnoldo Lutz" > > Sent: Friday, 14 July, 2017 5:27:44 PM

Re: [ovs-dev] [PATCH 6/6] packet-type-aware.at: Avoid GNU extension

2017-07-14 Thread Ben Pfaff
On Sat, Jul 15, 2017 at 02:39:46AM +0900, YAMAMOTO Takashi wrote: > \t is GNU sed extension. > > Signed-off-by: YAMAMOTO Takashi Acked-by: Ben Pfaff ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH 5/6] ovn.at: Use a correct operator in a test expression

2017-07-14 Thread Ben Pfaff
On Sat, Jul 15, 2017 at 02:39:45AM +0900, YAMAMOTO Takashi wrote: > == is a GNU extension. > > Signed-off-by: YAMAMOTO Takashi I wish this didn't exist in the GNU version. It's a useless extension. Acked-by: Ben Pfaff

Re: [ovs-dev] [PATCH 3/6] pmd.at: Avoid using GNU sed extension

2017-07-14 Thread Ben Pfaff
On Sat, Jul 15, 2017 at 02:39:43AM +0900, YAMAMOTO Takashi wrote: > BRE alternative (\|) is an GNU sed extension. [1] > It isn't available in NetBSD sed. > > [1] http://www.gnu.org/software/sed/manual/sed.html#Regular-Expressions > regexp1\|regexp2 > Matches either regexp1 or regexp2.

Re: [ovs-dev] [PATCH 2/6] NetBSD: Stop recommending pkg_alternatives

2017-07-14 Thread Ben Pfaff
On Sat, Jul 15, 2017 at 02:39:42AM +0900, YAMAMOTO Takashi wrote: > Because: > - It's no longer necessary > - It can cause problems for some utilities (e.g. ovs-pcap) > Cf. http://gnats.netbsd.org/cgi-bin/query-pr-single.pl?number=51152 > > Signed-off-by: YAMAMOTO Takashi

Re: [ovs-dev] [PATCH 1/6] interface-reconfigure.at: Use $PYTHON explicitly

2017-07-14 Thread Ben Pfaff
On Sat, Jul 15, 2017 at 02:39:41AM +0900, YAMAMOTO Takashi wrote: > Workaround pkg_alternative issue for NetBSD: > http://gnats.netbsd.org/cgi-bin/query-pr-single.pl?number=51152 > > An alternative would be generating xenserver scripts from *.in, > but i'm not sure if it's appropriate for

Re: [ovs-dev] [PATCH 4/6] testsuite: Drain the list of jobs in the shell

2017-07-14 Thread Ben Pfaff
On Sat, Jul 15, 2017 at 02:39:44AM +0900, YAMAMOTO Takashi wrote: > SUS says: > When jobs reports the termination status of a job, > the shell removes its process ID from the list of those > "known in the current shell execution environment"; > > With NetBSD /bin/sh, the list involves

Re: [ovs-dev] [PATCH] checkpatch: Check for trailing operators.

2017-07-14 Thread Joe Stringer
On 14 July 2017 at 14:29, Ben Pfaff wrote: > On Fri, Jul 14, 2017 at 02:22:16PM -0700, Joe Stringer wrote: >> On 14 July 2017 at 14:03, Ben Pfaff wrote: >> > On Fri, Jul 14, 2017 at 01:59:06PM -0700, Joe Stringer wrote: >> >> The style guide states that lines should

Re: [ovs-dev] [PATCH] Free port bindings when deleting cached ports.

2017-07-14 Thread Ben Pfaff
On Fri, Jul 14, 2017 at 02:27:24PM -0500, Mark Michelson wrote: > Running test "ovn-controller-vtep binding 2" with address sanitizer > enabled resulted in a failure due to a memory leak. The cached switch > port's bindings were not being freed when the port was freed. The > fix is to destroy the

Re: [ovs-dev] [PATCH] Support IPv6 link-local address scopes on Linux.

2017-07-14 Thread Ben Pfaff
On Wed, Jul 12, 2017 at 07:11:31AM +, Darrell Ball wrote: > > > On 7/11/17, 9:23 PM, "Ben Pfaff" wrote: > > Thanks for the review. > > I'm very new to the concept of IPv6 link-local address scoping. What > does this subset out of the larger feature? > >

[ovs-dev] [PATCH v2 3/3] Support IPv6 link-local address scopes on Linux.

2017-07-14 Thread Ben Pfaff
I hadn't even heard of this feature before, but it seems to be at least semi-standard to support Linux link-local address scopes via a % suffix, e.g. fe80::1234%eth0 for a link-local address scoped to eth0. This commit adds support. I'd appreciate feedback from folks who understand this feature

[ovs-dev] [PATCH v2 2/3] socket-util: Change ss_format_address() to take a dynamic string.

2017-07-14 Thread Ben Pfaff
It's occasionally convenient to format into a fixed-size buffer, but as the use cases, and the text to be formatted, get more sophisticated, it becomes easier to deal with "struct ds *" than a buffer pointer and length pair. An upcoming commit will make ss_format_address() do more work, and I

[ovs-dev] [PATCH v2 0/3] Support IPv6 link-local address scopes on Linux

2017-07-14 Thread Ben Pfaff
v1->v2: * Patches 1 and 2 are new. * Patch 3 now formats addresses with scope, instead of just parsing them. Patch 3 accepts ifindexes instead of just interface names. Ben Pfaff (3): stream: Make [p]stream_init() take ownership of 'name' parameter. socket-util: Change

Re: [ovs-dev] [PATCH] checkpatch: Check for trailing operators.

2017-07-14 Thread Ben Pfaff
On Fri, Jul 14, 2017 at 02:22:16PM -0700, Joe Stringer wrote: > On 14 July 2017 at 14:03, Ben Pfaff wrote: > > On Fri, Jul 14, 2017 at 01:59:06PM -0700, Joe Stringer wrote: > >> The style guide states that lines should not end with '&&', '||' '&' > >> '|', '?', ':'. Check for this

Re: [ovs-dev] [PATCH v5 3/4] ovsdb-idl: idl compound indexes implementation

2017-07-14 Thread Rodriguez Betancourt, Esteban
I think that is ok to remove that last pointer check in the generic comparison function. UUID is more than enough. Regards, Esteban > -Original Message- > From: Lance Richardson [mailto:lrich...@redhat.com] > Sent: jueves, 13 de julio de 2017 16:48 > To: Rodriguez Betancourt, Esteban

Re: [ovs-dev] [PATCH] checkpatch: Check for trailing operators.

2017-07-14 Thread Joe Stringer
On 14 July 2017 at 14:03, Ben Pfaff wrote: > On Fri, Jul 14, 2017 at 01:59:06PM -0700, Joe Stringer wrote: >> The style guide states that lines should not end with '&&', '||' '&' >> '|', '?', ':'. Check for this and report an error. >> >> Signed-off-by: Joe Stringer >

Re: [ovs-dev] [PATCH v1] socket-util: Fix recursion issue in sendmmsg

2017-07-14 Thread Ben Pfaff
On Fri, Jul 14, 2017 at 01:11:01PM -0700, Joe Stringer wrote: > On 14 July 2017 at 08:41, Ben Pfaff wrote: > > On Fri, Jul 14, 2017 at 03:06:50PM +, Zhenyu Gao wrote: > >> The wrap_sendmmsg has infinite recursion issue. > >> Fix it by undef sendmmsg. > >> > >> Signed-off-by:

Re: [ovs-dev] [PATCH] checkpatch: Check for trailing operators.

2017-07-14 Thread Ben Pfaff
On Fri, Jul 14, 2017 at 01:59:06PM -0700, Joe Stringer wrote: > The style guide states that lines should not end with '&&', '||' '&' > '|', '?', ':'. Check for this and report an error. > > Signed-off-by: Joe Stringer Hmm, is that right? It's pretty explicit about ?:, but I don't

[ovs-dev] [PATCH] checkpatch: Check for trailing operators.

2017-07-14 Thread Joe Stringer
The style guide states that lines should not end with '&&', '||' '&' '|', '?', ':'. Check for this and report an error. Signed-off-by: Joe Stringer --- utilities/checkpatch.py | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/utilities/checkpatch.py

Re: [ovs-dev] [PATCH] dp-packet: Remove misleading comment for refill init function.

2017-07-14 Thread Andy Zhou
On Fri, Jul 14, 2017 at 1:11 AM, Ilya Maximets wrote: > Function 'dp_packet_batch_refill_init' doesn't return anything. > Looks like this comment came from one of the intermediate versions > of the API enhancement patch. Additionally comment style changed > to be

Re: [ovs-dev] [PATCH v1] socket-util: Fix recursion issue in sendmmsg

2017-07-14 Thread Joe Stringer
On 14 July 2017 at 08:41, Ben Pfaff wrote: > On Fri, Jul 14, 2017 at 03:06:50PM +, Zhenyu Gao wrote: >> The wrap_sendmmsg has infinite recursion issue. >> Fix it by undef sendmmsg. >> >> Signed-off-by: Zhenyu Gao > > Thanks! I applied this to master.

Re: [ovs-dev] [PATCH] ofproto.at: Fix minor typo in test.

2017-07-14 Thread Ben Pfaff
On Sun, Jul 09, 2017 at 11:51:40PM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit > --- > tests/ofproto.at | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/ofproto.at b/tests/ofproto.at > index 9e6acfad653d..c7ea31a77ce9 100644 > ---

Re: [ovs-dev] [PATCH] vlog: Make "vlog/set" without args set everything to "dbg".

2017-07-14 Thread Ben Pfaff
On Sun, Jul 09, 2017 at 11:51:41PM -0700, Justin Pettit wrote: > The documentation stated that "ovs-appctl vlog/set" without any > arguments should set every module and destination to debug level. > > Signed-off-by: Justin Pettit Acked-by: Ben Pfaff

Re: [ovs-dev] [PATCH] dpif-netdev: Initialize 'tun_md' member of match.

2017-07-14 Thread Ben Pfaff
On Sun, Jul 09, 2017 at 11:51:38PM -0700, Justin Pettit wrote: > Found by valgrind. Acked-by: Ben Pfaff ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] ofp-util: Update OpenFlow 1.6 port support to track latest proposal.

2017-07-14 Thread Ben Pfaff
The latest updates to the OpenFlow 1.6 proposal removes the hw_addr_type fields from ofp_port and ofp_port_mod. This commit updates the OVS prototype to match the updated proposal. ONF-JIRA: EXT-566 Signed-off-by: Ben Pfaff --- include/openflow/openflow-1.6.h | 13 +++--

[ovs-dev] [PATCH V3 net] openvswitch: Fix for force/commit action failures

2017-07-14 Thread Greg Rose
When there is an established connection in direction A->B, it is possible to receive a packet on port B which then executes ct(commit,force) without first performing ct() - ie, a lookup. In this case, we would expect that this packet can delete the existing entry so that we can commit a connection

Re: [ovs-dev] [patch_v4 4/8] Userspace Datapath: Add ALG infra and FTP.

2017-07-14 Thread Ben Pfaff
Wow, that was fast. I'll look forward to v5. On Fri, Jul 14, 2017 at 05:37:43PM +, Darrell Ball wrote: > Thanks a lot for the review Ben > > On 7/13/17, 3:15 PM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff" > wrote: >

[ovs-dev] [PATCH] Free port bindings when deleting cached ports.

2017-07-14 Thread Mark Michelson
Running test "ovn-controller-vtep binding 2" with address sanitizer enabled resulted in a failure due to a memory leak. The cached switch port's bindings were not being freed when the port was freed. The fix is to destroy the bindings hash table when the switch port is freed. Signed-off-by: Mark

[ovs-dev] [PATCH v2 3/3] tests: Extend PTAP unit tests with decap action

2017-07-14 Thread Zoltán Balogh
From: Zoltán Balogh - Checking decap() prerequisits. - Send L3 packet over patch port. - Output L2/L3 packet to ports with different packet_type properties. Signed-off-by: Zoltán Balogh Suggested-by: Jan Scheurich

[ovs-dev] [PATCH v2 2/3] OF support and translation of generic encap and decap

2017-07-14 Thread Zoltán Balogh
From: Jan Scheurich This commit adds support for the OpenFlow actions generic encap and decap (as specified in ONF EXT-382) to the OVS control plane. CLI syntax for encap action with properties: encap(hdr=) encap(hdr=, prop(class=,type=,val=),

[ovs-dev] [PATCH v2 1/3] ofproto-dpif-xlate: drop L3 packets on L2 legacy port

2017-07-14 Thread Zoltán Balogh
From: Zoltán Balogh This commit drops packet during xlate if it is a L3 packet and output port packet_type is legacy_l2. New PTAP unit test is added. Signed-off-by: Zoltán Balogh --- ofproto/ofproto-dpif-xlate.c | 23 +++-

[ovs-dev] [PATCH v2 0/3] basic encap/decap

2017-07-14 Thread Zoltán Balogh
From: Zoltán Balogh This series is a continuation of other patch series initiated by Jan Scheurich before. These were already applied to the master branch: - userspace: Support for L3 tunneling https://mail.openvswitch.org/pipermail/ovs-dev/2017-June/87.html

[ovs-dev] [PATCH v7 4/7] ovsdb-idl: Autogenerated functions for compound indexes

2017-07-14 Thread Lance Richardson
Generates and fills in the default comparators for columns with type int, real, string. Also creates the macros that allow iteration over the contents of the index, and perform queries. Signed-off-by: Arnoldo Lutz Guevara Signed-off-by: Esteban Rodriguez Betancourt

[ovs-dev] [PATCH v7 6/7] ovn-controller: use idl indexes for logical port table

2017-07-14 Thread Lance Richardson
Use IDL index for logical port table lookups, avoiding the overhead of creating/destroying an index hmap for each iteration of the ovn-controller main loop. Signed-off-by: Lance Richardson --- v7: New patch. ovn/controller/binding.c| 27 ---

[ovs-dev] [PATCH v7 7/7] ovn-controller: use idl indexes for logical datapath

2017-07-14 Thread Lance Richardson
Use IDL index to iterate over all logical ports in a given logical datapath, avoiding the overhead of creating/destroying an indexing data structure in each iteration of the ovn-controller main loop. Signed-off-by: Lance Richardson --- v7: New patch.

[ovs-dev] [PATCH v7 5/7] ovn-controller: use idl index for multicast group table

2017-07-14 Thread Lance Richardson
Use IDL index for multicast group table lookups, avoiding the overhead of creating/destroying an index hmap for each iteration of the ovn-controller main loop. Signed-off-by: Lance Richardson --- v7: New patch. ovn/controller/lflow.c | 20 +-

[ovs-dev] [PATCH v7 3/7] ovsdb-idl: idl compound indexes implementation

2017-07-14 Thread Lance Richardson
This patch adds support for the creation of multicolumn indexes in the C IDL to enable for efficient search and retrieval of database rows by key. Signed-off-by: Esteban Rodriguez Betancourt Co-authored-by: Lance Richardson Signed-off-by: Lance Richardson

[ovs-dev] [PATCH v7 1/7] ovsdb-idl: compound indexes design document

2017-07-14 Thread Lance Richardson
In the work made in our projects, it was found the need to have a faster access to the rows contained in tables in the replica, as well to have the possibility to loop over a subset of rows that meet some specified criteria. Those needs lead us to design and implement a functionality that

[ovs-dev] [PATCH v7 2/7] lib: skiplist implementation

2017-07-14 Thread Lance Richardson
Skiplist implementation intended for use in the IDL compound indexes feature. Signed-off-by: Esteban Rodriguez Betancourt Co-authored-by: Lance Richardson Signed-off-by: Lance Richardson --- v7: - More coding style fixes, provided by

[ovs-dev] [PATCH v7 0/7] ovsdb-idl: ovsdb client index support

2017-07-14 Thread Lance Richardson
This set of patches is based on a series authored by Esteban Rodriguez Betancourt, Jorge Arturo Sauma Vargas, Javier Albornoz, and Arnoldo Lutz Guevara that has been inactive for a number of months. v7: - Added patches to make use of client idl indexing in ovn-controller (these were

Re: [ovs-dev] [PATCHv3] ofproto-dpif: Detect support for ct_tuple6.

2017-07-14 Thread Joe Stringer
On 6 July 2017 at 16:58, Ben Pfaff wrote: > On Fri, Jun 02, 2017 at 09:38:47AM -0700, Joe Stringer wrote: >> Support for extracting original direction 5 tuple fields from the >> connection tracking module may differ on some platforms between the IPv4 >> original tuple fields vs.

Re: [ovs-dev] [PATCH net] openvswitch: Fix for force/commit action failures

2017-07-14 Thread Greg Rose
On 07/14/2017 11:42 AM, Joe Stringer wrote: On 14 July 2017 at 09:10, Greg Rose wrote: > When there is an established connection in direction A->B, it is > possible to receive a packet on port B which then executes > ct(commit,force) without first performing ct() - ie, a

Re: [ovs-dev] [PATCH net] openvswitch: Fix for force/commit action failures

2017-07-14 Thread Joe Stringer
On 14 July 2017 at 09:10, Greg Rose wrote: > When there is an established connection in direction A->B, it is > possible to receive a packet on port B which then executes > ct(commit,force) without first performing ct() - ie, a lookup. > In this case, we would expect that

Re: [ovs-dev] [PATCH net] openvswitch: Fix for force/commit action failures

2017-07-14 Thread Joe Stringer
On 14 July 2017 at 09:10, Greg Rose wrote: > When there is an established connection in direction A->B, it is > possible to receive a packet on port B which then executes > ct(commit,force) without first performing ct() - ie, a lookup. > In this case, we would expect that

Re: [ovs-dev] [PATCH 3/3] dpctl: Add new 'ct-bkts' command.

2017-07-14 Thread Ben Pfaff
On Fri, Jul 14, 2017 at 10:11:04AM +, Fischetti, Antonio wrote: > Thanks Ben for your feedback, my replies inline. > > > -Original Message- > > From: Ben Pfaff [mailto:b...@ovn.org] > > Sent: Tuesday, July 11, 2017 8:54 PM > > To: Fischetti, Antonio > >

Re: [ovs-dev] [PATCH] system-traffic: 802.1ad: Add double VLAN match test case

2017-07-14 Thread Joe Stringer
On 15 June 2017 at 17:15, Eric Garver wrote: > On Thu, Jun 15, 2017 at 04:49:17PM -0700, Joe Stringer wrote: >> On 8 June 2017 at 14:42, Joe Stringer wrote: >> > Yes, I'm the right person. >> > >> > At this point I'm looking for the tap device persistence issue to be

Re: [ovs-dev] [PATCH 0/4] system-traffic: Add basic IPv6 underlay tunnel tests

2017-07-14 Thread Joe Stringer
On 7 July 2017 at 11:32, Ben Pfaff wrote: > On Wed, Jun 07, 2017 at 07:54:23PM -0400, Eric Garver wrote: >> Currently there is no system-traffic coverage for tunnels with IPv6 >> underlays. >> This series adds very basic ping tests for VXLANv6 and GENEVEv6. >> >> Note: GREv6 is not

Re: [ovs-dev] [PATCH 00/40] Fix static code analysis warnings.

2017-07-14 Thread Shashank Ram
Alin, thanks a lot for this important series! Could you please test out all these changes with Driver verifier and ensure that it does not introduce new regressions such as memory leaks, deadlocks etc. Thanks, Shashank From:

Re: [ovs-dev] [PATCH 37/40] datapath-windows: Add annotation for OvsIpFragmentEntryCleaner

2017-07-14 Thread Shashank Ram
From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Thursday, July 13, 2017 9:40 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH 37/40] datapath-windows: Add

Re: [ovs-dev] [PATCH 35/40] datapath-windows: Treat TCP_HDR_LEN static analysis warnings

2017-07-14 Thread Shashank Ram
From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Thursday, July 13, 2017 9:40 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH 35/40] datapath-windows: Treat

Re: [ovs-dev] [PATCH 40/40] datapath-windows: Fix static analysis warnings around ovsInstanceListLock

2017-07-14 Thread Shashank Ram
Comments inline. Thanks, Shashank From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Thursday, July 13, 2017 9:40 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH

[ovs-dev] [PATCH 6/6] packet-type-aware.at: Avoid GNU extension

2017-07-14 Thread YAMAMOTO Takashi
\t is GNU sed extension. Signed-off-by: YAMAMOTO Takashi --- tests/packet-type-aware.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/packet-type-aware.at b/tests/packet-type-aware.at index 1104078..2eee7f4 100644 --- a/tests/packet-type-aware.at

[ovs-dev] [PATCH 5/6] ovn.at: Use a correct operator in a test expression

2017-07-14 Thread YAMAMOTO Takashi
== is a GNU extension. Signed-off-by: YAMAMOTO Takashi --- tests/ovn.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ovn.at b/tests/ovn.at index efcbd91..06edcaa 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -7459,7 +7459,7 @@ test_packet() {

[ovs-dev] [PATCH 4/6] testsuite: Drain the list of jobs in the shell

2017-07-14 Thread YAMAMOTO Takashi
SUS says: When jobs reports the termination status of a job, the shell removes its process ID from the list of those "known in the current shell execution environment"; With NetBSD /bin/sh, the list involves zombie processes and ends up with "can not fork" during test runs. ---

[ovs-dev] [PATCH 3/6] pmd.at: Avoid using GNU sed extension

2017-07-14 Thread YAMAMOTO Takashi
BRE alternative (\|) is an GNU sed extension. [1] It isn't available in NetBSD sed. [1] http://www.gnu.org/software/sed/manual/sed.html#Regular-Expressions regexp1\|regexp2 Matches either regexp1 or regexp2. Use parentheses to use complex alternative regular expressions. The

[ovs-dev] [PATCH 2/6] NetBSD: Stop recommending pkg_alternatives

2017-07-14 Thread YAMAMOTO Takashi
Because: - It's no longer necessary - It can cause problems for some utilities (e.g. ovs-pcap) Cf. http://gnats.netbsd.org/cgi-bin/query-pr-single.pl?number=51152 Signed-off-by: YAMAMOTO Takashi --- Documentation/intro/install/netbsd.rst | 1 - 1 file changed, 1 deletion(-)

Re: [ovs-dev] [PATCH 32/40] datapath-windows: fix excessive stack usage in iphelper

2017-07-14 Thread Shashank Ram
From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Thursday, July 13, 2017 9:40 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH 32/40] datapath-windows: fix

Re: [ovs-dev] [PATCH 38/40] datapath-windows: Fix shared variables which use Interlocked functions

2017-07-14 Thread Shashank Ram
From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Thursday, July 13, 2017 9:40 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH 38/40] datapath-windows: Fix

Re: [ovs-dev] [patch_v4 5/8] Userspace Datapath: Add TFTP support.

2017-07-14 Thread Darrell Ball
On 7/13/17, 3:19 PM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff" wrote: On Wed, Jul 05, 2017 at 09:32:23PM -0700, Darrell Ball wrote: > Both ipv4 and ipv6 are supported. Also, NAT support is included. > >

Re: [ovs-dev] [patch_v4 4/8] Userspace Datapath: Add ALG infra and FTP.

2017-07-14 Thread Darrell Ball
Thanks a lot for the review Ben On 7/13/17, 3:15 PM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff" wrote: On Wed, Jul 05, 2017 at 09:32:22PM -0700, Darrell Ball wrote: > ALG infra and FTP (both V4 and V6) support is

Re: [ovs-dev] [PATCH 36/40] datapath-windows: Add annotation for OvsCtRelatedEntryCleaner

2017-07-14 Thread Shashank Ram
From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Thursday, July 13, 2017 9:40 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH 36/40] datapath-windows: Add

Re: [ovs-dev] [PATCH 33/40] datapath-windows: Check return status when using APIs

2017-07-14 Thread Shashank Ram
From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Thursday, July 13, 2017 9:40 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH 33/40] datapath-windows: Check

Re: [ovs-dev] [PATCH 34/40] datapath-windows: Vport check RtlStringCbLengthW return value

2017-07-14 Thread Shashank Ram
Minor nit inline. From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Thursday, July 13, 2017 9:40 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH 34/40]

Re: [ovs-dev] [PATCH 31/40] datapath-windows: prettify logging in iphelper

2017-07-14 Thread Shashank Ram
Minor nits inline. Thanks, Shashank From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Thursday, July 13, 2017 9:40 PM To: d...@openvswitch.org Subject: [ovs-dev]

Re: [ovs-dev] [PATCH 30/40] datapath-windows: Add dummy parameter for NotifyRouteChange2

2017-07-14 Thread Shashank Ram
From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Thursday, July 13, 2017 9:40 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH 30/40] datapath-windows: Add

Re: [ovs-dev] [PATCH 26/40] datapath-windows: Use annotations instead for macros

2017-07-14 Thread Shashank Ram
From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Thursday, July 13, 2017 9:40 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH 26/40] datapath-windows: Use

Re: [ovs-dev] [PATCH v1 0/2] Add GTP vport based on upstream datapath

2017-07-14 Thread Amar Padmanabhan
Yeah, we are looking at tunnel termination in OVS, i.e. GGSN or PGW. I think what you mention Weiger is about an on-path device that also does some classification like some of the 5G proposals. I think Yi is also looking at it but that is not directly related to this patch set. - Amar On

Re: [ovs-dev] [PATCH 19/40] datapath-windows: Add function annotations for OvsTunnelFilterCancelIrp

2017-07-14 Thread Shashank Ram
From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Thursday, July 13, 2017 9:40 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH 19/40] datapath-windows: Add

Re: [ovs-dev] [PATCH 29/40] datapath-windows: Suppress warning in jhash

2017-07-14 Thread Shashank Ram
From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Thursday, July 13, 2017 9:40 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH 29/40] datapath-windows:

Re: [ovs-dev] [PATCH 01/40] datapath-windows: Use only non executable memory

2017-07-14 Thread Shashank Ram
Comments inline. Thanks, Shashank From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Thursday, July 13, 2017 9:40 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH

Re: [ovs-dev] [PATCH 28/40] datapath-windows: Fix possible NULL deference in OvsFullCopyNBL

2017-07-14 Thread Shashank Ram
From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Thursday, July 13, 2017 9:40 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH 28/40] datapath-windows: Fix

Re: [ovs-dev] [PATCH 21/40] datapath-windows: Add function annotations for OvsAcquireEventQueueLock

2017-07-14 Thread Shashank Ram
From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Thursday, July 13, 2017 9:40 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH 21/40] datapath-windows: Add

Re: [ovs-dev] [PATCH 17/40] datapath-windows: Add function annotations for OvsReleaseDatapath

2017-07-14 Thread Shashank Ram
From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Thursday, July 13, 2017 9:40 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH 17/40] datapath-windows: Add

Re: [ovs-dev] [PATCH 25/40] datapath-windows: Fix spelling for OvsTunnelFilterSetIrpContext

2017-07-14 Thread Shashank Ram
Minor nit: Change commit message to "datapath-windows: Fix a spelling in the comment" Thanks, Shashank From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Thursday,

Re: [ovs-dev] Very Urgent

2017-07-14 Thread Aeberhardt Dania
Outlook Dear account User, A few of your incoming mails were placed on pending status due to the recent upgrade on our database. In order to receive your messages, click on the link below to login and wait for response from Webmail. CLICK HERE

Re: [ovs-dev] [PATCH 27/40] datapath-windows: Add assert in OvsPartialCopyNBL

2017-07-14 Thread Shashank Ram
From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Thursday, July 13, 2017 9:40 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH 27/40] datapath-windows: Add

Re: [ovs-dev] [PATCH 24/40] datapath-windows: Add annotations for OvsAcquirePidHashLock

2017-07-14 Thread Shashank Ram
From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Thursday, July 13, 2017 9:40 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH 24/40] datapath-windows: Add

Re: [ovs-dev] [PATCH 18/40] datapath-windows: Add function annotations for OvsCancelIrp

2017-07-14 Thread Shashank Ram
From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Thursday, July 13, 2017 9:40 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH 18/40] datapath-windows: Add

Re: [ovs-dev] [PATCH 16/40] datapath-windows: Add function annotations for OvsAcquireDatapathWrite

2017-07-14 Thread Shashank Ram
From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Thursday, July 13, 2017 9:40 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH 16/40] datapath-windows: Add

Re: [ovs-dev] [PATCH 23/40] datapath-windows: Add annotations for OvsReleasePidHashLock

2017-07-14 Thread Shashank Ram
From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Thursday, July 13, 2017 9:40 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH 23/40] datapath-windows: Add

Re: [ovs-dev] [PATCH 22/40] datapath-windows: Add annotations for OvsReleaseEventQueueLock

2017-07-14 Thread Shashank Ram
From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Thursday, July 13, 2017 9:40 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH 22/40] datapath-windows: Add

Re: [ovs-dev] [PATCH 14/40] datapath-windows: Remove function declarations from Tunnel.c

2017-07-14 Thread Shashank Ram
From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Thursday, July 13, 2017 9:40 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH 14/40] datapath-windows: Remove

Re: [ovs-dev] [PATCH 12/40] datapath-windows: Add annotations for OvsAcquireCtrlLock

2017-07-14 Thread Shashank Ram
From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Thursday, July 13, 2017 9:40 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH 12/40] datapath-windows: Add

Re: [ovs-dev] [PATCH 20/40] datapath-windows: Add function annotations for OvsCancelIrpDatapath

2017-07-14 Thread Shashank Ram
From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Thursday, July 13, 2017 9:40 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH 20/40] datapath-windows: Add

Re: [ovs-dev] [PATCH v1 0/2] Add GTP vport based on upstream datapath

2017-07-14 Thread Joe Stringer
On 14 July 2017 at 04:53, Wieger IJntema wrote: >> ovs-vsctl add-port br0 gtp-vport -- set interface gtp-vport \ >> ofport_request=2 type=gtp option:remote_ip=flow options:key=flow >> >> ovs-ofctl add-flow br0 >> "in_port=2,tun_src=192.168.60.141,tun_id=123,

Re: [ovs-dev] [PATCH 15/40] datapath-windows: Add function annotations for OvsAcquireDatapathRead

2017-07-14 Thread Shashank Ram
From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Thursday, July 13, 2017 9:40 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH 15/40] datapath-windows: Add

  1   2   >