[ovs-dev] Openvswitch crash when bringing down the dpdk bond port using "ovs-ofctl mod-port br-prv dpdk1 down"

2017-07-25 Thread Keshav Gupta
Hi We are experiencing a openvswitch crash when bringing down the dpdk bond port using "ovs-ofctl mod-port br-prv dpdk1 down". backtrace of core is like below. Is there any issue reported earlier for this type of crash in openvswitch community. (gdb) bt #0 ixgbe_rxq_rearm

[ovs-dev] [patch_v1] dpdk: Fix device cleanup.

2017-07-25 Thread Darrell Ball
Commit 5dcde09c80a8 was introduced to make detaching more automatic without using an additional command. Sometimes, since commit 5dcde09c80a8, dpdk devices are not detached when del-port is issued; command example: sudo ovs-vsctl del-port br0 dpdk1 This can happen when vswitchd is (re)started

Re: [ovs-dev] [PATCH v4] Update relevant artifacts to add support for DPDK 17.05.1.

2017-07-25 Thread Darrell Ball
Hi Aaron You had mentioned that you would be testing with the patch as well. Were you able to try it ? Thanks Darrell -Original Message- From: on behalf of Kevin Traynor Organization: Red Hat Date: Tuesday, July 25, 2017 at 9:35

Re: [ovs-dev] [PATCH v2 2/3] dpif-netdev: Avoid port's reconfiguration on pmd-cpu-mask changes.

2017-07-25 Thread Darrell Ball
-Original Message- From: Ilya Maximets Date: Monday, July 24, 2017 at 4:58 AM To: Darrell Ball , "d...@openvswitch.org" Cc: Heetae Ahn , Daniele Di Proietto , Ben Pfaff

Re: [ovs-dev] [PATCH v3 0/2] basic encap/decap

2017-07-25 Thread Yang, Yi Y
Hi, folks It seems Ben is out of office in these days, can anybody help review or merge this patch series? I heard 2.8 branch would be created end of July, but we still have NSH patch series waiting for review except this series. -Original Message- From: ovs-dev-boun...@openvswitch.org

Re: [ovs-dev] [PATCH v2 1/3] flow: Add flow_compose_size().

2017-07-25 Thread Andy Zhou
On Tue, Jul 25, 2017 at 6:02 AM, Ilya Maximets wrote: > This allows to compose packets with different real lenghts from > odp flows i.e. memory will be allocated for requested packet > size and all required headers like ip->tot_len filled correctly. > > Will be used in

[ovs-dev] [PATCH] flow: Refactor flow_compose() API.

2017-07-25 Thread Andy Zhou
Currently, flow_compose_size() is only supposed to be called after flow_compose(). I find this API to be unintuitive. Change flow_compose() API to take the 'size' argument, and returns 'true' if the packet can be created, 'false' otherwise. This change also improves error detection and reporting

Re: [ovs-dev] [PATCH] AUTHORS.rst: Add Mark Michelson.

2017-07-25 Thread Russell Bryant
On Tue, Jul 25, 2017 at 3:40 PM, Russell Bryant wrote: > Mark authored commit 747c31c9. > > Signed-off-by: Russell Bryant I went ahead and applied this when applying another patch from Mark. ___ dev mailing list

Re: [ovs-dev] [PATCH] stream-ssl: Fix memory leak in error scenario

2017-07-25 Thread Russell Bryant
On Fri, Jul 21, 2017 at 4:46 PM, Mark Michelson wrote: > ssl_new_stream() takes ownership of the passed-in 'name' parameter. > In error scenarios, the name is leaked. I was able to trigger this > leak by attempting to connect to an ovsdb over SSL and specifying > non-existent

Re: [ovs-dev] [PATCH] AUTHORS.rst: Add Mark Michelson.

2017-07-25 Thread Lance Richardson
> From: "Russell Bryant" > To: d...@openvswitch.org > Sent: Tuesday, 25 July, 2017 3:40:33 PM > Subject: [ovs-dev] [PATCH] AUTHORS.rst: Add Mark Michelson. > > Mark authored commit 747c31c9. > > Signed-off-by: Russell Bryant > --- > AUTHORS.rst | 1 + > 1

[ovs-dev] [PATCH] AUTHORS.rst: Add Mark Michelson.

2017-07-25 Thread Russell Bryant
Mark authored commit 747c31c9. Signed-off-by: Russell Bryant --- AUTHORS.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/AUTHORS.rst b/AUTHORS.rst index 177cef8fd..21a68c140 100644 --- a/AUTHORS.rst +++ b/AUTHORS.rst @@ -208,6 +208,7 @@ Mark D. Gray

Re: [ovs-dev] [PATCH v2 1/3] vswitch.xml: Fix L2 balancing mentioning for balance-tcp bond.

2017-07-25 Thread Andy Zhou
Thanks. I have pushed the series to master. While applying the patches. I noticed a minor issue and sent a follow up patch at: https://mail.openvswitch.org/pipermail/ovs-dev/2017-July/336231.html Will consider back porting after this patch is reviewed. On Tue, Jul 25, 2017 at 3:46 AM, Ilya

[ovs-dev] [PATCH] bond: Adjust bond hash masks

2017-07-25 Thread Andy Zhou
Commit 42781e77035d (bond: Unify hash functions in hash action and entry lookup.) changed the BM_TCP's hash function, but did not update hash mask fields accordingly. Found by inspection. CC: Ilya Maximets Signed-off-by: Andy Zhou --- ofproto/bond.c | 5

[ovs-dev] [PATCH 2/2] ovs-bugtool: Run the 'dmesg' command without condition.

2017-07-25 Thread Gurucharan Shetty
Currently we look for files with the name of "dmesg" in "/var/log". If it exists, we don't run the command "dmesg". This is unreliable as the file does not always contain the latest dmesg information. Since OVS kernel module emits information to dmesg, we need this information to debug bugs. So

[ovs-dev] [PATCH 1/2] ovs-bugtool: Collect OVS logs with "--ovs" option.

2017-07-25 Thread Gurucharan Shetty
ovs-bugtool collects a lot of data. This can be time consuming and can end up collecting a lot of redundant data. A option "--ovs" was added a while ago to only collect OVS relevent data. We missed adding the OVS logs to this filter. Signed-off-by: Gurucharan Shetty ---

Re: [ovs-dev] ovs delete flow slowly when there are many the flows

2017-07-25 Thread Joe Stringer
On 24 July 2017 at 18:42, 刘文学 wrote: > Hi, Joe Stringer: > the flows are deleted because of they are expired, the one core of cpu > is 100% because of there are many flows need to be deleted. Hmm. I would first suggest upgrading to the latest OVS release, some of the

Re: [ovs-dev] [PATCH v4] Update relevant artifacts to add support for DPDK 17.05.1.

2017-07-25 Thread Kevin Traynor
On 07/25/2017 01:34 PM, Michal Weglicki wrote: > Upgrading to DPDK 17.05.1 stable release adds new > significant features relevant to OVS, including, > but not limited to: > - tun/tap PMD, > - VFIO hotplug support, > - Generic flow API. > > Following changes are applied: > - netdev-dpdk: Changes

[ovs-dev] [PATCH V2] datapath: fix potential out of bound access in parse_ct

2017-07-25 Thread Greg Rose
Upstream commit: commit 69ec932e364b1ba9c3a2085fe96b76c8a3f71e7c Author: Liping Zhang Date: Sun Jul 23 17:52:23 2017 +0800 openvswitch: fix potential out of bound access in parse_ct Before the 'type' is validated, we shouldn't use it to fetch the

[ovs-dev] [PATCH] datapath: fix potential out of bound access in parse_ct

2017-07-25 Thread Greg Rose
Upstream commit: commit 69ec932e364b1ba9c3a2085fe96b76c8a3f71e7c Author: Liping Zhang Date: Sun Jul 23 17:52:23 2017 +0800 openvswitch: fix potential out of bound access in parse_ct Before the 'type' is validated, we shouldn't use it to fetch the

Re: [ovs-dev] [PATCH v4] dpctl: Add new 'ct-bkts' command.

2017-07-25 Thread Darrell Ball
Hi Antonio I had done a quick check of the two point changes, but, I did not retest, since I tested twice before. Thanks for the enhancement. This will go into 2.8. Thanks Darrell -Original Message- From: "Fischetti, Antonio" Date: Tuesday, July 25, 2017

Re: [ovs-dev] [PATCH v4] dpctl: Add new 'ct-bkts' command.

2017-07-25 Thread Fischetti, Antonio
Hi Darrell, I posted a v5 at http://patchwork.ozlabs.org/patch/792723/ where I added all your suggestions. Thanks, -Antonio > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Fischetti, Antonio > Sent: Monday, July 24,

Re: [ovs-dev] [PATCH] ovn-architecture: Remove outdated comment.

2017-07-25 Thread Russell Bryant
Thanks, applied to master. On Tue, Jul 25, 2017 at 8:45 AM, Miguel Angel Ajo Pelayo wrote: > Acked-by: Miguel Angel Ajo > > On Mon, Jul 24, 2017 at 10:53 PM, Russell Bryant wrote: >> >> This outdated comment said that support for

[ovs-dev] OVS-DPDK public meeting

2017-07-25 Thread Kevin Traynor
Hi All, The OVS-DPDK public meetings have moved to Wednesday's at the same time. Everyone is welcome, it's a chance to share status/plans etc. It's scheduled for every 2 weeks starting 26th July. Meeting time is currently @ 4pm UTC. You can connect through Bluejeans or through dial in:

[ovs-dev] [PATCH v2 0/3] Fix '--len' option for netdev-dummy/receive.

2017-07-25 Thread Ilya Maximets
See bug details is in patch #2. First patch introduces 'flow_compose_size()' which is used to fix bug in the second patch. To trigger the issue unit test from patch #3 can be used. Version 2: * New function 'flow_compose_size' introduced instead of modification of

Re: [ovs-dev] [PATCH 1/3] flow: Add packet_size option to flow_compose.

2017-07-25 Thread Ilya Maximets
On 24.07.2017 22:40, Andy Zhou wrote: > On Mon, Jul 24, 2017 at 6:33 AM, Ilya Maximets wrote: >> On 22.07.2017 01:38, Andy Zhou wrote: >>> On Wed, Jul 19, 2017 at 7:51 AM, Ilya Maximets >>> wrote: This allows to compose packets with different

[ovs-dev] [PATCH v4] Update relevant artifacts to add support for DPDK 17.05.1.

2017-07-25 Thread Michal Weglicki
Upgrading to DPDK 17.05.1 stable release adds new significant features relevant to OVS, including, but not limited to: - tun/tap PMD, - VFIO hotplug support, - Generic flow API. Following changes are applied: - netdev-dpdk: Changes required by DPDK API modifications. - doc: Because of DPDK API

Re: [ovs-dev] [PATCH] ovn-architecture: Remove outdated comment.

2017-07-25 Thread Miguel Angel Ajo Pelayo
Acked-by: Miguel Angel Ajo On Mon, Jul 24, 2017 at 10:53 PM, Russell Bryant wrote: > This outdated comment said that support for hardware gateways that > support the vtep schema would come later. This was actually > implemented a long time ago. > >

Re: [ovs-dev] [PATCH v3 2/3] ovn-controller: Add a new action - 'put_nd_ra_opts'

2017-07-25 Thread Miguel Angel Ajo Pelayo
Looks good to my unexperienced eye. Acked-by: Miguel Angel Ajo On Fri, Jul 14, 2017 at 2:26 PM, wrote: > From: Numan Siddique > > This patch adds a new OVN action 'put_nd_ra_opts' to support native > IPv6 Router Advertisement in

Re: [ovs-dev] [PATCH v3 3/3] ovn-northd: Add logical flows to support native IPv6 RA

2017-07-25 Thread Miguel Angel Ajo Pelayo
Looks good, just a tiny comment, but not actually very important. On Fri, Jul 14, 2017 at 2:26 PM, wrote: > From: Zongkai LI > > This patch adds logical flows which sends IPv6 Router Advertisement > packet in response to the IPv6 Router Solicitation

Re: [ovs-dev] [PATCH v3] Update relevant artifacts to add support for DPDK 17.05.1.

2017-07-25 Thread Weglicki, MichalX
Hi All, VHOST Client reconnection also works without any problems. Suggested documentation changes will be part of v4 patch which will be available shortly. Br, Michal. > -Original Message- > From: Stokes, Ian > Sent: Monday, July 24, 2017 7:15 PM > To: Darrell Ball

Re: [ovs-dev] [PATCH v3 1/3] ovn util: Refactor dhcp_opts_map to make it generic

2017-07-25 Thread Miguel Angel Ajo Pelayo
Looks good to my unexperienced eyes. Acked-by: Miguel Angel Ajo On Fri, Jul 14, 2017 at 2:25 PM, wrote: > From: Numan Siddique > > Renamed 'struct dhcp_opts_map' to 'struct gen_opts_map' and > renamed ovn-dhcp.h to ovn-l7.h. An

[ovs-dev] [PATCH V2] tc: Add SCTP support

2017-07-25 Thread Roi Dayan
From: Vlad Buslov Implement SCTP source and destination ports support for flower. Signed-off-by: Vlad Buslov Reviewed-by: Paul Blakey Acked-by: Roi Dayan --- V1->V2 - Fix typo in commit message.

[ovs-dev] (no subject)

2017-07-25 Thread Barry Stone
Brauchen Sie einen Kredit? ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] tc: Add SCTP support

2017-07-25 Thread Roi Dayan
On 25/07/2017 12:25, Or Gerlitz wrote: On 7/25/2017 8:29 AM, Roi Dayan wrote: Imlement SCTP source and destination ports support for flower s/Imlement/Implement also would be good to add a period @ the end of the sentence. bummer i actually saw that in our internal review but somehow sent

[ovs-dev] [PATCH v2 3/3] bond: Remove bond_hash_src.

2017-07-25 Thread Ilya Maximets
Since introduction of 'hash_mac()' function in commit 7e36ac42e33a ("lib/packet.h: add hash_mac()"), there is no need to have additional wrapper for mac address hashing. Lets use 'hash_mac()' directly and remove 'bond_hash_src()' to simplify the code. Suggested-by: Andy Zhou

[ovs-dev] [PATCH v2 2/3] bond: Unify hash functions in hash action and entry lookup.

2017-07-25 Thread Ilya Maximets
'lookup_bond_entry' currently uses 'flow_hash_symmetric_l4' while OVS_ACTION_ATTR_HASH uses 'flow_hash_5tuple'. This may lead to inconsistency in slave choosing for the new flows. In general, there is no point to unify hash functions, because it's not required for correct work, but it's logically

[ovs-dev] [PATCH v2 1/3] vswitch.xml: Fix L2 balancing mentioning for balance-tcp bond.

2017-07-25 Thread Ilya Maximets
L2 fields are not used in userspace hash action since commit 4f150744921f ("dpif-netdev: Use miniflow as a flow key."). In kernel datapath RSS (which is not include L2 by default for most of the NICs) was used from the beginning. This means that if recirculation is in use, L2 fields are not used

[ovs-dev] [PATCH v2 0/3] bond: Clean up hash functions.

2017-07-25 Thread Ilya Maximets
Version 2: * Became a patch-set. v1: https://mail.openvswitch.org/pipermail/ovs-dev/2017-July/336078.html * Removed bond_hash_tcp. * 2 new patches added: * Documentation fix. * Remove bond_hash_src. Ilya Maximets (3):

[ovs-dev] [PATCH v1] netdev-dpdk: Execute QoS Checking before copying to mbuf

2017-07-25 Thread Zhenyu Gao
In dpdk_do_tx_copy function, all packets were copied to mbuf first, but QoS checking may drop some of them. Move the QoS checking in front of copying data to mbuf, it helps to reduce useless copy. Signed-off-by: Zhenyu Gao --- lib/netdev-dpdk.c | 55

Re: [ovs-dev] Fwd: [PATCH] bond: Unify hash functions in hash action and entry lookup.

2017-07-25 Thread Ilya Maximets
On 24.07.2017 22:53, Andy Zhou wrote: > On Mon, Jul 24, 2017 at 9:23 AM, Ilya Maximets wrote: >> On 23.07.2017 00:02, Darrell Ball wrote: >>> >>> >>> -Original Message- >>> From: on behalf of Andy Zhou >>> >>>

Re: [ovs-dev] [PATCH] tc: Add SCTP support

2017-07-25 Thread Or Gerlitz
On 7/25/2017 8:29 AM, Roi Dayan wrote: Imlement SCTP source and destination ports support for flower s/Imlement/Implement also would be good to add a period @ the end of the sentence. ___ dev mailing list d...@openvswitch.org

[ovs-dev] FW:

2017-07-25 Thread Reno, Nitha
You Have been chosen for world heritage award This message, including any attachments, is intended only for the use of the intended recipient(s), and it may contain privileged and confidential information. If you are not the intended recipient, you are hereby notified that any review,