Re: [ovs-dev] [PATCH v5] ovn-controller: Refactor function of consider_port_binding

2017-08-03 Thread wang . qianyu
The function of consider_port_binding is redundant. This patch divide the function to some sub-function by the port type. Signed-off-by: wang qianyu --- ovn/controller/physical.c | 834 ++ 1 file changed, 481 insertions(+),

Re: [ovs-dev] Multiple ARP cache entries for one same dest IP?

2017-08-03 Thread Darrell Ball
-Original Message- From: on behalf of Joo Kim Date: Thursday, August 3, 2017 at 12:18 PM To: Darrell Ball Cc: "ovs-dev@openvswitch.org" Subject: Re: [ovs-dev] Multiple ARP cache entries

[ovs-dev] [PATCH v4] ovn-controller: Refactor function of consider_port_binding

2017-08-03 Thread wang . qianyu
The function of consider_port_binding is redundant. This patch divide the function to some sub-function by the port type. Signed-off-by: wang qianyu --- ovn/controller/physical.c | 816 +++--- 1 file changed, 482 insertions(+),

[ovs-dev] [patch_v9 3/6] Userspace Datapath: Add TFTP support.

2017-08-03 Thread Darrell Ball
Both ipv4 and ipv6 are supported. Also, NAT support is included. Signed-off-by: Darrell Ball --- include/sparse/netinet/in.h | 3 ++- lib/conntrack.c | 39 ++- 2 files changed, 40 insertions(+), 2 deletions(-) diff --git

[ovs-dev] [PATCH v2] ovn-controller: Refactor function of consider_port_binding

2017-08-03 Thread wang . qianyu
The function of consider_port_binding is redundant. This patch divide the function to some sub-function by the port type. Signed-off-by: wang qianyu --- ovn/controller/physical.c | 816 +++--- 1 file changed, 482 insertions(+),

Re: [ovs-dev] [PATCH v2 2/3] ovs-router: Set suitable type to netdev_open().

2017-08-03 Thread Tonghao Zhang
We can avoid the deadlock via removing the route_table_reset() from the route_table_init() the call trace is below dp_initialize (ovsthread_once) route_table_init route_table_reset route_table_handle_msg ovs_router_insert__ ovs_router_insert__

[ovs-dev] [PATCH] ovn-controller: Refactor function of consider_port_binding

2017-08-03 Thread wang . qianyu
The function of consider_port_binding is redundant. This patch split the function to some sub-function by the port type. Signed-off-by: wang qianyu --- ovn/controller/physical.c | 816 +++--- 1 file changed, 482 insertions(+),

[ovs-dev] 答复: Re: [PATCH] ovn-controller: Refactor function of consider_port_binding

2017-08-03 Thread wang . qianyu
The reason of this patch cannot be applied may be the character of "0xfeff" at begin of the file. I will delete the character and post again. Thanks Ben Pfaff 2017/08/04 04:23 收件人:wang.qia...@zte.com.cn, 抄送: d...@openvswitch.org,

[ovs-dev] 答复: Re: [PATCH] ovn: Support for taas(tap-as-a-service) function

2017-08-03 Thread wang . qianyu
Miguel Ángel and Russell Thanks for your reviews. Current taas function just for port monitor, in this situation, we can simplify the design by just add new port type. But we have the plane to add flow_classifier to tap_flow to monitor special flows of given port. The flow_classifier

[ovs-dev] [patch_v8 6/6] NEWS: Announce userspace datapath ALG support.

2017-08-03 Thread Darrell Ball
Signed-off-by: Darrell Ball --- NEWS | 1 + 1 file changed, 1 insertion(+) diff --git a/NEWS b/NEWS index a89e718..48b5b25 100644 --- a/NEWS +++ b/NEWS @@ -32,6 +32,7 @@ Post-v2.7.0 abbreviated to 4 hex digits. - Userspace Datapath: * Added NAT support for

[ovs-dev] [patch_v8 5/6] System tests: Add 4 new ftp and tftp tests.

2017-08-03 Thread Darrell Ball
In order to have full coverage of ALGs for the userspace datapath, it is necessary to add 4 new tests. Three of these will cover passive ftp, including basic V6 passive ftp, V4 passive ftp with NAT and sequence skew and V6 passive ftp with NAT. The last test will cover tftp with NAT. Before these

[ovs-dev] [patch_v8 2/6] Userspace Datapath: Add ALG infra and FTP.

2017-08-03 Thread Darrell Ball
ALG infra and FTP (both V4 and V6) support is added to the userspace datapath. Also, NAT support is included. Signed-off-by: Darrell Ball --- lib/conntrack-private.h | 35 +- lib/conntrack.c | 1055 +++ lib/conntrack.h

[ovs-dev] [patch_v8 4/6] System tests: Enable ALGs for userspace.

2017-08-03 Thread Darrell Ball
Signed-off-by: Darrell Ball --- tests/system-userspace-macros.at | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tests/system-userspace-macros.at b/tests/system-userspace-macros.at index 3fc4ef9..f3337f0 100644 --- a/tests/system-userspace-macros.at

[ovs-dev] [patch_v8 3/6] Userspace Datapath: Add TFTP support.

2017-08-03 Thread Darrell Ball
Both ipv4 and ipv6 are supported. Also, NAT support is included. Signed-off-by: Darrell Ball --- include/sparse/netinet/in.h | 3 ++- lib/conntrack.c | 39 ++- 2 files changed, 40 insertions(+), 2 deletions(-) diff --git

[ovs-dev] [patch_v8 1/6] string: Implement strcasestr substitute.

2017-08-03 Thread Darrell Ball
strcasestr is not defined for Windows, so implement a version that could be used on Windows. This is needed for an upcoming patch. Signed-off-by: Darrell Ball --- lib/string.c| 40 ++-- lib/string.h.in | 3 ++- 2 files changed, 40

[ovs-dev] [patch_v8 0/6] Userspace Datapath: Add ALG support.

2017-08-03 Thread Darrell Ball
ALG infra is added with support for FTP and TFTP. Both V4 and V6 are supported. Also, NAT is supported. Three passive ftp system tests are added to complete testing coverage of ftp for the userspace datapath, as the existing coverage of passive ftp was limited to one part of one test for V4

Re: [ovs-dev] [PATCH v8 0/7] ovsdb-idl: ovsdb client index support

2017-08-03 Thread Ben Pfaff
On Thu, Aug 03, 2017 at 02:20:00PM -0400, Lance Richardson wrote: > This set of patches is based on a series authored by Esteban Rodriguez > Betancourt, Jorge Arturo Sauma Vargas, Javier Albornoz, and Arnoldo Lutz > Guevara that has been inactive for a number of months. Thanks a lot. I applied

Re: [ovs-dev] [patch_v7 1/6] string: Implement strcasestr if it is missing.

2017-08-03 Thread Darrell Ball
Oops I forgot to cleanup and did so with an incremental diff --git a/lib/string.c b/lib/string.c index 445acd7..6e85462 100644 --- a/lib/string.c +++ b/lib/string.c @@ -16,7 +16,6 @@ #include #include -#include #include #include "util.h" @@ -44,9 +43,7 @@ char *strcasestr_s(const char

Re: [ovs-dev] [PATCH] datapath-windows: Fix conntrack lookups for reversed keys

2017-08-03 Thread Ben Pfaff
Thanks Anand, Shashank, Alin. I applied this to master. On Thu, Aug 03, 2017 at 05:11:36PM +, Alin Serdean wrote: > Acked-by: Alin Gabriel Serdean > > > > -Original Message- > > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > >

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-upcall: Fix key attr iteration.

2017-08-03 Thread Ben Pfaff
On Mon, Jul 31, 2017 at 04:54:22PM -0700, Joe Stringer wrote: > This call is operating on messages generated by the datapath. If a > datapath implementation sends improperly formatted netlink attributes, > then it's possible for a revalidator thread to end up trapped in an > infinite loop

Re: [ovs-dev] [PATCH 1/2] ofproto-dpif-upcall: Fix action attr iteration.

2017-08-03 Thread Ben Pfaff
On Mon, Jul 31, 2017 at 04:54:21PM -0700, Joe Stringer wrote: > This calls is operating on messages generated by the datapath. If a > datapath implementation sends improperly formatted netlink attributes, > then it's possible for a revalidator thread to end up trapped in an > infinite loop

[ovs-dev] Promo del mes de Agosto

2017-08-03 Thread Disney
Compartiendo la Magia del Servicio al Estilo Disney Ponemos a su alcance por primera vez y por tiempo limitado, un exclusivo programa con 12 Temas INEDITOS específicamente creados para mejorar su negocio en forma completa, conveniente y accesible . Con este programa usted y sus colaboradores

Re: [ovs-dev] [PATCH v5 2/3] ovn-controller: Add a new action - 'put_nd_ra_opts'

2017-08-03 Thread Ben Pfaff
On Mon, Jul 31, 2017 at 06:11:35PM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > This patch adds a new OVN action 'put_nd_ra_opts' to support native > IPv6 Router Advertisement in OVN. This action can be used to respond > to the IPv6 Router Solicitation

Re: [ovs-dev] [PATCH] ovs-ofctl: Avoid unnecessary flow replacement in "replace-flows" command.

2017-08-03 Thread Ben Pfaff
On Thu, Aug 03, 2017 at 01:35:50PM -0700, Andy Zhou wrote: > On Wed, Aug 2, 2017 at 2:13 PM, Ben Pfaff wrote: > > This bug fix still needs a review. Also, Kevin, if you can verify that > > it fixes the behavior you see, that would also be helpful. > > > > On Thu, Jul 06, 2017 at

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Add OFPACT_ENCAP, OFPACT_DECAP to reversible_actions().

2017-08-03 Thread Ben Pfaff
On Thu, Aug 03, 2017 at 01:46:06PM -0700, Andy Zhou wrote: > On Thu, Aug 3, 2017 at 1:20 PM, Ben Pfaff wrote: > > Fixes a broken build when building with --enable-Werror. > > > > I guess that encap and decap are often reversible, but it's safe to > > consider them irreversible. > >

Re: [ovs-dev] [PATCH] controller: Remote connection option to OpenFlow switch.

2017-08-03 Thread Ben Pfaff
On Mon, Jul 31, 2017 at 04:31:23PM +0530, Jai Singh Rana wrote: > Currently ovn-controller uses default unix domain socket in Open Vswitch's > "run" directory to connect to OpenFlow switch. If > ovn-controller/ovsdb-server and vswitchd is running on different systems, > remote connection method

[ovs-dev] [patch_v7 5/6] System tests: Add 4 new ftp and tftp tests.

2017-08-03 Thread Darrell Ball
Signed-off-by: Darrell Ball --- tests/system-traffic.at | 242 1 file changed, 242 insertions(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index 8145515..707f88f 100644 --- a/tests/system-traffic.at +++

[ovs-dev] [patch_v7 2/6] Userspace Datapath: Add ALG infra and FTP.

2017-08-03 Thread Darrell Ball
ALG infra and FTP (both V4 and V6) support is added to the userspace datapath. Also, NAT support is included. Signed-off-by: Darrell Ball --- lib/conntrack-private.h | 35 +- lib/conntrack.c | 1055 +++ lib/conntrack.h

[ovs-dev] [patch_v7 4/6] System tests: Enable ALGs for userspace.

2017-08-03 Thread Darrell Ball
Signed-off-by: Darrell Ball --- tests/system-userspace-macros.at | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tests/system-userspace-macros.at b/tests/system-userspace-macros.at index 3fc4ef9..f3337f0 100644 --- a/tests/system-userspace-macros.at

[ovs-dev] [patch_v7 3/6] Userspace Datapath: Add TFTP support.

2017-08-03 Thread Darrell Ball
Both ipv4 and ipv6 are supported. Also, NAT support is included. Signed-off-by: Darrell Ball --- include/sparse/netinet/in.h | 1 + lib/conntrack.c | 39 ++- 2 files changed, 39 insertions(+), 1 deletion(-) diff --git

[ovs-dev] [patch_v7 0/6] Userspace Datapath: Add ALG support.

2017-08-03 Thread Darrell Ball
ALG infra is added with support for FTP and TFTP. Both V4 and V6 are supported. Also, NAT is supported. Three passive ftp system tests are added to complete testing coverage of ftp for the userspace datapath, as the existing coverage of passive ftp was limited to one part of one test for V4

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Add OFPACT_ENCAP, OFPACT_DECAP to reversible_actions().

2017-08-03 Thread Andy Zhou
On Thu, Aug 3, 2017 at 1:20 PM, Ben Pfaff wrote: > Fixes a broken build when building with --enable-Werror. > > I guess that encap and decap are often reversible, but it's safe to > consider them irreversible. > > CC: Andy Zhou > Fixes: eee693934aac ("xlate: Emit

Re: [ovs-dev] [PATCH] ovs-ofctl: Avoid unnecessary flow replacement in "replace-flows" command.

2017-08-03 Thread Andy Zhou
On Wed, Aug 2, 2017 at 2:13 PM, Ben Pfaff wrote: > This bug fix still needs a review. Also, Kevin, if you can verify that > it fixes the behavior you see, that would also be helpful. > > On Thu, Jul 06, 2017 at 04:40:30PM -0700, Ben Pfaff wrote: >> The ovs-ofctl "diff-flows" and

Re: [ovs-dev] [PATCH] ovn-controller: Refactor function of consider_port_binding

2017-08-03 Thread Ben Pfaff
On Fri, Jul 28, 2017 at 11:32:29AM +0800, wang.qia...@zte.com.cn wrote: > The function of consider_port_binding is redundant. This patch divide the > function to some sub-function by the port type. > > Change-Id: I86a408e97e6d6211f3695cf42fc5b858352ac7ff > Signed-off-by: wang qianyu

Re: [ovs-dev] [PATCH] ovs-ovctl: Fix "OpenFlow versions" in ovs-ofctl -V

2017-08-03 Thread Ben Pfaff
On Thu, Jul 27, 2017 at 05:43:49PM +0200, Timothy Redaelli wrote: > Fix the output of "ovs-ofctl -V" to show OpenFlow 1.4 as max supported > versions since OpenFlow 1.4 was enabled by default in commit > 8d3485791188 ("OpenFlow: Enable OpenFlow 1.4 by default.") > > CC: Ben Pfaff >

[ovs-dev] [PATCH] ofproto-dpif-xlate: Add OFPACT_ENCAP, OFPACT_DECAP to reversible_actions().

2017-08-03 Thread Ben Pfaff
Fixes a broken build when building with --enable-Werror. I guess that encap and decap are often reversible, but it's safe to consider them irreversible. CC: Andy Zhou Fixes: eee693934aac ("xlate: Emit datapath clone only when necessary.") Signed-off-by: Ben Pfaff

Re: [ovs-dev] [PATCH] bridge: Avoid read of uninitialized data configuring Auto-Attach.

2017-08-03 Thread Andy Zhou
On Wed, Aug 2, 2017 at 2:12 PM, Ben Pfaff wrote: > This still needs a (trivial) review. > > On Thu, Jul 06, 2017 at 02:33:42PM -0700, Ben Pfaff wrote: >> Reported-by: "qintao (F)" >> Reported-at: >>

Re: [ovs-dev] [PATCH] tnl-ports: Open tunnel type if device name has special prefix

2017-08-03 Thread Ben Pfaff
On Wed, Aug 02, 2017 at 02:17:29PM +0300, Roi Dayan wrote: > From: Paul Blakey > > There is a race between listening on route changes from route-table > netlink which then calls ovs_router_insert() where it adds the involved > netdev to the tnl-ports map

Re: [ovs-dev] [PATCH V2] tc: Correct convert ticks to msecs on parsing tc TM

2017-08-03 Thread Ben Pfaff
On Tue, Aug 01, 2017 at 01:56:58PM -0700, Joe Stringer wrote: > On 29 July 2017 at 22:01, Roi Dayan wrote: > > From: Paul Blakey > > > > Use sysconf(_SC_CLK_TCK) to read run time "number of clock ticks per > > second" and use that to convert ticks to msecs.

Re: [ovs-dev] [PATCH] odp-util: Support zero mask on ipv4 frag

2017-08-03 Thread Ben Pfaff
On Thu, Aug 03, 2017 at 04:27:07PM +0300, Roi Dayan wrote: > From: Paul Blakey > > Don't print frag parsing error if mask is zero, > instead just don't print it. > > Signed-off-by: Paul Blakey > Reviewed-by: Roi Dayan Thanks, applied

Re: [ovs-dev] [clone optmization v2 0/7] Clone optimization

2017-08-03 Thread Andy Zhou
On Thu, Aug 3, 2017 at 11:27 AM, Ben Pfaff wrote: > On Fri, Jul 21, 2017 at 03:46:26PM -0700, Andy Zhou wrote: >> I respined the patches based on review feedback at: >> >> http://mail.openvswitch.org/pipermail/ovs-dev/2017-June/333502.html >> >> Patch 1-5: Implements a generic

Re: [ovs-dev] [PATCH V2 0/3] Small refactoring related to tc

2017-08-03 Thread Ben Pfaff
On Thu, Aug 03, 2017 at 04:38:22PM +0300, Roi Dayan wrote: > Hi, > > The following patches are small refactoring related to tc. > > Thanks, > Roi I applied this series to master. Thank you! ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH] ovs-ctl: Remove a leftover restore_interfaces in restart

2017-08-03 Thread Ben Pfaff
On Wed, Jul 26, 2017 at 03:48:33PM +0200, Timothy Redaelli wrote: > Since commit c416eaf8c247 ("ovs-ctl: Remove code for upgrading from Open > vSwitch 1.9 and earlier.") the kernel configuration of the specified > network interfaces is not saved anymore for restart command so there is no > need to

Re: [ovs-dev] [PATCH 2/2] ovs-bugtool: Run the 'dmesg' command without condition.

2017-08-03 Thread Ben Pfaff
On Tue, Jul 25, 2017 at 12:23:51AM -0700, Gurucharan Shetty wrote: > Currently we look for files with the name of "dmesg" > in "/var/log". If it exists, we don't run the command > "dmesg". This is unreliable as the file does not always > contain the latest dmesg information. > > Since OVS kernel

Re: [ovs-dev] Multiple ARP cache entries for one same dest IP?

2017-08-03 Thread Joo Kim
Darrell, I guess you said link-local addresses is one scenario where multiple entries for a given IP may exist. But, could you elaborate a bit more on 'routing space segmentation is another'? Thanks On Wed, Aug 2, 2017 at 5:32 PM, Darrell Ball wrote: > > > On Wed, Aug 2,

Re: [ovs-dev] [PATCH 1/2] ovs-bugtool: Collect OVS logs with "--ovs" option.

2017-08-03 Thread Ben Pfaff
On Tue, Jul 25, 2017 at 12:23:50AM -0700, Gurucharan Shetty wrote: > ovs-bugtool collects a lot of data. This can be time > consuming and can end up collecting a lot of redundant data. > A option "--ovs" was added a while ago to only collect > OVS relevent data. We missed adding the OVS logs to

Re: [ovs-dev] [PATCH] util: Add PADDED_MEMBERS_CACHELINE_MARKER macro to mark cachelines.

2017-08-03 Thread Ben Pfaff
On Tue, Jul 25, 2017 at 05:14:43AM +0100, Bhanuprakash Bodireddy wrote: > PADDED_MEMBERS_CACHELINE_MARKER macro introduces a way to mark > cachelines. > > This macro expands to an anonymous union containing cacheline marker, > members in nested anonymous structure, followed by array of bytes that

Re: [ovs-dev] [clone optmization v2 0/7] Clone optimization

2017-08-03 Thread Ben Pfaff
On Fri, Jul 21, 2017 at 03:46:26PM -0700, Andy Zhou wrote: > I respined the patches based on review feedback at: > > http://mail.openvswitch.org/pipermail/ovs-dev/2017-June/333502.html > > Patch 1-5: Implements a generic command that can defeature and restore >the datapath support

[ovs-dev] [PATCH v8 7/7] ovn-controller: use idl indexes for logical datapath

2017-08-03 Thread Lance Richardson
Use IDL index to iterate over all logical ports in a given logical datapath, avoiding the overhead of creating/destroying an indexing data structure in each iteration of the ovn-controller main loop. Signed-off-by: Lance Richardson --- v8: Rebased, changes required. v7:

[ovs-dev] [PATCH v8 6/7] ovn-controller: use idl indexes for logical port table

2017-08-03 Thread Lance Richardson
Use IDL index for logical port table lookups, avoiding the overhead of creating/destroying an index hmap for each iteration of the ovn-controller main loop. Signed-off-by: Lance Richardson --- v8: Rebased, changes required. v7: New patch. ovn/controller/binding.c

[ovs-dev] [PATCH v8 5/7] ovn-controller: use idl index for multicast group table

2017-08-03 Thread Lance Richardson
Use IDL index for multicast group table lookups, avoiding the overhead of creating/destroying an index hmap for each iteration of the ovn-controller main loop. Signed-off-by: Lance Richardson --- v8: Rebased, changes required. v7: New patch. ovn/controller/lflow.c

[ovs-dev] [PATCH v8 4/7] ovsdb-idl: Autogenerated functions for compound indexes

2017-08-03 Thread Lance Richardson
Generates and fills in the default comparators for columns with type int, real, string. Also creates the macros that allow iteration over the contents of the index, and perform queries. Signed-off-by: Arnoldo Lutz Guevara Signed-off-by: Esteban Rodriguez Betancourt

[ovs-dev] [PATCH v8 3/7] ovsdb-idl: idl compound indexes implementation

2017-08-03 Thread Lance Richardson
This patch adds support for the creation of multicolumn indexes in the C IDL to enable for efficient search and retrieval of database rows by key. Signed-off-by: Esteban Rodriguez Betancourt Co-authored-by: Lance Richardson Signed-off-by: Lance Richardson

[ovs-dev] [PATCH v8 2/7] lib: skiplist implementation

2017-08-03 Thread Lance Richardson
Skiplist implementation intended for use in the IDL compound indexes feature. Signed-off-by: Esteban Rodriguez Betancourt Co-authored-by: Lance Richardson Signed-off-by: Lance Richardson --- v8: - Rebased, no changes. v7: - More

[ovs-dev] [PATCH v8 1/7] ovsdb-idl: compound indexes design document

2017-08-03 Thread Lance Richardson
In the work made in our projects, it was found the need to have a faster access to the rows contained in tables in the replica, as well to have the possibility to loop over a subset of rows that meet some specified criteria. Those needs lead us to design and implement a functionality that

[ovs-dev] [PATCH v8 0/7] ovsdb-idl: ovsdb client index support

2017-08-03 Thread Lance Richardson
This set of patches is based on a series authored by Esteban Rodriguez Betancourt, Jorge Arturo Sauma Vargas, Javier Albornoz, and Arnoldo Lutz Guevara that has been inactive for a number of months. v8: Rebased. v7: - Added patches to make use of client idl indexing in ovn-controller (these

Re: [ovs-dev] [PATCH] AUTHORS: Add Wang Zhike.

2017-08-03 Thread Ben Pfaff
On Fri, Jul 21, 2017 at 11:29:13AM -0700, Joe Stringer wrote: > Signed-off-by: Joe Stringer Acked-by: Ben Pfaff ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] tunnel: ToS and TTL inheritance for MPLS tunneled traffic

2017-08-03 Thread Ben Pfaff
On Fri, Jul 21, 2017 at 01:08:34PM +, Miklós Pelyva wrote: > When a new outermost MPLS label is added to 'flow' the 'flow''s > Ethernet type is changed to 'mpls_eth_type'. After the new label is > set, the 'flow''s MPLS stack is updated, and the L3/4 fields are > cleared to mark them invalid.

Re: [ovs-dev] [PATCH v2 2/3] ovs-router: Set suitable type to netdev_open().

2017-08-03 Thread Ben Pfaff
On Tue, Jul 18, 2017 at 08:44:15PM -0700, Tonghao Zhang wrote: > ovs-router module uses the netdev_open() to get routes. > But this module always calls the netdev_open() with type > which is NULL. This module may open the eth0, vethx, > vxlan_sys_4789, br0 if these network devices exist. And >

Re: [ovs-dev] [PATCH v2 1/3] ovs-router: Remove redundant headers.

2017-08-03 Thread Ben Pfaff
On Tue, Jul 18, 2017 at 08:44:14PM -0700, Tonghao Zhang wrote: > Signed-off-by: Tonghao Zhang Applied, thanks! ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [patch_v6 0/5] Userspace Datapath: Add ALG support.

2017-08-03 Thread Darrell Ball
-Original Message- From: on behalf of Ben Pfaff Date: Thursday, August 3, 2017 at 9:58 AM To: Darrell Ball Cc: "d...@openvswitch.org" Subject: Re: [ovs-dev] [patch_v6 0/5] Userspace Datapath: Add

Re: [ovs-dev] [PATCH] datapath-windows: Fix conntrack lookups for reversed keys

2017-08-03 Thread Alin Serdean
Acked-by: Alin Gabriel Serdean > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Shashank Ram > Sent: Wednesday, August 2, 2017 1:08 AM > To: Anand Kumar ;

Re: [ovs-dev] [patch_v6 0/5] Userspace Datapath: Add ALG support.

2017-08-03 Thread Ben Pfaff
On Sat, Jul 15, 2017 at 12:49:51PM -0700, Darrell Ball wrote: > ALG infra is added with support for FTP and TFTP. > Both V4 and V6 are supported. Also, NAT is supported. Hi Darrell, would you mind doing a quick rebase and repost to incorporate the changes you mention for a clean Windows build?

Re: [ovs-dev] [PATCH v7 0/7] ovsdb-idl: ovsdb client index support

2017-08-03 Thread Ben Pfaff
Hi Lance, do you have time to do a quick rebase of this series? There are some patch rejects in patch 5. Maybe we have time to sneak it into 2.8, if we can iterate quickly. On Fri, Jul 14, 2017 at 03:15:42PM -0400, Lance Richardson wrote: > This set of patches is based on a series authored by

Re: [ovs-dev] [PATCH v2 1/2] dpif-netdev: Decrease range of values for EMC probability.

2017-08-03 Thread Fischetti, Antonio
LGTM, just wondering if a further comment would help, eg something like +/* random_uint32() returns a value in the [0; UINT32_MAX] range. + For our checking to be correct we would need instead a random value + in the range [0; UINT32_MAX - 1]. To avoid further computation + we use a

Re: [ovs-dev] [PATCH] ovn: Support for taas(tap-as-a-service) function

2017-08-03 Thread Miguel Angel Ajo Pelayo
I had the same thought about the tables. Regards, Miguel Ángel On Thu, Aug 3, 2017 at 5:11 PM, Russell Bryant wrote: > On Thu, Aug 3, 2017 at 4:44 AM, wrote: > > Taas was designed to provide tenants and service providers a means of > > monitoring the

Re: [ovs-dev] [PATCH] rhel: Use systemd Restart option for ovn-controllers.

2017-08-03 Thread Russell Bryant
On Wed, Aug 2, 2017 at 5:10 PM, Ben Pfaff wrote: > On Wed, Aug 02, 2017 at 01:43:04PM -0500, Mark Michelson wrote: >> This change stops the use of OVS's monitor for the ovn-controller and >> ovn-controller-vtep systemd services. Instead, the services use the >> systemd Restart

Re: [ovs-dev] [PATCH] ovn: Support for taas(tap-as-a-service) function

2017-08-03 Thread Russell Bryant
On Thu, Aug 3, 2017 at 4:44 AM, wrote: > Taas was designed to provide tenants and service providers a means of > monitoring the traffic flowing in their Neutron provisioned virtual > networks. It is useful for network trouble-shooting, security and > analytics. The taas

Re: [ovs-dev] [PATCH v2 2/2] dpif-netdev: Fix emc replacement policy.

2017-08-03 Thread Fischetti, Antonio
LGTM. I think this patch could work fine in conjunction with the one I posted https://mail.openvswitch.org/pipermail/ovs-dev/2017-July/335940.html where I'm targeting a congestion usecase with recirculated packets. The goal is still to limit thrashing and the criteria is to avoid EMC lookup and

[ovs-dev] [PATCH V2 2/3] tc: Split IPs and transport layer ports unions in flower struct

2017-08-03 Thread Roi Dayan
From: Paul Blakey Split dst/src_port and ipv4/ipv6 union so we can distingush them easily for later features. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/netdev-tc-offloads.c | 37 -

[ovs-dev] [PATCH V2 0/3] Small refactoring related to tc

2017-08-03 Thread Roi Dayan
Hi, The following patches are small refactoring related to tc. Thanks, Roi V1->V2 - Updated commit msg in one of the patches Paul Blakey (3): tc: Refactor nl_msg_put_flower_options tc: Split IPs and transport layer ports unions in flower struct netdev-tc-offloads: Parse ip related

[ovs-dev] [PATCH V2 1/3] tc: Refactor nl_msg_put_flower_options

2017-08-03 Thread Roi Dayan
From: Paul Blakey Refactor nl_msg_put_flower_options to be more readable. This commit doesn't change functionality. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Acked-by: Simon Horman --- lib/tc.c |

[ovs-dev] [PATCH V2 3/3] netdev-tc-offloads: Parse ip related fields only if eth type is ip

2017-08-03 Thread Roi Dayan
From: Paul Blakey There is no need to parse ip related fields if eth type is not ip. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/netdev-tc-offloads.c | 20 ++-- 1 file changed, 10 insertions(+), 10

[ovs-dev] [PATCH v2] tunnel: Fix deletion of datapath tunnel ports in case of reconfiguration

2017-08-03 Thread Balazs Nemeth
There is an issue in OVS with tunnel deletion during the reconfiguration of OF tunnels. If the dst_port value is changed, the old tunnel map entry will not be deleted, because the tp_port argument of tnl_port_map_delete() has the new dst_port setting, hence the tunnel cannot be found in the list

Re: [ovs-dev] [PATCH] tunnel: Fix deletion of datapath tunnel ports in case of reconfiguration

2017-08-03 Thread Balazs Nemeth
Thanks for the notice, I will upload v2 in a few minutes without whitespace errors. Yes, this patch is related to commit e7c9ff0. Both are fixing an issue with tunnel port handling, but I think the two issue is logically independent. One is with deletion, the other one is with changing

[ovs-dev] [PATCH] odp-util: Support zero mask on ipv4 frag

2017-08-03 Thread Roi Dayan
From: Paul Blakey Don't print frag parsing error if mask is zero, instead just don't print it. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/odp-util.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-)

[ovs-dev] [PATCH] ovn: Support for taas(tap-as-a-service) function

2017-08-03 Thread wang . qianyu
Taas was designed to provide tenants and service providers a means of monitoring the traffic flowing in their Neutron provisioned virtual networks. It is useful for network trouble-shooting, security and analytics. The taas presentations could be found from

Re: [ovs-dev] [PATCH v3 6/6] redhat: allow dpdk to also run as non-root user

2017-08-03 Thread Sergio Gonzalez Monroy
On 02/08/2017 16:07, Aaron Conole wrote: Sergio Gonzalez Monroy writes: Hi Aaron, Hi Sergio, On 01/08/2017 23:05, Aaron Conole wrote: After this commit, users may start a dpdk-enabled ovs setup as a non-root user. This is accomplished by exporting the