[ovs-dev] [PATCH V3 2/2] tests/system-offloads-traffic.at: add sanity check

Doing dump-flows also altering the netdev ports list. So doing it pre the actual test is adding a check to make sure we don't break the that list. Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey --- tests/system-offloads-traffic.at | 1 + 1 file

Re: [ovs-dev] [patch_v4 2/2] dpif-netdev: Refactor some pmd stats.

> The per packets stats are presently overlapping in that > miss stats include lost stats; make these stats non-overlapping > for clarity and make this clear in the dp_stat_type enum. This > also eliminates the need to increment two 'miss' stats for a > single packet. > > The subtable lookup

Re: [ovs-dev] [PATCH V2 1/2] dpif: Fix cleanup of netdev_ports map

On 17/08/2017 08:38, Roi Dayan wrote: Executing dpctl commands from userspace also calls to dpif_open()/dpif_close() but not really creating another dpif but using a clone. As for netdev_ports map is global we avoid adding duplicate entries but also need to make sure we are not removing needed

[ovs-dev] [PATCH V2 0/2] Fix rules not offloaded after executing dpctl command

Hi, The first patch is small update to the test to catch this error early. The second patch is the actual fix not to clean netdev_ports map early. V1->V2 - Change order of commits for fix to be first - Small refactor to function declaration Thanks, Roi Roi Dayan (2): dpif: Fix

[ovs-dev] [PATCH V2 2/2] tests/system-offloads-traffic.at: add sanity check

Doing dump-flows also altering the netdev ports list. So doing it pre the actual test is adding a check to make sure we don't break the that list. Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey --- tests/system-offloads-traffic.at | 1 + 1 file

[ovs-dev] [PATCH V2 1/2] dpif: Fix cleanup of netdev_ports map

Executing dpctl commands from userspace also calls to dpif_open()/dpif_close() but not really creating another dpif but using a clone. As for netdev_ports map is global we avoid adding duplicate entries but also need to make sure we are not removing needed entries. With this commit we make sure

Re: [ovs-dev] [PATCH 1/2] tests/system-offloads-traffic.at: add sanity check

On 17/08/2017 01:17, Joe Stringer wrote: On 16 August 2017 at 05:14, Roi Dayan wrote: Doing dump-flows also altering the netdev ports list. So doing it pre the actual test is adding a check to make sure we don't break the that list. Signed-off-by: Roi Dayan

Re: [ovs-dev] [ovs-security] RFC: Adding OvS to fuzzer test suite

Hi Justin, Nice to hear. I have CC ed Dev ml. Regards Bhargava On August 16, 2017 5:18:58 PM PDT, Justin Pettit wrote: >Hi, Bhargava. This seems like a great idea to me. Unless there's >something sensitive, I'd suggest we discuss it on the >d...@openvswitch.org mailing

Re: [ovs-dev] [PATCH v3] openvswitch: enable NSH support

On Wed, Aug 16, 2017 at 11:15:28PM +0800, Eric Garver wrote: > On Wed, Aug 16, 2017 at 01:35:30PM +0800, Yi Yang wrote: > > + > > +#define NSH_DST_PORT4790 /* UDP Port for NSH on VXLAN. */ > > +#define ETH_P_NSH 0x894F /* Ethertype for NSH. */ > > ETH_P_NSH probably belongs in

Re: [ovs-dev] [PATCH v3] openvswitch: enable NSH support

On Wed, Aug 16, 2017 at 10:03:22PM +0800, Jiri Benc wrote: > On Wed, 16 Aug 2017 17:31:30 +0800, Yang, Yi wrote: > > On Wed, Aug 16, 2017 at 11:19:21AM +0200, Jiri Benc wrote: > > > > --- a/include/uapi/linux/openvswitch.h > > > > +++ b/include/uapi/linux/openvswitch.h > > > [...] > > > > +#define

[ovs-dev] Administración, Organización y control

En línea y en Vivo / Para todo su Equipo con una sola Conexión Administración, Organización y control de un Departamento de Compras 01 de Septiembre - Online en Vivo - 10:00 a 13:00 y de 15:00 a 18:00 Hrs La falta de organización y control en el departamento de compras pueden llevar a

[ovs-dev] [PATCH] checkpatch: Enforce bracing around conditionals.

The coding style states that BSD-style brace placement should be used, and even single statements should be enclosed. Add checks to checkpatch for this. Signed-off-by: Joe Stringer --- utilities/checkpatch.py | 13 + 1 file changed, 13 insertions(+) diff --git

[ovs-dev] [PATCH] datapath: fix skb_panic due to the incorrect actions attrlen

Upstream commit: commit 494bea39f3201776cdfddc232705f54a0bd210c4 Author: Liping Zhang Date: Wed Aug 16 13:30:07 2017 +0800 For sw_flow_actions, the actions_len only represents the kernel part's size, and when we dump the actions to the userspace, we

Re: [ovs-dev] [PATCH] netdev-tc-offloads: Add prefix to identify source of log msg

On 16 August 2017 at 05:27, Roi Dayan wrote: > There is an identical log msg from multiple api calls. > Add a prefix to identify the source function of the log msg. > > Signed-off-by: Roi Dayan > Reviewed-by: Paul Blakey > --- Applied,

Re: [ovs-dev] [PATCH 1/2] tests/system-offloads-traffic.at: add sanity check

On 16 August 2017 at 05:14, Roi Dayan wrote: > Doing dump-flows also altering the netdev ports list. > So doing it pre the actual test is adding a check to > make sure we don't break the that list. > > Signed-off-by: Roi Dayan > Reviewed-by: Paul Blakey

Re: [ovs-dev] [PATCH V3 2/2] dpif: Fix cleanup of netdev_ports map

On 16 August 2017 at 05:12, Roi Dayan wrote: > Executing dpctl commands from userspace also calls to > dpif_open()/dpif_close() but not really creating another dpif > but using a clone. > As for netdev_ports map is global we avoid adding duplicate entries > but also need to

Re: [ovs-dev] [RFC PATCH 1/1] dpif-netdev : Include Rxq processing cycles

-Original Message- From: Kevin Traynor Organization: Red Hat Date: Wednesday, August 16, 2017 at 12:54 PM To: Darrell Ball , Jan Scheurich , Sugesh Chandran , "d...@openvswitch.org"

[ovs-dev] [PATCH 3/3] selinux: update policy to reflect non-root and dpdk support

The selinux policy that exists in the repository did not specify access to all of the resources needed for Open vSwitch to properly function with an enforcing selinux policy. This update allows Open vSwitch to operate with selinux set to Enforcing mode, even while running as a non-root user.

[ovs-dev] [PATCH 2/3] makefile: hook up dpdkstrip preprocessor

When building the openvswitch-custom.te file, it is important to have the ability to filter out dpdk blocks depending on whether the system has been configured with dpdk or not. This allows using all the standard .in file blocks, as well as the dpdkstrip blocks, when constructing the selinux

[ovs-dev] [PATCH 1/3] rhel: make the selinux policy intermediate

This will be used by an upcoming commit to have @begin_ and @end_ dpdk blocks to keep dpdk specific policy decisions only active when dpdk is used. Signed-off-by: Aaron Conole Tested-by: Jean Hsiao --- rhel/openvswitch-fedora.spec.in

[ovs-dev] [PATCH 0/3] updated selinux policy for Open vSwitch

This series brings about a policy update to openvswitch allowing it to run on a RHEL / Fedora system, even as a non-root user, with selinux set to Enforcing. The first two patches make some changes to the way the selinux policy is built to have a macro-like effect, allowing the dpdk policy to be

Re: [ovs-dev] [PATCH v4 0/6] OVS-DPDK rxq to pmd assignment improvements.

-Original Message- From: Kevin Traynor Organization: Red Hat Date: Wednesday, August 16, 2017 at 12:19 PM To: Darrell Ball , "d...@openvswitch.org" , "ian.sto...@intel.com" ,

Re: [ovs-dev] [RFC PATCH 1/1] dpif-netdev : Include Rxq processing cycles

On 08/16/2017 04:48 PM, Darrell Ball wrote: > Seems we are in sync on most points then. > > > > *From: *Jan Scheurich > *Date: *Wednesday, August 16, 2017 at 8:03 AM > *To: *Darrell Ball , Sugesh Chandran > ,

Re: [ovs-dev] [PATCH v4 0/6] OVS-DPDK rxq to pmd assignment improvements.

On 08/16/2017 07:28 AM, Darrell Ball wrote: > Hi Kevin > > I did some basic testing and parsed all the code. > I have some high level comments, below. > I’ll add the other comments tomorrow. > Thanks Darrell. > 1/ The redistribution is based on the last interval – I wonder if a number of >

[ovs-dev] [PATCH v3] datapath-windows: Update Orig Tuple to use ICMP Type and Code

- Also add some padding for the ct_endpoint's union, so that each member of ct_endpoint's union are of same size. Co-authored-by: Sairam Venugopal Signed-off-by: Anand Kumar --- datapath-windows/ovsext/Conntrack.c | 11 +--

Re: [ovs-dev] [PATCH/RFC] bond: add enable-recirc configuration for bond.

On Wed, Aug 16, 2017 at 7:59 AM, Simon Horman wrote: > Hi Andy, > > On Tue, Aug 15, 2017 at 01:31:36PM -0700, Andy Zhou wrote: >> On Tue, Aug 15, 2017 at 9:13 AM, Simon Horman >> wrote: >> > From: Pieter Jansen van Vuuren

Re: [ovs-dev] [RFC patch v1] dp-packet: Refactor DPDK packet initialization.

-Original Message- From: on behalf of "Chandran, Sugesh" Date: Wednesday, August 16, 2017 at 6:55 AM To: Darrell Ball , "d...@openvswitch.org" Subject: Re: [ovs-dev] [RFC patch v1]

Re: [ovs-dev] [PATCH v1] netdev-dpdk: Implement TCP/UDP TX cksum in ovs-dpdk side

Hi Ciara You had a general concern below; can we conclude on that before going further ? Thanks Darrell “ > On another note I have a general concern. I understand similar functionality > is present in the DPDK vhost sample app. I wonder if it would be feasible for > this to be implemented in

Re: [ovs-dev] [PATCH v2] datapath-windows: Update Orig Tuple to use ICMP Type and Code

Hi Shashank, Thanks for reviewing the patch. I will update the commit message and send out a v3 patch. For the other comment, please find my response inline. Thanks, Anand Kumar On 8/16/17, 10:03 AM, "Shashank Ram" wrote:

Re: [ovs-dev] [PATCH v3 1/4] dpif-netdev: Skip EMC lookup/insert for recirc packets

Something happened to your email – it is mostly blank lines; also inserted b/w lines belonging to same paragraph ? I have a few clarifications about the other lines. -Original Message- From: Jan Scheurich Date: Wednesday, August 16, 2017 at 9:23 AM To:

Re: [ovs-dev] [PATCH v3 1/4] dpif-netdev: Skip EMC lookup/insert for recirc packets

Hi, I agree that in the event of EMC overload it is beneficial to reduce the number of EMC insertions and lookups as they just generate overhead and degrade overall throughput. At the same time we want to keep as much of the EMC acceleration as possible for a fraction of traffic that can

[ovs-dev] Compliance of NSH implementation with latest NSH draft

I checked the IETF tracker for NSH draft version 19: It seems like final IETF reviews are concluding (deadline Aug 25), so we might consider updating the OVS implementation in 2.8 to align with version 19. At minimum this would mean restricting the nsh_mdtype field to 4 bits and possibly adjust

Re: [ovs-dev] [PATCH 1/4] netdev: Add set_ingress_sched to netdev api

Hi Mark, > -Original Message- > From: O Mahony, Billy > Sent: Wednesday, August 16, 2017 4:53 PM > To: Kavanagh, Mark B ; d...@openvswitch.org > Subject: RE: [ovs-dev] [PATCH 1/4] netdev: Add set_ingress_sched to netdev > api > > Hi Mark, > > I'm continuing

[ovs-dev] [PATCH 2/2] lib: Move lib/poll-loop.h to include/openvswitch

Poll-loop is the core to implement main loop. It should be available in libopenvswitch. Signed-off-by: Xiao Liang --- include/openvswitch/automake.mk | 1 + {lib => include/openvswitch}/poll-loop.h | 2 +- lib/bfd.c | 2 +-

[ovs-dev] [PATCH 1/2] lib: Move lib/rconn.h to include/openvswitch

Rconn provides useful features over vconn. Make it available to library users. Signed-off-by: Xiao Liang --- include/openvswitch/automake.mk | 1 + {lib => include/openvswitch}/rconn.h | 17 - lib/automake.mk | 1 -

[ovs-dev] [PATCH 0/2] Move some headers to public directory

Hi, This series moves lib/rconn.h and lib/poll-loop.h to include/openvswitch. Rconn is very useful in building applications with libopenvswitch. And vconn/rconn also needs main loop to actually work. I think they should be avaliable as public headers. Thanks, Xiao Xiao Liang (2): lib: Move

Re: [ovs-dev] [PATCH 1/4] netdev: Add set_ingress_sched to netdev api

Hi Mark, I'm continuing with rework/rebase. Some comments below. > -Original Message- > From: Kavanagh, Mark B > Sent: Friday, August 4, 2017 3:49 PM > To: O Mahony, Billy ; d...@openvswitch.org > Subject: RE: [ovs-dev] [PATCH 1/4] netdev: Add set_ingress_sched

Re: [ovs-dev] [RFC PATCH 1/1] dpif-netdev : Include Rxq processing cycles

Seems we are in sync on most points then. From: Jan Scheurich Date: Wednesday, August 16, 2017 at 8:03 AM To: Darrell Ball , Sugesh Chandran , "d...@openvswitch.org" , "ktray...@redhat.com"

[ovs-dev] OpenStack users list

style="color:rgb(46,116,181)">Hi,    style="color:rgb(46,116,181)">  A Quick Follow up to you that if you are interested in OpenStack users list which can help you to grow up your business campaigns?   We will provide you the information according to your criteria and

Re: [ovs-dev] [PATCH v3] openvswitch: enable NSH support

On Wed, Aug 16, 2017 at 01:35:30PM +0800, Yi Yang wrote: > v2->v3 > - Change OVS_KEY_ATTR_NSH to nested key to handle >length-fixed attributes and length-variable >attriubte more flexibly. > - Remove struct ovs_action_push_nsh completely > - Add code to handle nested attribute for

Re: [ovs-dev] [RFC PATCH 1/1] dpif-netdev : Include Rxq processing cycles

I believe that queue-related cycles stats should be part of the pmd-rxq-show output, possibly guarded by some command option. The queue statistics should be cumulative in the same sense as with pmd-stats-show, so that a user can reset them with the pmd-stats-clear command at any time and chose

[ovs-dev] [PATCH v2 2/2] python: Force file system encoding on cmdline args

On Windows, the default file system encoding is 'mbcs' resulting in a bad conversion. To make it cross-platform tolerant use 'sys.getfilesystemencoding()' instead of 'utf-8'. Co-authored-by: Alin Serdean Signed-off-by: Alin Balutoiu

[ovs-dev] [PATCH v2 1/2] python: fix python3 encode/decode on Windows

Fix double encoding/decoding on data, caused by 'get_decoded_buffer' and 'get_encoded_buffer'. The functions 'get_decoded_buffer' and 'get_encoded_buffer' from winutils have been removed. They are no longer necessary since the buffers received/returned are already in the right form. The

Re: [ovs-dev] [PATCH/RFC] bond: add enable-recirc configuration for bond.

Hi Andy, On Tue, Aug 15, 2017 at 01:31:36PM -0700, Andy Zhou wrote: > On Tue, Aug 15, 2017 at 9:13 AM, Simon Horman > wrote: > > From: Pieter Jansen van Vuuren > > > > Adds a config parameter that determines if a bond will use

Re: [ovs-dev] [PATCH/RFC] bond: add enable-recirc configuration for bond.

Hi Simon, This patch only covers how to prevent recirculation but does not describe how bond selection works in the absence of recirculation. Can you explain? Thanks, Jan > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf

Re: [ovs-dev] Yang, Yi Y sent you a message in Skype for Business-FYI: basically I have worked out a ovs nsh version per their requirements

Hi Yi, It is not correct that our implementation does not support MD2. OVS 2.8 will be able to receive and forward packets with NSH MD1 and MD2 headers (SFF use case). It should also be able to push an NSH header MD1 or MD2 format, with MD2 TLVs specified as encap properties, (Classifier use

Re: [ovs-dev] [PATCH v3] openvswitch: enable NSH support

On Wed, 16 Aug 2017 17:31:30 +0800, Yang, Yi wrote: > On Wed, Aug 16, 2017 at 11:19:21AM +0200, Jiri Benc wrote: > > > --- a/include/uapi/linux/openvswitch.h > > > +++ b/include/uapi/linux/openvswitch.h > > [...] > > > +#define NSH_MD1_CONTEXT_SIZE 4 > > > > Please move this to nsh.h and use it

Re: [ovs-dev] [PATCH 1/2] python: fix python3 encode/decode on Windows

> From: "Alin Balutoiu" > To: d...@openvswitch.org > Sent: Monday, August 14, 2017 9:47:06 PM > Subject: [ovs-dev] [PATCH 1/2] python: fix python3 encode/decode on Windows > > Fix double encoding/decoding on data, caused by > 'get_decoded_buffer' and

Re: [ovs-dev] [RFC patch v1] dp-packet: Refactor DPDK packet initialization.

Hi Darrel, Thank you for the patch. Please find my comments below. Regards _Sugesh > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Darrell Ball > Sent: Tuesday, August 15, 2017 5:14 PM > To: dlu...@gmail.com;

Re: [ovs-dev] [PATCH v1] netdev-dpdk: Implement TCP/UDP TX cksum in ovs-dpdk side

Hi Loftus, I had submitted a new version, please see https://patchwork.ozlabs.org/patch/802070/ It move the cksum to vhost receive side. Thanks Zhenyu Gao 2017-08-10 12:35 GMT+08:00 Gao Zhenyu : > I see, for flows in phy-phy setup, they should not be calculate

[ovs-dev] [PATCH v3] netdev-dpdk: Implement TCP/UDP TX cksum in ovs-dpdk side

Currently, the dpdk-vhost side in ovs doesn't support tcp/udp tx cksum. So L4 packets's cksum were calculated in VM side but performance is not good. Implementing tcp/udp tx cksum in ovs-dpdk side improves throughput and makes virtio-net frontend-driver support NETIF_F_SG as well Signed-off-by:

Re: [ovs-dev] [PATCH v3 1/4] dpif-netdev: Skip EMC lookup/insert for recirc packets

> -Original Message- > From: Darrell Ball [mailto:db...@vmware.com] > Sent: Wednesday, August 16, 2017 9:09 AM > To: Fischetti, Antonio ; d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v3 1/4] dpif-netdev: Skip EMC lookup/insert for > recirc packets > >

[ovs-dev] [PATCH] netdev-tc-offloads: Add prefix to identify source of log msg

There is an identical log msg from multiple api calls. Add a prefix to identify the source function of the log msg. Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey --- lib/netdev-tc-offloads.c | 12 ++-- 1 file changed, 6 insertions(+), 6

[ovs-dev] [PATCH 2/2] dpif: Fix cleanup of netdev_ports map

Executing dpctl commands from userspace also calls to dpif_open()/dpif_close() but not really creating another dpif but using a clone. As for netdev_ports map is global we avoid adding duplicate entries but also need to make sure we are not removing needed entries. With this commit we make sure

[ovs-dev] [PATCH 1/2] tests/system-offloads-traffic.at: add sanity check

Doing dump-flows also altering the netdev ports list. So doing it pre the actual test is adding a check to make sure we don't break the that list. Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey --- tests/system-offloads-traffic.at | 1 + 1 file

[ovs-dev] [PATCH 0/2] Fix rules not offloaded after executing dpctl command

Hi, The first patch is small update to the test to catch this error early. The second patch is the actual fix not to clean netdev_ports map early. Thanks, Roi Roi Dayan (2): tests/system-offloads-traffic.at: add sanity check dpif: Fix cleanup of netdev_ports map lib/dpif.c

Re: [ovs-dev] [PATCH V3 0/2] Fix rules not offloaded after executing dpctl command

On 16/08/2017 15:11, Roi Dayan wrote: Hi, The first patch is small update to the test to catch this error early. The second patch is the actual fix not to clean netdev_ports map early. Thanks, Roi Roi Dayan (2): tests/system-offloads-traffic.at: add sanity check dpif: Fix cleanup of

[ovs-dev] [PATCH V3 2/2] dpif: Fix cleanup of netdev_ports map

Executing dpctl commands from userspace also calls to dpif_open()/dpif_close() but not really creating another dpif but using a clone. As for netdev_ports map is global we avoid adding duplicate entries but also need to make sure we are not removing needed entries. With this commit we make sure

[ovs-dev] [PATCH V3 0/2] Fix rules not offloaded after executing dpctl command

Hi, The first patch is small update to the test to catch this error early. The second patch is the actual fix not to clean netdev_ports map early. Thanks, Roi Roi Dayan (2): tests/system-offloads-traffic.at: add sanity check dpif: Fix cleanup of netdev_ports map lib/dpif.c

[ovs-dev] [PATCH V3 1/2] tests/system-offloads-traffic.at: add sanity check

Doing dump-flows also altering the netdev ports list. So doing it pre the actual test is adding a check to make sure we don't break the that list. Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey --- tests/system-offloads-traffic.at | 1 + 1 file

Re: [ovs-dev] [PATCH v3] openvswitch: enable NSH support

On Wed, Aug 16, 2017 at 11:19:21AM +0200, Jiri Benc wrote: > Please always CC reviewers of the previous versions, thanks. Jiri, thank you for quick review. Sorry, I made a mistake on sending and missed all the CCs, will indeed do this in next version. > > + __be16 ver_flags_len; > > + u8

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-ipfix: add interface Information Elements to flow key

Hi, I haven't received any feedback on this patch for quite some time. Is there anything that I can do to expedite review process? Regards, Przemek > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Szczerbik,

Re: [ovs-dev] [PATCH v3 1/4] dpif-netdev: Skip EMC lookup/insert for recirc packets

-Original Message- From: "Fischetti, Antonio" Date: Tuesday, August 15, 2017 at 6:55 AM To: Darrell Ball , "d...@openvswitch.org" Subject: RE: [ovs-dev] [PATCH v3 1/4] dpif-netdev: Skip EMC lookup/insert for recirc

[ovs-dev] [PATCH] nsh: rework NSH netlink keys and actions

Per kernel data path requirements, this patch changes OVS_KEY_ATTR_NSH to nested attribute and adds three new NSH sub attribute keys: OVS_NSH_KEY_ATTR_BASE: for length-fixed NSH base header OVS_NSH_KEY_ATTR_MD1: for length-fixed MD type 1 context OVS_NSH_KEY_ATTR_MD2: for

Re: [ovs-dev] [RFC PATCH 1/1] dpif-netdev : Include Rxq processing cycles

I know there is some debate about where this o/p fits – pmd-rxq-show or pmd-stats-show If this is meant to support Kevin’s series - OVS-DPDK rxq to pmd assignment improvements ?, then maybe pmd-rxq-show might be easier since pmd-stats-show has lots of other info. Maybe an ‘option’ to

[ovs-dev] [PATCH v1] ovn: Fix BFD error config on gateway

The bfd_calculate_chassis function calculates gateway's peer datapaths to figure our which chassis should be add in bfd_chassis. But in most circumstance, a gateway's peer datapath has NO chassis. So it may disable BFD on some tunnel ports. Then a port on a remote ovs cannot send packet out

Re: [ovs-dev] [PATCH v4 0/6] OVS-DPDK rxq to pmd assignment improvements.

Hi Kevin I did some basic testing and parsed all the code. I have some high level comments, below. I’ll add the other comments tomorrow. 1/ The redistribution is based on the last interval – I wonder if a number of intervals may be better. Possibly a single interval could result in a