Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
build:
BUILD_ASSERT_DECL(offsetof(struct STRUCT, MEMBER) \
^
Hmm.
Kevin already has a patch-set with the same purpose:
https://patchwork.ozlabs.org/project/openvswitch/list/?series=75100
This patch-set already has some review comments. You can make your
comments too.
Anyway, Kevin, Ophir, you need to synchronize somehow in order to stop
duplicating
With --detach but not --no-chdir, core files and Address Sanitizer logs
don't go into the testsuite directory but end up dropped because it tries
to write them in the root directory.
Signed-off-by: Ben Pfaff
---
tests/bridge.at | 4 +-
tests/daemon-py.at | 12 ++---
The functions to put ofpacts into ofpbufs have always padded them to
OFPACT_ALIGNTO boundaries, but the underlying structures weren't
necessarily padded out. That led to difficulties in a few places where
structures were allocated on the stack instead in an ofpbuf, because
functions like
This makes the tests all pass cleanly when Address Sanitizer is enabled.
Signed-off-by: Ben Pfaff
---
Documentation/intro/install/general.rst | 7 +++
tests/atlocal.in| 5 +
tests/daemon.at | 8
tests/ovs-macros.at
dp_packet_put_uninit() can reallocate the data buffer, so find the L4
header pointer afterward instead of before.
Found by Address Sanitizer.
Signed-off-by: Ben Pfaff
---
lib/packets.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/packets.c b/lib/packets.c
index
When server A sends the leader a request to remove server B from the
cluster, where A != B, the leader sends both A and B a notification when
the removal is complete. Until now, however, the notification (which is a
raft_remove_server_reply message) did not say which server had been
removed, and
When the server is leaving the cluster but remains leader, the
raft_find_server() call can return NULL. Previously this caused a null
dereference. This commit fixes the problem.
Signed-off-by: Ben Pfaff
---
ovsdb/raft.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git
raft_update_commit_index() iterates over a sequence of entries that may
have up to two components: a set of servers and a piece of data. When
a set of servers is present, it calls raft_run_reconfigure(), which can
call through the following chain of functions in some cases:
Ordinarily the IDL finds out in advance whether a particular database is
on its server, or it finds out via notifications. But it's also a good
idea to adopt a belt-and-suspenders approach so that, if the IDL does
receive an "unknown database" error, we treat it as a "soft" error that
can be
For debugging, it is useful to know the source code line that sent a
given RPC message.
Signed-off-by: Ben Pfaff
---
ovsdb/raft.c | 55 ++-
1 file changed, 34 insertions(+), 21 deletions(-)
diff --git a/ovsdb/raft.c b/ovsdb/raft.c
index
Until now the code here would happily try to send transactions to the
database server even if the database connection was not in the correct
state. In some cases this could lead to strange behavior, such as sending
a database transaction for a database that the IDL had just learned did not
exist
Bleep bloop. Greetings Harry van Haaren, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
build:
libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include
-I ./lib -I
Bleep bloop. Greetings Harry van Haaren, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Improper whitespace around control block
#77 FILE:
This commit optimizes the dpcls_rule_matches_key() function
by refactoring the code to be shorter and less branchy. The
main code-change (and optimization) is to use popcount and
mask to calculate the packet block index.
This code is split out to the header file, which is marked as
static inline.
This commit moves some data-structures to be available
in the dpif-netdev.h header. This allows specific implementations
of the subtable lookup function to include just that header
file, and not require that the code exists in dpif-netdev.c
Signed-off-by: Harry van Haaren
---
lib/dpif-netdev.c
Hi Folks,
This patchset is a v2 on previous patches as in this bundle:
https://patchwork.ozlabs.org/bundle/hvanhaar/dpcls_func_ptr_opt/
The work contained in this patchset achieves the following;
Patch 1:
Refactor dpcls_lookup and the subtable for flexibility.
In particular, add a function
If parse_ofp_flow_mod_str returns no error, ofputil_flow_mod.match
contains allocated memory that should be free. This patch fixes it.
Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11343
Signed-off-by: Yifeng Sun
---
tests/oss-fuzz/ofctl_parse_target.c | 1 +
1 file
Bleep bloop. Greetings Ophir Munk, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Inappropriate bracing around statement
#178 FILE: lib/netdev-dpdk.c:1230:
if
1. Enable compilation and linkage with dpdk 18.11.x
2. Update references to DPDK version 18.11 in Documentation and in
travis linux-build script
3. Replace deprecated functions calls
- rte_eth_dev_attach
- rte_eth_dev_detach
with their respective new calls
- rte_dev_probe
-
This patch will be superseded. It will be resent to dpdk-latest branch
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Thanks for fixing this. The files normally get deleted when the agent closes.
Is this a regression or just test related? Ack'ing the fix.
Acked-by: Sairam Venugopal
On 11/14/18, 7:31 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin
Gabriel Serdean" wrote:
On Windows the file
OVS_BUFFER_CONTEXT gets cleared as part of NdisFreeNetBufferListContext
function call. This causes an invalid reference error.
Found while testing with driver verifier enabled.
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/BufferMgmt.c | 6 --
1 file changed, 4 insertions(+),
Bleep bloop. Greetings Ophir Munk, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
Failed to merge in the changes.
Patch failed at 0001 netdev-dpdk: Upgrade to dpdk v18.11
The copy of
Please note this patch is targeted for dpdk-latest and dpdk-hwol branches
> -Original Message-
> From: Ophir Munk
> Sent: Wednesday, November 14, 2018 7:13 PM
> To: ovs-dev@openvswitch.org
> Cc: Asaf Penso ; Ian Stokes ;
> Ben Pfaff ; Shahaf Shuler ; Thomas
> Monjalon ; Olga Shern ;
>
1. Enable compilation and linkage with dpdk 18.11.x
2. Update references to DPDK version 18.11 in Documentation and in
travis linux-build script
3. Replace deprecated functions calls
- rte_eth_dev_attach
- rte_eth_dev_detach
with their respective new calls
- rte_dev_probe
-
Okay. I want to make sure that we don't end up with 3 gateway
implementations. We currently have 2. So when you are adding this new
feature, please do NOT make it an independent feature which only works for
your use case. It will be a maintenance headache otherwise. Instead, it has
to be looked at
On Windows the file which is used for the named pipe connection (`punix:file`)
is not deleted when the process is closed.
Try to delete the `controller` file and fail if we can't (on Windows you can't
delete a file if there still an opened handle to it).
Also add a check to see if the
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
There is no sense returning the field because it never used.
Function returns the pointer just to allow the caller to free it.
Returning the pointer to the actual structure simplifies the code
allowing not to explain why we're freeing the container of.
Signed-off-by: Ilya Maximets
---
Hi Guru,
Sure, providing more explanation.
Q. What are we trying to solve?
Ans. Getting distributed routing to work for vlan backed networks through OVN.
Q. Disconnect wrt OVN capabilities for above task?
Ans. OVN lacks in certain areas wrt how to forward the packets
"correctly/efficiently"
> DEV_RX_OFFLOAD_CRC_STRIP has been removed from DPDK 18.11.
> DEV_RX_OFFLOAD_KEEP_CRC can now be used to keep the CRC. This doesn't
> change any behaviour in OVS, just updates to use the correct flags.
>
> Signed-off-by: Kevin Traynor
> ---
> lib/netdev-dpdk.c | 4 ++--
> 1 file changed, 2
On 12 Nov 2018, at 12:26, Eelco Chaudron wrote:
On 12 Nov 2018, at 12:18, Alejandro Lucero wrote:
When using large amount of hugepage based memory, doing all the
hugepages mapping can take quite significant time.
The problem is hugepages being initially mmaped to virtual addresses
which
33 matches
Mail list logo
