Re: [ovs-dev] [PATCH V3 18/19] netdev-offload-dpdk: Support offload of clone tnl_push/output actions

2019-12-09 Thread Eli Britstein
On 12/10/2019 8:52 AM, Sathya Perla wrote: > On Sun, Dec 8, 2019 at 6:53 PM Eli Britstein wrote: > ... >> +static int >> +parse_clone_actions(struct netdev *netdev, >> +struct flow_actions *actions, >> +const struct nlattr *clone_actions, >> +

Re: [ovs-dev] [PATCH V3 18/19] netdev-offload-dpdk: Support offload of clone tnl_push/output actions

2019-12-09 Thread Sathya Perla via dev
On Sun, Dec 8, 2019 at 6:53 PM Eli Britstein wrote: > ... > +static int > +parse_clone_actions(struct netdev *netdev, > +struct flow_actions *actions, > +const struct nlattr *clone_actions, > +const size_t clone_actions_len, > +

[ovs-dev] par les mains

2019-12-09 Thread Catherine
DEVENEZ MAGNETISEUR Quel que soit votre mtier actuel, nous pouvons vous former utiliser les techniques de de mieux-tre innovantes et trs efficaces. Un nouveau mtier pour une nouvelle vie ! - Vous installer votre compte tout

[ovs-dev] Ich brauche deine Hilfe !!!

2019-12-09 Thread henrique . blanck
Ich bin Fräulein Sabine Peters, Ich brauche Ihre unterstützung um für ein Investierung projekt in Ihr Land zu ziehen Ich bitte Sie um Hilfe. weil ich nicht über Geschäft und die Regeln weiß, die Ihr Land für einesichere Investitionen führen. Freundliche Grüße, Fräulein Sabine.

Re: [ovs-dev] [PATCH 0/3] checkpatch: Spell checker enhancements.

2019-12-09 Thread Ilya Maximets
On 09.12.2019 15:44, Aaron Conole wrote: > Ilya Maximets writes: > >> Ilya Maximets (3): >> checkpatch: Allow common abbreviations for spell checking. >> checkpatch: Skip words containing numbers. >> checkpatch: Check spelling in commit messages. >> >> utilities/checkpatch.py | 41

Re: [ovs-dev] [PATCH 1/3] dpif-netdev: Avoid infinite re-addition of misconfigured ports.

2019-12-09 Thread William Tu
On Sat, Dec 07, 2019 at 03:46:16PM +0100, Ilya Maximets wrote: > Infinite re-addition of failed ports happens if the device in userspace > datapath has a linux network interface and it's not able to be > configured. For example, if the first reconfiguration fails because of > misconfiguration or

Re: [ovs-dev] [PATCH 3/3] system-afxdp.at: Add test for infinite re-addition of failed ports.

2019-12-09 Thread William Tu
On Sat, Dec 07, 2019 at 03:46:18PM +0100, Ilya Maximets wrote: > New file created for AF_XDP specific tests. > > Signed-off-by: Ilya Maximets tested and LGTM, one minor comment. Acked-by: William Tu > --- > tests/automake.mk | 3 ++- > tests/system-afxdp-testsuite.at | 1 + >

Re: [ovs-dev] [PATCH 2/3] netdev-afxdp: Avoid removing of XDP program if not loaded.

2019-12-09 Thread William Tu
On Sat, Dec 07, 2019 at 03:46:17PM +0100, Ilya Maximets wrote: > 'bpf_set_link_xdp_fd' generates netlink event regardless of actual > changes it does, so if-notifier will receive link update even if > there was no XDP program previously loaded on the interface. > > OVS tries to remove XDP program

Re: [ovs-dev] [PATCHv5] netdev-afxdp: Enable loading XDP program.

2019-12-09 Thread William Tu
On Thu, Dec 05, 2019 at 03:32:19PM +0100, Eelco Chaudron wrote: > > > On 23 Nov 2019, at 1:26, William Tu wrote: > > >Now netdev-afxdp always forwards all packets to userspace because > >it is using libbpf's default XDP program, see 'xsk_load_xdp_prog'. > >There are some cases when users want

Re: [ovs-dev] [PATCH 3/3] checkpatch: Check spelling in commit messages.

2019-12-09 Thread William Tu
On Sun, Dec 08, 2019 at 08:42:34PM +0100, Ilya Maximets wrote: > This seems useful as I'm usually making a lot of typing mistakes. > Also, few commonly used words added to the extended dictionary. > > Signed-off-by: Ilya Maximets > --- Acked-by: William Tu > utilities/checkpatch.py | 33

Re: [ovs-dev] [PATCH 2/3] checkpatch: Skip words containing numbers.

2019-12-09 Thread William Tu
On Sun, Dec 08, 2019 at 08:42:33PM +0100, Ilya Maximets wrote: > Words like 'br0' are common and usually references some code or > database objects that should not be targets for spell checking. > So, it's better to skip all the words that has digits inside instead > of ones that starts with

Re: [ovs-dev] [PATCH 1/3] checkpatch: Allow common abbreviations for spell checking.

2019-12-09 Thread William Tu
On Sun, Dec 08, 2019 at 08:42:32PM +0100, Ilya Maximets wrote: > Abbreviations of Latin expressions like 'i.e.' or 'e.g.' are common > and known by the dictionary. However, our spell checker is not able > to recognize them because it strips dots out of them. To avoid this > issue we could pass

Re: [ovs-dev] [PATCH ovn v1] northd: Load config before processing nbdb contents

2019-12-09 Thread Russell Bryant
On Mon, Dec 9, 2019 at 11:44 AM Numan Siddique wrote: > On Mon, Dec 9, 2019 at 11:05 AM Russell Bryant wrote: > > > > Reorder ovnnb_db_run() such that configuration parameters are loaded > > or initialized before processing the nbdb contents. > > > > I found this bug because I noticed dynamic

Re: [ovs-dev] [PATCH ovn v1] northd: Load config before processing nbdb contents

2019-12-09 Thread Numan Siddique
On Mon, Dec 9, 2019 at 11:05 AM Russell Bryant wrote: > > Reorder ovnnb_db_run() such that configuration parameters are loaded > or initialized before processing the nbdb contents. > > I found this bug because I noticed dynamic MAC addresses being > assigned at ovn-northd startup with an empty

Re: [ovs-dev] [PATCH ovn v1 2/2] northd: Log all dynamic address assignments

2019-12-09 Thread Russell Bryant
On Mon, Dec 9, 2019 at 11:18 AM Numan Siddique wrote: > On Mon, Dec 9, 2019 at 8:17 AM Russell Bryant wrote: > > > > On Mon, Dec 9, 2019 at 3:01 AM Dumitru Ceara wrote: > > > > > On Sun, Dec 8, 2019 at 5:12 AM Russell Bryant wrote: > > > > > > > > This patch adds INFO level log messages for

Re: [ovs-dev] [PATCH 0/4] Add support for TSO with DPDK

2019-12-09 Thread Loftus, Ciara
> > Abbreviated as TSO, TCP Segmentation Offload is a feature which enables > the network stack to delegate the TCP segmentation to the NIC reducing > the per packet CPU overhead. > > A guest using vhost-user interface with TSO enabled can send TCP packets > much bigger than the MTU, which saves

Re: [ovs-dev] [PATCH ovn v1 2/2] northd: Log all dynamic address assignments

2019-12-09 Thread Numan Siddique
On Mon, Dec 9, 2019 at 8:17 AM Russell Bryant wrote: > > On Mon, Dec 9, 2019 at 3:01 AM Dumitru Ceara wrote: > > > On Sun, Dec 8, 2019 at 5:12 AM Russell Bryant wrote: > > > > > > This patch adds INFO level log messages for all dynamic address > > > assignments (MAC, IPv4, IPv6). While

[ovs-dev] [PATCH ovn v1] northd: Load config before processing nbdb contents

2019-12-09 Thread Russell Bryant
Reorder ovnnb_db_run() such that configuration parameters are loaded or initialized before processing the nbdb contents. I found this bug because I noticed dynamic MAC addresses being assigned at ovn-northd startup with an empty prefix. Later, it would switch to allocating MAC addresses with the

Re: [ovs-dev] [PATCH v3 03/10] tc: Introduce tcf_id to specify a tc filter

2019-12-09 Thread Paul Blakey
On 12/3/2019 3:45 PM, Roi Dayan wrote: > @@ -1428,38 +1419,35 @@ netdev_tc_flow_put(struct netdev *netdev, struct > match *match, > } > } > > -block_id = get_block_id_from_netdev(netdev); Accidentally removed this line, will post V4 soon with this fix. There is nothing

Re: [ovs-dev] [PATCH 0/3] checkpatch: Spell checker enhancements.

2019-12-09 Thread Aaron Conole
Ilya Maximets writes: > Ilya Maximets (3): > checkpatch: Allow common abbreviations for spell checking. > checkpatch: Skip words containing numbers. > checkpatch: Check spelling in commit messages. > > utilities/checkpatch.py | 41 +++-- > 1 file

[ovs-dev] [PATCH] tests: introduced test for checking "ovs-vsctl emer-reset"

2019-12-09 Thread Damijan Skvarc
Signed-off-by: Damijan Skvarc --- tests/ovs-vsctl.at | 119 + 1 file changed, 119 insertions(+) diff --git a/tests/ovs-vsctl.at b/tests/ovs-vsctl.at index ff39e15..00a832c 100644 --- a/tests/ovs-vsctl.at +++ b/tests/ovs-vsctl.at @@ -531,6

Re: [ovs-dev] [PATCH ovn v1 1/2] tests: Updated expected log message

2019-12-09 Thread Russell Bryant
On Mon, Dec 9, 2019 at 2:54 AM Dumitru Ceara wrote: > On Sun, Dec 8, 2019 at 5:18 AM Russell Bryant wrote: > > > > A previous commit added more detail to this log message. Fix the test > > to reflect the new text. > > > > Signed-off-by: Russell Bryant > > Hi Russell, > > Thanks for fixing the

Re: [ovs-dev] [PATCH ovn v1 2/2] northd: Log all dynamic address assignments

2019-12-09 Thread Russell Bryant
On Mon, Dec 9, 2019 at 3:01 AM Dumitru Ceara wrote: > On Sun, Dec 8, 2019 at 5:12 AM Russell Bryant wrote: > > > > This patch adds INFO level log messages for all dynamic address > > assignments (MAC, IPv4, IPv6). While debugging some issues in > > ovn-kubernetes, I found it would be helpful

Re: [ovs-dev] [PATCH V2 11/19] dpif-netdev: Read hw stats during flow_dump_next() call

2019-12-09 Thread Ilya Maximets
On 06.12.2019 17:29, Eli Britstein wrote: > > On 12/6/2019 6:04 PM, Ilya Maximets wrote: >> On 04.12.2019 21:23, Eli Britstein wrote: >>> On 12/4/2019 8:58 PM, Ilya Maximets wrote: On 04.12.2019 18:15, Eli Britstein wrote: > On 12/4/2019 5:58 PM, Ilya Maximets wrote: >> On 04.12.2019

Re: [ovs-dev] [OVN][RAFT] Follower refusing new entries from leader

2019-12-09 Thread taoyunupt
Hi, Han, I do not encounter that problem these days after using this patch. I think there is no COMPACT in my environment. Actaully , I don't see any snap file in /var/lib/openvswitch. Thanks, Yun At 2019-12-04 10:01:16, "Han Zhou" wrote: Hi, Could you see if this

Re: [ovs-dev] [PATCH V3 08/19] netdev-offload-dpdk: Protect UFID map by mutex

2019-12-09 Thread 贺鹏
Got it. You're correct. Eli Britstein 于2019年12月9日周一 下午3:21写道: > > > On 12/9/2019 9:15 AM, 贺鹏 wrote: > > Hi, > > > > > > cmap support multiple readers and one writer. > > since all write operations are performed in the offload thread, > > why need a mutex here? Maybe I miss some patches. >

Re: [ovs-dev] datapath-windows: Don't delete internal port

2019-12-09 Thread Alin Serdean
Applied on master! Thank you! On 6 Dec 2019, at 16:39, Alin Serdean mailto:aserd...@cloudbasesolutions.com>> wrote: On 3 Dec 2019, at 06:38, Jinjun Gao mailto:jinj...@vmware.com>> wrote: According to the microsoft doc:

Re: [ovs-dev] [PATCH v3 00/10] Add support for offloading CT datapath rules to TC

2019-12-09 Thread Paul Blakey
On 12/6/2019 11:46 AM, Simon Horman wrote: > On Thu, Dec 05, 2019 at 12:31:39PM +, Paul Blakey wrote: >> On 12/4/2019 2:26 PM, Simon Horman wrote: >>> On Wed, Dec 04, 2019 at 08:10:10AM +, Paul Blakey wrote: On 12/3/2019 6:41 PM, Simon Horman wrote: > On Tue, Dec 03, 2019 at

Re: [ovs-dev] [PATCH v2 3/3] travis: Enable OvS Travis CI for arm

2019-12-09 Thread Lance Yang (Arm Technology China)
> -Original Message- > From: Ilya Maximets > Sent: Saturday, December 7, 2019 12:39 AM > To: Lance Yang (Arm Technology China) ; > ovs-dev@openvswitch.org > Cc: i.maxim...@ovn.org; b...@ovn.org; Yanqin Wei (Arm Technology China) > ; dwil...@us.ibm.com; Gavin Hu (Arm Technology China) >

[ovs-dev] [PATCH ovn v2] ovn-controller: Run I-P engine even when no SB txn is available.

2019-12-09 Thread Dumitru Ceara
If the last ovn-controller main loop run started a transaction to the Southbound DB and the transaction is still in progress, ovn-controller will not call engine_run(). In case there were changes to the DB, engine_need_run() would return true which would trigger an immediate forced recompute in

Re: [ovs-dev] [PATCH ovn v1 2/2] northd: Log all dynamic address assignments

2019-12-09 Thread Dumitru Ceara
On Sun, Dec 8, 2019 at 5:12 AM Russell Bryant wrote: > > This patch adds INFO level log messages for all dynamic address > assignments (MAC, IPv4, IPv6). While debugging some issues in > ovn-kubernetes, I found it would be helpful to see ovn-northd's view > of what addresses were assigned where