Re: [ovs-dev] OVN Soft Freeze

2020-01-29 Thread Han Zhou
On Tue, Jan 28, 2020 at 1:37 PM Han Zhou wrote: > > > > On Tue, Jan 21, 2020 at 3:08 AM Mark Michelson wrote: > > > > Hi all, > > > > OVN has entered its "soft freeze" state. That means that any new > > features that should be added prior to the next release need to have > > reviews posted

[ovs-dev] [PATCH ovn] NEWS: Add the news for ECMP support.

2020-01-29 Thread Han Zhou
Signed-off-by: Han Zhou --- NEWS | 1 + 1 file changed, 1 insertion(+) diff --git a/NEWS b/NEWS index 2b8cd6f..d4f5dee 100644 --- a/NEWS +++ b/NEWS @@ -6,6 +6,7 @@ Post-OVS-v2.12.0 - Added Stateless Floating IP support in OVN. - Added Forwarding Group support in OVN. - Added support

Re: [ovs-dev] [PATCH ovn v1] ovn-openstack.rst: Account for networking-ovn-migration

2020-01-29 Thread 0-day Robot
Bleep bloop. Greetings Flavio Fernandes, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 82 characters long (recommended limit is 79) #56 FILE:

[ovs-dev] [PATCH] userspace: Enable TSO support for non-DPDK.

2020-01-29 Thread William Tu
For some cases, we want to use userspace datapath but not with DPDK library, ex: using AF_XDP. The patch enables non-DPDK support for TSO (TCP Segmentation Offload). I measured the performance using: iperf3 -c (ns0) -> veth peer -> OVS -> veth peer -> iperf3 -s (ns1) And got around 6Gbps,

[ovs-dev] [PATCH] netdev-linux: Prepend the std packet in the TSO packet

2020-01-29 Thread Flavio Leitner
Usually TSO packets are close to 50k, 60k bytes long, so to to copy less bytes when receiving a packet from the kernel change the approach. Instead of extending the MTU sized packet received and append with remaining TSO data from the TSO buffer, allocate a TSO packet with enough headroom to

[ovs-dev] [PATCH ovn v1] ovn-openstack.rst: Account for networking-ovn-migration

2020-01-29 Thread Flavio Fernandes
The networking-ovn repo has been migrated into Neutron [0] as of Ussuri release. This change implements the necessary updates to the OVN OpenStack tutorial. Other minor changes here include commands needed to make Devstack work with Centos 7, as well as the removal of workarounds that are no

Re: [ovs-dev] [PATCH v4 0/3] Add support for TSO with DPDK

2020-01-29 Thread Yifeng Sun
Got it. Thanks. Yifeng On Wed, Jan 29, 2020 at 3:04 PM Flavio Leitner wrote: > > On Wed, Jan 29, 2020 at 02:42:27PM -0800, Yifeng Sun wrote: > > Hi Flavio, > > Hi Yifend, thanks for looking into this. > > > I found this piece of code in kernel's drivers/net/virtio_net.c and > > its function

Re: [ovs-dev] [PATCH v4 0/3] Add support for TSO with DPDK

2020-01-29 Thread Flavio Leitner
On Wed, Jan 29, 2020 at 02:42:27PM -0800, Yifeng Sun wrote: > Hi Flavio, Hi Yifend, thanks for looking into this. > I found this piece of code in kernel's drivers/net/virtio_net.c and > its function receive_buf(): > if (hdr->hdr.flags & VIRTIO_NET_HDR_F_DATA_VALID) >

Re: [ovs-dev] [PATCH v4 0/3] Add support for TSO with DPDK

2020-01-29 Thread Yifeng Sun
Hi Flavio, I found this piece of code in kernel's drivers/net/virtio_net.c and its function receive_buf(): if (hdr->hdr.flags & VIRTIO_NET_HDR_F_DATA_VALID) skb->ip_summed = CHECKSUM_UNNECESSARY; My understanding is that vhost_user needs to set flag VIRTIO_NET_HDR_F_DATA_VALID

Re: [ovs-dev] [PATCH ovn v4 13/13] tutorial: Add tutorial for OVN Interconnection.

2020-01-29 Thread 0-day Robot
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 85 characters long (recommended limit is 79) #122 FILE:

Re: [ovs-dev] [PATCH v4 0/3] Add support for TSO with DPDK

2020-01-29 Thread Flavio Leitner
On Wed, Jan 29, 2020 at 11:19:47AM -0800, William Tu wrote: > On Wed, Jan 29, 2020 at 3:25 AM Flavio Leitner wrote: > > > > On Tue, Jan 28, 2020 at 03:23:02PM -0800, Yifeng Sun wrote: > > > Sure. > > > > > > Firstly, make sure userspace-tso-enable is true > > > # ovs-vsctl get Open_vSwitch .

Re: [ovs-dev] [PATCH ovn v4 12/13] ovn-ctl: Support commands for interconnection.

2020-01-29 Thread 0-day Robot
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 85 characters long (recommended limit is 79) #54 FILE: utilities/ovn-ctl:112:

Re: [ovs-dev] [PATCH ovn v4 11/13] ovn-ctl: Refactor to reduce redundant code.

2020-01-29 Thread 0-day Robot
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 83 characters long (recommended limit is 79) #58 FILE: utilities/ovn-ctl:72:

Re: [ovs-dev] [PATCH ovn v4 09/13] ovn-ic: Interconnection port controller.

2020-01-29 Thread 0-day Robot
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Comment with 'xxx' marker #321 FILE: ic/ovn-ic.c:652: /* XXX: Sync encap so that

Re: [ovs-dev] [PATCH ovn v4 06/13] ovn-ic: Transit switch controller.

2020-01-29 Thread 0-day Robot
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #325 FILE: ovn-sb.xml:2367:

Re: [ovs-dev] [PATCH ovn v4 04/13] ovn-ic: Interconnection controller with AZ registeration.

2020-01-29 Thread 0-day Robot
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 81 characters long (recommended limit is 79) #83 FILE: ic/ovn-ic.8.xml:12:

Re: [ovs-dev] [PATCH ovn v4 03/13] ovn-ic-sb: Interconnection southbound DB schema and CLI.

2020-01-29 Thread 0-day Robot
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #269 FILE: ovn-ic-sb.ovsschema:34:

Re: [ovs-dev] [PATCH ovn v4 02/13] ovn-ic-nb: Interconnection northbound DB schema and CLI.

2020-01-29 Thread 0-day Robot
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 85 characters long (recommended limit is 79) #346 FILE: ovn-ic-nb.xml:35:

Re: [ovs-dev] [PATCH v2] dpdk: Support running PMD threads on cores > RTE_MAX_LCORE.

2020-01-29 Thread Aaron Conole
David Marchand writes: > Most DPDK components make the assumption that rte_lcore_id() returns > a valid lcore_id in [0..RTE_MAX_LCORE[ range (with the exception of > the LCORE_ID_ANY special value). > OVS does not currently check which value is set in > RTE_PER_LCORE(_lcore_id) which exposes us

Re: [ovs-dev] [PATCH ovn v3 00/13] OVN Interconnection

2020-01-29 Thread Han Zhou
On Wed, Jan 29, 2020 at 11:44 AM Numan Siddique wrote: > > On Tue, Jan 28, 2020 at 8:26 AM Han Zhou wrote: > > > > The series supports interconnecting multiple OVN deployments (e.g. located at > > multiple data centers) through logical routers connected with tansit logical > > switches with

[ovs-dev] [PATCH ovn v4 12/13] ovn-ctl: Support commands for interconnection.

2020-01-29 Thread Han Zhou
Add support for managing IC-NB and IC-SB DBs, and ovn-ic daemon. Signed-off-by: Han Zhou --- utilities/ovn-ctl | 364 +++- utilities/ovn-ctl.8.xml | 91 2 files changed, 453 insertions(+), 2 deletions(-) diff --git

[ovs-dev] [PATCH ovn v4 13/13] tutorial: Add tutorial for OVN Interconnection.

2020-01-29 Thread Han Zhou
Added tutorial, and also updated NEWS and TODO. Tested-by: Aliasgar Ginwala Signed-off-by: Han Zhou --- Documentation/automake.mk | 1 + Documentation/tutorials/index.rst | 1 + Documentation/tutorials/ovn-interconnection.rst | 188

[ovs-dev] [PATCH ovn v4 11/13] ovn-ctl: Refactor to reduce redundant code.

2020-01-29 Thread Han Zhou
This patch helps reducing redundant code in next patch for adding support for interconnection related DBs and daemon. Signed-off-by: Han Zhou --- utilities/ovn-ctl | 61 +++ 1 file changed, 35 insertions(+), 26 deletions(-) diff --git

[ovs-dev] [PATCH ovn v4 03/13] ovn-ic-sb: Interconnection southbound DB schema and CLI.

2020-01-29 Thread Han Zhou
This patch introduces OVN_IC_Southbound DB schema and the CLI ovn-ic-sbctl that manages the DB. Signed-off-by: Han Zhou --- .gitignore |3 + automake.mk | 36 ++ debian/ovn-common.install|1 + debian/ovn-common.manpages |2 + lib/.gitignore

[ovs-dev] [PATCH ovn v4 09/13] ovn-ic: Interconnection port controller.

2020-01-29 Thread Han Zhou
Sync interconnection logical ports and bindings between NB, SB and IC-SB. With this patch, the OVN interconnection works end to end. Signed-off-by: Han Zhou --- controller/binding.c | 6 +- ic/ovn-ic.c| 385 - lib/ovn-util.c

[ovs-dev] [PATCH ovn v4 08/13] ovn-ic: Interconnection gateway controller.

2020-01-29 Thread Han Zhou
Sync local and remote gateways between SB and IC-SB. Signed-off-by: Han Zhou --- ic/ovn-ic.c | 147 tests/ovn-ic.at | 55 + 2 files changed, 202 insertions(+) diff --git a/ic/ovn-ic.c b/ic/ovn-ic.c index

[ovs-dev] [PATCH ovn v4 07/13] ovn-sb: Add keys is_interconn and is_remote to Chassis's external_ids.

2020-01-29 Thread Han Zhou
Support the new keys in external_ids column of Chassis table for OVN interconnection. Also, populate the is_interconn key according to external_ids:ovn-is-interconn key of Open_vSwitch table on the chassis. This patch also avoids creating tunnel or bfd sessions with remote chassis.

[ovs-dev] [PATCH ovn v4 10/13] ovn.at: e2e test for OVN interconnection.

2020-01-29 Thread Han Zhou
Test with 5 AZs, each with 1 GW, 1 HV, 5 VIFs, 5 LRs, connected to 5 transit switches. Verify traffic through each TS between each pair of AZs. Signed-off-by: Han Zhou --- tests/ovn.at | 147 +++ 1 file changed, 147 insertions(+) diff

[ovs-dev] [PATCH ovn v4 04/13] ovn-ic: Interconnection controller with AZ registeration.

2020-01-29 Thread Han Zhou
This patch introduces interconnection controller, ovn-ic, and implements the basic AZ registration feature: taking the AZ name from NB DB and create an Availability_Zone entry in IC-SB DB. Signed-off-by: Han Zhou --- Makefile.am | 1 + ic/.gitignore| 2 + ic/automake.mk

[ovs-dev] [PATCH ovn v4 00/13] OVN Interconnection

2020-01-29 Thread Han Zhou
The series supports interconnecting multiple OVN deployments (e.g. located at multiple data centers) through logical routers connected with tansit logical switches with overlay tunnels, managed through OVN control plane. See the ovn-architecture.rst document updates for more details, and find

[ovs-dev] [PATCH ovn v4 01/13] ovn-architecture: Add documentation for OVN interconnection feature.

2020-01-29 Thread Han Zhou
Signed-off-by: Han Zhou --- ovn-architecture.7.xml | 144 - 1 file changed, 143 insertions(+), 1 deletion(-) diff --git a/ovn-architecture.7.xml b/ovn-architecture.7.xml index c43f16d..defcdc9 100644 --- a/ovn-architecture.7.xml +++

[ovs-dev] [PATCH ovn v4 02/13] ovn-ic-nb: Interconnection northbound DB schema and CLI.

2020-01-29 Thread Han Zhou
This patch introduces OVN_IC_Northbound DB schema and the CLI ovn-ic-nbctl that manages the DB. Signed-off-by: Han Zhou --- .gitignore | 3 + automake.mk | 35 ++ debian/ovn-common.install| 1 + debian/ovn-common.manpages | 2 + lib/.gitignore

[ovs-dev] [PATCH ovn v4 05/13] ovn-northd.c: Refactor allocate_tnlid.

2020-01-29 Thread Han Zhou
Move allocate_tnlid() and related interfaces to ovn_util module, so that they be reused by ovn-ic (in next patches). At the same time, define macros for the range of datapath tunnel keys, and reserve a range with ((1u << 16) - 1) keys for global transit switch datapaths, among the ((1u << 24) - 1)

[ovs-dev] [PATCH ovn v4 06/13] ovn-ic: Transit switch controller.

2020-01-29 Thread Han Zhou
Processing transit switches and sync between IC-NB, IC-SB and NB. Signed-off-by: Han Zhou --- ic/ovn-ic.c | 107 lib/ovn-util.c | 6 +-- lib/ovn-util.h | 1 + northd/ovn-northd.c | 70 --

Re: [ovs-dev] [PATCH ovn v3 00/13] OVN Interconnection

2020-01-29 Thread Numan Siddique
On Tue, Jan 28, 2020 at 8:26 AM Han Zhou wrote: > > The series supports interconnecting multiple OVN deployments (e.g. located at > multiple data centers) through logical routers connected with tansit logical > switches with overlay tunnels, managed through OVN control plane. See the >

Re: [ovs-dev] [PATCH v4 0/3] Add support for TSO with DPDK

2020-01-29 Thread William Tu
On Wed, Jan 29, 2020 at 3:25 AM Flavio Leitner wrote: > > On Tue, Jan 28, 2020 at 03:23:02PM -0800, Yifeng Sun wrote: > > Sure. > > > > Firstly, make sure userspace-tso-enable is true > > # ovs-vsctl get Open_vSwitch . other_config > > {dpdk-init="true", enable-statistics="true",

Re: [ovs-dev] [PATCHv2] docs: Add header install command for afxdp.

2020-01-29 Thread William Tu
On Thu, Jan 23, 2020 at 09:03:11AM -0800, William Tu wrote: > The 'XDP_RING_NEED_WAKEUP' and related flags are defined if_xdp.h, so if > users are building their own kernel, users have to update the kernel's > header files, by doing: > > $ make headers_install INSTALL_HDR_PATH=/usr > >

Re: [ovs-dev] [PATCH] conntrack: Fix conntrack new state

2020-01-29 Thread William Tu
On Fri, Dec 20, 2019 at 01:16:39PM -0800, Ben Pfaff wrote: > On Fri, Dec 20, 2019 at 09:51:08AM -0800, Yi-Hung Wei wrote: > > In connection tracking system, a connection is established if we > > see packets from both directions. However, in userspace datapath's > > conntrack, if we send a

Re: [ovs-dev] [PATCH] kbuild: Include external modules compile flags

2020-01-29 Thread Gregory Rose
On 1/28/2020 7:37 AM, Gregory Rose wrote: On 1/27/2020 7:35 PM, Masahiro Yamada wrote: On Tue, Jan 28, 2020 at 6:50 AM Greg Rose wrote: Since this commit: 'commit 9b9a3f20cbe0 ("kbuild: split final module linking out into Makefile.modfinal")' at least one out-of-tree external kernel module

[ovs-dev] Is this d...@openvswitch.org still active?

2020-01-29 Thread Nelson Corey
I have tried to email this your d...@openvswitch.org account severally but I got no response, Please get back to me at your earliest convenience if you receive this email. Sincerely, Nelson Corey ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH v4 0/3] Add support for TSO with DPDK

2020-01-29 Thread Yifeng Sun
Hi Ilya, The whole output of 'ethtool -k ens6' is here: $ ethtool -k ens6 Features for ens6: rx-checksumming: on [fixed] tx-checksumming: on tx-checksum-ipv4: off [fixed] tx-checksum-ip-generic: on tx-checksum-ipv6: off [fixed] tx-checksum-fcoe-crc: off [fixed]

Re: [ovs-dev] [PATCH v4 0/3] Add support for TSO with DPDK

2020-01-29 Thread Yifeng Sun
Hi Flavio, Sorry in my last email, one change is incorrect. it should be: in tcp_v4_rcv() - if (skb_checksum_init(skb, IPPROTO_TCP, inet_compute_pseudo)) + if (0) The kernel version I am using is ubuntu 18.04's default kernel: $ uname -r 4.15.0-76-generic Thanks, Yifeng On Wed, Jan

[ovs-dev] Drink (2 a day) to end obesity

2020-01-29 Thread Ketosis via dev
Hi d...@openvswitch.org!! Can't Load Image? CLICK HERE

Re: [ovs-dev] [PATCH ovn v2] ovn-northd: Consider load balancer active backends in router pipeline

2020-01-29 Thread Numan Siddique
On Wed, Jan 29, 2020 at 7:05 PM Dumitru Ceara wrote: > > On 1/27/20 2:06 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > The commit [1] which added lood balancer health check support > > missed out on updating the logical flows to consider only > > active backends in the logical

Re: [ovs-dev] [PATCH ovn v2] ovn-northd: Consider load balancer active backends in router pipeline

2020-01-29 Thread Dumitru Ceara
On 1/27/20 2:06 PM, num...@ovn.org wrote: > From: Numan Siddique > > The commit [1] which added lood balancer health check support > missed out on updating the logical flows to consider only > active backends in the logical router pipeline if a load balancer > is associated. This patch fixes it.

Re: [ovs-dev] [PATCH ovn 2/2] ovn-northd: Support hairpinning for logical switch load balancing.

2020-01-29 Thread Dumitru Ceara
On 1/20/20 2:25 PM, Numan Siddique wrote: > On Thu, Jan 16, 2020 at 9:08 PM Dumitru Ceara wrote: >> >> In case a VIF is trying to connect to a load balancer VIP that includes in >> its backends the VIF itself, traffic would get DNAT-ed, ct_lb(VIP), but >> when it reaches the VIF, the VIF will try

[ovs-dev] [PATCH ovn v2] ovn-northd: Support hairpinning for logical switch load balancing.

2020-01-29 Thread Dumitru Ceara
In case a VIF is trying to connect to a load balancer VIP that includes in its backends the VIF itself, traffic would get DNAT-ed, ct_lb(VIP), but when it reaches the VIF, the VIF will try to reply locally as the source IP is known to be local. For this kind of hairpinning to work properly, reply

Re: [ovs-dev] [PATCH v3 ovn 0/2] Add MLD support.

2020-01-29 Thread Dumitru Ceara
On 1/29/20 1:28 PM, Numan Siddique wrote: > On Wed, Jan 29, 2020 at 2:59 PM Dumitru Ceara wrote: >> >> The first patch of the series is a minor fix of how IP multicast traffic >> is matched. >> >> The second patch extends the already existing IPv4 Multicast support >> (IGMP snooping, IGMP

Re: [ovs-dev] [PATCH v3 ovn 0/2] Add MLD support.

2020-01-29 Thread Numan Siddique
On Wed, Jan 29, 2020 at 2:59 PM Dumitru Ceara wrote: > > The first patch of the series is a minor fix of how IP multicast traffic > is matched. > > The second patch extends the already existing IPv4 Multicast support > (IGMP snooping, IGMP querier, relay and static flood config) to IPv6 > by

Re: [ovs-dev] [PATCH v4 0/3] Add support for TSO with DPDK

2020-01-29 Thread Ilya Maximets
On 29.01.2020 12:25, Flavio Leitner wrote: > On Tue, Jan 28, 2020 at 03:23:02PM -0800, Yifeng Sun wrote: >> Sure. >> >> Firstly, make sure userspace-tso-enable is true >> # ovs-vsctl get Open_vSwitch . other_config >> {dpdk-init="true", enable-statistics="true", pmd-cpu-mask="0xf", >>

Re: [ovs-dev] [PATCH v4 0/3] Add support for TSO with DPDK

2020-01-29 Thread Flavio Leitner
On Tue, Jan 28, 2020 at 03:23:02PM -0800, Yifeng Sun wrote: > Sure. > > Firstly, make sure userspace-tso-enable is true > # ovs-vsctl get Open_vSwitch . other_config > {dpdk-init="true", enable-statistics="true", pmd-cpu-mask="0xf", > userspace-tso-enable="true"} > > Next, create 2 VMs with

[ovs-dev] RE

2020-01-29 Thread CHERYL ANN
hello, did you get my last mail? ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] Earn $13,000 in literally 24 hours

2020-01-29 Thread Bitcoin Code via dev

[ovs-dev] [PATCH v3 ovn 2/2] ovn: Add MLD support.

2020-01-29 Thread Dumitru Ceara
Extend the existing infrastructure used for IPv4 multicast to IPv6 multicast: - snoop MLDv1 & MLDv2 reports. - if multicast querier is configured, generate MLDv2 queries. - support IPv6 multicast relay. - support static flood configuration for IPv6 multicast too. Acked-by: Mark Michelson

[ovs-dev] [PATCH v3 ovn 1/2] ovn-northd: Fix ipv4.mcast logical field.

2020-01-29 Thread Dumitru Ceara
Acked-by: Mark Michelson Signed-off-by: Dumitru Ceara --- lib/logical-fields.c |3 ++- northd/ovn-northd.c |2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/logical-fields.c b/lib/logical-fields.c index 8fb591c..5748b67 100644 --- a/lib/logical-fields.c +++

[ovs-dev] [PATCH v3 ovn 0/2] Add MLD support.

2020-01-29 Thread Dumitru Ceara
The first patch of the series is a minor fix of how IP multicast traffic is matched. The second patch extends the already existing IPv4 Multicast support (IGMP snooping, IGMP querier, relay and static flood config) to IPv6 by implementing MLDv1 & MLDv2 snooping and querier. Signed-off-by:

Re: [ovs-dev] [PATCH 1/1] flow: Fix parsing l3_ofs with partial offloading

2020-01-29 Thread Eli Britstein
ping On 1/14/2020 3:21 PM, Eli Britstein wrote: > l3_ofs should be set all Ethernet packets, not just IPv4/IPv6 ones. > For example for ARP over VLAN tagged packets, it may cause wrong > processing like in changing the VLAN ID action. Fix it. > > Fixes: aab96ec4d81e ("dpif-netdev: retrieve flow