Re: [ovs-dev] [ovs-dev v2 2/2] ofproto-dpif: fix meter use-after-free

2022-04-30 Thread 0-day Robot
Bleep bloop. Greetings Peng He, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Peng He needs to sign off. WARNING: Unexpected sign-offs from developers who are not

Re: [ovs-dev] [ovs-dev v2 1/2] ovs-rcu: add rcu_barrier

2022-04-30 Thread 0-day Robot
Bleep bloop. Greetings Peng He, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Peng He needs to sign off. ERROR: Co-author Eelco Chaudron needs to sign off.

[ovs-dev] [ovs-dev v2 2/2] ofproto-dpif: fix meter use-after-free

2022-04-30 Thread Peng He
add a rcu_barrier before close_dpif_backer to ensure that all meters has been freed before id_pool_destory meter's id-pool. Signed-off-by: Peng He Tested-by: David Marchand --- ofproto/ofproto-dpif.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ofproto/ofproto-dpif.c

[ovs-dev] [ovs-dev v2 1/2] ovs-rcu: add rcu_barrier

2022-04-30 Thread Peng He
rcu_barrier will block the current thread until all the postponed rcu job has been finished. it's like the OVS's version of the kernel rcu_barrier() Signed-off-by: Peng He Co-authored-by: Eelco Chaudron --- lib/ovs-rcu.c | 28 lib/ovs-rcu.h | 4 2 files

Re: [ovs-dev] [PATCH] python: Raise AttributeError from uuid_to_row

2022-04-30 Thread Terry Wilson
On Sat, Apr 30, 2022 at 3:10 PM Terry Wilson wrote: > > Prior to 4e3966e64, when calling _uuid_to_row, it would raise an > AttributeError when trying to access base.ref_table.rows if the > referenced table was not registered. When called from > Row.__getattr__(), this would appropriately raise an

[ovs-dev] [PATCH] python: Raise AttributeError from uuid_to_row

2022-04-30 Thread Terry Wilson
Prior to 4e3966e64, when calling _uuid_to_row, it would raise an AttributeError when trying to access base.ref_table.rows if the referenced table was not registered. When called from Row.__getattr__(), this would appropriately raise an AttributeError. After 4e3966e64, a KeyError would be raised,