Fixes fa8c591fa2a7("Support LSP:options:requested-chassis as a list")
Signed-off-by: Ihar Hrachyshka
---
controller/binding.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/controller/binding.c b/controller/binding.c
index 8a8570f13..2279570f9 100644
---
On Wed, Jun 1, 2022 at 1:26 PM Terry Wilson wrote:
>
> Since pids can be re-used, it is necessary to check that the
> process that is running with a pid matches the one that we expect.
>
> This adds the ability to optionally pass a 'binary' argument to
> pidfile_is_running, and if it is passed to
On Wed, Jun 1, 2022 at 11:44 AM Mark Michelson wrote:
>
> On 6/1/22 13:44, Numan Siddique wrote:
> > On Wed, Jun 1, 2022 at 12:52 PM Mark Michelson
wrote:
> >>
> >> Thanks Dumitru. This looks good to me.
> >>
> >> Acked-by: Mark Michelson
> >
> > Thanks Dumitru.
> > I applied this patch to main
This is the remaining piece in multi-chassis series. This new version
has no flow modification done in pinctrl thread. Instead, I-P engine
is notified of any newly activated ports, which then triggers pflow
update for lports.
Ihar
On Wed, Jun 1, 2022 at 6:57 PM Ihar Hrachyshka wrote:
>
> When
When options:activation-strategy is set to "rarp" for LSP, when used in
combination with multiple chassis names listed in
options:requested-chassis, additional chassis will install special flows
that would block all ingress and egress traffic for the port until a
special activation event happens.
On 5/31/2022 12:22 PM, Frode Nordahl wrote:
On Tue, May 31, 2022 at 7:05 PM Ilya Maximets wrote:
On 5/31/22 17:36, Gregory Rose wrote:
On 5/25/2022 6:47 AM, Flavio Leitner wrote:
Hi Greg,
On Mon, May 23, 2022 at 09:10:36PM +0200, Ilya Maximets wrote:
On 5/19/22 20:04, Gregory Rose
I merged patches 1-3 to main and branch-22.06.
I will give patch 4 a look tomorrow.
On 5/31/22 16:30, Ihar Hrachyshka wrote:
Another respin. Still the RARP activation strategy patch has pending
questions to resolve. The rest are ready to merge.
RARP activation strategy patch limitations,
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch' to see the
> On Thu, May 19, 2022 at 2:23 PM Lorenzo Bianconi
> wrote:
> >
> > Add the capability to automatically deploy a load-balancer on each
> > logical-switch connected to a logical router where the load-balancer
> > has been installed by the CMS. This patch allow to overcome the
> > distributed gw
Add the capability to automatically deploy a load-balancer on each
logical-switch connected to a logical router where the load-balancer
has been installed by the CMS. This patch allow to overcome the
distributed gw router scenario limitation where a load-balancer must be
installed on each datapath
On Wed, Jun 1, 2022 at 1:30 PM 0-day Robot wrote:
> checkpatch:
> WARNING: Line is 124 characters long (recommended limit is 79)
> #44 FILE: utilities/ovn-ctl:52:
> test -e "$pidfile" && [ -s "$pidfile" ] && pid=`cat "$pidfile"` &&
> pid_exists "$pid" && pid_exe_matches "$pid" "$binary"
>
>
On 6/1/22 13:44, Numan Siddique wrote:
On Wed, Jun 1, 2022 at 12:52 PM Mark Michelson wrote:
Thanks Dumitru. This looks good to me.
Acked-by: Mark Michelson
Thanks Dumitru.
I applied this patch to main and branch-22.06.
Looks like it's not applying cleanly to branch-22.03.
Numan
I
Bleep bloop. Greetings Terry Wilson, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 124 characters long (recommended limit is 79)
#44 FILE: utilities/ovn-ctl:52:
On Wed, Jun 1, 2022 at 12:52 PM Mark Michelson wrote:
>
> Thanks Dumitru. This looks good to me.
>
> Acked-by: Mark Michelson
Thanks Dumitru.
I applied this patch to main and branch-22.06.
Looks like it's not applying cleanly to branch-22.03.
Numan
>
> On 6/1/22 10:36, Dumitru Ceara wrote:
-Original Message-
From: William Tu
Sent: Wednesday, June 1, 2022 2:13 AM
To: Ilya Maximets
Cc: ; Alin Gabriel Serdean
Subject: Re: [ovs-dev] [PATCH] datapath-windows: Detect CT timeout.
On Tue, May 31, 2022 at 12:09 PM Ilya Maximets wrote:
>
> On 5/31/22 20:29, William Tu wrote:
>
Since pids can be re-used, it is necessary to check that the
process that is running with a pid matches the one that we expect.
This adds the ability to optionally pass a 'binary' argument to
pidfile_is_running, and if it is passed to match the binary against
/proc/$pid/exe.
Signed-off-by: Terry
When checking if ovsdb-server is running, ensure that the binary
we are going to run matches the one actually running with the the
pid that was in our pidfile.
Signed-off-by: Terry Wilson
---
utilities/ovn-ctl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utilities/ovn-ctl
We ran into an issue in a container environment where the pid files
are on a mount in the host system and not cleaned up. In this case,
due to reuse of pids and ovn-ctl using exec(), the pid of ovn-ctl
itself was in the ovnnb_db.pid file. So ovn-ctl would fail to start
ovsdb-server.
This adds the
Provide options to enforce NAT-T UDP encapsulation. Options are
encapsulation=true for libreswan and forceencaps=true for strongswan.
This may be required in environments where firewalls drop ESP
traffic but where NAT-T detection fails because packets are not
subject to NAT.
Signed-off-by:
Provide an option to enforce NAT-T UDP
encapsulation (encapsulation=true or forceencaps=true depending on the
chosen backend). This may be required in environments where firewalls
drop ESP traffic but where NAT-T detection fails because packets are not
subject to NAT.
Signed-off-by: Andreas Karis
Thanks Dumitru. This looks good to me.
Acked-by: Mark Michelson
On 6/1/22 10:36, Dumitru Ceara wrote:
Commit a075230e4a0f ("Use ct_mark for masked access to make flows
HW-offloading friendly.") started using the ct_lb_mark action instead of
ct_lb. In usual scenarios this new feature would be
The handler and CPU mapping in upcalls are incorrect, and this is
specially noticeable systems with cpu isolation enabled.
Say we have a 12 core system where only every even number CPU is enabled
C0, C2, C4, C6, C8, C10
This means we will create an array of size 6 that will be sent to
kernel
Additional threads are required to service upcalls when we have CPU
isolation (in per-cpu dispatch mode). The formula used to calculate
the number of handler threads to create is as follows
handlers_n = min(next_prime(active_cores+1), total_cores)
Where next_prime is a function that returns the
Splitting them allows them to be reused separately. This
is useful for setting some things in ovsdb before vswitchd is
started or DPDK is initialized.
Signed-off-by: Kevin Traynor
---
tests/system-dpdk-macros.at | 27 ---
1 file changed, 20 insertions(+), 7 deletions(-)
Test that user configured mempool params have been stored.
Signed-off-by: Kevin Traynor
---
tests/system-dpdk.at | 34 ++
1 file changed, 34 insertions(+)
diff --git a/tests/system-dpdk.at b/tests/system-dpdk.at
index 7d2715c4a..35c6bd54b 100644
---
This patchset optimizes for two cases when using shared mempools.
If there are ports with different MTUs, that usually leads
to multiple shared mempools being created because mempool
mbuf size and hence creation is based from MTU.
In fact, a port with a smaller MTU could share a mempool with
Mempools may currently be shared between DPDK ports based
on port MTU and NUMA. With some hint from the user we can
increase the sharing on MTU and hence reduce memory
consumption in many cases.
For example, a port with MTU 9000, uses a mempool with an
mbuf size based on 9000 MTU. A port with MTU
On 6/1/22 17:11, Numan Siddique wrote:
On Wed, May 11, 2022 at 2:45 PM Mark Michelson wrote:
On 5/10/22 12:27, Adrian Moreno wrote:
[...]
Some good alternatives to using the lflow UUID as a datapath
identifier would be
* The value of the OXM_METADATA register.
* The southbound
Bleep bloop. Greetings Andreas Karis, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 82 characters long (recommended limit is 79)
#67 FILE:
On 24/05/2022 12:14, David Marchand wrote:
On Thu, May 12, 2022 at 5:29 PM Kevin Traynor wrote:
Nit: title prefix should be "netdev-dpdk:"
Ah, good one, fixed in v4.
Shared memory mempools may be currently be shared between DPDK
There is a lot of "shared" and "memory" in this line
On Wed, Jun 1, 2022 at 11:39 AM Andreas Karis wrote:
>
> Provide an option to enforce NAT-T UDP
> encapsulation (encapsulation=true or forceencaps=true depending on the
> chosen backend). This may be required in environments where firewalls
> drop ESP traffic but where NAT-T detection fails
On Thu, May 19, 2022 at 2:23 PM Lorenzo Bianconi
wrote:
>
> Add the capability to automatically deploy a load-balancer on each
> logical-switch connected to a logical router where the load-balancer
> has been installed by the CMS. This patch allow to overcome the
> distributed gw router scenario
Provide an option to enforce NAT-T UDP
encapsulation (encapsulation=true or forceencaps=true depending on the
chosen backend). This may be required in environments where firewalls
drop ESP traffic but where NAT-T detection fails because packets are not
subject to NAT.
Signed-off-by: Andreas Karis
On Wed, May 11, 2022 at 2:45 PM Mark Michelson wrote:
>
> On 5/10/22 12:27, Adrian Moreno wrote:
> > [...]
> >
> Some good alternatives to using the lflow UUID as a datapath
> identifier would be
>
> * The value of the OXM_METADATA register.
> * The southbound
On 5/24/22 19:49, Dumitru Ceara wrote:
> On 5/24/22 18:56, Han Zhou wrote:
>> On Mon, May 23, 2022 at 12:38 PM Dumitru Ceara wrote:
>>>
>>> This is a series to explicitly backport a075230e4a0f ("Use ct_mark for
>>> masked access to make flows HW-offloading friendly.") and its
>>> dependencies to
Commit a075230e4a0f ("Use ct_mark for masked access to make flows
HW-offloading friendly.") started using the ct_lb_mark action instead of
ct_lb. In usual scenarios this new feature would be picked up when the
next stable release becomes available (i.e., 22.06.0). However, the
commit was also
On Wed, May 25, 2022 at 1:11 PM Kevin Traynor wrote:
>
> Currently mempools for vhost are being assigned before the vhost device
> is added. In some cases this may be just reusing an existing mempool but
> in others it can require creation of a mempool.
>
> For multi-NUMA, the NUMA info of the
The localnet is excluded from MAC learning for scale
reason. However there might be a valid workflow
when yo uwant to enable the learning and benefit
for that for HW offload. Add option called
'localnet_learn_fdb' to LSP, which will enable/disable
the learning. Setting it as disabled by default.
Add helper method for checking if lsp is localnet
to reduce the verbosity and increase readability
a bit.
Reported-at: https://bugzilla.redhat.com/2070529
Signed-off-by: Ales Musil
---
northd/northd.c | 28
1 file changed, 16 insertions(+), 12 deletions(-)
diff
Add new option for LSP called 'localnet_learn_fdb',
which will allow localnet LSP to add entries to FDB
when set to true. The default is false.
Ales Musil (2):
northd.c: Add lsp_is_localnet helper method
northd.c: Add option to enable MAC learning on localnet
northd/northd.c | 38
On 1 Jun 2022, at 12:14, Roi Dayan wrote:
> On 2022-05-16 6:38 PM, Eelco Chaudron wrote:
>> This patch will properly initialize offload, as it requires the
>> setting to be enabled before starting ovs-vswitchd (or do a
>> restart once configured).
>>
>> Signed-off-by: Eelco Chaudron
>>
On 2022-05-16 6:38 PM, Eelco Chaudron wrote:
Signed-off-by: Eelco Chaudron
Acked-by: Mike Pattrick
---
v2:
- Added section in the NEWS document
NEWS |2
tests/system-offloads-traffic.at | 413 ++
2 files changed,
On 2022-05-16 6:37 PM, Eelco Chaudron wrote:
This change implements support for the check_pkt_len
action using the TC police action, which supports MTU
checking.
Signed-off-by: Eelco Chaudron
Acked-by: Mike Pattrick
---
v3:
Was using TCA_CSUM_PARMS instead of TCA_POLICE_TBF.
On 2022-05-16 6:38 PM, Eelco Chaudron wrote:
This patch will properly initialize offload, as it requires the
setting to be enabled before starting ovs-vswitchd (or do a
restart once configured).
Signed-off-by: Eelco Chaudron
Acked-by: Mike Pattrick
---
v2:
- Unified all the
On 2022-05-16 6:37 PM, Eelco Chaudron wrote:
Move handling of the individual actions in the parse_tc_flower_to_match()
function to a separate function that will make recursive action handling
easier.
Signed-off-by: Eelco Chaudron
Acked-by: Mike Pattrick
---
lib/netdev-offload-tc.c | 422
On 2022-05-16 6:37 PM, Eelco Chaudron wrote:
Move handling of the individual actions in the netdev_tc_flow_put()
function to a separate function that will make recursive action handling
easier.
Signed-off-by: Eelco Chaudron
Acked-by: Mike Pattrick
---
lib/netdev-offload-tc.c | 255
"TUNNEL_ID" is a bad name, but that's how dpdk called it.
There was a discussion about having this knowledge in OVS so we can avoid
calling rte_flow_get_restore_info(). How else it is used?
>-Original Message-
>From: Ivan Malov
>Sent: Monday, May 30, 2022 5:16 PM
>To:
- Missing proper handling of the testpmd syntax logging. It changes the used
port according to "transfer", but the log still uses netdev_dpdk_get_port_id().
- The usage of the "proxy" port for rte-flow implies that this proxy port is
attached to OVS, otherwise it is not "started" and creation of
On 1 Jun 2022, at 9:02, Roi Dayan wrote:
> On 2022-05-31 5:34 PM, Eelco Chaudron wrote:
>> When processing netlink messages, we should ignore unknown OVS_KEY_ATTR
>> as we can assume if newer attributes are present, they are backward
>> compatible.
>>
>> This patch also updates the existing
On 2022-05-31 5:34 PM, Eelco Chaudron wrote:
When processing netlink messages, we should ignore unknown OVS_KEY_ATTR
as we can assume if newer attributes are present, they are backward
compatible.
This patch also updates the existing comments to better explain what
happens in the error
50 matches
Mail list logo
