Bleep bloop. Greetings Terry Wilson, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 82 characters long (recommended limit is 79)
#185 FILE:
The only way to configure settings on a remote (e.g. inactivity_probe)
is via --remote=db:DB,table,row. There is no way to do this via the
existing CLI options.
For a clustered DB with multiple servers listening on unique addresses
there is no way to store these entries in the DB as the DB is
On Wed, Jun 15, 2022 at 1:59 PM wrote:
>
> From: Numan Siddique
>
> ovsdb-server already supports specifying the uuid in the insert
> transaction by the client. But the C IDL client library was
> missing this feature. This patch adds this support.
>
> For each schema table, a new function is
Signed-off-by: Ihar Hrachyshka
---
tests/ovn.at | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/ovn.at b/tests/ovn.at
index bfaa41962..a4a696d51 100644
--- a/tests/ovn.at
+++ b/tests/ovn.at
@@ -7432,7 +7432,7 @@ ovs-vsctl -- add-port br-int vif2 -- \
# Allow some
The leak is reported for asan runs.
Signed-off-by: Ihar Hrachyshka
---
utilities/ovn-dbctl.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/utilities/ovn-dbctl.c b/utilities/ovn-dbctl.c
index a292e589d..c4cc8c9b2 100644
--- a/utilities/ovn-dbctl.c
+++ b/utilities/ovn-dbctl.c
@@
Before the patch, for switches with a localnet port,
- traffic to a multichassis port was funneled through tunnels; but
- traffic from a multichassis port was sent through localnet.
This is not optimal because:
- bidirectional sessions are sent through two separate paths;
- leaking multichassis
On Fri, Jun 24, 2022 at 12:41 PM Numan Siddique wrote:
>
> On Fri, Jun 24, 2022 at 11:49 AM Han Zhou wrote:
> >
> > On Fri, Jun 24, 2022 at 1:11 AM Ales Musil wrote:
> > >
> > > Hi Han,
> > >
> > > after our discussion I did he suggested test and the throughput does
not
> > seem to be affected,
On 5/30/22 14:42, Roi Dayan wrote:
>
>
> On 2022-03-22 11:35 AM, Eelco Chaudron wrote:
>> The parse_key_and_mask_to_match() is a function to translate
>> a netlink formatted key/mask to match structure. And should
>> not consider any configuration setting when translating.
>>
>> In addition we
On 6/24/22 16:19, Dumitru Ceara wrote:
> On 6/21/22 13:47, Ilya Maximets wrote:
>> The test doesn't wait for old flows being revalidated before sending
>> the second packet. The packet hits old flows and doesn't increase the
>> new drop counter as a result.
>>
>> Solution is to wait for
On 6/16/22 16:07, Jon Kohler wrote:
>
>
>> On Jun 3, 2022, at 1:00 PM, Ilya Maximets wrote:
>>
>> On 6/3/22 16:47, Jon Kohler wrote:
>>>
>>>
On Jun 2, 2022, at 5:50 PM, Ilya Maximets wrote:
On 6/2/22 23:13, Jon Kohler wrote:
> Any takers? I’m hoping I’ve got the right
On Fri, Jun 24, 2022 at 11:49 AM Han Zhou wrote:
>
> On Fri, Jun 24, 2022 at 1:11 AM Ales Musil wrote:
> >
> > Hi Han,
> >
> > after our discussion I did he suggested test and the throughput does not
> seem to be affected,
> > I did the test with aging set to 2 sec, and during the test period
Bleep bloop. Greetings Kevin Sprague, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
build:
mv tests/ovsdb-cluster-testsuite.tmp tests/ovsdb-cluster-testsuite
\
{ sed -n -e '/%AUTHORS%/q' -e
During normal operations, it is useful to understand when a particular flow
gets removed from the system. This can be useful when debugging performance
issues tied to ofproto flow changes, trying to determine deployed traffic
patterns, or while debugging dynamic systems where ports come and go.
Ilya Maximets writes:
> ofpbuf_reserve() can be called with a zero size for a buffer with
> an unallocated data. It's a valid case, but we should not allow
> evaluation of 'NULL + 0'.
>
> SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior lib/ofpbuf.c:469:30
> in
> lib/ofpbuf.c:469:30:
Ilya Maximets writes:
> SUMMARY: UndefinedBehaviorSanitizer:
>
> lib/odp-util.c:3436:32: runtime error:
> load of misaligned address 0x624000489424 for type 'const ovs_be64'
> (aka 'const unsigned long'), which requires 8 byte alignment
> 0x624000489424:
> note: pointer points
Ilya Maximets writes:
> 'max_port' is 16bit field, shift expands it to 'int', not unsigned int.
>
> lib/conntrack.c:2245:41: runtime error:
>left shift of 34568 by 16 places cannot be represented in type 'int'.
>
> 0 0xec45f4 in nat_range_hash lib/conntrack.c:2245:41
> 1 0xec45f4
Ilya Maximets writes:
> 'max_port' is 16bit field, shift expands it to 'int', not unsigned int.
>
> lib/conntrack.c:2245:41: runtime error:
>left shift of 34568 by 16 places cannot be represented in type 'int'.
>
> 0 0xec45f4 in nat_range_hash lib/conntrack.c:2245:41
> 1 0xec45f4
Ilya Maximets writes:
> On 6/20/22 23:57, Paolo Valerio wrote:
>> Ilya Maximets writes:
>>
>>> On 6/7/22 11:39, Robin Jarry wrote:
Paolo Valerio, Jun 05, 2022 at 19:37:
> Just a note that may be useful.
> After some tests, I noticed that establishing e.g. two TCP connections,
On Fri, Jun 24, 2022 at 1:11 AM Ales Musil wrote:
>
> Hi Han,
>
> after our discussion I did he suggested test and the throughput does not
seem to be affected,
> I did the test with aging set to 2 sec, and during the test period (360
sec) the MAC binding was removed multiple times.
> There were
Hi Mark
Thanks for the suggestion, it makes sense as it makes the test easier to
read.
I'll send a v2
Thanks
Xavier
On Thu, Jun 23, 2022 at 10:39 PM Mark Michelson wrote:
> Hi Xavier,
>
> Thanks a bunch for fixing this. I have a small suggestion below
>
> On 6/22/22 11:02, Xavier Simonart
+Ori
From: Finn, Emma
Sent: Friday, June 24, 2022 5:41 PM
To: Ilya Maximets ; ovs-dev@openvswitch.org
; Stokes, Ian
Cc: Eli Britstein ; Slava Ovsiienko ;
Flavio Leitner ; Matan Azrad
Subject: RE: [ovs-dev] [PATCH] netdev-offload-dpdk: setting RSS hash types
'max_port' is 16bit field, shift expands it to 'int', not unsigned int.
lib/conntrack.c:2245:41: runtime error:
left shift of 34568 by 16 places cannot be represented in type 'int'.
0 0xec45f4 in nat_range_hash lib/conntrack.c:2245:41
1 0xec45f4 in nat_get_unique_tuple
> -Original Message-
> From: dev On Behalf Of Ilya
> Maximets
> Sent: Monday 20 June 2022 19:00
> To: ovs-dev@openvswitch.org; Stokes, Ian
> Cc: Eli Britstein ; viachesl...@nvidia.com; Flavio Leitner
> ; i.maxim...@ovn.org; ma...@nvidia.com
> Subject: Re: [ovs-dev] [PATCH]
On 24 Jun 2022, at 16:18, Ilya Maximets wrote:
> MPLS header is only 2 byte aligned, so the value has to be written
> in parts. Also, even though the 'struct mpls_hdr' has only one
> field, it's cleaner to not access that field directly.
>
> lib/packets.c:432:9: runtime error:
>store to
On 24 Jun 2022, at 15:18, Ilya Maximets wrote:
> Pointers to gnet_stats_basic and tcf_t are not correctly aligned,
> so we need to copy the data before accessing. Found by running
> check-offloads testsuite with UBsan:
>
> lib/tc.c:1791:50: runtime error:
>member access within misaligned
On 6/21/22 13:47, Ilya Maximets wrote:
> The test doesn't wait for old flows being revalidated before sending
> the second packet. The packet hits old flows and doesn't increase the
> new drop counter as a result.
>
> Solution is to wait for revalidators to clean up old flows. This fixes
>
MPLS header is only 2 byte aligned, so the value has to be written
in parts. Also, even though the 'struct mpls_hdr' has only one
field, it's cleaner to not access that field directly.
lib/packets.c:432:9: runtime error:
store to misaligned address 0x61b000756382 for type 'ovs_be32'
(aka
On 6/24/22 15:18, Ilya Maximets wrote:
> Pointers to gnet_stats_basic and tcf_t are not correctly aligned,
> so we need to copy the data before accessing. Found by running
> check-offloads testsuite with UBsan:
>
> lib/tc.c:1791:50: runtime error:
>member access within misaligned address
On 6/24/22 14:55, Ilya Maximets wrote:
> SUMMARY: UndefinedBehaviorSanitizer:
>
> lib/odp-util.c:3436:32: runtime error:
> load of misaligned address 0x624000489424 for type 'const ovs_be64'
> (aka 'const unsigned long'), which requires 8 byte alignment
> 0x624000489424:
> note:
On 6/24/22 14:54, Ilya Maximets wrote:
> ofpbuf_reserve() can be called with a zero size for a buffer with
> an unallocated data. It's a valid case, but we should not allow
> evaluation of 'NULL + 0'.
>
> SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior lib/ofpbuf.c:469:30
> in
>
Pointers to gnet_stats_basic and tcf_t are not correctly aligned,
so we need to copy the data before accessing. Found by running
check-offloads testsuite with UBsan:
lib/tc.c:1791:50: runtime error:
member access within misaligned address 0x6195ce1c for type
'const struct
SUMMARY: UndefinedBehaviorSanitizer:
lib/odp-util.c:3436:32: runtime error:
load of misaligned address 0x624000489424 for type 'const ovs_be64'
(aka 'const unsigned long'), which requires 8 byte alignment 0x624000489424:
note: pointer points here
0c 00 00 00 ff ff ff ff ff
ofpbuf_reserve() can be called with a zero size for a buffer with
an unallocated data. It's a valid case, but we should not allow
evaluation of 'NULL + 0'.
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior lib/ofpbuf.c:469:30 in
lib/ofpbuf.c:469:30: runtime error: applying zero offset to
Match the drop flow for stateless dnat_and_snat flow in S_ROUTER_IN_GW_REDIRECT
stage just if allowed_ext_ips or exempted_ext_ips conditions do not
match since it breaks the hairpin scenario with stateless nat.
Fix the northd documentation.
Fixes: c0224a14f ("northd: fix stateless nat with
From: ldejing
This patch mainly support alg field in ct action when process
ftp/tftp traffic. Tftp with alg mainly parse the tftp packet
(IPv4/IPv6), extract connect info from the tftp packet and
create the related connection. For ftp, previous version has
supported process of ftp traffic.
From: ldejing
When icmp error code send back to sender, currently ovs ct can't create
conntrack for the error code properly, this patch mainly fix the bug.
icmp error code test case:
1) packet too big.
2) network unreachable
3) parameter problem
Signed-off-by: ldejing
---
Test that user configured mempool params have been stored.
Signed-off-by: Kevin Traynor
Reviewed-by: David Marchand
---
tests/system-dpdk.at | 34 ++
1 file changed, 34 insertions(+)
diff --git a/tests/system-dpdk.at b/tests/system-dpdk.at
index
Splitting them allows them to be reused separately. This
is useful for setting some things in ovsdb before vswitchd is
started or DPDK is initialized.
Signed-off-by: Kevin Traynor
Reviewed-by: David Marchand
---
tests/system-dpdk-macros.at | 27 ---
1 file changed, 20
Mempools may currently be shared between DPDK ports based
on port MTU and NUMA. With some hint from the user we can
increase the sharing on MTU and hence reduce memory
consumption in many cases.
For example, a port with MTU 9000, uses a mempool with an
mbuf size based on 9000 MTU. A port with MTU
This patchset optimizes for two cases when using shared mempools.
If there are ports with different MTUs, that usually leads
to multiple shared mempools being created because mempool
mbuf size and hence creation is based from MTU.
In fact, a port with a smaller MTU could share a mempool with
Add a new command, 'ovsdb-server/tlog-set DB:TABLE on|off', which
allows the user to enable/disable transaction logging for specific
databases and tables.
By default, logging is disabled. Once enabled, logs are generated
with level INFO and are also rate limited.
If used with care, this command
On 6/20/22 18:46, Ilya Maximets wrote:
> On 11/16/21 15:34, Dumitru Ceara wrote:
>> Add a new command, 'ovsdb-server/tlog-set DB:TABLE on|off', which
>> allows the user to enable/disable transaction logging for specific
>> databases and tables.
>>
>> By default, logging is disabled. Once enabled,
Do not learn IPv6 routes with link-local nex-thop. This issue occurs
when the lrp connected to the transit switch has no IPv6 addresses and
the internal logical router port has a valid IPv6 one.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2100355
Signed-off-by: Lorenzo Bianconi
---
On 23 Jun 2022, at 17:38, Eelco Chaudron wrote:
> On 14 Jun 2022, at 13:57, Emma Finn wrote:
>
>> This commit adds the AVX512 implementation of the action functionality.
>>
>> Usage:
>> $ ovs-appctl dpif-netdev/action-impl-set avx512
>>
>> Signed-off-by: Emma Finn
>> Acked-by: Harry van
On Thu, Jun 23, 2022 at 10:22 PM Ilya Maximets wrote:
>
> On 4/12/22 13:49, Christophe Fontaine wrote:
> > This config param allows the delivery of broadcast and multicast packets
> > to the secondary interface of non-lacp bonds, equivalent to the option
> > "all_slaves_active" for kernel bonds.
On 14 Jun 2022, at 13:57, Emma Finn wrote:
> This patchset introduces actions infrastructure changes which allows the
> user to choose between different action implementations based on CPU ISA
> by using different commands. The infrastructure also provides a way to
> check the correctness of
Hi Han,
after our discussion I did he suggested test and the throughput does not
seem to be affected,
I did the test with aging set to 2 sec, and during the test period (360
sec) the MAC binding was removed multiple times.
There were some dropped packets, but the traffic was maintained with
On 6/20/22 19:04, Ilya Maximets wrote:
> On 11/30/21 10:47, Dumitru Ceara wrote:
>> Clients might be connected to multiple databases (e.g., ovn-controller
>> is connected to OVN_Southbound and Open_vSwitch databases) and the IDL
>> memory statistics are more useful if they're not aggregated.
>>
>>
Clients might be connected to multiple databases (e.g., ovn-controller
is connected to OVN_Southbound and Open_vSwitch databases) and the IDL
memory statistics are more useful if they're not aggregated.
Signed-off-by: Dumitru Ceara
---
V2:
- Addressed Ilya's comment and swapped database name and
On Fri, Jun 24, 2022 at 9:30 AM David Marchand
wrote:
>
> As described in the bugzilla below, cpu_has_isa code may be compiled
> with some AVX512 instructions in it, because cpu.c is built as part of
> the libopenvswitchavx512.
> This is a problem when this function (supposed to probe for AVX512
As described in the bugzilla below, cpu_has_isa code may be compiled
with some AVX512 instructions in it, because cpu.c is built as part of
the libopenvswitchavx512.
This is a problem when this function (supposed to probe for AVX512
instructions availability) is invoked from generic OVS code, on
51 matches
Mail list logo
