When ovn-controller is restarted, it may need multiple iterations of
main loop before completely download all related data from SB DB,
especially when ovn-monitor-all=false, so after restart, before it sees
the related localnet ports from SB DB, it treats the related patch
ports on the chassis as
Hi Dumitru,
I have a small note below, and with it fixed,
Acked-by: Mark Michelson
On 6/23/22 15:58, Dumitru Ceara wrote:
In large scale scenarios this option hugely reduces the size of the
Southbound database positively affecting end to end performance. In
such scenarios there's no real
Thanks for the update, Lorenzo.
Acked-by: Mark Michelson
On 6/24/22 08:38, Lorenzo Bianconi wrote:
Match the drop flow for stateless dnat_and_snat flow in S_ROUTER_IN_GW_REDIRECT
stage just if allowed_ext_ips or exempted_ext_ips conditions do not
match since it breaks the hairpin scenario
On 6/24/22 09:29, David Marchand wrote:
> As described in the bugzilla below, cpu_has_isa code may be compiled
> with some AVX512 instructions in it, because cpu.c is built as part of
> the libopenvswitchavx512.
> This is a problem when this function (supposed to probe for AVX512
> instructions
Thank you for the backport, Xavier. I pushed the change to branch-21.12.
On 6/27/22 07:28, Xavier Simonart wrote:
On gateway routers egress packets might be both:
- unDNATted
- SNATted
Reply packets should not be SNATted (they must of course be UnDNATted
if DNAT was applied).
Reported-at:
For patches 1 and 2:
Acked-by: Mark Michelson
Given their simplicity and how obviously correct they are, I went ahead
and merged these to main, branch-22.06, branch-22.03, and branch-21.12.
On 6/24/22 18:41, Ihar Hrachyshka wrote:
The leak is reported for asan runs.
Signed-off-by: Ihar
On Mon, Jun 27, 2022 at 11:27 AM Terry Wilson wrote:
>
> On Mon, Jun 27, 2022 at 5:44 AM Dumitru Ceara wrote:
> >
> > For now include the IDL related TODO items as discussed at:
> > https://mail.openvswitch.org/pipermail/ovs-dev/2022-April/393516.html
> >
> > Signed-off-by: Dumitru Ceara
> >
It is common to pass ovn-ctl options via an /etc/sysconfig file.
It would be useful to be able to pass custom --remote options or
additional DBs to listen to via this file. This would give end
users the ability to have more fine-grained control without
having to modify ovn-ctl.
Signed-off-by:
On 6/24/22 22:56, Han Zhou wrote:
> On Fri, Jun 24, 2022 at 12:41 PM Numan Siddique wrote:
>>
>> On Fri, Jun 24, 2022 at 11:49 AM Han Zhou wrote:
>>>
>>> On Fri, Jun 24, 2022 at 1:11 AM Ales Musil wrote:
Hi Han,
after our discussion I did he suggested test and the throughput
On Mon, Jun 27, 2022 at 5:44 AM Dumitru Ceara wrote:
>
> For now include the IDL related TODO items as discussed at:
> https://mail.openvswitch.org/pipermail/ovs-dev/2022-April/393516.html
>
> Signed-off-by: Dumitru Ceara
> ---
> python/TODO.rst| 34 ++
>
The only way to configure settings on a remote (e.g. inactivity_probe)
is via --remote=db:DB,table,row. There is no way to do this via the
existing CLI options.
For a clustered DB with multiple servers listening on unique addresses
there is no way to store these entries in the DB as the DB is
On Mon, 2022-06-27 at 11:32 +0200, Eelco Chaudron wrote:
>
>
> On 21 Jun 2022, at 10:22, Jianbo Liu wrote:
>
> > On Mon, 2022-06-20 at 12:18 +0200, Eelco Chaudron wrote:
> > > On 27 May 2022, at 11:00, Jianbo Liu wrote:
> > >
> > > > OVS meters are created in advance and openflow rules refer
On 2022-06-27 1:13 PM, Tao Liu wrote:
On Mon, Jun 27, 2022 at 11:51:48AM +0300, Roi Dayan wrote:
On 2022-06-27 10:49 AM, Tao Liu wrote:
On Mon, Jun 27, 2022 at 09:40:38AM +0300, Roi Dayan wrote:
On 2022-06-23 12:42 PM, Roi Dayan wrote:
On 2022-06-22 11:56 PM, Marcelo Ricardo Leitner
On 6/24/22 16:00, Dumitru Ceara wrote:
> On 6/24/22 14:54, Ilya Maximets wrote:
>> ofpbuf_reserve() can be called with a zero size for a buffer with
>> an unallocated data. It's a valid case, but we should not allow
>> evaluation of 'NULL + 0'.
>>
>> SUMMARY: UndefinedBehaviorSanitizer:
On 6/24/22 20:49, Aaron Conole wrote:
> Ilya Maximets writes:
>
>> SUMMARY: UndefinedBehaviorSanitizer:
>>
>> lib/odp-util.c:3436:32: runtime error:
>> load of misaligned address 0x624000489424 for type 'const ovs_be64'
>> (aka 'const unsigned long'), which requires 8 byte alignment
On 6/24/22 20:48, Aaron Conole wrote:
> Ilya Maximets writes:
>
>> 'max_port' is 16bit field, shift expands it to 'int', not unsigned int.
>>
>> lib/conntrack.c:2245:41: runtime error:
>>left shift of 34568 by 16 places cannot be represented in type 'int'.
>>
>> 0 0xec45f4 in
On 6/24/22 16:36, Eelco Chaudron wrote:
>
>
> On 24 Jun 2022, at 16:18, Ilya Maximets wrote:
>
>> MPLS header is only 2 byte aligned, so the value has to be written
>> in parts. Also, even though the 'struct mpls_hdr' has only one
>> field, it's cleaner to not access that field directly.
>>
>>
On 6/24/22 16:34, Eelco Chaudron wrote:
>
>
> On 24 Jun 2022, at 15:18, Ilya Maximets wrote:
>
>> Pointers to gnet_stats_basic and tcf_t are not correctly aligned,
>> so we need to copy the data before accessing. Found by running
>> check-offloads testsuite with UBsan:
>>
>> lib/tc.c:1791:50:
Bleep bloop. Greetings Xavier Simonart, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors
or
On 6/27/22 13:25, Ilya Maximets wrote:
> On 6/16/22 08:32, Adrian Moreno wrote:
>> Add more decoders that can be used by KVParser.
>>
>> For IPv4 and IPv6 addresses, create a new class that wraps
>> netaddr.IPAddress.
>> For Ethernet addresses, create a new class that wraps netaddr.EUI.
>> For
On 6/16/22 08:32, Adrian Moreno wrote:
> Add unit tests for OFPFlow class and ip-port range decoder
>
> Acked-by: Eelco Chaudron
> Signed-off-by: Adrian Moreno
> ---
> python/automake.mk| 4 +-
> python/ovs/tests/test_decoders.py | 130
>
On 6/16/22 08:32, Adrian Moreno wrote:
> Create a small helper script and check that flows used in ofp-actions.at
> are parseable.
>
> Signed-off-by: Adrian Moreno
> ---
> tests/automake.mk | 2 ++
> tests/ofp-actions.at | 18 +
> tests/ovs-test-ofparse.py | 42
On gateway routers egress packets might be both:
- unDNATted
- SNATted
Reply packets should not be SNATted (they must of course be UnDNATted
if DNAT was applied).
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2061593
Signed-off-by: Xavier Simonart
Acked-by: Mark Michelson
On 6/16/22 08:32, Adrian Moreno wrote:
> Add more decoders that can be used by KVParser.
>
> For IPv4 and IPv6 addresses, create a new class that wraps
> netaddr.IPAddress.
> For Ethernet addresses, create a new class that wraps netaddr.EUI.
> For Integers, create a new class that performs basic
For now include the IDL related TODO items as discussed at:
https://mail.openvswitch.org/pipermail/ovs-dev/2022-April/393516.html
Signed-off-by: Dumitru Ceara
---
python/TODO.rst| 34 ++
python/automake.mk | 2 ++
2 files changed, 36 insertions(+)
create
The following test cases were sometimes failing, (mainly) for the same reason
i.e. packet lost as being sent before patch ports were installed.
- 2 HVs, 2 LS, switching between multiple localnet ports with same tags
- VLAN transparency, passthru=true, ARP responder disabled
- send gratuitous arp
On Mon, Jun 27, 2022 at 11:51:48AM +0300, Roi Dayan wrote:
>
>
> On 2022-06-27 10:49 AM, Tao Liu wrote:
> > On Mon, Jun 27, 2022 at 09:40:38AM +0300, Roi Dayan wrote:
> > >
> > >
> > > On 2022-06-23 12:42 PM, Roi Dayan wrote:
> > > >
> > > >
> > > > On 2022-06-22 11:56 PM, Marcelo Ricardo
On 27 Jun 2022, at 12:00, Jianbo Liu wrote:
> On Mon, 2022-06-27 at 11:33 +0200, Eelco Chaudron wrote:
>>
>>
>> On 27 Jun 2022, at 11:32, Jianbo Liu wrote:
>>
>>> On Mon, 2022-06-27 at 11:03 +0200, Eelco Chaudron wrote:
On 21 Jun 2022, at 5:29, Jianbo Liu wrote:
> On
On Mon, 2022-06-27 at 11:33 +0200, Eelco Chaudron wrote:
>
>
> On 27 Jun 2022, at 11:32, Jianbo Liu wrote:
>
> > On Mon, 2022-06-27 at 11:03 +0200, Eelco Chaudron wrote:
> > >
> > >
> > > On 21 Jun 2022, at 5:29, Jianbo Liu wrote:
> > >
> > > > On Mon, 2022-06-20 at 12:15 +0200, Eelco
On Mon, 2022-06-27 at 11:17 +0200, Eelco Chaudron wrote:
>
>
> On 21 Jun 2022, at 5:51, Jianbo Liu wrote:
>
> > On Mon, 2022-06-20 at 12:16 +0200, Eelco Chaudron wrote:
> > > On 27 May 2022, at 11:00, Jianbo Liu wrote:
> > >
> > > > As the police actions with indexes of 0x1000-0x1fff
The ip6.src or nd.sll does not have to be always set.
According to rfc4861:
Source Address
Either an address assigned to the interface from
which this message is sent or (if Duplicate Address
Detection is in progress [ADDRCONF]) the
On 16 Jun 2022, at 8:32, Adrian Moreno wrote:
> Create a small helper script and check that flows tested in odp.at are
> parseable.
>
> Signed-off-by: Adrian Moreno
Changes look good.
Acked-by: Eelco Chaudron
___
dev mailing list
On 16 Jun 2022, at 8:32, Adrian Moreno wrote:
> Use pytest to run unit tests as part of the standard testsuite.
>
> Signed-off-by: Adrian Moreno
Changes look good to me.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
On 16 Jun 2022, at 8:32, Adrian Moreno wrote:
> Create a small helper script and check that flows used in ofp-actions.at
> are parseable.
>
> Signed-off-by: Adrian Moreno
> ---
Changes look good to me.
Acked-by: Eelco Chaudron
___
dev mailing
On 27 Jun 2022, at 11:32, Jianbo Liu wrote:
> On Mon, 2022-06-27 at 11:03 +0200, Eelco Chaudron wrote:
>>
>>
>> On 21 Jun 2022, at 5:29, Jianbo Liu wrote:
>>
>>> On Mon, 2022-06-20 at 12:15 +0200, Eelco Chaudron wrote:
On 27 May 2022, at 11:00, Jianbo Liu wrote:
> For
On 21 Jun 2022, at 10:22, Jianbo Liu wrote:
> On Mon, 2022-06-20 at 12:18 +0200, Eelco Chaudron wrote:
>> On 27 May 2022, at 11:00, Jianbo Liu wrote:
>>
>>> OVS meters are created in advance and openflow rules refer to them
>>> by
>>> their unique ID. New tc_police API is used to offload them.
On Mon, 2022-06-27 at 11:03 +0200, Eelco Chaudron wrote:
>
>
> On 21 Jun 2022, at 5:29, Jianbo Liu wrote:
>
> > On Mon, 2022-06-20 at 12:15 +0200, Eelco Chaudron wrote:
> > > On 27 May 2022, at 11:00, Jianbo Liu wrote:
> > >
> > > > For dpif-netlink, meters are mapped by tc to police actions
>
On 21 Jun 2022, at 5:51, Jianbo Liu wrote:
> On Mon, 2022-06-20 at 12:16 +0200, Eelco Chaudron wrote:
>> On 27 May 2022, at 11:00, Jianbo Liu wrote:
>>
>>> As the police actions with indexes of 0x1000-0x1fff are
>>> reserved for meter offload, to provide a clean environment for OVS,
>>>
On 21 Jun 2022, at 5:29, Jianbo Liu wrote:
> On Mon, 2022-06-20 at 12:15 +0200, Eelco Chaudron wrote:
>> On 27 May 2022, at 11:00, Jianbo Liu wrote:
>>
>>> For dpif-netlink, meters are mapped by tc to police actions with
>>> one-to-one relationship. Implement meter offload API to set/get/del
On 2022-06-27 10:49 AM, Tao Liu wrote:
On Mon, Jun 27, 2022 at 09:40:38AM +0300, Roi Dayan wrote:
On 2022-06-23 12:42 PM, Roi Dayan wrote:
On 2022-06-22 11:56 PM, Marcelo Ricardo Leitner wrote:
On Wed, Jun 22, 2022 at 11:10:17AM +0800, Tao Liu wrote:
On Tue, Jun 21, 2022 at 06:49:42AM
On 21 Jun 2022, at 5:09, Jianbo Liu wrote:
> On Mon, 2022-06-20 at 12:14 +0200, Eelco Chaudron wrote:
>> On 27 May 2022, at 11:00, Jianbo Liu wrote:
>>
>>> Add helpers to add, delete and get stats of police action with
>>> the specified index.
>>>
>>> Signed-off-by: Jianbo Liu
>>> ---
>>>
OVN checks whether ovn-installed is already present (in OVS) before updating it.
This might cause ovn-installed related issues in the following case:
- (1) ovn-installed is present
- (2) we claim the interface
- (3) we update ovs, removing ovn-installed and start installing flows
- (4) (next
On 21 Jun 2022, at 4:40, Jianbo Liu wrote:
> On Mon, 2022-06-20 at 12:12 +0200, Eelco Chaudron wrote:
>>
>> On 27 May 2022, at 11:00, Jianbo Liu wrote:
>>
>>> Add API to offload meter to HW, and the corresponding functions to
>>> call
>>> the meter callbacks from all the registered flow API
On 24 Jun 2022, at 21:18, Kevin Sprague wrote:
> During normal operations, it is useful to understand when a particular flow
> gets removed from the system. This can be useful when debugging performance
> issues tied to ofproto flow changes, trying to determine deployed traffic
> patterns, or
On Mon, Jun 27, 2022 at 09:40:38AM +0300, Roi Dayan wrote:
>
>
> On 2022-06-23 12:42 PM, Roi Dayan wrote:
> >
> >
> > On 2022-06-22 11:56 PM, Marcelo Ricardo Leitner wrote:
> > > On Wed, Jun 22, 2022 at 11:10:17AM +0800, Tao Liu wrote:
> > > > On Tue, Jun 21, 2022 at 06:49:42AM -0700, Marcelo
On 2022-06-23 12:42 PM, Roi Dayan wrote:
On 2022-06-22 11:56 PM, Marcelo Ricardo Leitner wrote:
On Wed, Jun 22, 2022 at 11:10:17AM +0800, Tao Liu wrote:
On Tue, Jun 21, 2022 at 06:49:42AM -0700, Marcelo Ricardo Leitner wrote:
Hi,
On Tue, Jun 21, 2022 at 02:10:39PM +0800, Tao Liu wrote:
46 matches
Mail list logo
