The ip6.src or nd.sll does not have to be always set.
According to rfc4861:
Source Address
Either an address assigned to the interface from
which this message is sent or (if Duplicate Address
Detection is in progress [ADDRCONF]) the
This is continuation after discussion during review on
80187a803 (ovn-northd: Add flow to use eth.src if nd.tll is 0
in put_nd() action.)
Signed-off-by: Ales Musil
---
tests/ovn-northd.at | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/ovn-northd.at b/tests/ovn-northd.at
index
On Tue, Jun 28, 2022 at 4:41 PM Dumitru Ceara wrote:
> On 6/27/22 11:56, Ales Musil wrote:
> > The ip6.src or nd.sll does not have to be always set.
> > According to rfc4861:
> >
> > Source Address
> > Either an address assigned to the interface from
> >
Bleep bloop. Greetings Frode Nordahl, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Co-author Luca Boccassi needs to sign off.
Lines checked: 3737, Warnings: 0, Errors:
The packaging source in the OVS repository has drifted away from
what is currently in Debian and Ubuntu. This state is problematic
because from time to time someone tries to build packages from the
upstream OVS debian package source and then expect that package to
work with up-/down-grades
Signed-off-by: Frode Nordahl
---
debian/rules | 26 ++
1 file changed, 18 insertions(+), 8 deletions(-)
diff --git a/debian/rules b/debian/rules
index b9454fa79..62c4fff28 100755
--- a/debian/rules
+++ b/debian/rules
@@ -95,16 +95,26 @@ override_dh_install:
mv
Use a separate GitHub Actions job for deb test so that we can
control base image for package test.
The CI deb package test code currently attempts to use `apt` to
install local packages. That may not produce the expected result.
Explicitly install the local packages with `dpkg` after installing
Signed-off-by: Frode Nordahl
---
utilities/checkpatch.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
index 8c02ac3ce..de2420e1f 100755
--- a/utilities/checkpatch.py
+++ b/utilities/checkpatch.py
@@ -194,12 +194,12 @@
Allow caller of setup.py to pass in libopenvswitch.a as an object
for linking through the use of LDFLAGS environment variable when
not building a shared openvswitch library.
To accomplish this set the `enable_shared` environment variable to
'no'.
Example:
LDFLAGS=lib/libopenvswitch.a
On Tue, 2022-06-28 at 13:18 +0200, Eelco Chaudron wrote:
>
>
> On 28 Jun 2022, at 10:52, Jianbo Liu wrote:
>
> > On Tue, 2022-06-28 at 09:52 +0200, Eelco Chaudron wrote:
> > >
> > >
> > > On 27 Jun 2022, at 16:58, Jianbo Liu wrote:
> > >
> > > > On Mon, 2022-06-27 at 11:32 +0200, Eelco
On Tue, 2022-06-28 at 13:15 +0200, Eelco Chaudron wrote:
>
>
> On 28 Jun 2022, at 10:28, Jianbo Liu wrote:
>
> > On Tue, 2022-06-28 at 09:53 +0200, Eelco Chaudron wrote:
> > >
> > >
> > > On 27 Jun 2022, at 16:58, Jianbo Liu wrote:
> > >
> > > > On Mon, 2022-06-27 at 11:32 +0200, Eelco
On Tue, Jun 28, 2022 at 8:20 AM Dumitru Ceara wrote:
>
> On 6/28/22 02:49, Han Zhou wrote:
> > When ovn-controller is restarted, it may need multiple iterations of
> > main loop before completely download all related data from SB DB,
> > especially when ovn-monitor-all=false, so after restart,
On 6/27/22 17:27, Terry Wilson wrote:
> On Mon, Jun 27, 2022 at 5:44 AM Dumitru Ceara wrote:
>>
>> For now include the IDL related TODO items as discussed at:
>> https://mail.openvswitch.org/pipermail/ovs-dev/2022-April/393516.html
>>
>> Signed-off-by: Dumitru Ceara
>> ---
>> python/TODO.rst
On 6/24/22 11:55, Dumitru Ceara wrote:
> Add a new command, 'ovsdb-server/tlog-set DB:TABLE on|off', which
> allows the user to enable/disable transaction logging for specific
> databases and tables.
>
> By default, logging is disabled. Once enabled, logs are generated
> with level INFO and are
On 6/24/22 09:48, Dumitru Ceara wrote:
> Clients might be connected to multiple databases (e.g., ovn-controller
> is connected to OVN_Southbound and Open_vSwitch databases) and the IDL
> memory statistics are more useful if they're not aggregated.
>
> Signed-off-by: Dumitru Ceara
> ---
> V2:
> -
On 6/21/22 17:52, Cian Ferriter wrote:
> __builtin_constant_p is only available in GCC and only versions >= 4.
> Use the same "#if __GNUC__ >= 4" check used in other parts of OVS for
> this builtin.
>
> Signed-off-by: Cian Ferriter
> ---
> lib/dpif-netdev-extract-avx512.c | 4
> 1 file
On 6/20/22 22:08, Mike Pattrick wrote:
> Now ovs-tcpdump will check for an OVS_RUNDIR environment variable and
> if present, use it instead of the default RUNDIR. This is useful when
> used in conjunction with OVS_PAUSE_TEST while running the test suite.
>
> Signed-off-by: Mike Pattrick
>
> --
On 6/9/22 10:17, Eelco Chaudron wrote:
>
>
> On 7 Jun 2022, at 12:36, Harry van Haaren wrote:
>
>> This patch adds the old name "subtable-lookup-prio-get" as an unlisted
>> command,
>> to restore a consistency between OVS releases for testing scripts.
>>
>> Fixes 738c76a503f4 ("dpcls: Change
On 6/17/22 18:19, Mike Pattrick wrote:
> On Mon, Jun 6, 2022 at 7:07 AM Yunjian Wang via dev
> wrote:
>>
>> Found by Coverity.
>>
>> Fixes: 1b1d2e6daa56 ("ovsdb: Introduce experimental support for clustered
>> databases.")
>> Signed-off-by: Yunjian Wang
>
> Looks correct to me!
>
> Acked-by:
On 5/31/22 16:34, Eelco Chaudron wrote:
> When processing netlink messages, we should ignore unknown OVS_KEY_ATTR
> as we can assume if newer attributes are present, they are backward
> compatible.
>
> This patch also updates the existing comments to better explain what
> happens in the error
On 6/8/22 19:14, Paolo Valerio wrote:
> lic121 writes:
>
>> If lldp didn't change, we are not supposed to trigger backer
>> revalidation.
>> Without this patch, bridge_reconfigure() always trigger udpif
>> revalidator because of lldp.
>>
>> Signed-off-by: lic121
>> Signed-off-by: Eelco Chaudron
On 6/8/22 19:14, Paolo Valerio wrote:
> lic121 writes:
>
>> lldp_create() malloc memory for lldp->lldpd->g_hardware. lldp_unref
>> is supposed to free the memory regardless of hw->h_flags.
>>
>> Signed-off-by: lic121
>> Acked-by: Eelco Chaudron
>> ---
>> lib/lldp/lldpd.c | 10 +++---
>> 1
On 5/9/22 11:45, Eelco Chaudron wrote:
>
>
> On 30 Apr 2022, at 6:47, lic121 wrote:
>
>> ipfix cfg creation/deleting triggers revalidation. But this does
>> not cover the case where ipfix options changes, which also suppose
>> to trigger revalidation.
>>
>> Fixes: a9f5ee1199e1 ("ofproto-dpif:
On 27/06/2022 05:21, Anurag Agarwal wrote:
Hello Kevin,
-Original Message-
From: Kevin Traynor
Sent: Thursday, June 23, 2022 9:07 PM
To: Anurag Agarwal ; ovs-dev@openvswitch.org
Cc: lic...@chinatelecom.cn
Subject: Re: [ovs-dev] [PATCH v5] dpif-netdev: Allow cross-NUMA polling on
On 6/28/22 16:54, Terry Wilson wrote:
> The only way to configure settings on a remote (e.g. inactivity_probe)
> is via --remote=db:DB,table,row. There is no way to do this via the
> existing CLI options.
>
> For a clustered DB with multiple servers listening on unique addresses
> there is no way
On Tue, Jun 28, 2022 at 4:39 AM Dumitru Ceara wrote:
>
> On 6/27/22 18:00, Terry Wilson wrote:
> > It is common to pass ovn-ctl options via an /etc/sysconfig file.
> > It would be useful to be able to pass custom --remote options or
> > additional DBs to listen to via this file. This would give
On 6/28/22 02:49, Han Zhou wrote:
> When ovn-controller is restarted, it may need multiple iterations of
> main loop before completely download all related data from SB DB,
> especially when ovn-monitor-all=false, so after restart, before it sees
> the related localnet ports from SB DB, it treats
> -Original Message-
> From: Stokes, Ian
> Sent: Tuesday 28 June 2022 15:46
> To: Phelan, Michael ; d...@openvswitch.org
> Cc: acon...@redhat.com; i.maxim...@ovn.org; maxime.coque...@redhat.com
> Subject: RE: [PATCH] tests: Add OVS-DPDK QoS unit tests
>
>
>
> > -Original
> -Original Message-
> From: Stokes, Ian
> Sent: Tuesday 28 June 2022 15:09
> To: Phelan, Michael ; d...@openvswitch.org
> Cc: acon...@redhat.com; i.maxim...@ovn.org; maxime.coque...@redhat.com
> Subject: RE: [PATCH] tests: Add OVS-DPDK MTU unit tests.
>
>
>
> > -Original
The only way to configure settings on a remote (e.g. inactivity_probe)
is via --remote=db:DB,table,row. There is no way to do this via the
existing CLI options.
For a clustered DB with multiple servers listening on unique addresses
there is no way to store these entries in the DB as the DB is
> -Original Message-
> From: Phelan, Michael
> Sent: Tuesday, June 21, 2022 11:19 AM
> To: d...@openvswitch.org
> Cc: Stokes, Ian ; acon...@redhat.com;
> i.maxim...@ovn.org; maxime.coque...@redhat.com; Phelan, Michael
>
> Subject: [PATCH] tests: Add OVS-DPDK QoS unit tests
>
> This
> -Original Message-
> From: Stokes, Ian
> Sent: Tuesday 28 June 2022 14:43
> To: Phelan, Michael ; d...@openvswitch.org
> Cc: acon...@redhat.com; i.maxim...@ovn.org;
> maxime.coque...@redhat.com; david.march...@redhat.com; Ryan, Seamus
>
> Subject: RE: [PATCH v3] tests: Add ovs-dpdk
On 6/27/22 11:56, Ales Musil wrote:
> The ip6.src or nd.sll does not have to be always set.
> According to rfc4861:
>
> Source Address
> Either an address assigned to the interface from
> which this message is sent or (if Duplicate Address
>
On 6/22/22 18:21, Xavier Simonart wrote:
> The test was failing randomly (on highly loaded systems) mainly because
> the MAC address of the migrator port in the main switch was migrating at
> unexpected times.
> In addition, a few undefined variables were fixed, and sleep was removed /
> replaced
> -Original Message-
> From: Phelan, Michael
> Sent: Tuesday, June 21, 2022 11:21 AM
> To: d...@openvswitch.org
> Cc: Stokes, Ian ; acon...@redhat.com;
> i.maxim...@ovn.org; maxime.coque...@redhat.com; Phelan, Michael
>
> Subject: [PATCH] tests: Add OVS-DPDK MTU unit tests.
>
> This
> This adds 4 new unit tests to the 'check-dpdk' subsystem that will
> test rate limiting functionality.
>
> Signed-off-by: Seamus Ryan
> Signed-off-by: Michael Phelan
> Co-authored-by: Michael Phelan
>
> ---
> v3:
> - Removed NEWS entry.
> - Added check to catch error if policer fails to
> -Original Message-
> From: Ilya Maximets
> Sent: Tuesday, June 28, 2022 1:07 AM
> To: David Marchand ; d...@openvswitch.org
> Cc: i.maxim...@ovn.org; amu...@redhat.com; Van Haaren, Harry
> ; Ferriter, Cian ;
> Pai G, Sunil
> Subject: Re: [PATCH] dpif-netdev: Refactor AVX512 runtime
On 6/27/22 10:52, Xavier Simonart wrote:
> OVN checks whether ovn-installed is already present (in OVS) before updating
> it.
> This might cause ovn-installed related issues in the following case:
> - (1) ovn-installed is present
> - (2) we claim the interface
> - (3) we update ovs, removing
On 6/22/22 12:23, Xavier Simonart wrote:
> When VIF ports are claimed on a chassis, SBDB Port_Binding table is updated.
> If the SBDB IDL is still is read-only ("in transaction") when such a update
> is required, the update is not possible and recompute is triggered through
> I+P failure.
>
>
On 28 Jun 2022, at 10:52, Jianbo Liu wrote:
> On Tue, 2022-06-28 at 09:52 +0200, Eelco Chaudron wrote:
>>
>>
>> On 27 Jun 2022, at 16:58, Jianbo Liu wrote:
>>
>>> On Mon, 2022-06-27 at 11:32 +0200, Eelco Chaudron wrote:
On 21 Jun 2022, at 10:22, Jianbo Liu wrote:
> On
On 28 Jun 2022, at 10:28, Jianbo Liu wrote:
> On Tue, 2022-06-28 at 09:53 +0200, Eelco Chaudron wrote:
>>
>>
>> On 27 Jun 2022, at 16:58, Jianbo Liu wrote:
>>
>>> On Mon, 2022-06-27 at 11:32 +0200, Eelco Chaudron wrote:
On 21 Jun 2022, at 10:22, Jianbo Liu wrote:
> On
On 6/3/22 17:31, Rosemarie O'Riorden wrote:
> When OVS sees a tunnel push with a nested list next, it will not
> clone the packet, as a clone is not needed. However, a clone action will
> still be created with the tunnel push encapulated inside. There is no
> need to create the clone action in
On 6/27/22 18:00, Terry Wilson wrote:
> It is common to pass ovn-ctl options via an /etc/sysconfig file.
> It would be useful to be able to pass custom --remote options or
> additional DBs to listen to via this file. This would give end
> users the ability to have more fine-grained control without
On 6/27/22 17:22, Terry Wilson wrote:
> The only way to configure settings on a remote (e.g. inactivity_probe)
> is via --remote=db:DB,table,row. There is no way to do this via the
> existing CLI options.
>
> For a clustered DB with multiple servers listening on unique addresses
> there is no way
The patch adds and re-uses the dpif set command to set the
function pointers to be used to switch between different inner
dpifs.
Signed-off-by: Kumar Amber
Signed-off-by: Cian Ferriter
Co-authored-by: Cian Ferriter
---
v3:
- Add description to the dpif recirc function.
- Fix use of return
This patch adds the necessary changes required to support
tunnel packet types in avx512 dpif.
Signed-off-by: Kumar Amber
Signed-off-by: Cian Ferriter
Co-authored-by: Cian Ferriter
---
v3:
- Apply in_port optimization suggested by Harry.
---
---
lib/dpif-netdev-avx512.c | 25
Create new APIs for the avx512 DPIF, enabling one baseline
common code to be specialized into DPIF implementations for
"outer" processing, and "recirc" processing.
Signed-off-by: Kumar Amber
Signed-off-by: Cian Ferriter
Co-authored-by: Cian Ferriter
---
v3:
- Fix comments from Harry.
---
---
The refactor allows us to use *recirc_depth_get() to obtain
the depth across ovs which was previously limited to only
dpif-netdev.c.
Signed-off-by: Kumar Amber
Signed-off-by: Cian Ferriter
Co-authored-by: Cian Ferriter
Acked-by: Harry van Haaren
---
lib/dpif-netdev-private-dpif.c | 2 ++
The refactor allows us to use hash function accross
multiple files which was earlier restricted to
dpif-netdev.c only.
Signed-off-by: Kumar Amber
Signed-off-by: Cian Ferriter
Co-authored-by: Cian Ferriter
---
v3:
- Fix minor comments from Harry.
---
---
lib/dpif-netdev-private-dpcls.h | 23
The patch adds support for recirculation of packets in AVX512
DPIF which would allow for processing tunneled packets.
---
v3:
* Fix comments from Harry.
V2:
* Split DPIF AVX512 into separate patchset.
---
Kumar Amber (5):
dpif-netdev: Refactor per thread recirc data allocation.
dpif-netdev:
On Tue, 2022-06-28 at 09:52 +0200, Eelco Chaudron wrote:
>
>
> On 27 Jun 2022, at 16:58, Jianbo Liu wrote:
>
> > On Mon, 2022-06-27 at 11:32 +0200, Eelco Chaudron wrote:
> > >
> > >
> > > On 21 Jun 2022, at 10:22, Jianbo Liu wrote:
> > >
> > > > On Mon, 2022-06-20 at 12:18 +0200, Eelco
On Tue, 2022-06-28 at 09:53 +0200, Eelco Chaudron wrote:
>
>
> On 27 Jun 2022, at 16:58, Jianbo Liu wrote:
>
> > On Mon, 2022-06-27 at 11:32 +0200, Eelco Chaudron wrote:
> > >
> > >
> > > On 21 Jun 2022, at 10:22, Jianbo Liu wrote:
> > >
> > > > On Mon, 2022-06-20 at 12:18 +0200, Eelco
On 27 Jun 2022, at 16:58, Jianbo Liu wrote:
> On Mon, 2022-06-27 at 11:32 +0200, Eelco Chaudron wrote:
>>
>>
>> On 21 Jun 2022, at 10:22, Jianbo Liu wrote:
>>
>>> On Mon, 2022-06-20 at 12:18 +0200, Eelco Chaudron wrote:
On 27 May 2022, at 11:00, Jianbo Liu wrote:
> OVS meters are
On 27 Jun 2022, at 16:58, Jianbo Liu wrote:
> On Mon, 2022-06-27 at 11:32 +0200, Eelco Chaudron wrote:
>>
>>
>> On 21 Jun 2022, at 10:22, Jianbo Liu wrote:
>>
>>> On Mon, 2022-06-20 at 12:18 +0200, Eelco Chaudron wrote:
On 27 May 2022, at 11:00, Jianbo Liu wrote:
> OVS meters are
Hi,
so I did the suggested test. Setup was HIV1 - ext0 and vm0, HIV2 ext1 and
vm1
The networks were connected as follow:
- vm0 and vm1 on the same switch
- logical router connected with the "internal" and "external" switch
- "external" switch connected to ext0 and ext1 through localnet
So the
55 matches
Mail list logo
