Re: [ovs-dev] [PATCH v4 ovsdb 1/1] Add ovs-confctl utility for Local_Config db

Bleep bloop. Greetings Terry Wilson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #811 FILE: utilities/ovs-confctl.c:304:

[ovs-dev] [PATCH v4 ovsdb 1/1] Add ovs-confctl utility for Local_Config db

This adds ovs-confctl to configure DBs running the Local_Config schema added in 6f24c2bc7. Signed-off-by: Terry Wilson --- debian/openvswitch-common.install | 1 + debian/openvswitch-common.manpages | 1 + lib/.gitignore | 3 + lib/automake.mk| 8

Re: [ovs-dev] [PATCH v3 ovsdb 1/1] Add ovs-confctl utility for Local_Config db

Bleep bloop. Greetings Terry Wilson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #811 FILE: utilities/ovs-confctl.c:304:

[ovs-dev] [PATCH v3 ovsdb 1/1] Add ovs-confctl utility for Local_Config db

This adds ovs-confctl to configure DBs running the Local_Config schema added in 6f24c2bc7. Signed-off-by: Terry Wilson --- debian/openvswitch-common.install | 1 + debian/openvswitch-common.manpages | 1 + lib/.gitignore | 3 + lib/automake.mk| 8

Re: [ovs-dev] [PATCH v2 ovsdb 1/1] Add ovs-confctl utility for Local_Config db

Bleep bloop. Greetings Terry Wilson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #811 FILE: utilities/ovs-confctl.c:304:

Re: [ovs-dev] [PATCH ovsdb 1/1] Add ovs-confctl utility for Local_Config db

Bleep bloop. Greetings Terry Wilson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #811 FILE: utilities/ovs-confctl.c:304:

[ovs-dev] [PATCH v2 ovsdb 1/1] Add ovs-confctl utility for Local_Config db

This adds ovs-confctl to configure DBs running the Local_Config schema added in 6f24c2bc7. Signed-off-by: Terry Wilson --- debian/openvswitch-common.install | 1 + debian/openvswitch-common.manpages | 1 + lib/.gitignore | 3 + lib/automake.mk| 8

[ovs-dev] [PATCH ovsdb 1/1] Add ovs-confctl utility for Local_Config db

This adds ovs-confctl to configure DBs running the Local_Config schema added in 6f24c2bc7. Signed-off-by: Terry Wilson --- debian/openvswitch-common.install | 1 + debian/openvswitch-common.manpages | 1 + lib/.gitignore | 3 + lib/automake.mk| 8

Re: [ovs-dev] [PATCH v9 07/10] odp-execute: Add ISA implementation of pop_vlan action.

On 7/12/22 19:44, Harry van Haaren wrote: > From: Emma Finn > > This commit adds the AVX512 implementation of the > pop_vlan action. > > Signed-off-by: Emma Finn > --- > lib/automake.mk | 3 +- > lib/odp-execute-avx512.c | 182 ++ >

Re: [ovs-dev] [PATCH v9 06/10] odp-execute: Add ISA implementation of actions.

On 7/12/22 19:44, Harry van Haaren wrote: > From: Emma Finn > > This commit adds the AVX512 implementation of the action functionality. > > Usage: > $ ovs-appctl odp-execute/action-impl-set avx512 > > Signed-off-by: Emma Finn > Acked-by: Harry van Haaren > > --- > > v9: rebase conflict

Re: [ovs-dev] [PATCH v7 0/5] conntrack: Improve multithread scalability.

On 7/11/22 18:54, Paolo Valerio wrote: > This series aims to address the issues present in the previous versions. > The end result is a different approach, using different data structure, > but it solves the multiple issues observed in v4 and the problems that > affected the baseline. > > The

[ovs-dev] [PATCH v5 ovn 2/2] controller: throttle port claim attempts

When multiple chassis are fighting for the same port (requested-chassis is not set, e.g. for gateway ports), they may produce an unreasonable number of chassis field updates in a very short time frame (hundreds of updates in several seconds). This puts unnecessary load on OVN as well as any db

[ovs-dev] [PATCH v5 ovn 1/2] Split out code to handle port binding db updates

This function will later be used to handle port binding updates for postponed (throttled) bindings. Signed-off-by: Ihar Hrachyshka --- controller/binding.c | 250 ++- 1 file changed, 130 insertions(+), 120 deletions(-) diff --git a/controller/binding.c

Re: [ovs-dev] [PATCH V4 0/8] Remove OVS kernel driver

On 7/12/2022 2:02 PM, David Marchand wrote: On Tue, Jul 12, 2022 at 7:58 PM Greg Rose wrote: It is time to remove support for the ovs kernel driver and push towards use of the upstream linux openvswitch kernel driver in it's place [1]. 1.

Re: [ovs-dev] [PATCH V4 7/8] Documentation: Remove kernel module documentation

On 7/12/2022 1:50 PM, David Marchand wrote: On Tue, Jul 12, 2022 at 8:07 PM Gregory Rose wrote: On 7/12/2022 10:56 AM, Greg Rose wrote: As of Open vSwitch release 2.18 the OVS kernel module is no longer supported. Pull the documentation references. Signed-off-by: Greg Rose ---

Re: [ovs-dev] [PATCH V4 6/8] acinclude.m4: Remove support for building the OVS kernel module

On 7/12/2022 1:49 PM, David Marchand wrote: On Tue, Jul 12, 2022 at 7:58 PM Greg Rose wrote: Since the openvswitch project inception it has had support for building a Linux kernel module to support the OVS kernel datapath. Since Linux kernel release 5.8 support for newer kernels has been

Re: [ovs-dev] [PATCH V4 4/8] Make: Remove the Linux datapath

On 7/12/2022 1:35 PM, David Marchand wrote: build-aux/initial-tab-allowed-files is updated in patch 5, so I'd expect a build check failure at this point of the series as mentionned in v3. On 7/12/22 19:56, Greg Rose wrote: diff --git a/Makefile.am b/Makefile.am index cb8076433..eda0d91eb

Re: [ovs-dev] [PATCH V4 3/8] tests: Remove support for check-kmod test

On 7/12/2022 1:27 PM, David Marchand wrote: On Tue, Jul 12, 2022 at 8:01 PM Greg Rose wrote: The OVS kernel module is no longer supported as of OVS 2.18 Signed-off-by: Greg Rose With a '.' at the end of the title: Reviewed-by: David Marchand Will do. - Greg

Re: [ovs-dev] [PATCH V4 2/8] rhel: Remove kernel mode spec

On 7/12/2022 1:26 PM, David Marchand wrote: On Tue, Jul 12, 2022 at 8:03 PM Greg Rose wrote: Remove the kernel driver specification for RHEL 6.x, 7.x, 8.x and Fedora. Signed-off-by: Greg Rose The patch lgtm. I suggest a title like: rhel: Stop packaging OVS kernel module. You can add:

Re: [ovs-dev] [PATCH V4 1/8] Disable unsupported kernel builds

On 7/12/2022 1:12 PM, David Marchand wrote: On Tue, Jul 12, 2022 at 7:58 PM Greg Rose wrote: Remove kernel based github workflows since the OVS kernel driver is no longer supported since Release 2.18 Signed-off-by: Greg Rose Just one last nit on the title. We are still building a part

Re: [ovs-dev] [PATCH v4 ovn 2/2] controller: throttle port claim attempts

FYI there's a memory leak in the patch (I don't free shash_node->data on cleanup), please hold off merging. On Tue, Jul 12, 2022 at 2:37 PM Mark Michelson wrote: > > Acked-by: Mark Michelson > > On 7/12/22 12:51, Ihar Hrachyshka wrote: > > When multiple chassis are fighting for the same port

Re: [ovs-dev] [PATCH 1/14] Rename flags with CKSUM to CSUM

> > Any response to these queries? I’m uncomfortable TBH with this feature > going in to 2.18 unless these are addressed/resolved. From an Intel > perspective we’re more than happy to test and review but there are > genuine issues to be discussed I feel below before merge. > > I tend to agree

Re: [ovs-dev] [PATCH V4 0/8] Remove OVS kernel driver

On Tue, Jul 12, 2022 at 7:58 PM Greg Rose wrote: > > It is time to remove support for the ovs kernel driver and push > towards use of the upstream linux openvswitch kernel driver > in it's place [1]. > > 1. https://mail.openvswitch.org/pipermail/ovs-dev/2022-april/393292.html > > Changes in V2:

Re: [ovs-dev] [PATCH ovn] ci: Use CFLAGS instead of OVS_CFLAGS

Thanks Ales. Acked-by: Mark Michelson On 7/12/22 02:30, Ales Musil wrote: The OVS_CFLAGS variable is for internal use only. Use regular CFLAGS instead. This also has the effect of correctly propagating the flags, when the OVS_CFLAGS variable was used the -O1 was in the overwritten by autoconf

Re: [ovs-dev] [PATCH V4 7/8] Documentation: Remove kernel module documentation

On Tue, Jul 12, 2022 at 8:07 PM Gregory Rose wrote: > On 7/12/2022 10:56 AM, Greg Rose wrote: > > As of Open vSwitch release 2.18 the OVS kernel module is no longer > > supported. Pull the documentation references. > > > > Signed-off-by: Greg Rose > > --- > > Documentation/faq/releases.rst

Re: [ovs-dev] [PATCH V4 6/8] acinclude.m4: Remove support for building the OVS kernel module

On Tue, Jul 12, 2022 at 7:58 PM Greg Rose wrote: > > Since the openvswitch project inception it has had support for building > a Linux kernel module to support the OVS kernel datapath. Since Linux > kernel release 5.8 support for newer kernels has been deprecated. Now > is the time to fully

Re: [ovs-dev] [PATCH V4 4/8] Make: Remove the Linux datapath

build-aux/initial-tab-allowed-files is updated in patch 5, so I'd expect a build check failure at this point of the series as mentionned in v3. On 7/12/22 19:56, Greg Rose wrote: diff --git a/Makefile.am b/Makefile.am index cb8076433..eda0d91eb 100644 --- a/Makefile.am +++ b/Makefile.am @@

Re: [ovs-dev] [PATCH V4 3/8] tests: Remove support for check-kmod test

On Tue, Jul 12, 2022 at 8:01 PM Greg Rose wrote: > > The OVS kernel module is no longer supported as of OVS 2.18 > > Signed-off-by: Greg Rose With a '.' at the end of the title: Reviewed-by: David Marchand -- David Marchand ___ dev mailing list

Re: [ovs-dev] [PATCH V4 2/8] rhel: Remove kernel mode spec

On Tue, Jul 12, 2022 at 8:03 PM Greg Rose wrote: > > Remove the kernel driver specification for RHEL 6.x, 7.x, 8.x and Fedora. > > Signed-off-by: Greg Rose The patch lgtm. I suggest a title like: rhel: Stop packaging OVS kernel module. You can add: Reviewed-by: David Marchand I have some

Re: [ovs-dev] [PATCH V4 1/8] Disable unsupported kernel builds

On Tue, Jul 12, 2022 at 8:25 PM Gregory Rose wrote: > On 7/12/2022 10:56 AM, Greg Rose wrote: > > Remove kernel based github workflows since the OVS kernel driver is > > no longer supported since Release 2.18 > > > > Signed-off-by: Greg Rose > > This patch should actually have David Marchand as

Re: [ovs-dev] [PATCH V4 1/8] Disable unsupported kernel builds

On Tue, Jul 12, 2022 at 7:58 PM Greg Rose wrote: > > Remove kernel based github workflows since the OVS kernel driver is > no longer supported since Release 2.18 > > Signed-off-by: Greg Rose Just one last nit on the title. We are still building a part of a kernel for AF XDP. What do you think

Re: [ovs-dev] [PATCH ovn] ovn-ic: do not learn routes with link-local next-hops

Acked-by: Mark Michelson On 6/24/22 05:41, Lorenzo Bianconi wrote: Do not learn IPv6 routes with link-local nex-thop. This issue occurs when the lrp connected to the transit switch has no IPv6 addresses and the internal logical router port has a valid IPv6 one. Reported-at:

Re: [ovs-dev] [PATCH ovn] tests: fixed flaky test localnet connectivity with multiple requested-chassis

Thanks everyone, I pushed this to main and branch-22.06 On 6/29/22 18:52, Ihar Hrachyshka wrote: Thank you. Acked-by: Ihar Hrachyshka On Wed, Jun 22, 2022 at 12:21 PM Xavier Simonart wrote: The test was failing randomly (on highly loaded systems) mainly because the MAC address of the

Re: [ovs-dev] [PATCH v4 ovn 1/2] Split out code to handle port binding db updates

Acked-by: Mark Michelson On 7/12/22 12:48, Ihar Hrachyshka wrote: This function will later be used to handle port binding updates for postponed (throttled) bindings. Signed-off-by: Ihar Hrachyshka --- controller/binding.c | 250 ++- 1 file changed,

Re: [ovs-dev] [PATCH v4 ovn 2/2] controller: throttle port claim attempts

Acked-by: Mark Michelson On 7/12/22 12:51, Ihar Hrachyshka wrote: When multiple chassis are fighting for the same port (requested-chassis is not set, e.g. for gateway ports), they may produce an unreasonable number of chassis field updates in a very short time frame (hundreds of updates in

Re: [ovs-dev] [PATCH V4 4/8] Make: Remove the Linux datapath

On 7/12/2022 11:25 AM, 0-day Robot wrote: Bleep bloop. Greetings Gregory Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: mv tests/testsuite.tmp tests/testsuite /bin/sh

Re: [ovs-dev] [PATCH V4 8/8] xenserver: Remove xenserver

Bleep bloop. Greetings Gregory Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error,

Re: [ovs-dev] [PATCH V4 7/8] Documentation: Remove kernel module documentation

Bleep bloop. Greetings Gregory Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error,

Re: [ovs-dev] [PATCH V4 6/8] acinclude.m4: Remove support for building the OVS kernel module

Bleep bloop. Greetings Gregory Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error,

Re: [ovs-dev] [PATCH V4 5/8] aux:utilities: Remove references to the Linux datapath

Bleep bloop. Greetings Gregory Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error,

Re: [ovs-dev] [PATCH V4 4/8] Make: Remove the Linux datapath

Bleep bloop. Greetings Gregory Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: mv tests/testsuite.tmp tests/testsuite /bin/sh

Re: [ovs-dev] [PATCH V4 1/8] Disable unsupported kernel builds

On 7/12/2022 10:56 AM, Greg Rose wrote: Remove kernel based github workflows since the OVS kernel driver is no longer supported since Release 2.18 Signed-off-by: Greg Rose This patch should actually have David Marchand as a co-author. I'll fix that up next rev. - Greg ---

Re: [ovs-dev] [PATCH v9 09/10] odp-execute: Add ISA implementation of set_masked ETH

Bleep bloop. Greetings Harry van Haaren, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error,

Re: [ovs-dev] [PATCH v9 10/10] odp-execute: Add ISA implementation of set_masked IPv4 action

Bleep bloop. Greetings Harry van Haaren, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error,

Re: [ovs-dev] [PATCH v9 07/10] odp-execute: Add ISA implementation of pop_vlan action.

Bleep bloop. Greetings Harry van Haaren, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: mv -f $depbase.Tpo $depbase.Plo libtool: compile: g++ -std=gnu++11 -DHAVE_CONFIG_H -I. -I

Re: [ovs-dev] [PATCH v9 08/10] odp-execute: Add ISA implementation of push_vlan action.

Bleep bloop. Greetings Harry van Haaren, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error,

Re: [ovs-dev] [PATCH V4 7/8] Documentation: Remove kernel module documentation

On 7/12/2022 10:56 AM, Greg Rose wrote: As of Open vSwitch release 2.18 the OVS kernel module is no longer supported. Pull the documentation references. Signed-off-by: Greg Rose --- Documentation/faq/releases.rst| 4 +- .../contributing/backporting-patches.rst | 7

[ovs-dev] [PATCH V4 6/8] acinclude.m4: Remove support for building the OVS kernel module

Since the openvswitch project inception it has had support for building a Linux kernel module to support the OVS kernel datapath. Since Linux kernel release 5.8 support for newer kernels has been deprecated. Now is the time to fully discontinue support for building the openvswitch kernel driver.

[ovs-dev] [PATCH V4 7/8] Documentation: Remove kernel module documentation

As of Open vSwitch release 2.18 the OVS kernel module is no longer supported. Pull the documentation references. Signed-off-by: Greg Rose --- Documentation/faq/releases.rst| 4 +- .../contributing/backporting-patches.rst | 7 +++ Documentation/intro/install/fedora.rst

[ovs-dev] [PATCH V4 5/8] aux:utilities: Remove references to the Linux datapath

Remove references to the Linux datapath from auxiliary files and utilities since it is no longer supported. Signed-off-by: Greg Rose --- build-aux/initial-tab-allowed-files | 1 - .../docker/debian/build-kernel-modules.sh | 13 - utilities/ovs-dev.py

[ovs-dev] [PATCH V4 2/8] rhel: Remove kernel mode spec

Remove the kernel driver specification for RHEL 6.x, 7.x, 8.x and Fedora. Signed-off-by: Greg Rose --- Documentation/intro/install/rhel.rst | 18 Vagrantfile | 12 +-- poc/playbook-centos-builder.yml | 8 -- poc/playbook-fedora-builder.yml | 16 ---

[ovs-dev] [PATCH V4 0/8] Remove OVS kernel driver

It is time to remove support for the ovs kernel driver and push towards use of the upstream linux openvswitch kernel driver in it's place [1]. 1. https://mail.openvswitch.org/pipermail/ovs-dev/2022-april/393292.html Changes in V2: * Removed the Linux datapath and fixed up various Makefiles to

[ovs-dev] [PATCH V4 3/8] tests: Remove support for check-kmod test

The OVS kernel module is no longer supported as of OVS 2.18 Signed-off-by: Greg Rose --- Documentation/topics/testing.rst | 7 --- tests/automake.mk| 6 -- 2 files changed, 13 deletions(-) diff --git a/Documentation/topics/testing.rst b/Documentation/topics/testing.rst

[ovs-dev] [PATCH V4 1/8] Disable unsupported kernel builds

Remove kernel based github workflows since the OVS kernel driver is no longer supported since Release 2.18 Signed-off-by: Greg Rose --- .ci/linux-build.sh | 33 +++- .github/workflows/build-and-test.yml | 20 - 2 files changed, 3

[ovs-dev] [PATCH v9 10/10] odp-execute: Add ISA implementation of set_masked IPv4 action

From: Emma Finn This commit adds support for the AVX512 implementation of the ipv4_set_addrs action as well as an AVX512 implementation of updating the checksums. Signed-off-by: Emma Finn --- lib/odp-execute-avx512.c | 208 +++ 1 file changed, 208

[ovs-dev] [PATCH v9 09/10] odp-execute: Add ISA implementation of set_masked ETH

From: Emma Finn This commit includes infrastructure changes for enabling set_masked_X actions and also adds support for the AVX512 implementation of the eth_set_addrs action. Signed-off-by: Emma Finn --- lib/odp-execute-avx512.c | 90 +++

[ovs-dev] [PATCH v9 07/10] odp-execute: Add ISA implementation of pop_vlan action.

From: Emma Finn This commit adds the AVX512 implementation of the pop_vlan action. Signed-off-by: Emma Finn --- lib/automake.mk | 3 +- lib/odp-execute-avx512.c | 182 ++ lib/odp-execute-private.c | 33 ++- lib/odp-execute-private.h | 2

[ovs-dev] [PATCH v9 08/10] odp-execute: Add ISA implementation of push_vlan action.

From: Emma Finn This commit adds the AVX512 implementation of the push_vlan action. Signed-off-by: Emma Finn --- lib/odp-execute-avx512.c | 55 lib/odp-execute.c| 22 +--- 2 files changed, 68 insertions(+), 9 deletions(-) diff

[ovs-dev] [PATCH v9 05/10] acinclude: Add configure option to enable actions autovalidator at build time.

From: Kumar Amber This commit adds a new command to allow the user to enable the actions autovalidator by default at build time thus allowing for running unit test by default. $ ./configure --enable-actions-default-autovalidator Signed-off-by: Kumar Amber Acked-by: Harry van Haaren ---

[ovs-dev] [PATCH v9 06/10] odp-execute: Add ISA implementation of actions.

From: Emma Finn This commit adds the AVX512 implementation of the action functionality. Usage: $ ovs-appctl odp-execute/action-impl-set avx512 Signed-off-by: Emma Finn Acked-by: Harry van Haaren --- v9: rebase conflict on NEWS --- Documentation/ref/ovs-actions.7.rst | 26

[ovs-dev] [PATCH v9 03/10] odp-execute: Add auto validation function for actions.

From: Emma Finn This commit introduced the auto-validation function which allows users to compare the batch of packets obtained from different action implementations against the linear action implementation. The autovalidator function can be triggered at runtime using the following command: $

[ovs-dev] [PATCH v9 04/10] odp-execute: Add command to switch action implementation.

From: Emma Finn This commit adds a new command to allow the user to switch the active action implementation at runtime. Usage: $ ovs-appctl odp-execute/action-impl-set scalar This commit also adds a new command to retrieve the list of available action implementations. This can be used by to

[ovs-dev] [PATCH v9 02/10] odp-execute: Add function pointer for pop_vlan action.

From: Emma Finn This commit removes the pop_vlan action from the large switch and creates a separate function for batched processing. A function pointer is also added to call the new batched function for the pop_vlan action. Signed-off-by: Emma Finn Acked-by: Harry van Haaren ---

[ovs-dev] [PATCH v9 01/10] odp-execute: Add function pointers to odp-execute for different action implementations.

From: Emma Finn This commit introduces the initial infrastructure required to allow different implementations for OvS actions. The patch introduces action function pointers which allows user to switch between different action implementations available. This will allow for more performance and

[ovs-dev] [PATCH v9 00/10] Actions Infrastructure + Optimizations

This patchset introduces actions infrastructure changes which allows the user to choose between different action implementations based on CPU ISA by using different commands. The infrastructure also provides a way to check the correctness of the ISA optimized action version against the scalar

[ovs-dev] [PATCH ovn] tests: fixed '1 LR with distributed router gateway port' fluke

The test sometimes failed because of duplicate periodic bcast ARPs captured. Use _UNIQ version of packet check procedure to pass. Signed-off-by: Ihar Hrachyshka --- tests/ovn.at | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index

[ovs-dev] [PATCH v4 ovn 2/2] controller: throttle port claim attempts

When multiple chassis are fighting for the same port (requested-chassis is not set, e.g. for gateway ports), they may produce an unreasonable number of chassis field updates in a very short time frame (hundreds of updates in several seconds). This puts unnecessary load on OVN as well as any db

[ovs-dev] [PATCH v4 ovn 1/2] Split out code to handle port binding db updates

This function will later be used to handle port binding updates for postponed (throttled) bindings. Signed-off-by: Ihar Hrachyshka --- controller/binding.c | 250 ++- 1 file changed, 130 insertions(+), 120 deletions(-) diff --git a/controller/binding.c

Re: [ovs-dev] [PATCH 1/14] Rename flags with CKSUM to CSUM

On Thu, Jul 7, 2022 at 5:53 AM Amber, Kumar wrote: > > Hi Flavio, Mike, > > > > I did have a quick look over the patch-set > https://patchwork.ozlabs.org/project/openvswitch/list/?series=307485 > > > > I have some comments over the patches mentioned below: > > 1. Can a Cover letter

Re: [ovs-dev] [PATCH ovn 2/2] controller: throttle port claim attempts

On Tue, Jul 12, 2022 at 11:55 AM Mark Michelson wrote: > > Hi Ihar, I have a few comments below. > > On 7/9/22 01:33, Ihar Hrachyshka wrote: > > When multiple chassis are fighting for the same port (requested-chassis > > is not set, e.g. for gateway ports), they may produce an unreasonable > >

Re: [ovs-dev] [PATCH ovn 2/2] controller: throttle port claim attempts

Hi Ihar, I have a few comments below. On 7/9/22 01:33, Ihar Hrachyshka wrote: When multiple chassis are fighting for the same port (requested-chassis is not set, e.g. for gateway ports), they may produce an unreasonable number of chassis field updates in a very short time frame (hundreds of

Re: [ovs-dev] [PATCH v3] tests: Add OVS-DPDK MTU unit tests.

> > Hi Michael, > > > > The patch uses MTU sizes > 9000 values to check and fail but 9000 may > > not be good value for older NICs As they might fail the test ? > > > > Can we kind of confirm is MTU > 9000 is safe if not we can just use a > > lower value like 1500 etc etc to be safe So that we

Re: [ovs-dev] [PATCH v4 11/14] userspace: Enable L4 csum offloading by default.

On Fri, Jul 1, 2022 at 5:58 AM Mike Pattrick wrote: > diff --git a/lib/netdev.c b/lib/netdev.c > index b222a5e64..ad9081f28 100644 > --- a/lib/netdev.c > +++ b/lib/netdev.c [snip] > @@ -966,11 +946,10 @@ netdev_push_header(const struct netdev *netdev, > size_t i, size =

Re: [ovs-dev] [PATCH 1/14] Rename flags with CKSUM to CSUM

On 7/12/22 16:09, Stokes, Ian wrote: > Hi Folks, > > Any response to these queries? I’m uncomfortable TBH with this feature going > in to 2.18 unless these are addressed/resolved. From an Intel perspective > we’re more than happy to test and review but there are genuine issues to be >

Re: [ovs-dev] [PATCH v3] tests: Add OVS-DPDK MTU unit tests.

> Hi Michael, > > The patch uses MTU sizes > 9000 values to check and fail but 9000 may not > be good value for older NICs > As they might fail the test ? > > Can we kind of confirm is MTU > 9000 is safe if not we can just use a lower > value like 1500 etc etc to be safe > So that we don't

Re: [ovs-dev] [PATCH 1/14] Rename flags with CKSUM to CSUM

Hi Folks, Any response to these queries? I'm uncomfortable TBH with this feature going in to 2.18 unless these are addressed/resolved. From an Intel perspective we're more than happy to test and review but there are genuine issues to be discussed I feel below before merge. Thanks Ian From:

Re: [ovs-dev] [PATCH] acinclude: Fix double -Werror.

On 7/8/22 16:08, Ales Musil wrote: > > > On Fri, Jul 8, 2022 at 3:34 PM Ilya Maximets > wrote: > > We're adding -Werror argument twice to every compiler invocation, > if configured with --enable-Werror.  The reason is the double > expansion of the

Re: [ovs-dev] [PATCH] ovsdb: Enable memory trimming after compaction by default.

On 6/30/22 13:34, Dumitru Ceara wrote: > On 6/30/22 13:27, Ilya Maximets wrote: >> Memory trimming was introduced in OVS 2.15 and didn't cause any >> issues in production environments since then, while allowing >> ovsdb-sever to consume a lot less memory in high scale OVN >> deployments. Enabling

Re: [ovs-dev] [PATCH v2] tests: Add test for later IPv6 fragments nw_proto=44

On 7/8/22 22:55, Rosemarie O'Riorden wrote: > This is a regression test to make sure that all later IPv6 fragments > have proto=44 in the flow key, and that there are not any later IPv6 > frag flows that do not have it. > > Previously, the way that later IPv6 fragments' nw_proto field is parsed >

Re: [ovs-dev] [PATCH v3] tests: Add OVS-DPDK MTU unit tests.

Hi Michael, The patch uses MTU sizes > 9000 values to check and fail but 9000 may not be good value for older NICs As they might fail the test ? Can we kind of confirm is MTU > 9000 is safe if not we can just use a lower value like 1500 etc etc to be safe So that we don't fail un-necessary

Re: [ovs-dev] [PATCH v2] meta-flow: Document nw_proto limitation for IPv6 later frags.

On 7/4/22 16:29, Paolo Valerio wrote: > Signed-off-by: Paolo Valerio > --- > lib/meta-flow.xml |9 + > 1 file changed, 9 insertions(+) > > diff --git a/lib/meta-flow.xml b/lib/meta-flow.xml > index 28865f88c..a1a20366d 100644 > --- a/lib/meta-flow.xml > +++ b/lib/meta-flow.xml > @@

Re: [ovs-dev] [PATCH] utilities/bashcomp: Fix incorrect file mode

On 7/8/22 08:52, Frode Nordahl wrote: > The bash completion scripts shipped with Open vSwitch currently > have the executable bit set. This is problematic because the > files do not start with a shebang and as such a user may end up > executing them using the wrong shell. When installed in a

Re: [ovs-dev] [PATCH v2 1/2] dpif-netdev: Refactor simple match lookup functions.

> Make the simple match functions used during lookup non-static to allow > reuse of these functions in the AVX512 DPIF. > > Signed-off-by: Cian Ferriter > Tested-by: Harry van Haaren > Thanks for the patch series Cian, given that this was discussed at the community call for exception I've

Re: [ovs-dev] [v8 06/10] odp-execute: Add ISA implementation of actions.

> -Original Message- > From: Pai G, Sunil > Sent: Tuesday 12 July 2022 12:22 > To: Finn, Emma ; d...@openvswitch.org > Cc: i.maxim...@ovn.org; echau...@redhat.com; Van Haaren, Harry > ; Amber, Kumar > Subject: RE: [ovs-dev] [v8 06/10] odp-execute: Add ISA implementation of > actions.

Re: [ovs-dev] [v8 05/10] dpif-netdev: Add configure option to enable actions autovalidator at build time.

> -Original Message- > From: Pai G, Sunil > Sent: Tuesday 12 July 2022 12:18 > To: Finn, Emma ; Amber, Kumar > ; d...@openvswitch.org > Cc: i.maxim...@ovn.org; echau...@redhat.com; Van Haaren, Harry > > Subject: RE: [ovs-dev] [v8 05/10] dpif-netdev: Add configure option to enable >

Re: [ovs-dev] [v8 04/10] odp-execute: Add command to switch action implementation.

> -Original Message- > From: Pai G, Sunil > Sent: Tuesday 12 July 2022 12:15 > To: Finn, Emma ; d...@openvswitch.org > Cc: Stokes, Ian ; i.maxim...@ovn.org; > echau...@redhat.com; Van Haaren, Harry ; > Amber, Kumar > Subject: RE: [v8 04/10] odp-execute: Add command to switch action >

Re: [ovs-dev] [v8 01/10] odp-execute: Add function pointers to odp-execute for different action implementations.

> -Original Message- > From: Pai G, Sunil > Sent: Tuesday 12 July 2022 12:04 > To: Finn, Emma ; d...@openvswitch.org > Cc: i.maxim...@ovn.org; echau...@redhat.com; Van Haaren, Harry > ; Amber, Kumar > Subject: RE: [ovs-dev] [v8 01/10] odp-execute: Add function pointers to odp- >

Re: [ovs-dev] [v8 00/10] Actions Infrastructure + Optimizations

> -Original Message- > From: Pai G, Sunil > Sent: Tuesday 12 July 2022 11:48 > To: Finn, Emma ; d...@openvswitch.org > Cc: i.maxim...@ovn.org; echau...@redhat.com; Van Haaren, Harry > ; Amber, Kumar > Subject: RE: [ovs-dev] [v8 00/10] Actions Infrastructure + Optimizations > > Hi

Re: [ovs-dev] [v8 06/10] odp-execute: Add ISA implementation of actions.

Hi Emma, Thanks for the patch, couple of comments inline. > diff --git a/lib/automake.mk b/lib/automake.mk index 5c3b05f6b..e6335ccac > 100644 > --- a/lib/automake.mk > +++ b/lib/automake.mk > @@ -31,6 +31,9 @@ lib_LTLIBRARIES += lib/libopenvswitchavx512.la > lib_libopenvswitch_la_LIBADD +=

Re: [ovs-dev] [v8 05/10] dpif-netdev: Add configure option to enable actions autovalidator at build time.

Hi Amber/Emma, Thanks for the patch, couple of minor nits below. > -Original Message- > From: dev On Behalf Of Emma Finn > Sent: Thursday, July 7, 2022 9:09 PM > To: d...@openvswitch.org; echau...@redhat.com; Van Haaren, Harry > ; Amber, Kumar > Cc: i.maxim...@ovn.org > Subject:

Re: [ovs-dev] [v8 04/10] odp-execute: Add command to switch action implementation.

Hi Emma, Thanks for the patch, generally looks good, one comment below. > diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index > 58be9d0f0..b618ecba0 100644 > --- a/lib/dpif-netdev.c > +++ b/lib/dpif-netdev.c > @@ -63,6 +63,7 @@ > #include "netdev-vport.h" > #include "netlink.h" >

Re: [ovs-dev] [v8 01/10] odp-execute: Add function pointers to odp-execute for different action implementations.

Hi Emma, Thanks for the patch, generally looks good, few comments inline. > diff --git a/lib/odp-execute-private.c b/lib/odp-execute-private.c new > file mode 100644 index 0..b10880ed9 > --- /dev/null > +++ b/lib/odp-execute-private.c > @@ -0,0 +1,92 @@ > +/* > + * Copyright (c) 2022

Re: [ovs-dev] [PATCH v4] ovsdb idl: Add the support to specify the uuid for row insert.

On 6/29/22 18:57, num...@ovn.org wrote: > From: Numan Siddique > > ovsdb-server allows the OVSDB clients to specify the uuid for > the row inserts [1]. The C IDL client library is missing this > feature. This patch adds this support. > > For each schema table, a new function is generated - >

Re: [ovs-dev] [PATCH v3 7/8] debian: Fix generation of copyright file.

On Mon, Jul 11, 2022 at 8:51 PM Ilya Maximets wrote: > > On 7/11/22 20:27, Ilya Maximets wrote: > > On 7/7/22 19:42, Frode Nordahl wrote: > >> The recipe for inserting authors from AUTHORS.rst is wrong. > >> > >> Fixes: 3deca69b08f2 ("doc: Convert AUTHORS to rST") > >> Signed-off-by: Frode

Re: [ovs-dev] [PATCH v4 0/5] netdev-offload-tc: Add support for the check_pkt_len action.

On 12 Jul 2022, at 11:14, Ilya Maximets wrote: > On 6/10/22 16:37, Ilya Maximets wrote: >> On 6/3/22 10:54, Eelco Chaudron wrote: >>> This series adds support for the datapath action check_pkt_len for TC >>> offload. >>> It also includes some offload self-tests. >> >> Thanks for working on

[ovs-dev] openstack/ovsdbapp changes

Hi, I’m interested whether changes to ovsdbapp repository are still accepted? We’ve got some [1], but the review process is on hold for a long time. Thanks. 1: https://review.opendev.org/q/owner:dragen15051%2540gmail.com+status:open Regards, Vladislav Odintsov

Re: [ovs-dev] [v8 00/10] Actions Infrastructure + Optimizations

Hi Emma, Thanks for the series. As discussed internally, I looked over the patches and have few comments. Hope you can address them. > -Original Message- > From: dev On Behalf Of Emma Finn > Sent: Thursday, July 7, 2022 9:09 PM > To: d...@openvswitch.org; echau...@redhat.com; Van

Re: [ovs-dev] [PATCH v2 1/2] dpif-netdev: Refactor simple match lookup functions.

Adding Amber on CC since he missed this patch on mailing list. > -Original Message- > From: Ferriter, Cian > Sent: Thursday, July 7, 2022 6:35 PM > To: ovs-dev@openvswitch.org > Cc: Van Haaren, Harry ; Pai G, Sunil > ; Ferriter, Cian > Subject: [PATCH v2 1/2] dpif-netdev: Refactor

Re: [ovs-dev] [PATCH v2 2/2] dpif-avx512: Add support for simple match lookup.

Adding Amber on CC since he missed this patch on mailing list. > -Original Message- > From: Ferriter, Cian > Sent: Thursday, July 7, 2022 6:35 PM > To: ovs-dev@openvswitch.org > Cc: Van Haaren, Harry ; Pai G, Sunil > ; Ferriter, Cian > Subject: [PATCH v2 2/2] dpif-avx512: Add support

Re: [ovs-dev] [PATCH v2 2/2] dpif-avx512: Add support for simple match lookup.

Adding Amber on CC since he missed this patch on mailing list. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

  1   2   >