On Mon, Nov 28, 2022 at 7:36 PM Jamal Hadi Salim wrote:
> On Mon, Nov 28, 2022 at 3:56 AM Tianyu Yuan
> wrote:
> >
> > Hi Jamal,
> >
> >
> > When no action is specified, there should not be gact with PIPE, rather than
> a gact with drop, like:
> >
Thanks for reminding, I'll add that :)
>
>
On Sun, Nov 27, 2022 at 9:56 PM wrote:
> From: Numan Siddique
>
> ovsdb-server allows the OVSDB clients to specify the uuid for
> the row inserts [1]. Both the C IDL client library and Python
> IDL are missing this feature. This patch adds this support.
>
> In C IDL, for each schema table, a
On 11/27/22 15:14, Abhiram R N wrote:
Mirror creation just creates the mirror. The lsp-attach-mirror
triggers the sequence to create Mirror in OVS DB on compute node.
OVS already supports Port Mirroring.
Further added test cases in ovn.at to verify end to end
the functioning of Port Mirror and
On 11/27/22 15:14, Abhiram R N wrote:
Changes which syncs the NB port mirrors with SB port mirrors.
Also test added to check the NB and SB sync
Co-authored-by: Veda Barrenkala
Signed-off-by: Veda Barrenkala
Signed-off-by: Abhiram R N
---
v16-->v17: No changes
northd/en-northd.c |
Hi, since this patch series doesn't have a cover letter, I figure I
would make some top-level comments on the series here on patch 1. First
off, I suggest running all of the patches through
utilities/checkpatch.py in OVN. There are quite a few nitpicky coding
guidelines violations I noticed
On Thu, Nov 24, 2022 at 4:33 PM Lorenzo Bianconi
wrote:
>
> Introduce the capability to apply QoS rules for logical switch ports
> claimed by ovn-controller. Rely on shash instead of sset for
> egress_ifaces.
>
> Acked-by: Mark Michelson
> Reported-at:
Thanks for the changes, Ales and Dumitru.
Acked-by: Mark Michelson
On 11/25/22 04:37, Ales Musil wrote:
Improve the affinity code to reuse ds buffers as much as possible
without constantly repeating some parts. Add ct.new for the LB flows
so it is clear that the commit happens only when we
On 11/28/22 16:51, Mark Michelson wrote:
> ---
> NEWS | 3 +++
> configure.ac | 2 +-
> debian/changelog | 6 ++
> 3 files changed, 10 insertions(+), 1 deletion(-)
Aside from the missing sign-off, LGTM.
Acked-by: Ilya Maximets
>
> diff --git a/NEWS b/NEWS
> index
On 11/28/22 16:56, Mark Michelson wrote:
> Ilya pointed out that these patches are missing a sign-off. Whoops!
> I can add this when I merge them, assuming they get acked.
OK, LGTM.
Acked-by: Ilya Maximets
>
> On 11/28/22 10:51, Mark Michelson wrote:
>> ---
>> NEWS | 4 ++--
>>
On 11/22/22 10:29, Ales Musil wrote:
> The related traffic wasn't correctly forwarded
> through the LB, the main issue was that the
> traffic was not NATted. This series allows
> the NAT to be applied and the traffic should
> arrive with correct addresses.
> ---
I pushed this version to the main
Improve buffered packet management in ovn-controller using even
datapath and port keys as buffered_packets_map hashmap hash.
Improve run_buffered_binding avoiding unnecessary loops over
datapaths and port_bindings.
Signed-off-by: Lorenzo Bianconi
---
Changes since v4:
- improve
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author Mark Michelson needs to sign off.
Lines checked: 53, Warnings: 0, Errors: 1
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author Mark Michelson needs to sign off.
Lines checked: 55, Warnings: 0, Errors: 1
Ilya pointed out that these patches are missing a sign-off. Whoops! I
can add this when I merge them, assuming they get acked.
On 11/28/22 10:51, Mark Michelson wrote:
---
NEWS | 4 ++--
configure.ac | 2 +-
debian/changelog | 4 ++--
3 files changed, 5 insertions(+), 5
---
NEWS | 3 +++
configure.ac | 2 +-
debian/changelog | 6 ++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index 52a1ea1da..408bde947 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,6 @@
+Post v22.12.0
+-
+
OVN v22.12.0 - xx xxx
---
NEWS | 4 ++--
configure.ac | 2 +-
debian/changelog | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/NEWS b/NEWS
index 672efb749..52a1ea1da 100644
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,5 @@
-Post v22.09.0
--
+OVN v22.12.0 - xx xxx
On 11/25/22 12:09, Dumitru Ceara wrote:
> On 11/22/22 10:29, Ales Musil wrote:
>> In order to allow related traffic use the
>> new action ct_commit_nat, which ensures that
>> the traffic is commited and NATted. In combination
>> with match on ct.rel it allows the related traffic
>> to go through
On 11/25/22 12:08, Dumitru Ceara wrote:
> On 11/22/22 10:29, Ales Musil wrote:
>> Add action called ct_commit_nat, that performs
>> NAT while committing the connection. This is
>> useful for related traffic on which we need
>> to perform NAT, mainly ICMP. We need to
>> commit due to design
On 11/23/22 09:50, Dumitru Ceara wrote:
> On 11/22/22 21:11, Mark Michelson wrote:
>> For the series:
>>
>> Acked-by: Mark Michelson
>
> Thanks, Mark, for the review!
>
> Han, I know you were testing v2, I'll wait for your confirmation before
> merging v3.
>
It seems we have two ways forward
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line has trailing whitespace
#47 FILE: .cirrus.yml:14:
libtool net-tools
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 82 characters long (recommended limit is 79)
#67 FILE: .ci/linux-build.sh:48:
The Cirrus CI script was configured to run FreeBSD job,
however it seems that this job didn't run for several years.
Update the .cirrus.yml to run ARM jobs instead. As first
phase only the regular "test" for GCC and Clang.
We cannot run sanitizers for now as they are very slow
on Cirrus CI and
Update the build script, so it is easier to
define opts/flags per compiler, but also per architecture.
Signed-off-by: Ales Musil
---
.ci/linux-build.sh | 48 +-
.github/workflows/test.yml | 8 +++
2 files changed, 31 insertions(+), 25
To speed up search of possible recursive symbols
use sset. This also prevents the dangling pointer
warning wtih GCC 12 [0].
[0] https://bugzilla.redhat.com/2145107
Signed-off-by: Ales Musil
---
lib/expr.c | 71 --
1 file changed, 32
Bleep bloop. Greetings Xavier Simonart, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: add_cacheinfo failed to refresh for path 'ovs'; merge aborting.
error: Failed to merge
On Mon, Nov 28, 2022 at 02:17:40PM +0100, Eelco Chaudron wrote:
>
>
> On 28 Nov 2022, at 14:11, Marcelo Leitner wrote:
>
> > On Mon, Nov 28, 2022 at 07:11:05AM +, Tianyu Yuan wrote:
...
> >>
> >> Furthermore, I think the current stats for each action mentioned in 2)
> >> cannot represent the
On 28 Nov 2022, at 14:11, Marcelo Leitner wrote:
> On Mon, Nov 28, 2022 at 07:11:05AM +, Tianyu Yuan wrote:
>>
>> On Fri, Nov 25, 2022 at 10:20 PM Marcelo Leitner
>>> On Fri, Nov 25, 2022 at 03:10:37AM +, Tianyu Yuan wrote:
On Fri, Nov 25, 2022 at 10:21 AM Jamal Hadi Salim
>>>
On Mon, Nov 28, 2022 at 07:11:05AM +, Tianyu Yuan wrote:
>
> On Fri, Nov 25, 2022 at 10:20 PM Marcelo Leitner
> > On Fri, Nov 25, 2022 at 03:10:37AM +, Tianyu Yuan wrote:
> > > On Fri, Nov 25, 2022 at 10:21 AM Jamal Hadi Salim
> > wrote:
> > >
> > > >
> > > > I am not sure if the mlx5
On Thu, Nov 24, 2022 at 6:31 AM Mike Pattrick wrote:
>
> From: Flavio Leitner
>
> The netdev receiving packets is supposed to provide the flags
> indicating if the L4 checksum was verified and it is OK or BAD,
> otherwise the stack will check when appropriate by software.
>
> If the packet comes
On Thu, Nov 24, 2022 at 6:31 AM Mike Pattrick wrote:
>
> From: Flavio Leitner
>
> The netdev receiving packets is supposed to provide the flags
> indicating if the IP checksum was verified and it is GOOD or BAD,
> otherwise the stack will check when appropriate by software.
>
> If the packet
Hi Ales,
the patch lgtm, and works as expected.
There are some nit/remarks below, but other than that, I'm ok with the
change.
Ales Musil writes:
> Currently, the CT can be flushed by dpctl only be specifying
> the whole 5-tuple. This is not very convenient when there are
> only some fields
On Mon, Nov 28, 2022 at 3:56 AM Tianyu Yuan wrote:
>
> Hi Jamal,
>
>
> When no action is specified, there should not be gact with PIPE, rather than
> a gact with drop, like:
>
Thanks for the example dumps. I think you should put them in your commit logs.
[..]
>
> About the second scenario of
On 11/28/22 10:49, Ales Musil wrote:
> On Thu, Nov 24, 2022 at 11:53 PM Xavier Simonart
> wrote:
>
>> Recompute test case was checking whether there were no recomputes
>> when ports were ready to be claimed by ovn-controller but sb was read-only.
>>
>> However this was tested by running a test
On Thu, Nov 24, 2022 at 11:53 PM Xavier Simonart
wrote:
> Recompute test case was checking whether there were no recomputes
> when ports were ready to be claimed by ovn-controller but sb was read-only.
>
> However this was tested by running a test case reproducing how the issue
> was
> initially
On 11/28/22 10:31, Lorenzo Bianconi wrote:
>> Fixes: d3926b433e44 ("northd: rely on new actions for lb affinity")
>> Signed-off-by: Dumitru Ceara
>> ---
>> NEWS | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/NEWS b/NEWS
>> index 6c4573b50d..672efb7494 100644
>> --- a/NEWS
>> +++
On 11/25/22 16:37, Numan Siddique wrote:
> On Fri, Nov 25, 2022 at 6:18 AM Dumitru Ceara wrote:
>>
>> A few logical pipeline stages have been added. The internal minor
>> version must be bumped every time that happens.
>>
>> Fixes: d3926b433e44 ("northd: rely on new actions for lb affinity")
>>
On 11/25/22 12:50, Ales Musil wrote:
> As stated by the Github CI:
> "Node.js 12 actions are deprecated. For more information see:
> https://github.blog/changelog/2022-09-22-github-actions-all-
> actions-will-begin-running-on-node16-instead-of-node12/.
> Please update the following actions to use
> Fixes: d3926b433e44 ("northd: rely on new actions for lb affinity")
> Signed-off-by: Dumitru Ceara
> ---
> NEWS | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/NEWS b/NEWS
> index 6c4573b50d..672efb7494 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -1,5 +1,8 @@
> Post v22.09.0
>
Low test coverage on this area caused some errors to remain unnoticed.
Add basic functional test of rculist.
Signed-off-by: Adrian Moreno
---
tests/automake.mk| 1 +
tests/library.at | 5 ++
tests/test-rculist.c | 202 +++
3 files changed, 208
The .prev member of a rculist should not be used directly by users
because it's not rcu-safe. A convenient fake mutex (rculist_fake_mutex)
helps ensuring that in conjunction with clang's thread safety
extensions.
Only writers with exclusive access to the rculist should access .prev
via some of
Fixes: d3926b433e44 ("northd: rely on new actions for lb affinity")
Signed-off-by: Dumitru Ceara
---
NEWS | 3 +++
1 file changed, 3 insertions(+)
diff --git a/NEWS b/NEWS
index 6c4573b50d..672efb7494 100644
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,8 @@
Post v22.09.0
-
+ - Add load
On 11/25/22 16:51, Ilya Maximets wrote:
On 11/25/22 16:29, Adrian Moreno wrote:
On 11/23/22 22:22, Ilya Maximets wrote:
On 11/22/22 15:03, Aaron Conole wrote:
When processing upcall commands, two groups of data are available to
userspace for processing: the actual packet data and the
On 28 Nov 2022, at 8:18, Tianyu Yuan wrote:
>> -Original Message-
>> From: Eelco Chaudron
>> Sent: Friday, November 25, 2022 10:33 PM
>> To: Marcelo Leitner
>> Cc: Tianyu Yuan ; Jamal Hadi Salim
>> ; Simon Horman ;
>> net...@vger.kernel.org; Cong Wang ; Davide
>> Caratti ; Edward Cree
On 11/25/22 16:40, Numan Siddique wrote:
> On Fri, Nov 25, 2022 at 4:53 AM Dumitru Ceara wrote:
>>
>> On 11/22/22 16:03, Ales Musil wrote:
>>> The related traffic wasn't correctly forwarded
>>> through the LB, the main issue was that the
>>> traffic was not NATted. This series allows
>>> the NAT
Hi Jamal,
When no action is specified, there should not be gact with PIPE, rather than a
gact with drop, like:
`
# tc -s -d filter show dev eth8 ingress
filter protocol ipv6 pref 3 flower chain 0
filter protocol ipv6 pref 3 flower chain 0 handle 0x1
eth_type ipv6
ip_flags nofrag
in_hw
On 25 Nov 2022, at 17:05, Adrian Moreno wrote:
> On 10/18/22 18:42, Eelco Chaudron wrote:
>> The datapath supports installing wider flows, and OVS relies on
>> this behavior. For example if ipv4(src=1.1.1.1/192.0.0.0,
>> dst=1.1.1.2/192.0.0.0) exists, a wider flow (smaller mask) of
>>
The datapath supports installing wider flows, and OVS relies on
this behavior. For example if ipv4(src=1.1.1.1/192.0.0.0,
dst=1.1.1.2/192.0.0.0) exists, a wider flow (smaller mask) of
ipv4(src=192.1.1.1/128.0.0.0,dst=192.1.1.2/128.0.0.0) is allowed
to be added.
However, if we try to add a
47 matches
Mail list logo
