Re: [ovs-dev] [PATCH net-next] net: openvswitch: Use struct_size()

Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Sat, 6 May 2023 18:04:16 +0200 you wrote: > Use struct_size() instead of hand writing it. > This is less verbose and more informative. > > Signed-off-by: Christophe JAILLET > --- > It will also help scripts

[ovs-dev] [PATCH v2] python: Add aync DNS support

This adds a Python version of the async DNS support added in: 771680d96 DNS: Add basic support for asynchronous DNS resolving The above version uses the unbound C library, and this implimentation uses the SWIG-wrapped Python version of that. In the event that the Python unbound library is not

Re: [ovs-dev] [PATCH v8 ovn 00/10] Configure OVN QoS thorugh OvS db

On Wed, May 17, 2023 at 5:02 AM Lorenzo Bianconi wrote: > > Rework OVN QoS implementation in order to configure it through OVS QoS > table instead of running tc command directly bypassing OVS. > This series allows to apply QoS rules on the localnet port related to > logical switch ports running

Re: [ovs-dev] [PATCH v8 ovn 03/10] northd: add qos_physical_network in port_binding config column

On Wed, May 17, 2023 at 5:02 AM Lorenzo Bianconi wrote: > > Introduce qos_physical_network in port_binding config column in order to > indicate the name of the egress network name where traffic shaping will > be applied. > This is a preliminary patch to rework OVN QoS implementation in order to >

[ovs-dev] [PATCH ovn v3 3/5] if-status: track interfaces for additional chassis

This will allow all chassis hosting a port to extract interface MTU from if-status-mgr. This will be used in a later patch to calculate the effective path MTU for each port. In addition, it's the right thing to do to claim and mark an interface on all chassis as ovn-installed, even if the chassis

[ovs-dev] [PATCH ovn v3 4/5] Add new egress tables to accommodate for too-big packets handling

The new tables will be used in a later patch as follows: table=37, OFTABLE_OUTPUT_INIT: becomes an initial entry point into the egress pipeline that serves a semantic goal. (Not doing any actual processing at the moment.) table=38, OFTABLE_OUTPUT_LARGE_PKT_DETECT: detect "too-big" IP packets and

[ovs-dev] [PATCH ovn v3 5/5] Implement MTU Path Discovery for multichassis ports

When a multichassis port belongs to a switch with a localnet port, packets originating or directed to the multichassis port are NOT sent thorugh the localnet port. Instead, tunneling is enforced in-cluster to guarantee delivery of all packets to all chassis of the port. This behavior has an

[ovs-dev] [PATCH ovn v3 2/5] Track interface MTU in if-status-mgr

This will be used in a later patch to calculate the effective interface MTU after considering tunneling overhead. NOTE: ideally, OVN would support Logical_Port MTU, in which case we wouldn't have to track OVSDB for interfaces. Signed-off-by: Ihar Hrachyshka --- controller/binding.c| 4

[ovs-dev] [PATCH ovn v3 0/5] Implement MTU Path Discovery for multichassis ports

This series fixes a non-optimal behavior with some multichassis ports. Specifically, - when a multichassis port belongs to a switch that also has a localnet port, - because ingress and egress traffic for the port is funnelled through tunnels to guarantee delivery of packets to all chassis

[ovs-dev] [PATCH ovn v3 1/5] Track ip version of tunnel in chassis_tunnel struct

This will be used in a later patch to calculate tunneling overhead for effective path MTU. Acked-by: Dumitru Ceara Signed-off-by: Ihar Hrachyshka --- controller/local_data.c | 2 ++ controller/local_data.h | 1 + 2 files changed, 3 insertions(+) diff --git a/controller/local_data.c

Re: [ovs-dev] [PATCH v8 ovn 04/10] controller: configure qos through ovs qos table and do not run tc directly

> Hi Lorenzo, > > I'm only replying to this patch since as far as I'm concerned, the rest of > the patches look good enough to me. I'll withhold ACKs until I can ACK the > whole series. > > See below for comments. > > On 5/17/23 05:01, Lorenzo Bianconi wrote: > > Rework OVN QoS implementation

[ovs-dev] [Notice] 0day-bot host scheduled for a system update & backup on Monday, May 22nd

Hi all, We are scheduling a system update and backup for the 0day-bot host on Monday, May 22nd. This means 0daybot, Github Actions and other CI tools will be down for the duration of the update & backup. It is expected to be back online at the end of business day. Best

Re: [ovs-dev] [PATCH v3] tc: fix crash on EAGAIN return from recvmsg on netlink socket.

On Mon, May 15, 2023 at 10:04:48AM +0200, Frode Nordahl wrote: > The tc module combines the use of the `tc_transact` helper > function for communication with the in-kernel tc infrastructure > with assertions on the reply data by `ofpbuf_at_assert` on the > received data prior to further

Re: [ovs-dev] [PATCH ovn v2 6/6] Update multichassis physical flows on interface MTU update

On Tue, May 16, 2023 at 9:41 AM Dumitru Ceara wrote: > > On 5/3/23 22:13, Ihar Hrachyshka wrote: > > Make ICMP Path MTU Discovery flows in table=38 react to underlying > > interface MTU update. > > > > NOTE: ideally, OVN would support Logical_Port MTU, in which case we > > wouldn't have to track

Re: [ovs-dev] [PATCH ovn v2 2/6] Track interface MTU in if-status-mgr

On Tue, May 16, 2023 at 9:40 AM Dumitru Ceara wrote: > > On 5/3/23 22:13, Ihar Hrachyshka wrote: > > This will be used in a later patch to calculate the effective interface > > MTU after considering tunneling overhead. > > > > Signed-off-by: Ihar Hrachyshka > > --- > > controller/binding.c |

Re: [ovs-dev] [PATCH v8 ovn 04/10] controller: configure qos through ovs qos table and do not run tc directly

Hi Lorenzo, I'm only replying to this patch since as far as I'm concerned, the rest of the patches look good enough to me. I'll withhold ACKs until I can ACK the whole series. See below for comments. On 5/17/23 05:01, Lorenzo Bianconi wrote: Rework OVN QoS implementation in order to

[ovs-dev] [PATCH 1/2] stream-ssl: Disable alerts on unexpected EOF.

OpenSSL 3.0 enabled alerts for unexpected EOF by default. It supposed to alert the application whenever the connection terminated without a proper close_notify. And that should allow applications to take actions to protect themselves from potential TLS truncation attack. This is how it looks

[ovs-dev] [PATCH 2/2] tests: Check ovsdb-server logs in OVSDB tests.

Many OVSDB tests are not checking the server log for warnings or errors. Some are not even using the log file. It's mostly OK as we're usually checking the user-visible behavior. But it would also be nice to detect some internal warnings if there are some. Moving the OVSDB_SERVER_SHUTDOWN

[ovs-dev] [PATCH 0/2] ssl: Ignore unexpected EOF + ovsdb log checking in tests.

This patch set removes annoying EOF alerts from ovsdb-server logs in case of OpenSSL 3.0+ and enables checking of server logs in many existing tests. Ilya Maximets (2): stream-ssl: Disable alerts on unexpected EOF. tests: Check ovsdb-server logs in OVSDB tests. lib/stream-ssl.c | 8

Re: [ovs-dev] [PATCH ovn v2 5/6] Implement MTU Path Discovery for multichassis ports

Thank you Dumitru! See below. On Tue, May 16, 2023 at 9:41 AM Dumitru Ceara wrote: > I'm not necessarily rejecting this change. I just wanted to bring up an > alternative approach (I'm not sure if it's possible to implement it though): > > The CMS (e.g., Neutron) probably knows before hand the

Re: [ovs-dev] [ovn] help wanted: how MC_FLOOD actions works for eth.mcast traffic coming from localnet lports?

Thanks Dumitru for the response. I’ve looked through this code and even tried to implement similar logic for vtep lport, but realized, that vtep mcast traffic is a bit different from localnet port. mcast traffic originated in normal vif port in localnet-attached lswitch has two cases: - if

Re: [ovs-dev] [ovn] ha-chassis-group false positive failover

On Wed, May 17, 2023 at 4:44 AM Vladislav Odintsov wrote: > > > > > On 16 May 2023, at 23:54, Numan Siddique wrote: > > > > Hi Vladislav, > > > > Sorry for the late reply. > > > > PSB for few comments. > > > Thanks for your reply! > My answers are inline. > > > > > > > > > On Tue, May 16, 2023

Re: [ovs-dev] [PATCH ovn] actions: Remove unused ovnfield_act_header structure.

On 5/16/23 18:25, Simon Horman wrote: > On Mon, May 08, 2023 at 01:14:55PM +0200, Dumitru Ceara wrote: >> It's not referenced anywhere and by the look of it it has never been. >> >> Signed-off-by: Dumitru Ceara > > Reviewed-by: Simon Horman > Thanks, Simon, for the review. I applied the

Re: [ovs-dev] [PATCH ovn v2] tests: Fix flakiness of policy based routing on slower systems

On 5/10/23 13:41, Ales Musil wrote: > The test expected that the packet statistics will be > immediately reflected after packet inject, however that > might not be true on slower systems. Use OVS_WAIT_UNTIL > instead to ensure that the packet really went through. > Also align the IPv4 and IPv6

Re: [ovs-dev] [PATCH ovn] ovn-controller docs: fix typo in ovn-monitor-all description

On 5/16/23 17:46, Simon Horman wrote: > On Fri, May 05, 2023 at 11:40:03AM +0300, Vladislav Odintsov wrote: >> Make it more clear that ovn-monitor-all option has effect on OVN Southbound >> database rather than local OVS. >> >> Reported-at: >>

Re: [ovs-dev] [PATCH ovn 0/4] remove unnecessary OVS_PACKED attribute from dhcpv6 structures

On 5/15/23 21:48, Mark Michelson wrote: > Thanks Lorenzo, > > For the series, > > Acked-by: Mark Michelson > Thanks, Lorenzo and Mark! I applied patches 2, 3 and 4 to the main branch. I skipped the first patch because I had already applied my (identical) version of it. [0] Regards, Dumitru

[ovs-dev] [PATCH v9] ofproto-dpif-upcall: Don't set statistics to 0 when they jump back

The only way that stats->{n_packets,n_bytes} would decrease is due to an overflow, or if there are bugs in how statistics are handled. In the past, there were multiple issues that caused a jump backward. A workaround was in place to set the statistics to 0 in that case. When this happened while

[ovs-dev] [PATCH v8] ofproto-dpif-upcall: Don't set statistics to 0 when they jump back

The only way that stats->{n_packets,n_bytes} would decrease is due to an overflow, or if there are bugs in how statistics are handled. In the past, there were multiple issues that caused a jump backward. A workaround was in place to set the statistics to 0 in that case. When this happened while

[ovs-dev] [PATCH v7] ofproto-dpif-upcall: Don't set statistics to 0 when they jump back

The only way that stats->{n_packets,n_bytes} would decrease is due to an overflow, or if there are bugs in how statistics are handled. In the past, there were multiple issues that caused a jump backward. A workaround was in place to set the statistics to 0 in that case. When this happened while

Re: [ovs-dev] [PATCH ovn v3] Pass localnet traffic through CT when a LB is configured.

On Wed, May 10, 2023 at 4:05 AM Ales Musil wrote: > > On Mon, May 8, 2023 at 5:19 PM Mark Michelson wrote: > > > Current code always skips conntrack for traffic that ingresses or > > egresses on a localnet port. However, this makes it impossible for > > traffic to be load-balanced when it

Re: [ovs-dev] Official Way For Rebuilding OVS

Hi Frode, Any comparison between using dpkg-buildpackage and debhelper? What is the official way for including custom patches? Just edit the source code files? What about custom patches naming? Best regards. On Wed, May 17, 2023, 2:28 AM Frode Nordahl wrote: > > > tir. 16. mai 2023, 19:03

Re: [ovs-dev] [PATCH v6] ofproto-dpif-upcall: Don't set statistics to 0 when they jump back

On 5/17/23 14:50, Balazs Nemeth wrote: > The only way that stats->{n_packets,n_bytes} would decrease is due to an > overflow, or if there are bugs in how statistics are handled. In the > past, there were multiple issues that caused a jump backward. A > workaround was in place to set the statistics

Re: [ovs-dev] Official Way For Rebuilding OVS

Hi Ilya, You are right, dpkg-buildpackage produce two sets of binaries, each for standard and DPDK versions. I have found the debug symbols stripped ones on different folders Best regards. On Wed, May 17, 2023, 12:03 AM Ilya Maximets wrote: > On 5/16/23 17:39, Lazuardi Nasution wrote: > >

Re: [ovs-dev] [PATCH 2/2] conntrack: Release nat_conn in case both keys have the same hash.

Paolo Valerio writes: > Ilya Maximets writes: > >> On 5/4/23 19:21, Paolo Valerio wrote: >>> Ilya Maximets writes: >>> On 4/19/23 20:40, Paolo Valerio wrote: > During the creation of a new connection, there's a chance both key and > rev_key end up having the same hash. This is

Re: [ovs-dev] [PATCH ovn] northd: centralized reply lb traffic even if FIP is defined

On 4/28/23 15:57, Lorenzo Bianconi wrote: > In the current codebase for distributed gw router port use-case, > it is not possible to add a load balancer that redirects the traffic > to a backed if it is even the internal IP of a FIP NAT rule since > the reply traffic is never centralized. Fix the

[ovs-dev] [PATCH v6] ofproto-dpif-upcall: Don't set statistics to 0 when they jump back

The only way that stats->{n_packets,n_bytes} would decrease is due to an overflow, or if there are bugs in how statistics are handled. In the past, there were multiple issues that caused a jump backward. A workaround was in place to set the statistics to 0 in that case. When this happened while

Re: [ovs-dev] [PATCH v5] ofproto-dpif-upcall: Don't set statistics to 0 when they jump back

On 5/17/23 13:09, Eelco Chaudron wrote: > > > On 31 Mar 2023, at 15:19, Eelco Chaudron wrote: > >> On 31 Mar 2023, at 15:15, Ilya Maximets wrote: >> >>> On 3/31/23 15:06, Eelco Chaudron wrote: On 31 Mar 2023, at 12:38, Simon Horman wrote: > On Fri, Mar 31, 2023 at

Re: [ovs-dev] [PATCH v5] ofproto-dpif-upcall: Don't set statistics to 0 when they jump back

On 31 Mar 2023, at 15:19, Eelco Chaudron wrote: > On 31 Mar 2023, at 15:15, Ilya Maximets wrote: > >> On 3/31/23 15:06, Eelco Chaudron wrote: >>> >>> >>> On 31 Mar 2023, at 12:38, Simon Horman wrote: >>> On Fri, Mar 31, 2023 at 12:05:09PM +0200, Ilya Maximets wrote: > On 3/31/23 11:07,

Re: [ovs-dev] [PATCH] seq: Make read of the current value atomic

On 16 May 2023, at 21:48, Ilya Maximets wrote: > On 5/16/23 10:20, Eelco Chaudron wrote: >> >> >> On 15 May 2023, at 17:47, Ilya Maximets wrote: >> >>> On 5/15/23 16:24, Eelco Chaudron wrote: On 4 May 2023, at 0:55, Ilya Maximets wrote: > On 3/27/23 13:25, Eelco Chaudron

[ovs-dev] [PATCH v8 ovn 09/10] controller: get rid of egress_ifaces sset

egress_ifaces sset is no longer used by ovn-controller, so get rid of it Signed-off-by: Lorenzo Bianconi --- controller/binding.c| 40 - controller/binding.h| 1 - controller/ovn-controller.c | 10 ++ 3 files changed, 2 insertions(+),

[ovs-dev] [PATCH v8 ovn 08/10] northd: apply QoS rules on the localnet port related to LSP ports

This patch allows to apply QoS rules on the localnet port related to logical switch ports running on the same datapath. Considering the following netowrk configuration: LSP{0,1} -- LogicalSwitch -- Localnet0 It is possible to apply the following QoS rules on Localnet0 on egress traffic entering

[ovs-dev] [PATCH v8 ovn 10/10] update NEWS with new QoS info

Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2129742 Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2139100 Acked-By: Ihar Hrachyshka Signed-off-by: Lorenzo Bianconi --- NEWS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS b/NEWS index 0f1c5f985..a7a11061f

[ovs-dev] [PATCH v8 ovn 07/10] northd: make queue_id allocation global for the ovn cluster

In order to avoid possible queue_id clash when we have a localnet and a LSP ports on the same hv, make QoS queue_id allocation global for the ovn cluster. Signed-off-by: Lorenzo Bianconi --- northd/northd.c | 127 1 file changed, 20

[ovs-dev] [PATCH v8 ovn 05/10] controller: improve ovs port lookup by qos

Introduce ovsport_lookup_by_qos routine in order to speed-up ovs port lookup based on port qos. Acked-By: Ihar Hrachyshka Tested-by: Rodolfo Alonso Signed-off-by: Lorenzo Bianconi --- controller/binding.c| 37 ++--- controller/binding.h| 2 +-

[ovs-dev] [PATCH v8 ovn 04/10] controller: configure qos through ovs qos table and do not run tc directly

Rework OVN QoS implementation in order to configure it through OVS QoS table instead of running tc command directly bypassing OVS. Acked-By: Ihar Hrachyshka Reviewed-by: Simon Horman Tested-by: Rodolfo Alonso Signed-off-by: Lorenzo Bianconi --- controller/binding.c| 432

[ovs-dev] [PATCH v8 ovn 06/10] controller: use unsigned long long int for qos_max_rate/qos_min_rate/qos_burst

This patch allow to configure max/min rate greater than 4Gbps Acked-By: Ihar Hrachyshka Tested-by: Rodolfo Alonso Signed-off-by: Lorenzo Bianconi --- controller/binding.c | 29 - 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/controller/binding.c

[ovs-dev] [PATCH v8 ovn 02/10] controller: add incremental processing for ovn-controller qos_map

Introduce support to process incrementally ovn-controller QoS configuration received from ovn-northd adding qos_map hash map. This is a preliminary patch to rework OVN QoS implementation in order to configure it through OVS QoS table instead of running tc command directly bypassing OVS.

[ovs-dev] [PATCH v8 ovn 03/10] northd: add qos_physical_network in port_binding config column

Introduce qos_physical_network in port_binding config column in order to indicate the name of the egress network name where traffic shaping will be applied. This is a preliminary patch to rework OVN QoS implementation in order to configure it through OVS QoS table instead of running tc command

[ovs-dev] [PATCH v8 ovn 01/10] controller: remove tunnel interfaces from egress_ifaces sset

Remove tunnel interfaces from egress list in order to not shape them. Acked-By: Ihar Hrachyshka Tested-by: Rodolfo Alonso Signed-off-by: Lorenzo Bianconi --- controller/binding.c | 9 - 1 file changed, 9 deletions(-) diff --git a/controller/binding.c b/controller/binding.c index

[ovs-dev] [PATCH v8 ovn 00/10] Configure OVN QoS thorugh OvS db

Rework OVN QoS implementation in order to configure it through OVS QoS table instead of running tc command directly bypassing OVS. This series allows to apply QoS rules on the localnet port related to logical switch ports running on the same datapath. Considering the following netowrk

Re: [ovs-dev] [ovn] ha-chassis-group false positive failover

> On 16 May 2023, at 23:54, Numan Siddique wrote: > > Hi Vladislav, > > Sorry for the late reply. > > PSB for few comments. Thanks for your reply! My answers are inline. > > > > On Tue, May 16, 2023 at 3:42 PM Vladislav Odintsov > wrote: >> >> Hi Numan,