On 6/23/23 19:33, David Marchand wrote:
> On Fri, Jun 23, 2023 at 5:14 PM Ilya Maximets wrote:
>> On 6/23/23 15:16, David Marchand wrote:
>>> On Wed, Jun 21, 2023 at 12:13 AM Ilya Maximets wrote:
On 6/14/23 21:03, Mike Pattrick wrote:
> The netdev receiving packets is supposed to
On 6/15/23 04:51, Peng He wrote:
> OVS allows overlapping megaflows, as long as the actions of these
> megaflows are equal. However, the current implementation of action
> modification relies on flow_lookup instead of ufid, this could result
> in looking up a wrong megaflow and make the ukeys and
On 6/23/23 21:37, num...@ovn.org wrote:
> From: Numan Siddique
>
> This patch series adds the support to handle load balancer and
> load balancer group changes incrementally in the "northd" engine
> node. "flow" engine node doesn't support I-P yet and falls back
> to full recompute.
>
> Note:
On 6/19/23 07:05, Chris Mi wrote:
> This patch set adds offload support for sFlow.
>
> Psample is a genetlink channel for packet sampling. TC action act_sample
> uses psample to send sampled packets to userspace.
>
> When offloading sample action to TC, userspace creates a unique ID to
> map
On 6/19/23 07:05, Chris Mi wrote:
> Add three sFlow offload test cases:
>
> 3: offloads - sflow with sampling=1 - offloads enabled ok
> 4: offloads - sflow with sampling=2 - offloads enabled ok
> 5: offloads - ping over vxlan tunnel with sflow - offloads enabled ok
>
> Signed-off-by: Chris
On 6/19/23 07:05, Chris Mi wrote:
> In thread handler 0, add netdev offload recv in normal recv upcalls.
> To avoid starvation, introduce a flag to alternate the order of
> receiving normal upcalls and offload upcalls based on that flag.
>
> Add similar change for recv_wait.
>
> Signed-off-by:
On 6/19/23 07:05, Chris Mi wrote:
> Create a unique group ID to map the sFlow info when offloading sample
> action to TC. When showing the offloaded datapath flows, translate the
> group ID from TC sample action to sFlow info using the mapping.
>
> Signed-off-by: Chris Mi
> Reviewed-by: Roi
On 6/19/23 07:05, Chris Mi wrote:
> Iterate each registered offload API. It's not a problem for today
> since we only have one implementation.
>
> Signed-off-by: Chris Mi
> Reviewed-by: Roi Dayan
> ---
> lib/netdev-offload.c | 38 ++
> lib/netdev-offload.h |
On 6/19/23 07:05, Chris Mi wrote:
> Initialize psample socket. Add sample recv API to receive sampled
> packets from psample socket. Add sample recv wait API to add psample
> socket fd to poll list.
>
> Signed-off-by: Chris Mi
> Reviewed-by: Roi Dayan
> ---
> lib/dpif.h|
On 6/19/23 07:05, Chris Mi wrote:
> When offloading sample action to TC, userspace creates a unique ID
> to map sample action and tunnel info and passes this ID to kernel
> instead of the sample info. Kernel will send this ID and sampled
> packet to userspace. Using the ID, userspace can recover
On 6/9/23 12:19, Ihar Hrachyshka wrote:
This thread is to discuss improvements that would allow OVN (and maybe
OVS?) to adopt fmt_pkt (frontend to scapy packet constructor) in the test
suite.
(For those not aware of what it is, please consult this commit:
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
Patch skipped due to previous failure.
Please check this out. If you feel there has been an error,
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
Patch skipped due to previous failure.
Please check this out. If you feel there has been an error,
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
Patch skipped due to previous failure.
Please check this out. If you feel there has been an error,
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
Patch skipped due to previous failure.
Please check this out. If you feel there has been an error,
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
Patch skipped due to previous failure.
Please check this out. If you feel there has been an error,
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
Patch skipped due to previous failure.
Please check this out. If you feel there has been an error,
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
Patch skipped due to previous failure.
Please check this out. If you feel there has been an error,
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: sha1 information is lacking or useless (northd/en-northd.c).
error: could not build fake
From: Numan Siddique
When a logical router gets updated due to load balancer
or load balancer groups changes, it is now incrementally
handled in the 'northd' engine node. Other logical router
updates result in the full recompute of 'northd' engine node.
lflow engine node still falls back to
From: Numan Siddique
A new engine node 'en_sync_to_sb_pb' is added within 'en_sync_to_sb'
node to sync NAT column of Port bindings table. This separation
is required in order to add load balancer group I-P handling
in 'en_northd' engine node (which is handled in the next commit).
From: Numan Siddique
Signed-off-by: Numan Siddique
---
lib/lb.c| 45 +
lib/lb.h| 33 +--
northd/northd.c | 80 -
tests/ovn-northd.at | 6 ++--
4 files changed, 121 insertions(+), 43
From: Numan Siddique
Signed-off-by: Numan Siddique
---
lib/lb.c| 17 +++-
lib/lb.h| 2 +
northd/northd.c | 211 +---
northd/northd.h | 9 ++
tests/ovn-northd.at | 8 +-
5 files changed, 190 insertions(+), 57
From: Numan Siddique
This will help in handling other column changes of a logical switch.
Signed-off-by: Numan Siddique
---
northd/northd.c | 245
1 file changed, 144 insertions(+), 101 deletions(-)
diff --git a/northd/northd.c
From: Numan Siddique
Any changes to load balancers and load balancer groups
are handled incrementally in the newly added 'northd_lb_data'
engine node. 'northd_lb_data' is input to 'northd' node
and the handler - northd_northd_lb_data_handler in 'northd'
node handles the changes.
If a load
From: Numan Siddique
This patch separates out the 'lbs' and 'lb_groups' from the 'northd' engine
node data into a new engine node 'northd_lb_data'. This new node becomes
an input to the 'northd' node.
This makes handling the NB load balancer and load balancer group changes
easier.
From: Numan Siddique
This patch separates out the 'lbs' and 'lb_groups' from the 'northd' engine
node data into a new engine node 'northd_lb_data'. This new node becomes
an input to the 'northd' node.
This makes handling the NB load balancer and load balancer group changes
easier.
From: Numan Siddique
Similar to the commit [1], a new sub-engine node "en_sync_to_sb_lb"
is added with-in the "en_sync_to_sb" to sync the SB load balancers.
Its main input nodes are "en_northd" (to access the "lbs" hmap built
by this node) and "en_sb_load_balancer" to access the SB load
From: Numan Siddique
This patch series adds the support to handle load balancer and
load balancer group changes incrementally in the "northd" engine
node. "flow" engine node doesn't support I-P yet and falls back
to full recompute.
Note: I still need to do some scale testing and measure the
On Fri, Jun 23, 2023 at 5:14 PM Ilya Maximets wrote:
> On 6/23/23 15:16, David Marchand wrote:
> > On Wed, Jun 21, 2023 at 12:13 AM Ilya Maximets wrote:
> >>
> >> On 6/14/23 21:03, Mike Pattrick wrote:
> >>> The netdev receiving packets is supposed to provide the flags
> >>> indicating if the L4
Currently OVS keeps track of which mirrors that each packet has been
sent to for the purpose of deduplication. However, this doesn't consider
that openflow rules can make significant changes to packets after
ingress.
For example, OVN can create OpenFlow rules that turn an echo request
into an
On 6/23/23 17:15, Terry Wilson wrote:
> Just checking in on this. I see a single test failure
> https://github.com/ovsrobot/ovs/actions/runs/5272193494 'linux clang
> test asan' but it looks like something related to bfd, so definitely
> not the python patch here.
This one is unrelated, yes.
>
Just checking in on this. I see a single test failure
https://github.com/ovsrobot/ovs/actions/runs/5272193494 'linux clang
test asan' but it looks like something related to bfd, so definitely
not the python patch here. Anything I need to do?
On Wed, Jun 14, 2023 at 4:07 PM Terry Wilson wrote:
>
On 6/23/23 15:16, David Marchand wrote:
> On Wed, Jun 21, 2023 at 12:13 AM Ilya Maximets wrote:
>>
>> On 6/14/23 21:03, Mike Pattrick wrote:
>>> The netdev receiving packets is supposed to provide the flags
>>> indicating if the L4 checksum was verified and it is OK or BAD,
>>> otherwise the
On 15 Jun 2023, at 4:51, Peng He wrote:
> OVS allows overlapping megaflows, as long as the actions of these
> megaflows are equal. However, the current implementation of action
> modification relies on flow_lookup instead of ufid, this could result
> in looking up a wrong megaflow and make the
On 6/21/23 15:25, Aaron Conole wrote:
> Eelco Chaudron writes:
>
>> On 20 Jun 2023, at 16:17, Aaron Conole wrote:
>>
>>> Eelco Chaudron writes:
>>>
Add additional error coverage counters for dpif operation failures.
This could help to quickly identify netlink problems when
Dumitru Ceara writes:
> As far as I can tell they're used mostly for CI job definitions and
> these tend to result in long lines.
>
> Reported-at:
> https://mail.openvswitch.org/pipermail/ovs-dev/2023-June/405796.html
> Suggested-by: Aaron Conole
> Signed-off-by: Dumitru Ceara
> ---
On Wed, Jun 21, 2023 at 12:13 AM Ilya Maximets wrote:
>
> On 6/14/23 21:03, Mike Pattrick wrote:
> > The netdev receiving packets is supposed to provide the flags
> > indicating if the L4 checksum was verified and it is OK or BAD,
> > otherwise the stack will check when appropriate by software.
>
On 6/16/23 19:41, Paolo Valerio wrote:
> Ilya Maximets writes:
>
>> On 6/16/23 14:56, Aaron Conole wrote:
>>> Ilya Maximets writes:
>>>
On 6/15/23 19:49, Paolo Valerio wrote:
> Ilya Maximets writes:
>
>> On 6/14/23 21:08, Ilya Maximets wrote:
>>> On 6/14/23 20:11, Paolo
On 6/23/23 14:20, Eelco Chaudron wrote:
>
>
> On 9 Jun 2023, at 17:03, Peng He wrote:
>
>> push_dp_ops only handles delete ops errors but ignores the modify
>> ops results. It's better to handle all the dp operation errors in
>> a consistent way.
>>
>> This patch prevents the inconsistency by
On 23 Jun 2023, at 14:33, Dumitru Ceara wrote:
> On 6/23/23 14:23, Eelco Chaudron wrote:
>>
>>
>> On 23 Jun 2023, at 14:22, Eelco Chaudron wrote:
>>
>>> On 23 Jun 2023, at 14:12, Dumitru Ceara wrote:
>>>
As far as I can tell they're used mostly for CI job definitions and
these tend to
On 6/23/23 14:23, Eelco Chaudron wrote:
>
>
> On 23 Jun 2023, at 14:22, Eelco Chaudron wrote:
>
>> On 23 Jun 2023, at 14:12, Dumitru Ceara wrote:
>>
>>> As far as I can tell they're used mostly for CI job definitions and
>>> these tend to result in long lines.
>>>
>>> Reported-at:
>>>
On 23 Jun 2023, at 14:22, Eelco Chaudron wrote:
> On 23 Jun 2023, at 14:12, Dumitru Ceara wrote:
>
>> As far as I can tell they're used mostly for CI job definitions and
>> these tend to result in long lines.
>>
>> Reported-at:
>>
On 23 Jun 2023, at 14:12, Dumitru Ceara wrote:
> As far as I can tell they're used mostly for CI job definitions and
> these tend to result in long lines.
>
> Reported-at:
> https://mail.openvswitch.org/pipermail/ovs-dev/2023-June/405796.html
> Suggested-by: Aaron Conole
> Signed-off-by:
On 9 Jun 2023, at 17:03, Peng He wrote:
> push_dp_ops only handles delete ops errors but ignores the modify
> ops results. It's better to handle all the dp operation errors in
> a consistent way.
>
> This patch prevents the inconsistency by considering modify failure
> in revalidators.
>
> To
On 6/22/23 15:37, Aaron Conole wrote:
> Dumitru Ceara writes:
>
>> On 6/22/23 13:56, Aaron Conole wrote:
>>> Dumitru Ceara writes:
>>>
This avoids manual intervention when upstream ovn-kubernetes changes
its dependency versions.
Signed-off-by: Patryk Diak
As far as I can tell they're used mostly for CI job definitions and
these tend to result in long lines.
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-dev/2023-June/405796.html
Suggested-by: Aaron Conole
Signed-off-by: Dumitru Ceara
---
utilities/checkpatch.py | 2 +-
1 file changed,
On Fri, Jun 23, 2023 at 01:01:38PM +0200, Eelco Chaudron wrote:
>
>
> On 23 Jun 2023, at 12:57, Simon Horman wrote:
>
> > On Fri, Jun 23, 2023 at 11:16:50AM +0200, Eelco Chaudron wrote:
> >>
> >>
> >> On 19 Jun 2023, at 13:56, Roi Dayan wrote:
> >>
> >>> From: Gavin Li
> >>>
> >>> Add a vxlan
On 23 Jun 2023, at 12:57, Simon Horman wrote:
> On Fri, Jun 23, 2023 at 11:16:50AM +0200, Eelco Chaudron wrote:
>>
>>
>> On 19 Jun 2023, at 13:56, Roi Dayan wrote:
>>
>>> From: Gavin Li
>>>
>>> Add a vxlan gbp offload test case:
>>>
>>> vxlan offloads with gbp extention - ping between two
On Fri, Jun 23, 2023 at 11:16:50AM +0200, Eelco Chaudron wrote:
>
>
> On 19 Jun 2023, at 13:56, Roi Dayan wrote:
>
> > From: Gavin Li
> >
> > Add a vxlan gbp offload test case:
> >
> > vxlan offloads with gbp extention - ping between two ports - offloads
> > enabled ok
> >
> > Signed-off-by:
The patch introduces a new commands ovs-appctl dpctl/dump-conntrack-exp
that allows to dump the existing expectations for the userspace ct.
Signed-off-by: Paolo Valerio
---
NEWS |2 +
lib/conntrack.c | 66 +
On 19 Jun 2023, at 13:56, Roi Dayan wrote:
> From: Gavin Li
>
> Add a vxlan gbp offload test case:
>
> vxlan offloads with gbp extention - ping between two ports - offloads
> enabled ok
>
> Signed-off-by: Gavin Li
> Reviewed-by: Roi Dayan
> Reviewed-by: Simon Horman
> ---
Thanks for
On 19 Jun 2023, at 13:56, Roi Dayan wrote:
> From: Gavin Li
>
> Kernels that do not support vxlan gbp would treat the rule that has vxlan
> gbp encap action or vxlan gbp id match differently, either reject it or
> just skip the action/match and continue processing the knowing ones.
>
> To
On 23 Jun 2023, at 10:44, Eelco Chaudron wrote:
> On 19 Jun 2023, at 13:56, Roi Dayan wrote:
>
>> From: Gavin Li
>>
>> Add TC offload support for vxlan encap with gbp option
>>
>> Signed-off-by: Gavin Li
>> Reviewed-by: Gavi Teitz
>> Reviewed-by: Roi Dayan
>> Reviewed-by: Simon Horman
>
>
On 19 Jun 2023, at 13:56, Roi Dayan wrote:
> From: Gavin Li
>
> Add TC offload support for vxlan encap with gbp option
>
> Signed-off-by: Gavin Li
> Reviewed-by: Gavi Teitz
> Reviewed-by: Roi Dayan
> Reviewed-by: Simon Horman
Thanks for following up! The changes look good to me, one small
On 19 Jun 2023, at 13:56, Roi Dayan wrote:
> From: Gavin Li
>
> Most of the data members of struct tc_action{ } are defined as anonymous
> struct in place. Instead of passing all members of an anonymous struct,
> which is not flexible to new members being added, expose encap as named
> struct
On 19 Jun 2023, at 13:56, Roi Dayan wrote:
> From: Gavin Li
>
> Add TC offload support for filtering vxlan tunnels with gbp option
>
> Signed-off-by: Gavin Li
> Reviewed-by: Gavi Teitz
> Reviewed-by: Roi Dayan
> Reviewed-by: Simon Horman
Thanks for following up! The changes look good to
On 19 Jun 2023, at 13:56, Roi Dayan wrote:
> From: Gavin Li
>
> Linux kernel netlink module added NLA_F_NESTED flag checking for nested
> netlink messages in 5.2. A nested message without the flag set will be
> treated as malformated one. The check is optional and is controlled by
> message
On 19 Jun 2023, at 13:56, Roi Dayan wrote:
> From: Gavin Li
>
> Extract vxlan gbp option encoding to odp_encode_gbp_raw to be used in
> following commits.
>
> Signed-off-by: Gavin Li
> Reviewed-by: Roi Dayan
> Reviewed-by: Simon Horman
Thanks for following up! The changes look good to
On 19 Jun 2023, at 13:56, Roi Dayan wrote:
> From: Gavin Li
>
> Extract vxlan gbp option decoding to odp_decode_gbp_raw to be used in
> following commits.
>
> Signed-off-by: Gavin Li
> Reviewed-by: Roi Dayan
> Reviewed-by: Simon Horman
Thanks for following up! The changes look good to me.
On 19 Jun 2023, at 13:56, Roi Dayan wrote:
> From: Gavin Li
>
> Tc flower tunnel key options were encoded in nl_msg_put_flower_tunnel_opts
> and decoded in nl_parse_flower_tunnel_opts. Only geneve was supported.
>
> To avoid adding more arguments to the function to support more vxlan
>
61 matches
Mail list logo
