On Sat, Jul 1, 2023 at 7:33 AM Han Zhou wrote:
>
> On Thu, Jun 29, 2023 at 10:54 PM Numan Siddique wrote:
> >
> > On Sun, Jun 18, 2023 at 11:48 AM Han Zhou wrote:
> > >
> > > This patch achieves zero recompute for VIF updates and deletions in
> > > common scenarios. The performance gain for
Bleep bloop. Greetings Peng He, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author Peng He needs to sign off.
WARNING: Unexpected sign-offs from developers who are not
push_dp_ops only handles delete ops errors but ignores the modify
ops results. It's better to handle all the dp operation errors in
a consistent way.
This patch prevents the inconsistency by considering modify failure
in revalidators.
To note, we cannot perform two state transitions and change
Bleep bloop. Greetings Peng He, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed
Bleep bloop. Greetings Peng He, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed
push_dp_ops only handles delete ops errors but ignores the modify
ops results. It's better to handle all the dp operation errors in
a consistent way.
This patch prevents the inconsistency by considering modify failure
in revalidators.
To note, we cannot perform two state transitions and change
I miss one command in the test suite. will resend.
Peng He 于2023年7月1日周六 12:50写道：
> push_dp_ops only handles delete ops errors but ignores the modify
> ops results. It's better to handle all the dp operation errors in
> a consistent way.
>
> This patch prevents the inconsistency by considering
push_dp_ops only handles delete ops errors but ignores the modify
ops results. It's better to handle all the dp operation errors in
a consistent way.
This patch prevents the inconsistency by considering modify failure
in revalidators.
To note, we cannot perform two state transitions and change
Bleep bloop. Greetings Peng He, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author Peng He needs to sign off.
WARNING: Unexpected sign-offs from developers who are not
On Fri, Jun 30, 2023 at 4:30 PM Ilya Maximets wrote:
>
> On 6/25/23 19:35, Han Zhou wrote:
> > When a server becomes unstable due to overloading or intermittent
> > partitioning, it may miss some heartbeats and then starts election with
> > a new term, which would disrupt the otherwise healthy
OVS allows overlapping megaflows, as long as the actions of these
megaflows are equal. However, the current implementation of action
modification relies on flow_lookup instead of ufid, this could result
in looking up a wrong megaflow and make the ukeys and megaflows inconsistent
Just like the
Eelco Chaudron 于2023年6月23日周五 22:31写道：
>
>
> On 15 Jun 2023, at 4:51, Peng He wrote:
>
> > OVS allows overlapping megaflows, as long as the actions of these
> > megaflows are equal. However, the current implementation of action
> > modification relies on flow_lookup instead of ufid, this could
On Thu, Jun 29, 2023 at 10:54 PM Numan Siddique wrote:
>
> On Sun, Jun 18, 2023 at 11:48 AM Han Zhou wrote:
> >
> > This patch achieves zero recompute for VIF updates and deletions in
> > common scenarios. The performance gain for these scenarios is similar to
> > the patch "northd: Incremental
Ilya Maximets 于2023年6月23日周五 20:40写道：
> On 6/23/23 14:20, Eelco Chaudron wrote:
> >
> >
> > On 9 Jun 2023, at 17:03, Peng He wrote:
> >
> >> push_dp_ops only handles delete ops errors but ignores the modify
> >> ops results. It's better to handle all the dp operation errors in
> >> a consistent
On Thu, Jun 29, 2023 at 10:06 PM Numan Siddique wrote:
>
> On Fri, Jun 30, 2023 at 7:01 AM Han Zhou wrote:
> >
> > On Thu, Jun 29, 2023 at 4:57 AM Dumitru Ceara wrote:
> > >
> > > On 6/18/23 08:17, Han Zhou wrote:
> > > > For incremental processing, we need to maintain SB lflow uuids in
> > > >
On Fri, Jun 30, 2023 at 6:35 AM Lucas Martins wrote:
>
> Hi all,
>
> On Thu, Apr 27, 2023 at 7:08 PM Han Zhou wrote:
> >
> >
> >
> > On Thu, Apr 27, 2023 at 10:15 AM Ihar Hrachyshka
wrote:
> > >
> > > On Wed, Apr 19, 2023 at 5:17 AM Lucas Martins
wrote:
> > > >
> > > > Hi Han, all
> > > >
> >
On 7/1/23 01:43, Ilya Maximets wrote:
> On 6/8/23 12:07, Alin Serdean wrote:
>> Ack, I will try to see if I can get GH actions.
>> It would also be better to have everything integrated in one place.
>>
>> I remember the discussion and the PR… I had some comments which never got
>> addressed.
>>
On 6/30/23 08:40, Eelco Chaudron wrote:
>
>
> On 29 Jun 2023, at 17:54, Ilya Maximets wrote:
>
>> On 6/29/23 17:43, Eelco Chaudron wrote:
>>>
>>>
>>> On 22 Jun 2023, at 0:32, Ilya Maximets wrote:
>>>
Current implementation of meters in the userspace datapath takes
the meter lock for
On 6/8/23 12:07, Alin Serdean wrote:
> Ack, I will try to see if I can get GH actions.
> It would also be better to have everything integrated in one place.
>
> I remember the discussion and the PR… I had some comments which never got
> addressed.
>
> Windows is pretty slow when starting
On 6/25/23 19:35, Han Zhou wrote:
> When a server becomes unstable due to overloading or intermittent
> partitioning, it may miss some heartbeats and then starts election with
> a new term, which would disrupt the otherwise healthy cluster formed by
> the rest of the healthy nodes. Such situation
On Fri, Jun 30, 2023 at 2:26 AM Frode Nordahl
wrote:
>
> Hello all,
>
> On Tue, May 30, 2023 at 5:16 PM Felix Huettner
> wrote:
> >
> > Hi Dumitru,
> >
> > On Fri, May 26, 2023 at 01:30:54PM +0200, Dumitru Ceara wrote:
> > > On 5/24/23 09:37, Felix Huettner wrote:
> > > > Hi everyone,
> > >
> >
Chandan Somani writes:
> This will help narrow down spelling errors that are in the
> commit subject
>
> Signed-off-by: Chandan Somani
> ---
> utilities/checkpatch.py | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
> index
Chandan Somani writes:
> This wil lbe useful for correcting possible spelling
> mistakes with ease. Suggestions limited to 3 at first,
> but configurable in the future
>
> Signed-off-by: Chandan Somani
> ---
This is a really useful feature! Thanks!
Acked-by: Aaron Conole
>
Chandan Somani writes:
> A list approach lets us single out each flagged word and
> provide more useful details, like spelling suggestions.
> This will be used in an upcoming patch.
>
> Signed-off-by: Chandan Somani
> ---
> utilities/checkpatch.py | 12 +---
> 1 file changed, 9
On Fri, Jun 30, 2023 at 3:31 AM Frode Nordahl
wrote:
> Hello all,
>
> On Tue, May 30, 2023 at 5:16 PM Felix Huettner
> wrote:
> >
> > Hi Dumitru,
> >
> > On Fri, May 26, 2023 at 01:30:54PM +0200, Dumitru Ceara wrote:
> > > On 5/24/23 09:37, Felix Huettner wrote:
> > > > Hi everyone,
> > >
> > >
This is prep for adding a different OVS_ACTION_ATTR_ enum value. This
action, OVS_ACTION_ATTR_DEC_TTL, is not actually implemented. However,
to make -Werror happy we must add a case to all existing switches.
Signed-off-by: Eric Garver
---
include/linux/openvswitch.h | 1 +
lib/dpif-netdev.c
Signed-off-by: Eric Garver
---
tests/system-traffic.at | 30 ++
1 file changed, 30 insertions(+)
diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index 4c378e1d02b0..31c1ef46d561 100644
--- a/tests/system-traffic.at
+++ b/tests/system-traffic.at
@@
Signed-off-by: Eric Garver
---
tests/system-common-macros.at | 4
1 file changed, 4 insertions(+)
diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at
index 0077a8609c02..afc0df00a329 100644
--- a/tests/system-common-macros.at
+++ b/tests/system-common-macros.at
@@
Probe the datapath implementation for support of OVS_ACTION_ATTR_DROP.
Also add a new test case.
v2:
- new patch (1) to fix build (switch cases)
- fixed check-system-userspace
Eric Garver (4):
dpif: stub out unimplemented action OVS_ACTION_ATTR_DEC_TTL
dpif: probe support for
Signed-off-by: Eric Garver
---
include/linux/openvswitch.h | 2 +-
lib/dpif.c | 6 --
lib/dpif.h | 1 -
ofproto/ofproto-dpif.c | 34 --
4 files changed, 33 insertions(+), 10 deletions(-)
diff --git
On Fri, Jun 30, 2023 at 1:07 AM Dumitru Ceara wrote:
>
> On 6/29/23 08:42, Han Zhou wrote:
> > If the ovs port used as output_port in mirror is deleted (either by
> > mistake or intentionally), ovn-controller would crash in the
> > check_and_update_interface_table() when trying to sync the mirror
On Fri, Jun 30, 2023 at 12:33 PM Ilya Maximets wrote:
>
> On 6/30/23 18:13, Ilya Maximets wrote:
> > On 6/30/23 00:45, Mike Pattrick wrote:
> >> On Thu, Jun 29, 2023 at 3:10 PM Ilya Maximets wrote:
> >>>
> >>> On 6/9/23 17:05, Mike Pattrick wrote:
> Several xlate actions used in recursive
Thanks. I'll look through the resources and submit a new, correctly formatted
patch soon.
From: Ilya Maximets
Sent: Friday, June 30, 2023 3:39 AM
To: Sayali Naval (sanaval) ; d...@openvswitch.org
Cc: i.maxim...@ovn.org
Subject: Re: [ovs-dev] [PATCH v1] bridge
On 6/30/23 12:31, Aaron Conole wrote:
Flavio Leitner writes:
Today the exit code refers to the execution of the change
in the database. However, when not using parameter --no-wait
(default), the ovs-vsctl also checks if OVSDB transactions
are successfully recorded and reload by
On 6/30/23 18:13, Ilya Maximets wrote:
> On 6/30/23 00:45, Mike Pattrick wrote:
>> On Thu, Jun 29, 2023 at 3:10 PM Ilya Maximets wrote:
>>>
>>> On 6/9/23 17:05, Mike Pattrick wrote:
Several xlate actions used in recursive translation currently store a
large amount of information on the
On 6/30/23 00:45, Mike Pattrick wrote:
> On Thu, Jun 29, 2023 at 3:10 PM Ilya Maximets wrote:
>>
>> On 6/9/23 17:05, Mike Pattrick wrote:
>>> Several xlate actions used in recursive translation currently store a
>>> large amount of information on the stack. This can result in handler
>>> threads
Flavio Leitner writes:
> Today the exit code refers to the execution of the change
> in the database. However, when not using parameter --no-wait
> (default), the ovs-vsctl also checks if OVSDB transactions
> are successfully recorded and reload by ovs-vswitchd. In this
> case, an error message
On 6/30/23 16:54, Adrian Moreno wrote:
>
>
> On 6/30/23 14:35, Ilya Maximets wrote:
>> On 6/30/23 14:23, Adrian Moreno wrote:
>>>
>>>
>>> On 6/30/23 13:40, Ilya Maximets wrote:
On 6/30/23 12:39, Adrian Moreno wrote:
>
>
> On 6/14/23 23:07, Terry Wilson wrote:
>> This adds a
On Fri, Jun 30, 2023 at 5:53 AM Dumitru Ceara wrote:
>
> On 6/28/23 08:22, Han Zhou wrote:
> > The test case intended to ensure there are no more than 3 failures in 10
> > runs. However, it used "break" to exit the loop whenever a failure is
> > encountered, end up with at most 1 failure and so
On 6/30/23 14:35, Ilya Maximets wrote:
On 6/30/23 14:23, Adrian Moreno wrote:
On 6/30/23 13:40, Ilya Maximets wrote:
On 6/30/23 12:39, Adrian Moreno wrote:
On 6/14/23 23:07, Terry Wilson wrote:
This adds a Python version of the async DNS support added in:
771680d96 DNS: Add basic
Today the exit code refers to the execution of the change
in the database. However, when not using parameter --no-wait
(default), the ovs-vsctl also checks if OVSDB transactions
are successfully recorded and reload by ovs-vswitchd. In this
case, an error message is printed if there is a problem
On 6/30/23 09:25, Frode Nordahl wrote:
> Hello all,
>
> On Tue, May 30, 2023 at 5:16 PM Felix Huettner
> wrote:
>>
>> Hi Dumitru,
>>
>> On Fri, May 26, 2023 at 01:30:54PM +0200, Dumitru Ceara wrote:
>>> On 5/24/23 09:37, Felix Huettner wrote:
Hi everyone,
>>>
>>> Hi Felix,
>>>
Hi,
It wasn't clear to me from the responses whether there was an action item -
is something needed from the submitte? )Or is the patch under consideration?
cheers,
-Thomas
On Wed, May 24, 2023 at 9:08 AM Adrian Moreno wrote:
>
>
> On 5/23/23 22:26, Ilya Maximets wrote:
> > On 5/23/23
Hi all,
On Thu, Apr 27, 2023 at 7:08 PM Han Zhou wrote:
>
>
>
> On Thu, Apr 27, 2023 at 10:15 AM Ihar Hrachyshka wrote:
> >
> > On Wed, Apr 19, 2023 at 5:17 AM Lucas Martins wrote:
> > >
> > > Hi Han, all
> > >
> > > On Mon, Apr 17, 2023 at 8:02 PM Han Zhou wrote:
> > > >
> > > >
> > > >
> >
On Fri, Jun 30, 2023 at 08:29:58AM -0400, Eric Garver wrote:
> On Fri, Jun 30, 2023 at 11:47:04AM +0200, Simon Horman wrote:
> > On Thu, Jun 29, 2023 at 04:30:05PM -0400, Eric Garver wrote:
> > > This adds an explicit drop action. This is used by OVS to drop packets
> > > for which it cannot
Frode Nordahl, Jun 30, 2023 at 09:25:
> Below are some proposals for dates and times, please respond with a
> prioritized list of what works best for you and we'll try to land on a
> single date/time for a first meeting:
> Wednesday July 5th 13:00 UTC
> Tuesday July 11th 13:30 UTC
> Wednesday July
On 6/30/23 14:33, Eric Garver wrote:
> On Fri, Jun 30, 2023 at 08:57:15AM +0200, Eelco Chaudron wrote:
>>
>>
>> On 29 Jun 2023, at 22:30, Eric Garver wrote:
>>
>>> Probe the datapath implementation for support of OVS_ACTION_ATTR_DROP.
>>> Also add a new test case.
>>
>>
>> Hi Eric,
>>
>> Thanks
On 6/28/23 08:22, Han Zhou wrote:
> The test case intended to ensure there are no more than 3 failures in 10
> runs. However, it used "break" to exit the loop whenever a failure is
> encountered, end up with at most 1 failure and so the final check for
> the failure count will always pass. It
On 30 Jun 2023, at 14:33, Eric Garver wrote:
> On Fri, Jun 30, 2023 at 08:57:15AM +0200, Eelco Chaudron wrote:
>>
>>
>> On 29 Jun 2023, at 22:30, Eric Garver wrote:
>>
>>> Probe the datapath implementation for support of OVS_ACTION_ATTR_DROP.
>>> Also add a new test case.
>>
>>
>> Hi Eric,
>>
On 6/30/23 14:23, Adrian Moreno wrote:
>
>
> On 6/30/23 13:40, Ilya Maximets wrote:
>> On 6/30/23 12:39, Adrian Moreno wrote:
>>>
>>>
>>> On 6/14/23 23:07, Terry Wilson wrote:
This adds a Python version of the async DNS support added in:
771680d96 DNS: Add basic support for
On Fri, Jun 30, 2023 at 08:57:15AM +0200, Eelco Chaudron wrote:
>
>
> On 29 Jun 2023, at 22:30, Eric Garver wrote:
>
> > Probe the datapath implementation for support of OVS_ACTION_ATTR_DROP.
> > Also add a new test case.
>
>
> Hi Eric,
>
> Thanks for the patch, but I get quite some build
On Fri, Jun 30, 2023 at 11:47:04AM +0200, Simon Horman wrote:
> On Thu, Jun 29, 2023 at 04:30:05PM -0400, Eric Garver wrote:
> > This adds an explicit drop action. This is used by OVS to drop packets
> > for which it cannot determine what to do. An explicit action in the
> > kernel allows passing
On 6/30/23 13:40, Ilya Maximets wrote:
On 6/30/23 12:39, Adrian Moreno wrote:
On 6/14/23 23:07, Terry Wilson wrote:
This adds a Python version of the async DNS support added in:
771680d96 DNS: Add basic support for asynchronous DNS resolving
The above version uses the unbound C library,
On 6/30/23 12:39, Adrian Moreno wrote:
>
>
> On 6/14/23 23:07, Terry Wilson wrote:
>> This adds a Python version of the async DNS support added in:
>>
>> 771680d96 DNS: Add basic support for asynchronous DNS resolving
>>
>> The above version uses the unbound C library, and this
>> implimentation
On 6/30/23 10:00, Robin Jarry wrote:
> Hi Ilya,
>
> Ilya Maximets, Jun 29, 2023 at 23:57:
>>> +if (flags && ovsrcu_get(void *, >hw_info.offload_data)) {
>>
>> We probbaly shouldn't use the offload_data outside of netdev-offload
>> modules. Simply checking netdev_is_flow_api_enabled() should
On 6/30/23 12:34, Eelco Chaudron wrote:
On 5 Jun 2023, at 8:25, Adrian Moreno wrote:
On 6/5/23 08:22, Adrian Moreno wrote:
On 6/2/23 16:13, Adrian Moreno wrote:
There are currently two issues that limit our ability to configure QoS
on certain cards in linux:
1) Firstly, the maximum
On 6/30/23 12:46, Ilya Maximets wrote:
On 6/30/23 03:38, Thomas Bachman wrote:
Hi,
It wasn't clear to me from the responses whether there was an action item - is
something needed from the submitte? )Or is the patch under consideration?
Hi. I replied to the patch now. The patch itself
On 6/30/23 03:38, Thomas Bachman wrote:
> Hi,
>
> It wasn't clear to me from the responses whether there was an action item -
> is something needed from the submitte? )Or is the patch under consideration?
Hi. I replied to the patch now. The patch itself has extra
spacing between lines, so it
On 6/14/23 23:07, Terry Wilson wrote:
This adds a Python version of the async DNS support added in:
771680d96 DNS: Add basic support for asynchronous DNS resolving
The above version uses the unbound C library, and this
implimentation uses the SWIG-wrapped Python version of that.
In the
On 6/21/23 20:43, Sayali Naval (sanaval) via dev wrote:
> A gentle reminder to take a look at this patch.
Hi. Sorry for a late reply. But this patch came in strangely formatted,
so it wasn't recognized as a patch by any of our systems.
The patch has extra spacing after every line that makes it
On 5 Jun 2023, at 8:25, Adrian Moreno wrote:
> On 6/5/23 08:22, Adrian Moreno wrote:
>>
>> On 6/2/23 16:13, Adrian Moreno wrote:
>>> There are currently two issues that limit our ability to configure QoS
>>> on certain cards in linux:
>>>
>>> 1) Firstly, the maximum link speed (which is used as
On Thu, Jun 29, 2023 at 04:30:05PM -0400, Eric Garver wrote:
> This adds an explicit drop action. This is used by OVS to drop packets
> for which it cannot determine what to do. An explicit action in the
> kernel allows passing the reason _why_ the packet is being dropped. We
> can then use perf
On 6/29/23 08:42, Han Zhou wrote:
> If the ovs port used as output_port in mirror is deleted (either by
> mistake or intentionally), ovn-controller would crash in the
> check_and_update_interface_table() when trying to sync the mirror port
> configuration. e.g.:
>
> 0 0x00449d6e in
Hi Ilya,
Ilya Maximets, Jun 29, 2023 at 23:57:
> > +if (flags && ovsrcu_get(void *, >hw_info.offload_data)) {
>
> We probbaly shouldn't use the offload_data outside of netdev-offload
> modules. Simply checking netdev_is_flow_api_enabled() should be
> enough. Since both features require
On Fri, Jun 30, 2023 at 09:25:47AM +0200, Frode Nordahl wrote:
> Hello all,
>
> On Tue, May 30, 2023 at 5:16 PM Felix Huettner
> wrote:
> >
> > Hi Dumitru,
> >
> > On Fri, May 26, 2023 at 01:30:54PM +0200, Dumitru Ceara wrote:
> > > On 5/24/23 09:37, Felix Huettner wrote:
> > > > Hi everyone,
> >
Hello all,
On Tue, May 30, 2023 at 5:16 PM Felix Huettner
wrote:
>
> Hi Dumitru,
>
> On Fri, May 26, 2023 at 01:30:54PM +0200, Dumitru Ceara wrote:
> > On 5/24/23 09:37, Felix Huettner wrote:
> > > Hi everyone,
> >
> > Hi Felix,
> >
> > >
> > > Ilya mentioned to me that you will want to bring
On 29 Jun 2023, at 22:30, Eric Garver wrote:
> Probe the datapath implementation for support of OVS_ACTION_ATTR_DROP.
> Also add a new test case.
Hi Eric,
Thanks for the patch, but I get quite some build failures on missing switch
cases.
Can you take a look? If you build with the
On 29 Jun 2023, at 17:54, Ilya Maximets wrote:
> On 6/29/23 17:43, Eelco Chaudron wrote:
>>
>>
>> On 22 Jun 2023, at 0:32, Ilya Maximets wrote:
>>
>>> Current implementation of meters in the userspace datapath takes
>>> the meter lock for every packet batch. If more than one thread
>>> hits
68 matches
Mail list logo
