Re: [ovs-dev] [PATCH v6 3/3] userspace: Add Generic Segmentation Offloading.

On 10/31/23 20:51, Mike Pattrick wrote: > From: Flavio Leitner > > This provides a software implementation in the case > the egress netdev doesn't support segmentation in hardware. > > The challenge here is to guarantee packet ordering in the > original batch that may be full of TSO packets.

Re: [ovs-dev] [PATCH v6 2/3] userspace: Respect tso/gso segment size.

On 10/31/23 20:51, Mike Pattrick wrote: > From: Flavio Leitner > > Currently OVS will calculate the segment size based on the > MTU of the egress port. That usually happens to be correct > when the ports share the same MTU, but that is not always true. > > Therefore, if the segment size is

Re: [ovs-dev] [PATCH v6 1/3] netdev-linux: Use ethtool to detect offload support.

On 10/31/23 20:51, Mike Pattrick wrote: > Currently when userspace-tso is enabled, netdev-linux interfaces will > indicate support for all offload flags regardless of interface > configuration. This patch checks for which offload features are enabled > during netdev construction. > >

Re: [ovs-dev] [PATCH] python: idl: Handle monitor_canceled

Bleep bloop. Greetings Terry Wilson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: The subject summary should end with a dot. Subject: python: idl: Handle

Re: [ovs-dev] [PATCH] python: idl: Handle monitor_canceled

On 11/16/23 23:16, Terry Wilson wrote: > Currently python-ovs claims to be "db change aware" but does not > parse the "monitor_canceled" notification. Transactions can continue > being made, but the monitor updates will not be sent. Adding a > force_reconnect() upon receiving a "monitor_canceled"

[ovs-dev] [PATCH] python: idl: Handle monitor_canceled

Currently python-ovs claims to be "db change aware" but does not parse the "monitor_canceled" notification. Transactions can continue being made, but the monitor updates will not be sent. Adding a force_reconnect() upon receiving a "monitor_canceled" notification resolves this issue.

Re: [ovs-dev] [PATCH v3 1/1] netdev-offload-dpdk: Fix GRE without a key match.

On 10/31/23 16:14, Salem Sol via dev wrote: > In case there is no match on GRE key, avoid adding the key match item. > > Fixes: 7617d0583c73 ("netdev-offload-dpdk: Add support for matching on gre > fields.") > Signed-off-by: Salem Sol > --- > lib/netdev-offload-dpdk.c | 15 +-- > 1

Re: [ovs-dev] [PATCH] lib/conntrack.c:compatible with nat with no action(direction)

Eelco Chaudron writes: > On 16 Nov 2023, at 11:07, Joseph Zhong wrote: > >> This patch is to avoid generating incorrect conntrack entry >> In a certain use case of conntrack flow that if flow included >> ct(commit, nat) action, but no detail action/direction specified, >> CT will generate

Re: [ovs-dev] [OVN RFC 0/7] OVN IC bugfixes & proposals/questions

On Tue, Jan 24, 2023 at 8:00 AM Ilya Maximets wrote: > > On 1/24/23 14:12, Vladislav Odintsov wrote: > > Hi Ilya, > > > > could you please take a look on this? > > Maybe you can advice any direction how to investigate this issue? > > > > Thanks in advance. > > > > Regards, > > Vladislav Odintsov

Re: [ovs-dev] [PATCH ovn v2 04/18] northd: Move router ports SB PB options sync to sync_to_sb_pb node.

On Wed, Nov 15, 2023 at 1:24 AM Han Zhou wrote: > > On Tue, Nov 14, 2023 at 9:40 PM Han Zhou wrote: > > > > > > > > On Thu, Oct 26, 2023 at 11:15 AM wrote: > > > > > > From: Numan Siddique > > > > > > It also moves the logical router port IPv6 prefix delegation > > > updates to "sync-from-sb"

Re: [ovs-dev] [PATCH ovn v2 00/18] northd lflow incremental processing

On Thu, Nov 16, 2023 at 2:54 PM Han Zhou wrote: > > On Wed, Nov 15, 2023 at 7:32 PM Numan Siddique wrote: > > > > On Wed, Nov 15, 2023 at 2:59 AM Han Zhou wrote: > > > > > > On Thu, Oct 26, 2023 at 11:12 AM wrote: > > > > > > > > From: Numan Siddique > > > > > > > > This patch series adds

Re: [ovs-dev] [PATCH ovn v3 0/2] Stabilize CI by pinning container, runner and Python versions.

On 11/16/23 12:35, Ales Musil wrote: On Thu, Nov 16, 2023 at 6:26 PM Dumitru Ceara > wrote: All of the above were changed to track the latest available releases. Initially that seemed like a good idea but in practice, a new release would potentially

Re: [ovs-dev] [PATCH v6 1/1] ofproto-dpif-trace: Improve conjunctive match tracing.

On 11/15/23 10:47, Nobuhiro MIKI wrote: > A conjunctive flow consists of two or more multiple flows with > conjunction actions. When input to the ofproto/trace command > matches a conjunctive flow, it outputs flows of all dimensions. > > Acked-by: Simon Horman > Signed-off-by: Nobuhiro MIKI >

Re: [ovs-dev] [PATCH v5] ovs-ofctl: Implement compose-packet --bare [--bad-csum].

On 11/15/23 17:42, Simon Horman wrote: > On Tue, Nov 14, 2023 at 05:59:37PM +, Ihar Hrachyshka wrote: >> With --bare, it will produce a bare hexified payload with no spaces or >> offset indicators inserted, which is useful in tests to produce frames >> to pass to e.g. `ovs-ofctl receive`. >>

Re: [ovs-dev] [PATCH ovn v2 00/18] northd lflow incremental processing

On Wed, Nov 15, 2023 at 7:32 PM Numan Siddique wrote: > > On Wed, Nov 15, 2023 at 2:59 AM Han Zhou wrote: > > > > On Thu, Oct 26, 2023 at 11:12 AM wrote: > > > > > > From: Numan Siddique > > > > > > This patch series adds incremental processing in the lflow engine > > > node to handle changes

Re: [ovs-dev] [PATCH ovn v3 2/2] ci: Pin Python, Fedora and Ubuntu runner versions.

On 11/16/23 18:34, Ales Musil wrote: > On Thu, Nov 16, 2023 at 6:26 PM Dumitru Ceara wrote: > >> We initially thought always using the latest releases would be more >> maintainable because we didn't have to bump versions manually. It turns >> out that it's the opposite, CI suddenly starts to

Re: [ovs-dev] [PATCH ovn v3 0/2] Stabilize CI by pinning container, runner and Python versions.

On Thu, Nov 16, 2023 at 6:26 PM Dumitru Ceara wrote: > All of the above were changed to track the latest available releases. > Initially that seemed like a good idea but in practice, a new release would > potentially (silently) cause CI runs that used to pass on given stable > versions to

Re: [ovs-dev] [PATCH ovn v3 2/2] ci: Pin Python, Fedora and Ubuntu runner versions.

On Thu, Nov 16, 2023 at 6:26 PM Dumitru Ceara wrote: > We initially thought always using the latest releases would be more > maintainable because we didn't have to bump versions manually. It turns > out that it's the opposite, CI suddenly starts to fail on versions where > it used to pass. > >

[ovs-dev] [PATCH ovn v3 2/2] ci: Pin Python, Fedora and Ubuntu runner versions.

We initially thought always using the latest releases would be more maintainable because we didn't have to bump versions manually. It turns out that it's the opposite, CI suddenly starts to fail on versions where it used to pass. To avoid ever changing tools in our CI due to newer releases of

[ovs-dev] [PATCH ovn v3 1/2] ovs: Bump submodule to include E721 fixes.

Specifically the following commit: fdbf0bb2aed5 ("flake8: Fix E721 check failures.") Signed-off-by: Dumitru Ceara --- ovs |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovs b/ovs index 19770fc307..fdbf0bb2ae 16 --- a/ovs +++ b/ovs @@ -1 +1 @@ -Subproject commit

[ovs-dev] [PATCH ovn v3 0/2] Stabilize CI by pinning container, runner and Python versions.

All of the above were changed to track the latest available releases. Initially that seemed like a good idea but in practice, a new release would potentially (silently) cause CI runs that used to pass on given stable versions to unexpectedly start failing. To address that this series pins all

Re: [ovs-dev] [PATCH ovn v2] tests: Remove broken "feature inactivity probe" test.

On 11/16/23 16:21, Xavier Simonart wrote: > Hi Dumitru > > Looks good to me, thanks. > Acked-by: Xavier Simonart > Thanks! Applied and backported down to 22.03. One flaky test less to worry about! :) > Thanks > Xavier > > On Thu, Nov 16, 2023 at 2:54 PM Dumitru Ceara wrote: >> >> The test

Re: [ovs-dev] [PATCH v2] mcast-snooping: Store IGMP/MLD protocol version.

On 16 Nov 2023, at 15:58, Eelco Chaudron wrote: > On 16 Nov 2023, at 15:08, Mohammad Heib wrote: > >> Store the igmp/mld protocol version into the >> mcast_group internally. >> >> This can be used by ovs consumers to update >> about the igmp/mld version of each group. >> >> Signed-off-by:

Re: [ovs-dev] [PATCH ovn v2] tests: Remove broken "feature inactivity probe" test.

Hi Dumitru Looks good to me, thanks. Acked-by: Xavier Simonart Thanks Xavier On Thu, Nov 16, 2023 at 2:54 PM Dumitru Ceara wrote: > > The test incorrectly assumed that "ovn-nbctl --wait=hv sync" will always > send an OpenFlow barrier to ovs-vswitchd. That doesn't happen unless > there are

[ovs-dev] [PATCH v4 2/3] dpctl, ovs-ofctl: Unify parsing of ct-flush arguments.

In order to make the command extensible unify the arguments parsing into single function. This will be later on used for the mark and labels arguments. Signed-off-by: Ales Musil --- v4: Rebase on top of current master. v3: Rebase on top of current master. Fix the system-tests failure. ---

[ovs-dev] [PATCH v4 3/3] openflow: Allow CT flush to match on mark and labels.

Extend the current NX_CT_FLUSH with four additional fields, that allow to match on CT entry "mark" or "labels". This is encoded as separate TLV values which is backward compatible. Versions that do not support them will simply ignore it. Extend also the ovs-dpctl and ovs-ofctl command line tools

[ovs-dev] [PATCH v4 0/3] Extend the CT flush with mark and labels fields

The CT flush is not capable of partial flush based on the touples and zone combinations. Extend it so it also accepts mark and labels. As part of this series unify parsing of arguments in dpctl and ovs-ofctl for the ct flush command. Ales Musil (3): ofp-prop: Add helper for parsing and storing

[ovs-dev] [PATCH v4 1/3] ofp-prop: Add helper for parsing and storing of ovs_u128.

Add helper methods that allow us to store and parse the ovs_u128 type. Signed-off-by: Ales Musil --- v4: Rebase on top of current master. Use ofprop_put instead of manual ofpbuf_start/put/end. v3: Rebase on top of current master. v2: Add missing ofpprop_parse_be128() function. ---

Re: [ovs-dev] [PATCH v2] mcast-snooping: Store IGMP/MLD protocol version.

On 16 Nov 2023, at 15:08, Mohammad Heib wrote: > Store the igmp/mld protocol version into the > mcast_group internally. > > This can be used by ovs consumers to update > about the igmp/mld version of each group. > > Signed-off-by: Mohammad Heib Hi Mohammad, Thanks for the patch, I have not

Re: [ovs-dev] [PATCH v3 3/3] openflow: Allow CT flush to match on mark and labels.

On 11/2/23 10:37, Ales Musil wrote: > > > On Wed, Oct 25, 2023 at 12:25 AM Ilya Maximets > wrote: > > On 10/18/23 08:28, Ales Musil wrote: > > Extend the current NX_CT_FLUSH with four additional fields, > > that allow to match on CT entry "mark" or

Re: [ovs-dev] [PATCH] mcast-snooping: store IGMP/MLD protocol version

Bleep bloop. Greetings Mohammad Heib, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: The subject summary should start with a capital. WARNING: The subject summary should

[ovs-dev] [PATCH v2] mcast-snooping: Store IGMP/MLD protocol version.

Store the igmp/mld protocol version into the mcast_group internally. This can be used by ovs consumers to update about the igmp/mld version of each group. Signed-off-by: Mohammad Heib --- lib/mcast-snooping.c | 16 +--- lib/mcast-snooping.h | 9 ++---

[ovs-dev] [PATCH] mcast-snooping: store IGMP/MLD protocol version

Store the igmp/mld protocol version into the mcast_group internally. This can be used by ovs consumers to update about the igmp/mld version of each group. Signed-off-by: Mohammad Heib --- lib/mcast-snooping.c | 15 --- lib/mcast-snooping.h | 9 ++---

Re: [ovs-dev] [PATCH] lib/conntrack.c:compatible with nat with no action(direction)

On 16 Nov 2023, at 11:07, Joseph Zhong wrote: > This patch is to avoid generating incorrect conntrack entry > In a certain use case of conntrack flow that if flow included > ct(commit, nat) action, but no detail action/direction specified, > CT will generate incorrect conntrack entry. > For

Re: [ovs-dev] [PATCH] lib/conntrack.c:compatible with nat with no action(direction)

Bleep bloop. Greetings Joseph Zhong, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: corrupt patch at line 10 error: could not build fake ancestor hint: Use 'git am

Re: [ovs-dev] [PATCH ovn] tests: Fix race in "feature inactivity probe" test.

On 11/16/23 12:59, Dumitru Ceara wrote: > On 11/16/23 12:49, Xavier Simonart wrote: >> Hi Dumitru >> > > Hi Xavier, > >> Thanks for the patch. It clearly decreases the failure count. >> I am afraid however it does not fix all potential issues. >> My understanding is the following: >> The test

[ovs-dev] [PATCH ovn v2] tests: Remove broken "feature inactivity probe" test.

The test incorrectly assumed that "ovn-nbctl --wait=hv sync" will always send an OpenFlow barrier to ovs-vswitchd. That doesn't happen unless there are other OpenFlow (rule or group) changes that need to be programmed in the datapath. An initial attempt to fix this [0] uncovered the fact that

[ovs-dev] [PATCH] lib/conntrack.c:compatible with nat with no action(direction)

This patch is to avoid generating incorrect conntrack entry In a certain use case of conntrack flow that if flow included ct(commit, nat) action, but no detail action/direction specified, CT will generate incorrect conntrack entry. For example, add below flow:

Re: [ovs-dev] [PATCH ovn v2 0/3] Stabilize CI by pinning container, runner and Python versions.

On 11/16/23 13:44, Ales Musil wrote: > On Thu, Nov 16, 2023 at 1:40 PM Dumitru Ceara wrote: > >> On 11/16/23 13:05, Ilya Maximets wrote: >>> On 11/16/23 10:17, Dumitru Ceara wrote: On 11/16/23 10:02, Dumitru Ceara wrote: > On 11/16/23 09:51, Dumitru Ceara wrote: >> On 11/16/23

Re: [ovs-dev] [PATCH ovn v2 0/3] Stabilize CI by pinning container, runner and Python versions.

On Thu, Nov 16, 2023 at 1:40 PM Dumitru Ceara wrote: > On 11/16/23 13:05, Ilya Maximets wrote: > > On 11/16/23 10:17, Dumitru Ceara wrote: > >> On 11/16/23 10:02, Dumitru Ceara wrote: > >>> On 11/16/23 09:51, Dumitru Ceara wrote: > On 11/16/23 09:44, Ales Musil wrote: > > On Thu, Nov

Re: [ovs-dev] [PATCH ovn v2 0/3] Stabilize CI by pinning container, runner and Python versions.

On 11/16/23 13:05, Ilya Maximets wrote: > On 11/16/23 10:17, Dumitru Ceara wrote: >> On 11/16/23 10:02, Dumitru Ceara wrote: >>> On 11/16/23 09:51, Dumitru Ceara wrote: On 11/16/23 09:44, Ales Musil wrote: > On Thu, Nov 16, 2023 at 9:34 AM Dumitru Ceara wrote: > >> On 11/16/23

Re: [ovs-dev] [PATCH v2 0/2] Add argument to skip committer signoff check

On Sun, Nov 05, 2023 at 10:38:08AM +0200, Roi Dayan via dev wrote: > Hi, > > This v2 is just adding checkpatch.at case to verify the flag. ... Thanks Roi, I have applied this patch-set. - checkpatch: Add argument to skip committer signoff check.

Re: [ovs-dev] [PATCH ovn v2 0/3] Stabilize CI by pinning container, runner and Python versions.

On 11/16/23 10:17, Dumitru Ceara wrote: > On 11/16/23 10:02, Dumitru Ceara wrote: >> On 11/16/23 09:51, Dumitru Ceara wrote: >>> On 11/16/23 09:44, Ales Musil wrote: On Thu, Nov 16, 2023 at 9:34 AM Dumitru Ceara wrote: > On 11/16/23 00:12, Ilya Maximets wrote: >> On 11/15/23

Re: [ovs-dev] [PATCH] netdev-offload-tc: Fix offload of tunnel key tp_src.

Hi Vladislav, On Wed, Nov 15, 2023 at 04:13:13PM +0300, Vladislav Odintsov wrote: ... > Final flow: >

Re: [ovs-dev] [PATCH ovn] tests: Fix race in "feature inactivity probe" test.

On 11/16/23 12:49, Xavier Simonart wrote: > Hi Dumitru > Hi Xavier, > Thanks for the patch. It clearly decreases the failure count. > I am afraid however it does not fix all potential issues. > My understanding is the following: > The test goal was to ensure ovs does not disconnect the

Re: [ovs-dev] [PATCH ovn] tests: Fix race in "feature inactivity probe" test.

Hi Dumitru Thanks for the patch. It clearly decreases the failure count. I am afraid however it does not fix all potential issues. My understanding is the following: The test goal was to ensure ovs does not disconnect the connections on inactivity probe.There are 4 connections with inactivity

Re: [ovs-dev] [PATCH v2 1/2] mcast-snooping: Test per port explicit flooding.

On Thu, Nov 16, 2023 at 12:32 PM Ilya Maximets wrote: > > +AT_CHECK([ > > +ovs-vsctl set bridge br0 \ > > +datapath_type=dummy \ > > +mcast_snooping_enable=true \ > > +other-config:mcast-snooping-disable-flood-unregistered=false > > Nit: > Not a full review, but in case you're

[ovs-dev] [PATCH v3 3/3] mcast-snooping: Fix comments format.

Capitalize comments and end them with a . when needed. Signed-off-by: David Marchand --- tests/mcast-snooping.at | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/mcast-snooping.at b/tests/mcast-snooping.at index faeb7890d9..890e6aca00 100644 ---

[ovs-dev] [PATCH v3 1/3] mcast-snooping: Test per port explicit flooding.

Various options affect how the mcast snooping module work. When multicast snooping is enabled and a reporter is known, it is still possible to flood associated packets to some other port via the mcast-snooping-flood option. If flooding unregistered traffic is disabled, it is still possible to

[ovs-dev] [PATCH v3 2/3] mcast-snooping: Flush flood and report ports when deleting interfaces.

When a configuration change triggers an interface destruction/creation (like for example, setting ofport_request), a port object may still be referenced as a fport or a rport in the mdb. Before the fix, when flooding multicast traffic: bridge("br0") - 0. priority 32768 NORMAL

Re: [ovs-dev] [PATCH v2 1/2] mcast-snooping: Test per port explicit flooding.

On 11/10/23 18:52, David Marchand wrote: > Various options affect how the mcast snooping module work. > > When multicast snooping is enabled and a reporter is known, it is still > possible to flood associated packets to some other port via the > mcast-snooping-flood option. > > If flooding

Re: [ovs-dev] [PATCH v2 2/2] mcast-snooping: Flush flood and report ports when deleting interfaces.

On 16 Nov 2023, at 12:24, David Marchand wrote: > On Thu, Nov 16, 2023 at 10:38 AM Eelco Chaudron wrote: >>> diff --git a/tests/mcast-snooping.at b/tests/mcast-snooping.at >>> index b5474cf392..1ce31168e8 100644 >>> --- a/tests/mcast-snooping.at >>> +++ b/tests/mcast-snooping.at >>> @@ -207,6

Re: [ovs-dev] [PATCH v2 1/2] mcast-snooping: Test per port explicit flooding.

On 16 Nov 2023, at 12:13, David Marchand wrote: > On Thu, Nov 16, 2023 at 11:57 AM Eelco Chaudron wrote: >> On 10 Nov 2023, at 18:52, David Marchand wrote: >>> +Final flow: unchanged >>> +Megaflow: >>>

Re: [ovs-dev] [PATCH v2 1/2] mcast-snooping: Test per port explicit flooding.

On 16 Nov 2023, at 12:10, David Marchand wrote: > Hello Eelco, > > On Thu, Nov 16, 2023 at 11:57 AM Eelco Chaudron wrote: > > [snip] > >>> +bridge("br0") >>> +- >>> + 0. priority 32768 >>> +NORMAL >>> + -> forwarding to mcast group port >>> + -> forwarding to mcast

Re: [ovs-dev] [PATCH v2 2/2] mcast-snooping: Flush flood and report ports when deleting interfaces.

On Thu, Nov 16, 2023 at 10:38 AM Eelco Chaudron wrote: > > diff --git a/tests/mcast-snooping.at b/tests/mcast-snooping.at > > index b5474cf392..1ce31168e8 100644 > > --- a/tests/mcast-snooping.at > > +++ b/tests/mcast-snooping.at > > @@ -207,6 +207,24 @@ Megaflow: > >

Re: [ovs-dev] [PATCH v2 1/2] mcast-snooping: Test per port explicit flooding.

On Thu, Nov 16, 2023 at 11:57 AM Eelco Chaudron wrote: > On 10 Nov 2023, at 18:52, David Marchand wrote: > > +Final flow: unchanged > > +Megaflow: > > recirc_id=0,eth,udp,in_port=3,dl_src=aa:55:aa:55:00:ff,dl_dst=01:00:5e:01:01:01,nw_dst=224.1.1.1,nw_frag=no > > +]) > > +AT_CHECK([sed -ne

Re: [ovs-dev] [PATCH v2 1/2] mcast-snooping: Test per port explicit flooding.

Hello Eelco, On Thu, Nov 16, 2023 at 11:57 AM Eelco Chaudron wrote: [snip] > > +bridge("br0") > > +- > > + 0. priority 32768 > > +NORMAL > > + -> forwarding to mcast group port > > + -> forwarding to mcast flood port > > + > > +Final flow: unchanged > > +Megaflow: > >

Re: [ovs-dev] [PATCH v4 1/6] Add global option for JSON output to ovs-appctl.

Bleep bloop. Greetings Jakob Meng, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator WARNING: Line lacks whitespace around operator

Re: [ovs-dev] [PATCH v2 1/2] mcast-snooping: Test per port explicit flooding.

On 10 Nov 2023, at 18:52, David Marchand wrote: > Various options affect how the mcast snooping module work. > > When multicast snooping is enabled and a reporter is known, it is still > possible to flood associated packets to some other port via the > mcast-snooping-flood option. > > If

Re: [ovs-dev] [RFC v3 0/4] Add global option to output JSON from ovs-appctl cmds.

Thank you again for all your input! Your comments have been incorporated into a new patch series v4: https://patchwork.ozlabs.org/project/openvswitch/list/?series=382459=both=* On 25.10.23 11:37, jm...@redhat.com wrote: > From: Jakob Meng > > Add global option to output JSON from ovs-appctl

[ovs-dev] [PATCH v4 6/6] unixctl: Pass output format as command args via JSON-RPC API.

From: Jakob Meng A previous patch had changed the JSON-RPC API in lib/unixctl.* (and its Python counterpart) in order to allow transporting the requested output format from ovs-xxx tools to ovs-vswitchd across unix sockets: The meaning of 'method' and 'params' had be changed: 'method' would be

[ovs-dev] [PATCH v4 2/6] python: Add global option for JSON output to Python tools.

From: Jakob Meng This patch introduces support for different output formats to the Python code, as did the previous commit for ovs-xxx tools like 'ovs-appctl --format json dpif/show'. In particular, tests/appctl.py gains a global option '-f,--format' which allows users to request JSON instead of

[ovs-dev] [PATCH v4 4/6] ofproto: Add JSON output for 'dpif/show' command.

From: Jakob Meng The 'dpif/show' command now supports machine-readable JSON output in addition to the plain-text output for humans. An example would be: ovs-appctl --format json dpif/show Reported-at: https://bugzilla.redhat.com/1824861 Signed-off-by: Jakob Meng --- ofproto/ofproto-dpif.c

[ovs-dev] [PATCH v4 5/6] appctl: Add option '--pretty' for pretty-printing JSON output.

From: Jakob Meng Signed-off-by: Jakob Meng --- NEWS | 3 +++ lib/unixctl.c | 4 ++-- lib/unixctl.h | 2 +- tests/pmd.at | 2 +- utilities/ovs-appctl.c | 19 +-- 5 files changed, 24 insertions(+), 6 deletions(-) diff --git

[ovs-dev] [PATCH v4 1/6] Add global option for JSON output to ovs-appctl.

From: Jakob Meng For monitoring systems such as Prometheus it would be beneficial if OVS would expose statistics in a machine-readable format. This patch introduces support for different output formats to ovs-xxx tools. They gain a global option '-f,--format' which allows users to request JSON

[ovs-dev] [PATCH v4 0/6] Add global option to output JSON from ovs-appctl cmds.

From: Jakob Meng This patch series builds upon [0] and brings the following changes: * Last patch in series shows how output format and other args could be passed via JSON-RPC API without the indirection introduced in the first patch (at the cost of inferiour error handling) * By default, the

Re: [ovs-dev] [PATCH ovn] tests: Fix race in "feature inactivity probe" test.

On Wed, Nov 15, 2023 at 2:40 PM Dumitru Ceara wrote: > The test incorrectly assumed that "ovn-nbctl --wait=hv sync" will always > send an OpenFlow barrier to ovs-vswitchd. That doesn't happen unless > there are other OpenFlow (rule or group) changes that need to be > programmed in the datapath.

Re: [ovs-dev] [PATCH v2 2/2] mcast-snooping: Flush flood and report ports when deleting interfaces.

On 10 Nov 2023, at 18:52, David Marchand wrote: > When a configuration change triggers an interface destruction/creation > (like for example, setting ofport_request), a port object may still be > referenced as a fport or a rport in the mdb. > > Before the fix, when flooding multicast traffic:

Re: [ovs-dev] [PATCH ovn v2 0/3] Stabilize CI by pinning container, runner and Python versions.

On 11/16/23 10:02, Dumitru Ceara wrote: > On 11/16/23 09:51, Dumitru Ceara wrote: >> On 11/16/23 09:44, Ales Musil wrote: >>> On Thu, Nov 16, 2023 at 9:34 AM Dumitru Ceara wrote: >>> On 11/16/23 00:12, Ilya Maximets wrote: > On 11/15/23 22:20, Mark Michelson wrote: >> On 11/15/23

Re: [ovs-dev] [PATCH ovn v2 0/3] Stabilize CI by pinning container, runner and Python versions.

On 11/16/23 09:51, Dumitru Ceara wrote: > On 11/16/23 09:44, Ales Musil wrote: >> On Thu, Nov 16, 2023 at 9:34 AM Dumitru Ceara wrote: >> >>> On 11/16/23 00:12, Ilya Maximets wrote: On 11/15/23 22:20, Mark Michelson wrote: > On 11/15/23 12:02, Ilya Maximets wrote: >> On 11/15/23

Re: [ovs-dev] [PATCH ovn v2 0/3] Stabilize CI by pinning container, runner and Python versions.

On 11/16/23 09:44, Ales Musil wrote: > On Thu, Nov 16, 2023 at 9:34 AM Dumitru Ceara wrote: > >> On 11/16/23 00:12, Ilya Maximets wrote: >>> On 11/15/23 22:20, Mark Michelson wrote: On 11/15/23 12:02, Ilya Maximets wrote: > On 11/15/23 17:00, Dumitru Ceara wrote: >> All of the above

Re: [ovs-dev] [PATCH ovn v2 1/3] ovs: Bump submodule to include E721 fixes.

On Wed, Nov 15, 2023 at 5:01 PM Dumitru Ceara wrote: > Specifically the following commit: > fdbf0bb2aed5 ("flake8: Fix E721 check failures.") > > Signed-off-by: Dumitru Ceara > --- > ovs |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ovs b/ovs > index

Re: [ovs-dev] [PATCH v2 2/2] checkpatch.at: Add cases to verify skip committer check.

On 5 Nov 2023, at 9:38, Roi Dayan wrote: > First case without the skip flag should fail. > Second case uses the skip flag and should pass. > > Signed-off-by: Roi Dayan > --- Thanks for adding the testcase. Acked-by: Eelco Chaudron ___ dev

Re: [ovs-dev] [PATCH ovn v2 0/3] Stabilize CI by pinning container, runner and Python versions.

On Thu, Nov 16, 2023 at 9:34 AM Dumitru Ceara wrote: > On 11/16/23 00:12, Ilya Maximets wrote: > > On 11/15/23 22:20, Mark Michelson wrote: > >> On 11/15/23 12:02, Ilya Maximets wrote: > >>> On 11/15/23 17:00, Dumitru Ceara wrote: > All of the above were changed to track the latest

Re: [ovs-dev] [PATCH v2 1/2] checkpatch: Add argument to skip committer signoff check.

On 5 Nov 2023, at 9:38, Roi Dayan wrote: > From: Salem Sol > > Introduce --skip-committer-signoff arg that can be used internally > by groups using gerrit for code reviews and gerrit maintainers could > do the rebase instead of the author or push upstream commits to be > merged through

Re: [ovs-dev] [PATCH ovn v2 0/3] Stabilize CI by pinning container, runner and Python versions.

On 11/16/23 00:12, Ilya Maximets wrote: > On 11/15/23 22:20, Mark Michelson wrote: >> On 11/15/23 12:02, Ilya Maximets wrote: >>> On 11/15/23 17:00, Dumitru Ceara wrote: All of the above were changed to track the latest available releases. Initially that seemed like a good idea but in