Re: [ovs-dev] [PATCH v3 10/11] ci: Allow make check-dpdk to run the MFEX tests.

2023-12-18 Thread Eelco Chaudron
On 15 Dec 2023, at 16:45, Simon Horman wrote: > On Tue, Dec 05, 2023 at 04:00:41PM +0100, Eelco Chaudron wrote: >> The testcase change will make sure the 'MFEX Configuration' test >> will run without the need for scapy and it's auto generated tests. >> In addition we exclude the traffic

Re: [ovs-dev] [PATCH ovn v3 16/16] northd: Add northd change handler for sync_to_sb_lb node.

2023-12-18 Thread Han Zhou
On Mon, Nov 27, 2023 at 6:39 PM wrote: > > From: Numan Siddique > > Any changes to northd engine node due to load balancers > are now handled in 'sync_to_sb_lb' node to sync the changed > load balancers to SB load balancers. > > The logic to sync the SB load balancers is changed a bit and it >

Re: [ovs-dev] [PATCH v3 2/2] netdev-dummy: Add support and test for tso.

2023-12-18 Thread 0-day Robot
Bleep bloop. Greetings Mike Pattrick, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: corrupt patch at line 159 error: could not build fake ancestor hint: Use 'git am

[ovs-dev] [PATCH v3 1/2] dp-packet: Set checksum flags during software TSO.

2023-12-18 Thread Mike Pattrick
When OVS needs to fallback on the software TSO implementation to segment a packet, it currently doesn't guarantee that IP and TCP checksum offload flags are set. However, it is possible that these is required. This is true in the case of dp_netdev_upcall(), which clears these flags. This patch

[ovs-dev] [PATCH v3 2/2] netdev-dummy: Add support and test for tso.

2023-12-18 Thread Mike Pattrick
Test that netdev-dummy is able to send and receive segment offloaded packets. Signed-off-by: Mike Pattrick --- v2: Fix clang build error: mutex needed to access netdev_dummy members v3: Remove use of tcpdump, hexdump, and otherwise clean up test Note, somehow the v3 patch reported as corrupted

Re: [ovs-dev] [PATCH v3 2/2] netdev-dummy: Add support and test for tso.

2023-12-18 Thread Mike Pattrick
These patches apply cleanly on the current master branch for me. I will try to resubmit. -M On Mon, Dec 18, 2023 at 4:21 PM 0-day Robot wrote: > > Bleep bloop. Greetings Mike Pattrick, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some

Re: [ovs-dev] [PATCH ovn v3 15/16] northd: Add a noop handler for northd SB mac binding.

2023-12-18 Thread Han Zhou
On Mon, Dec 18, 2023 at 12:22 PM Numan Siddique wrote: > > On Wed, Dec 13, 2023 at 9:57 AM Dumitru Ceara wrote: > > > > On 11/28/23 03:38, num...@ovn.org wrote: > > > From: Numan Siddique > > > > > > Signed-off-by: Numan Siddique > > > --- > > > northd/inc-proc-northd.c | 9 - > > > 1

Re: [ovs-dev] [PATCH ovn v3 14/16] northd: Add I-P for NB_Global and SB_Global.

2023-12-18 Thread Han Zhou
On Wed, Dec 13, 2023 at 6:47 AM Dumitru Ceara wrote: > > On 11/28/23 03:37, num...@ovn.org wrote: > > From: Numan Siddique > > > > A new engine node "global_config" is added which handles the changes > > to NB_Global an SB_Global tables. It also creates these rows if > > not present. > > > >

Re: [ovs-dev] [PATCH ovn v3 12/16] northd: Add lr_stateful handler for lflow engine node.

2023-12-18 Thread Han Zhou
On Mon, Nov 27, 2023 at 6:38 PM wrote: > > From: Numan Siddique > > Signed-off-by: Numan Siddique > --- > northd/en-lflow.c| 29 +++ > northd/en-lflow.h| 1 + > northd/en-lr-stateful.c | 39 - > northd/en-lr-stateful.h | 26 +++ > northd/inc-proc-northd.c | 3 +- >

Re: [ovs-dev] [PATCH v2] python: idl: Handle monitor_canceled

2023-12-18 Thread 0-day Robot
Bleep bloop. Greetings Terry Wilson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: The subject summary should end with a dot. Subject: python: idl: Handle

[ovs-dev] [PATCH v2] python: idl: Handle monitor_canceled

2023-12-18 Thread Terry Wilson
Currently python-ovs claims to be "db change aware" but does not parse the "monitor_canceled" notification. Transactions can continue being made, but the monitor updates will not be sent. This handles monitor_cancel similarly to how ovsdb-cs currently does. Signed-off-by: Terry Wilson ---

Re: [ovs-dev] [PATCH v3 2/2] netdev-dummy: Add support and test for tso.

2023-12-18 Thread 0-day Robot
Bleep bloop. Greetings Mike Pattrick, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: corrupt patch at line 157 error: could not build fake ancestor hint: Use 'git am

[ovs-dev] [PATCH v3 2/2] netdev-dummy: Add support and test for tso.

2023-12-18 Thread Mike Pattrick
Test that netdev-dummy is able to send and receive segment offloaded packets. Signed-off-by: Mike Pattrick --- v2: Fix clang build error: mutex needed to access netdev_dummy members v3: Remove use of tcpdump, hexdump, and otherwise clean up test --- lib/netdev-dummy.c | 32

[ovs-dev] [PATCH v3 1/2] dp-packet: Set checksum flags during software TSO.

2023-12-18 Thread Mike Pattrick
When OVS needs to fallback on the software TSO implementation to segment a packet, it currently doesn't guarantee that IP and TCP checksum offload flags are set. However, it is possible that these is required. This is true in the case of dp_netdev_upcall(), which clears these flags. This patch

Re: [ovs-dev] [PATCH ovn v3 15/16] northd: Add a noop handler for northd SB mac binding.

2023-12-18 Thread Numan Siddique
On Wed, Dec 13, 2023 at 9:57 AM Dumitru Ceara wrote: > > On 11/28/23 03:38, num...@ovn.org wrote: > > From: Numan Siddique > > > > Signed-off-by: Numan Siddique > > --- > > northd/inc-proc-northd.c | 9 - > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > > diff --git

Re: [ovs-dev] [PATCH ovn] Revert "ovn: add geneve PMTUD support"

2023-12-18 Thread Numan Siddique
On Mon, Dec 18, 2023 at 4:54 AM Dumitru Ceara wrote: > > On 12/18/23 10:52, Dumitru Ceara wrote: > > On 12/16/23 04:48, num...@ovn.org wrote: > >> From: Numan Siddique > >> > >> This reverts commit 450e41e783bfa69e4f9d6c80f6bcb01147d5cfe1. > >> > >> If a packet has to be tunnelled to another

Re: [ovs-dev] [PATCH v3 02/11] ci: Add make check-ovsdb-cluster tests to GitHub action ci.

2023-12-18 Thread Simon Horman
On Mon, Dec 18, 2023 at 11:59:23AM +0100, Eelco Chaudron wrote: > > > On 15 Dec 2023, at 16:23, Simon Horman wrote: > > > On Tue, Dec 05, 2023 at 03:59:31PM +0100, Eelco Chaudron wrote: > >> This patch adds 'make check-ovsdb-cluster' tests to GitHub action ci. > >> In addition, this patch also

Re: [ovs-dev] [PATCH v2 2/2] netdev-dummy: Add support and test for tso.

2023-12-18 Thread Mike Pattrick
On Fri, Dec 15, 2023 at 8:05 PM Ilya Maximets wrote: > > On 12/11/23 16:39, Mike Pattrick wrote: > > Test that netdev-dummy is able to send and recieve segment offloaded > > packets. > > > > Signed-off-by: Mike Pattrick > > > > --- > > v2: Fix clang build error: mutex needed to access

Re: [ovs-dev] [PATCH OVN] Add support to make fdb table local to the chassis.

2023-12-18 Thread Dumitru Ceara
On 12/18/23 16:17, Naveen Yerramneni wrote: > > >> On 18-Dec-2023, at 7:26 PM, Dumitru Ceara wrote: >> >> On 11/30/23 16:32, Dumitru Ceara wrote: >>> On 11/30/23 15:54, Naveen Yerramneni wrote: > On 30-Nov-2023, at 6:06 PM, Dumitru Ceara wrote: > > On 11/30/23 09:45,

Re: [ovs-dev] [PATCH OVN] Add support to make fdb table local to the chassis.

2023-12-18 Thread Naveen Yerramneni
> On 18-Dec-2023, at 7:26 PM, Dumitru Ceara wrote: > > On 11/30/23 16:32, Dumitru Ceara wrote: >> On 11/30/23 15:54, Naveen Yerramneni wrote: >>> >>> On 30-Nov-2023, at 6:06 PM, Dumitru Ceara wrote: On 11/30/23 09:45, Naveen Yerramneni wrote: > > >> On

Re: [ovs-dev] [PATCH v2 1/2] ofproto-dpif-upcall: Resolve checksums before controller upcall.

2023-12-18 Thread Mike Pattrick
On Mon, Dec 18, 2023 at 5:04 AM Eelco Chaudron wrote: > > > > On 15 Dec 2023, at 19:22, Mike Pattrick wrote: > > > On Fri, Dec 15, 2023 at 8:01 AM Eelco Chaudron wrote: > >> > >> > >> > >> On 11 Dec 2023, at 16:39, Mike Pattrick wrote: > >> > >>> Currently dp_netdev_upcall() resolves checksums

[ovs-dev] [PATCH ovn] ovn-ic: handle NB:name updates properly

2023-12-18 Thread Mohammad Heib
When the user updates the NB_GLOBAL.name after registering to IC Databases if the user already has defined chassis as a gateway that will cause ovn-ic instance to run in an infinity loop trying to update the gateways and insert the current gateway to the SB.chassis tables as a remote chassis (we

Re: [ovs-dev] [PATCH ovn v3 16/16] northd: Add northd change handler for sync_to_sb_lb node.

2023-12-18 Thread Dumitru Ceara
On 11/28/23 03:38, num...@ovn.org wrote: > From: Numan Siddique > > Any changes to northd engine node due to load balancers > are now handled in 'sync_to_sb_lb' node to sync the changed > load balancers to SB load balancers. > > The logic to sync the SB load balancers is changed a bit and it >

Re: [ovs-dev] [PATCH ovn v4] northd: forward arp request to lrp snat on.

2023-12-18 Thread Dumitru Ceara
On 12/8/23 16:38, Daniel Ding wrote: > If the router has a snat rule and it's external ip isn't lrp address, > when the arp request from other router for this external ip, will > be drop, because of this external ip use same mac address as lrp, so > can not forward to MC_FLOOD. > > Fixes:

Re: [ovs-dev] [PATCH OVN] Add support to make fdb table local to the chassis.

2023-12-18 Thread Dumitru Ceara
On 11/30/23 16:32, Dumitru Ceara wrote: > On 11/30/23 15:54, Naveen Yerramneni wrote: >> >> >>> On 30-Nov-2023, at 6:06 PM, Dumitru Ceara wrote: >>> >>> On 11/30/23 09:45, Naveen Yerramneni wrote: > On 29-Nov-2023, at 2:24 PM, Dumitru Ceara wrote: > > On 11/29/23 07:45,

Re: [ovs-dev] [PATCH ovn] test: add dedicated test for garp-max-timeout

2023-12-18 Thread Dumitru Ceara
On 12/15/23 18:01, Lorenzo Bianconi wrote: > Introduce a dedicated test for garp-max-timeout knob > For context of the review, I had asked for this "standalone" test for garp-max-timeout so that we can backport the following patch to 21.12:

Re: [ovs-dev] [PATCH v3 02/11] ci: Add make check-ovsdb-cluster tests to GitHub action ci.

2023-12-18 Thread Eelco Chaudron
On 15 Dec 2023, at 16:23, Simon Horman wrote: > On Tue, Dec 05, 2023 at 03:59:31PM +0100, Eelco Chaudron wrote: >> This patch adds 'make check-ovsdb-cluster' tests to GitHub action ci. >> In addition, this patch also makes sure this test and 'make check' do >> not run as root. >> >>

Re: [ovs-dev] [PATCH v2 1/2] ofproto-dpif-upcall: Resolve checksums before controller upcall.

2023-12-18 Thread Eelco Chaudron
On 15 Dec 2023, at 19:22, Mike Pattrick wrote: > On Fri, Dec 15, 2023 at 8:01 AM Eelco Chaudron wrote: >> >> >> >> On 11 Dec 2023, at 16:39, Mike Pattrick wrote: >> >>> Currently dp_netdev_upcall() resolves checksums on all packets, but this >>> isn't strictly needed. The checksums will be

Re: [ovs-dev] [PATCH ovn] Revert "ovn: add geneve PMTUD support"

2023-12-18 Thread Dumitru Ceara
On 12/18/23 10:52, Dumitru Ceara wrote: > On 12/16/23 04:48, num...@ovn.org wrote: >> From: Numan Siddique >> >> This reverts commit 450e41e783bfa69e4f9d6c80f6bcb01147d5cfe1. >> >> If a packet has to be tunnelled to another node and if the physical >> interface used for tunnelling has lower MTU

Re: [ovs-dev] [PATCH ovn] Revert "ovn: add geneve PMTUD support"

2023-12-18 Thread Dumitru Ceara
On 12/16/23 04:48, num...@ovn.org wrote: > From: Numan Siddique > > This reverts commit 450e41e783bfa69e4f9d6c80f6bcb01147d5cfe1. > > If a packet has to be tunnelled to another node and if the physical > interface used for tunnelling has lower MTU than the packet or > if there is a route