Re: [ovs-dev] [PATCH] vconn: Count vconn_sent regardless of log level.

2024-01-05 Thread Cheng Li
On Thu, Jan 04, 2024 at 03:16:59PM +0100, Maximets wrote: > On 1/4/24 14:53, Cheng Li wrote: > > vconn_sent counter is supposed to increase each time send() is > > called, no matter if the vconn log debug is on or off. > > Good catch! But I think the intention was fr it to be increased > each

Re: [ovs-dev] [RFC v3 ovn] ovn: add geneve PMTUD support

2024-01-05 Thread Numan Siddique
On Fri, Dec 22, 2023 at 11:27 AM Lorenzo Bianconi wrote: > > Introduce specif flows for E/W ICMPv{4,6} packets if tunnelled packets > do not fit path MTU. This patch enable PMTUD for East/West Geneve traffic. > > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2241711 > Signed-off-by:

Re: [ovs-dev] [PATCH 20/22] ovsdb-server: Allow user-provided config files.

2024-01-05 Thread Terry Wilson
On Wed, Dec 13, 2023 at 7:05 PM Ilya Maximets wrote: > -/* Clears and replaces 'remotes' and 'dbnames' by a configuration read from > - * 'config_file', which must have been previously written by save_config(). > */ > -static void > +/* Clears and replaces 'remotes' and 'db_conf' by a

Re: [ovs-dev] [PATCH v2] python: idl: Handle monitor_canceled

2024-01-05 Thread Terry Wilson
On Fri, Jan 5, 2024 at 9:56 AM Simon Horman wrote: > > On Mon, Dec 18, 2023 at 05:31:24PM -0600, Terry Wilson wrote: > > Currently python-ovs claims to be "db change aware" but does not > > parse the "monitor_canceled" notification. Transactions can continue > > being made, but the monitor

[ovs-dev] [PATCH] lib/backtrace: Fix error in log_backtrace() documentation.

2024-01-05 Thread Frode Nordahl
The documentation for log_backtrace() states the backtrace is logged at DEBUG level, while in reality it is logged at ERROR level. Fixes: d0b99d38edab ("backtrace: Add log_backtrace()") Signed-off-by: Frode Nordahl --- lib/backtrace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [ovs-dev] [PATCH ovn v3 16/16] northd: Add northd change handler for sync_to_sb_lb node.

2024-01-05 Thread Numan Siddique
On Tue, Dec 19, 2023 at 2:37 AM Han Zhou wrote: > > On Mon, Nov 27, 2023 at 6:39 PM wrote: > > > > From: Numan Siddique > > > > Any changes to northd engine node due to load balancers > > are now handled in 'sync_to_sb_lb' node to sync the changed > > load balancers to SB load balancers. > > >

Re: [ovs-dev] [PATCH v5] system-dpdk: Test with mlx5 devices.

2024-01-05 Thread Kevin Traynor
On 22/11/2023 16:09, David Marchand wrote: > The DPDK unit test only runs if vfio or igb_uio kernel modules are loaded: > on systems with only mlx5, this test is always skipped. > > Besides, the test tries to grab the first device listed by dpdk-devbind.py, > regardless of the PCI device status

Re: [ovs-dev] [PATCH v2] python: idl: Handle monitor_canceled

2024-01-05 Thread Simon Horman
On Mon, Dec 18, 2023 at 05:31:24PM -0600, Terry Wilson wrote: > Currently python-ovs claims to be "db change aware" but does not > parse the "monitor_canceled" notification. Transactions can continue > being made, but the monitor updates will not be sent. This handles > monitor_cancel similarly to

Re: [ovs-dev] [PATCH v3 8/8] python: ovs: flow: Add meter_id to controller.

2024-01-05 Thread Simon Horman
On Fri, Jan 05, 2024 at 12:47:00PM +0100, Adrian Moreno wrote: > Add missing option to controller action. > > Signed-off-by: Adrian Moreno Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH v3 7/8] python: ovs: flow: Make check_pkt_len action a list.

2024-01-05 Thread Simon Horman
On Fri, Jan 05, 2024 at 12:46:59PM +0100, Adrian Moreno wrote: > In general, most actions must be lists since the keys can be repeated. > > Signed-off-by: Adrian Moreno Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH v3 6/8] python: ovs: flow: Add idle_age to openflow flows.

2024-01-05 Thread Simon Horman
On Fri, Jan 05, 2024 at 12:46:58PM +0100, Adrian Moreno wrote: > Add missing key. > > Signed-off-by: Adrian Moreno Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v3 5/8] python: tests: Refactor test_odp section testing.

2024-01-05 Thread Simon Horman
On Fri, Jan 05, 2024 at 12:46:57PM +0100, Adrian Moreno wrote: > Avoid code duplication by moving the section testing code to its own > function. > > Signed-off-by: Adrian Moreno Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH 5/5] ovsdb: transaction: Calculate added/removed from diff.

2024-01-05 Thread Mike Pattrick
On Fri, Jan 5, 2024 at 9:40 AM Ilya Maximets wrote: > > On 1/1/24 07:37, Mike Pattrick wrote: > > On Sun, Dec 17, 2023 at 9:03 PM Ilya Maximets wrote: > >> > >> In case the difference between 'old' and 'new' rows is readily > >> available, it can be used to construct added/removed datums > >>

Re: [ovs-dev] [PATCH v3 4/8] python: ovs: flow: Add dp hash and meter actions.

2024-01-05 Thread Simon Horman
On Fri, Jan 05, 2024 at 12:46:56PM +0100, Adrian Moreno wrote: > Add missing actions. > > Signed-off-by: Adrian Moreno Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v3 3/8] python: ovs: flow: Add sample to nested actions.

2024-01-05 Thread Simon Horman
On Fri, Jan 05, 2024 at 12:46:55PM +0100, Adrian Moreno wrote: > Add the sample action to those that can be called in nested actions > (such as clone). > > Signed-off-by: Adrian Moreno Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH v3 1/8] python: ovs: flow: Fix typo in n_packets.

2024-01-05 Thread Simon Horman
On Fri, Jan 05, 2024 at 12:46:53PM +0100, Adrian Moreno wrote: > They key used in flows is "n_packets". > > Signed-off-by: Adrian Moreno Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH v3 2/8] python: tests: Add info and key tests for OFPFlows.

2024-01-05 Thread Simon Horman
On Fri, Jan 05, 2024 at 12:46:54PM +0100, Adrian Moreno wrote: > Parsing of info and matches was being tested as generic k-v parsing. > Also verify we don't find any unexpected field. > > Signed-off-by: Adrian Moreno > --- > python/ovs/tests/test_ofp.py | 73 +++-

Re: [ovs-dev] [PATCH 3/5] ovsdb: transaction: Don't try to diff unchanged columns.

2024-01-05 Thread Mike Pattrick
On Fri, Jan 5, 2024 at 9:30 AM Ilya Maximets wrote: > > On 12/29/23 17:28, Mike Pattrick wrote: > > On Sun, Dec 17, 2023 at 9:03 PM Ilya Maximets wrote: > >> > >> While reassessing weak references the code attempts to collect added > >> and removed atoms, even if the column didn't change. In

Re: [ovs-dev] [PATCH 5/5] ovsdb: transaction: Calculate added/removed from diff.

2024-01-05 Thread Ilya Maximets
On 1/1/24 07:37, Mike Pattrick wrote: > On Sun, Dec 17, 2023 at 9:03 PM Ilya Maximets wrote: >> >> In case the difference between 'old' and 'new' rows is readily >> available, it can be used to construct added/removed datums >> instead. Diffs are typically much smaller than the column >> itself.

Re: [ovs-dev] [PATCH 3/5] ovsdb: transaction: Don't try to diff unchanged columns.

2024-01-05 Thread Ilya Maximets
On 12/29/23 17:28, Mike Pattrick wrote: > On Sun, Dec 17, 2023 at 9:03 PM Ilya Maximets wrote: >> >> While reassessing weak references the code attempts to collect added >> and removed atoms, even if the column didn't change. In case the >> column contains a large set, it may take significant

Re: [ovs-dev] [PATCH ovn] treewide: Cleanup free() calls.

2024-01-05 Thread Dumitru Ceara
On 1/4/24 20:56, Mark Michelson wrote: > Thanks Ales and Dumitru. > Thanks Mark! > I applied this patch to main only, since it's not really fixing any > problems. If you think this should be backported, let me know and I can > apply it to older branches. > I don't think it's really needed

Re: [ovs-dev] [PATCH] ovsdb-idl: Reparse reference src before dst is deleted

2024-01-05 Thread Ilya Maximets
On 1/5/24 04:13, Tao Liu wrote: > > On 1/4/24 7:56 PM, Ilya Maximets wrote: >> On 7/4/23 12:41, Tao Liu wrote: >>> Hi, Ilya. Thanks for your comment. >>> >>> On 7/4/23 4:10 AM, Ilya Maximets wrote: On 7/2/23 11:59, Tao Liu wrote: > Commit 02f31a1262fc has fixed the row references when

[ovs-dev] [PATCH v3 6/8] python: ovs: flow: Add idle_age to openflow flows.

2024-01-05 Thread Adrian Moreno
Add missing key. Signed-off-by: Adrian Moreno --- python/ovs/flow/ofp.py | 1 + python/ovs/tests/test_ofp.py | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/python/ovs/flow/ofp.py b/python/ovs/flow/ofp.py index f1a720d75..3d3226c91 100644 ---

[ovs-dev] [PATCH v3 8/8] python: ovs: flow: Add meter_id to controller.

2024-01-05 Thread Adrian Moreno
Add missing option to controller action. Signed-off-by: Adrian Moreno --- python/ovs/flow/ofp_act.py | 1 + python/ovs/tests/test_ofp.py | 15 +++ 2 files changed, 16 insertions(+) diff --git a/python/ovs/flow/ofp_act.py b/python/ovs/flow/ofp_act.py index c540443ea..2c85076a3

[ovs-dev] [PATCH v3 7/8] python: ovs: flow: Make check_pkt_len action a list.

2024-01-05 Thread Adrian Moreno
In general, most actions must be lists since the keys can be repeated. Signed-off-by: Adrian Moreno --- python/ovs/flow/odp.py | 6 -- python/ovs/tests/test_odp.py | 12 ++-- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/python/ovs/flow/odp.py

[ovs-dev] [PATCH v3 5/8] python: tests: Refactor test_odp section testing.

2024-01-05 Thread Adrian Moreno
Avoid code duplication by moving the section testing code to its own function. Signed-off-by: Adrian Moreno --- python/ovs/tests/test_odp.py | 66 ++-- 1 file changed, 26 insertions(+), 40 deletions(-) diff --git a/python/ovs/tests/test_odp.py

[ovs-dev] [PATCH v3 3/8] python: ovs: flow: Add sample to nested actions.

2024-01-05 Thread Adrian Moreno
Add the sample action to those that can be called in nested actions (such as clone). Signed-off-by: Adrian Moreno --- python/ovs/flow/odp.py | 29 +++-- python/ovs/tests/test_ofp.py | 14 ++ 2 files changed, 29 insertions(+), 14 deletions(-) diff --git

[ovs-dev] [PATCH v3 1/8] python: ovs: flow: Fix typo in n_packets.

2024-01-05 Thread Adrian Moreno
They key used in flows is "n_packets". Signed-off-by: Adrian Moreno --- python/ovs/flow/ofp.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/ovs/flow/ofp.py b/python/ovs/flow/ofp.py index 20231fd9f..f1a720d75 100644 --- a/python/ovs/flow/ofp.py +++

[ovs-dev] [PATCH v3 4/8] python: ovs: flow: Add dp hash and meter actions.

2024-01-05 Thread Adrian Moreno
Add missing actions. Signed-off-by: Adrian Moreno --- python/ovs/flow/odp.py | 9 + python/ovs/tests/test_odp.py | 12 2 files changed, 21 insertions(+) diff --git a/python/ovs/flow/odp.py b/python/ovs/flow/odp.py index ef7e5d6b8..46697a1bc 100644 ---

[ovs-dev] [PATCH v3 2/8] python: tests: Add info and key tests for OFPFlows.

2024-01-05 Thread Adrian Moreno
Parsing of info and matches was being tested as generic k-v parsing. Also verify we don't find any unexpected field. Signed-off-by: Adrian Moreno --- python/ovs/tests/test_ofp.py | 73 +++- 1 file changed, 55 insertions(+), 18 deletions(-) diff --git

[ovs-dev] [PATCH v3 0/8] python: Miscelaneous flow parsing fixes.

2024-01-05 Thread Adrian Moreno
This series contains some miscelaneous fixes in the flow parsing library. V4: - Fixed pytests and added more tests for each fix. V2: - Rebased and dropped first patch. Adrian Moreno (8): python: ovs: flow: Fix typo in n_packets. python: tests: Add info and key tests for OFPFlows.

Re: [ovs-dev] [PATCH v2 5/6] python: ovs: flow: Make check_pkt_len action a list.

2024-01-05 Thread Adrian Moreno
On 1/2/24 15:26, Ilya Maximets wrote: On 12/20/23 18:57, Adrian Moreno wrote: In general, most actions must be lists since the keys can be repeated. Signed-off-by: Adrian Moreno --- python/ovs/flow/odp.py | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git