Re: [ovs-dev] [PATCH ovn v5 00/16] northd lflow incremental processing

2024-01-24 Thread Han Zhou
On Thu, Jan 11, 2024 at 7:28 AM wrote: > > From: Numan Siddique > > This patch series adds incremental processing in the lflow engine > node to handle changes to northd and other engine nodes. > Changed related to load balancers and NAT are mainly handled in > this patch series. > > This patch

Re: [ovs-dev] [PATCH ovn v5 11/16] northd: Handle lb changes in lflow engine.

2024-01-24 Thread Han Zhou
On Thu, Jan 11, 2024 at 7:33 AM wrote: > > From: Numan Siddique > > Since northd tracked data has the changed lb data, northd > engine handler for lflow engine now handles the lb changes > incrementally. All the lflows generated for each lb is > stored in the ovn_lb_datapaths->lflow_ref and

Re: [ovs-dev] [PATCH ovn v5 08/16] northd: Refactor lflow management into a separate module.

2024-01-24 Thread Han Zhou
On Wed, Jan 24, 2024 at 10:07 PM Han Zhou wrote: > > > > On Thu, Jan 11, 2024 at 7:32 AM wrote: > > > > From: Numan Siddique > > > > ovn_lflow_add() and other related functions/macros are now moved > > into a separate module - lflow-mgr.c. This module maintains a > > table 'struct lflow_table'

Re: [ovs-dev] [PATCH ovn v5 08/16] northd: Refactor lflow management into a separate module.

2024-01-24 Thread Han Zhou
On Thu, Jan 11, 2024 at 7:32 AM wrote: > > From: Numan Siddique > > ovn_lflow_add() and other related functions/macros are now moved > into a separate module - lflow-mgr.c. This module maintains a > table 'struct lflow_table' for the logical flows. lflow table > maintains a hmap to store the

Re: [ovs-dev] [PATCH ovn v5 08/16] northd: Refactor lflow management into a separate module.

2024-01-24 Thread Han Zhou
On Wed, Jan 24, 2024 at 8:39 PM Numan Siddique wrote: > > On Wed, Jan 24, 2024 at 10:53 PM Han Zhou wrote: > > > > On Wed, Jan 24, 2024 at 4:23 AM Dumitru Ceara wrote: > > > > > > On 1/24/24 06:01, Han Zhou wrote: > > > > On Fri, Jan 19, 2024 at 2:50 AM Dumitru Ceara wrote: > > > >> > > > >>

Re: [ovs-dev] [PATCH ovn v2] fix segfault due to ssl-ciphers

2024-01-24 Thread Numan Siddique
On Thu, Jan 18, 2024 at 1:42 AM Ales Musil wrote: > > On Wed, Jan 17, 2024 at 9:13 PM wrote: > > > From: Aliasgar Ginwala > > > > To avoid invalidating existing certs setup by old version of ovs pki. > > openssl supports setting ciphers but it fails with ovn as below > > ovn-controller

Re: [ovs-dev] [PATCH ovn v5 08/16] northd: Refactor lflow management into a separate module.

2024-01-24 Thread Numan Siddique
On Wed, Jan 24, 2024 at 10:53 PM Han Zhou wrote: > > On Wed, Jan 24, 2024 at 4:23 AM Dumitru Ceara wrote: > > > > On 1/24/24 06:01, Han Zhou wrote: > > > On Fri, Jan 19, 2024 at 2:50 AM Dumitru Ceara wrote: > > >> > > >> On 1/11/24 16:31, num...@ovn.org wrote: > > >>> + > > >>> +void > > >>>

Re: [ovs-dev] [PATCH ovn v5 08/16] northd: Refactor lflow management into a separate module.

2024-01-24 Thread Han Zhou
On Wed, Jan 24, 2024 at 4:23 AM Dumitru Ceara wrote: > > On 1/24/24 06:01, Han Zhou wrote: > > On Fri, Jan 19, 2024 at 2:50 AM Dumitru Ceara wrote: > >> > >> On 1/11/24 16:31, num...@ovn.org wrote: > >>> + > >>> +void > >>> +lflow_table_add_lflow(struct lflow_table *lflow_table, > >>> +

Re: [ovs-dev] [PATCH ovn] Controller: Handle unconditional IDL messages while paused.

2024-01-24 Thread Mark Michelson
Hi Mohammad, I'm having a hard time with this one, and mainly it's because of what the intended semantics of being "paused" are. I could see it argued that pausing ovn-controller should have the existing behavior. I could see someone writing a test where they pause ovn-controller specifically

Re: [ovs-dev] [PATCH ovn v5 13/16] northd: Add ls_stateful handler for lflow engine node.

2024-01-24 Thread Numan Siddique
On Fri, Jan 19, 2024 at 6:57 AM Dumitru Ceara wrote: > > On 1/11/24 16:33, num...@ovn.org wrote: > > From: Numan Siddique > > > > Signed-off-by: Numan Siddique > > --- > > Hi Numan, > > > diff --git a/northd/inc-proc-northd.c b/northd/inc-proc-northd.c > > index dcce79510a..f7c3d2bcf5 100644 >

Re: [ovs-dev] [PATCH ovn] northd: Make sure that affinity flows match on VIP.

2024-01-24 Thread Mark Michelson
Hi Ales, Acked-by: Mark Michelson I was ready to point out this doesn't have an accompanying change to ovn-northd.8.xml . However, looking at the existing documentation, the match on the LB VIP is already documented. Apparently this was planned from the beginning but didn't actually make it

Re: [ovs-dev] [PATCH] Userspace: Software fallback for UDP encapsulated TCP segmentation.

2024-01-24 Thread Mike Pattrick
On Wed, Jan 24, 2024 at 1:14 PM Mike Pattrick wrote: > > When sending packets that are flagged as requiring segmentation to an > interface that doens't support this feature, send the packet to the TSO > software fallback instead of dropping it. > > Signed-off-by: Mike Pattrick For some reason,

Re: [ovs-dev] [PATCH] dp-packet: Reset offload flags when clearing a packet.

2024-01-24 Thread Ilya Maximets
On 1/24/24 17:39, Aaron Conole wrote: > Dumitru Ceara writes: > >> On 1/23/24 00:11, Mike Pattrick wrote: >>> The OVN test suite identified a bug in dp_packet_ol_send_prepare() where >>> a BFD packet flagged as double encapsulated would trigger a seg fault. >>> The problem surfaced because

Re: [ovs-dev] [PATCH] userspace: Check for inner L3 while preparing encapsulated packets.

2024-01-24 Thread Ilya Maximets
On 1/23/24 14:31, Mike Pattrick wrote: > On Tue, Jan 23, 2024 at 7:41 AM Ilya Maximets wrote: >> >> On 1/22/24 23:24, Mike Pattrick wrote: >>> On Mon, Jan 22, 2024 at 4:10 PM Ilya Maximets wrote: On 1/22/24 21:33, Mike Pattrick wrote: > On Mon, Jan 22, 2024 at 1:47 PM Ilya Maximets

[ovs-dev] [PATCH] Userspace: Software fallback for UDP encapsulated TCP segmentation.

2024-01-24 Thread Mike Pattrick
When sending packets that are flagged as requiring segmentation to an interface that doens't support this feature, send the packet to the TSO software fallback instead of dropping it. Signed-off-by: Mike Pattrick --- lib/dp-packet-gso.c | 73 +

Re: [ovs-dev] [PATCH v4 ovn] ovn: Add geneve PMTUD support.

2024-01-24 Thread Numan Siddique
On Tue, Jan 23, 2024 at 11:14 AM Lorenzo Bianconi wrote: > > Introduce specif flows for E/W ICMPv{4,6} packets if tunnelled packets > do not fit path MTU. This patch enable PMTUD for East/West Geneve traffic. > > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2241711 > Tested-at: >

Re: [ovs-dev] [PATCH] dp-packet: Reset offload flags when clearing a packet.

2024-01-24 Thread Aaron Conole
Dumitru Ceara writes: > On 1/23/24 00:11, Mike Pattrick wrote: >> The OVN test suite identified a bug in dp_packet_ol_send_prepare() where >> a BFD packet flagged as double encapsulated would trigger a seg fault. >> The problem surfaced because bfd_put_packet was reusing a packet >> allocated on

Re: [ovs-dev] [PATCH ovn v5 4/4] ic/tests: Add unit test for ic sync command.

2024-01-24 Thread Ales Musil
On Wed, Jan 24, 2024 at 3:28 PM Mohammad Heib wrote: > add unit test that check validate that sync command > sync ISB properly > > Signed-off-by: Mohammad Heib > --- > tests/ovn-ic.at | 43 +++ > 1 file changed, 43 insertions(+) > > diff --git

Re: [ovs-dev] [PATCH ovn v5 2/4] ovn-ic: Implement basic INB change handling status.

2024-01-24 Thread Ales Musil
On Wed, Jan 24, 2024 at 3:28 PM Mohammad Heib wrote: > This patch implements a basic sequence number protocol > that can be used by CMS to determine if the changes > applied to INB are successfully propagated to ISB. > > The implementation of this patch relies on OVN-ICs > instances to update

Re: [ovs-dev] [PATCH ovn] pinctrl: dns: Ignore additional additional records.

2024-01-24 Thread Dumitru Ceara
On 1/23/24 22:47, Mark Michelson wrote: > Hi Dumitru. > Hi Mark, > Two questions: > > 1) Did you mean to title this as "additional additional records?" Or did > you just mean "additional records?" > Well, no, I didn't I just expanded AR without thinking. :) > 2) Should this include a test?

Re: [ovs-dev] [PATCH ovn v5 3/4] OVN-IC: Make it possible for CMS to detect when the ISB is up-to-date.

2024-01-24 Thread 0-day Robot
Bleep bloop. Greetings Mohammad Heib, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator WARNING: Line lacks whitespace around operator

Re: [ovs-dev] [PATCH ovn v4 4/4] ic/tests: add unit test for ic sync command

2024-01-24 Thread Mohammad Heib
Hi Ales, On Fri, Jan 12, 2024 at 11:12 AM Ales Musil wrote: > > > On Tue, Jan 9, 2024 at 2:29 PM Mohammad Heib wrote: > >> add unit test that check validate that sync command >> sync ISB properly >> >> Signed-off-by: Mohammad Heib >> --- >> > > Hi Mohammad, > > I have a few comments down

[ovs-dev] [PATCH ovn v5 3/4] OVN-IC: Make it possible for CMS to detect when the ISB is up-to-date.

2024-01-24 Thread Mohammad Heib
Until now, there has been no reliable for the CMS to detect when changes made to the INB configuration have been passed through to the ISB, This commit adds this feature to the system, by adding sequence numbers to the INB and ISB and adding code in ovn-ic-nbctl, ovn-ic to keep those sequence

[ovs-dev] [PATCH ovn v5 4/4] ic/tests: Add unit test for ic sync command.

2024-01-24 Thread Mohammad Heib
add unit test that check validate that sync command sync ISB properly Signed-off-by: Mohammad Heib --- tests/ovn-ic.at | 43 +++ 1 file changed, 43 insertions(+) diff --git a/tests/ovn-ic.at b/tests/ovn-ic.at index d4c436f84..535aba7da 100644 ---

[ovs-dev] [PATCH ovn v5 2/4] ovn-ic: Implement basic INB change handling status.

2024-01-24 Thread Mohammad Heib
This patch implements a basic sequence number protocol that can be used by CMS to determine if the changes applied to INB are successfully propagated to ISB. The implementation of this patch relies on OVN-ICs instances to update the ISB by adding a per AZ a nb_ic_cfg counter that will be updated

[ovs-dev] [PATCH ovn v5 1/4] OVN-IC: Interconnect DBs add basic Information Flow columns.

2024-01-24 Thread Mohammad Heib
Add basic flow columns to interconnect northbound DB and interconnect Southbound DB. Those columns will be used by future patches to add basic support for Information Flow in OVN interconnect. Signed-off-by: Mohammad Heib Acked-by: Mark Michelson Acked-by: Ales Musil --- NEWS

[ovs-dev] [PATCH ovn v5 0/4] OVN-IC: Add basic sequence number status support.

2024-01-24 Thread Mohammad Heib
Currently, OVN-IC doesn't support a way to tell the end-user when their changes to the IC-NB database have propagated successfully to the IC-SB Database. This patch series adds basic support for the sequence number status protocol that is implemented on the native OVN, with this patch series the

Re: [ovs-dev] [PATCH OVN] DHCP Relay Agent support for overlay subnets

2024-01-24 Thread Naveen Yerramneni
> On 24-Jan-2024, at 8:59 AM, Numan Siddique wrote: > > On Tue, Jan 23, 2024 at 8:02 PM Naveen Yerramneni > wrote: >> >> >> >>> On 16-Jan-2024, at 2:30 AM, Numan Siddique wrote: >>> >>> On Tue, Dec 12, 2023 at 1:05 PM Naveen Yerramneni >>> wrote: This patch contains changes

Re: [ovs-dev] [PATCH ovn v5 08/16] northd: Refactor lflow management into a separate module.

2024-01-24 Thread Dumitru Ceara
On 1/24/24 06:01, Han Zhou wrote: > On Fri, Jan 19, 2024 at 2:50 AM Dumitru Ceara wrote: >> >> On 1/11/24 16:31, num...@ovn.org wrote: >>> + >>> +void >>> +lflow_table_add_lflow(struct lflow_table *lflow_table, >>> + const struct ovn_datapath *od, >>> +

Re: [ovs-dev] [PATCH ovn v4 0/4] OVN-IC: add basic sequence number status support

2024-01-24 Thread Ales Musil
On Wed, Jan 24, 2024 at 9:44 AM Mohammad Heib wrote: > Hi Ales, > > Yes sure that's what I'm planning to do next, i first wanted to make those > patches accepted upstream and then update the test case to use > the sync command, i guess it will be easier to review if send the test > cases change

Re: [ovs-dev] [PATCH ovn v4 0/4] OVN-IC: add basic sequence number status support

2024-01-24 Thread Mohammad Heib
Hi Ales, Yes sure that's what I'm planning to do next, i first wanted to make those patches accepted upstream and then update the test case to use the sync command, i guess it will be easier to review if send the test cases change as a separate patch, what do you think? On Fri, Jan 12, 2024 at