Add a test case for regression in openvswitch nat that was fixed by
commit e6345d2824a3 ("netfilter: nf_nat: fix action not being set for
all ct states").
Link: https://lore.kernel.org/netdev/20231221224311.130319-1-b...@faucet.nz/
Link:
On Tue, Jan 30, 2024 at 10:52 AM Numan Siddique wrote:
>
> On Tue, Jan 30, 2024 at 7:38 AM Dumitru Ceara wrote:
> >
> > This picks up the following relevant commit:
> > cd8ffc956c3c ovs-atomic: Fix inclusion of Clang header by GCC 14.
> >
> > Without this builds on Fedora 40 (rawhide) are
> On 29-Jan-2024, at 9:11 PM, Ihar Hrachyshka wrote:
>
> On Mon, Jan 22, 2024 at 12:22 PM Naveen Yerramneni
> wrote:
> This option can be used to enable/disable arp/nd reply flows.
>
> Usecase:
> =
> It is useful to reduce packet loss when VM is being migrated to
>
> It may indeed
Include inner offsets in functions where l3 and l4 offsets are either
modified or checked.
Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
Signed-off-by: Mike Pattrick
---
v2:
- Prints out new offsets in autovalidator
- Extends resize_l2 change to avx512
Signed-off-by: Mike
Currently the monitor will call dp_packet_clear() on the dp_packet that
is shared amongst BFD, LLDP, and CFM. However, all of these packets are
created with eth_compose(), which already calls dp_packet_clear().
Signed-off-by: Mike Pattrick
---
ofproto/ofproto-dpif-monitor.c | 3 ---
1 file
Previously the BFD packet creation code did not appropriately set
offsets or flags. This contributed to issues involving encapsulation and
the TSO code.
Fixes: ccc096898c46 ("bfd: Implement Bidirectional Forwarding Detection.")
Signed-off-by: Mike Pattrick
---
v2: Corrected formatting, and just
This patch fixes the correctness of dp_packet_inner_l4_size() when
checking for the existence of an inner L4 header. Previously it checked
for the outer L4 header.
This function is currently only used when a packet is already flagged
for tunneling, so an incorrect determination isn't possible as
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line has non-spaces leading whitespace
WARNING: Line has trailing whitespace
#4892
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Inappropriate bracing around statement
#687 FILE: northd/en-ls-stateful.h:55:
On 1/30/24 16:08, Mark Michelson wrote:
RBAC did not restrict which chassis could update IGMP_Groups. With this
change, we add a new "chassis_name" column to IGMP_Group.
This may seem odd since there is already a "chassis" column in
IGMP_Group. But RBAC specifically works by string matching
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Inappropriate bracing around statement
#100 FILE: northd/en-lr-nat.h:95:
From: Numan Siddique
A new engine node "global_config" is added which handles the changes
to NB_Global an SB_Global tables. It also creates these rows if
not present.
Without the I-P, any changes to the options column of these tables
result in recompute of 'northd' and 'lflow' engine nodes.
From: Numan Siddique
northd engine node uses the sb mac binding table to
cleanup mac binding entries for deleted logical ports
and datapaths. Any update to SB mac binding doesn't
change the northd engine node state or data. Hence
it is ok to add a noop_handler.
Presently, mac_binding_aging
From: Numan Siddique
Any changes to northd engine node due to load balancers
are now handled in 'sync_to_sb_lb' node to sync the changed
load balancers to SB load balancers.
The logic to sync the SB load balancers is changed a bit and it
now mimics the SB lflow sync.
Below are the scale
From: Numan Siddique
Acked-by: Han Zhou
Signed-off-by: Numan Siddique
---
northd/en-lflow.c| 26 +
northd/en-lflow.h| 1 +
northd/en-ls-stateful.c | 9 +++--
northd/en-ls-stateful.h | 26 +
northd/inc-proc-northd.c | 2 +-
northd/northd.c
From: Numan Siddique
Acked-by: Han Zhou
Signed-off-by: Numan Siddique
---
northd/en-lflow.c| 27 +++
northd/en-lflow.h| 1 +
northd/en-lr-stateful.c | 33 +++-
northd/en-lr-stateful.h | 31 +++-
northd/inc-proc-northd.c | 2 +-
northd/northd.c | 369
From: Numan Siddique
Since northd tracked data has the changed lb information,
the lflow change handler for northd inputs can now handle
lb updates incrementally. All the lflows generated for
each lb is stored in the ovn_lb_datapaths->lflow_ref and
this is used similar to how we handle ovn_port
From: Numan Siddique
It also moves the ovn-controller specific code from lib/lb.c
and lib/lb.h to controller/lb.c and controller/lb.h.
Acked-by: Han Zhou
Co-authored-by: Dumitru Ceara
Signed-off-by: Dumitru Ceara
Signed-off-by: Numan Siddique
---
controller/automake.mk | 2 +
From: Numan Siddique
This new engine now maintains the load balancer and ACL data of a
logical switch which was earlier part of northd engine node data.
The main inputs to this engine are:
- northd node
- Port group node
A record for each logical switch is maintained in the
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 88 characters long (recommended limit is 79)
#204 FILE:
From: Numan Siddique
Previous commits added new engine nodes to store logical router's
stateful (LB and NAT data). Make use of the data stored by these
engine nodes to generate logical flows related to router's LBs and NATs.
Acked-by: Dumitru Ceara
Signed-off-by: Numan Siddique
---
From: Numan Siddique
This new engine now maintains the load balancer and NAT data of a
logical router which was earlier part of northd engine node data.
The main inputs to this engine are:
- northd node
- lr_nat node
- lb_data node
A record for each logical router is maintained in the
From: Numan Siddique
This new engine now maintains the NAT related data for each
logical router which was earlier maintained by the northd
engine node in the 'struct ovn_datapath'. The input to
this engine node is 'northd'.
A record for each logical router (lr_nat_record) is maintained
in the
From: Numan Siddique
This patch series adds incremental processing in the lflow engine
node to handle changes to northd and other engine nodes.
Changed related to load balancers and NAT are mainly handled in
this patch series.
This patch series can also be found here -
This adds a new "chassis_name" column to the BFD table. ovn-northd sets
this to the logical port's chassis name when creating the BFD record.
RBAC has been updated so that chassis may only update their own records.
Signed-off-by: Mark Michelson
---
v1 -> v2:
* Rebased on current main
---
RBAC did not restrict which chassis could update IGMP_Groups. With this
change, we add a new "chassis_name" column to IGMP_Group.
This may seem odd since there is already a "chassis" column in
IGMP_Group. But RBAC specifically works by string matching based on the
certificate common name.
Service monitors already had the restriction that chassis could not
insert or delete records. However, there was nothing restricting chassis
from updating records for service monitors that are relevant to other
chassis.
This change adds a new "chassis_name" column to the Service_Monitor
table.
On Tue, Jan 30, 2024 at 3:35 AM Dumitru Ceara wrote:
>
> On 1/30/24 08:59, Ales Musil wrote:
> > On Tue, Jan 30, 2024 at 8:58 AM Ales Musil wrote:
> >
> >> The Fedora version of grep (grep (GNU grep) 3.11) complains
> >> about the syntax grep "output\:": grep: warning: stray \ before :
> >>
> >>
On 1 Dec 2023, at 20:14, Adrian Moreno wrote:
> Graph view leverages the tree format (specially the tree-based
> filtering) and uses graphviz library to build a visual graph of the
> datapath in graphviz format.
>
> Conntrack zones are shown in random colors to help visualize connection
>
On 1 Dec 2023, at 20:14, Adrian Moreno wrote:
> Using the existing FlowTree and HTMLFormatter, create an HTML tree
> visualization that also supports collapsing and expanding entire flow
> trees and subtrees.
This looks good to me, maybe add an example in the commit message.
Acked-by: Eelco
On 1 Dec 2023, at 20:14, Adrian Moreno wrote:
> When anaylizing OVN issues, it might be useful to see what OpenFlow
> flows were generated from each logical flow. In order to make it simpler
> to visualize this, add a cookie format that simply sorts the flows first
> by cookie, then by table.
On 1 Dec 2023, at 20:14, Adrian Moreno wrote:
> This view is interesting for debugging the logical pipeline. It arranges
> the flows in "logical" groups (not to be confused with OVN's
> Logical_Flows). A logical group of flows is a set of flows that:
> - Have the same table number and priority
>
On 30 Jan 2024, at 16:52, Eelco Chaudron wrote:
> On 1 Dec 2023, at 20:14, Adrian Moreno wrote:
>
>> Datapath flows can be arranged into a "tree"-like structure based on
>> recirculation ids, e.g:
>>
>> recirc(0),eth(...),ipv4(...) actions=ct,recirc(0x42)
>>\->
On 1 Dec 2023, at 20:14, Adrian Moreno wrote:
> Datapath flows can be arranged into a "tree"-like structure based on
> recirculation ids, e.g:
>
> recirc(0),eth(...),ipv4(...) actions=ct,recirc(0x42)
>\-> recirc(42),ct_state(0/0),eth(...),ipv4(...) actions=1
>\->
On 1 Dec 2023, at 20:14, Adrian Moreno wrote:
> Datapath flows can be arranged into a "tree"-like structure based on
> recirculation ids, e.g:
>
> recirc(0),eth(...),ipv4(...) actions=ct,recirc(0x42)
>\-> recirc(42),ct_state(0/0),eth(...),ipv4(...) actions=1
>\->
On Tue, Jan 30, 2024 at 7:38 AM Dumitru Ceara wrote:
>
> This picks up the following relevant commit:
> cd8ffc956c3c ovs-atomic: Fix inclusion of Clang header by GCC 14.
>
> Without this builds on Fedora 40 (rawhide) are broken due to failing to
> compile the submodule.
>
> Signed-off-by:
On 1 Dec 2023, at 20:14, Adrian Moreno wrote:
> Add a HTML Formatter and use it to print OpenFlow flows in an HTML list
> with table links.
>
> Signed-off-by: Adrian Moreno
No real comments from my side, this looks good! Maybe add an example to the
commit message.
One small potential addition
On 1 Dec 2023, at 20:14, Adrian Moreno wrote:
> It has two basic styles defined: "dark" and "light" intended for
> dark and light terminals.
This patch looks fine to me. Should we maybe add an example in the commit
message on how to use the --style option?
Cheers,
Eelco
> Signed-off-by:
On 1 Dec 2023, at 20:14, Adrian Moreno wrote:
> Add a flow formatting framework and one implementation for console
> printing using rich.
>
> The flow formatting framework is a simple set of classes that can be
> used to write different flow formatting implementations. It supports
> styles to be
On 1 Dec 2023, at 20:14, Adrian Moreno wrote:
> process.py contains a useful base class that processes files
> odp.py and ofp.py: contain datapath and openflow subcommand definitions
> as well as the first formatting option: json.
>
> Also, this patch adds basic filtering support.
>
> Examples:
>
On 1 Dec 2023, at 20:14, Adrian Moreno wrote:
> Add a new python package (just the scheleton for now) to hold a flow
> visualization tool based on the flow parsing library.
Thanks for this series, and sorry for the late review :(
Maybe I'm doing something wrong, but doing 'the pip install .' in
On 1 Dec 2023, at 20:14, Adrian Moreno wrote:
> This series introduces a python utility called ovs-flowviz.
>
> The goal of this utility is to read both datapath and Openflow flows
> (using the flow library already available) and print them in different
> formats and styles to make it easier to
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 94 characters long (recommended limit is 79)
WARNING: Line lacks
Ilya Maximets writes:
> On 1/25/24 21:55, Aaron Conole wrote:
>> All supported versions of Fedora do package libbpf, so it
>> makes sense to enable USDT support.
>>
>> Signed-off-by: Aaron Conole
>> ---
>> v8: Include the correct devel package as a dependency
>>
>>
Bleep bloop. Greetings Mohammad Heib, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: The subject, ': ', is over 70 characters, i.e., 77.
Subject: ovn-controller: Stop
On 1/30/24 13:07, Ilya Maximets wrote:
> checkout@v3, cache@v3, setup-python@v4 and setup-go@v3 are using
> outdated Node.js 16 which is now deprecated in GHA [1], so these
> actions may stop working soon.
>
> Updating to most recent major versions with Node.js 20. This stops
> GHA from throwing
This commit fixes the prefix filter function as the return condition for IPv6
addresses is disabling the advertisement of all learned prefixes regardless of
the match with the blacklist or not.
Reported-at: https://bugs.launchpad.net/ubuntu/+source/ovn/+bug/2046804
Fixes: 57b347c55168 ("ovn-ic:
Bleep bloop. Greetings Roberto Bartzen Acosta, I am a robot and I have tried
out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: The subject summary should start with a capital.
WARNING: The subject
ovn-controller immediately removes the vport_bindings requests that were
generated by VIFs after handling them locally, this approach is intended
to avoid binding the vport to one VIF only and allocate the vport
between the different VIFs that exist in the vport:virtual-parents.
Although the
This commit fixes the prefix filter function as the return condition for IPv6
addresses is disabling the advertisement of all learned prefixes regardless of
the match with the blacklist or not.
Reported-at: https://bugs.launchpad.net/ubuntu/+source/ovn/+bug/2046804
Fixes: 57b347c55168 ("ovn-ic:
This picks up the following relevant commit:
cd8ffc956c3c ovs-atomic: Fix inclusion of Clang header by GCC 14.
Without this builds on Fedora 40 (rawhide) are broken due to failing to
compile the submodule.
Signed-off-by: Dumitru Ceara
---
ovs | 2 +-
1 file changed, 1 insertion(+), 1
checkout@v3, cache@v3, setup-python@v4 and setup-go@v3 are using
outdated Node.js 16 which is now deprecated in GHA [1], so these
actions may stop working soon.
Updating to most recent major versions with Node.js 20. This stops
GHA from throwing warnings in every build.
[1]
On 1/23/24 14:40, Mohammad Heib wrote:
> When the user updates the NB_GLOBAL.name after registering
> to IC Databases if the user already has defined chassis as a gateway
> that will cause ovn-ic instance to run in an infinity loop trying
> to update the gateways and insert the current gateway to
On 1/29/24 15:33, Xavier Simonart wrote:
> Hi Dumitru
>
> Thanks for the patch.
>
> On Tue, Jan 23, 2024 at 10:44 PM Mark Michelson wrote:
>
>> Hi Dumitru,
>>
>> Acked-by: Mark Michelson
>>
>> I think this change is good. I looked through the documentation for the
>> "external_port_range"
On 1/18/24 09:06, Ales Musil wrote:
> Replace and remove the ovn_smap_get_uint as smap_get_uint is avaiable in OvS
> library since 7b2e999fd759 ("smap: Add smap_get_uint() helper function.").
>
> Signed-off-by: Ales Musil
> ---
Applied to main, thanks!
Regards,
Dumitru
On 1/30/24 10:48, Mohammad Heib wrote:
> Hi,
> Thank you Dumitru.
>
> Acked-by: Mohammad Heib
>
> On Tue, Jan 30, 2024 at 11:16 AM Eelco Chaudron wrote:
>
>>
>>
>> On 30 Jan 2024, at 9:57, Dumitru Ceara wrote:
>>
>>> On 1/30/24 09:04, Eelco Chaudron wrote:
On 30 Jan 2024, at
On 1/30/24 08:59, Ales Musil wrote:
> On Tue, Jan 30, 2024 at 8:58 AM Ales Musil wrote:
>
>> The Fedora version of grep (grep (GNU grep) 3.11) complains
>> about the syntax grep "output\:": grep: warning: stray \ before :
>>
>> Remove the \ which works also for Ubuntu grep version
>> (grep (GNU
On 1/30/24 09:54, Jakob Meng wrote:
> On 29.01.24 23:33, Ilya Maximets wrote:
>> Fedora 37 reached EOL in November. Switch to the most recent version
>> to avoid potential CI failures in the future.
>>
>> Signed-off-by: Ilya Maximets
>> ---
>> .github/workflows/build-and-test.yml | 2 +-
>> 1
On Mon, Jan 29, 2024 at 11:33:56PM +0100, Ilya Maximets wrote:
> Fedora 37 reached EOL in November. Switch to the most recent version
> to avoid potential CI failures in the future.
>
> Signed-off-by: Ilya Maximets
Acked-by: Simon Horman
___
dev
On Mon, Jan 29, 2024 at 01:51:42PM +0100, Eelco Chaudron wrote:
> This changes add statistics for when a thread is put into stop state.
> For example with the following:
>
> kill -STOP $(pidof ovs-vswitchd); sleep 1; kill -CONT $(pidof ovs-vswitchd);
>
> Acked-by: Simon Horman
> Signed-off-by:
On 1/25/24 21:55, Aaron Conole wrote:
> All supported versions of Fedora do package libbpf, so it
> makes sense to enable USDT support.
>
> Signed-off-by: Aaron Conole
> ---
> v8: Include the correct devel package as a dependency
>
> rhel/openvswitch-fedora.spec.in | 8
> 1 file
On Thu, Jan 25, 2024 at 03:55:44PM -0500, Aaron Conole wrote:
> All supported versions of Fedora do package libbpf, so it
> makes sense to enable USDT support.
>
> Signed-off-by: Aaron Conole
> ---
> v8: Include the correct devel package as a dependency
Thanks for the update, this one looks
On Fri, Jan 26, 2024 at 10:29:27AM -0800, Han Zhou wrote:
> On Fri, Jan 26, 2024 at 10:26 AM Han Zhou wrote:
> >
> >
> >
> > On Fri, Jan 26, 2024 at 7:53 AM Aaron Conole wrote:
> > >
> > > Han Zhou writes:
> > >
> > > > On Thu, Jan 25, 2024 at 12:55 PM Aaron Conole
> wrote:
> > > >>
> > > >>
Hi,
Thank you Dumitru.
Acked-by: Mohammad Heib
On Tue, Jan 30, 2024 at 11:16 AM Eelco Chaudron wrote:
>
>
> On 30 Jan 2024, at 9:57, Dumitru Ceara wrote:
>
> > On 1/30/24 09:04, Eelco Chaudron wrote:
> >>
> >>
> >> On 30 Jan 2024, at 0:36, Dumitru Ceara wrote:
> >>
> >>> This picks up the
On Fri, Jan 26, 2024 at 10:55:48AM -0500, Aaron Conole wrote:
> Simon Horman writes:
>
> > On Thu, Jan 25, 2024 at 12:05:29PM -0500, Aaron Conole wrote:
> >> From: Kevin Sprague
> >>
> >> During normal operations, it is useful to understand when a particular flow
> >> gets removed from the
On Fri, Jan 26, 2024 at 02:24:51PM +0100, jm...@redhat.com wrote:
> From: Jakob Meng
>
> In a scenario where OVN does load balancing and then SNAT with a OVS
> userspace datapath [0], the recirc_depth may be greater than 6. In
> that case, ovs-vswitchd might drop packets and raise warnings:
>
>
On 30 Jan 2024, at 9:57, Dumitru Ceara wrote:
> On 1/30/24 09:04, Eelco Chaudron wrote:
>>
>>
>> On 30 Jan 2024, at 0:36, Dumitru Ceara wrote:
>>
>>> This picks up the following relevant OVS commits:
>>> 8893e24d9d dpdk: Update to use v23.11.
>>> ed738eca39 util: Annotate function that
On 1/30/24 09:04, Eelco Chaudron wrote:
>
>
> On 30 Jan 2024, at 0:36, Dumitru Ceara wrote:
>
>> This picks up the following relevant OVS commits:
>> 8893e24d9d dpdk: Update to use v23.11.
>> ed738eca39 util: Annotate function that will never return NULL.
>> 77d0bad04 mcast-snooping:
On 29.01.24 23:33, Ilya Maximets wrote:
> Fedora 37 reached EOL in November. Switch to the most recent version
> to avoid potential CI failures in the future.
>
> Signed-off-by: Ilya Maximets
> ---
> .github/workflows/build-and-test.yml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
On 29 Jan 2024, at 23:33, Ilya Maximets wrote:
> Fedora 37 reached EOL in November. Switch to the most recent version
> to avoid potential CI failures in the future.
>
> Signed-off-by: Ilya Maximets
Thanks for looking forward! The change looks fine to me, only tested on the
master branch.
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: The subject summary should end with a dot.
Subject: tests: Fix grep warning
Lines
On 30 Jan 2024, at 0:36, Dumitru Ceara wrote:
> This picks up the following relevant OVS commits:
> 8893e24d9d dpdk: Update to use v23.11.
> ed738eca39 util: Annotate function that will never return NULL.
> 77d0bad04 mcast-snooping: Store IGMP/MLD protocol version.
> b222593bc6
On Tue, Jan 30, 2024 at 8:58 AM Ales Musil wrote:
> The Fedora version of grep (grep (GNU grep) 3.11) complains
> about the syntax grep "output\:": grep: warning: stray \ before :
>
> Remove the \ which works also for Ubuntu grep version
> (grep (GNU grep) 3.7).
>
>
I forgot to add the Fixes
73 matches
Mail list logo
