Re: [ovs-dev] [PATCH OVN] ovn-nb: Add documentation for disable_arp_nd_rsp option

2024-02-16 Thread 0-day Robot
References: <20240217035326.6562-1-naveen.yerramn...@nutanix.com> Bleep bloop. Greetings Naveen Yerramneni, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: The

[ovs-dev] [PATCH OVN] ovn-nb: Add documentation for disable_arp_nd_rsp option

2024-02-16 Thread Naveen Yerramneni
Signed-off-by: Naveen Yerramneni --- ovn-nb.xml | 7 +++ 1 file changed, 7 insertions(+) diff --git a/ovn-nb.xml b/ovn-nb.xml index e0b983ed6..b652046a7 100644 --- a/ovn-nb.xml +++ b/ovn-nb.xml @@ -1268,6 +1268,13 @@ unknown ports connected to the same Logical Switch.

Re: [ovs-dev] [PATCH ovn] physical: Don't reset encap ID across pipelines.

2024-02-16 Thread Numan Siddique
On Mon, Feb 12, 2024 at 2:49 PM Han Zhou wrote: > > The MFF_LOG_ENCAP_ID register was defined to save the encap ID and avoid > changing across pipelines, but in the function > load_logical_ingress_metadata it was reset unconditionally. Because of > this, the encap selection doesn't work when

Re: [ovs-dev] [PATCH OVN] Add "disable_arp_nd_rsp" option to LSP

2024-02-16 Thread Numan Siddique
On Thu, Feb 15, 2024 at 8:46 PM Naveen Yerramneni wrote: > > > > > On 12-Feb-2024, at 8:36 PM, Ihar Hrachyshka wrote: > > > > On Tue, Jan 30, 2024 at 10:52 PM Naveen Yerramneni > > wrote: > > > > > > > On 29-Jan-2024, at 9:11 PM, Ihar Hrachyshka wrote: > > > > > > On Mon, Jan 22, 2024 at

Re: [ovs-dev] [PATCH branch-3.3 2/2] Prepare for 3.3.1.

2024-02-16 Thread Ilya Maximets
On 2/16/24 16:55, Simon Horman wrote: > On Fri, Feb 16, 2024 at 12:46:33PM +0100, Ilya Maximets wrote: >> Signed-off-by: Ilya Maximets > > Acked-by: Simon Horman > Thanks, Simon! I applied the patches (first one to master and branch-3.3 and the second one to branch-3.3 only) and tagged the

Re: [ovs-dev] [PATCH OVN] Add "pkt_clone_type" option to LSP.

2024-02-16 Thread Numan Siddique
On Mon, Jan 22, 2024 at 12:13 PM Naveen Yerramneni wrote: > > Currently only valid value for this option is mc_unknown. > If set to mc_unknown, packets destined to the port gets cloned > to all unknown ports connected to the same Logical Switch. > > Usecase: > = > It is required to reduce

Re: [ovs-dev] [PATCH v4 4/4] Userspace: Add system test with UDP tunneling of UDP traffic.

2024-02-16 Thread Ilya Maximets
On 2/16/24 21:40, Mike Pattrick wrote: > On Fri, Feb 16, 2024 at 3:23 PM Ilya Maximets wrote: >> >> On 2/15/24 23:53, Mike Pattrick wrote: >>> Previously a gap existed in the tunnel system tests where only ICMP and >>> TCP traffic was tested. However, the code paths using for UDP traffic is >>>

Re: [ovs-dev] [PATCH v4 4/4] Userspace: Add system test with UDP tunneling of UDP traffic.

2024-02-16 Thread Mike Pattrick
On Fri, Feb 16, 2024 at 3:23 PM Ilya Maximets wrote: > > On 2/15/24 23:53, Mike Pattrick wrote: > > Previously a gap existed in the tunnel system tests where only ICMP and > > TCP traffic was tested. However, the code paths using for UDP traffic is > > different then either of those and should

Re: [ovs-dev] [PATCH v4 4/4] Userspace: Add system test with UDP tunneling of UDP traffic.

2024-02-16 Thread Ilya Maximets
On 2/15/24 23:53, Mike Pattrick wrote: > Previously a gap existed in the tunnel system tests where only ICMP and > TCP traffic was tested. However, the code paths using for UDP traffic is > different then either of those and should also be tested. > > Some of the modified tests had previously

Re: [ovs-dev] [RFC 4/7] selftests: openvswitch: delete previously allocated netns

2024-02-16 Thread Aaron Conole
Paolo Abeni writes: > On Fri, 2024-02-16 at 10:28 -0500, Aaron Conole wrote: >> Many openvswitch test cases reused netns and interface names. This works >> fine as long as the test case cleans up gracefully. However, if there is >> some kind of ungraceful termination (such as an external

Re: [ovs-dev] [PATCH v2 2/2] conntrack: Handle persistent selection for IP addresses.

2024-02-16 Thread Paolo Valerio
Simon Horman writes: > On Wed, Feb 07, 2024 at 06:38:08PM +0100, Paolo Valerio wrote: >> The patch, when 'persistent' flag is specified, makes the IP selection >> in a range persistent across reboots. >> >> Signed-off-by: Paolo Valerio > > Hi Paolo, > > I have some minor nits below - which you

[ovs-dev] [PATCH v3 2/2] conntrack: Handle persistent selection for IP addresses.

2024-02-16 Thread Paolo Valerio
The patch, when 'persistent' flag is specified, makes the IP selection in a range persistent across reboots. Signed-off-by: Paolo Valerio Acked-by: Simon Horman --- v3: - rearranged branches in nat_get_unique_tuple() (Simon) --- NEWS | 3 ++- lib/conntrack.c | 25

[ovs-dev] [PATCH v3 1/2] conntrack: Handle random selection for port ranges.

2024-02-16 Thread Paolo Valerio
The userspace conntrack only supported hash for port selection. With the patch, both userspace and kernel datapath support the random flag. The default behavior remains the same, that is, if no flags are specified, hash is selected. Signed-off-by: Paolo Valerio Acked-by: Simon Horman ---

Re: [ovs-dev] [RFC 4/7] selftests: openvswitch: delete previously allocated netns

2024-02-16 Thread Paolo Abeni
On Fri, 2024-02-16 at 10:28 -0500, Aaron Conole wrote: > Many openvswitch test cases reused netns and interface names. This works > fine as long as the test case cleans up gracefully. However, if there is > some kind of ungraceful termination (such as an external signal) the netns > or

Re: [ovs-dev] [PATCH branch-3.3 2/2] Prepare for 3.3.1.

2024-02-16 Thread Simon Horman
On Fri, Feb 16, 2024 at 12:46:33PM +0100, Ilya Maximets wrote: > Signed-off-by: Ilya Maximets Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-3.3 1/2] Set release date for 3.3.0.

2024-02-16 Thread Simon Horman
On Fri, Feb 16, 2024 at 12:46:32PM +0100, Ilya Maximets wrote: > Beside the date update, moving the mdb NEWS entry to a more > appropriate place - ovs-appctl section. > > Signed-off-by: Ilya Maximets Acked-by: Simon Horman ___ dev mailing list

Re: [ovs-dev] [RFC 7/7] selftests: openvswitch: add config and timeout settings

2024-02-16 Thread 0-day Robot
Bleep bloop. Greetings Aaron Conole, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error,

Re: [ovs-dev] [RFC 6/7] selftests: openvswitch: insert module when running the tests

2024-02-16 Thread 0-day Robot
Bleep bloop. Greetings Aaron Conole, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error,

Re: [ovs-dev] [RFC 5/7] selftests: openvswitch: make arping test a bit 'slower'

2024-02-16 Thread 0-day Robot
Bleep bloop. Greetings Aaron Conole, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error,

Re: [ovs-dev] [RFC 4/7] selftests: openvswitch: delete previously allocated netns

2024-02-16 Thread 0-day Robot
Bleep bloop. Greetings Aaron Conole, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error,

Re: [ovs-dev] [RFC 3/7] selftests: openvswitch: use non-graceful kills when needed

2024-02-16 Thread 0-day Robot
Bleep bloop. Greetings Aaron Conole, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error,

Re: [ovs-dev] [RFC 2/7] selftests: openvswitch: be more verbose with selftest debugging

2024-02-16 Thread 0-day Robot
Bleep bloop. Greetings Aaron Conole, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error,

Re: [ovs-dev] [RFC 1/7] selftests: openvswitch: add test case error directories to clean list

2024-02-16 Thread 0-day Robot
Bleep bloop. Greetings Aaron Conole, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless (tools/testing/selftests/net/openvswitch/Makefile).

Re: [ovs-dev] [PATCH ovn v2] ci: Update crun in Cirrus CI cloud image.

2024-02-16 Thread Ales Musil
On Fri, Feb 16, 2024 at 4:27 PM Numan Siddique wrote: > On Fri, Feb 16, 2024 at 9:52 AM Dumitru Ceara wrote: > > > > On 2/16/24 14:40, Ales Musil wrote: > > > There are some issues with older crun and newer kernel > > > combination [0]. Unfortunately Ubuntu 23.10 falls into this > > > category

[ovs-dev] [RFC 7/7] selftests: openvswitch: add config and timeout settings

2024-02-16 Thread Aaron Conole
In order for the ovs selftests to run, we need to introduce a sample configuration. This will get run under the kselftest runner for net, but given that environment can be limited process wise, the test can take longer than on bare metal or high availability VMs. So, also introduce a settings

[ovs-dev] [RFC 4/7] selftests: openvswitch: delete previously allocated netns

2024-02-16 Thread Aaron Conole
Many openvswitch test cases reused netns and interface names. This works fine as long as the test case cleans up gracefully. However, if there is some kind of ungraceful termination (such as an external signal) the netns or interfaces can be left lingering. This happens when the selftest

[ovs-dev] [RFC 6/7] selftests: openvswitch: insert module when running the tests

2024-02-16 Thread Aaron Conole
The openvswitch tests do not attempt to insert the openvswitch module automatically. Now the test will auto load the module and try to unload it at the end. The test harness includes the option to not load the module, which is helpful when developing changes and loading the module from a

[ovs-dev] [RFC 3/7] selftests: openvswitch: use non-graceful kills when needed

2024-02-16 Thread Aaron Conole
Normally a spawned process under OVS is given a SIGTERM when the test ends as part of cleanup. However, in case the process is still lingering for some reason, we also send a SIGKILL to force it down faster. Signed-off-by: Aaron Conole --- tools/testing/selftests/net/openvswitch/openvswitch.sh

[ovs-dev] [RFC 1/7] selftests: openvswitch: add test case error directories to clean list

2024-02-16 Thread Aaron Conole
Normally, the openvswitch selftests don't keep error files around, but if debugging, there is an option to keep these files. The 'clean' target should be informed that they exist to ensure they are deleted properly. Signed-off-by: Aaron Conole ---

[ovs-dev] [RFC 5/7] selftests: openvswitch: make arping test a bit 'slower'

2024-02-16 Thread Aaron Conole
The arping test transmits a single packet and immediately tries to pull the log for upcall details. This works fine in practice on most systems but can fail under a slower VM where it can take a while for the log data to be written. By adding addtional transmits we give the system time to write,

[ovs-dev] [RFC 2/7] selftests: openvswitch: be more verbose with selftest debugging

2024-02-16 Thread Aaron Conole
The openvswitch selftest is difficult to debug for anyone that isn't directly familiar with the openvswitch module and the specifics of the test cases. Many times when something fails, the debug log will be sparsely populated and it takes some time to understand where a failure occured. Increase

[ovs-dev] [RFC 0/7] selftests: openvswitch: cleanups for running as selftests

2024-02-16 Thread Aaron Conole
The series is a host of cleanups to the openvswitch selftest suite which should be ready to run under the netdev selftest runners using vng. For now, the testing has been done with RW directories, but additional testing will be done to try and keep it all as RO to be more friendly. There is one

Re: [ovs-dev] [PATCH ovn v2] ci: Update crun in Cirrus CI cloud image.

2024-02-16 Thread Numan Siddique
On Fri, Feb 16, 2024 at 9:52 AM Dumitru Ceara wrote: > > On 2/16/24 14:40, Ales Musil wrote: > > There are some issues with older crun and newer kernel > > combination [0]. Unfortunately Ubuntu 23.10 falls into this > > category and the jobs will often time fail. Temoprarily use > > newer crun

Re: [ovs-dev] [PATCH branch-3.3 0/2] Release patches for v3.3.0.

2024-02-16 Thread Ilya Maximets
CC: Aaron, Simon. :) On 2/16/24 12:46, Ilya Maximets wrote: > It's time for an OVS 3.3 release! > > The plan is to accept a couple more fixes before the actual release, > namely checksum offloading fixes, but sending this set now to get > it reviewed. > > Ilya Maximets (2): > Set release date

Re: [ovs-dev] [PATCH ovn v2] ci: Update crun in Cirrus CI cloud image.

2024-02-16 Thread Dumitru Ceara
On 2/16/24 14:40, Ales Musil wrote: > There are some issues with older crun and newer kernel > combination [0]. Unfortunately Ubuntu 23.10 falls into this > category and the jobs will often time fail. Temoprarily use > newer crun from git that has the fix [1]. > > [0]

[ovs-dev] [PATCH ovn] northd: Fix NAT configuration with --add-route option for gw-router.

2024-02-16 Thread Lorenzo Bianconi
Enable automatic static route configuration when NAT is created with --ad-route option for gw routers similar to what is currently supported for distributed routers with gw_router_ports. Reported-at: https://issues.redhat.com/browse/FDP-244 Signed-off-by: Lorenzo Bianconi --- northd/northd.c

[ovs-dev] [PATCH ovn v2] ci: Update crun in Cirrus CI cloud image.

2024-02-16 Thread Ales Musil
There are some issues with older crun and newer kernel combination [0]. Unfortunately Ubuntu 23.10 falls into this category and the jobs will often time fail. Temoprarily use newer crun from git that has the fix [1]. [0] https://github.com/containers/crun/pull/1309 [1]

[ovs-dev] [PATCH branch-3.3 2/2] Prepare for 3.3.1.

2024-02-16 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index fb3ec..4bfb341cf 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v3.3.1 - xx xxx

[ovs-dev] [PATCH branch-3.3 1/2] Set release date for 3.3.0.

2024-02-16 Thread Ilya Maximets
Beside the date update, moving the mdb NEWS entry to a more appropriate place - ovs-appctl section. Signed-off-by: Ilya Maximets --- NEWS | 6 +++--- debian/changelog | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/NEWS b/NEWS index e4eedb5b4..fb3ec 100644

[ovs-dev] [PATCH branch-3.3 0/2] Release patches for v3.3.0.

2024-02-16 Thread Ilya Maximets
It's time for an OVS 3.3 release! The plan is to accept a couple more fixes before the actual release, namely checksum offloading fixes, but sending this set now to get it reviewed. Ilya Maximets (2): Set release date for 3.3.0. Prepare for 3.3.1. NEWS | 9 ++---

Re: [ovs-dev] [PATCH v2] dpif-netdev: Increase MAX_RECIRC_DEPTH to 8.

2024-02-16 Thread Jakob Meng
On 16.02.24 00:03, Ilya Maximets wrote: > On 2/15/24 14:23, Simon Horman wrote: >> On Thu, Feb 15, 2024 at 09:16:38AM +0100, Jakob Meng wrote: >>> On 30.01.24 10:44, Simon Horman wrote: On Fri, Jan 26, 2024 at 02:24:51PM +0100, jm...@redhat.com wrote: > From: Jakob Meng > > In a