Re: [ovs-dev] [FYI][PATCH] tracing/treewide: Remove second parameter of __assign_str()

On Thu, 14 Mar 2024 09:57:57 -0700 Alison Schofield wrote: > On Fri, Feb 23, 2024 at 12:56:34PM -0500, Steven Rostedt wrote: > > From: "Steven Rostedt (Google)" > > > > [ > >This is a treewide change. I will likely re-create this patch again in > >the second week of the merge window of

Re: [ovs-dev] [PATCH OVN] Add support to make fdb table local to the chassis.

> On 14-Mar-2024, at 9:07 PM, Dumitru Ceara wrote: > > On 3/14/24 15:21, Naveen Yerramneni wrote: >> >> >>> On 08-Mar-2024, at 2:37 PM, Ales Musil wrote: >>> >>> >>> >>> On Wed, Mar 6, 2024 at 8:24 PM Naveen Yerramneni >>> wrote: >>> >>> On 18-Dec-2023, at 8:53 PM, Dumitru Ceara

Re: [ovs-dev] [PATCH OVN] Add support to make fdb table local to the chassis.

On 3/14/24 15:21, Naveen Yerramneni wrote: > > >> On 08-Mar-2024, at 2:37 PM, Ales Musil wrote: >> >> >> >> On Wed, Mar 6, 2024 at 8:24 PM Naveen Yerramneni >> wrote: >> >> >>> On 18-Dec-2023, at 8:53 PM, Dumitru Ceara wrote: >>> >>> On 12/18/23 16:17, Naveen Yerramneni wrote:

Re: [ovs-dev] [PATCH OVN v2] DHCP Relay Agent support for overlay subnets.

On Sun, Mar 3, 2024 at 11:20 PM Naveen Yerramneni wrote: > > This patch contains changes to enable DHCP Relay Agent support for > overlay subnets. > > USE CASE: > -- > - Enable IP address assignment for overlay subnets from the centralized > DHCP server present in the

Re: [ovs-dev] [PATCH OVN] Add support to make fdb table local to the chassis.

> On 08-Mar-2024, at 2:37 PM, Ales Musil wrote: > > > > On Wed, Mar 6, 2024 at 8:24 PM Naveen Yerramneni > wrote: > > > > On 18-Dec-2023, at 8:53 PM, Dumitru Ceara wrote: > > > > On 12/18/23 16:17, Naveen Yerramneni wrote: > >> > >> > >>> On 18-Dec-2023, at 7:26 PM, Dumitru Ceara

Re: [ovs-dev] [PATCH 3/3] netdev-dpdk: Fix tunnel type check during Tx offload preparation.

On Wed, Mar 13, 2024 at 1:29 PM Ilya Maximets wrote: > > Tunnel types are not flags, but 4-bit fields, so checking them with > a simple binary 'and' is incorrect and may produce false-positive > matches. > > While the current implementation is unlikely to cause any issues today, > since both

Re: [ovs-dev] [PATCH 2/3] netdev-dpdk: Fix TCP check during Tx offload preparation.

On Wed, Mar 13, 2024 at 1:29 PM Ilya Maximets wrote: > > RTE_MBUF_F_TX_TCP_CKSUM is not a flag, but a 2-bit field, so checking > it with a simple binary 'and' is incorrect. For example, this check > will succeed for a packet with UDP checksum requested as well. > > Fix the check to avoid wrongly

Re: [ovs-dev] [PATCH 1/3] netdev-dpdk: Clear inner packet marks if no inner offloads requested.

On Wed, Mar 13, 2024 at 1:29 PM Ilya Maximets wrote: > > In some cases only outer offloads may be requested for a tunneled > packet. In this case there is no need to mark the type of an > inner packet. Clean these flags up to avoid potential confusion > of DPDK drivers. > > Fixes: 084c8087292c

Re: [ovs-dev] [Patch ovn v2 2/2] northd: Fix direct access to SNAT network on DR.

Hello all, I have one more follow-up regarding the comments in v1. @amusil, you were concerned about the impact this change would have on the performance so I ran some tests to try to gauge it. I used following setup with two physical hosts connected over switch: |Physical ext. |

[ovs-dev] [PATCH] ofproto-dpif-upcall: try lock for umap iteration during sweep

A potential race condition happened with the following 3 threads: * PMD thread replaced the old_ukey and transitioned the state to UKEY_DELETED. * RCU thread is freeing the old_ukey mutex. * While the revalidator thread is trying to lock the old_ukey mutex. Then vswitchd process aborts at the