[ovs-dev] [PATCH] Use listen backlog = 64 for all connections.

Before the patch, the size of the backlog depended on the type of socket (UNIX vs INET) as well as on the language (C vs Python), specifically: - python used backlog size = 10 for all sockets; - C used 64 for UNIX sockets but 10 for INET sockets. This consolidates the values across the board. It

[ovs-dev] [PATCH net] net: openvswitch: fix unwanted error log on timeout policy probing

On startup, ovs-vswitchd probes different datapath features including support for timeout policies. While probing, it tries to execute certain operations with OVS_PACKET_ATTR_PROBE or OVS_FLOW_ATTR_PROBE attributes set. These attributes tell the openvswitch module to not log any errors when they

Re: [ovs-dev] [PATCH ovn] northd: Add support for disabling vxlan mode.

re-sending email because ovs list rejected previous its content for some reason: Hi Ihar, thanks for your quick reaction! I didn’t see mentioned thread, but I think that it is not safe enough to have automatic detection of this scenario here. Imagine: for VXLAN with HW VTEP scenario besides

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Fallback to non tunnel offloading API.

On 4/3/24 19:40, David Marchand wrote: > On Thu, Mar 28, 2024 at 10:16 AM David Marchand > wrote: >> >> The outer checksum offloading API in DPDK is ambiguous and was >> added by Intel folks with the assumption that any outer offloading >> always goes with an inner offloading request. >> >> With

Re: [ovs-dev] [PATCH ovn] northd: Add support for disabling vxlan mode.

Thank you Vladislav. FYI it was reported in the past in https://mail.openvswitch.org/pipermail/ovs-discuss/2022-July/051931.html but fell through cracks then. Thanks for picking it up! In your patch, you introduce a new config option to disable the 'vxlan-mode' behavior. This will definitely

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Fallback to non tunnel offloading API.

On Thu, Mar 28, 2024 at 10:16 AM David Marchand wrote: > > The outer checksum offloading API in DPDK is ambiguous and was > added by Intel folks with the assumption that any outer offloading > always goes with an inner offloading request. > > With net/i40e and net/ice drivers, requesting outer ip

Re: [ovs-dev] [PATCH v14 4/6] dpif: Probe support for OVS_ACTION_ATTR_DROP.

On 4/3/24 16:35, Eric Garver wrote: > Kernel support has been added for this action. As such, we need to probe > the datapath for support. > > Signed-off-by: Eric Garver > --- > include/linux/openvswitch.h | 2 +- > lib/dpif.c | 6 ++- > lib/dpif.h | 2 +- >

Re: [ovs-dev] [PATCH ovn v2 3/3] pinctrl: Fixed 100% cpu on ovs connection loss.

Thanks Xavier and Ales. I pushed this to main and all branches back to branch-23.06. On 3/28/24 04:50, Ales Musil wrote: On Tue, Mar 26, 2024 at 12:55 PM Xavier Simonart wrote: This issue is happening for instance when running test "ovn-controller - Chassis other_config". Signed-off-by:

Re: [ovs-dev] [PATCH ovn v2 2/3] pinctrl: Fix missing MAC_Bindings.

Thanks Xavier and Ales. I addresed Ales's finding and pushed this to main and all branches back to branch-23.06. On 3/28/24 04:48, Ales Musil wrote: On Tue, Mar 26, 2024 at 12:55 PM Xavier Simonart wrote: Pinctrl is responsible of creating MAC_Bindings on peer router datapaths. However,

Re: [ovs-dev] [PATCH ovn v2 1/3] tests: Add macros to pause controller updates.

Thanks Xavier and Ales. I addresed Ales's finding and pushed this to main and all branches back to branch-23.06. On 3/28/24 04:48, Ales Musil wrote: On Tue, Mar 26, 2024 at 12:55 PM Xavier Simonart wrote: Such macros can then be used for instance to create condition where sb is seen as

Re: [ovs-dev] [PATCH v7] rhel: make the version, displayed to the user, customizable

Bleep bloop. Greetings Timothy Redaelli, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: The subject summary should start with a capital. WARNING: The subject summary

[ovs-dev] [PATCH v7] rhel: make the version, displayed to the user, customizable

Since on CentOS/RHEL the builds are based on stable branches and not on tags for debugging purpose it's better to have the downstream version as version so it's easier to know which commits are included in a build. This commit adds --with-version-suffix as ./configure option in order to set an

[ovs-dev] [PATCH v14 5/6] tests: system-traffic: Add coverage for drop action.

Exercise the drop action in the datapath. This specific tests triggers an xlate_error. For the kernel datapath skb drop reasons can then be seen while this test runs. # perf trace -e skb:kfree_skb --filter="reason >= 0x3" 0.000 ping/1275884 skb:kfree_skb(skbaddr: 0x8acd76546000, \

[ovs-dev] [PATCH v14 0/6] dpif: probe support for OVS_ACTION_ATTR_DROP

v14: - remove atomic_init() - add bogus dl_type to feature probe - ovs_assert() that check_drop_action() returns false when expected - add and use missing enum ovs_dec_ttl_attr v13: - use macros strip_ptype and strip_eth in test v12: - new patch to verify re-probe - don't mention hw

[ovs-dev] [PATCH v14 2/6] dpif: Make get_datapath_cap() access support by pointer.

This avoids copying the support struct onto the stack. Acked-by: Eelco Chaudron Signed-off-by: Eric Garver --- ofproto/ofproto-dpif.c | 59 +- 1 file changed, 29 insertions(+), 30 deletions(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c

[ovs-dev] [PATCH v14 6/6] tests: system-offload-traffic: Verify re-probe of drop action.

Verify that the explicit drop action is re-probed if the hw-offload flag is changed. Acked-by: Eelco Chaudron Signed-off-by: Eric Garver --- tests/system-offloads-traffic.at | 12 1 file changed, 12 insertions(+) diff --git a/tests/system-offloads-traffic.at

[ovs-dev] [PATCH v14 3/6] dpif: Support atomic_bool field type.

The next commit will convert a dp feature from bool to atomic_bool. As such we have to add support to the macros and functions. We must pass by reference instead of pass by value because all the atomic operations require a reference. Acked-by: Eelco Chaudron Signed-off-by: Eric Garver ---

[ovs-dev] [PATCH v14 4/6] dpif: Probe support for OVS_ACTION_ATTR_DROP.

Kernel support has been added for this action. As such, we need to probe the datapath for support. Signed-off-by: Eric Garver --- include/linux/openvswitch.h | 2 +- lib/dpif.c | 6 ++- lib/dpif.h | 2 +- ofproto/ofproto-dpif.c | 77

[ovs-dev] [PATCH v14 1/6] dpif: Stub out unimplemented action OVS_ACTION_ATTR_DEC_TTL.

This is prep for adding a different OVS_ACTION_ATTR_ enum value. This action, OVS_ACTION_ATTR_DEC_TTL, is not actually implemented. However, to make -Werror happy we must add a case to all existing switches. Signed-off-by: Eric Garver --- include/linux/openvswitch.h | 9 +

Re: [ovs-dev] [PATCH v7 1/2] util: Support checking for kernel versions.

Felix Huettner via dev writes: > Extract checking for a given kernel version to a separate function. > It will be used also in the next patch. > > Acked-by: Mike Pattrick > Acked-by: Eelco Chaudron > Signed-off-by: Felix Huettner > --- Acked-by: Aaron Conole > v6->v7: none > v5->v6: > -

Re: [ovs-dev] [PATCH ovn] northd: Add support for disabling vxlan mode.

The failed new testcase assumes that patch [1] is applied. Should I resend them both as a single patchset? 1: https://patchwork.ozlabs.org/project/ovn/patch/20240401121510.758326-1-odiv...@gmail.com/ > On 3 Apr 2024, at 13:34, Vladislav Odintsov wrote: > > Commit [1] introduced a "vxlan mode"

Re: [ovs-dev] [PATCH v13 4/6] dpif: Probe support for OVS_ACTION_ATTR_DROP.

On Wed, Apr 03, 2024 at 12:42:25AM +0200, Ilya Maximets wrote: > On 4/3/24 00:28, Eric Garver wrote: > > On Fri, Mar 29, 2024 at 12:26:11AM +0100, Ilya Maximets wrote: > >> On 3/22/24 14:54, Eric Garver wrote: > > [..] > >>> @@ -1649,8 +1693,8 @@ check_support(struct dpif_backer *backer) > >>>

Re: [ovs-dev] [PATCH ovn] controller: change dns resolution to async.

References: <20240403112904.139377-1-naveen.yerramn...@nutanix.com> Bleep bloop. Greetings Naveen Yerramneni, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: The

[ovs-dev] [PATCH ovn] controller: change dns resolution to async.

Currently DNS resolution is a blocking call in OVN controller. If DNS server is not reachable for any reason then, ovn-controller thread blocks for longer time and other events are not processed. Ex: If we try to run ovn-appctl commands during this then, ovn-controller will not respond for a

Re: [ovs-dev] [PATCH v2] conntrack: Do not use icmp reverse helper for icmpv6.

On 3/28/24 17:56, Paolo Valerio wrote: > In the flush tuple code path, while populating the conn_key, > reverse_icmp_type() gets called for both icmp and icmpv6 cases, > while, depending on the proto, its respective helper should be > called, instead. > > The above leads to an abort: > > [...] >

Re: [ovs-dev] [PATCH v2] conntrack: Fix SNAT with exhaustion system test.

On 3/28/24 17:18, Paolo Valerio wrote: > Recent kernels introduced a mechanism that allows to evict colliding > entries in a closing state whereas they were previously considered as > parts of a non-recoverable clash. > This new behavior makes "conntrack - SNAT with port range with > exhaustion

[ovs-dev] [PATCH ovn] northd: Add support for disabling vxlan mode.

Commit [1] introduced a "vxlan mode" concept. It brought a limitation for available tunnel IDs because of lack of space in VXLAN VNI. In vxlan mode OVN is limited by 4095 datapaths (LRs or non-transit LSs) and 2047 logical switch ports per datapath. Prior to this patch vxlan mode was enabled

[ovs-dev] [PATCH ovn] northd: Add support for disabling vxlan mode.

Commit [1] introduced a "vxlan mode" concept. It brought a limitation for available tunnel IDs because of lack of space in VXLAN VNI. In vxlan mode OVN is limited by 4095 datapaths (LRs or non-transit LSs) and 2047 logical switch ports per datapath. Prior to this patch vxlan mode was enabled

[ovs-dev] [PATCH v2 ovn] northd: Fix pmtud for non routed traffic.

Similar to what is already implemented for routed e/w traffic, introduce pmtud support for e/w traffic between two logical switch ports connected to the same logical switch, but running on two different hypervisors. Acked-by: Mark Michelson Reported-at: https://issues.redhat.com/browse/FDP-362

Re: [ovs-dev] [PATCH] [PATCH v2] ofproto: Fix mod flow table name not to take effect.

On Wed, Apr 03, 2024 at 03:11:36PM +0800, Yuhao zhou via dev wrote: > From: "zhouyuhao.philozhou" > > When mod a flow table's name with table's prefix name, there > will be no change. Because when check whether the new and old > name are the same, only compare the length of the new name. > >

[ovs-dev] [PATCH ovn v2] controller: Allow br-int connection via other methods.

The br-int connection is hardcoded to use unix socket, which requires for the socket to be visible for ovn-controller. This is achievable in container by mounting the socket, but in turn the container requires additional privileges. Add option to vswitchd external-ids that allows to specify

Re: [ovs-dev] [PATCH ovn] controller: Allow br-int connection via other methods.

On 4/2/24 16:32, Ales Musil wrote: > On Tue, Apr 2, 2024 at 4:25 PM Ilya Maximets wrote: > >> On 4/2/24 16:17, Ales Musil wrote: >>> >>> >>> On Tue, Apr 2, 2024 at 4:03 PM Ilya Maximets > > wrote: >>> >>> On 4/2/24 15:36, Ales Musil wrote: >>> > >>> > >>>

[ovs-dev] [PATCH] [PATCH v2] ofproto: Fix mod flow table name not to take effect.

From: "zhouyuhao.philozhou" When mod a flow table's name with table's prefix name, there will be no change. Because when check whether the new and old name are the same, only compare the length of the new name. Case: table 10: "good" There will be no change if mod the table's name with "g"

Re: [ovs-dev] [PATCH ovn v2] ofctrl: Wait at S_WAIT_BEFORE_CLEAR only once.

On Tue, Apr 2, 2024 at 11:11 PM Han Zhou wrote: > > > > On Tue, Apr 2, 2024 at 10:48 PM Han Zhou wrote: > > > > > > > > On Thu, Mar 28, 2024 at 1:29 PM Mark Michelson wrote: > > > > > > Thanks Han, > > > > > > Acked-by: Mark Michelson > > > > Thanks Mark. Applied to main. > > Also backported

[ovs-dev] [PATCH] ofproto: Fix mod flow table name not to take effect.

From: "zhouyuhao.philozhou" When mod a flow table's name with table's prefix name, there will be no change. Because when check whether the new and old name are the same, only compare the length of the new name. Case: table 10: "good" There will be no change if mod the table's name with "g"

Re: [ovs-dev] [PATCH ovn v2] ofctrl: Wait at S_WAIT_BEFORE_CLEAR only once.

On Tue, Apr 2, 2024 at 10:48 PM Han Zhou wrote: > > > > On Thu, Mar 28, 2024 at 1:29 PM Mark Michelson wrote: > > > > Thanks Han, > > > > Acked-by: Mark Michelson > > Thanks Mark. Applied to main. Also backported down to branch-23.06 Han > > Han > > > > On 3/28/24 02:58, Han Zhou wrote: > > >