Re: [ovs-dev] [PATCH ovn] docs: Typo. Remove duplicated "to".

Great! Thank you for the fast review! Could you also look at https://github.com/ovn-org/ovn-website/pull/81 ? > On Wed, May 8, 2024 at 1:38 PM Igor Zhukov wrote: > >> I came across a new patch recently: >>

Re: [ovs-dev] [PATCH ovn 2/2 branch-24.03] northd, controller: Handle tunnel_key change consistently.

On Thu, May 9, 2024 at 3:36 AM Ales Musil wrote: > > Currently the tunnel_key change for either LS/LR/LSP/LRP wasn't > consistent. That would lead to a situations when some old would still > be present, breaking the connection especially for already existing > FDBs and MAC bindings. > > Make sure

Re: [ovs-dev] [PATCH ovn] docs: Typo. Remove duplicated "to".

On Wed, May 8, 2024 at 1:38 PM Igor Zhukov wrote: > > I came across a new patch recently: > https://patchwork.ozlabs.org/project/ovn/patch/20240423095006.24429-1-martin.kal...@canonical.com/ > After that, I searched the OVN source code for instances of "to to" and > discovered two more

Re: [ovs-dev] [PATCH ovn] Documentation: change link from ovs to ovn in the "Submitted-at" example.

On Wed, May 8, 2024 at 11:46 AM Igor Zhukov wrote: > > It's a mega nitpick, but I observed that the example URL in the > "Submitted-at" points to the OVS repository instead of OVN. > > Signed-off-by: Igor Zhukov Thanks. Applied to main. Numan > --- >

Re: [ovs-dev] [PATCH ovn branch-24.03 1/2] Set release date for 24.03.2.

Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the

Re: [ovs-dev] [PATCH ovn branch-24.03 2/2] Prepare for 24.03.3.

Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless (NEWS). error: could not build fake ancestor hint:

[ovs-dev] [PATCH ovn branch-23.06 1/2] Set release date for 23.06.4.

Signed-off-by: Mark Michelson --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index a87cfd7ec..e98c2102c 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -OVN v23.06.4 - xx xxx +OVN v23.06.4 - 09 May 2024

[ovs-dev] [PATCH ovn branch-23.09 0/2] Release patches for v23.09.4.

Mark Michelson (2): Set release date for 23.09.4. Prepare for 23.09.5. NEWS | 6 +- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 13 insertions(+), 3 deletions(-) -- 2.44.0 ___ dev mailing list

[ovs-dev] [PATCH ovn branch-24.03 1/2] Set release date for 24.03.2.

Signed-off-by: Mark Michelson --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index ca3562425..4d16d97ff 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -OVN v24.03.2 - xx xxx +OVN v24.03.2 - 09 May 2024

[ovs-dev] [PATCH ovn branch-23.09 1/2] Set release date for 23.09.4.

Signed-off-by: Mark Michelson --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 97e1c41d5..5c80fa482 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -OVN v23.09.4 - xx xxx +OVN v23.09.4 - 09 May 2024

[ovs-dev] [PATCH ovn branch-23.06 0/2] Release patches for v23.06.4.

Mark Michelson (2): Set release date for 23.06.4. Prepare for 23.06.5. NEWS | 6 +- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 13 insertions(+), 3 deletions(-) -- 2.44.0 ___ dev mailing list

[ovs-dev] [PATCH ovn branch-23.06 2/2] Prepare for 23.06.5.

Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index e98c2102c..115db073a 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v23.06.5 - xx xxx

[ovs-dev] [PATCH ovn branch-23.09 2/2] Prepare for 23.09.5.

Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 5c80fa482..472594d16 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v23.09.5 - xx xxx

[ovs-dev] [PATCH ovn branch-24.03 2/2] Prepare for 24.03.3.

Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 4d16d97ff..9e4a52f46 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v24.03.3 - xx xxx

[ovs-dev] [PATCH ovn branch-24.03 0/2] Release patches for v24.03.2.

Mark Michelson (2): Set release date for 24.03.2. Prepare for 24.03.3. NEWS | 6 +- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 13 insertions(+), 3 deletions(-) -- 2.44.0 ___ dev mailing list

Re: [ovs-dev] [PATCH net] net: openvswitch: fix overwriting ct original tuple for ICMPv6

Ilya Maximets writes: > OVS_PACKET_CMD_EXECUTE has 3 main attributes: > - OVS_PACKET_ATTR_KEY - Packet metadata in a netlink format. > - OVS_PACKET_ATTR_PACKET - Binary packet content. > - OVS_PACKET_ATTR_ACTIONS - Actions to execute on the packet. > > OVS_PACKET_ATTR_KEY is parsed first to

Re: [ovs-dev] [PATCH ovn] northd: Add lsp option force_fdb_lookup.

On Thu, May 9, 2024 at 5:54 AM Shibir Basak wrote: > > Hi team, > > Could someone please review these changes? Sorry for the delay. I'll take a look and come back. Numan > > Thanks, > Shibir Basak > > > On 24-Apr-2024, at 12:15 PM, Shibir Basak wrote: > > > > This option is applicable only

Re: [ovs-dev] [PATCH ovn] northd: Add documentation for is_cr_port() and is_l3dgw_port().

On Tue, May 7, 2024 at 5:57 PM wrote: > > From: Numan Siddique > > Although these util functions are correct in their implementation, > they are confusing to the reader. Add proper documentation > and make the is_l3dgw_port() more clearer by checking if the > gateway chassis or ha chassis group

[ovs-dev] [PATCH ovn v2 3/3] Add support for overlay provider networks.

From: Numan Siddique It is expected that a provider network logical switch has a localnet logical switch port in order to bridge the overlay traffic to the underlay traffic. There can be some usecases where a overlay logical switch (without a localnet port) can act as a provider network and

[ovs-dev] [PATCH ovn v2 2/3] northd: Refactor chassisresident port checking.

From: Numan Siddique The implementation of util functions "is_cr_port()" and "is_l3dgw_port()" are confusing and not very intuitive. This patch adds some documentation. It also renames the struct ovn_port member 'l3dgw_port' to 'primary_port'. If struct ovn_port->primary_port is set, then it

[ovs-dev] [PATCH ovn v2 1/3] northd: Don't reparse lport's addresses while adding L2_LKUP flows.

From: Numan Siddique The addresses are already parsed and stored in the "struct ovn_port"'s lsp_addrs field. Signed-off-by: Numan Siddique --- northd/northd.c | 165 +--- 1 file changed, 59 insertions(+), 106 deletions(-) diff --git

[ovs-dev] [PATCH ovn v2 0/3] Overlay provider network support.

From: Numan Siddique This patch series adds support of overlay provider networks so that NAT can be supported on the logical switch subnet even if there are no localnet ports. v1 -> v2 -- * Added a new patch, patch 2 to the series to refactor the cr port code. This patch was earlier

Re: [ovs-dev] [PATCH ovn v4] controller: Track individual address set constants.

On 5/7/24 02:12, Han Zhou wrote: On Mon, May 6, 2024 at 10:37 PM Ales Musil > wrote: > > > > On Mon, May 6, 2024 at 8:41 PM Han Zhou > wrote: >> >> >> >> On Thu, May 2, 2024 at 10:35 PM Ales Musil > wrote: >>

Re: [ovs-dev] [PATCH net] net: openvswitch: fix overwriting ct original tuple for ICMPv6

I tested this patch by applying it to 6.8.9, and it addresses the issue I observed. On Thu, May 9, 2024 at 2:41 AM Ilya Maximets wrote: > > OVS_PACKET_CMD_EXECUTE has 3 main attributes: > - OVS_PACKET_ATTR_KEY - Packet metadata in a netlink format. > - OVS_PACKET_ATTR_PACKET - Binary packet

Re: [ovs-dev] [PATCH net] net: openvswitch: fix overwriting ct original tuple for ICMPv6

I tested this patch by applying it to 6.8.9, and it addresses the issue I observed. On Thu, May 9, 2024 at 2:41 AM Ilya Maximets wrote: > OVS_PACKET_CMD_EXECUTE has 3 main attributes: > - OVS_PACKET_ATTR_KEY - Packet metadata in a netlink format. > - OVS_PACKET_ATTR_PACKET - Binary packet

Re: [ovs-dev] [PATCH v2] utilities: Correct deletion reason in flow_reval_monitor.py.

On Wed, May 08, 2024 at 11:19:56AM +0200, Eelco Chaudron wrote: > The flow_reval_monitor.py script incorrectly reported the reasons for > FDR_PURGE and FDR_TOO_EXPENSIVE, as their descriptions were swapped. > This patch rectifies the order using a dictionary to avoid similar > problems in the

Re: [ovs-dev] [PATCH] ci: Set platform parameter when building DPDK.

On Tue, May 07, 2024 at 05:04:34PM +0200, David Marchand wrote: > This change has no impact, since -Dmachine=default gets converted by > DPDK into -Dplatform=generic (since v21.08, see the link to DPDK commit > below). Yet, switch to explicitly setting -Dplatform and avoid the > following warning:

Re: [ovs-dev] [PATCH v2] conntrack: Do not use {0} to initialize unions.

Xavier Simonart writes: > In the following case: > union ct_addr { > unsigned int ipv4; > struct in6_addr ipv6; > }; > union ct_addr zero_ip = {0}; > > The ipv6 field might not be properly initialized. > For instance, clang 18.1.1 does not initialize the ipv6 field. >

Re: [ovs-dev] [PATCH ovn] northd: Add lsp option force_fdb_lookup.

Hi team, Could someone please review these changes? Thanks, Shibir Basak > On 24-Apr-2024, at 12:15 PM, Shibir Basak wrote: > > This option is applicable only if the lsp is of default 'type' > i.e. type=empty_string (which is a VM (or VIF) interface) and the > lsp also has 'unknown'

[ovs-dev] [PATCH net] net: openvswitch: fix overwriting ct original tuple for ICMPv6

OVS_PACKET_CMD_EXECUTE has 3 main attributes: - OVS_PACKET_ATTR_KEY - Packet metadata in a netlink format. - OVS_PACKET_ATTR_PACKET - Binary packet content. - OVS_PACKET_ATTR_ACTIONS - Actions to execute on the packet. OVS_PACKET_ATTR_KEY is parsed first to populate sw_flow_key structure with

Re: [ovs-dev] [PATCH ovn 2/2 branch-24.03] northd, controller: Handle tunnel_key change consistently.

Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers:

Re: [ovs-dev] [PATCH ovn 1/2 branch-24.03] tests: Add macro for checking flows after recompute.

Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers:

[ovs-dev] [PATCH ovn 2/2 branch-24.03] northd, controller: Handle tunnel_key change consistently.

Currently the tunnel_key change for either LS/LR/LSP/LRP wasn't consistent. That would lead to a situations when some old would still be present, breaking the connection especially for already existing FDBs and MAC bindings. Make sure the FDB entries are up to date by removing them from DB when

[ovs-dev] [PATCH ovn 1/2 branch-24.03] tests: Add macro for checking flows after recompute.

From: Xavier Simonart The macro CHECK_FLOWS_AFTER_RECOMPUTE dumps the Openflows, then recomputes, then dumps again the Openflows, and finally compares both sets of flows. The test fails if flows are different. As of now, the macro cannot be used in all tests: many tests would fail as I+P does