[ovs-dev] [PATCH] table: Fix freeing global variable.

2024-05-13 Thread Yunjian Wang via dev
From: Pengfei Sun In function shash_replace_nocopy, argument to free() is the address of a global variable (argument passed by function table_print_json__), which is not memory allocated by malloc(). ovsdb-client -f json monitor Open_vSwitch --timestamp ASan reports:

Re: [ovs-dev] [PATCH v3] route-table: Add support for v4 via v6 route.

2024-05-13 Thread Ilya Maximets
On 5/14/24 00:11, William Tu wrote: > Add route-table support for ipv4 dst via ipv6. One use case is BGP > unnumbered, a mechanism that establishes peering sessions without the > need to explicitly configure IPv4 addresses on the interfaces involved > in the peering. Without using IPv4 address

[ovs-dev] [PATCH v3] route-table: Add support for v4 via v6 route.

2024-05-13 Thread William Tu via dev
Add route-table support for ipv4 dst via ipv6. One use case is BGP unnumbered, a mechanism that establishes peering sessions without the need to explicitly configure IPv4 addresses on the interfaces involved in the peering. Without using IPv4 address assignments, it uses link-local IPv6 addresses

Re: [ovs-dev] [PATCH] fix ct tp policy when create zone.

2024-05-13 Thread Ilya Maximets
On 5/6/24 06:05, Chandler Wu wrote: > From 5b4d479a9083272e56c51ef9521e6ef665dd534d Mon Sep 17 00:00:00 2001 > From: chandlerwu > Date: Mon, 6 May 2024 11:58:21 +0800 > Subject: [PATCH] Subject:[PATCH] fix ct tp policy when create zone. > > Signed-off-by: chandlerwu > --- > vswitchd/bridge.c |

Re: [ovs-dev] [RFC 08/11] netdev-offload-tc: Add sample support.

2024-05-13 Thread Adrian Moreno
On 5/13/24 2:38 PM, Adrian Moreno wrote: On 5/13/24 1:32 PM, Eelco Chaudron wrote: On 13 May 2024, at 10:44, Adrian Moreno wrote: On 5/10/24 12:06 PM, Eelco Chaudron wrote: On 24 Apr 2024, at 21:53, Adrian Moreno wrote: Offload the sample action if it contains psample information by

Re: [ovs-dev] [RFC 01/11] odp-util: Add support to new psample uAPI.

2024-05-13 Thread Adrian Moreno
On 5/10/24 3:06 PM, Ilya Maximets wrote: On 5/10/24 14:01, Eelco Chaudron wrote: On 10 May 2024, at 12:45, Adrian Moreno wrote: On 5/10/24 12:06 PM, Eelco Chaudron wrote: On 24 Apr 2024, at 21:53, Adrian Moreno wrote: The new odp sample attributes allow userspace to specify a group_id

Re: [ovs-dev] [PATCH v2] utilities: Correct deletion reason in flow_reval_monitor.py.

2024-05-13 Thread Ilya Maximets
On 5/8/24 11:19, Eelco Chaudron wrote: > The flow_reval_monitor.py script incorrectly reported the reasons for > FDR_PURGE and FDR_TOO_EXPENSIVE, as their descriptions were swapped. > This patch rectifies the order using a dictionary to avoid similar > problems in the future. > > In addition this

Re: [ovs-dev] [RFC 06/11] utilities: Add ovs-psample.

2024-05-13 Thread Eelco Chaudron
On 13 May 2024, at 14:50, Adrian Moreno wrote: > On 5/13/24 2:48 PM, Ilya Maximets wrote: >> On 5/13/24 13:10, Adrian Moreno wrote: >>> >>> >>> On 5/13/24 12:44 PM, Eelco Chaudron wrote: On 13 May 2024, at 9:01, Adrian Moreno wrote: > On 5/10/24 12:06 PM, Eelco Chaudron

Re: [ovs-dev] [PATCH v2 2/2] conntrack: Key connections by zone.

2024-05-13 Thread Paolo Valerio
Hi Peng, Peng He writes: > To seperate into N cmaps, why not use hash value divided by N? > FWIW, I think it makes sense to discuss the potential benefits of other approaches as well. They may even end up not being as performant as this one, but also some points to consider here are: - the

Re: [ovs-dev] [PATCH ovn] Do not reply on unicast arps for targets.

2024-05-13 Thread Dumitru Ceara
On 5/4/24 11:38, Vasyl Saienko wrote: > Hello Numan > > Thanks for review and feedback. > > On Fri, May 3, 2024 at 7:14 PM Numan Siddique wrote: > >> On Mon, Apr 22, 2024 at 2:54 AM Vasyl Saienko >> wrote: >>> >>> Reply only if target ethernet address is broadcast, if >>> address is specified

Re: [ovs-dev] [RFC 05/11] ofproto_dpif_xlate: Use psample for OFP samples.

2024-05-13 Thread Adrian Moreno
On 5/13/24 12:32 PM, Eelco Chaudron wrote: On 10 May 2024, at 13:15, Adrian Moreno wrote: On 5/10/24 12:06 PM, Eelco Chaudron wrote: On 24 Apr 2024, at 21:53, Adrian Moreno wrote: When a OFP_SAMPLE action is xlated and a dpif_psample object has been configured (via

Re: [ovs-dev] [RFC 06/11] utilities: Add ovs-psample.

2024-05-13 Thread Adrian Moreno
On 5/13/24 2:48 PM, Ilya Maximets wrote: On 5/13/24 13:10, Adrian Moreno wrote: On 5/13/24 12:44 PM, Eelco Chaudron wrote: On 13 May 2024, at 9:01, Adrian Moreno wrote: On 5/10/24 12:06 PM, Eelco Chaudron wrote: On 24 Apr 2024, at 21:53, Adrian Moreno wrote: This simple program

Re: [ovs-dev] [RFC 06/11] utilities: Add ovs-psample.

2024-05-13 Thread Ilya Maximets
On 5/13/24 13:10, Adrian Moreno wrote: > > > On 5/13/24 12:44 PM, Eelco Chaudron wrote: >> >> >> On 13 May 2024, at 9:01, Adrian Moreno wrote: >> >>> On 5/10/24 12:06 PM, Eelco Chaudron wrote: On 24 Apr 2024, at 21:53, Adrian Moreno wrote: > This simple program reads from psample

Re: [ovs-dev] [RFC 02/11] ofproto_dpif: Check for psample support.

2024-05-13 Thread Adrian Moreno
On 5/10/24 1:49 PM, Ilya Maximets wrote: On 5/10/24 13:03, Adrian Moreno wrote: On 5/10/24 12:06 PM, Eelco Chaudron wrote: On 24 Apr 2024, at 21:53, Adrian Moreno wrote: Only kernel datapath supports psample so check that the datapath is not userspace and that it accepts the new

Re: [ovs-dev] [RFC 01/11] odp-util: Add support to new psample uAPI.

2024-05-13 Thread Adrian Moreno
On 5/13/24 2:38 PM, Ilya Maximets wrote: On 5/13/24 09:17, Eelco Chaudron wrote: On 10 May 2024, at 15:06, Ilya Maximets wrote: On 5/10/24 14:01, Eelco Chaudron wrote: On 10 May 2024, at 12:45, Adrian Moreno wrote: On 5/10/24 12:06 PM, Eelco Chaudron wrote: On 24 Apr 2024, at

Re: [ovs-dev] [PATCH v2] conntrack: Fully initialize conn struct before insertion.

2024-05-13 Thread Simon Horman
On Fri, May 10, 2024 at 05:45:54PM +0200, Paolo Valerio wrote: > From: Mike Pattrick > > In case packets are concurrently received in both directions, there's > a chance that the ones in the reverse direction get received right > after the connection gets added to the connection tracker but

Re: [ovs-dev] [RFC 01/11] odp-util: Add support to new psample uAPI.

2024-05-13 Thread Ilya Maximets
On 5/13/24 09:17, Eelco Chaudron wrote: > > > On 10 May 2024, at 15:06, Ilya Maximets wrote: > >> On 5/10/24 14:01, Eelco Chaudron wrote: >>> >>> >>> On 10 May 2024, at 12:45, Adrian Moreno wrote: >>> On 5/10/24 12:06 PM, Eelco Chaudron wrote: > On 24 Apr 2024, at 21:53, Adrian Moreno

Re: [ovs-dev] [RFC 08/11] netdev-offload-tc: Add sample support.

2024-05-13 Thread Adrian Moreno
On 5/13/24 1:32 PM, Eelco Chaudron wrote: On 13 May 2024, at 10:44, Adrian Moreno wrote: On 5/10/24 12:06 PM, Eelco Chaudron wrote: On 24 Apr 2024, at 21:53, Adrian Moreno wrote: Offload the sample action if it contains psample information by creating a tc "sample" action with the user

Re: [ovs-dev] [PATCH] Subject: conntrack: Fully initialize conn struct before insertion.

2024-05-13 Thread Simon Horman
On Fri, May 10, 2024 at 05:43:51PM +0200, Paolo Valerio wrote: > From: Mike Pattrick > > In case packets are concurrently received in both directions, there's > a chance that the ones in the reverse direction get received right > after the connection gets added to the connection tracker but

Re: [ovs-dev] [Patch] ovsdb-client: Add missing arg to help for 'dump'.

2024-05-13 Thread Simon Horman
On Fri, May 10, 2024 at 01:31:10PM +0200, martin.kal...@canonical.com wrote: > Thanks for the merge and backports Simon. > > On Tue, 2024-05-07 at 17:26 +0100, Simon Horman wrote: > > On Tue, May 07, 2024 at 03:16:25PM +0100, Simon Horman wrote: > > > On Fri, May 03, 2024 at 02:22:27PM +0200, > >

Re: [ovs-dev] [RFC 08/11] netdev-offload-tc: Add sample support.

2024-05-13 Thread Eelco Chaudron
On 13 May 2024, at 10:44, Adrian Moreno wrote: > On 5/10/24 12:06 PM, Eelco Chaudron wrote: >> On 24 Apr 2024, at 21:53, Adrian Moreno wrote: >> >>> Offload the sample action if it contains psample information by creating >>> a tc "sample" action with the user cookie inside the action's cookie.

Re: [ovs-dev] [RFC 06/11] utilities: Add ovs-psample.

2024-05-13 Thread Adrian Moreno
On 5/13/24 12:44 PM, Eelco Chaudron wrote: On 13 May 2024, at 9:01, Adrian Moreno wrote: On 5/10/24 12:06 PM, Eelco Chaudron wrote: On 24 Apr 2024, at 21:53, Adrian Moreno wrote: This simple program reads from psample and prints the packets to stdout. It's useful for quickly collecting

Re: [ovs-dev] [RFC 06/11] utilities: Add ovs-psample.

2024-05-13 Thread Eelco Chaudron
On 13 May 2024, at 9:01, Adrian Moreno wrote: > On 5/10/24 12:06 PM, Eelco Chaudron wrote: >> On 24 Apr 2024, at 21:53, Adrian Moreno wrote: >> >>> This simple program reads from psample and prints the packets to stdout. >>> It's useful for quickly collecting sampled packets. >> >> See some

Re: [ovs-dev] [RFC 05/11] ofproto_dpif_xlate: Use psample for OFP samples.

2024-05-13 Thread Eelco Chaudron
On 10 May 2024, at 13:15, Adrian Moreno wrote: > On 5/10/24 12:06 PM, Eelco Chaudron wrote: >> On 24 Apr 2024, at 21:53, Adrian Moreno wrote: >> >>> When a OFP_SAMPLE action is xlated and a dpif_psample object has been >>> configured (via Flow_Sample_Collector_Set table) with the same >>>

Re: [ovs-dev] [RFC 11/11] tests: Add test for sample offloading.

2024-05-13 Thread Adrian Moreno
On 5/10/24 12:06 PM, Eelco Chaudron wrote: On 24 Apr 2024, at 21:53, Adrian Moreno wrote: Signed-off-by: Adrian Moreno --- tests/system-common-macros.at| 4 +++ tests/system-offloads-traffic.at | 53 2 files changed, 57 insertions(+) diff --git

Re: [ovs-dev] [RFC 10/11] ofproto-dpif-psample: Add command to show stats.

2024-05-13 Thread Adrian Moreno
On 5/10/24 12:06 PM, Eelco Chaudron wrote: On 24 Apr 2024, at 21:53, Adrian Moreno wrote: Maybe add a small description to this patch. Signed-off-by: Adrian Moreno --- ofproto/ofproto-dpif-psample.c | 59 ++ ofproto/ofproto-dpif-psample.h | 1 +

Re: [ovs-dev] [RFC 08/11] netdev-offload-tc: Add sample support.

2024-05-13 Thread Adrian Moreno
On 5/10/24 12:06 PM, Eelco Chaudron wrote: On 24 Apr 2024, at 21:53, Adrian Moreno wrote: Offload the sample action if it contains psample information by creating a tc "sample" action with the user cookie inside the action's cookie. Avoid using the "sample" action's cookie to store the

Re: [ovs-dev] [RFC 03/11] ofproto: Add ofproto-dpif-psample.

2024-05-13 Thread Eelco Chaudron
On 13 May 2024, at 8:45, Adrian Moreno wrote: > On 5/10/24 12:06 PM, Eelco Chaudron wrote: >> On 24 Apr 2024, at 21:53, Adrian Moreno wrote: >> >>> Add a new resource in ofproto-dpif and the corresponding API in >>> ofproto_provider.h to represent and change psample configuration. >> >> See

Re: [ovs-dev] [PATCH ovn v4] controller: Track individual address set constants.

2024-05-13 Thread Sri kor
Thanks Ales, This address set is not present in SB DB. -Srini On Sun, May 12, 2024 at 10:26 PM Ales Musil wrote: > > > On Sun, May 12, 2024 at 11:17 PM Sri kor wrote: > >> Hi @num...@ovn.org @Ales Musil , >> Currently we are on OVN 23.09. We are facing the following syntax >> error with

Re: [ovs-dev] [RFC 01/11] odp-util: Add support to new psample uAPI.

2024-05-13 Thread Eelco Chaudron
On 10 May 2024, at 15:06, Ilya Maximets wrote: > On 5/10/24 14:01, Eelco Chaudron wrote: >> >> >> On 10 May 2024, at 12:45, Adrian Moreno wrote: >> >>> On 5/10/24 12:06 PM, Eelco Chaudron wrote: On 24 Apr 2024, at 21:53, Adrian Moreno wrote: > The new odp sample attributes allow

Re: [ovs-dev] [PATCH v3 4/6] netdev-dpdk: Refactor TSO request code.

2024-05-13 Thread David Marchand
Hello Kevin, Thanks for reviewing. On Fri, May 10, 2024 at 11:50 PM Kevin Traynor wrote: > > On 19/04/2024 15:06, David Marchand wrote: > > Replace check on th == NULL with an assert() because dp_packet_l4(pkt) > > is priorly used to compute (outer) L3 length. > > > > Besides, filling l4_len

Re: [ovs-dev] [RFC 07/11] netlink-offload-tc: Rename act_cookie->flow_cookie.

2024-05-13 Thread Adrian Moreno
On 5/10/24 12:06 PM, Eelco Chaudron wrote: On 24 Apr 2024, at 21:53, Adrian Moreno wrote: In preparation to allowing certain actions to have a cookie that does not represent the entire flow, rename flower->act_cookie to flower->flow_cookie. This patch does not introduce any behavioral

Re: [ovs-dev] [RFC 06/11] utilities: Add ovs-psample.

2024-05-13 Thread Adrian Moreno
On 5/10/24 12:06 PM, Eelco Chaudron wrote: On 24 Apr 2024, at 21:53, Adrian Moreno wrote: This simple program reads from psample and prints the packets to stdout. It's useful for quickly collecting sampled packets. See some comments below, did not review the actual sample application in

Re: [ovs-dev] [RFC 03/11] ofproto: Add ofproto-dpif-psample.

2024-05-13 Thread Adrian Moreno
On 5/10/24 12:06 PM, Eelco Chaudron wrote: On 24 Apr 2024, at 21:53, Adrian Moreno wrote: Add a new resource in ofproto-dpif and the corresponding API in ofproto_provider.h to represent and change psample configuration. See comments below. //Eelco Signed-off-by: Adrian Moreno ---

Re: [ovs-dev] [RFC 04/11] vswitchd: Add psample to schema and configure it.

2024-05-13 Thread Adrian Moreno
On 5/10/24 12:06 PM, Eelco Chaudron wrote: On 24 Apr 2024, at 21:53, Adrian Moreno wrote: Add a psample_group field to the Flow Sample Collector Set table and use it to configure the psample ofproto layer. See comments below, Eelco Signed-off-by: Adrian Moreno --- vswitchd/bridge.c