Re: [ovs-dev] [PATCH ovn] northd: Fix an issue wrt mac binding aging.

2024-05-15 Thread Ales Musil
On Thu, May 16, 2024 at 7:24 AM Indrajitt Valsaraj < indrajitt.valsa...@nutanix.com> wrote: > Issue: > In case of a Logical_Router without mac_binding_age_threshold set or a > Logical_Router with an incorrectly formatted mac_binding_threshold option, > entries were not being purged from the Mac

[ovs-dev] [PATCH ovn] northd: Fix an issue wrt mac binding aging.

2024-05-15 Thread Indrajitt Valsaraj
Issue: In case of a Logical_Router without mac_binding_age_threshold set or a Logical_Router with an incorrectly formatted mac_binding_threshold option, entries were not being purged from the Mac Binding table in SouthBound. This was because in the function `en_mac_binding_aging_run` in case of

Re: [ovs-dev] [PATCH ovn] ovn-ctl: Support for --config-file ovsdb-server option.

2024-05-15 Thread Vladislav Odintsov
Thanks Numan! regards, Vladislav Odintsov > On 15 May 2024, at 23:55, Numan Siddique wrote: > > On Fri, May 3, 2024 at 2:05 AM Ales Musil wrote: >> >>> On Tue, Apr 23, 2024 at 6:43 PM Vladislav Odintsov >>> wrote: >>> >>> Since OVS 3.3.0 ovsdb-server accepts databases and remotes

Re: [ovs-dev] [PATCH ovn] docs: List supported rolling upgrade paths.

2024-05-15 Thread Numan Siddique
On Fri, May 3, 2024 at 1:43 AM Ales Musil wrote: > > On Fri, Apr 26, 2024 at 10:49 PM Ihar Hrachyshka > wrote: > > > The wording above is not completely clear without these scenarios > > listed. A confused reader may incorrectly read it as: > > > > ``` > > Only LTS-to-LTS is supported for

Re: [ovs-dev] [PATCH ovn] docs: Explain nature of ovs dependency.

2024-05-15 Thread Numan Siddique
On Fri, May 3, 2024 at 1:43 AM Ales Musil wrote: > > On Fri, Apr 26, 2024 at 10:35 PM Ihar Hrachyshka > wrote: > > > The dependency is during build time, not runtime. > > > > Signed-off-by: Ihar Hrachyshka > > --- > > Documentation/intro/install/ovn-upgrades.rst | 18 -- > > 1

Re: [ovs-dev] [PATCH v29 0/8] Add offload support for sFlow

2024-05-15 Thread Ilya Maximets
On 3/26/24 03:30, Chris Mi wrote: > This patch set adds offload support for sFlow. > > Psample is a genetlink channel for packet sampling. TC action act_sample > uses psample to send sampled packets to userspace. > > When offloading sample action to TC, userspace creates a unique ID to > map

Re: [ovs-dev] [PATCH ovn] ovn-ctl: Support for --config-file ovsdb-server option.

2024-05-15 Thread Numan Siddique
On Fri, May 3, 2024 at 2:05 AM Ales Musil wrote: > > On Tue, Apr 23, 2024 at 6:43 PM Vladislav Odintsov > wrote: > > > Since OVS 3.3.0 ovsdb-server accepts databases and remotes configuration > > via JSON text file. This patch adds support for such option. > > > > Signed-off-by: Vladislav

[ovs-dev] [PATCH] ipf: Only add fragments to batch of same dl_type.

2024-05-15 Thread Mike Pattrick
When conntrack is reassembling packet fragments, the same reassembly context can be shared across multiple threads handling different packets simultaneously. Once a full packet is assembled, it is added to a packet batch for processing, this is most likely the batch that added it in the first

Re: [ovs-dev] vlog: Destroy async_append first then close log_fd.

2024-05-15 Thread Simon Horman
On Wed, May 15, 2024 at 11:28:21AM +0800, hepeng via dev wrote: > From: Peng He > > async_append stores log_fd, it should be destructed before log_fd > is closed. > > Signed-off-by: Peng He Acked-by: Simon Horman ___ dev mailing list

Re: [ovs-dev] [PATCH v2] table: Fix freeing global variable.

2024-05-15 Thread Simon Horman
On Wed, May 15, 2024 at 02:14:13PM +0800, Yunjian Wang via dev wrote: > From: Pengfei Sun > > In function shash_replace_nocopy, argument to free() is the address > of a global variable (argument passed by function table_print_json__), > which is not memory allocated by malloc(). > >

Re: [ovs-dev] [PATCH v3 4/6] netdev-dpdk: Refactor TSO request code.

2024-05-15 Thread Kevin Traynor
On 13/05/2024 08:13, David Marchand wrote: > Hello Kevin, > > Thanks for reviewing. > > On Fri, May 10, 2024 at 11:50 PM Kevin Traynor wrote: >> >> On 19/04/2024 15:06, David Marchand wrote: >>> Replace check on th == NULL with an assert() because dp_packet_l4(pkt) >>> is priorly used to

Re: [ovs-dev] [PATCH v3 6/6] netdev-dpdk: Refactor tunnel checksum offloading.

2024-05-15 Thread Kevin Traynor
On 19/04/2024 15:06, David Marchand wrote: > All informations required for checksum offloading can be deduced by > already tracked dp_packet l3_ofs, l4_ofs, inner_l3_ofs and inner_l4_ofs > fields. > Remove DPDK specific l[2-4]_len from generic OVS code. > > netdev-dpdk code then fills mbuf

[ovs-dev] [PATCH v4] lib: Assert for incorrect packet.

2024-05-15 Thread Amit Prakash Shukla
Packet that are not encapsulated but metadata of the packet contains a offload flag set, will call dp_packet_inner_l4 to get TCP, UDP, SCTP header pointers. dp_packet_inner_l4 for such packets would return NULL as the inner offsets by-default are configured as UINT16_MAX. On derefrencing such

Re: [ovs-dev] [PATCH v3 5/6] netdev-dpdk: Use guest TSO segmentation size hint.

2024-05-15 Thread Kevin Traynor
On 19/04/2024 15:06, David Marchand wrote: > In a typical setup like: > guest A <-virtio-> OVS A <-vxlan-> OVS B <-virtio-> guest B > > TSO packets from guest A are segmented against the OVS A physical port > mtu adjusted by the vxlan tunnel header size, regardless of guest A > interface mtu. >

Re: [ovs-dev] [PATCH v3] lib: assert for incorrect packet.

2024-05-15 Thread 0-day Robot
Bleep bloop. Greetings Amit Prakash Shukla, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: The subject summary should start with a capital. Subject: lib: assert for

[ovs-dev] [PATCH v3] lib: assert for incorrect packet.

2024-05-15 Thread Amit Prakash Shukla
Packet that are not encapsulated but metadata of the packet contains a offload flag set, will call dp_packet_inner_l4 to get TCP, UDP, SCTP header pointers. dp_packet_inner_l4 for such packets would return NULL as the inner offsets by-default are configured as UINT16_MAX. On derefrencing such

Re: [ovs-dev] [v2] odp-execute: Fix AVX checksum calculation.

2024-05-15 Thread Eelco Chaudron
On 14 May 2024, at 15:48, Emma Finn wrote: > The AVX implementation for calcualting checksums was not > handling carry-over addition correctly in some cases. > This patch adds an additional shuffle to add 16-bit padding > to the final part of the calculation to handle such cases. > This commit

Re: [ovs-dev] [PATCH v2] table: Fix freeing global variable.

2024-05-15 Thread Eelco Chaudron
On 15 May 2024, at 8:14, Yunjian Wang via dev wrote: > From: Pengfei Sun > > In function shash_replace_nocopy, argument to free() is the address > of a global variable (argument passed by function table_print_json__), > which is not memory allocated by malloc(). > > ovsdb-client -f json

[ovs-dev] [PATCH v2] table: Fix freeing global variable.

2024-05-15 Thread Yunjian Wang via dev
From: Pengfei Sun In function shash_replace_nocopy, argument to free() is the address of a global variable (argument passed by function table_print_json__), which is not memory allocated by malloc(). ovsdb-client -f json monitor Open_vSwitch --timestamp ASan reports: