Add check_pkt_len action to the decoder list that it, itself, uses.
This makes nested check_pkt_len (i.e:a check_pkt_len inside another)
work.
Signed-off-by: Adrian Moreno
---
python/ovs/flow/odp.py | 43 ++--
python/ovs/tests/test_odp.py | 29
Test simultaneous IPFIX and local sampling including slow-path.
Signed-off-by: Adrian Moreno
---
tests/system-common-macros.at | 4 ++
tests/system-traffic.at | 105 ++
2 files changed, 109 insertions(+)
diff --git a/tests/system-common-macros.at b/tests
This simple program reads from psample and prints the packets to stdout.
Signed-off-by: Adrian Moreno
---
include/linux/automake.mk | 1 +
include/linux/psample.h | 68 +
tests/automake.mk | 3 +-
tests/test-psample.c | 282 ++
4
Add a command to dump statistics per exporter.
Signed-off-by: Adrian Moreno
---
NEWS | 2 +
ofproto/ofproto-dpif-lsample.c | 113 +
ofproto/ofproto-dpif-lsample.h | 1 +
ofproto/ofproto-dpif.c | 1 +
4 files changed, 117
Use the newly added emit_sample to implement OpenFlow sample() actions
with local sampling configuration.
Signed-off-by: Adrian Moreno
---
ofproto/ofproto-dpif-lsample.c | 17
ofproto/ofproto-dpif-lsample.h | 6 ++
ofproto/ofproto-dpif-xlate.c | 163
Add as new column in the Flow_Sample_Collector_Set table named
"local_sample_group" which enables this feature.
Signed-off-by: Adrian Moreno
---
NEWS | 4 ++
vswitchd/bridge.c | 78 +++---
vswitchd/vswitch.ovss
Add a cache entry type for local sample objects.
Store both the dpif_lsample reference and the collector_set_id so we can
quickly find the particular exporter.
Using this mechanism, account for packet and byte statistics.
Signed-off-by: Adrian Moreno
---
ofproto/ofproto-dpif-lsample.c | 18
Add a new resource in ofproto-dpif and the corresponding API in
ofproto_provider.h to represent and local sampling configuration.
Signed-off-by: Adrian Moreno
---
ofproto/automake.mk| 2 +
ofproto/ofproto-dpif-lsample.c | 185 +
ofproto/ofproto-dpif
Only kernel datapath supports this action so add a function in dpif.c
that checks for that.
Signed-off-by: Adrian Moreno
---
lib/dpif.c | 7 +++
lib/dpif.h | 1 +
ofproto/ofproto-dpif.c | 45 ++
ofproto/ofproto-dpif.h | 6
" by the kernel.
Signed-off-by: Adrian Moreno
---
include/linux/openvswitch.h | 25 +
lib/dpif-netdev.c| 1 +
lib/dpif.c | 1 +
lib/odp-execute.c| 25 -
lib/odp-util.c | 103 +++
n this series as existing sample
or userspace actions are not currently offloadable. Also some
improvements need to be implemented in tc for it to be feasible.
[1]
https://patchwork.kernel.org/project/netdevbpf/cover/20240603185647.2310748-1-amore...@redhat.com/
Adrian Moreno (9):
odp-uti
the regexp to allow more than one consecutive "+" characters.
Signed-off-by: Adrian Moreno
---
tests/checkpatch.at | 25 +
utilities/checkpatch.py | 2 +-
2 files changed, 26 insertions(+), 1 deletion(-)
diff --git a/tests/checkpatch.at b/tests/checkpatch
Current regexp used to check whitespaces around operators does not
consider that there can be more than one "*" together to express pointer
to pointer. As a result, false positive warnings are raised [1].
Fix the regexp to allow more than one consecutive "+" characters.
S
Signed-off-by: Adrian Moreno
---
net/openvswitch/actions.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c
index 33f6d93ba5e4..54fc1abcff95 100644
--- a/net/openvswitch/actions.c
+++ b/net/openvswitch
for "userspace" and
"trunc" actions.
Signed-off-by: Adrian Moreno
---
.../selftests/net/openvswitch/openvswitch.sh | 99 +++-
.../selftests/net/openvswitch/ovs-dpctl.py| 112 +-
2 files changed, 204 insertions(+), 7 deletions(-)
diff --git a/tools/t
Add sample and emit_sample action support to ovs-dpctl.py.
Refactor common attribute parsing logic into an external function.
Signed-off-by: Adrian Moreno
---
.../selftests/net/openvswitch/ovs-dpctl.py| 162 +-
1 file changed, 161 insertions(+), 1 deletion(-)
diff --git
The behavior of actions might not be the exact same if they are being
executed inside a nested sample action. Store the probability of the
parent sample action in the skb's cb area.
Use the probability in emit_sample to pass it down to psample.
Signed-off-by: Adrian Moreno
---
include/uapi
ling a decent
amount of packets, this sampling rate semantics is not very useful.
Add a new flag to the uAPI that indicates that the sampling rate is
expressed in scaled probability, this is:
- 0 is 0% probability, no packets get sampled.
- U32_MAX is 100% probability, all packets get sampled.
Signed-o
cookies that will not be offloadable.
Signed-off-by: Adrian Moreno
---
Documentation/netlink/specs/ovs_flow.yaml | 17
include/uapi/linux/openvswitch.h | 25
net/openvswitch/actions.c | 50 +++
net/openvswitch/flow_netlink.c
If nobody is listening on the multicast group, generating the sample,
which involves copying packet data, seems completely unnecessary.
Return fast in this case.
Signed-off-by: Adrian Moreno
---
net/psample/psample.c | 4
1 file changed, 4 insertions(+)
diff --git a/net/psample/psample.c
If the action has a user_cookie, pass it along to the sample so it can
be easily identified.
Signed-off-by: Adrian Moreno
---
net/sched/act_sample.c | 12
1 file changed, 12 insertions(+)
diff --git a/net/sched/act_sample.c b/net/sched/act_sample.c
index a69b53d54039..5c3f86ec964a
Add a user cookie to the sample metadata so that sample emitters can
provide more contextual information to samples.
If present, send the user cookie in a new attribute:
PSAMPLE_ATTR_USER_COOKIE.
Signed-off-by: Adrian Moreno
---
include/net/psample.h| 2 ++
include/uapi/linux/psample.h
a new OVS-only multicast group.
- Extend psample and tc with a user-defined cookie.
Adrian Moreno (9):
net: psample: add user cookie
net: sched: act_sample: add action cookie to sample
net: psample: skip packet copy if no listeners
net: psample: allow using rate as probability
net: openv
^^
File "[...]/pyroute2/netlink/__init__.py", line 1560, in encode_nlas
nla_instance.setvalue(cell[1])
File "[...]/pyroute2/netlink/__init__.py", line 1265, in setvalue
nlv.setvalue(nla_tuple[1])
~^^^
IndexError: list index out of range
In the action formatting function ("dpstr"), the iteration is made over
the nla_map, so if there are more than one attribute from the same type
we only print the first one.
Fix this by iterating over the actual attributes.
Signed-off-by: Adrian Moreno
---
.../selftests/net/openv
On 4/24/24 9:53 PM, Adrian Moreno wrote:
This is the userspace counterpart of the work being done in the kernel
[1]. Sending it as RFC to get some early feedback on the overall
solution.
** Problem description **
Currently, OVS supports several observability features, such as
per-bridge
On 5/14/24 1:27 PM, Eelco Chaudron wrote:
On 14 May 2024, at 13:05, Ilya Maximets wrote:
On 5/14/24 12:14, Adrian Moreno wrote:
On 5/14/24 11:09 AM, Ilya Maximets wrote:
On 5/14/24 09:39, Adrian Moreno wrote:
On 5/10/24 12:45 PM, Adrian Moreno wrote:
On 5/10/24 12:06 PM, Eelco
On 5/14/24 11:09 AM, Ilya Maximets wrote:
On 5/14/24 09:39, Adrian Moreno wrote:
On 5/10/24 12:45 PM, Adrian Moreno wrote:
On 5/10/24 12:06 PM, Eelco Chaudron wrote:
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
The new odp sample attributes allow userspace to specify a group_id
On 5/10/24 12:14 PM, Eelco Chaudron wrote:
On 10 May 2024, at 10:23, Adrian Moreno wrote:
On 5/10/24 9:14 AM, Eelco Chaudron wrote:
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
This is the userspace counterpart of the work being done in the kernel
[1]. Sending it as RFC to get some
On 5/10/24 12:45 PM, Adrian Moreno wrote:
On 5/10/24 12:06 PM, Eelco Chaudron wrote:
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
The new odp sample attributes allow userspace to specify a group_id and
user-defined cookie to be passed down to psample.
Add support for parsing
On 5/13/24 2:38 PM, Adrian Moreno wrote:
On 5/13/24 1:32 PM, Eelco Chaudron wrote:
On 13 May 2024, at 10:44, Adrian Moreno wrote:
On 5/10/24 12:06 PM, Eelco Chaudron wrote:
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
Offload the sample action if it contains psample information
On 5/10/24 3:06 PM, Ilya Maximets wrote:
On 5/10/24 14:01, Eelco Chaudron wrote:
On 10 May 2024, at 12:45, Adrian Moreno wrote:
On 5/10/24 12:06 PM, Eelco Chaudron wrote:
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
The new odp sample attributes allow userspace to specify a group_id
On 5/13/24 12:32 PM, Eelco Chaudron wrote:
On 10 May 2024, at 13:15, Adrian Moreno wrote:
On 5/10/24 12:06 PM, Eelco Chaudron wrote:
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
When a OFP_SAMPLE action is xlated and a dpif_psample object has been
configured (via
On 5/13/24 2:48 PM, Ilya Maximets wrote:
On 5/13/24 13:10, Adrian Moreno wrote:
On 5/13/24 12:44 PM, Eelco Chaudron wrote:
On 13 May 2024, at 9:01, Adrian Moreno wrote:
On 5/10/24 12:06 PM, Eelco Chaudron wrote:
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
This simple program
On 5/10/24 1:49 PM, Ilya Maximets wrote:
On 5/10/24 13:03, Adrian Moreno wrote:
On 5/10/24 12:06 PM, Eelco Chaudron wrote:
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
Only kernel datapath supports psample so check that the datapath is not
userspace and that it accepts the new
On 5/13/24 2:38 PM, Ilya Maximets wrote:
On 5/13/24 09:17, Eelco Chaudron wrote:
On 10 May 2024, at 15:06, Ilya Maximets wrote:
On 5/10/24 14:01, Eelco Chaudron wrote:
On 10 May 2024, at 12:45, Adrian Moreno wrote:
On 5/10/24 12:06 PM, Eelco Chaudron wrote:
On 24 Apr 2024, at 21:53
On 5/13/24 1:32 PM, Eelco Chaudron wrote:
On 13 May 2024, at 10:44, Adrian Moreno wrote:
On 5/10/24 12:06 PM, Eelco Chaudron wrote:
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
Offload the sample action if it contains psample information by creating
a tc "sample" action wit
On 5/13/24 12:44 PM, Eelco Chaudron wrote:
On 13 May 2024, at 9:01, Adrian Moreno wrote:
On 5/10/24 12:06 PM, Eelco Chaudron wrote:
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
This simple program reads from psample and prints the packets to stdout.
It's useful for quickly collecting
On 5/10/24 12:06 PM, Eelco Chaudron wrote:
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
Signed-off-by: Adrian Moreno
---
tests/system-common-macros.at| 4 +++
tests/system-offloads-traffic.at | 53
2 files changed, 57 insertions(+)
diff --git
On 5/10/24 12:06 PM, Eelco Chaudron wrote:
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
Maybe add a small description to this patch.
Signed-off-by: Adrian Moreno
---
ofproto/ofproto-dpif-psample.c | 59 ++
ofproto/ofproto-dpif-psample.h | 1
On 5/10/24 12:06 PM, Eelco Chaudron wrote:
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
Offload the sample action if it contains psample information by creating
a tc "sample" action with the user cookie inside the action's cookie.
Avoid using the "sample" acti
On 5/10/24 12:06 PM, Eelco Chaudron wrote:
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
In preparation to allowing certain actions to have a cookie that does
not represent the entire flow, rename flower->act_cookie to
flower->flow_cookie.
This patch does not introduce any beha
On 5/10/24 12:06 PM, Eelco Chaudron wrote:
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
This simple program reads from psample and prints the packets to stdout.
It's useful for quickly collecting sampled packets.
See some comments below, did not review the actual sample application
On 5/10/24 12:06 PM, Eelco Chaudron wrote:
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
Add a new resource in ofproto-dpif and the corresponding API in
ofproto_provider.h to represent and change psample configuration.
See comments below.
//Eelco
Signed-off-by: Adrian Moreno
On 5/10/24 12:06 PM, Eelco Chaudron wrote:
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
Add a psample_group field to the Flow Sample Collector Set table and use
it to configure the psample ofproto layer.
See comments below,
Eelco
Signed-off-by: Adrian Moreno
---
vswitchd/bridge.c
On 5/10/24 12:06 PM, Eelco Chaudron wrote:
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
When a OFP_SAMPLE action is xlated and a dpif_psample object has been
configured (via Flow_Sample_Collector_Set table) with the same
collector_set_id, add psample information to the odp sample action
On 5/10/24 12:06 PM, Eelco Chaudron wrote:
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
Only kernel datapath supports psample so check that the datapath is not
userspace and that it accepts the new attributes.
Signed-off-by: Adrian Moreno
---
ofproto/ofproto-dpif.c | 59
On 5/10/24 12:06 PM, Eelco Chaudron wrote:
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
The new odp sample attributes allow userspace to specify a group_id and
user-defined cookie to be passed down to psample.
Add support for parsing and formatting such action.
Signed-off-by: Adrian
On 5/10/24 9:14 AM, Eelco Chaudron wrote:
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
This is the userspace counterpart of the work being done in the kernel
[1]. Sending it as RFC to get some early feedback on the overall
solution.
** Problem description **
Currently, OVS supports
Add a man page for ovs-flowviz as well as a topic page with some more
detailed examples.
Signed-off-by: Adrian Moreno
---
Documentation/automake.mk | 4 +-
Documentation/conf.py | 2 +
Documentation/ref/index.rst | 1 +
Documentation
In order to support dark style in html outputs, allow the config file to
express the background color and set it in a top style object.
Acked-by: Eelco Chaudron
Signed-off-by: Adrian Moreno
---
python/ovs/flowviz/html_format.py | 4 +++-
python/ovs/flowviz/odp/html.py | 30
ovs-flowviz -f "output.port=3"
datapath html > /tmp/flows.html
Acked-by: Eelco Chaudron
Signed-off-by: Adrian Moreno
---
python/automake.mk | 1 +
python/ovs/flowviz/odp/cli.py | 10 ++
python/ovs/flowviz/odp/html.py | 259 +
3 fi
with both the html flows and the graph
(in svg) that enables navegation.
Examples:
$ ovs-appctl dpctl/dump-flows -m | ovs-flowviz datapath graph | dot
-Tpng -o graph.png
$ ovs-appctl dpctl/dump-flows -m | ovs-flowviz datapath graph --html >
flows.html
Acked-by: Eelco Chaudron
Signed-off-by: Adr
apath console
- Quickly detect where most packets are going using heatmap and
paginated output:
$ ovs-ofctl dump-flows br-int | ovs-flowviz openflow console -h
[1] https://rich.readthedocs.io/en/stable/introduction.html
Signed-off-by: Adrian Moreno
---
python/automake.mk| 2
ow logic
$ ovs-ofctl dump-flows br-int | ovs-flowviz openflow logic -s -h
$ export OVN_NB_DB=...
$ export OVN_SB_DB=...
$ ovs-ofctl dump-flows br-int | ovs-flowviz openflow logic -d
$ ovs-ofctl dump-flows br-int | ovs-flowviz openflow logic -d
--ovn-filter="acl.*icmp4"
Acked-by: Eelco C
low the sequence of related
actions.
- full-tree filtering: if a user specifies a filter, an entire subtree
is filtered out if none of its branches satisfy it.
Acked-by: Eelco Chaudron
Signed-off-by: Adrian Moreno
---
python/automake.mk | 1 +
python/ovs/flowviz/console.py | 21
=...
$ ovs-vsctl dump-flows br-int | ovs-flowviz openflow cookie
--ovn-filter="acl.*icmp4"
$ ovs-vsctl dump-flows br-int | ovs-flowviz openflow cookie
--ovn-detrace
Acked-by: Eelco Chaudron
Signed-off-by: Adrian Moreno
---
python/ovs/flowviz/ofp/cli.py | 57 +-
$ ovs-ofctl dump-flows br-int > flows.txt && ovs-flowviz -i flows.txt openflow
json
$ ovs-ofctl appctl dpctl/dump-flows | ovs-flowviz -f 'ct' datapath json
$ ovs-ofctl appctl dpctl/dump-flows > flows.txt && ovs-flowviz -i flows.txt -f
'drop' datapath json
Signed-off-by
It has two basic styles defined: "dark" and "light" intended for
dark and light terminals.
Examples:
$ ovs-flowviz -i /tmp/dpflows --style=dark datapath console
$ ovs-flowviz -i /tmp/ofpflows --style=light openflow console
Acked-by: Eelco Chaudron
Signed-off-by: Adrian
tml
Acked-by: Eelco Chaudron
Signed-off-by: Adrian Moreno
---
python/automake.mk | 3 +-
python/ovs/flowviz/html_format.py | 136
python/ovs/flowviz/ofp/cli.py | 10 ++
python/ovs/flowviz/ofp/html.py | 80
python/ovs/f
Signed-off-by: Adrian Moreno
---
python/automake.mk | 14 ---
python/ovs/flowviz/__init__.py | 0
python/ovs/flowviz/main.py | 40 ++
python/ovs/flowviz/odp/__init__.py | 0
python/ovs/flowviz/ofp/__init__.py | 0
python/ovs/flowviz/o
RFC -> V1:
- Addressed Eelco's comments
- Added a documentation page
- Added support for dark style HTML pages
- Patch 3. Small fix in the way a style is looked up. Use the key in
the KV instead of the metadata string. This helps with "free" values
such as "output".
Adrian M
On 5/3/24 11:43 AM, Eelco Chaudron wrote:
On 24 Apr 2024, at 15:50, Adrian Moreno wrote:
Add support for psample sampling via two new attributes to the
OVS_ACTION_ATTR_SAMPLE action.
OVS_SAMPLE_ATTR_PSAMPLE_GROUP used to pass an integer psample group_id.
OVS_SAMPLE_ATTR_PSAMPLE_COOKIE
quot;,
-"Too expensive to revalidate",
"Purged with user action",
+"Too expensive to revalidate",
"Flow state inconsistent after updates",
"Flow translation error",
]
Reviewed-by: Adrian Moreno
t| 22 ++
3 files changed, 25 insertions(+), 2 deletions(-)
Reviewed-by: Adrian Moreno
diff --git a/ofproto/ofproto-dpif-trace.c b/ofproto/ofproto-dpif-trace.c
index 87506aa78..e43d9f88c 100644
--- a/ofproto/ofproto-dpif-trace.c
+++ b/ofproto/ofproto-dpif-trace.c
@@
Signed-off-by: Adrian Moreno
---
tests/system-common-macros.at| 4 +++
tests/system-offloads-traffic.at | 53
2 files changed, 57 insertions(+)
diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at
index 2a68cd664..860d6a8c9 100644
Offload the sample action if it contains psample information by creating
a tc "sample" action with the user cookie inside the action's cookie.
Avoid using the "sample" action's cookie to store the ufid.
Signed-off-by: Adrian Moreno
---
include/linux/automake.mk|
Signed-off-by: Adrian Moreno
---
ofproto/ofproto-dpif-psample.c | 59 ++
ofproto/ofproto-dpif-psample.h | 1 +
ofproto/ofproto-dpif.c | 1 +
3 files changed, 61 insertions(+)
diff --git a/ofproto/ofproto-dpif-psample.c b/ofproto/ofproto-dpif-psample.c
This simple program reads from psample and prints the packets to stdout.
It's useful for quickly collecting sampled packets.
Signed-off-by: Adrian Moreno
---
Documentation/automake.mk | 1 +
Documentation/conf.py | 2 +
Documentation/ref/index.rst | 1
Add a cache entry type for psample objects.
Store both the dpif_psample reference and the collector_set_id so we can
quickly find the particular exporter.
Using that mechanism, account for packet and byte statistics.
Signed-off-by: Adrian Moreno
---
ofproto/ofproto-dpif-psample.c | 20
Add a new resource in ofproto-dpif and the corresponding API in
ofproto_provider.h to represent and change psample configuration.
Signed-off-by: Adrian Moreno
---
ofproto/automake.mk| 2 +
ofproto/ofproto-dpif-psample.c | 167 +
ofproto/ofproto-dpif
When a OFP_SAMPLE action is xlated and a dpif_psample object has been
configured (via Flow_Sample_Collector_Set table) with the same
collector_set_id, add psample information to the odp sample action.
Signed-off-by: Adrian Moreno
---
ofproto/ofproto-dpif-psample.c | 20 +
ofproto/ofproto
In preparation to allowing certain actions to have a cookie that does
not represent the entire flow, rename flower->act_cookie to
flower->flow_cookie.
This patch does not introduce any behavioral change, it's just a
variable renaming.
Signed-off-by: Adrian Moreno
---
lib/netdev-offloa
The new odp sample attributes allow userspace to specify a group_id and
user-defined cookie to be passed down to psample.
Add support for parsing and formatting such action.
Signed-off-by: Adrian Moreno
---
include/linux/openvswitch.h | 49 +---
lib/odp-execute.c| 3
Add a psample_group field to the Flow Sample Collector Set table and use
it to configure the psample ofproto layer.
Signed-off-by: Adrian Moreno
---
vswitchd/bridge.c | 54 ++
vswitchd/vswitch.ovsschema | 7 -
vswitchd/vswitch.xml | 32
patchwork.kernel.org/project/netdevbpf/list/?series=847473
Adrian Moreno (11):
odp-util: Add support to new psample uAPI.
ofproto_dpif: Check for psample support.
ofproto: Add ofproto-dpif-psample.
vswitchd: Add psample to schema and configure it.
ofproto_dpif_xlate: Use psample for OFP sampl
Only kernel datapath supports psample so check that the datapath is not
userspace and that it accepts the new attributes.
Signed-off-by: Adrian Moreno
---
ofproto/ofproto-dpif.c | 59 ++
ofproto/ofproto-dpif.h | 6 -
2 files changed, 64 insertions
ction (via refactoring the one
in sample).
Signed-off-by: Adrian Moreno
---
.../selftests/net/openvswitch/openvswitch.sh | 97 +-
.../selftests/net/openvswitch/ovs-dpctl.py| 167 ++
2 files changed, 231 insertions(+), 33 deletions(-)
diff --git a/tools/testing/sel
.
The presence of a group_id mandates that the action shall called the
psample module to multicast the packet with such group_id and the
user-provided cookie if present. This behavior is orthonogal to
also executing the nested actions if present.
Signed-off-by: Adrian Moreno
---
Documentation/netlink
Add sample action support to ovs-dpctl.py.
Signed-off-by: Adrian Moreno
---
.../selftests/net/openvswitch/ovs-dpctl.py| 96 ++-
1 file changed, 95 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/openvswitch/ovs-dpctl.py
b/tools/testing/selftests/net
ple arguments.
- Extend psample and tc with a user-defined cookie.
- Add a tracepoint to psample to facilitate troubleshooting.
rfc_v1 -> rfc_v2:
- Use psample instead of a new OVS-only multicast group.
- Extend psample and tc with a user-defined cookie.
Adrian Moreno (8):
net: netlink: expor
de characters.
An example of these warnings:
tools/testing/selftests/net/openvswitch/ovs-dpctl.py:505:
SyntaxWarning: invalid escape sequence '\d'
Fix all the warnings by flagging literals as raw strings.
Signed-off-by: Adrian Moreno
---
.../selftests/net/openvswitch/ovs-dpctl.
On 4/12/24 11:10, Eelco Chaudron wrote:
On 9 Apr 2024, at 9:06, Adrian Moreno wrote:
Add a man page for ovs-flowviz as well as a topic page with some more
detailed examples.
Signed-off-by: Adrian Moreno
In addition to Ilya’s comments, find 3 small comments below. The rest looks
good
On 3/26/24 03:30, Chris Mi via dev wrote:
This patch set adds offload support for sFlow.
Psample is a genetlink channel for packet sampling. TC action act_sample
uses psample to send sampled packets to userspace.
When offloading sample action to TC, userspace creates a unique ID to
map sFlow
-flowviz.8.rst not listed in
Documentation/automake.mk
"""
Fix it by making the {dir}/ part of the docre regexp optional.
Signed-off-by: Adrian Moreno
---
utilities/checkpatch.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utilities/checkpatch.py b/utilities/checkpa
On 4/9/24 09:06, Adrian Moreno wrote:
Add a man page for ovs-flowviz as well as a topic page with some more
detailed examples.
Signed-off-by: Adrian Moreno
---
Documentation/automake.mk | 4 +-
Documentation/conf.py | 2 +
Documentation/ref
Add a man page for ovs-flowviz as well as a topic page with some more
detailed examples.
Signed-off-by: Adrian Moreno
---
Documentation/automake.mk | 4 +-
Documentation/conf.py | 2 +
Documentation/ref/index.rst | 1 +
Documentation
with both the html flows and the graph
(in svg) that enables navegation.
Examples:
$ ovs-appctl dpctl/dump-flows -m | ovs-flowviz datapath graph | dot
-Tpng -o graph.png
$ ovs-appctl dpctl/dump-flows -m | ovs-flowviz datapath graph --html >
flows.html
Acked-by: Eelco Chaudron
Signed-off-by: Adr
$ ovs-ofctl dump-flows br-int > flows.txt && ovs-flowviz -i flows.txt openflow
json
$ ovs-ofctl appctl dpctl/dump-flows | ovs-flowviz -f 'ct' datapath json
$ ovs-ofctl appctl dpctl/dump-flows > flows.txt && ovs-flowviz -i flows.txt -f
'drop' datapath json
Signed-off-by
ovs-flowviz -f "output.port=3"
datapath html > /tmp/flows.html
Acked-by: Eelco Chaudron
Signed-off-by: Adrian Moreno
---
python/automake.mk | 1 +
python/ovs/flowviz/odp/cli.py | 10 ++
python/ovs/flowviz/odp/html.py | 259 +
3 fi
In order to support dark style in html outputs, allow the config file to
express the background color and set it in a top style object.
Acked-by: Eelco Chaudron
Signed-off-by: Adrian Moreno
---
python/ovs/flowviz/html_format.py | 4 +++-
python/ovs/flowviz/odp/html.py | 30
ow logic
$ ovs-ofctl dump-flows br-int | ovs-flowviz openflow logic -s -h
$ export OVN_NB_DB=...
$ export OVN_SB_DB=...
$ ovs-ofctl dump-flows br-int | ovs-flowviz openflow logic -d
$ ovs-ofctl dump-flows br-int | ovs-flowviz openflow logic -d
--ovn-filter="acl.*icmp4"
Acked-by: Eelco C
low the sequence of related
actions.
- full-tree filtering: if a user specifies a filter, an entire subtree
is filtered out if none of its branches satisfy it.
Acked-by: Eelco Chaudron
Signed-off-by: Adrian Moreno
---
python/automake.mk | 1 +
python/ovs/flowviz/console.py | 21
=...
$ ovs-vsctl dump-flows br-int | ovs-flowviz openflow cookie
--ovn-filter="acl.*icmp4"
$ ovs-vsctl dump-flows br-int | ovs-flowviz openflow cookie
--ovn-detrace
Acked-by: Eelco Chaudron
Signed-off-by: Adrian Moreno
---
python/ovs/flowviz/ofp/cli.py | 57 +-
tml
Acked-by: Eelco Chaudron
Signed-off-by: Adrian Moreno
---
python/automake.mk | 3 +-
python/ovs/flowviz/html_format.py | 136
python/ovs/flowviz/ofp/cli.py | 10 ++
python/ovs/flowviz/ofp/html.py | 80
python/ovs/f
It has two basic styles defined: "dark" and "light" intended for
dark and light terminals.
Examples:
$ ovs-flowviz -i /tmp/dpflows --style=dark datapath console
$ ovs-flowviz -i /tmp/ofpflows --style=light openflow console
Acked-by: Eelco Chaudron
Signed-off-by: Adrian
Signed-off-by: Adrian Moreno
---
python/automake.mk | 14 ---
python/ovs/flowviz/__init__.py | 0
python/ovs/flowviz/main.py | 40 ++
python/ovs/flowviz/odp/__init__.py | 0
python/ovs/flowviz/ofp/__init__.py | 0
python/ovs/flowviz/o
apath console
- Quickly detect where most packets are going using heatmap and
paginated output:
$ ovs-ofctl dump-flows br-int | ovs-flowviz openflow console -h
[1] https://rich.readthedocs.io/en/stable/introduction.html
Signed-off-by: Adrian Moreno
---
python/automake.mk| 2
dded support for dark style HTML pages
- Patch 3. Small fix in the way a style is looked up. Use the key in
the KV instead of the metadata string. This helps with "free" values
such as "output".
Adrian Moreno (12):
python: ovs: Add flowviz scheleton.
python: ovs: fl
On 3/15/24 12:29, Eelco Chaudron wrote:
On 13 Mar 2024, at 10:03, Adrian Moreno wrote:
Add a flow formatting framework and one implementation for console
printing using rich.
The flow formatting framework is a simple set of classes that can be
used to write different flow formatting
1 - 100 of 866 matches
Mail list logo
