Re: [ovs-dev] [PATCH ovn v2] northd: Fix the match not being cleared inside the loop.

2024-05-29 Thread Dumitru Ceara
s good to me, thanks! Acked-by: Dumitru Ceara ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn] northd: Fix the match not being cleared inside the loop.

2024-05-29 Thread Dumitru Ceara
On 5/29/24 09:03, Ales Musil wrote: > The match wasn't cleared which led to matches being appended together > and the ovn-controller failed to parse them. > > Fixes: 3faadc76ad71 ("northd: Fix pmtud for non routed traffic.") > Signed-off-by: Ales Musil > --- Thanks, Ales, for the fix, it looks

Re: [ovs-dev] [PATCH ovn] northd: Add bfd and bfd_consumer nodes to I-P engine.

2024-05-23 Thread Dumitru Ceara
On 5/16/24 15:08, Lorenzo Bianconi wrote: >> On Thu, May 2, 2024 at 8:22 AM Lorenzo Bianconi >> wrote: >>> >>> Introduce bfd and bfd_consumer nodes to northd I-P engine to track bfd >>> connections and northd static_route/policy_route changes. >>> >>> Reported-at:

Re: [ovs-dev] [PATCH] [Patch ovn] text respresntations for drop sampling.

2024-05-21 Thread Dumitru Ceara
quot;outport == \"none\"" >> pipeline: ingress >> priority: 50 >> table_id: 27 >> tags: {} >> hash: 0 >> >> where the action includes the flow_desc as the drop reason >> > > Than

Re: [ovs-dev] OVN technical community meeting - May 13th

2024-05-17 Thread Dumitru Ceara
On 5/14/24 12:29, Dumitru Ceara wrote: > Thanks, everyone, for attending the OVN community meeting yesterday! It > was a very interesting discussion about how to better integrate OVN and BGP! > > Here's the link to the recording: > https://youtu.be/k448ada9aFQ > &g

[ovs-dev] OVN technical community meeting - May 13th

2024-05-14 Thread Dumitru Ceara
> I went ahead and scheduled a new instance: > Date/Time: Monday, May 13th, 3PM UTC > Link: https://meet.google.com/zns-gqsd-jdn?authuser=0=122 > Agenda: > https://docs.google.com/document/d/1dG4GwcYOSs4uArPGtOoaP5tH4KCto-GH_C3tIXSnZZ8/edit?usp=meetingnotes > Thanks, everyone, for attending

Re: [ovs-dev] [PATCH ovn] Do not reply on unicast arps for targets.

2024-05-13 Thread Dumitru Ceara
On 5/4/24 11:38, Vasyl Saienko wrote: > Hello Numan > > Thanks for review and feedback. > > On Fri, May 3, 2024 at 7:14 PM Numan Siddique wrote: > >> On Mon, Apr 22, 2024 at 2:54 AM Vasyl Saienko >> wrote: >>> >>> Reply only if target ethernet address is broadcast, if >>> address is specified

Re: [ovs-dev] [PATCH ovn] tests: Fix netcat 7.94 issues.

2024-04-23 Thread Dumitru Ceara
On 4/23/24 11:12, martin.kal...@canonical.com wrote: > Hi Ales, > Sorry that these new tests are causing problems. Just out of curiosity, > do you have link to some failing test runs? I'll add few thoughts > below. > > On Tue, 2024-04-23 at 09:41 +0200, Ales Musil wrote: >> The netcat 7.94 allows

Re: [ovs-dev] [PATCH ovn] tests: Fix netcat 7.94 issues.

2024-04-23 Thread Dumitru Ceara
On 4/23/24 09:41, Ales Musil wrote: > The netcat 7.94 allows multiple connections over udp (-k/--keep-open) [0], > without this option the connection can be closed "unexpctedly". This > to keep the test backward compatible make new servers for every UDP > connection. > > The second issue is that

Re: [ovs-dev] [Patch ovn v4 1/2] actions: New action ct_commit_to_zone.

2024-04-22 Thread Dumitru Ceara
On 4/22/24 10:49, Ales Musil wrote: > On Fri, Apr 19, 2024 at 2:33 PM Martin Kalcok > wrote: > >> This change adds a new action 'ct_commit_to_zone' that enables users to >> commit >> the flow into a specific zone in the connection tracker. >> >> A new feature flag, OVN_FEATURE_CT_COMMIT_TO_ZONE,

Re: [ovs-dev] [PATCH ovn] utilities: Add missing bfd option in ovn-nbctl manpage.

2024-04-22 Thread Dumitru Ceara
On 4/5/24 12:02, Lorenzo Bianconi wrote: > Add missing bfd option to lr-route-add and lr-policy-add commands in > ovn-nbctl manpage. > > Reported-at: https://issues.redhat.com/browse/FDP-550 > Signed-off-by: Lorenzo Bianconi > --- > utilities/ovn-nbctl.c | 2 ++ > 1 file changed, 2

Re: [ovs-dev] [PATCH ovn] ovn-nbctl: Document "--portrange" in the manpage.

2024-04-22 Thread Dumitru Ceara
On 4/17/24 08:28, Ales Musil wrote: > On Mon, Apr 15, 2024 at 8:21 PM Mark Michelson wrote: > >> The --portrange option was added in commit [0]. The option appears in >> the help text for ovn-nbctl, but it is not documented in the manpage at >> all. >> >> This commit adds documentation to the

Re: [ovs-dev] [PATCH ovn] northd: Do not incrementally proccess changes for disabled LR.

2024-04-22 Thread Dumitru Ceara
On 4/19/24 16:57, Ales Musil wrote: > When the logical router is disabled it is not populated in the datapaths > and is not internally available to I-P engine in the hmap. This could > lead to a crash during I-P processing: > > To fix that make sure we process incrementally only LR that are

Re: [ovs-dev] [PATCH ovn] controller: Remove the ovn-set-local-ip option.

2024-04-22 Thread Dumitru Ceara
On 4/22/24 08:34, Han Zhou wrote: > > > On Fri, Apr 19, 2024 at 4:51 AM Dumitru Ceara <mailto:dce...@redhat.com>> wrote: >> >> On 4/19/24 13:14, Ales Musil wrote: >> > The local_ip should be present for chassis with single encap whenever >> &g

Re: [ovs-dev] [Patch ovn v4 2/2] northd: Fix direct access to SNAT network.

2024-04-22 Thread Dumitru Ceara
On 4/22/24 10:55, Ales Musil wrote: > On Mon, Apr 22, 2024 at 9:45 AM Martin Kalcok > wrote: > >> wrt the failed ovn-kubernetes tests, they seemed to have passed >> successfully in my branch [0]. Is it possible that the tests are unstable? >> >> [0]

Re: [ovs-dev] [PATCH v3 ovn] northd: Fix pmtud for non routed traffic.

2024-04-22 Thread Dumitru Ceara
On 4/22/24 22:43, Dumitru Ceara wrote: > On 4/17/24 14:41, Lorenzo Bianconi wrote: >> Similar to what is already implemented for routed e/w traffic, >> introduce pmtud support for e/w traffic between two logical switch ports >> connected to the same logical switch, but run

Re: [ovs-dev] [PATCH v3 ovn] northd: Fix pmtud for non routed traffic.

2024-04-22 Thread Dumitru Ceara
On 4/17/24 14:41, Lorenzo Bianconi wrote: > Similar to what is already implemented for routed e/w traffic, > introduce pmtud support for e/w traffic between two logical switch ports > connected to the same logical switch, but running on two different > hypervisors. > > Acked-by: Mark Michelson >

Re: [ovs-dev] [Patch ovn v4 1/2] actions: New action ct_commit_to_zone.

2024-04-22 Thread Dumitru Ceara
On 4/22/24 12:34, Martin Kalcok wrote: > Thanks for the review Ales and sorry about those unrelated changes. I just > noticed those two typos and thought I'll sneak in the fix. > > On Mon, Apr 22, 2024 at 10:49 AM Ales Musil wrote: > [...] >>> diff --git a/ovn-sb.xml b/ovn-sb.xml >>> index

Re: [ovs-dev] [PATCH ovn] controller: Remove the ovn-set-local-ip option.

2024-04-19 Thread Dumitru Ceara
On 4/19/24 13:14, Ales Musil wrote: > The local_ip should be present for chassis with single encap whenever > we configure its interface in OvS. Not having the local_ip can lead to > traffic being dropped on the other side of tunnel because the source > IP might be different, this is more likely

Re: [ovs-dev] [PATCH ovn] ovs: Bump the submodule to the tip of branch-3.3.

2024-04-19 Thread Dumitru Ceara
On 4/19/24 10:50, Ales Musil wrote: > There are some improvements that are needed for further work on OVN > side. Most notably the commits mentioned below: > > a0df9c85def0 ("netdev-dummy: Add local route entries for IP addresses.") > c67de08f1d82 ("dpif-netdev: Increase MAX_RECIRC_DEPTH to 8.")

Re: [ovs-dev] [PATCH ovn v3] northd: Add support for disabling vxlan mode.

2024-04-19 Thread Dumitru Ceara
On 4/4/24 20:41, Vladislav Odintsov wrote: > Commit [1] introduced a "vxlan mode" concept. It brought a limitation > for available tunnel IDs because of lack of space in VXLAN VNI. > In vxlan mode OVN is limited by 4095 datapaths (LRs or non-transit LSs) > and 2047 logical switch ports per

Re: [ovs-dev] [PATCH ovn] northd: Add support for disabling vxlan mode.

2024-04-19 Thread Dumitru Ceara
On 4/4/24 21:23, Ihar Hrachyshka wrote: > On Thu, Apr 4, 2024 at 6:06 AM Dumitru Ceara wrote: > >> On 4/3/24 22:05, Vladislav Odintsov wrote: >>> re-sending email because ovs list rejected previous its content for some >> reason: >>> >>> Hi Ihar

Re: [ovs-dev] [PATCH ovn] controller: Fix an issue wrt cleanup of stale patch port.

2024-04-19 Thread Dumitru Ceara
On 3/28/24 13:28, Priyankar Jain wrote: > Issue: > Upon updating the network_name option of localnet port from one physical > bridge to another, ovn-controller fails to cleanup the peer localnet > patch port from the old bridge and ends up creating a duplicate peer > localnet patch port which

Re: [ovs-dev] [PATCH ovn] northd: Support routing over other address families.

2024-04-19 Thread Dumitru Ceara
On 3/27/24 09:43, Felix Huettner via dev wrote: > In most cases IPv4 packets are routed only over other IPv4 networks and > IPv6 packets are routed only over IPv6 networks. However there is no > interent reason for this limitation. Routing IPv4 packets over IPv6 > networks just requires the router

Re: [ovs-dev] [PATCH ovn] Fix typo in README.

2024-04-18 Thread Dumitru Ceara
On 4/18/24 14:10, Dumitru Ceara wrote: > From: Kacper Kamiński > > Submitted-at: https://github.com/ovn-org/ovn/pull/138 > Signed-off-by: Kacper Kamiński > Signed-off-by: Dumitru Ceara > --- Applied to main. I also added Kacper to the AUTHORS list. Bes

[ovs-dev] [PATCH ovn] Fix typo in README.

2024-04-18 Thread Dumitru Ceara
From: Kacper Kamiński Submitted-at: https://github.com/ovn-org/ovn/pull/138 Signed-off-by: Kacper Kamiński Signed-off-by: Dumitru Ceara --- README.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.rst b/README.rst index 4b9ea1df91..014d208c07 100644

Re: [ovs-dev] [PATCH ovn] tests: Ignore log setting extended ack support failed.

2024-04-18 Thread Dumitru Ceara
On 4/18/24 13:29, Xie Liu wrote: > > @Dumitru > Thanks for your review! > Yeah, I'm OK! > Awesome, I fixed up the git author and pushed this to main. Best regards, Dumitru > At 2024-04-18 19:22:01, "Dumitru Ceara" wrote: >> On 4/16/24 04:57, liuxie.

Re: [ovs-dev] [PATCH ovn] tests: Ignore log setting extended ack support failed.

2024-04-18 Thread Dumitru Ceara
On 4/16/24 04:57, liuxie...@163.com wrote: > From: shylou > > The test error log 'setting extended ack support failed' in the test > results may cause test failures. However, according to the OVS commit[1], > this is not a critical issue, so we can safely ignore this log. > >

Re: [ovs-dev] [Patch ovn v3 2/2] northd: Fix direct access to SNAT network.

2024-04-17 Thread Dumitru Ceara
On 4/17/24 09:08, Ales Musil wrote: > On Mon, Apr 15, 2024 at 2:15 PM Martin Kalcok > wrote: > >> This change fixes bug that breaks ability of machines from external >> networks, to communicate with machines in SNATed networks (specifically >> when using a Distributed router). >> >> Currently

Re: [ovs-dev] [Patch ovn v3 1/2] actions: New action ct_commit_to_zone.

2024-04-17 Thread Dumitru Ceara
On 4/17/24 09:04, Ales Musil wrote: > On Mon, Apr 15, 2024 at 2:15 PM Martin Kalcok > wrote: > >> This change adds a new action 'ct_commit_to_zone' that enables users to >> commit >> the flow into a specific zone in the connection tracker. >> >> A new feature flag, OVN_FEATURE_CT_COMMIT_TO_ZONE,

Re: [ovs-dev] [PATCH ovn v2 1/3] northd: Introduce ECMP_Nexthop table in SB db.

2024-04-12 Thread Dumitru Ceara
On 3/12/24 16:59, Lorenzo Bianconi wrote: > Introduce ECMP_Nexthop table in the SB db in order to track active > ecmp-symmetric-reply connections and flush stale ones. > > Signed-off-by: Lorenzo Bianconi > --- Hi Lorenzo, > northd/en-northd.c | 4 +++ > northd/inc-proc-northd.c | 8

Re: [ovs-dev] [PATCH ovn] controller: Track individual address set constants.

2024-04-12 Thread Dumitru Ceara
On 3/27/24 08:45, Ales Musil wrote: > On Wed, Mar 27, 2024 at 7:14 AM Han Zhou wrote: > >> >> >> On Tue, Mar 19, 2024 at 9:45 AM Ales Musil wrote: >>> >>> >>> >>> On Tue, Mar 19, 2024 at 5:43 PM Ales Musil wrote: Instead of tracking address set per struct expr_constant_set track it

Re: [ovs-dev] [PATCH ovn] ovn-trace: Make sure we don't exit when the port is not specified.

2024-04-12 Thread Dumitru Ceara
On 4/9/24 14:36, Ales Musil wrote: > It might happen that the microflow doesn't have port specified or > the port is part of different datapath. In that case ovn-trace would > print warning and move to later crash on assert. Exit early instead > of crashing on assert. > > Signed-off-by: Ales

Re: [ovs-dev] [PATCH ovn] treewide: Remove remaining XenServer references.

2024-04-12 Thread Dumitru Ceara
On 4/11/24 10:30, Ales Musil wrote: > On Mon, Apr 8, 2024 at 1:06 PM Ilya Maximets wrote: > >> Remaining bits from the OVS/OVN split. >> >> Fixes: 1af37d11be73 ("Remove XenServer Code") >> Signed-off-by: Ilya Maximets >> --- >> Documentation/tutorials/index.rst | 6 -- >> README.rst

Re: [ovs-dev] [PATCH ovn] northd: Fix BFD for policy routing.

2024-04-12 Thread Dumitru Ceara
On 4/9/24 20:42, Mark Michelson wrote: > Hi Lorenzo, > > This looks good to me. Thanks for fixing this! > > Acked-by: Mark Michelson > Thanks, Lorenzo and Mark! Applied to main and backported to 24.03. Regards, Dumitru ___ dev mailing list

Re: [ovs-dev] [PATCH ovn] Start mcast id allocations from OVN_MIN_IP_MULTICAST.

2024-04-12 Thread Dumitru Ceara
On 4/11/24 10:32, Ales Musil wrote: > On Thu, Apr 4, 2024 at 11:44 PM Ihar Hrachyshka wrote: > >> Strictly speaking, this is not *essential* to start from MIN and not >> MIN+1 (once the hint reaches max, it will wrap back to MIN anyway), but >> this is inconsistent with how we handle datapath

Re: [ovs-dev] [PATCH ovn] actions: Remove ct_commit_v1.

2024-04-12 Thread Dumitru Ceara
On 4/9/24 14:38, Martin Kalcok wrote: > LGTM, thanks for helping with this clean-up. > > On Wed, Apr 3, 2024 at 7:43 AM Ales Musil wrote: > >> >> >> On Tue, Apr 2, 2024 at 5:31 PM Dumitru Ceara wrote: >> >>> It's not used by any logical flow s

Re: [ovs-dev] [PATCH ovn] tests: Add macro for checking flows after recompute.

2024-04-12 Thread Dumitru Ceara
On 4/5/24 11:55, Xavier Simonart wrote: > Hi Mark > > Thanks for the review. > > On Thu, Apr 4, 2024 at 10:25 PM Mark Michelson wrote: > >> Hi Xavier, the patch looks good, but I have one question down below. >> >> On 3/26/24 07:56, Xavier Simonart wrote: >>> The macro

Re: [ovs-dev] [PATCH v2 ovn] northd: Fix pmtud for non routed traffic.

2024-04-12 Thread Dumitru Ceara
On 4/3/24 12:29, Lorenzo Bianconi wrote: > Similar to what is already implemented for routed e/w traffic, > introduce pmtud support for e/w traffic between two logical switch ports > connected to the same logical switch, but running on two different > hypervisors. > > Acked-by: Mark Michelson >

Re: [ovs-dev] [PATCH ovn] Add dh-python to debian/control.

2024-04-12 Thread Dumitru Ceara
On 4/11/24 17:28, Igor Zhukov wrote: > I tried to build OVN in a fresh Ubuntu 24.04 Docker container. > > I only installed the Build-Depends. > > I ran: > > $ dpkg-buildpackage -us -uc -ui -b > > And I received the following output: > > dpkg-buildpackage: info: source package ovn >

Re: [ovs-dev] [RFC ovn] controller: Always populate prefix-length for IPv6 PD.

2024-04-12 Thread Dumitru Ceara
On 3/19/24 10:14, Frode Nordahl wrote: > On Mon, Mar 18, 2024 at 10:12 PM Frode Nordahl wrote: >> Hi Frode, Sorry for taking so long to reply. >> The prefix we obtain is used to fill the ``ipv6_ra_prefixes`` >> option for configuration of instances through SLAAC. >> >> As discussed in RFC 7421

Re: [ovs-dev] [PATCH] rhel/systemd: Set ovsdb-server timeout to 5 minutes

2024-04-12 Thread Dumitru Ceara
On 4/11/24 19:10, Chris Riches wrote: > On 11/04/2024 17:10, Dumitru Ceara wrote: >> On 4/11/24 15:43, Chris Riches wrote: >>> On 11/04/2024 14:24, Ilya Maximets wrote: >>>> On 4/11/24 10:59, Chris Riches wrote: >> Hi Chris, Ilya, >> >>>>

Re: [ovs-dev] [PATCH] rhel/systemd: Set ovsdb-server timeout to 5 minutes

2024-04-11 Thread Dumitru Ceara
On 4/11/24 15:43, Chris Riches wrote: > On 11/04/2024 14:24, Ilya Maximets wrote: >> On 4/11/24 10:59, Chris Riches wrote: Hi Chris, Ilya, >>>  From what we know so far, the DB was full of stale connection-tracking >>> information such as the following: >>> >>> [...] >>> >>> Once the host was

Re: [ovs-dev] [PATCH ovn v2] treewide: Rename references from OvS master to main.

2024-04-10 Thread Dumitru Ceara
On 4/10/24 17:24, Simon Horman wrote: > On Wed, Apr 10, 2024 at 03:45:53PM +0200, Ales Musil wrote: >> There was recent switch in OvS from master to main branch. >> Use main in all the references across OVN code base. >> >> Signed-off-by: Ales Musil >> --- >> v2: Add the missing two references. >

[ovs-dev] [PATCH] python: Remove hacking dependency and use recent flake8.

2024-04-10 Thread Dumitru Ceara
The previously enabled 'hacking' checks were only applicable to Python 2 code. OVS doesn't support Python 2 for a while now so it's fine to remove the dependency on hacking. A similar change landed in OVN a while ago: https://github.com/ovn-org/ovn/commit/271186fa7d76 Signed-off-by: Dumitru

Re: [ovs-dev] [PATCH ovn] ci: Rename OvS master branch to main.

2024-04-10 Thread Dumitru Ceara
Hi Ales, Simon, On 4/10/24 15:39, Simon Horman wrote: > On Wed, Apr 10, 2024 at 03:26:25PM +0200, Ales Musil wrote: >> There was recent switch in OvS from master to main branch. >> Use main instead in ovn-fake-mutlinode tests. Nit: typo :) >> >> Signed-off-by: Ales Musil > > Acked-by: Simon

Re: [ovs-dev] [PATCH ovn v2] northd, controller: Use paused controller action for packet buffering.

2024-04-09 Thread Dumitru Ceara
On 4/8/24 09:19, Ales Musil wrote: > On Fri, Apr 5, 2024 at 10:35 PM Numan Siddique wrote: > >> >> >> On Tue, Apr 2, 2024 at 2:28 AM Ales Musil wrote: >> >>> The current packet injection loses ct_state in the process. When >>> the ct_state is lost we might commit to DNAT zone and perform >>>

Re: [ovs-dev] [PATCH ovn] northd: fix infinite loop in ovn_allocate_tnlid()

2024-04-04 Thread Dumitru Ceara
hat big of a deal to me. > This is all probably relevant to the question of whether any backports > should happen for this patch. > > Ihar > Regards, Dumitru > > On Thu, Apr 4, 2024 at 12:46 PM Dumitru Ceara wrote: > >> On 4/4/24 17:52, Vladislav Odintsov wrote

Re: [ovs-dev] [PATCH ovn v2] northd: Add support for disabling vxlan mode.

2024-04-04 Thread Dumitru Ceara
On 4/4/24 18:06, Vladislav Odintsov wrote: > Commit [1] introduced a "vxlan mode" concept. It brought a limitation > for available tunnel IDs because of lack of space in VXLAN VNI. > In vxlan mode OVN is limited by 4095 datapaths (LRs or non-transit LSs) > and 2047 logical switch ports per

Re: [ovs-dev] [PATCH ovn] northd: fix infinite loop in ovn_allocate_tnlid()

2024-04-04 Thread Dumitru Ceara
ackport patches to 22.03 unless they fix critical issues. I'm not completely convinced that this is such a critical issue though. You need 4K logical datapaths with vxlan enabled before this gets hit. In any case, Mark, what do you think? Regards, Dumitru >> On 4 Apr 2024, at 18:26, Dumitru Cea

Re: [ovs-dev] [PATCH ovn] northd: Add support for disabling vxlan mode.

2024-04-04 Thread Dumitru Ceara
on on this! >> >>> On 4 Apr 2024, at 13:06, Dumitru Ceara wrote: >>> >>> On 4/3/24 22:05, Vladislav Odintsov wrote: >>>> re-sending email because ovs list rejected previous its content for some >>>> reason: >>>> >>>&g

Re: [ovs-dev] [PATCH ovn] northd: fix infinite loop in ovn_allocate_tnlid()

2024-04-04 Thread Dumitru Ceara
On 4/1/24 16:27, Mark Michelson wrote: > Thanks Vladislav, > > Acked-by: Mark Michelson > Thanks, Vladislav and Mark! Applied to main and backported down to 23.06 with a minor test change, please see below. > On 4/1/24 08:15, Vladislav Odintsov wrote: >> In case if all tunnel ids are

Re: [ovs-dev] [PATCH ovn] northd: Add support for disabling vxlan mode.

2024-04-04 Thread Dumitru Ceara
On 4/3/24 22:05, Vladislav Odintsov wrote: > re-sending email because ovs list rejected previous its content for some > reason: > > Hi Ihar, > Hi Vladislav, Ihar, > thanks for your quick reaction! > I didn’t see mentioned thread, but I think that it is not safe enough to have > automatic

Re: [ovs-dev] [PATCH ovn] controller: Allow br-int connection via other methods.

2024-04-03 Thread Dumitru Ceara
On 4/2/24 16:32, Ales Musil wrote: > On Tue, Apr 2, 2024 at 4:25 PM Ilya Maximets wrote: > >> On 4/2/24 16:17, Ales Musil wrote: >>> >>> >>> On Tue, Apr 2, 2024 at 4:03 PM Ilya Maximets > > wrote: >>> >>> On 4/2/24 15:36, Ales Musil wrote: >>> > >>> > >>>

Re: [ovs-dev] [Patch ovn v2 1/2] actions: Enable specifying zone for ct_commit.

2024-04-02 Thread Dumitru Ceara
On 3/20/24 12:20, Ales Musil wrote: > On Tue, Mar 12, 2024 at 9:18 PM Martin Kalcok > wrote: > > Hi Martin, > Hi Ales, Martin, Numan, > sorry for the late reply. > Sorry for jumping in late in the discussion. > Following up on the comments from v1. >> >> @amusil You were right that the

Re: [ovs-dev] [Patch ovn v2 1/2] actions: Enable specifying zone for ct_commit.

2024-04-02 Thread Dumitru Ceara
On 3/13/24 10:27, Martin Kalcok wrote: > On Tue, Mar 12, 2024 at 9:17 PM Martin Kalcok > wrote: > >> Following up on the comments from v1. >> >> @amusil You were right that the struct in actions.h was not necessary >> then. However I also noticed that I forgot to modify `format_CT_COMMIT_V1` >>

[ovs-dev] [PATCH ovn] actions: Remove ct_commit_v1.

2024-04-02 Thread Dumitru Ceara
be removed. Update the tests to reflect the fact that the action is not supported anymore. Signed-off-by: Dumitru Ceara --- include/ovn/actions.h | 9 +-- lib/actions.c | 141 -- tests/ovn.at | 41 utilities/ovn-trace.c | 1

Re: [ovs-dev] [PATCH ovn] northd: Fix population of ipv6_ra_prefixes from IPv6 PD.

2024-03-28 Thread Dumitru Ceara
On 3/28/24 15:19, Frode Nordahl wrote: > On Thu, Mar 28, 2024 at 3:03 PM Dumitru Ceara wrote: >> >> On 3/18/24 22:21, Mark Michelson wrote: >>> Thanks Frode, looks good to me. >>> >>> Acked-by: Mark Michelson >>> >>> On 3/18/24 07:43,

Re: [ovs-dev] [PATCH ovn] ovn-ic: Avoid igmp/mld traffic flooding.

2024-03-28 Thread Dumitru Ceara
On 3/15/24 16:23, Lorenzo Bianconi wrote: > Avoid recirculating IGMP/MLD packets more than one time from stage > ls_out_pre_lb in the egress pipeline to ovn table 37 in order to avoid > packet looping for ovn-ic deployment. > > Acked-by: Mohammad Heib > Signed-off-by: Lorenzo Bianconi > --- >

Re: [ovs-dev] [PATCH ovn] northd: Fix population of ipv6_ra_prefixes from IPv6 PD.

2024-03-28 Thread Dumitru Ceara
On 3/18/24 22:21, Mark Michelson wrote: > Thanks Frode, looks good to me. > > Acked-by: Mark Michelson > > On 3/18/24 07:43, Frode Nordahl wrote: >> The current code puts the contents of the ``ipb6_ra_pd_list`` >> option verbatim into the ``ipv6_ra_prefixes`` option. >> >> This does not work,

Re: [ovs-dev] [PATCH ovn v3 0/8] Various treewide fixes.

2024-03-28 Thread Dumitru Ceara
On 3/22/24 19:33, Mark Michelson wrote: > I had a look through all the patches. For the entire series: > > Acked-by: Mark Michelson > Thanks, applied to main. Regards, Dumitru ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH ovn] controller: Use multicast for IPv6 Prefix Delegation.

2024-03-28 Thread Dumitru Ceara
On 3/18/24 22:08, Mark Michelson wrote: > Thanks Frode, looks good to me. > > Acked-by: Mark Michelson > > On 3/18/24 07:42, Frode Nordahl wrote: >> The OVN Controller currently uses unicast messages when >> communicating with the DHCPv6 server. >> >> This is at odds with RFC 3315 paragraph 1

Re: [ovs-dev] [PATCH ovn] ovn-ic: Avoid igmp/mld traffic flooding.

2024-03-28 Thread Dumitru Ceara
On 3/15/24 16:23, Lorenzo Bianconi wrote: > Avoid recirculating IGMP/MLD packets more than one time from stage > ls_out_pre_lb in the egress pipeline to ovn table 37 in order to avoid > packet looping for ovn-ic deployment. > > Acked-by: Mohammad Heib > Signed-off-by: Lorenzo Bianconi > ---

Re: [ovs-dev] [PATCH ovn v2 2/2] tests: Use sync command in ovn-ic tests.

2024-03-28 Thread Dumitru Ceara
On 3/12/24 11:56, Mohammad Heib wrote: > Use the sync commands in the ovn-ic unit tests > and remove lines that wait for IC-SB to sync with IC-NB. > > Signed-off-by: Mohammad Heib > --- Thanks, Mohammad! Applied to main and 24.03. Regards, Dumitru

Re: [ovs-dev] [PATCH ovn v2 1/2] tests: Move ovn interconnection tests to ovn-ic.at.

2024-03-28 Thread Dumitru Ceara
On 3/12/24 11:56, Mohammad Heib wrote: > Move ovn-ic tests that exist in ovn.at to ovn-ic.at. > > Signed-off-by: Mohammad Heib > --- Thanks, Mohammad! Applied to main and 24.03. Regards, Dumitru ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH ovn 2/2] IC: Tansit switch don't flood mcast traffic to router ports if matches igmp group.

2024-03-28 Thread Dumitru Ceara
On 3/15/24 11:56, Mohammad Heib wrote: > Crrently ovn transit switch forward mcast traffic that match an igmp > group to all ports participating in this group and to all router ports > that are connected to this TS switch and have mcast_flood enabled. > > The above behavior can lead to packet

Re: [ovs-dev] [PATCH ovn 1/2] northd: Don't skip transit switch LSP when creating mcast groups.

2024-03-28 Thread Dumitru Ceara
On 3/15/24 11:56, Mohammad Heib wrote: > Currently when we enable IGMP on OVN-IC cluster with two or more AZs > and one vm from AZ1 send IGMP report, northd will create the following > multicast_group on each AZ: > > AZ1: > 1. multicast_group that forward the mcast traffic from LS1 to the VM. >

Re: [ovs-dev] [PATCH ovn] northd: Fix NAT configuration with --add-route option for gw-router.

2024-03-28 Thread Dumitru Ceara
On 3/15/24 20:45, Mark Michelson wrote: > Thanks for this Lorenzo, looks good to me. > > Acked-by: Mark Michelson > Thanks, Lorenzo and Mark! Applied to main and 24.03. If we need it backported to older branches please post an explicit patch. There were some conflicts when cherry picking to

Re: [ovs-dev] [PATCH ovn] northd: Fix pmtud for non routed traffic.

2024-03-28 Thread Dumitru Ceara
On 3/15/24 20:34, Mark Michelson wrote: > Hi Lorenzo, > > Thanks for the fix. > > Acked-by: Mark Michelson > Hi Lorenzo, Mark, I'm afraid there's a bug in this patch, please see below. > When this is merged, the following should also be folded in: > > --- > diff --git

Re: [ovs-dev] OVN technical community meeting - March 19th

2024-03-28 Thread Dumitru Ceara
On 3/20/24 16:39, Dumitru Ceara wrote: > On 3/19/24 10:44, Dumitru Ceara wrote: >> Hi all, >> >> The next OVN technical community meeting is scheduled to happen today, >> at 4PM UTC. >> >> Feel free to add topics you might want to discuss today to the age

Re: [ovs-dev] [PATCH ovn v3 6/8] utilities/docker: Fix up container build.

2024-03-28 Thread Dumitru Ceara
On 3/27/24 07:40, Ales Musil wrote: > On Tue, Mar 26, 2024 at 7:09 PM Mark Michelson wrote: > >> On 3/25/24 05:09, Ales Musil wrote: >>> >>> >>> On Mon, Mar 25, 2024 at 9:47 AM Dumitru Ceara >> <mailto:dce...@redhat.com>> wrote: >>>

Re: [ovs-dev] [PATCH ovn v3 6/8] utilities/docker: Fix up container build.

2024-03-25 Thread Dumitru Ceara
On 3/22/24 19:34, Mark Michelson wrote: > On 3/21/24 19:15, Dumitru Ceara wrote: >> Most of the steps were inaccurate.  Instead, use latest Ubuntu, use >> OVS from the submodule inside the OVN repo. >> >> Signed-off-by: Dumitru Ceara >> --- >>  

Re: [ovs-dev] [PATCH ovn v3 8/8] Update post OVS-OVN split TODO list.

2024-03-22 Thread Dumitru Ceara
On 3/22/24 00:15, Dumitru Ceara wrote: > As Ilya commented in the review of the V1 of this series [0] the > statement that "all the TODO items listed in it have been addressed" > is indeed "a bold statement". However quite a few don't seem > ap

Re: [ovs-dev] [PATCH ovn v3 8/8] Update post OVS-OVN split TODO list.

2024-03-22 Thread Dumitru Ceara
On 3/22/24 00:15, Dumitru Ceara wrote: > As Ilya commented in the review of the V1 of this series [0] the > statement that "all the TODO items listed in it have been addressed" > is indeed "a bold statement". However quite a few don't seem > ap

Re: [ovs-dev] [PATCH ovn v3 3/8] rhel: Update docs.

2024-03-22 Thread Dumitru Ceara
On 3/22/24 00:15, Dumitru Ceara wrote: > Remove openvswitch related left overs. > Remove documentation about installation on older RHEL versions. RHEL 6.x > will reach the end of its ELS, Extended Life Cycle Support on July 1st: > > https://access.redhat.com/articles/4665701#1-c

[ovs-dev] [PATCH ovn v3 6/8] utilities/docker: Fix up container build.

2024-03-21 Thread Dumitru Ceara
Most of the steps were inaccurate. Instead, use latest Ubuntu, use OVS from the submodule inside the OVN repo. Signed-off-by: Dumitru Ceara --- utilities/docker/Makefile | 4 ++-- utilities/docker/debian/Dockerfile | 2 +- utilities/docker/debian/build.sh | 2 ++ utilities/docker

[ovs-dev] [PATCH ovn v3 8/8] Update post OVS-OVN split TODO list.

2024-03-21 Thread Dumitru Ceara
/412704.html Signed-off-by: Dumitru Ceara --- TODO_SPLIT.rst | 73 -- 1 file changed, 73 deletions(-) diff --git a/TODO_SPLIT.rst b/TODO_SPLIT.rst index 9c65f77d87..cdc2d25ba7 100644 --- a/TODO_SPLIT.rst +++ b/TODO_SPLIT.rst @@ -25,9 +25,6 @@ OVN/

[ovs-dev] [PATCH ovn v3 4/8] treewide: Remove some of the post OVS-OVN split leftovers.

2024-03-21 Thread Dumitru Ceara
A few still remain and need to be addressed in the future. Signed-off-by: Dumitru Ceara --- Documentation/automake.mk | 1 - Documentation/index.rst | 4 +- .../internals/contributing/coding-style.rst | 6 - .../internals/contributing/index.rst

[ovs-dev] [PATCH ovn v3 7/8] tests: Add multinode-testsuite to .gitinore.

2024-03-21 Thread Dumitru Ceara
Signed-off-by: Dumitru Ceara --- tests/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/.gitignore b/tests/.gitignore index 65cb1c6e4f..6971b426e9 100644 --- a/tests/.gitignore +++ b/tests/.gitignore @@ -6,6 +6,7 @@ /idltest.c /idltest.h /idltest.ovsidl +/multinode

[ovs-dev] [PATCH ovn v3 3/8] rhel: Update docs.

2024-03-21 Thread Dumitru Ceara
Signed-off-by: Dumitru Ceara --- Documentation/automake.mk | 1 - Documentation/howto/docker.rst | 2 +- Documentation/index.rst| 1 - Documentation/intro/install/fedora.rst | 7 +- Documentation/intro/install/index.rst | 1 - Documentation/intro/install

[ovs-dev] [PATCH ovn v3 5/8] Documentation: Remove references to TravisCI.

2024-03-21 Thread Dumitru Ceara
OVN doesn't use TravisCI for a while. Instead GitHub Actions are preferred. Signed-off-by: Dumitru Ceara --- .../contributing/submitting-patches.rst | 8 ++-- Documentation/topics/testing.rst | 40 --- 2 files changed, 3 insertions(+), 45 deletions(-) diff

[ovs-dev] [PATCH ovn v3 0/8] Various treewide fixes.

2024-03-21 Thread Dumitru Ceara
Some of these have been missed when: - splitting from OVS - moving to using OVS as a submodule - changing the default branch name to "main" Changes in v3: - properly formatted series Changes in v2: - added more fixes - was less bold :) Dumitru Ceara (8): Documentation: Fix

[ovs-dev] [PATCH ovn v3 2/8] ovn-sandbox: Rename script from ovs-sandbox to ovn-sandbox.

2024-03-21 Thread Dumitru Ceara
submodule and build on top. Remove the post-split TODO item that suggested we do the latter. Signed-off-by: Dumitru Ceara --- Documentation/tutorials/ovn-sandbox.rst | 19 ++- NEWS| 1 + TODO_SPLIT.rst | 8

[ovs-dev] [PATCH ovn v3 1/8] Documentation: Fix reference to the default branch.

2024-03-21 Thread Dumitru Ceara
Signed-off-by: Dumitru Ceara --- Documentation/intro/install/general.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/intro/install/general.rst b/Documentation/intro/install/general.rst index ab62094828..e8c312b5cb 100644 --- a/Documentation/intro/install

Re: [ovs-dev] [PATCH ovn v2 0/8] Various treewide fixes.

2024-03-21 Thread Dumitru Ceara
On 3/22/24 00:03, Dumitru Ceara wrote: > Some of these have been missed when: > - splitting from OVS > - moving to using OVS as a submodule > - changing the default branch name to "main" > > Changes in v2: > - added more fixes > - was less bold :) > O

[ovs-dev] [PATCH ovn v2 7/8] tests: Add multinode-testsuite to .gitinore.

2024-03-21 Thread Dumitru Ceara
Signed-off-by: Dumitru Ceara --- tests/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/.gitignore b/tests/.gitignore index 65cb1c6e4f..6971b426e9 100644 --- a/tests/.gitignore +++ b/tests/.gitignore @@ -6,6 +6,7 @@ /idltest.c /idltest.h /idltest.ovsidl +/multinode

[ovs-dev] [PATCH ovn v2 7/8] utilities/docker: Fix up container build.

2024-03-21 Thread Dumitru Ceara
Most of the steps were inaccurate. Instead, use latest Ubuntu, use OVS from the submodule inside the OVN repo. Signed-off-by: Dumitru Ceara --- utilities/docker/Makefile | 4 ++-- utilities/docker/debian/Dockerfile | 2 +- utilities/docker/debian/build.sh | 2 ++ utilities/docker

[ovs-dev] [PATCH ovn v2 6/8] utilities/docker: Fix up container build.

2024-03-21 Thread Dumitru Ceara
Most of the steps were inaccurate. Instead, use latest Ubuntu, use OVS from the submodule inside the OVN repo. Signed-off-by: Dumitru Ceara --- utilities/docker/Makefile | 4 ++-- utilities/docker/debian/Dockerfile | 2 +- utilities/docker/debian/build.sh | 2 ++ utilities/docker

[ovs-dev] [PATCH ovn v2 5/8] Documentation: Remove references to TravisCI.

2024-03-21 Thread Dumitru Ceara
OVN doesn't use TravisCI for a while. Instead GitHub Actions are preferred. Signed-off-by: Dumitru Ceara --- .../contributing/submitting-patches.rst | 8 ++-- Documentation/topics/testing.rst | 40 --- 2 files changed, 3 insertions(+), 45 deletions(-) diff

[ovs-dev] [PATCH ovn v2 6/8] Update post OVS-OVN split TODO list.

2024-03-21 Thread Dumitru Ceara
As Ilya commented in the review of the V1 of this series the statement that "all the TODO items listed in it have been addressed" is indeed "a bold statement". However quite a few don't seem applicable anymore. Signed-off-by: Dumitru Ceara ---

[ovs-dev] [PATCH ovn v2 4/8] treewide: Remove some of the post OVS-OVN split leftovers.

2024-03-21 Thread Dumitru Ceara
A few still remain and need to be addressed in the future. Signed-off-by: Dumitru Ceara --- Documentation/automake.mk | 1 - Documentation/index.rst | 4 +- .../internals/contributing/coding-style.rst | 6 - .../internals/contributing/index.rst

[ovs-dev] [PATCH ovn v2 3/8] rhel: Update docs.

2024-03-21 Thread Dumitru Ceara
Signed-off-by: Dumitru Ceara --- Documentation/automake.mk | 1 - Documentation/howto/docker.rst | 2 +- Documentation/index.rst| 1 - Documentation/intro/install/fedora.rst | 7 +- Documentation/intro/install/index.rst | 1 - Documentation/intro/install

[ovs-dev] [PATCH ovn v2 1/8] Documentation: Fix reference to the default branch.

2024-03-21 Thread Dumitru Ceara
Signed-off-by: Dumitru Ceara --- Documentation/intro/install/general.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/intro/install/general.rst b/Documentation/intro/install/general.rst index ab62094828..e8c312b5cb 100644 --- a/Documentation/intro/install

[ovs-dev] [PATCH ovn v2 0/8] Various treewide fixes.

2024-03-21 Thread Dumitru Ceara
Some of these have been missed when: - splitting from OVS - moving to using OVS as a submodule - changing the default branch name to "main" Changes in v2: - added more fixes - was less bold :) Dumitru Ceara (8): Documentation: Fix reference to the default branch. ovn-sandbox: Ren

[ovs-dev] [PATCH ovn v2 2/8] ovn-sandbox: Rename script from ovs-sandbox to ovn-sandbox.

2024-03-21 Thread Dumitru Ceara
submodule and build on top. Remove the post-split TODO item that suggested we do the latter. Signed-off-by: Dumitru Ceara --- Documentation/tutorials/ovn-sandbox.rst | 19 ++- NEWS| 1 + TODO_SPLIT.rst | 8

[ovs-dev] [PATCH ovn v2 0/8] Various treewide fixes.

2024-03-21 Thread Dumitru Ceara
Some of these have been missed when: - splitting from OVS - moving to using OVS as a submodule - changing the default branch name to "main" Changes in v2: - added more fixes - was less bold :) Dumitru Ceara (8): Documentation: Fix reference to the default branch. ovn-sandbox: Ren

Re: [ovs-dev] [PATCH ovn 3/5] Documentation: Use links to OVN documentation when applicable.

2024-03-21 Thread Dumitru Ceara
On 3/21/24 18:34, Ilya Maximets wrote: > On 3/21/24 17:09, Dumitru Ceara wrote: >> Some of the links were still pointing to OVS although we have >> OVN counterparts. >> >> Signed-off-by: Dumitru Ceara >> --- >> Documentation/intro/install/fedora.rst

Re: [ovs-dev] [PATCH ovn 2/5] Remove TODO-SPLIT.rst.

2024-03-21 Thread Dumitru Ceara
On 3/21/24 18:30, Ilya Maximets wrote: > On 3/21/24 17:09, Dumitru Ceara wrote: >> All the TODO items listed in it have been addressed (for a while). > > That's a bold statement. And I disagree. :) > It's the only type of statements I make. :) >> OVN includes OVS

[ovs-dev] [PATCH ovn 5/5] tests: Add multinode-testsuite to .gitinore.

2024-03-21 Thread Dumitru Ceara
Signed-off-by: Dumitru Ceara --- tests/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/.gitignore b/tests/.gitignore index 65cb1c6e4f..6971b426e9 100644 --- a/tests/.gitignore +++ b/tests/.gitignore @@ -6,6 +6,7 @@ /idltest.c /idltest.h /idltest.ovsidl +/multinode

[ovs-dev] [PATCH ovn 4/5] utilities/docker: Fix up container build.

2024-03-21 Thread Dumitru Ceara
Most of the steps were inaccurate. Instead, use latest Ubuntu, use OVS from the submodule inside the OVN repo. Signed-off-by: Dumitru Ceara --- utilities/docker/Makefile | 4 ++-- utilities/docker/debian/Dockerfile | 2 +- utilities/docker/debian/build.sh | 2 ++ utilities/docker

  1   2   3   4   5   6   7   8   9   10   >