On 29 May 2024, at 14:51, Ilya Maximets wrote:
> On 5/29/24 11:01, Eelco Chaudron wrote:
>>
>>
>> On 28 May 2024, at 16:49, Ilya Maximets wrote:
>>
>>> On 5/28/24 14:36, Eelco Chaudron wrote:
>>>>
>>>>
>>>> On 2
On 28 May 2024, at 17:44, Ilya Maximets wrote:
> On 5/22/24 14:47, Eelco Chaudron wrote:
>>
>>
>> On 21 May 2024, at 17:47, Simon Horman wrote:
>>
>>> On Tue, May 21, 2024 at 08:35:21AM +0200, Eelco Chaudron wrote:
>>>>
>>>>
>&g
This patch fixes an uninitialized gso_type case in
netdev_linux_prepend_vnet_hdr() by returning an error.
Fixes: 3337e6d91c5b ("userspace: Enable L4 checksum offloading by default.")
Signed-off-by: Eelco Chaudron
---
lib/netdev-linux.c | 4
1 file changed, 4 insertions(+)
diff -
ommon database command code into
library.")
Signed-off-by: Eelco Chaudron
---
lib/db-ctl-base.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/db-ctl-base.c b/lib/db-ctl-base.c
index 3a8068b12..b3e9b92d1 100644
--- a/lib/db-ctl-base.c
+++ b/lib/db-ctl-base.c
@@ -2656
-by: Paolo Valerio
Signed-off-by: Eelco Chaudron
---
ofproto/ofproto-dpif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index 32d037be6..fcd7cd753 100644
--- a/ofproto/ofproto-dpif.c
+++ b/ofproto/ofproto-dpif.c
@@ -6097
a Maximets
Signed-off-by: Eelco Chaudron
--
Note that this checkpatch reports an 'Improper whitespace
around control block' error on this patch + some warnings.
But I did not want to change the code style in this entire file.
---
lib/sflow_api.h | 6 +++---
lib/sflow_receiver.c
ystem.")
Acked-by: Mike Pattrick
Signed-off-by: Eelco Chaudron
---
lib/sflow_poller.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/sflow_poller.c b/lib/sflow_poller.c
index 9e6a487bc..46e40cbd4 100644
--- a/lib/sflow_poller.c
+++ b/lib/sflow_poller.c
@@
ndling by returning an error + log message.
- Changed sFlowRcvrTimeout to be using uint32_t to avoid TIME_T_MAKE.
Eelco Chaudron (8):
netdev-linux: Fix possible int overflow in tc_add_matchall_policer().
cfm: Fix possible integer overflow in tc_add_matchall_policer().
sflow: Replace libc's random() fu
structures to use uint32_t variables.
Fixes: c72e245a0e2c ("Add InMon's sFlow Agent library to the build system.")
Acked-by: Mike Pattrick
Signed-off-by: Eelco Chaudron
---
lib/sflow_api.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/sflow_api.h b/lib/s
Fix unintentional integer overflow reported by Coverity by adding
the LL suffix to the numerical literals used in the multiplication.
Fixes: 5767a79a4059 ("cfm: Require ccm received in demand mode.")
Acked-by: Mike Pattrick
Signed-off-by: Eelco Chaudron
---
lib/cfm.c | 2 +-
1 file
Fix unintentional integer overflow reported by Coverity by adding
the ULL suffix to the numerical literals used in the multiplications.
Fixes: ed2300cca0d3 ("netdev-linux: Refactor put police action netlink message")
Acked-by: Mike Pattrick
Signed-off-by: Eelco Chaudron
---
lib/netd
On 28 May 2024, at 21:30, Ilya Maximets wrote:
> On 5/28/24 13:39, Eelco Chaudron wrote:
>> This patch fixes an uninitialized gso_type case in
>> netdev_linux_prepend_vnet_hdr() by returning an error.
>>
>> Fixes: 3337e6d91c5b ("userspace: Enable L4 checksum of
On 28 May 2024, at 16:49, Ilya Maximets wrote:
> On 5/28/24 14:36, Eelco Chaudron wrote:
>>
>>
>> On 24 May 2024, at 11:20, Emma Finn wrote:
>>
>>> The AVX implementation for calcualting checksums was not
>>> handling carry-over addition
On 28 May 2024, at 19:56, Paolo Valerio wrote:
> Eelco Chaudron writes:
>
>> Fix the warning from Coverity about potential truncation of the
>> time_t value when copying to a local variable by changing the
>> local variable's type to time_t.
>>
>> ccc24
; Signed-off-by: Emma Finn
> Reported-by: Eelco Chaudron
> ---
> lib/odp-execute-avx512.c | 5
> tests/dpif-netdev.at | 64
> 2 files changed, 69 insertions(+)
>
> diff --git a/lib/odp-execute-avx512.c b/lib/odp-execute-av
This patch fixes an uninitialized gso_type case in
netdev_linux_prepend_vnet_hdr() by returning an error.
Fixes: 3337e6d91c5b ("userspace: Enable L4 checksum offloading by default.")
Signed-off-by: Eelco Chaudron
---
lib/netdev-linux.c | 5 +
1 file changed, 5 insertions(+)
ommon database command code into
library.")
Signed-off-by: Eelco Chaudron
---
lib/db-ctl-base.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/db-ctl-base.c b/lib/db-ctl-base.c
index 3a8068b12..b3e9b92d1 100644
--- a/lib/db-ctl-base.c
+++ b/lib/db-ctl-base.c
@@ -2656
Fix the warning from Coverity about potential truncation of the
time_t value when copying to a local variable by changing the
local variable's type to time_t.
ccc24fc88d59 ("ofproto-dpif: APIs and CLI option to add/delete static fdb
entry.")
Signed-off-by: Eelco Chaudron
---
ofpro
Changed sFlowRcvrTimeout to a uint32_t to avoid time_t warnings
reported by Coverity. A uint32_t is more than large enough as
this is a (seconds) tick counter and OVS is not even using this.
Fixes: c72e245a0e2c ("Add InMon's sFlow Agent library to the build system.")
Signed-off-by: Eelc
Fix unintentional integer overflow reported by Coverity by adding
the LL suffix to the numerical literals used in the multiplication.
Fixes: 5767a79a4059 ("cfm: Require ccm received in demand mode.")
Signed-off-by: Eelco Chaudron
---
lib/cfm.c | 2 +-
1 file changed, 1 insertion(+),
structures to use uint32_t variables.
Fixes: c72e245a0e2c ("Add InMon's sFlow Agent library to the build system.")
Signed-off-by: Eelco Chaudron
---
lib/sflow_api.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/sflow_api.h b/lib/sflow_api.h
index
ystem.")
Signed-off-by: Eelco Chaudron
---
lib/sflow_poller.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/sflow_poller.c b/lib/sflow_poller.c
index 9e6a487bc..46e40cbd4 100644
--- a/lib/sflow_poller.c
+++ b/lib/sflow_poller.c
@@ -6,6 +6,7 @@
*/
#include &q
Fix unintentional integer overflow reported by Coverity by adding
the ULL suffix to the numerical literals used in the multiplications.
Fixes: ed2300cca0d3 ("netdev-linux: Refactor put police action netlink message")
Signed-off-by: Eelco Chaudron
---
lib/netdev-linux.c | 4 ++--
1 fi
out to be using uint32_t to avoid TIME_T_MAKE.
Eelco Chaudron (8):
netdev-linux: Fix possible int overflow in tc_add_matchall_policer().
cfm: Fix possible integer overflow in tc_add_matchall_policer().
sflow: Replace libc's random() function with the OVS's random_range().
sflow: Use uint32_t inst
On 28 May 2024, at 1:04, Neil McKee wrote:
> Would it help if I set up a separate github project for this sFlow encoding
> C code? Then we could make it easier to incorporate in OVS by fixing the
> whitespace and indentation issues there, and maybe change all the "time_t"
> variables to
On 27 May 2024, at 16:42, Ilya Maximets wrote:
> On 5/27/24 13:01, Eelco Chaudron wrote:
>> Instead of casting time_t to uint32_t for the 0x comparison,
>> define a TIME_T_MAX and use it for both setting and comparison.
>>
>> Fixes: c72e245a0e2c ("
On 27 May 2024, at 16:56, Ilya Maximets wrote:
> On 5/27/24 13:01, Eelco Chaudron wrote:
>> This patch fixes a uninitialized gso_type case in
>> netdev_linux_prepend_vnet_hdr().
>>
>> Fixes: 3337e6d91c5b ("userspace: Enable L4 checksum offloading by default.&qu
On 27 May 2024, at 16:50, Ilya Maximets wrote:
> On 5/27/24 13:01, Eelco Chaudron wrote:
>> Coverity was flagged that the uninitialized output variable was used
>> in the ctl_context_init_command() function. This patch initializes
>> the variable.
>>
>> Fixes:
On 27 May 2024, at 16:04, Ilya Maximets wrote:
> On 5/27/24 13:01, Eelco Chaudron wrote:
>> Fix three Unintentional integer overflow reports by adding the
>> ULL/LL suffix to the numerical literals used in the multiplications.
>>
>> Fixes: 5767a79a4059 ("cfm
This patch fixes a uninitialized gso_type case in
netdev_linux_prepend_vnet_hdr().
Fixes: 3337e6d91c5b ("userspace: Enable L4 checksum offloading by default.")
Signed-off-by: Eelco Chaudron
---
lib/netdev-linux.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/
Coverity was flagged that the uninitialized output variable was used
in the ctl_context_init_command() function. This patch initializes
the variable.
Fixes: 07ff77ccb82a ("db-ctl-base: Make common database command code into
library.")
Signed-off-by: Eelco Chaudron
---
lib/db-ctl-
Fix the warning from Coverity about potential truncation of the
time_t value when copying to a local variable by changing the
local variable's type to time_t.
ccc24fc88d59 ("ofproto-dpif: APIs and CLI option to add/delete static fdb
entry.")
Signed-off-by: Eelco Chaudron
---
ofpro
Instead of casting time_t to uint32_t for the 0x comparison,
define a TIME_T_MAX and use it for both setting and comparison.
Fixes: c72e245a0e2c ("Add InMon's sFlow Agent library to the build system.")
Signed-off-by: Eelco Chaudron
--
Note that this checkpatch reports an
structures to use uint32_t variables.
Fixes: c72e245a0e2c ("Add InMon's sFlow Agent library to the build system.")
Signed-off-by: Eelco Chaudron
---
lib/sflow_api.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/sflow_api.h b/lib/sflow_api.h
index
ystem.")
Signed-off-by: Eelco Chaudron
---
lib/sflow_poller.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/sflow_poller.c b/lib/sflow_poller.c
index 9e6a487bc..46e40cbd4 100644
--- a/lib/sflow_poller.c
+++ b/lib/sflow_poller.c
@@ -6,6 +6,7 @@
*/
#include &q
ge")
Signed-off-by: Eelco Chaudron
---
lib/cfm.c | 2 +-
lib/netdev-linux.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/cfm.c b/lib/cfm.c
index c3742f3de..7eb080157 100644
--- a/lib/cfm.c
+++ b/lib/cfm.c
@@ -863,7 +863,7 @@ cfm_process_heartbeat(struct cf
gt; This commit also adds a unit test to fuzz test the actions
> autovalidator.
>
> Signed-off-by: Emma Finn
> Reported-by: Eelco Chaudron
> ---
> lib/odp-execute-avx512.c | 5 +
> tests/dpif-netdev.at | 26 ++
> 2 files changed, 31 inserti
On 22 May 2024, at 0:11, Ilya Maximets wrote:
> On 5/16/24 19:03, Adrian Moreno wrote:
>>
>>
>> On 4/24/24 9:53 PM, Adrian Moreno wrote:
>>> This is the userspace counterpart of the work being done in the kernel
>>> [1]. Sending it as RFC to get some early feedback on the overall
>>> solution.
On 21 May 2024, at 17:47, Simon Horman wrote:
> On Tue, May 21, 2024 at 08:35:21AM +0200, Eelco Chaudron wrote:
>>
>>
>> On 20 May 2024, at 20:13, Simon Horman wrote:
>>
>>> From: Ville Skyttä
>>>
>>> Fix CONFIG_HAVE_EBPF_JIT Kconfi
On 16 May 2024, at 14:46, Ilya Maximets wrote:
> On 5/14/24 15:15, Eelco Chaudron wrote:
>> The flow_reval_monitor.py script incorrectly reported the reasons for
>> FDR_PURGE and FDR_TOO_EXPENSIVE, as their descriptions were swapped.
>> This patch rectifies the ord
On 1 May 2024, at 16:54, Mike Pattrick wrote:
> Currently a bridge mirror will collect all packets and tools like
> ovs-tcpdump can apply additional filters after they have already been
> duplicated by vswitchd. This can result in inefficient collection.
>
> This patch adds support to apply
On 21 May 2024, at 0:03, Ilya Maximets wrote:
> On 5/1/24 14:33, Eelco Chaudron wrote:
>>
>>
>> On 29 Apr 2024, at 14:59, Ilya Maximets wrote:
>>
>>> On 4/16/24 09:44, Eelco Chaudron wrote:
>>>> This patch adds a daily Coverity run for the OVS ma
FDP-164
> Fixes: 58264848a5a7 ("openvswitch: Add vxlan tunneling support.")
> Signed-off-by: Aaron Conole
Thanks for the additional comments and detailed commit message. The change
looks good to me.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
;odp: Add SRv6 tunnel actions.")
> Fixes: 03fc1ad78521 ("userspace: Add SRv6 tunnel support.")
> Signed-off-by: Ilya Maximets
Thanks for fixing this, looks good to me.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 20 May 2024, at 17:39, Simon Horman wrote:
> Add Jun Gu to AUTHORS file.
>
> Signed-off-by: Simon Horman
Looks good to me.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/lis
On 20 May 2024, at 17:39, Simon Horman wrote:
> From: Jun Gu
>
> Correct spelling of destination in ovs-ctl.in.
>
> Signed-off-by: Jun Gu
> Signed-off-by: Simon Horman
> ---
Looks good to me.
Acked-by: Eelco Chaudron
_
On 20 May 2024, at 20:13, Simon Horman wrote:
> Add Ville Skyttä to AUTHORS file.
>
> Signed-off-by: Simon Horman
Looks good.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
/tooling?
The rest looks good.
Acked-by: Eelco Chaudron
> Signed-off-by: Simon Horman
> ---
> Documentation/intro/install/afxdp.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/intro/install/afxdp.rst
> b/Documentation/intro/
ackaging' is a common dependency, added to the test
> requirements so it will not be missed in CI.
>
> Signed-off-by: Ilya Maximets
Thanks for fixing this. The changes look good to me.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
ests.")
> Signed-off-by: Ilya Maximets
Thanks for fixing this. The changes looks good to me.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
macros already check to make sure the function parameter
> is the correct size.
>
> So that check is disabled in the single function that is causing all of
> the errors.
>
> Signed-off-by: Mike Pattrick
Thanks for fixing the naming.
Acked-by: Eelco Chaudron
___
On 1 May 2024, at 16:54, Mike Pattrick wrote:
> Currently a bridge mirror will collect all packets and tools like
> ovs-tcpdump can apply additional filters after they have already been
> duplicated by vswitchd. This can result in inefficient collection.
>
> This patch adds support to apply
ttrick
> Acked-by: Simon Horman
> Acked-by: Eelco Chaudron
> Signed-off-by: Mike Pattrick
> ---
Even with the additional changes this patch looks good to me.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://m
gt; This commit also adds a unit test to fuzz test the actions
> autovalidator.
>
> Signed-off-by: Emma Finn
> Reported-by: Eelco Chaudron
Hi Emma,
Thanks for also fixing the IPv6 case, however, the test you added does not seem
to catch the issue. See notes below.
Cheers,
Eelc
)
> #10 0xaeb50110 in __libc_start_main (/usr/lib64/libc.so.6+
> 0x2b110)
> #11 0x40906c in _start (/usr/local/bin/ovsdb-client+0x40906c)
>
> Fixes: cb139fa8b3a1 ("table: New function table_format() for formatting a
> table as a string.")
> Signed
On 13 May 2024, at 17:02, Ilya Maximets wrote:
> On 5/8/24 11:19, Eelco Chaudron wrote:
>> The flow_reval_monitor.py script incorrectly reported the reasons for
>> FDR_PURGE and FDR_TOO_EXPENSIVE, as their descriptions were swapped.
>> This patch rectifies the order using
of the
script, with the comments in the code.
Fixes: 86b9e653ef22 ("revalidator: Add a USDT probe during flow deletion with
purge reason.")
Signed-off-by: Eelco Chaudron
---
v3: - Renamed ofproto dpif to bridge in delete reasons.
- Added comment pointing back to delete reasons in .c.
v2: -
On 14 May 2024, at 14:50, Ilya Maximets wrote:
> On 5/14/24 14:43, Eelco Chaudron wrote:
>>
>>
>> On 14 May 2024, at 14:28, Ilya Maximets wrote:
>>
>>> On 5/14/24 13:27, Eelco Chaudron wrote:
>>>>
>>>>
>>>> On 14 May
On 14 May 2024, at 14:28, Ilya Maximets wrote:
> On 5/14/24 13:27, Eelco Chaudron wrote:
>>
>>
>> On 14 May 2024, at 13:05, Ilya Maximets wrote:
>>
>>> On 5/14/24 12:14, Adrian Moreno wrote:
>>>>
>>>>
>>>> On 5/14/24 11
On 14 May 2024, at 13:05, Ilya Maximets wrote:
> On 5/14/24 12:14, Adrian Moreno wrote:
>>
>>
>> On 5/14/24 11:09 AM, Ilya Maximets wrote:
>>> On 5/14/24 09:39, Adrian Moreno wrote:
>>>>
>>>>
>>>> On 5/10/24 12:45 PM, Adrian M
On 13 May 2024, at 21:59, Adrian Moreno wrote:
> On 5/13/24 2:38 PM, Adrian Moreno wrote:
>>
>>
>> On 5/13/24 1:32 PM, Eelco Chaudron wrote:
>>>
>>>
>>> On 13 May 2024, at 10:44, Adrian Moreno wrote:
>>>
>>>> On 5/10/24 1
On 13 May 2024, at 14:44, Adrian Moreno wrote:
> On 5/13/24 2:38 PM, Ilya Maximets wrote:
>> On 5/13/24 09:17, Eelco Chaudron wrote:
>>>
>>>
>>> On 10 May 2024, at 15:06, Ilya Maximets wrote:
>>>
>>>> On 5/10/24 14:01, Eelco Chaudron
On 13 May 2024, at 14:50, Adrian Moreno wrote:
> On 5/13/24 2:48 PM, Ilya Maximets wrote:
>> On 5/13/24 13:10, Adrian Moreno wrote:
>>>
>>>
>>> On 5/13/24 12:44 PM, Eelco Chaudron wrote:
>>>>
>>>>
>>>> On 13 May 2024, at 9
On 13 May 2024, at 10:44, Adrian Moreno wrote:
> On 5/10/24 12:06 PM, Eelco Chaudron wrote:
>> On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
>>
>>> Offload the sample action if it contains psample information by creating
>>> a tc "sample" action with
On 13 May 2024, at 9:01, Adrian Moreno wrote:
> On 5/10/24 12:06 PM, Eelco Chaudron wrote:
>> On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
>>
>>> This simple program reads from psample and prints the packets to stdout.
>>> It's useful for quickly collectin
On 10 May 2024, at 13:15, Adrian Moreno wrote:
> On 5/10/24 12:06 PM, Eelco Chaudron wrote:
>> On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
>>
>>> When a OFP_SAMPLE action is xlated and a dpif_psample object has been
>>> configured (via Flow_Sample_C
On 13 May 2024, at 8:45, Adrian Moreno wrote:
> On 5/10/24 12:06 PM, Eelco Chaudron wrote:
>> On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
>>
>>> Add a new resource in ofproto-dpif and the corresponding API in
>>> ofproto_provider.h to represent and change
On 10 May 2024, at 15:06, Ilya Maximets wrote:
> On 5/10/24 14:01, Eelco Chaudron wrote:
>>
>>
>> On 10 May 2024, at 12:45, Adrian Moreno wrote:
>>
>>> On 5/10/24 12:06 PM, Eelco Chaudron wrote:
>>>> On 24 Apr 2024, at 21:53, Adrian Moreno wrote
On 10 May 2024, at 12:45, Adrian Moreno wrote:
> On 5/10/24 12:06 PM, Eelco Chaudron wrote:
>> On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
>>
>>> The new odp sample attributes allow userspace to specify a group_id and
>>> user-defined cookie to be passed dow
s.
>
> Fixes: 92eb03f7b03a ("odp-execute: Add ISA implementation of set_masked IPv4
> action")
> Signed-off-by: Emma Finn
> Reported-by: Eelco Chaudron
Hi Emma,
Thanks for fixing this, however, it looks like the same issue also exists in
IPv6.
In addition, can you also a
On 7 May 2024, at 16:30, Adrian Moreno wrote:
> Add a man page for ovs-flowviz as well as a topic page with some more
> detailed examples.
>
> Signed-off-by: Adrian Moreno
Thanks for making the changes, they look good to me.
Acked-by: Ee
On 10 May 2024, at 10:23, Adrian Moreno wrote:
> On 5/10/24 9:14 AM, Eelco Chaudron wrote:
>>
>>
>> On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
>>
>>> This is the userspace counterpart of the work being done in the kernel
>>> [1]. Sending it as
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
Maybe add a small description to this patch.
> Signed-off-by: Adrian Moreno
> ---
> ofproto/ofproto-dpif-psample.c | 59 ++
> ofproto/ofproto-dpif-psample.h | 1 +
> ofproto/ofproto-dpif.c | 1 +
> 3 files
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
> In preparation to allowing certain actions to have a cookie that does
> not represent the entire flow, rename flower->act_cookie to
> flower->flow_cookie.
>
> This patch does not introduce any behavioral change, it's just a
> variable renaming.
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
> Add a psample_group field to the Flow Sample Collector Set table and use
> it to configure the psample ofproto layer.
See comments below,
Eelco
> Signed-off-by: Adrian Moreno
> ---
> vswitchd/bridge.c | 54
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
> Add a new resource in ofproto-dpif and the corresponding API in
> ofproto_provider.h to represent and change psample configuration.
See comments below.
//Eelco
> Signed-off-by: Adrian Moreno
> ---
> ofproto/automake.mk| 2 +
>
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
> This simple program reads from psample and prints the packets to stdout.
> It's useful for quickly collecting sampled packets.
See some comments below, did not review the actual sample application in detail.
//Eelco
> Signed-off-by: Adrian
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
> Only kernel datapath supports psample so check that the datapath is not
> userspace and that it accepts the new attributes.
>
> Signed-off-by: Adrian Moreno
> ---
> ofproto/ofproto-dpif.c | 59 ++
>
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
> The new odp sample attributes allow userspace to specify a group_id and
> user-defined cookie to be passed down to psample.
>
> Add support for parsing and formatting such action.
>
> Signed-off-by: Adrian Moreno
Hi Adrian,
See my comments below
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
> When a OFP_SAMPLE action is xlated and a dpif_psample object has been
> configured (via Flow_Sample_Collector_Set table) with the same
> collector_set_id, add psample information to the odp sample action.
See comments below.
//Eelco
>
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
> Signed-off-by: Adrian Moreno
> ---
> tests/system-common-macros.at| 4 +++
> tests/system-offloads-traffic.at | 53
> 2 files changed, 57 insertions(+)
>
> diff --git a/tests/system-common-macros.at
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
> Offload the sample action if it contains psample information by creating
> a tc "sample" action with the user cookie inside the action's cookie.
>
> Avoid using the "sample" action's cookie to store the ufid.
I have some concerns about the sample
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
> Add a cache entry type for psample objects.
> Store both the dpif_psample reference and the collector_set_id so we can
> quickly find the particular exporter.
>
> Using that mechanism, account for packet and byte statistics.
See comments inline.
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
> This is the userspace counterpart of the work being done in the kernel
> [1]. Sending it as RFC to get some early feedback on the overall
> solution.
>
> ** Problem description **
> Currently, OVS supports several observability features, such as
On 9 May 2024, at 15:25, Simon Horman wrote:
> On Wed, May 08, 2024 at 11:19:56AM +0200, Eelco Chaudron wrote:
>> The flow_reval_monitor.py script incorrectly reported the reasons for
>> FDR_PURGE and FDR_TOO_EXPENSIVE, as their descriptions were swapped.
>> This patc
penvswitch: Add original direction conntrack tuple to
> sw_flow_key.")
> Reported-by: Antonin Bas
> Closes: https://github.com/openvswitch/ovs-issues/issues/327
> Signed-off-by: Ilya Maximets
This patch looks good to me.
Acked-by: Eelco Chaudron
> ---
>
> Note: I'm wor
On 7 May 2024, at 16:18, Adrian Moreno wrote:
> On 5/3/24 11:43 AM, Eelco Chaudron wrote:
>>
>>
>> On 24 Apr 2024, at 15:50, Adrian Moreno wrote:
>>
>>> Add support for psample sampling via two new attributes to the
>>> OVS_ACTION_ATTR_SAMPLE actio
of the
script, with the comments in the code.
Fixes: 86b9e653ef22 ("revalidator: Add a USDT probe during flow deletion with
purge reason.")
Signed-off-by: Eelco Chaudron
---
v2: - Converted the list of strings to dictionary.
- Added comment to code to keep code and script in sync.
-18T14:50:17.0770596Z WARNING: Running the setup command as
> `meson [options]` instead of `meson setup [options]` is ambiguous
> and deprecated.
>
> Link: https://git.dpdk.org/dpdk/commit/?id=bf66003b51ec
> Signed-off-by: David Marchand
Thanks, the change looks good to me.
Acked-b
needs to prevent these packets from being processed through TC.
Signed-off-by: Eelco Chaudron
---
v2: - Fixed and added some comments.
- Use ovs-pcap to compare packets.
NOTE: This patch needs an AVX512 fix before it can be applied.
Intel is working on this.
---
lib/netdev-offload-tc.c
On 2 May 2024, at 14:46, Ilya Maximets wrote:
> On 4/29/24 16:48, Eelco Chaudron wrote:
>> While offloading header modifications to TC, OVS is using {TCA_PEDIT} +
>> {TCA_CSUM} combination as that it the only way to represent header
>> rewrite. However, {TCA_CSUM} is u
On 24 Apr 2024, at 15:50, Adrian Moreno wrote:
> Add support for psample sampling via two new attributes to the
> OVS_ACTION_ATTR_SAMPLE action.
>
> OVS_SAMPLE_ATTR_PSAMPLE_GROUP used to pass an integer psample group_id.
> OVS_SAMPLE_ATTR_PSAMPLE_COOKIE used to pass a variable-length binary
>
44) 'action_set' (line 4762)
>
> SUMMARY: AddressSanitizer: stack-use-after-return
>ofproto/ofproto-dpif-trace.c:704:49 in ofproto_trace_recirc_node
>
> Fix that by copying the action.
>
> Fixes: d072d2de011b ("ofproto-dpif-trace: Improve NAT tracing.")
> Repor
> Fixes: db5a101931c5 ("clang: Fix the alignment warning.")
> Signed-off-by: Ales Musil
> ---
> v3: Do partial revert of db5a101931c5 instead of simple cast.
Looks good to me.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 2 May 2024, at 16:48, Finn, Emma wrote:
>> -Original Message-
>> From: Eelco Chaudron
>> Sent: Thursday, May 2, 2024 8:14 AM
>> To: Finn, Emma
>> Cc: Simon Horman ; Stokes, Ian ;
>> Van Haaren, Harry ; d...@openvswitch.org;
>> Flavio Lei
The flow_reval_monitor.py script incorrectly reported the reasons for
FDR_PURGE and FDR_TOO_EXPENSIVE, as their descriptions were swapped.
This patch rectifies the order.
Fixes: 86b9e653ef22 ("revalidator: Add a USDT probe during flow deletion with
purge reason.")
Signed-off-by: Eelc
On 1 May 2024, at 15:36, Finn, Emma wrote:
>> -Original Message-
>> From: Eelco Chaudron
>> Sent: Wednesday, May 1, 2024 1:52 PM
>> To: Simon Horman
>> Cc: Finn, Emma ; Stokes, Ian ;
>> sunil.pa...@intel.com; Van Haaren, Harry ;
>> d...@openv
On 1 May 2024, at 14:39, Simon Horman wrote:
> On Tue, Apr 30, 2024 at 02:42:45PM +0200, Eelco Chaudron wrote:
>> Greetings, Intel team!
>>
>> The self-test conducted as part of this patch has revealed an issue with the
>> AVX512 checksumming code. Since it was agree
On 29 Apr 2024, at 14:59, Ilya Maximets wrote:
> On 4/16/24 09:44, Eelco Chaudron wrote:
>> This patch adds a daily Coverity run for the OVS main branch
>> to the GitHub actions. The result of the runs can be found here:
>>
>> https://scan.coverity.com/projec
On 26 Apr 2024, at 10:57, Simon Horman wrote:
> On Tue, Apr 16, 2024 at 09:44:52AM +0200, Eelco Chaudron wrote:
>> This patch adds a daily Coverity run for the OVS main branch
>> to the GitHub actions. The result of the runs can be found here:
>>
>> https:/
1 - 100 of 2805 matches
Mail list logo
