quot;vxlan_sys_4789"),
and relevant offload flows are not destroyed.
To fix it, add the datapath netdev to the netdev-offload ports map. In
case there is no different internal netdev, use the dpif netdev, as before.
Fixes: adbd4301a249 ("netdev-offload-dpdk: Use per-netdev offload metadata.&
-netdev offload metadata.")
Reported-by: 15895987278
Signed-off-by: Eli Britstein
---
lib/netdev-offload-dpdk.c | 35 ++-
1 file changed, 30 insertions(+), 5 deletions(-)
diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c
index 14bc87771..992627
quot;vxlan_sys_4789"),
and relevant offload flows are not destroyed.
To fix it, add the datapath netdev to the netdev-offload ports map. In
case there is no different internal netdev, use the dpif netdev, as before.
Fixes: adbd4301a249 ("netdev-offload-dpdk: Use per-netdev offload metadata.&
-netdev offload metadata.")
Reported-by: 15895987278
Signed-off-by: Eli Britstein
---
lib/netdev-offload-dpdk.c | 35 ++-
1 file changed, 30 insertions(+), 5 deletions(-)
diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c
index 14bc87771..992627
>-Original Message-
>From: David Marchand
>Sent: Friday, 26 May 2023 17:48
>To: Eli Britstein
>Cc: d...@openvswitch.org; Ilya Maximets ;
>wuxi_...@163.com
>Subject: Re: [ovs-dev] [PATCH 1/2] netdev-offload-dpdk: Fix flushing of a
>physdev
>
>External em
>-Original Message-
>From: Ivan Malov
>Sent: Sunday, 4 June 2023 15:58
>To: Eli Britstein
>Cc: ovs-dev@openvswitch.org; Ilya Maximets ; Ori
>Kam ; David Marchand
>Subject: RE: [PATCH v4 3/3] netdev-offload-dpdk: use flow transfer proxy
>mechanism
>
&
nal Message-
>From: Nole Zhang
>Sent: Friday, 31 March 2023 6:20
>To: Eli Britstein ; Simon Horman
>; d...@openvswitch.org
>Cc: Ilya Maximets ; Chaoyong He
>; Kevin Liu ; oss-drivers
>
>Subject: RE: [PATCH dpdk-latest v3 0/6] Add support for DPDK meter HW
>offload
st/?series=342885=*
Thanks,
Eli
>-Original Message-
>From: Simon Horman
>Sent: Thursday, 30 March 2023 14:21
>To: d...@openvswitch.org
>Cc: Ilya Maximets ; Eli Britstein ;
>Chaoyong He ; Peng Zhang
>; Jin Liu ; oss-
>driv...@corigine.com
>Subject: [PATCH dpdk-late
>-Original Message-
>From: Ivan Malov
>Sent: Tuesday, 21 February 2023 2:41
>To: ovs-dev@openvswitch.org
>Cc: Ilya Maximets ; Eli Britstein ; Ori
>Kam ; David Marchand
>Subject: [PATCH v4 3/3] netdev-offload-dpdk: use flow transfer proxy
>mechanism
>
&
>-Original Message-
>From: David Marchand
>Sent: Wednesday, 11 January 2023 10:53
>To: Ivan Malov ; Eli Britstein ;
>d...@openvswitch.org
>Cc: Ilya Maximets ; Ori Kam ;
>Andrew Rybchenko ; Ian Stokes
>
>Subject: [PATCH] netdev-offload-dpdk: Fix transfer fl
>-Original Message-
>From: David Marchand
>Sent: Wednesday, 11 January 2023 10:32
>To: Eli Britstein ; Ivan Malov
>Cc: Ilya Maximets ; d...@openvswitch.org; Stephen
>Hemminger ; Ori Kam ;
>Maxime Coquelin ; Ian Stokes
>; Andrew Rybchenko
>
>Subject: Re: [
>-Original Message-
>From: David Marchand
>Sent: Wednesday, 11 January 2023 9:59
>To: Ivan Malov
>Cc: Ilya Maximets ; Eli Britstein ;
>d...@openvswitch.org; Stephen Hemminger
>; Ori Kam ; Maxime
>Coquelin ; Ian Stokes
>; Andrew Rybchenko
>
>Subject: Re
>-Original Message-
>From: Nole Zhang
>Sent: Monday, 9 January 2023 11:23
>To: Eli Britstein ; d...@openvswitch.org
>Cc: Eelco Chaudron ; Ilya Maximets
>; Chaoyong He ; oss-
>drivers
>Subject: RE: [PATCH 0/6] Add support for DPDK meter HW offload
>
>Exter
>-Original Message-
>From: Nole Zhang
>Sent: Friday, 6 January 2023 11:28
>To: Eli Britstein ; d...@openvswitch.org
>Cc: Eelco Chaudron ; Ilya Maximets
>; Chaoyong He ; oss-
>drivers ; Nole Zhang
>Subject: RE: [PATCH 0/6] Add support for DPDK meter HW offloa
be
shared between multiple flows, on different ports.
>-Original Message-
>From: Simon Horman
>Sent: Friday, 16 December 2022 17:51
>To: d...@openvswitch.org
>Cc: Eelco Chaudron ; Ilya Maximets
>; Eli Britstein ; Chaoyong He
>; oss-driv...@corigine.com; Peng Zhang
>;
y.type' was declared here
8460 | struct ofputil_bundle_ctrl_msg reply;
|^
Fixes: 777af88d50b8 ("Add basic implementation for OpenFlow 1.4 bundles")
Signed-off-by: Eli Britstein
---
ofproto/ofproto.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/o
-overflow=]
59 | return __builtin___memset_chk (__dest, __ch, __len,
| ^
[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92718
Signed-off-by: Eli Britstein
---
lib/netlink.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/lib/netlink.c b/lib
140:18: note: 'limit' was declared here
2140 | uint32_t limit;
| ^
Fixes: 4eeec031d4c4 ("dpctl: Implement dpctl commands for conntrack per zone
limit")
Signed-off-by: Eli Britstein
---
lib/dpctl.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
/ovsdb/ovsdb.c:230:36: note: 'table' was declared here
230 | struct ovsdb_table_schema *table;
|^
Fixes: f85f8ebbfac9 ("Initial implementation of OVSDB.")
Signed-off-by: Eli Britstein
---
ovsdb/ovsdb.c | 2 +-
1 file changed, 1 insertio
After resolving DPDK cast align warnings as stated in [1], and
resolving some more warnings in OVS side, enforce -Werror for debian and
rhel builds too.
[1] 0b6d2faace76 ("ci: Remove -Wno-cast-align from CI.")
Signed-off-by: Eli Britstein
---
debian/rules | 4
t;)
Signed-off-by: Eli Britstein
---
utilities/ovs-ofctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c
index fe9114580..6805140d6 100644
--- a/utilities/ovs-ofctl.c
+++ b/utilities/ovs-ofctl.c
@@ -3121,7 +3121,7 @@ s
Fixing various warnings and enable Werror for debian/rhel builds.
Eli Britstein (8):
dp-packet: Fix dp-packet may be used initialized
ofp-port: Fix 'strnlen' specified bound may exceed source size
ovs-ofctl: Fix 'usable_protocols' may be used uninitialized
dpctl: Fix zone/limit may
: error: 'strnlen' specified bound 15 may exceed source
size 11 [-Werror=stringop-overread]
380 | size_t len = strnlen(src, size - 1);
| ^
Fixes: 28b114322856 ("ofp-util: New function ofputil_port_to_string().")
Signed-off-by: Eli Britstein
---
lib/ofp-
MASK;
|^
Fixes: a47e2db209e4 ("dp-packet: Refactor offloading API.")
Signed-off-by: Eli Britstein
---
lib/dp-packet.c | 1 -
lib/dp-packet.h | 7 ---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/dp-packet.c b/lib/dp-packet.c
i
>-Original Message-
>From: Simon Horman
>Sent: Monday, 14 November 2022 12:44
>To: Eli Britstein
>Cc: d...@openvswitch.org; Ilya Maximets ; Simon
>Horman ; Salem Sol
>Subject: Re: [PATCH] debian, rhel: Enable Werror option in spec files
>
>External email
Following resolving DPDK cast align warnings as stated in [1], enforce
-Werror for RPM builds too.
[1] 0b6d2faace76 ("ci: Remove -Wno-cast-align from CI.")
Signed-off-by: Eli Britstein
---
debian/rules | 4 ++--
rhel/openvswitch.spec.in | 2 +-
2 files changed, 3 insert
Acked-by: Eli Britstein
>-Original Message-
>From: Simon Horman
>Sent: Wednesday, 9 November 2022 21:55
>To: d...@openvswitch.org
>Cc: Eelco Chaudron ; Ilya Maximets
>; Eli Britstein ; Chaoyong He
>; oss-driv...@corigine.com; Louis Peens
>; Simon Horman
>
is OK but the commit message tells a long
story, opinions etc instead of just stating the bug fix.
>-Original Message-
>From: Simon Horman
>Sent: Wednesday, 26 October 2022 12:05
>To: d...@openvswitch.org
>Cc: Eelco Chaudron ; Ilya Maximets
>; Eli Britstein ; Chaoy
quot;vxlan_sys_4789"),
and relevant offload flows are not destroyed.
To fix it, add the datapath netdev to the netdev-offload ports map. In
case there is no different internal netdev, use the dpif netdev, as before.
Fixes: adbd4301a249 ("netdev-offload-dpdk: Use per-netdev offload metadata.&
, the physdev fails to be removed.
Fix it by flushing the physdev's offload flows in all related netdevs,
e.g. the netdev itself, or for physical devices, all vports.
Fixes: adbd4301a249 ("netdev-offload-dpdk: Use per-netdev offload metadata.")
Reported-by: 15895987278
Signed-off-by: Eli
]: 6e50c1651869 ("dpif-netdev: Avoid hw_miss_packet_recover() for devices
with no support.")
Fixes: 6e50c1651869 ("dpif-netdev: Avoid hw_miss_packet_recover() for devices
with no support.")
Signed-off-by: Eli Britstein
---
lib/dpif-netdev.c| 18 +++---
lib/n
On 8/16/2022 3:50 PM, Simon Horman wrote:
From: Chaoyong He
Add the support of offload of set IPv4 DSCP action.
Signed-off-by: Chaoyong He
Signed-off-by: Simon Horman
---
lib/netdev-offload-dpdk.c | 21 ++---
1 file changed, 18 insertions(+), 3 deletions(-)
diff --git
On 8/16/2022 3:50 PM, Simon Horman wrote:
From: Chaoyong He
Add support of IPv6 tunnel.
IPv6 tunnel is already supported. The missing setting of is_ipv6 field
affects only if using a dpdk PMD that would return restore info flags
with RTE_FLOW_RESTORE_INFO_TUNNEL on, but
>-Original Message-
>From: Ivan Malov
>Sent: Wednesday, July 20, 2022 3:18 PM
>To: d...@openvswitch.org
>Cc: Eli Britstein ; Stephen Hemminger
>; Ilya Maximets ; Ori
>Kam ; Maxime Coquelin
>; David Marchand
>; Andrew Rybchenko
>
>Subject: [PATCH v3 3
A connection is established if we see packets from both directions.
The cited commit [1] fixed the issue of sending twice in one direction,
but still an issue if more than that.
Fix it.
Fixes: a867c010ee91 ("conntrack: Fix conntrack new state")
Signed-off-by: Eli Britstein
---
lib
]: 6e50c1651869 ("dpif-netdev: Avoid hw_miss_packet_recover() for devices
with no support.")
Fixes: 6e50c1651869 ("dpif-netdev: Avoid hw_miss_packet_recover() for devices
with no support.")
Signed-off-by: Eli Britstein
---
lib/dpif-netdev.c| 15 ---
lib/n
+Ori
From: Finn, Emma
Sent: Friday, June 24, 2022 5:41 PM
To: Ilya Maximets ; ovs-dev@openvswitch.org
; Stokes, Ian
Cc: Eli Britstein ; Slava Ovsiienko ;
Flavio Leitner ; Matan Azrad
Subject: RE: [ovs-dev] [PATCH] netdev-offload-dpdk: setting RSS hash types
Hi Ivan,
>-Original Message-
>From: Ivan Malov
>Sent: Wednesday, June 8, 2022 10:02 PM
>To: Eli Britstein
>Cc: d...@openvswitch.org; Andrew Rybchenko
>; Ilya Maximets ;
>Ori Kam ; NBU-Contact-Thomas Monjalon (EXTERNAL)
>; Stephen Hemminger
>; David Marcha
Hi Ivan,
>-Original Message-
>From: Ivan Malov
>Sent: Wednesday, June 8, 2022 5:46 PM
>To: Eli Britstein
>Cc: d...@openvswitch.org; Andrew Rybchenko
>; Ilya Maximets ;
>Ori Kam ; NBU-Contact-Thomas Monjalon (EXTERNAL)
>; Stephen Hemminger
>; David Marcha
Hi Ivan,
>-Original Message-
>From: Ivan Malov
>Sent: Tuesday, June 7, 2022 11:56 PM
>To: Eli Britstein
>Cc: d...@openvswitch.org; Andrew Rybchenko
>; Ilya Maximets ;
>Ori Kam ; NBU-Contact-Thomas Monjalon (EXTERNAL)
>; Stephen Hemminger
>; David Marcha
2022 5:16 PM
>To: d...@openvswitch.org
>Cc: Andrew Rybchenko ; Ilya Maximets
>; Ori Kam ; Eli Britstein
>; NBU-Contact-Thomas Monjalon (EXTERNAL)
>; Stephen Hemminger
>; David Marchand
>; Gaetan Rivet ; Maxime
>Coquelin
>Subject: [PATCH 1/3] netdev-dpdk: negotiate delivery of per-pack
uot;started" and creation of flows will fail.
>-Original Message-
>From: Ivan Malov
>Sent: Monday, May 30, 2022 5:16 PM
>To: d...@openvswitch.org
>Cc: Andrew Rybchenko ; Ilya Maximets
>; Ori Kam ; Eli Britstein
>; NBU-Contact-Thomas Monjalon (EXTERNAL)
>; Stephe
, and fallback
to RAW. Geneve is under this category.
From: Hemal Shah
Sent: Wednesday, May 18, 2022 6:02 PM
To: Eli Britstein
Cc: Ilya Maximets ; d...@openvswitch.org
Subject: Re: [ovs-dev] [PATCH V2 3/3] netdev-offload-dpdk: Add geneve header
pattern match
Eli,
I'm trying to understand options handling
>-Original Message-
>From: Ilya Maximets
>Sent: Wednesday, May 4, 2022 2:44 PM
>To: Eli Britstein ; d...@openvswitch.org
>Cc: i.maxim...@ovn.org; Gaetan Rivet ;
>msant...@redhat.com; Nir Anteby
>Subject: Re: [PATCH V2 3/3] netdev-offload-dpdk: Add geneve
Tunnel offload APIs have '__rte_experimental' attribute, therefore
available only if ALLOW_EXPERIMENTAL_API is defined. Documente it.
Signed-off-by: Eli Britstein
---
Documentation/howto/dpdk.rst | 4
1 file changed, 4 insertions(+)
diff --git a/Documentation/howto/dpdk.rst b
> -Original Message-
> From: Ilya Maximets
> Sent: Wednesday, March 16, 2022 2:43 PM
> To: Eli Britstein ; d...@openvswitch.org; Emma Finn
>
> Cc: i.maxim...@ovn.org; Ian Stokes
> Subject: Re: [ovs-dev] [PATCH V4 1/2] netdev-offload-dpdk: Use has_vlan
> match
Add support for matching on geneve header.
Signed-off-by: Eli Britstein
Reviewed-by: Nir Anteby
Acked-by: Michael Santana
---
NEWS | 2 ++
lib/netdev-offload-dpdk.c | 58 +++
2 files changed, 60 insertions(+)
diff --git a/NEWS b/NEWS
Add support for dpdk geneve tunnel offloads.
v2-v1:
- Rebase.
GitHub actions:
v1: https://github.com/elibritstein/OVS/actions/runs/1633157455
v2: https://github.com/elibritstein/OVS/actions/runs/1807027490
Eli Britstein (3):
netdev-dpdk: Add flow_api support for netdev geneve vports
netdev
Signed-off-by: Eli Britstein
Reviewed-by: Nir Anteby
Acked-by: Michael Santana
---
lib/netdev-offload-dpdk.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c
index 94dc6a9b7..edd4e009d 100644
--- a/lib/netdev-offload
Add the acceptance of geneve devices to netdev_dpdk_flow_api_supported()
API, to allow offloading of DPDK geneve devices.
Signed-off-by: Eli Britstein
Reviewed-by: Nir Anteby
Acked-by: Michael Santana
---
lib/netdev-dpdk.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
case.
[1] 0d25621e4d9f ("dpif-netdev: Fix flow modification after failure.")
Fixes: b5e6f6f6bfbe ("dpif-netdev: Provide orig_in_port in metadata for
tunneled packets.")
Signed-off-by: Eli Britstein
---
lib/dpif-netdev-private-flow.h | 1 +
lib/dpif-netdev.c | 9
For VLANs, the match of ethernet type should be specified in inner_type
field of the vlan match, and not type field in ethernet match.
Fix it.
Fixes: e8a2b5bf92bb ("netdev-dpdk: implement flow offload with rte flow")
Signed-off-by: Eli Britstein
Reviewed-by: Salem Sol
---
lib/netd
DPDK 20.11 introduced an ability to specify existance/non-existance of
VLAN tag by [1].
Use this attribute.
[1]: 09315fc83861 ("ethdev: add VLAN attributes to ethernet and VLAN items")
Signed-off-by: Eli Britstein
Reviewed-by: Salem Sol
---
lib/netdev-offload-dpdk.c | 16 +
On 1/4/2022 4:56 PM, Eelco Chaudron wrote:
External email: Use caution opening links or attachments
On 5 Dec 2021, at 8:34, Eli Britstein via dev wrote:
Following [1]-[3] in DPDK, there are no more such warnings from DPDK.
Remove ignoring them if they occur.
GitHub actions:
v1: https
Add support for matching on geneve header.
Signed-off-by: Eli Britstein
Reviewed-by: Nir Anteby
---
NEWS | 2 ++
lib/netdev-offload-dpdk.c | 58 +++
2 files changed, 60 insertions(+)
diff --git a/NEWS b/NEWS
index bc4a1cfac..18f15b61f
Signed-off-by: Eli Britstein
Reviewed-by: Nir Anteby
---
lib/netdev-offload-dpdk.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c
index 402353125..50650bd07 100644
--- a/lib/netdev-offload-dpdk.c
+++ b/lib/netdev-offload
Add support for dpdk geneve tunnel offloads.
GitHub actions:
v1: https://github.com/elibritstein/OVS/actions/runs/1633157455
Eli Britstein (3):
netdev-dpdk: Add flow_api support for netdev geneve vports
netdev-offload-dpdk: Support tnl_pop for geneve tunnel
netdev-offload-dpdk: Add geneve
Add the acceptance of geneve devices to netdev_dpdk_flow_api_supported()
API, to allow offloading of DPDK geneve devices.
Signed-off-by: Eli Britstein
Reviewed-by: Nir Anteby
---
lib/netdev-dpdk.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/netdev-dpdk.c b/lib
On 12/17/2021 12:06 AM, Ilya Maximets wrote:
External email: Use caution opening links or attachments
New 'options:dummy-rte-flow' configuration knob for netdev-dpdk
ports, i.e. type=dpdk/dpdkvhostuserclient, to turn on dummy rte_flow
API. This version of API will do nothing but reply with
buf: avoid cast-align warning in data offset macro")
[3] 6de430b7079e ("eal/x86: avoid cast-align warning in memcpy functions")
Signed-off-by: Eli Britstein
---
.ci/linux-build.sh | 4
utilities/ovs-dev.py | 1 -
2 files changed, 5 deletions(-)
diff --git a/.ci/linux-build
Acked-by: Eli Britstein
On 12/3/2021 11:12 PM, Ilya Maximets wrote:
External email: Use caution opening links or attachments
Last RX queue, from which the packet got received, is already stored
in the PMD context. So, we can get the netdev from it without the
expensive hash map lookup
On 11/30/2021 2:06 PM, Ilya Maximets wrote:
External email: Use caution opening links or attachments
On 11/30/21 10:43, Eli Britstein wrote:
On 11/30/2021 12:31 AM, Ilya Maximets wrote:
External email: Use caution opening links or attachments
On 11/7/21 11:56, Eli Britstein via dev wrote
On 11/30/2021 12:31 AM, Ilya Maximets wrote:
External email: Use caution opening links or attachments
On 11/7/21 11:56, Eli Britstein via dev wrote:
Following dpdk commits [1]-[3], it is now possible to compile with
--enable-Werror. Change the default to on, with an option to disable
using
On 11/22/2021 3:19 PM, Sriharsha Basavapatna wrote:
Hi Eli,
On Sun, Nov 21, 2021 at 12:03 PM Eli Britstein via dev
wrote:
Hi Harsha,
It's a clever idea, though have some problems in the implementation. PSB.
Thanks, please see my response below.
On 11/20/2021 11:20 AM, Sriharsha
Hi Harsha,
It's a clever idea, though have some problems in the implementation. PSB.
On 11/20/2021 11:20 AM, Sriharsha Basavapatna wrote:
The hw_miss_packet_recover() API results in performance degradation, for
ports that are either not offload capable or do not support this specific
offload
oject/openvswitch/list/?series=268844
[5] https://patchwork.ozlabs.org/project/openvswitch/list/?series=261231
[6]
https://patches.dpdk.org/project/dpdk/patch/20211028101428.15007-1-david.march...@redhat.com/
Signed-off-by: Eli Britstein
Reviewed-by: Gaetan Rivet
---
.ci/linux-build.sh
On 8/27/2021 12:30 PM, Maxime Coquelin wrote:
External email: Use caution opening links or attachments
On 8/16/21 3:53 PM, Eli Britstein via dev wrote:
Signed-off-by: Eli Britstein
---
NEWS | 2 ++
lib/netdev-offload-dpdk.c | 5 -
2 files changed, 2 insertions
On 8/24/2021 6:47 PM, Ilya Maximets wrote:
External email: Use caution opening links or attachments
On 8/24/21 5:25 PM, Eli Britstein wrote:
On 8/24/2021 6:08 PM, Finn, Emma wrote:
External email: Use caution opening links or attachments
-Original Message-
From: Eli Britstein
On 8/24/2021 6:08 PM, Finn, Emma wrote:
External email: Use caution opening links or attachments
-Original Message-
From: Eli Britstein
Sent: Monday 16 August 2021 14:55
To: d...@openvswitch.org; Ilya Maximets
Cc: Finn, Emma ; Stokes, Ian ; Sriharsha Basavapatna
; Gaetan Rivet
case.
[1] 0d25621e4d9f ("dpif-netdev: Fix flow modification after failure.")
Fixes: b5e6f6f6bfbe ("dpif-netdev: Provide orig_in_port in metadata for
tunneled packets.")
Signed-off-by: Eli Britstein
---
lib/dpif-netdev-private-flow.h | 1 +
lib/dpif-netdev.c | 9
For VLANs, the match of ethernet type should be specified in inner_type
field of the vlan match, and not type field in ethernet match.
Fix it.
Fixes: e8a2b5bf92bb ("netdev-dpdk: implement flow offload with rte flow")
Signed-off-by: Eli Britstein
Reviewed-by: Salem Sol
---
lib/netd
DPDK 20.11 introduced an ability to specify existance/non-existance of
VLAN tag by [1].
Use this attribute.
[1]: 09315fc83861 ("ethdev: add VLAN attributes to ethernet and VLAN items")
Signed-off-by: Eli Britstein
Reviewed-by: Salem Sol
---
lib/netdev-offload-dpdk.c | 16 +
Support IPv6 fragmentation matching.
Signed-off-by: Eli Britstein
---
lib/netdev-offload-dpdk.c | 82 ++-
1 file changed, 81 insertions(+), 1 deletion(-)
diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c
index ee8e56fe0..d79ad1bea 100644
Signed-off-by: Eli Britstein
---
NEWS | 2 ++
lib/netdev-offload-dpdk.c | 5 -
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/NEWS b/NEWS
index 26920e215..80466c014 100644
--- a/NEWS
+++ b/NEWS
@@ -8,6 +8,8 @@ Post-v2.16.0
by default
Matching on frag types requires range. Add 'last' attribute to patterns.
Signed-off-by: Eli Britstein
---
lib/netdev-offload-dpdk.c | 151 --
1 file changed, 81 insertions(+), 70 deletions(-)
diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c
Support IPv4 fragmentation matching.
Signed-off-by: Eli Britstein
---
lib/netdev-offload-dpdk.c | 47 +--
1 file changed, 45 insertions(+), 2 deletions(-)
diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c
index 769dc48d2..ee8e56fe0 100644
://github.com/elibritstein/OVS/actions/runs/459082657
v2: https://github.com/elibritstein/OVS/actions/runs/1135430235
v2-v1:
- Rebase.
Eli Britstein (4):
netdev-offload-dpdk: Add last attribute to patterns
netdev-offload-dpdk: Support IPv4 fragmentation types
netdev-offload-dpdk: Support IPv6
On 8/2/2021 10:58 PM, Ilya Maximets wrote:
External email: Use caution opening links or attachments
On 7/26/21 10:14 AM, Eli Britstein wrote:
This patch-set improves/fixes offloads transitions behavior.
Patch #1 avoids flushing PMD offloads unnecessarily.
Patch #2 fixes a flow
k: Support offload of output action.")
Signed-off-by: Eli Britstein
Reviewed-by: Gaetan Rivet
---
lib/dpif-netdev.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 5fe06b996..6a7bed840 100644
--- a/lib/dpif-netdev.c
+++
Log flow modifications to help debugging.
Signed-off-by: Eli Britstein
Reviewed-by: Gaetan Rivet
---
lib/dpif-netdev.c | 114 +++---
1 file changed, 68 insertions(+), 46 deletions(-)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 6a7bed840
not be handled as a modification, but rather as an "add".
Fixes: 02bb2824e51d ("dpif-netdev: do hw flow offload in a thread")
Signed-off-by: Eli Britstein
---
lib/dpif-netdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/dpif-netdev.c b/lib
from being offloaded, and won't resume offloading.
As PMD offload flush is not necessary, avoid it.
[1] 62d1c28e9ce0 ("dpif-netdev: Flush offload rules upon port deletion.")
Signed-off-by: Eli Britstein
Reviewed-by: Gaetan Rivet
---
lib/dpif-netdev.c | 13 -
1 file c
commit
messages since:
https://github.com/elibritstein/OVS/actions/runs/70787
v2: https://github.com/elibritstein/OVS/actions/runs/1023045302
v3: https://github.com/elibritstein/OVS/actions/runs/1066584199
Eli Britstein (4):
dpif-netdev: Do not flush PMD offloads on reload
dpif
Reported-by: Harry Van Haaren
Fixes: 4e432d6f8128 ("netdev-offload-dpdk: Support tnl/push using vxlan encap
attribute.")
Fixes: e098c2f966cb ("netdev-dpdk-offload: Add vxlan pattern matching
function.")
Signed-off-by: Eli Britstein
---
lib/netdev-offload-dpdk.c | 19 ++
Fixes: b6207b1d2711 ("netdev-offload-dpdk: Support offload of set IPv6
actions.")
Signed-off-by: Eli Britstein
---
lib/netdev-offload-dpdk.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c
index e7913292e.
On 7/23/2021 9:00 PM, Ilya Maximets wrote:
External email: Use caution opening links or attachments
On 7/12/21 5:07 PM, Eli Britstein wrote:
Before flushing offloads of a removed port was supported by [1], it was
necessary to flush the 'marks'. In doing so, all offloads of the PMD
On 7/22/2021 4:10 PM, Ilya Maximets wrote:
External email: Use caution opening links or attachments
On 7/22/21 3:00 PM, Eli Britstein wrote:
On 7/22/2021 3:28 PM, Ilya Maximets wrote:
External email: Use caution opening links or attachments
On 7/11/21 7:15 AM, Eli Britstein wrote
On 7/22/2021 3:28 PM, Ilya Maximets wrote:
External email: Use caution opening links or attachments
On 7/11/21 7:15 AM, Eli Britstein wrote:
Compiling with -Werror and -Wcast-align has errors like:
lib/netdev-offload-dpdk.c: In function 'dump_flow_pattern':
lib/netdev-offload-dpdk.c:385:38
On 7/15/2021 4:35 PM, Ferriter, Cian wrote:
External email: Use caution opening links or attachments
-Original Message-
From: Eli Britstein
Sent: Wednesday 14 July 2021 16:21
To: Ferriter, Cian ; Ilya Maximets
; Gaëtan Rivet
; d...@openvswitch.org; Van Haaren, Harry
Cc: Majd
On 7/14/2021 5:58 PM, Ferriter, Cian wrote:
External email: Use caution opening links or attachments
-Original Message-
From: Ilya Maximets
Sent: Friday 9 July 2021 21:53
To: Ferriter, Cian ; Gaëtan Rivet ;
Eli Britstein
; d...@openvswitch.org; Van Haaren, Harry
Cc: Majd Dibbiny
Port numbers are usually small. Maintain an array of netdev handles indexed
by port numbers. It accelerates looking up for them for
netdev_hw_miss_packet_recover().
Reported-by: Cian Ferriter
Signed-off-by: Eli Britstein
Reviewed-by: Gaetan Rivet
---
lib/dpif-netdev-private-thread.h | 4
rte_flow_get_restore_info() API is under experimental attribute. Using it
has a performance impact that can be avoided for non-experimental compilation.
Do not call it without experimental support.
Reported-by: Cian Ferriter
Signed-off-by: Eli Britstein
Reviewed-by: Gaetan Rivet
---
lib/dpif
For VLANs, the match of ethernet type should be specified in inner_type
field of the vlan match, and not type field in ethernet match.
Fix it.
Fixes: e8a2b5bf92bb ("netdev-dpdk: implement flow offload with rte flow")
Signed-off-by: Eli Britstein
Reviewed-by: Salem Sol
---
lib/netd
DPDK 20.11 introduced an ability to specify existance/non-existance of
VLAN tag by [1].
Use this attribute.
[1]: 09315fc83861 ("ethdev: add VLAN attributes to ethernet and VLAN items")
Signed-off-by: Eli Britstein
Reviewed-by: Salem Sol
---
lib/netdev-offload-dpdk.c | 16 +
For VLANs, the match of ethernet type should be specified in inner_type
field of the vlan match, and not type field in ethernet match.
Fix it.
Fixes: e8a2b5bf92bb ("netdev-dpdk: implement flow offload with rte flow")
Signed-off-by: Eli Britstein
Reviewed-by: Salem Sol
---
lib/netd
DPDK 20.11 introduced an ability to specify existance/non-existance of
VLAN tag by [1].
Use this attribute.
[1]: 09315fc83861 ("ethdev: add VLAN attributes to ethernet and VLAN items")
Signed-off-by: Eli Britstein
Reviewed-by: Salem Sol
---
lib/netdev-offload-dpdk.c | 16 +
k: Support offload of output action.")
Signed-off-by: Eli Britstein
Reviewed-by: Gaetan Rivet
---
lib/dpif-netdev.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 21b0e025d..9b2b8d6d9 100644
--- a/lib/dpif-netdev.c
++
/70787
v2: https://github.com/elibritstein/OVS/actions/runs/1023045302
Eli Britstein (3):
dpif-netdev: Do not flush PMD offloads on reload
dpif-netdev: Fix offloads of modified flows
dpif-netdev: Log flow modification in debug level
lib/dpif-netdev.c | 130
Log flow modifications to help debugging.
Signed-off-by: Eli Britstein
Reviewed-by: Gaetan Rivet
---
lib/dpif-netdev.c | 101 +-
1 file changed, 55 insertions(+), 46 deletions(-)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 9b2b8d6d9
from being offloaded, and won't resume offloading.
As PMD offload flush is not necessary, avoid it.
[1] 62d1c28e9ce0 ("dpif-netdev: Flush offload rules upon port deletion.")
Signed-off-by: Eli Britstein
Reviewed-by: Gaetan Rivet
---
lib/dpif-netdev.c | 13 -
1 file c
1 - 100 of 791 matches
Mail list logo
