On Wed, Mar 13, 2024 at 12:00 AM Lorenzo Bianconi <
lorenzo.bianc...@redhat.com> wrote:
>
> Introduce ECMP_Nexthop table in the SB db in order to track active
> ecmp-symmetric-reply connections and flush stale ones.
>
> Signed-off-by: Lorenzo Bianconi
> ---
> northd/en-northd.c | 4 +++
>
ff:ff:ff:ff to the IPv6 NS responder flows, which is
obviously wrong. Please ignore my feedback for the current patch and we can
address IPv6 in a separate patch if it is required.
Thanks,
Han
> On Wed, May 22, 2024 at 12:16 AM Han Zhou wrote:
>>
>>
>>
>> On Tue, May 21, 2024 a
On Tue, May 21, 2024 at 9:56 PM Numan Siddique wrote:
>
> On Mon, May 20, 2024 at 1:47 AM Vasyl Saienko
wrote:
> >
> > Thanks for feedback Numan.
> >
> > On Wed, May 15, 2024 at 12:04 AM Numan Siddique wrote:
> >
> > > On Mon, May 13, 2024 at 9:00 AM Dumitru Ceara
wrote:
> > > >
> > > > On
On Mon, May 20, 2024 at 5:32 PM Indrajitt Valsaraj <
indrajitt.valsa...@nutanix.com> wrote:
>
> Issue:
> In case of a Logical_Router without mac_binding_age_threshold set or a
> Logical_Router with an incorrectly formatted mac_binding_threshold
> option, entries were not being purged from the Mac
On Thu, May 16, 2024 at 10:09 PM Indrajitt Valsaraj <
indrajitt.valsa...@nutanix.com> wrote:
>
> Issue:
> In case of a Logical_Router without mac_binding_age_threshold set or a
> Logical_Router with an incorrectly formatted mac_binding_threshold
> option, entries were not being purged from the Mac
On Thu, May 2, 2024 at 8:22 AM Lorenzo Bianconi
wrote:
>
> Introduce bfd and bfd_consumer nodes to northd I-P engine to track bfd
> connections and northd static_route/policy_route changes.
>
> Reported-at: https://issues.redhat.com/browse/FDP-600
> Signed-off-by: Lorenzo Bianconi
Hi Lorenzo,
On Fri, May 10, 2024 at 9:23 AM Numan Siddique wrote:
>
> On Fri, May 10, 2024 at 2:37 AM Han Zhou wrote:
> >
> > On Thu, May 9, 2024 at 10:32 AM Mark Michelson
wrote:
> > >
> > > On 5/7/24 02:12, Han Zhou wrote:
> > > >
> >
On Thu, May 9, 2024 at 10:32 AM Mark Michelson wrote:
>
> On 5/7/24 02:12, Han Zhou wrote:
> >
> >
> > On Mon, May 6, 2024 at 10:37 PM Ales Musil > <mailto:amu...@redhat.com>> wrote:
> > >
> > >
> > >
> > >
On Mon, May 6, 2024 at 10:37 PM Ales Musil wrote:
>
>
>
> On Mon, May 6, 2024 at 8:41 PM Han Zhou wrote:
>>
>>
>>
>> On Thu, May 2, 2024 at 10:35 PM Ales Musil wrote:
>> >
>> > On Thu, May 2, 2024 at 6:23 PM Han Zhou wrote:
>> > &
On Thu, May 2, 2024 at 10:35 PM Ales Musil wrote:
>
> On Thu, May 2, 2024 at 6:23 PM Han Zhou wrote:
> >
> >
> >
> > On Thu, May 2, 2024 at 6:29 AM Ales Musil wrote:
> > >
> > > Instead of tracking address set per struct expr_constant_set tr
On Thu, May 2, 2024 at 9:01 AM Numan Siddique wrote:
>
> On Mon, Apr 22, 2024 at 2:41 AM Han Zhou wrote:
> >
> > The current comments are obviously conflicting. Fixing it according the
> > current implementation - static route overrides src-ip route.
> >
> >
On Thu, May 2, 2024 at 6:29 AM Ales Musil wrote:
>
> Instead of tracking address set per struct expr_constant_set track it
> per individual struct expr_constant. This allows more fine grained
> control for I-P processing of address sets in controller. It helps with
> scenarios like matching on
On Tue, Apr 30, 2024 at 9:56 AM Ales Musil wrote:
>
> Instead of tracking address set per struct expr_constant_set track it
> per individual struct expr_constant. This allows more fine grained
> control for I-P processing of address sets in controller. It helps with
> scenarios like matching on
On Fri, Apr 12, 2024 at 8:20 AM Ales Musil wrote:
>
> Instead of tracking address set per struct expr_constant_set track it
> per individual struct expr_constant. This allows more fine grained
> control for I-P processing of address sets in controller. It helps with
> scenarios like matching on
On Tue, Apr 23, 2024 at 2:50 AM Martin Kalcok
wrote:
>
> Signed-off-by: Martin Kalcok
> ---
> ovn-sb.xml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ovn-sb.xml b/ovn-sb.xml
> index f9fb6c304..bf4689f12 100644
> --- a/ovn-sb.xml
> +++ b/ovn-sb.xml
> @@ -1456,7
The current comments are obviously conflicting. Fixing it according the
current implementation - static route overrides src-ip route.
Signed-off-by: Han Zhou
---
northd/northd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/northd/northd.c b/northd/northd.c
index
ould depend on the old behavior. Thinking it
more carefully, for OVN it seems not possible because the ovn-encap-ip used
as the local_ip is always the one shared to other chassis through SB DB. So
now I think we should be safe to change the default behavior.
Acked-by: Han Zhou
On Wed, Apr 10, 2024 at 6:52 AM Simon Horman wrote:
>
> Hi,
>
> I would like to announce that the primary development branch for OvS
> has been renamed main.
>
> The rename occurred a little earlier today.
>
> OVS is currently hosted on GitHub. We can expect the following behaviour
> after the
On Thu, Mar 21, 2024 at 10:05 AM Ilya Maximets wrote:
>
> On 3/14/24 06:23, Han Zhou wrote:
> >
> >
> > On Fri, Apr 22, 2022 at 1:41 AM Eelco Chaudron mailto:echau...@redhat.com>> wrote:
> >>
> >>
> >>
> >> On 15 Apr 2022, at 13:
On Thu, Apr 4, 2024 at 10:03 AM Mark Michelson wrote:
>
> Thanks for the fix, Han.
>
> Acked-by: Mark Michelson
Thanks Mark. Applied to main and backported.
Han
>
> On 4/4/24 02:47, Han Zhou wrote:
> > Fixes: bbf2f941965a ("ofctrl: Wait at S_WAIT_BEFORE_CLEA
Fixes: bbf2f941965a ("ofctrl: Wait at S_WAIT_BEFORE_CLEAR only once.")
Signed-off-by: Han Zhou
---
tests/ovn-controller.at | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/tests/ovn-controller.at b/tests/ovn-controller.at
index 3202f0beff46..f2c792c9c
On Tue, Apr 2, 2024 at 11:11 PM Han Zhou wrote:
>
>
>
> On Tue, Apr 2, 2024 at 10:48 PM Han Zhou wrote:
> >
> >
> >
> > On Thu, Mar 28, 2024 at 1:29 PM Mark Michelson
wrote:
> > >
> > > Thanks Han,
> > >
> > > Acked-by: M
On Tue, Apr 2, 2024 at 10:48 PM Han Zhou wrote:
>
>
>
> On Thu, Mar 28, 2024 at 1:29 PM Mark Michelson
wrote:
> >
> > Thanks Han,
> >
> > Acked-by: Mark Michelson
>
> Thanks Mark. Applied to main.
Also backported down to branch-23.06
Han
>
&
On Thu, Mar 28, 2024 at 1:29 PM Mark Michelson wrote:
>
> Thanks Han,
>
> Acked-by: Mark Michelson
Thanks Mark. Applied to main.
Han
>
> On 3/28/24 02:58, Han Zhou wrote:
> > The ovn-ofctrl-wait-before-clear setting is designed to minimize
> > downtime during t
On Wed, Mar 20, 2024 at 4:07 PM Han Zhou wrote:
>
>
>
> On Mon, Mar 18, 2024 at 11:27 AM Mark Michelson
wrote:
> >
> > Hi Han,
> >
> > I have a comment below
> >
> > On 3/5/24 01:27, Han Zhou wrote:
> > > The ovn-ofctrl-wait-before-cl
educe
down time during upgrade.")
Signed-off-by: Han Zhou
---
v2: Addressed Mark's comments - made test case more reliable.
controller/ofctrl.c | 1 -
tests/ovn-controller.at | 9 +++--
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/controller/ofctrl.c b/controlle
On Wed, Mar 27, 2024 at 12:46 AM Ales Musil wrote:
>
> On Wed, Mar 27, 2024 at 7:14 AM Han Zhou wrote:
>
> >
> >
> > On Tue, Mar 19, 2024 at 9:45 AM Ales Musil wrote:
> > >
> > >
> > >
> > > On Tue, Mar 19, 2024 at 5:43 PM Ales
On Tue, Mar 19, 2024 at 9:45 AM Ales Musil wrote:
>
>
>
> On Tue, Mar 19, 2024 at 5:43 PM Ales Musil wrote:
>>
>> Instead of tracking address set per struct expr_constant_set track it
>> per individual struct expr_constant. This allows more fine grained
>> control for I-P processing of address
other servers that are not behind the majority. */
> +threshold = raft->commit_index;
> +} else {
> +/* Try any other server. It is safe, because they either
have all
> + * the append requests queued up for them before the
leadership
> +
On Wed, Mar 20, 2024 at 12:48 PM Mark Michelson wrote:
>
> Thanks Ales, looks good to me.
>
> Acked-by: Mark Michelson
>
Thanks Ales and Mark. I applied to main and backported down to branch-23.06.
Han
> On 3/19/24 11:57, Ales Musil wrote:
> > The memory usage would be increased for size of
fter-starting-to-add \
> +| grep -q "engaged"])
> +done
> +
> +AT_CHECK([ovsdb-server -v -vconsole:off -vsyslog:off \
> + --detach --no-chdir --log-file=s$i.log \
> + --pidfile=s$i.pid --unixctl=s$i \
> + --remote=punix:s$i.ovsdb s$i.db])
> +done
> +
> +dnl Make sure that all servers joined the cluster.
> +for i in $(seq $n); do
> +AT_CHECK([ovsdb_client_wait unix:s$i.ovsdb $schema_name connected])
> +done
> +
> +for i in $(seq $n); do
> +OVS_APP_EXIT_AND_WAIT_BY_TARGET([$(pwd)/s$i], [s$i.pid])
> +done
> +
> AT_CLEANUP
>
>
> --
> 2.43.0
>
Thanks Ilya. Looks good to me.
Acked-by: Han Zhou
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
o deal
with disruptive server.")
> Signed-off-by: Ilya Maximets
Thanks for the fix.
Acked-by: Han Zhou
> ---
> ovsdb/raft.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ovsdb/raft.c b/ovsdb/raft.c
> index 237d7ebf5..c41419052 100644
> --
->data'. */
> raft_run_reconfigure(raft);
> +} else if (e->servers &&
!raft_has_uncommitted_configuration(raft)) {
> +struct ovsdb_error *error;
> +struct raft_server *s;
> +struct hmap servers;
> +
> +
raft_reset_ping_timer(raft);
> }
>
> +uint64_t interval = raft->joining
> +? 1000 :
RAFT_TIMER_THRESHOLD(raft->election_timer);
nit: the hardcoded joining timer value 1000 is used at least 3 places, so
probably better to define a macro for it.
Ac
On Tue, Mar 19, 2024 at 12:05 AM Felix Huettner via dev <
ovs-dev@openvswitch.org> wrote:
>
> On Mon, Mar 18, 2024 at 05:52:12PM +0100, Ilya Maximets wrote:
> > On 3/18/24 17:15, Felix Huettner wrote:
> > > On Fri, Mar 15, 2024 at 09:14:49PM +0100, Ilya Maximets wrote:
> > >> Each cluster member
On Mon, Mar 18, 2024 at 11:27 AM Mark Michelson wrote:
>
> Hi Han,
>
> I have a comment below
>
> On 3/5/24 01:27, Han Zhou wrote:
> > The ovn-ofctrl-wait-before-clear setting is designed to minimize
> > downtime during the initial start-up of the ovn-controller.
On Wed, Mar 20, 2024 at 2:56 AM Dumitru Ceara wrote:
>
> On 3/20/24 06:41, Han Zhou wrote:
> > ovn-controller runs at 100% cpu when OVS exits. This is because the
> > ofctrl_run is not called while ofctrl_wait is always called in the main
> > loop. Because of the missin
a chance to run ofctrl_run
as long as ofctrl_wait is called.
Fixes: 1d6d953bf883 ("controller: Don't artificially limit group and meter IDs
to 16bit.")
Fixes: 94cbc59dc0f1 ("ovn-controller: Fix use of dangling pointers in I-P
runtime_data.")
Signed-off-by: Han Zhou
---
On Fri, Apr 22, 2022 at 1:41 AM Eelco Chaudron wrote:
>
>
>
> On 15 Apr 2022, at 13:25, wenx05124...@163.com wrote:
>
> > From: wenxu
> >
> > The netdev-offload in tc mode can't work with flow-restore-wait.
> > When the vswitchd restart with flow-restore-wait, the tc qdisc
> > will be delete in
ayer directly.
> + * When a port deleted, the corresponding netdev is also removed
from
> + * netdev_shash. netdev_get_type_from_name returns NULL in such
case.
> + * We should try to get type from ofport->netdev. */
nit: this comment is better to be moved to the above
On Fri, Mar 8, 2024 at 12:17 AM Tao Liu wrote:
>
>
> On 3/7/24 5:39 AM, Ilya Maximets wrote:
> > On 2/27/24 20:14, Han Zhou wrote:
> >> For kernel datapath, when a new tunnel port is created in the same
> >> transaction in which an old tunnel port with t
educe
down time during upgrade.")
Signed-off-by: Han Zhou
---
controller/ofctrl.c | 1 -
tests/ovn-controller.at | 9 +++--
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/controller/ofctrl.c b/controller/ofctrl.c
index f14cd79a8dbb..0d72ecbaa167 100644
--- a/controlle
On Fri, Mar 1, 2024 at 2:26 AM Dumitru Ceara wrote:
>
> On 2/16/24 07:52, Han Zhou wrote:
> > In commit 41eefcb2807d, the format of external_ids:ovn-chassis-id for
> > tunnels was modified to include the local encapsulation IP. This change
> > can lead to the recr
pproach to
just re-run the bridge_reconfigure() when there are any port creations
encountered "File exists" error, which indicates a possible resource
conflict may have happened due to a later deleted port, and retry may
succeed.
Signed-off-by: Han Zhou
---
This is RFC because I am not sure i
aintainers. But it is severe enough, IMO.
>
Thanks Ilya. The fix looks good to me. And I think it is ok to backport,
since the change is simple enough.
Acked-by: Han Zhou
Just curious, how would the OVS perform with this large number of meters?
Thanks,
Han
> controller/ofctrl.c | 37
On Fri, Feb 16, 2024 at 2:50 PM Numan Siddique wrote:
>
> On Mon, Feb 12, 2024 at 2:49 PM Han Zhou wrote:
> >
> > The MFF_LOG_ENCAP_ID register was defined to save the encap ID and avoid
> > changing across pipelines, but in the function
> > load_logical
reate separate tunnels for multiple local encap
IPs.")
Signed-off-by: Han Zhou
---
controller/encaps.c | 83 -
tests/ovn-controller.at | 44 ++
2 files changed, 110 insertions(+), 17 deletions(-)
diff --git a/controller/
oup_add_with_reference(lflow, od, dp_bitmap, bitmap_len);
> -
> if (parallelization_state != STATE_USE_PARALLELIZATION) {
> hmap_insert(_table->entries, >hmap_node, hash);
> } else {
> @@ -1350,8 +1349,10 @@ dp_refcnt_use(struct hmap *dp_refcnts_map, size_t
dp
->linked = true;
> }
>
> --
> 2.43.0
>
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Thanks Numan for the fix.
Acked-by: Han Zhou
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
witch_rport_arp_req_flow(
> nat->external_ip, AF_INET, sw_op, sw_od, 80, lflows,
> diff --git a/northd/northd.h b/northd/northd.h
> index b5c175929e..3f1cd83413 100644
> --- a/northd/northd.h
> +++ b/northd/northd.h
> @@ -293,6 +293,7 @@ struct ovn_datapath
/listinfo/ovs-dev
Thanks Numan. The patch LGTM except that the function
build_lr_nat_defrag_and_lb_default_flows() doesn't seem to be the right
place to add the flow. I'd either add a new function, or just call the
ovn_lflow_add_default_drop directly in
build_lswitch_and_lrouter_iterate_by_lr for this flow.
With this addressed:
Acked-by: Han Zhou
Regards,
Han
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
it by ensuring the register is loaded only
in the flows of table 0, which is where packets from VIFs enter the
pipeline for the first time.
Fixes: 17b6a12fa286 ("ovn-controller: Support VIF-based local encap IPs
selection.")
Signed-off-by: Han Zhou
---
controller/physical.c | 28 ---
te
On Mon, Feb 5, 2024 at 7:47 PM Numan Siddique wrote:
>
> On Mon, Feb 5, 2024 at 9:41 PM Han Zhou wrote:
> >
> > On Mon, Feb 5, 2024 at 4:12 PM Numan Siddique wrote:
> > >
> > > On Mon, Feb 5, 2024 at 5:54 PM Han Zhou wrote:
> > > >
>
On Mon, Feb 5, 2024 at 4:12 PM Numan Siddique wrote:
>
> On Mon, Feb 5, 2024 at 5:54 PM Han Zhou wrote:
> >
> > On Mon, Feb 5, 2024 at 10:15 AM Ilya Maximets
wrote:
> > >
> > > On 2/5/24 15:45, Ilya Maximets wrote:
> > > > On 2/5/24 11:34, Ilya M
On Mon, Feb 5, 2024 at 10:15 AM Ilya Maximets wrote:
>
> On 2/5/24 15:45, Ilya Maximets wrote:
> > On 2/5/24 11:34, Ilya Maximets wrote:
> >> On 2/5/24 09:23, Dumitru Ceara wrote:
> >>> On 2/5/24 08:13, Han Zhou wrote:
> >>>> On S
On Sun, Feb 4, 2024 at 9:26 PM Numan Siddique wrote:
>
> On Sun, Feb 4, 2024 at 9:53 PM Han Zhou wrote:
> >
> > On Sun, Feb 4, 2024 at 5:46 AM Ilya Maximets wrote:
> > >
> > > >>>
> > > >>> > 35 files changed, 9681 inser
ch-24.03 was created. I'm more than happy to
submit
> > follow up patches if you have any comments to address. Please let me
know.
> >>
> >
> > Hi Numan,
> >
> > I was writing the reply and saw your email just now. Thanks a lot for
> > taking a huge effort t
On Thu, Feb 1, 2024 at 5:30 PM Han Zhou wrote:
>
>
>
> On Mon, Jan 29, 2024 at 1:36 AM Dumitru Ceara wrote:
> >
> > On 1/29/24 07:20, Ales Musil wrote:
> > > Considering following topology:
> > > client - sw0 - lrp0 - lr - lrp1 - sw1 - server
&g
On Mon, Jan 29, 2024 at 1:36 AM Dumitru Ceara wrote:
>
> On 1/29/24 07:20, Ales Musil wrote:
> > Considering following topology:
> > client - sw0 - lrp0 - lr - lrp1 - sw1 - server
> > sw0 in subnet 192.168.0.0/24
> > sw1 in subnet 172.168.0.0/24
> > SNAT configured for client
> > gateway_mtu=1400
On Tue, Jan 30, 2024 at 3:35 AM Dumitru Ceara wrote:
>
> On 1/30/24 08:59, Ales Musil wrote:
> > On Tue, Jan 30, 2024 at 8:58 AM Ales Musil wrote:
> >
> >> The Fedora version of grep (grep (GNU grep) 3.11) complains
> >> about the syntax grep "output\:": grep: warning: stray \ before :
> >>
> >>
On Mon, Jan 29, 2024 at 2:41 AM Ales Musil wrote:
>
>
>
> On Fri, Jan 26, 2024 at 8:05 PM Han Zhou wrote:
>>
>>
>>
>> On Thu, Jan 25, 2024 at 10:54 PM Ales Musil wrote:
>> >
>> >
>> >
>> > On Fri, Jan 26, 2024 at 4:07 AM
On Mon, Jan 29, 2024 at 7:11 PM Numan Siddique wrote:
> On Thu, Jan 25, 2024 at 1:08 AM Han Zhou wrote:
> >
> > On Thu, Jan 11, 2024 at 7:32 AM wrote:
> > >
> > > From: Numan Siddique
> > >
> > > ovn_lflow_add() and other related function
On Thu, Jan 25, 2024 at 10:54 PM Ales Musil wrote:
>
>
>
> On Fri, Jan 26, 2024 at 4:07 AM Han Zhou wrote:
>>
>>
>>
>> On Tue, Jan 23, 2024 at 5:29 AM Ales Musil wrote:
>> >
>> >
>> >
>> > On Wed, Jan 17, 2024 at 6:48
On Thu, Jan 25, 2024 at 8:22 AM Numan Siddique wrote:
>
> On Tue, Jan 23, 2024 at 2:40 AM Han Zhou wrote:
> >
> > On Mon, Jan 22, 2024 at 7:11 PM Numan Siddique wrote:
> > >
> > > On Mon, Jan 22, 2024 at 4:03 PM Han Zhou wrote:
> > > >
> &
On Fri, Jan 26, 2024 at 10:26 AM Han Zhou wrote:
>
>
>
> On Fri, Jan 26, 2024 at 7:53 AM Aaron Conole wrote:
> >
> > Han Zhou writes:
> >
> > > On Thu, Jan 25, 2024 at 12:55 PM Aaron Conole
wrote:
> > >>
> > >> From: Kevi
On Fri, Jan 26, 2024 at 7:53 AM Aaron Conole wrote:
>
> Han Zhou writes:
>
> > On Thu, Jan 25, 2024 at 12:55 PM Aaron Conole
wrote:
> >>
> >> From: Kevin Sprague
> >>
> >> During normal operations, it is useful to understand when a particul
On Thu, Jan 25, 2024 at 12:55 PM Aaron Conole wrote:
>
> From: Kevin Sprague
>
> During normal operations, it is useful to understand when a particular
flow
> gets removed from the system. This can be useful when debugging
performance
> issues tied to ofproto flow changes, trying to determine
On Tue, Jan 23, 2024 at 5:29 AM Ales Musil wrote:
>
>
>
> On Wed, Jan 17, 2024 at 6:48 AM Han Zhou wrote:
>>
>> Commit dd527a283cd8 partially supported multiple encap IPs. It supported
>> remote encap IP selection based on the destination VIF's encap_ip
>
On Mon, Jan 22, 2024 at 6:36 AM Ales Musil wrote:
>
> On Mon, Jan 22, 2024 at 9:09 AM Felix Huettner via dev <
> ovs-dev@openvswitch.org> wrote:
>
> > On Fri, Jan 19, 2024 at 04:33:28PM -0500, Mark Michelson wrote:
> > > With this change, a chassis may only update MAC Binding records that
it
> >
scenario for both lflows (p8) and SB load balancers (p15) .
Thanks Numan. I went through this version of the series. I tried my best to
review in details but I can't say I examined every lines of the changes.
The major comments are about the implicit dependency related to p4, p5, p6,
p7, and so
lflow->dp_refcnts_map,
> - lrn->dp_index)) {
> - bitmap_set0(lrn->lflow->dpg_bitmap, lrn->dp_index);
> +if (lrn->dpgrp_lflow) {
> +size_t index;
> +BITMAP_FOR_EACH_1 (index, lrn-&g
On Wed, Jan 24, 2024 at 10:07 PM Han Zhou wrote:
>
>
>
> On Thu, Jan 11, 2024 at 7:32 AM wrote:
> >
> > From: Numan Siddique
> >
> > ovn_lflow_add() and other related functions/macros are now moved
> > into a separate module - lflow-mgr.c. This module
On Thu, Jan 11, 2024 at 7:32 AM wrote:
>
> From: Numan Siddique
>
> ovn_lflow_add() and other related functions/macros are now moved
> into a separate module - lflow-mgr.c. This module maintains a
> table 'struct lflow_table' for the logical flows. lflow table
> maintains a hmap to store the
On Wed, Jan 24, 2024 at 8:39 PM Numan Siddique wrote:
>
> On Wed, Jan 24, 2024 at 10:53 PM Han Zhou wrote:
> >
> > On Wed, Jan 24, 2024 at 4:23 AM Dumitru Ceara wrote:
> > >
> > > On 1/24/24 06:01, Han Zhou wrote:
> > > > On F
On Wed, Jan 24, 2024 at 4:23 AM Dumitru Ceara wrote:
>
> On 1/24/24 06:01, Han Zhou wrote:
> > On Fri, Jan 19, 2024 at 2:50 AM Dumitru Ceara wrote:
> >>
> >> On 1/11/24 16:31, num...@ovn.org wrote:
> >>> +
> >>> +void
> &
On Fri, Jan 19, 2024 at 2:50 AM Dumitru Ceara wrote:
>
> On 1/11/24 16:31, num...@ovn.org wrote:
> > +
> > +void
> > +lflow_table_add_lflow(struct lflow_table *lflow_table,
> > + const struct ovn_datapath *od,
> > + const unsigned long *dp_bitmap, size_t
tats lflow recompute nocompute
> +check_engine_stats sync_to_sb_pb recompute nocompute
> CHECK_NO_CHANGE_AFTER_RECOMPUTE
>
> # Create a dnat_and_snat NAT with external_mac and logical_port
> check as northd ovn-appctl -t ovn-northd inc-engine/clear-stats
>
nat-del lr0 dnat_and_snat 172.168.0.150
> +check_engine_stats northd recompute nocompute
> +check_engine_stats lflow recompute nocompute
> +CHECK_NO_CHANGE_AFTER_RECOMPUTE
> +
> +check as northd ovn-appctl -t ovn-northd inc-engine/clear-stats
> +check ovn-nbct
n,
> +op->od->sb, MC_FLOOD, OVN_MCAST_FLOOD_TUNNEL_KEY);
> +}
> +sbrec_multicast_group_update_ports_addvalue(sbmc_flood, op->sb);
> +
> +if (!sbmc_flood_l2) {
> +sbmc_flood_l2 = create_sb_multicast_group(ovnsb_txn,
> +
On Thu, Jan 11, 2024 at 7:29 AM wrote:
>
> From: Numan Siddique
>
> This new engine now maintains the NAT related data for each
> logical router which was earlier maintained by the northd
> engine node in the 'struct ovn_datapath'. The input to
> this engine node is 'northd'.
>
> A record for
On Tue, Jan 16, 2024 at 5:45 AM Mark Michelson wrote:
>
> Hi everyone,
>
> The soft freeze for OVN 24.03 is this Friday, 19 January, 2024. Please
> ensure that any patches that introduce new features are posted to the
> mailing list by that date if you wish to have them included in OVN 24.03.
>
>
On Tue, Jan 16, 2024 at 9:48 PM Han Zhou wrote:
>
> In commit dd527a283cd8, it created separate tunnels for different remote
> encap IPs of the same remote chassis, but when the current chassis is
> the one that has multiple encap IPs configured, it only uses the first
> encap
-off-by: Lei Huang
Signed-off-by: Han Zhou
---
NEWS| 3 +
controller/chassis.c| 2 +-
controller/local_data.c | 2 +-
controller/local_data.h | 2 +-
controller/ovn-controller.8.xml | 30 ++-
controller/ovn-controller.c | 49
encap IPs in current chassis and sets corresponding
local_ip for each tunnel interface in such cases.
Co-authored-by: Lei Huang
Signed-off-by: Lei Huang
Signed-off-by: Han Zhou
---
controller/bfd.c| 4 +-
controller/encaps.c | 158
Rename vars and structs to reflect the fact that there can be multiple
tunnels for each individual chassis. Also update the documentation of
external_ids:ovn-encap-ip.
Signed-off-by: Han Zhou
---
controller/encaps.c | 77 -
controller/ovn-controller.8
Han Zhou (3):
encaps: Refactor the naming related to tunnels.
encaps: Create separate tunnels for multiple local encap IPs.
ovn-controller: Support VIF-based local encap IPs selection.
NEWS| 3 +
controller/bfd.c| 4 +-
controller/chassis.c
mac; j++) {
> -if (extract_lsp_addresses(pb->mac[j], _addrs)) {
> - break;
> -}
> +if (!extract_lsp_addresses(pb->mac[0], _addrs)) {
> +continue;
> }
>
> pfd = shash_find_data(_prefixd, pb->logical_
On Tue, Jan 9, 2024 at 10:32 AM Mark Michelson wrote:
>
> A static analyzer determined that if pb->n_mac was 0, then the c_addrs
> lport_addresses struct would never be initialized. We would then use
> and attempt to free uninitialized memory.
>
> In reality, pb->n_mac will always be 1. This is
On Mon, Jan 8, 2024 at 3:52 PM Numan Siddique wrote:
>
> On Fri, Jan 5, 2024 at 11:36 AM Numan Siddique wrote:
> >
> > On Tue, Dec 19, 2023 at 2:37 AM Han Zhou wrote:
> > >
> > > On Mon, Nov 27, 2023 at 6:39 PM wrote:
> > > >
> > > >
IDRs shows itself.
>
Thanks Mark. I applied it to main.
Regards,
Han
> On 11/7/23 23:36, Han Zhou wrote:
> > Enhance MAC_Binding aging to allow CIDR-based threshold configurations.
> > This enables distinct threshold settings for different IP ranges,
> > applying the longest
On Mon, Nov 27, 2023 at 6:39 PM wrote:
>
> From: Numan Siddique
>
> Any changes to northd engine node due to load balancers
> are now handled in 'sync_to_sb_lb' node to sync the changed
> load balancers to SB load balancers.
>
> The logic to sync the SB load balancers is changed a bit and it
>
On Mon, Dec 18, 2023 at 12:22 PM Numan Siddique wrote:
>
> On Wed, Dec 13, 2023 at 9:57 AM Dumitru Ceara wrote:
> >
> > On 11/28/23 03:38, num...@ovn.org wrote:
> > > From: Numan Siddique
> > >
> > > Signed-off-by: Numan Siddique
> > > ---
> > > northd/inc-proc-northd.c | 9 -
> > > 1
On Wed, Dec 13, 2023 at 6:47 AM Dumitru Ceara wrote:
>
> On 11/28/23 03:37, num...@ovn.org wrote:
> > From: Numan Siddique
> >
> > A new engine node "global_config" is added which handles the changes
> > to NB_Global an SB_Global tables. It also creates these rows if
> > not present.
> >
> >
On Mon, Nov 27, 2023 at 6:38 PM wrote:
>
> From: Numan Siddique
>
> Signed-off-by: Numan Siddique
> ---
> northd/en-lflow.c| 29 +++
> northd/en-lflow.h| 1 +
> northd/en-lr-stateful.c | 39 -
> northd/en-lr-stateful.h | 26 +++
> northd/inc-proc-northd.c | 3 +-
>
On Mon, Nov 27, 2023 at 6:38 PM wrote:
>
> From: Numan Siddique
>
> Since northd tracked data has the changed lb data, northd
> engine handler for lflow engine now handles the lb changes
> incrementally. All the lflows generated for each lb is
> stored in the ovn_lb_datapaths->lflow_ref and
On Tue, Nov 14, 2023 at 10:42 PM Han Zhou wrote:
>
>
>
> On Thu, Oct 26, 2023 at 11:16 AM wrote:
> >
> > From: Numan Siddique
> >
> > Previous commits added new engine nodes to store logical router's lb
> > and NAT data. Make use of the data stored by
On Wed, Nov 15, 2023 at 7:32 PM Numan Siddique wrote:
>
> On Wed, Nov 15, 2023 at 2:59 AM Han Zhou wrote:
> >
> > On Thu, Oct 26, 2023 at 11:12 AM wrote:
> > >
> > > From: Numan Siddique
> > >
> > > This patch series adds incremental proce
On Thu, Oct 26, 2023 at 11:12 AM wrote:
>
> From: Numan Siddique
>
> This patch series adds incremental processing in the lflow engine
> node to handle changes to northd and other engine nodes.
> Changed related to load balancers and NAT are mainly handled in
> this patch series.
>
> This patch
On Thu, Oct 26, 2023 at 11:17 AM wrote:
>
> From: Numan Siddique
>
> This new engine now maintains the load balancer and ACL data of a
> logical switch which was earlier part of northd engine node data.
> The main inputs to this engine are:
> - northd node
> - NB logical switch node
>
On Thu, Oct 26, 2023 at 11:16 AM wrote:
>
> From: Numan Siddique
>
> This is not required.
>
Thanks Numan for the fix. Could you provide a little more detail why this
is not required:
- Is it a bug fix? What's the impact?
- Shall we update the ovn-northd documentation for the related lflow
1 - 100 of 2591 matches
Mail list logo
