On 5/29/24 11:01, Eelco Chaudron wrote:
>
>
> On 28 May 2024, at 16:49, Ilya Maximets wrote:
>
>> On 5/28/24 14:36, Eelco Chaudron wrote:
>>>
>>>
>>> On 24 May 2024, at 11:20, Emma Finn wrote:
>>>
>>>> The AVX implementation f
migrate from the legacy ethtool_cmd API at some point,
but this change makes sense for now.
Applied to main and backported down to 3.3. Thanks!
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
roed out even on errors. That is defined in netdev-provider API. But
the new static netdev_linux_get_speed_locked() function didn't do the same.
I fixed that and applied the set. Individual patches backported according to
their Fixes tags. Thanks!
Best regards, Ilya Maximets.
__
contains 'offload'
and it's not necessarily hardware here. Also, flags are better printed in hex,
i.e. %#"PRIx64. And there is a missing space between the cast and a variable.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
gt; ---
> lib/sflow_api.h | 6 +++---
> lib/sflow_receiver.c | 7 ---
> ofproto/ofproto-dpif-sflow.c | 2 +-
> 3 files changed, 8 insertions(+), 7 deletions(-)
Acked-by: Ilya Maximets
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 5/28/24 19:35, Ilya Maximets wrote:
> On 5/21/24 10:38, Martin Kalcok wrote:
>> Help text for 'ovsdb-client dump' does not mention that it's capable
>> of dumping a specific column's contents if the user supplies the
>> column's name as a fourth positional argument.
>&g
\n"
> + "on SERVER to stdout\n"
I think it was '[TABLE [COLUMN]...]' until commit 85226894ddec
("ovsdb-client: support monitor2") removed that part on accident.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
issues, as
Simon pointed out previously. The change you're proposing may have
some performance impact as we'll be holding the shared mutex for
longer while allocating IDs, so I'd like to understand why it is a
problem before making the change.
Best regards, Ilya Maximets.
___
ailable_prio(ovs_be16 protocol)
> return TC_RESERVED_PRIORITY_IPV4;
> } else if (protocol == htons(ETH_P_IPV6)) {
> return TC_RESERVED_PRIORITY_IPV6;
> +} else if (protocol == htons(ETH_P_8021Q)) {
o the flow
should not be freed until the processing is over.
The flow will be dead in this case with a zero counter, but it
is not freed, i.e. should be accessible.
Do you know what exactly failed in odp_execute_actions ?
Your version of the code seems to be very differe
ade some noticeable changes to the original patch,
or if they want to clarify something that wasn't fully explained
by the original commit message. I add those sometimes as well.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
tion/intro/install/dpdk.rst | 8
> NEWS | 2 ++
> 4 files changed, 13 insertions(+), 11 deletions(-)
Acked-by: Ilya Maximets
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
tion/intro/install/dpdk.rst | 8
> NEWS | 2 ++
> 4 files changed, 13 insertions(+), 11 deletions(-)
Acked-by: Ilya Maximets
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
/intro/install/dpdk.rst | 8
> NEWS | 2 ++
> 4 files changed, 11 insertions(+), 9 deletions(-)
Acked-by: Ilya Maximets
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
/intro/install/dpdk.rst | 8
> NEWS | 2 ++
> 4 files changed, 10 insertions(+), 8 deletions(-)
Acked-by: Ilya Maximets
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
/intro/install/dpdk.rst | 8
> NEWS | 2 ++
> 4 files changed, 9 insertions(+), 7 deletions(-)
Acked-by: Ilya Maximets
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
/intro/install/dpdk.rst | 8
> NEWS | 2 ++
> 4 files changed, 8 insertions(+), 6 deletions(-)
Didn't test, but LGTM.
Acked-by: Ilya Maximets
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
ose?
For now, I'll mark this patch with 'Changes Requested'.
If you plan to send a new version based on Mike's comments, please, add
'v6' to the subject prefix, i.e. [PATCH v6], since it's technically a
6th version of it.
Best regards, Ilya Maximets.
_
On 5/28/24 14:36, Eelco Chaudron wrote:
>
>
> On 24 May 2024, at 11:20, Emma Finn wrote:
>
>> The AVX implementation for calcualting checksums was not
>> handling carry-over addition correctly in some cases.
>> This patch adds an additional shuffle to add 16-bit padding to
>> the final part of
will still need a decent amount of
glue to pair with the library as well as maintain OVS-specific counters, I
think,
it's better to keep things as-is for now and try to periodically sync with the
original code from host-sflow. Sub-projects/modules/trees are generally not
easy
to work
/NEWS
> +++ b/NEWS
> @@ -8,4 +8,6 @@ Post-v3.3.0
> The OVS tree remains hosted on GitHub.
> https://github.com/openvswitch/ovs.git
> + - DPDK:
> + * Add support for DPDK 23.11.1.
>
>
Same here. 'validated with'?
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
a/NEWS
> +++ b/NEWS
> @@ -1,4 +1,7 @@
> v3.3.1 - xx xxx
>
> + - DPDK:
> + * Add support for DPDK 23.11.1.
> +
We're normally using 'validated with'.
And the extra line is not needed here.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
al issue is added. Some extra
testing infrastructure added to be able to handle and print out the
'indexed' table from the idltest schema.
Fixes: 13973bc41524 ("Add multi-column index support for the Python IDL")
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-discuss/2024-May/
not happen. But, in case it does,
I think we need to print a warning and return with error instead
of ignoring the TSO request.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> ctl_context_init_command(ctx, command, false);
> }
I don't see this string to be destroyed anywhere, should this be
added to the context_done() ? I see it's being swapped around with
command output, but it's hard to track.
Best regards, Ilya Maximets.
_
e may probably just replace sFlowRcvrTimeout with a uint32_t value and
compare agains UIN32_MAX. It doesn't have to be time_t. It's just a tick
counter that should not be too high. And we're not even using it anyway.
Best regards, Ilya Maximets.
> +
> /* The ovs_be types indicate that a
p with naming as well.
Also, please, either send all patches as separate or add a cover letter to
the set.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
netdev_features_to_bps(netdev->supported, 0) /
> 100ULL);
> +} else {
> +*current = 0;
> +*max = 0;
Please, squash these into one line as netdev_get_speed() does. Same for the
other
instance.
> }
> return netdev->get_features_err
x_read_stringset_info(netdev, );
> -if (error || !len) {
> +if (!len) {
> +return -EOPNOTSUPP;
> +} else if (error) {
> return error;
> }
Hmm. In case there is an error, we should return it. The length
check should be secondary.
Best regards, Ilya Maximet
; Signed-off-by: Mike Pattrick
> Fixes: 03fc1ad78521 ("userspace: Add SRv6 tunnel support.")
Nit: The 'Fixes' tag should go before the SoB.
Also, please, either send patches separately, or add a cover letter
to the set.
Best regards, Ilya Maximets.
> ---
> lib/netdev-nat
dev),
Hi, Roi. Thanks for the patch!
I think it is trying to fix the same issue as:
https://patchwork.ozlabs.org/project/openvswitch/patch/20240523191152.589605-6-...@redhat.com/
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
p_flags=ack
eth_src=8a:bf:7e:2f:05:84,eth_dst=0a:8f:39:4f:e0:73,dl_type=0x86dd,
ipv6_src=16bf:5603:6d40:1620:2a8e:6a83:4348:6136,
ipv6_dst=5003:74fd:47cd:6b65:353c:7fc1:5ac5:7d08,
ipv6_label=0x7661,nw_proto=6,nw_ttl=214,nw_frag=no,
tp_src=21024,tp_dst=23624,tcp_flags=ack
Feeding them into 'ovs-ofctl compose-packet --bare' produces valid packets
that trigger the issue.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 5/20/24 03:54, Nobuhiro MIKI wrote:
> On 2024/05/18 3:33, Ilya Maximets wrote:
>> Segments list in SRv6 header is 16-bit aligned as most of other fields
>> in packet headers. A little counter-intuitively, compilers are allowed
>> to make alignment assumptions based on th
On 5/21/24 08:32, Eelco Chaudron wrote:
>
>
> On 17 May 2024, at 20:47, Ilya Maximets wrote:
>
>> 'pkg_resources' module is deprecated and no longer available in newer
>> versions of python, so pytest tests are skipped:
>>
>> DeprecationWarning: pkg_resourc
the recently released v23.11.1.
But I think we'll need to make stable releases even if we will not be
able to incorporate changes above in time.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Adding the list back to CC.
On 5/22/24 13:28, amore...@redhat.com wrote:
> On Wed, May 22, 2024 at 12:11:37AM GMT, Ilya Maximets wrote:
>> On 5/16/24 19:03, Adrian Moreno wrote:
>>>
>>>
>>> On 4/24/24 9:53 PM, Adrian Moreno wrote:
>>>> This is
Please, keep the list in CC. :)
On 5/22/24 12:52, amore...@redhat.com wrote:
> On Wed, May 22, 2024 at 12:17:37AM GMT, Ilya Maximets wrote:
>> On 5/21/24 23:56, Ilya Maximets wrote:
>>> On 5/21/24 20:56, amore...@redhat.com wrote:
>>>> On Tue, May 21, 2024 at 08:03
bling IXGBE_HLREG0_TXPADEN for ixgbe cards for example. So, even if
the padding is not performed in software it doesn't mean it's not performed.
Doing this in software will be a waste of CPU resources in most cases.
Best regards, Ilya Maximets.
>
> Regards,
> Rohit Kumar
> --
On 5/21/24 23:56, Ilya Maximets wrote:
> On 5/21/24 20:56, amore...@redhat.com wrote:
>> On Tue, May 21, 2024 at 08:03:49PM GMT, Ilya Maximets wrote:
>>> On 5/21/24 18:13, amore...@redhat.com wrote:
>>>> On Tue, May 21, 2024 at 03:49:03PM GMT, amore...@redhat.com wro
(even without "trunc").
>
> - It requires a very big amount of work in ovs-vswitchd:
>- We'd need to decide who creates the port, if it's the user via Openflow
> and
> it's exposed as a port in a bridge or if it's a hidden vport created by the
> dpif
> layer.
>- Controls need to be established to limit OFP actions to send traffic to
> this port or it receiving traffic.
>- DPDK datapath would probably require a new netdev_class as well.
>
> - tc offload is more complicated. If we want to use act_sample (I cannot
> think
> of a way that doesn't involve act_sample), we'd need to track "sample"
> actions
> and "set_observability_metadata) to be able to build an act_sample for this.
>
> Ilya, Aaron, Eelco, did I miss something?
>
> Thoughts? Preferences?
I think, option C is a little too heavy for the end functionality for the user.
And I'm not sure if we'll be able to reuse this infrastructure for anything
else.
I'm not a fan of the design breaking part of the A and duplication of
attributes.
So, I'd prefer the B here, but I'm a little biased.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 5/21/24 20:56, amore...@redhat.com wrote:
> On Tue, May 21, 2024 at 08:03:49PM GMT, Ilya Maximets wrote:
>> On 5/21/24 18:13, amore...@redhat.com wrote:
>>> On Tue, May 21, 2024 at 03:49:03PM GMT, amore...@redhat.com wrote:
>>>> On Tue, May 21, 2024 at 01:51
On 5/21/24 18:13, amore...@redhat.com wrote:
> On Tue, May 21, 2024 at 03:49:03PM GMT, amore...@redhat.com wrote:
>> On Tue, May 21, 2024 at 01:51:33PM GMT, Ilya Maximets wrote:
>>> On 5/7/24 16:30, Adrian Moreno wrote:
>>>> The goal of this utility is to read bo
d:9.077s, flags:S,
actions:ct(commit,zone=269,mark=0/0x1,nat(src)),set(eth(src=3a:3b:3c:3d:3e:3f,dst=4a:4b:4c:4d:4e:4f)),set(ipv4(ttl=63)),check_pkt_len(size=8514,gt(sample(sample=100.0%,actions(meter(4),userspace(pid=4294967295,controller(reason=1,dont_send=0,continuation=0,recirc_id=29551991,rule_cookie=0x769b5340,controller_id=0,max_len=65535),le(set(eth(src=0a:0b:0c:0d:08:08,dst=aa:bb:cc:dd:ee:ff)),set(ipv4(ttl=62)),check_pkt_len(size=8514,gt(sample(sample=100.0%,actions(meter(4),userspace(pid=4294967295,controller(reason=1,dont_send=0,continuation=0,recirc_id=33861236,rule_cookie=0x9ac6aa33,controller_id=0,max_len=65535),le(ct(zone=12,nat),recirc(0x204ae75)
My guess is that it has some trouble with nested check_pkt_len.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 5/1/24 14:33, Eelco Chaudron wrote:
>
>
> On 29 Apr 2024, at 14:59, Ilya Maximets wrote:
>
>> On 4/16/24 09:44, Eelco Chaudron wrote:
>>> This patch adds a daily Coverity run for the OVS main branch
>>> to the GitHub actions. The result of the ru
of a driver to properly pad
packets before transmitting them. OVS doesn't know what the requirements
for the particular network it is connected to or even if it is an ethernet
or some other type of the interface. So, it can't make a decision on padding,
only driver can do that.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
t; will find the new copied tp== tp_cfg, so ``ofproto_ct_set_zone_timeout_policy`
> will not be called.
As I mentioned in reply to v1, I'd still prefer if we just removed the
get_timeout_policy_from_ovsrec() call from ct_zone_alloc().
Best regards, Ilya Maximets.
>
> Signed-off-by: chandlerwu
> ---
>
sted though. I'll reply to v2 separately.
And please keep the mailing list in CC while replying to emails (i.e.
use Reply-All), so the thread is visible in the mailing list archives.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.or
netdev_features_to_bps(netdev->supported, 0) /
> 100ULL);
> +} else {
> +*current = 0;
> }
> return netdev->get_features_error;
> }
We should be clearing both the current and a max for consistency.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
ction, so we should fix it
instead, so other potential users do not have this issue.
While at it, inet_parse_active() has the same problem. It should set
the 'dns_failure' whenever it fails.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 5/16/24 21:36, Mike Pattrick wrote:
> Clang's static analyzer will complain about an uninitialized value
> because we weren't setting a value for ufid_generated in all code paths.
>
> Now we initialize this on declaration.
>
> Signed-off-by: Mike Pattrick
> ---
Same comments for the subject
On 5/17/24 22:14, Ilya Maximets wrote:
> On 5/16/24 21:36, Mike Pattrick wrote:
>> Clang's static analyzer will complain about an uninitialized value
>> because we weren't properly checking the error code from a function that
>> would have initialized the value.
>
&g
On 5/16/24 21:36, Mike Pattrick wrote:
> Clang's static analyzer will complain about an uninitialized value
> because we weren't properly checking the error code from a function that
> would have initialized the value.
Please, be more specific. :) At least, mention the variable name.
And the
; +ovs_rwlock_unlock(_to_netdev_rwlock);
> +
> +return NULL;
> +}
> +
> +dumps = xzalloc(sizeof *dumps * count);
I'd suggest we initialize the 'dumps' to NULL at the top and then
just if (!count) { goto unlock; } to avoid code duplication.
Best
and falling back to
'pkg_resources' if needed. We may remove the fallback when we stop
supporting python below 3.8.
Even though 'packaging' is a common dependency, added to the test
requirements so it will not be missed in CI.
Signed-off-by: Ilya Maximets
---
python/test_requirements.txt | 1 +
tests
cannot be verified.
The issue can be reproduced on systems with python 3.12+ in case the
deprecated 'pkg_resources' module is not available.
Fixes: 445dceb88461 ("python: Introduce unit tests.")
Signed-off-by: Ilya Maximets
---
tests/atlocal.in | 3 ++-
1 file changed, 2 insertions(+),
'pkg_resources' module is deprecated, so it needs a replacement.
Ilya Maximets (2):
atlocal: Fix setting HAVE_PYTEST on unexpected errors.
atlocal: Replace deprecated pkg_resources.
python/test_requirements.txt | 1 +
tests/atlocal.in | 31 ---
2
ovs_16aligned_in6_addr pointer instead.
Fixes: 7381fd440a88 ("odp: Add SRv6 tunnel actions.")
Fixes: 03fc1ad78521 ("userspace: Add SRv6 tunnel support.")
Signed-off-by: Ilya Maximets
---
lib/netdev-native-tnl.c | 5 ++---
lib/odp-util.c | 4 ++--
2 files changed, 4 insertions(+),
>> Signed-off-by: Mike Pattrick
>
> Thanks for fixing the naming.
>
> Acked-by: Eelco Chaudron
Thanks, Mike, Jakob and Eelco!
I fixed the comment spacing and moved the attribute to the same line
with a return type as we normally do. With that, applied to a
d commit message.
>
> v3:
> - Resolved review comment - added assert.
> - Updated patch subject and commit message.
>
> v4:
> - Fixed checkpatch warning.
Thanks! I added a note to the commit message that the crash was not
related to OV
n/ovsdb-client+0x40906c)
>>
>> Fixes: cb139fa8b3a1 ("table: New function table_format() for formatting a
>> table as a string.")
>> Signed-off-by: Pengfei Sun
>
> Acked-by: Simon Horman
>
Thanks, Pengfei, Eelco and Simon!
Applied and backpotred down to 2.17.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
; Acked-by: Simon Horman
>
Applied to main and backported down to 2.17.
Thanks!
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 5/15/24 12:12, Eelco Chaudron wrote:
>
>
> On 14 May 2024, at 15:48, Emma Finn wrote:
>
>> The AVX implementation for calcualting checksums was not
>> handling carry-over addition correctly in some cases.
>> This patch adds an additional shuffle to add 16-bit padding
>> to the final part of
sync it correctly. What do you think?
Best regards, Ilya Maximets.
>
> Best regards.
>
> On Tue, May 14, 2024 at 5:11 AM Ilya Maximets <mailto:i.maxim...@ovn.org>> wrote:
>
> On 5/6/24 06:05, Chandler Wu wrote:
> > From 5b4d479a9083272e56c51ef952
On 5/14/24 00:42, Ilya Maximets wrote:
> On 5/14/24 00:11, William Tu wrote:
>> Add route-table support for ipv4 dst via ipv6. One use case is BGP
>> unnumbered, a mechanism that establishes peering sessions without the
>> need to explicitly configure IPv4 addresses on th
ut.
> ---
I didn't test, but the code looks fine to me. Thanks!
Acked-by: Ilya Maximets
BTW, is there a reason why we can't just report a static string
from the USDT probe instead of an integer? If we did that we
would not need to have this mapping in the script at all.
Best regards, Ilya Ma
e possible for the same reason.
In addition to tunnel metadata we will also have to provide connection tracking
information, which is even harder, because conntrack state is more dynamic and
is only actually known to the datapath. psample can't supply this information
to the userspace.
Thoughts
On 5/14/24 10:38, Ales Musil wrote:
> There were two things missing for the Fedora builds, 32-bit
> version of glibc to allows the -m32 compilation on Fedora
> and numactl-devel package.
>
> Signed-off-by: Ales Musil
> ---
> .ci/linux-build.sh | 3 +++
>
On 5/14/24 14:43, Eelco Chaudron wrote:
>
>
> On 14 May 2024, at 14:28, Ilya Maximets wrote:
>
>> On 5/14/24 13:27, Eelco Chaudron wrote:
>>>
>>>
>>> On 14 May 2024, at 13:05, Ilya Maximets wrote:
>>>
>>>> On 5/14/24 12:14
On 5/14/24 13:27, Eelco Chaudron wrote:
>
>
> On 14 May 2024, at 13:05, Ilya Maximets wrote:
>
>> On 5/14/24 12:14, Adrian Moreno wrote:
>>>
>>>
>>> On 5/14/24 11:09 AM, Ilya Maximets wrote:
>>>> On 5/14/24 09:39, Adrian Moreno wrote:
&
On 5/14/24 12:14, Adrian Moreno wrote:
>
>
> On 5/14/24 11:09 AM, Ilya Maximets wrote:
>> On 5/14/24 09:39, Adrian Moreno wrote:
>>>
>>>
>>> On 5/10/24 12:45 PM, Adrian Moreno wrote:
>>>>
>>>>
>>>> On 5/10/24 12:06
.
Collector is always an external process...
>>>
>>> "raw": As in, samples are not IPFIX any more (unless the external collector
>>> decides to export them in IPFIX) but we're exporting the raw packet
>>> (alongside some metadata). SAMPLE_ATT
On 5/13/24 20:59, Adrian Moreno wrote:
>
>
> On 5/10/24 3:06 PM, Ilya Maximets wrote:
>> On 5/10/24 14:01, Eelco Chaudron wrote:
>>>
>>>
>>> On 10 May 2024, at 12:45, Adrian Moreno wrote:
>>>
>>>> On 5/10/24 12:06 PM, Eelco Chau
will truncate the packet
> size to the specified value. This can be useful for large packets for which
> we
> are only interested in the headers.
>
> WDYT?
>
> [snip]
>
Hrm. This makes me think these should not be attributes of a sample action at
all,
but rathe
p() below. json_object_put() will copy the name.
> - json, "time",
> +json, xstrdup("time"),
> json_string_create_nocopy(table_format_timestamp__()));
> }
>
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
gt; Reported-at: https://issues.redhat.com/browse/FDP-616
>> Signed-off-by: Mike Pattrick
>> Co-authored-by: Paolo Valerio
>> Signed-off-by: Paolo Valerio
>
> Acked-by: Simon Horman
Thanks, Paolo, Mike and Simon!
Applied and backported down to 2.17.
Bets regards, Ilya Ma
> Thanks Xavier.
>
> Acked-by: Paolo Valerio
Thanks, Xavier and Paolo!
Applied and backported down to 2.17.
Bets regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 5/14/24 00:11, William Tu wrote:
> Add route-table support for ipv4 dst via ipv6. One use case is BGP
> unnumbered, a mechanism that establishes peering sessions without the
> need to explicitly configure IPv4 addresses on the interfaces involved
> in the peering. Without using IPv4 address
that update_timeout_policy() call later in
the function should correctly set the policy. Is that not happening?
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 5/8/24 11:19, Eelco Chaudron wrote:
> The flow_reval_monitor.py script incorrectly reported the reasons for
> FDR_PURGE and FDR_TOO_EXPENSIVE, as their descriptions were swapped.
> This patch rectifies the order using a dictionary to avoid similar
> problems in the future.
>
> In addition this
t;> psample/psample_mon, as we also have nlmon.
>>>>
>>>
>>> Well, the way the cookie is decoded into observation_domain_id and
>>> observation_point_id is ovs-specific.
>>>
>>> In fact, for the n
On 5/13/24 09:17, Eelco Chaudron wrote:
>
>
> On 10 May 2024, at 15:06, Ilya Maximets wrote:
>
>> On 5/10/24 14:01, Eelco Chaudron wrote:
>>>
>>>
>>> On 10 May 2024, at 12:45, Adrian Moreno wrote:
>>>
>>>> On 5/10/24 12:06 PM, E
On 4/24/24 21:53, Adrian Moreno wrote:
> Add a psample_group field to the Flow Sample Collector Set table and use
> it to configure the psample ofproto layer.
>
> Signed-off-by: Adrian Moreno
> ---
> vswitchd/bridge.c | 54 ++
>
for new lines. Also not sure what multi line comment style we
> would
> like to enforce for new files. Coding style prefers /* and /* on new lines,
> but
> other options are allowed. Ilya?
Coding style allows for /* and */ on the same line as the comment start/end,
and I prefer it th
>> diff --git a/lib/odp-util.c b/lib/odp-util.c
>>>> index 21f34d955..611b5229e 100644
>>>> --- a/lib/odp-util.c
>>>> +++ b/lib/odp-util.c
>>>> @@ -227,12 +227,16 @@ format_odp_sample_action(struct ds *ds, const struct
>>>> nlattr *
On 5/10/24 13:44, Ales Musil wrote:
>
>
> On Fri, May 10, 2024 at 1:34 PM Ilya Maximets <mailto:i.maxim...@ovn.org>> wrote:
>
> On 5/10/24 12:57, Ales Musil wrote:
> > The bitmap used in the update_ct_zones was uninitialized, and it could
> &
ode in the
> netdev
> datapath that (as the kernel does) would make the action installation fail.
> I'll
> double check but I think it's just not capable of detecting unsupported
> attributes on flow installation.
It's expected
troy(_users);
> +free(unreq_snat_zones_map);
> }
>
> static void
Thanks, Ales. This change LGTM.
Though I'm a bit surprised asan didn't catch this. Is this code not
covered by tests?
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
using a proper bitmap API. Can we just use
the bitmap_allocate() here instead? With the amount of dynamic memory
allocations this function does with all the hash maps adding one more
allocation will not make any difference, but may protect from potential
issues of not using the API / providing a bad
is
already parsed.
Fixes: 9dd7f8907c37 ("openvswitch: Add original direction conntrack tuple to
sw_flow_key.")
Reported-by: Antonin Bas
Closes: https://github.com/openvswitch/ovs-issues/issues/327
Signed-off-by: Ilya Maximets
---
Note: I'm working on a selftest for this issue, but it req
fixed.
Hope this makes sense.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 5/3/24 11:29, Eelco Chaudron wrote:
>
>
> On 3 May 2024, at 1:36, Ilya Maximets wrote:
>
>> While tracing NAT actions, pointer to the action may be stored in the
>> recirculation node for future reference. However, while translating
>> actions for the grou
>>
>> SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior lib/hash.c:46:22
>>
>> [0] https://github.com/llvm/llvm-project/issues/90848
>> Fixes: db5a101931c5 ("clang: Fix the alignment warning.")
>> Signed-o
.17 since it is needed for
a successful build.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 5/3/24 00:42, Ihar Hrachyshka wrote:
> On Thu, May 2, 2024 at 5:52 PM Ilya Maximets <mailto:i.maxim...@ovn.org>> wrote:
>
> On 4/26/24 18:54, Ihar Hrachyshka wrote:
> > Remove the notion of cluster/leave --force since it was never
> > implemented.
illy error on my
> side, but I am unable to see this patch in OVS patchwork [1].
>
> If it is not there, would it be possible to resubmit?
>
> [1] https://patchwork.ozlabs.org/project/openvswitch/list/
For some reason it had 'Archived' flag set. I un-archived it:
https://patchwork.ozlabs.org/project/openvs
;,
> "Flow translation error",
> ]
Hi, Eelco. Thanks for the fix!
Did you consider changing this array to a dictionary? This may help
avoiding such issues in the future.
A few other general notes:
We may consider adding a comment to the C definition of the enum that
pyth
et_sctp_complete_csum(struct dp_packet *p, bool
> inner)
> tp_len = dp_packet_l4_size(p);
> }
>
> +if (!sh) {
> +return;
> +}
> +
> put_16aligned_be32(>sctp_csum, 0);
> csum = crc32c((void *) sh, tp_len);
> put_16aligned_be32(>sctp_csum, csum);
Please, don't add these checks. If these functions are called for
incorrect packet it's a bug in a code that calls them. We may add
assertions instead, e.g. ovs_assert(sh);
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
s full and
> + * connect() returns EAGAIN (on Linux) or EINPROGRESS (on POSIX). */
Double spaces.
> +for (int i = 0; i < sizeof(clientsocks) / sizeof(clientsocks[0]); i++) {
ARRAY_SIZE macro from util.h.
> +clientsocks[i] = make_unix_socket(SOCK_STREAM, true, NULL,
> client
11b ("ofproto-dpif-trace: Improve NAT tracing.")
Reported-by: Ales Musil
Signed-off-by: Ilya Maximets
---
ofproto/ofproto-dpif-trace.c | 3 ++-
ofproto/ofproto-dpif-trace.h | 2 +-
tests/ofproto-dpif.at| 22 ++
3 files changed, 25 insertions(+), 2 deletions(-
ing the change.
Let me know what you think.
Best regards, Ilya Maximets.
>
> ---
> Documentation/ref/ovsdb.7.rst | 44 ---
> ovsdb/ovsdb-server.1.in | 3 +--
> 2 files changed, 37 insertions(+), 10 deletions(-)
>
> diff --git a/Documen
1 - 100 of 6814 matches
Mail list logo
