Re: [ovs-dev] [PATCH ovn v2] controller: Fix an issue wrt cleanup of stale patch port.

2024-05-14 Thread Priyankar Jain
On 10/05/24 10:06 pm, Numan Siddique wrote: On Fri, May 3, 2024 at 11:00 AM Numan Siddique wrote: On Mon, Apr 22, 2024 at 2:49 AM Priyankar Jain wrote: Issue: Upon updating the network_name option of localnet port from one physical bridge to another, ovn-controller fails to cleanup the peer

[ovs-dev] [PATCH ovn v2] controller: Fix an issue wrt cleanup of stale patch port.

2024-04-22 Thread Priyankar Jain
e cleanup in #3 it will be considered. Fixes: b600316f252a ("Don't delete patch ports that don't belong to br-int") Signed-off-by: Priyankar Jain --- controller/patch.c | 32 +++-- tests/ovn.at | 109 + 2 files changed, 124 in

[ovs-dev] [PATCH ovn] controller: Fix an issue wrt cleanup of stale patch port.

2024-03-28 Thread Priyankar Jain
e cleanup in #3 it will be considered. Fixes: b600316 ("Don't delete patch ports that don't belong to br-int") Signed-off-by: Priyankar Jain --- controller/patch.c | 32 +++-- tests/ovn.at | 109 + 2 files changed, 124 insertions(

Re: [ovs-dev] [PATCH ovn] northd: Added lb_vip_mac config option in Logical_Switch.

2024-02-05 Thread Priyankar Jain
Hi, On 01/02/24 5:15 am, Numan Siddique wrote: On Mon, Jan 8, 2024 at 8:13 AM Priyankar Jain wrote: Currently load balancer applied to a logical switch has the following restriction: - VIP of the load balancer cannot reside in the subnet prefix as the clients as OVN does not install ARP

Re: [ovs-dev] [PATCH ovn v2] northd: Added svc_monitor_ipv4 in NB_Global options.

2024-02-05 Thread Priyankar Jain
about IPv6. I'll add for it as well. Thanks, Priyankar Thanks, Mark Michelson On 1/8/24 08:00, Priyankar Jain wrote: This commit adds a new optional svc_monitor_ipv4 config in the NB_Global options column. This IP address can be used to send the packets to the OVN controller bypassing most of the

[ovs-dev] [PATCH ovn] northd: Added lb_vip_mac config option in Logical_Switch.

2024-01-08 Thread Priyankar Jain
ateway MAC. This allows CMS to allocate VIP of the Load balancer from any subnet prefix. Signed-off-by: Priyankar Jain --- northd/northd.c | 71 ++ northd/northd.h | 2 + northd/ovn-northd.8.xml | 49 ++ tests/ovn.at

[ovs-dev] [PATCH ovn v2] northd: Added svc_monitor_ipv4 in NB_Global options.

2024-01-08 Thread Priyankar Jain
-port mappings. Signed-off-by: Priyankar Jain --- Changes since v1: - Fixed one testcase in ovn-northd.at --- northd/en-sync-sb.c | 10 + northd/northd.c | 34 +-- northd/northd.h | 1 + northd/ovn-northd.8.xml | 40 +++-- tests/ovn-northd.at

[ovs-dev] [PATCH ovn] northd: Added svc_monitor_ipv4 in NB_Global options.

2024-01-08 Thread Priyankar Jain
-port mappings. Signed-off-by: Priyankar Jain --- northd/en-sync-sb.c | 10 + northd/northd.c | 34 -- northd/northd.h | 1 + northd/ovn-northd.8.xml | 40 +++-- tests/ovn-northd.at | 98 + 5 files changed

Re: [ovs-dev] [PATCH ovn] Remove lport from related_lports if there is no binding

2023-07-13 Thread Priyankar Jain
diff oflows1 oflows2 OVN_CLEANUP([hv1],[hv2]) AT_CLEANUP ]) ~ On Thu, Jun 1, 2023 at 8:21 PM Priyankar Jain wrote: Hi Mark, Thanks for the review. On 01/06/23 12:29 am, Mark Michelson wrote: Hi Priyankar, The description makes the issue crystal clear, and you appear to be

Re: [ovs-dev] [PATCH ovn] Remove lport from related_lports if there is no binding

2023-06-01 Thread Priyankar Jain
this race condition as well. I suspect the port-flapping scenario is most likely to trigger it, though. On 5/31/23 01:35, Priyankar Jain wrote: Currently during port migration, two chassis (source and destination) can try to claim the same logical switch port simultaneously for a short-period

[ovs-dev] [PATCH ovn] Remove lport from related_lports if there is no binding

2023-05-30 Thread Priyankar Jain
update to SB. 3. OVS interface deletion notification received by ovn-controller. 4. SB ack received for step-2 PB update. This commit fixes this issue by removing the logical_port from related port even in case there is no binding available locally. Signed-off-by: Priyankar Jain --- controller

[ovs-dev] [PATCH] python-ovs: [jsonrpc] Maintain Connection.output as bytes instead of string

2022-12-28 Thread Priyankar Jain
n_type(errors) OpenSSL.SSL.Error: [('SSL routines', 'ssl3_write_pending', 'bad write retry')] ``` This patch fixes it by maintaining the data to be sent as bytes instead of string in jsonrpc.py so that on retries buffer remains unchanged. Signed-off-by: Priyankar Jain --- python/ovs/jsonr

Re: [ovs-dev] [PATCH ovn v4] northd: Add ACL label

2021-08-11 Thread Priyankar Jain
Hi Numan, In case the patch looks good to you, can you please merge it in master? Thanks and Regards, Priyankar Jain On 02/08/21 2:02 pm, Priyankar Jain wrote: Allow adding label to an ACL to identify which ACL allowed a particular flow in the connection tracking table. The ACL label covers

[ovs-dev] [PATCH ovn v4] northd: Add ACL label

2021-08-02 Thread Priyankar Jain
vs_ct_execute call accounted for 1-2% of the round trip time (sock_sendmsg duration). The actual percentage is expected to be lesser since it doesn't take into account the tracing overhead which is substantial for smaller functions. Signed-off-by: Priyankar Jain Acked-by: Numan Siddique --- v3 -> v4

[ovs-dev] [PATCH ovn v3] northd: Add ACL label

2021-08-02 Thread Priyankar Jain
vs_ct_execute call accounted for 1-2% of the round trip time (sock_sendmsg duration). The actual percentage is expected to be lesser since it doesn't take into account the tracing overhead which is substantial for smaller functions. Signed-off-by: Priyankar Jain Acked-by: Numan Siddique --- v2 -> v3

[ovs-dev] [PATCH ovn v2] northd: Add ACL label

2021-07-29 Thread Priyankar Jain
vs_ct_execute call accounted for 1-2% of the round trip time (sock_sendmsg duration). The actual percentage is expected to be lesser since it doesn't take into account the tracing overhead which is substantial for smaller functions. Signed-off-by: Priyankar Jain --- v1 -> v2 * Changed type of labe

Re: [ovs-dev] [PATCH ovn] northd: Add ACL label

2021-07-23 Thread Priyankar Jain
Sure. Thanks Numan. Best Regards, Priyankar Jain On 23/07/21 7:57 pm, Numan Siddique wrote: On Tue, Jul 20, 2021 at 12:17 PM Priyankar Jain wrote: ping for review. Hi Priyankar, I'll take a look at the patch and come back to you with comments. Thanks Numan On 12/07/21 1:04 pm

Re: [ovs-dev] [PATCH ovn] northd: Add ACL label

2021-07-20 Thread Priyankar Jain
ping for review. On 12/07/21 1:04 pm, Priyankar Jain wrote: Allow adding label to an ACL to identify which ACL allowed a particular flow in the connection tracking table. The ACL label covers 32 bits at the end of ct_label. Since only allowed connections are committed, only "allow"

[ovs-dev] [PATCH ovn] northd: Add ACL label

2021-07-12 Thread Priyankar Jain
vs_ct_execute call accounted for 1-2% of the round trip time (sock_sendmsg duration). The actual percentage is expected to be lesser since it doesn't take into account the tracing overhead which is substantial for smaller functions. Signed-off-by: Priyankar Jain --- lib/logical-fields.c |