Re: [ovs-dev] [ovs-discuss] [branch-2.16] ovn distributed gateway chassisredirect strip_vlan not taking effect with stt

2024-04-24 Thread aginwala
nce, let us know for any further amendments on above changes if any as issue is mitigated with this patch and workaround is needed no more. We will do some more tests and call out for any other failures. Regards, Aliasgar On Tue, Apr 23, 2024 at 10:35 AM aginwala wrote: > Hi: > > Dat

Re: [ovs-dev] [ovs-discuss] [branch-2.16] ovn distributed gateway chassisredirect strip_vlan not taking effect with stt

2024-04-23 Thread aginwala
 PM aginwala wrote: > Hi All: > > Part of upgrading OVN north south gateway to the new 5.4 kernel , VMs > connectivity is lost when setting chassis for provider network lrp to this > new gateway. For interconnection gateways and hypervisors its not an issue/ > lrp > _uuid

[ovs-dev] [ovs-discuss] [branch-2.16] ovn distributed gateway chassisredirect strip_vlan not taking effect with stt

2024-04-19 Thread aginwala
Hi All: Part of upgrading OVN north south gateway to the new 5.4 kernel , VMs connectivity is lost when setting chassis for provider network lrp to this new gateway. For interconnection gateways and hypervisors its not an issue/ lrp _uuid : 387a735d-fc11-4e90-8655-07785aa024af

Re: [ovs-dev] [PATCH ovn] ovn-ctl: Add ssl-ciphers and protocols support.

2024-02-27 Thread aginwala
Rebased to main to fix the merge conflict and sent v2 On Tue, Feb 27, 2024 at 1:59 PM 0-day Robot wrote: > Bleep bloop. Greetings aginwala aginwala, I am a robot and I have tried > out your patch. > Thanks for your contribution. > > I encountered some error that I wasn't

Re: [ovs-dev] [OVN coredump with ssl-ciphers args]

2024-01-22 Thread aginwala
Hi Numan: Ping can we get this in? Also need to apply for branch-23.09. cc @Ales Musil Ali On Thu, Jan 18, 2024 at 9:14 AM aginwala wrote: > Thanks: > > fix: > https://patchwork.ozlabs.org/project/ovn/patch/20240117201258.4033-1-amgin...@gmail.com/ > . > > > Ali

Re: [ovs-dev] [OVN coredump with ssl-ciphers args]

2024-01-18 Thread aginwala
Thanks: fix: https://patchwork.ozlabs.org/project/ovn/patch/20240117201258.4033-1-amgin...@gmail.com/ . Ali On Tue, Jan 9, 2024 at 7:14 PM Numan Siddique wrote: > > > On Tue, Jan 9, 2024, 9:46 PM aginwala wrote: > >> So it seems it would be ok to use STREAM_SSL_OPTION_HAN

Re: [ovs-dev] [PATCH ovn 2/2] add tests for ssl ciphers

2024-01-17 Thread aginwala
Thank Ales: Addressed 2 changes: - Merged into a single commit to include code+tests. - Addressed comment for ovn-controller to remove PKIDIR. PTAL. Thanks, Ali On Tue, Jan 16, 2024 at 10:21 PM Ales Musil wrote: > > > On Wed, Jan 17, 2024 at 6:22 AM aginwala wrote: >

Re: [ovs-dev] [PATCH ovn 2/2] add tests for ssl ciphers

2024-01-16 Thread aginwala
Hi Ales: Ping. Following up for the test coverage bits. I would like to keep it slick for the bug fix/feature gap first. Please confirm so I can amend accordingly. Ali On Fri, Jan 12, 2024 at 8:11 AM aginwala wrote: > Thanks for review. > > On Fri, Jan 12, 2024 at 2:08 AM Ales Mus

Re: [ovs-dev] [PATCH ovn 2/2] add tests for ssl ciphers

2024-01-12 Thread aginwala
Thanks for review. On Fri, Jan 12, 2024 at 2:08 AM Ales Musil wrote: > On Thu, Jan 11, 2024 at 2:30 PM wrote: > > > From: Aliasgar Ginwala > > > > Signed-off-by: Aliasgar Ginwala > > --- > > > > Hi Aliasgar, > > thank you for the series. Those two patches should be squashed to one and I >

Re: [ovs-dev] [OVN coredump with ssl-ciphers args]

2024-01-09 Thread aginwala
So it seems it would be ok to use STREAM_SSL_OPTION_HANDLERS for multiple places not just ovn-controller which covers ssl-ciphers and ssl-protocols. Let me know and can amend in other patch or amend in same patch. On Tue, Jan 9, 2024 at 4:15 PM aginwala wrote: > Hi : > > Debuggin

Re: [ovs-dev] [OVN coredump with ssl-ciphers args]

2024-01-09 Thread aginwala
: +stream_ssl_set_ciphers(optarg); +break; case OPT_PEER_CA_CERT: stream_ssl_set_peer_ca_cert_file(optarg); Works fine after compiling with this fix. I can send a formal pr accordingly. Regards, Ali On Mon, Jan 8, 2024 at 3:35 PM aginwala wrote: > Hi: > > When setting e

[ovs-dev] [OVN coredump with ssl-ciphers args]

2024-01-08 Thread aginwala
Hi: When setting extra args like ssl-cipers for ovn-controller, it results in coredump on branch 23.09 compiled with --with-ovs-source and --with-ovs-build option, OVS (branch-3.2) dump: Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". Core was generated by

Re: [ovs-dev] [PATCH v2] ovs-ctl: Allow recording hostname separately

2021-09-01 Thread aginwala
On Wed, Sep 1, 2021 at 12:26 AM aginwala wrote: > > > On Tue, Aug 31, 2021 at 11:26 PM Frode Nordahl < > frode.nord...@canonical.com> wrote: > >> On Tue, Aug 31, 2021 at 8:28 PM aginwala wrote: >> > >> > >> > >> > On Tue, Aug 31,

Re: [ovs-dev] [PATCH v2] ovs-ctl: Allow recording hostname separately

2021-09-01 Thread aginwala
On Tue, Aug 31, 2021 at 11:26 PM Frode Nordahl wrote: > On Tue, Aug 31, 2021 at 8:28 PM aginwala wrote: > > > > > > > > On Tue, Aug 31, 2021 at 11:20 AM Frode Nordahl < > frode.nord...@canonical.com> wrote: > >> > >> On Tue, Aug

Re: [ovs-dev] [PATCH v2] ovs-ctl: Allow recording hostname separately

2021-08-31 Thread aginwala
On Tue, Aug 31, 2021 at 11:20 AM Frode Nordahl wrote: > On Tue, Aug 31, 2021 at 8:01 PM aginwala wrote: > > > > Hi: > > > > Thanks for this improvement. As per our recent tests with ovs 2.16 with > 5.4* linux, the problem is that ovs-vswitchd adds ovs

Re: [ovs-dev] [PATCH v2] ovs-ctl: Allow recording hostname separately

2021-08-31 Thread aginwala
Hi: Thanks for this improvement. As per our recent tests with ovs 2.16 with 5.4* linux, the problem is that ovs-vswitchd adds ovs-record-hostname as required in the systemctl params. Because of that debian installation of ovs always complaints Setting up openvswitch-switch (2.16.0-1) ...

Re: [ovs-dev] [PATCH ovn] Remove python six library

2020-05-31 Thread aginwala
Thanks for the improvement. Acked-by: Aliasgar Ginwala On Fri, May 29, 2020 at 2:13 PM Brian Haley wrote: > Since OVN is python3-only, there is no need for six. > > Signed-off-by: Brian Haley > --- > Documentation/intro/install/general.rst | 6 -- > Documentation/intro/install/rhel.rst

Re: [ovs-dev] [PATCH] odp-util.c: Fix dp_hash execution with slowpath actions.

2020-05-28 Thread aginwala
Thanks Han for the fix: I verified it in the internal ecmp environment and Ping works fine with no more drop recirc action error messages as per example above. Maybe it would be good to show if R3 has a VIF too in the diagram and tweak the commit message a bit stating VIFs under R3 can ping R3

Re: [ovs-dev] [PATCH v2] datapath: Add hash info to upcall.

2020-05-27 Thread aginwala
Thanks Han for backporting it for lower kernels. I tested this patch with some running workloads with old 3.13* kernels (ovs 2.11*) and it works fine. In addition I am also considering the discussion [1], and for ecmp workloads I see all packets are hitting the different bucket instead of the

Re: [ovs-dev] Improved OVN CI

2020-05-18 Thread aginwala
On Mon, May 18, 2020 at 5:14 PM Mark Michelson wrote: > On 5/18/20 2:47 PM, aginwala wrote: > > Hi Mark: > > > > Sounds a decent plan. However, I think regular patches should cover > > system tests too. Let me know what make commands need to be inclusive > > a

Re: [ovs-dev] Improved OVN CI

2020-05-18 Thread aginwala
Hi Mark: Sounds a decent plan. However, I think regular patches should cover system tests too. Let me know what make commands need to be inclusive and I can give it a shot to enable them apart from make distchecks. For ovn-k8s, I think shouldn't we enable integration tests on ovn-k8s repo where

Re: [ovs-dev] [PATCH ovn v1] test/ovstest: fix shared library deps.

2020-05-18 Thread aginwala
Thanks Numan for review and merge. Yup, I thought the same at first. Going further, let's make sure new patches pass CI as a prereq before merging. On Mon, May 18, 2020 at 2:06 AM Numan Siddique wrote: > On Mon, May 18, 2020 at 1:37 PM wrote: > > > From: Aliasgar Ginwala > > > > When using

Re: [ovs-dev] [PATCH 1/1] ovsdb-tool: fix memory leak while converting cluster into standalone database

2020-03-24 Thread aginwala
Sounds good Ben. I sent https://patchwork.ozlabs.org/patch/1260937/ and https://patchwork.ozlabs.org/patch/1260935/ for 2.11. On Tue, Mar 24, 2020 at 9:53 AM Ben Pfaff wrote: > Probably best to post a rebased series. > > On Fri, Mar 20, 2020 at 11:43:41AM -0700, aginwala wrote: &

Re: [ovs-dev] [PATCH 1/1] ovsdb-tool: fix memory leak while converting cluster into standalone database

2020-03-20 Thread aginwala
://github.com/openvswitch/ovs/commit/5832e6a4f103a1eddd62c9ba459ce669e3a5d132 in too to 2.11 it will apply cleanly. Let me know else I will have to amend the news and it will fail backport for fast re-syc if we move that to 2.11 in future. On Thu, Mar 19, 2020 at 4:22 PM aginwala wrote: > Ok sounds g

Re: [ovs-dev] [PATCH 1/1] ovsdb-tool: fix memory leak while converting cluster into standalone database

2020-03-19 Thread aginwala
Ok sounds good. Will do that. Thanks a ton! On Thu, Mar 19, 2020 at 3:53 PM Ben Pfaff wrote: > I backported both to 2.12. > > They need a manual backport to 2.11, will you take care of it? > > On Thu, Mar 19, 2020 at 03:39:58PM -0700, aginwala wrote: > > Oh I see it see

Re: [ovs-dev] [PATCH 1/1] ovsdb-tool: fix memory leak while converting cluster into standalone database

2020-03-19 Thread aginwala
Ok sure, will do in a bit! On Thu, Mar 19, 2020 at 3:40 PM Ben Pfaff wrote: > There is a merge conflict. Post a backported version? > > On Thu, Mar 19, 2020 at 03:07:39PM -0700, aginwala wrote: > > Hi Ben: > > > > Thanks for backporting previous patches. Plea

Re: [ovs-dev] [PATCH 1/1] ovsdb-tool: fix memory leak while converting cluster into standalone database

2020-03-19 Thread aginwala
u, Mar 19, 2020 at 03:07:39PM -0700, aginwala wrote: > > Hi Ben: > > > > Thanks for backporting previous patches. Please see if you can back port > > this one too to 2.11 and 2.12. > > > > On Thu, Mar 19, 2020 at 1:53 PM aginwala wrote: > > > >

Re: [ovs-dev] [PATCH 1/1] ovsdb-tool: fix memory leak while converting cluster into standalone database

2020-03-19 Thread aginwala
Hi Ben: Thanks for backporting previous patches. Please see if you can back port this one too to 2.11 and 2.12. On Thu, Mar 19, 2020 at 1:53 PM aginwala wrote: > Hi Ben: > Can you also backport this patch to 2.12 and 2.11 too? > > On Mon, Oct 7, 2019 at 11:22 AM Ben Pfaff wrote:

Re: [ovs-dev] [PATCH 1/1] ovsdb-tool: fix memory leak while running "db-is-standalone" command

2020-03-19 Thread aginwala
Hi Ben: Can you also backport this patch to 2.12 and 2.11 too? On Mon, Oct 7, 2019 at 11:21 AM Ben Pfaff wrote: > On Mon, Oct 07, 2019 at 10:30:07AM +0200, Damijan Skvarc wrote: > > problem is reported by valgrind while running functional tests: > > > > ==21043== 160 (88 direct, 72 indirect)

Re: [ovs-dev] [PATCH 1/1] ovsdb-tool: fix memory leak while converting cluster into standalone database

2020-03-19 Thread aginwala
Hi Ben: Can you also backport this patch to 2.12 and 2.11 too? On Mon, Oct 7, 2019 at 11:22 AM Ben Pfaff wrote: > On Mon, Oct 07, 2019 at 10:10:34AM +0200, Damijan Skvarc wrote: > > memory leak is reported by valgrind while executing functional test > > "ovsdb-tool convert-to-standalone" > > >

Re: [ovs-dev] how to use ovn-scale-test when i do not use git repo

2020-01-06 Thread aginwala
Sure: You can refer to https://ovn-scale-test.readthedocs.io/en/latest/tutorial/step_1_setting_up_the_environment.html which is in doc folder of ovn-scale-test repo including the links in README. On Mon, Jan 6, 2020 at 6:29 PM shenjian...@gmail.com wrote: > >

Re: [ovs-dev] [PATCH v1] ovs container build: Make kernel module configurable

2019-12-19 Thread aginwala
Thanks Ben for the review. Sorry for the delay! On Thu, Nov 21, 2019 at 4:54 PM Ben Pfaff wrote: > On Tue, Nov 12, 2019 at 12:47:58AM -0800, amgin...@gmail.com wrote: > > -./configure --localstatedir="/var" --sysconfdir="/etc" --prefix="/usr" \ > > +if [ $KERNEL_VERSION == "host" ]; then > >

Re: [ovs-dev] [PATCH ovn 18/19] ovn-ctl: Support commands for interconnection.

2019-10-29 Thread aginwala
Thanks Han for the patches. OVN-ctl doesn't seem to accept inb/sb args. On Sun, Oct 20, 2019 at 5:55 PM Han Zhou wrote: > Add support for managing IC-NB and IC-SB DBs, and ovn-ic daemon. > > Signed-off-by: Han Zhou > --- > utilities/ovn-ctl | 362 >

Re: [ovs-dev] [PATCH ovn 10/19] ovn-ic: Interconnection controller with AZ registeration.

2019-10-29 Thread aginwala
Thanks Han for the patches. On Sun, Oct 20, 2019 at 5:54 PM Han Zhou wrote: > This patch introduces interconnection controller, ovn-ic, and > implements the basic AZ registration feature: taking the AZ > name from NB DB and create an Availability_Zone entry in > IC-SB DB. > > Signed-off-by: Han

Re: [ovs-dev] [PATCH ovn 19/19] tutorial: Add tutorial for OVN Interconnection.

2019-10-29 Thread aginwala
Thanks Han for the correction. Just one more minor typo in the tutorial below. I hit some roadblocks to start ic controller on different az but got my setup running with workarounds in current code and have posted in comments which needs fix for sure. I tried with 2 different ovn setups with 2

Re: [ovs-dev] [PATCH v1 ovn] ovn-nb/sbctl.c: Use env variables for passing options.

2019-10-15 Thread aginwala
On Tue, Oct 15, 2019 at 10:38 AM Ben Pfaff wrote: > On Mon, Oct 14, 2019 at 07:45:11PM -0700, aginwala wrote: > > On Mon, Oct 14, 2019 at 4:38 PM Ben Pfaff wrote: > > > > > On Mon, Oct 14, 2019 at 03:33:25PM -0700, Ben Pfaff wrote: > > > > On Wed, Oct

Re: [ovs-dev] [PATCH v1] ovs container build.sh requires python3

2019-10-14 Thread aginwala
Hi Ben: Can you also push this to OVS master? Got it merged in ovn repo already. On Fri, Oct 11, 2019 at 2:06 PM wrote: > From: Aliasgar Ginwala > > building ovn/ovs container breaks while configure: > checking for Python 3 (version 3.4 or later)... no > configure: error: Python 3.4 or later

Re: [ovs-dev] [PATCH v1 ovn] ovn-nb/sbctl.c: Use env variables for passing options.

2019-10-14 Thread aginwala
On Mon, Oct 14, 2019 at 4:38 PM Ben Pfaff wrote: > On Mon, Oct 14, 2019 at 03:33:25PM -0700, Ben Pfaff wrote: > > On Wed, Oct 09, 2019 at 04:56:40PM -0700, amgin...@gmail.com wrote: > > > From: Aliasgar Ginwala > > > > > > Add new env variables OVN_NBCTL_OPTIONS and OVN_SBCTL_OPTIONS for > > >

Re: [ovs-dev] [PATCH ovn] ovn-ctl: Create etcdir when starting ovsdb servers

2019-10-12 Thread aginwala
Acked-by: Aliasgar Ginwala > On Sat, Oct 12, 2019 at 1:16 PM wrote: > From: Numan Siddique > > 'ovn-ctl promote_ovnnb/promote_ovnsb' stores the address of the > active server in /etc/ovn/ovn(nb/sb)-active.conf and this fails as > ovn-ctl doesn't create /etc/ovn dir. > > This patch fixes it. >

Re: [ovs-dev] [PATCH v1 ovn] ovn-nb/sbctl.c: Set no-leader-only as default for clustered dbs

2019-10-09 Thread aginwala
the rest of the > OVN community come to consensus here. > > On Thu, Oct 03, 2019 at 02:17:48PM -0700, aginwala wrote: > > Thanks Han and ben for the suggestions. However, one more reason for > using > > this approach is because ovn-controller uses no-leader-only by defaul

Re: [ovs-dev] [PATCH v1 ovn] ovn-nb/sbctl.c: Set no-leader-only as default for clustered dbs

2019-10-03 Thread aginwala
Thanks Han and ben for the suggestions. However, one more reason for using this approach is because ovn-controller uses no-leader-only by default so that all the chassis can be randomly distributed to talk to any node in the cluster to avoid overloading leader node in a large scale env

Re: [ovs-dev] [PATCH v10] ovsdb-tool: Convert clustered db to standalone db.

2019-09-19 Thread aginwala
Hi Ben: Just a gentle reminder. Can you please help merge this patch if no additional comments? Got acked-by Han on the same already. On Fri, Aug 30, 2019 at 8:30 AM wrote: > From: Aliasgar Ginwala > > Add support in ovsdb-tool for migrating clustered dbs to standalone dbs. > E.g. usage to

Re: [ovs-dev] [PATCH 1/2 ovn] OVN: Fix container build.

2019-09-19 Thread aginwala
://patchwork.ozlabs.org/patch/1164870/ to handle the same. PTAL. On Thu, Sep 19, 2019 at 11:15 AM Numan Siddique wrote: > > > On Thu, Sep 12, 2019 at 7:00 AM aginwala wrote: > >> Signed-off-by: Aliasgar Ginwala >> >> > Hi Ali, > > This patch is failing when I

Re: [ovs-dev] [PATCH 05/10] trigger: Free leaked ovsdb_schema

2019-09-13 Thread aginwala
. I take it back! On Fri, Sep 13, 2019 at 9:46 AM Yifeng Sun wrote: > Thanks Aginwala, > > Could you please double check if 'json_destroy(result)' is necessary here? > If result != NULL, then it is passed in trigger_success(), which puts > result in 't->reply', > later, jsonrpc

Re: [ovs-dev] [PATCH 05/10] trigger: Free leaked ovsdb_schema

2019-09-12 Thread aginwala
One minor suggestion here: Can you also handle freeing result: diff --git a/ovsdb/trigger.c b/ovsdb/trigger.c index 6f4ed96b0..0158957d6 100644 --- a/ovsdb/trigger.c +++ b/ovsdb/trigger.c @@ -214,6 +214,7 @@ ovsdb_trigger_try(struct ovsdb_trigger *t, long long int now) /*

Re: [ovs-dev] [PATCH 1/2 ovn] OVN: Fix container build.

2019-09-11 Thread aginwala
Signed-off-by: Aliasgar Ginwala On Wed, Sep 11, 2019 at 6:00 PM 0-day Robot wrote: > Bleep bloop. Greetings aginwala aginwala, I am a robot and I have tried > out your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See th

Re: [ovs-dev] [PATCH 2/2 ovn] Support starting containers with unix socket

2019-09-11 Thread aginwala
Signed-off-by: Aliasgar Ginwala On Wed, Sep 11, 2019 at 6:04 PM 0-day Robot wrote: > Bleep bloop. Greetings aginwala aginwala, I am a robot and I have tried > out your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See th

Re: [ovs-dev] Hypervisor down during upgrade OVS 2.10.x to 2.10.y

2019-09-06 Thread aginwala
Hi: Adding correct ovs-discuss ML. I did get a chance to take a look on it a bit. I think this is the bug in 4.4.0-104-generic kernel on ubuntu 16.04 as its being discussed on ubuntu forum https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1711407 where it can be hit all of a sudden as per the

Re: [ovs-dev] [branch-2.11 1/2] Set release date for 2.11.2.

2019-09-05 Thread aginwala
Hi Justin: Please back-port the above patches to branch-2.10 too as it fails there too. On Thu, Sep 5, 2019 at 4:24 PM Justin Pettit wrote: > > > On Sep 5, 2019, at 4:08 PM, Han Zhou wrote: > > > > Shall older branches support latest kernels? If so, some kernel patches > need to be

Re: [ovs-dev] [PATCH v9] ovsdb-tool: Convert clustered db to standalone db.

2019-08-30 Thread aginwala
Thanks Han. Addressed the minor comment in v10. On Thu, Aug 29, 2019 at 10:31 PM Han Zhou wrote: > Thanks for the update. > > On Thu, Aug 29, 2019 at 6:20 PM wrote: > > > > From: Aliasgar Ginwala > > > > Add support in ovsdb-tool for migrating clustered dbs to standalone dbs. > > E.g. usage

Re: [ovs-dev] [PATCH v8] ovsdb-tool: Convert clustered db to standalone db.

2019-08-29 Thread aginwala
Hi Han and Ben: Sorry, realized little late that ovsdb-tool transact wont work on clustered db. Since in current UT I didn't add AT_CHECK for transact operation for clustered db, test-suite didn't catch the same. Hence, fixed it in v9 and merged it to one UT to use ovsdb-client to insert

Re: [ovs-dev] [PATCH v6] ovsdb-tool: Convert clustered db to standalone db.

2019-08-29 Thread aginwala
On Thu, Aug 29, 2019 at 2:01 PM Han Zhou wrote: > On Thu, Aug 29, 2019 at 1:14 PM wrote: > > > > From: Aliasgar Ginwala > > > > Add support in ovsdb-tool for migrating clustered dbs to standalone dbs. > > E.g. usage to migrate nb/sb db to standalone db from raft: > > ovsdb-tool

Re: [ovs-dev] [PATCH v3] ovsdb-tool: Convert clustered db to standalone db.

2019-08-26 Thread aginwala
Seems some issue in my local env where --enable-Werror --enable-sparse didn't catch this warning. Addressed in v4. On Mon, Aug 26, 2019 at 3:01 PM 0-day Robot wrote: > Bleep bloop. Greetings aginwala aginwala, I am a robot and I have tried > out your patch. > Thanks for your con

Re: [ovs-dev] [PATCH v2] ovsdb-tool: Convert clustered db to standalone db.

2019-08-26 Thread aginwala
Hi Han and Ben: Addressed review comments from both of you in v3 https://patchwork.ozlabs.org/patch/1153456/ . PTAL On Fri, Aug 23, 2019 at 3:37 PM Ginwala, Aliasgar wrote: > Thanks Ben: > > On 8/23/19, 2:50 PM, "Ben Pfaff" wrote: > > On Fri, Aug 23, 2019 at 09:29:00PM +, Ginwala,

Re: [ovs-dev] [PATCH v2] ovsdb-tool: Convert clustered db to standalone db.

2019-08-23 Thread aginwala
Thanks Ben for review! On Fri, Aug 23, 2019 at 10:42 AM Ben Pfaff wrote: > On Thu, Aug 22, 2019 at 05:53:10PM -0700, amgin...@gmail.com wrote: > > From: Aliasgar Ginwala > > > > Add support in ovsdb-tool for migrating clustered dbs to standalone dbs. > > E.g. usage to migrate nb/sb db to

Re: [ovs-dev] [PATCH v2] ovsdb-tool: Convert clustered db to standalone db.

2019-08-23 Thread aginwala
Thanks Han for detailed review. On Fri, Aug 23, 2019 at 8:17 AM Han Zhou wrote: > On Thu, Aug 22, 2019 at 10:29 PM aginwala aginwala > wrote: > > > Thanks for the review Han. > > > > On Thu, Aug 22, 2019 at 7:27 PM Han Zhou wrote: > > > >> Ali, th

Re: [ovs-dev] [PATCH v2] ovsdb-tool: Convert clustered db to standalone db.

2019-08-22 Thread aginwala aginwala
Thanks for the review Han. On Thu, Aug 22, 2019 at 7:27 PM Han Zhou wrote: > Ali, thanks for the patch. Please see my comments below. > > On Thu, Aug 22, 2019 at 5:53 PM wrote: > > > > From: Aliasgar Ginwala > > > > Add support in ovsdb-tool for migrating clustered dbs to standalone dbs. > >

Re: [ovs-dev] [PATCH v1] ovsdb-tool: Convert clustered db to standalone db.

2019-08-22 Thread aginwala aginwala
Thanks Aron. I addressed this warning and sent v2. Didn't see it in subsequent make as it appeared only first time so couldn't notice. On Thu, Aug 22, 2019 at 5:00 PM 0-day Robot wrote: > Bleep bloop. Greetings Aliasgar Ginwala, I am a robot and I have tried > out your patch. > Thanks for your

Re: [ovs-dev] [PATCH v2 ovn] Containerize components

2019-08-21 Thread aginwala
Update documentation about building/running ovn in containers. > > > > Signed-off-by: aginwala > > > > This patch has conflicts. Would you mind submit v3 rebasing the patch ? > > Thanks > Numan > > > > --- > > Documentation/intro/install/general.rst |

Re: [ovs-dev] [PATCH v1 ovn] Containerize components

2019-08-17 Thread aginwala
On Fri, Aug 16, 2019 at 10:33 AM aginwala wrote: > > > On Thu, Aug 15, 2019 at 11:32 PM Numan Siddique > wrote: > >> On Thu, Aug 1, 2019 at 3:01 AM Aliasgar Ginwala >> wrote: >> >> > 1. Containerize ovn central components >> > 2. Conta

Re: [ovs-dev] [PATCH v1 ovn] Containerize components

2019-08-16 Thread aginwala
give it a try and update usage details in doc in v2. > > For ovn db services, it using tcp. Can't we add support to use unix sockets > as well ? I am fine adding this support as a follow up > patch. > > We can for sure as a follow up patch. > Thanks > Numan

Re: [ovs-dev] [PATCH 2/4] ovsdb-idl.c: Allows retry even when using a single remote.

2019-08-14 Thread aginwala
Sure. Thanks for re-validating different corner cases with me. Yup, we can update more details in leader-only section about using single LB VIP while accessing clustered db via ovn-nbctl/ovn-sbctl for sure to avoid confusion. On Wed, Aug 14, 2019 at 3:21 PM Han Zhou wrote: > Hi Aginw

Re: [ovs-dev] [PATCH v2] OVN: Enhance ovndb-servers.ocf to handle inactive_probe_interval updates

2019-06-29 Thread aginwala
Thanks Lucas for the patch: It's good to update inactivity_probe via crm resource as we ideally use ovn-nbtl/ovn-sbctl commands to do that since the value one chooses depends on scale and can be different for everyone and we always tune it from active node. Also what do you mean by multiple

Re: [ovs-dev] [PATCH] ovn-ctl: Set max open files limit for SB DB.

2019-05-15 Thread aginwala
Acked-by: aginwala On Wed, May 15, 2019 at 8:58 AM Han Zhou wrote: > > > On Wed, May 15, 2019 at 12:53 AM aginwala wrote: > >> >> >> On Tue, May 14, 2019 at 3:15 PM Han Zhou wrote: >> >>> From: Han Zhou >>> >>> Increase the

Re: [ovs-dev] [PATCH] ovn-ctl: Set max open files limit for SB DB.

2019-05-15 Thread aginwala
On Tue, May 14, 2019 at 3:15 PM Han Zhou wrote: > From: Han Zhou > > Increase the limit on the number of open file descriptors, because > SB DB may connect to large number of chassises. > > Signed-off-by: Han Zhou > --- > ovn/utilities/ovn-ctl | 8 > 1 file changed, 8 insertions(+) >

Re: [ovs-dev] [PATCH v3 2/2] ovndb-servers.ocf: Add ssl support for managing OVN DB resources with pacemaker using LB VIP.

2018-10-11 Thread aginwala aginwala
Thanks Ben: Please backport it to 2.10 and 2.9 On Thu, Oct 11, 2018 at 2:06 PM Ben Pfaff wrote: > On Wed, Oct 10, 2018 at 11:42:08AM +0530, Numan Siddique wrote: > > On Wed, Oct 10, 2018 at 3:42 AM aginwala wrote: > > > > > When starting OVN DBs in HA using pacemaker w

Re: [ovs-dev] [PATCH 1/2] ovn-ctl: Allow passing ssl certs when starting OVN DBs in ssl mode.

2018-10-09 Thread aginwala aginwala
Hi Han: Have added the man section for ssl in v3. PTAL. Thanks, On Mon, Oct 8, 2018 at 6:49 PM aginwala aginwala wrote: > Sure. I will add ssl usage example with some brief in the ovn-ctl.8.xml > and send v3 for this patch . Does that sound good? > > On Mon, Oct 8, 2018 at 5:32

[ovs-dev] [PATCH v3 2/2] ovndb-servers.ocf: Add ssl support for managing OVN DB resources with pacemaker using LB VIP.

2018-10-09 Thread aginwala
When starting OVN DBs in HA using pacemaker with ssl, we need to pass ssl certs for starting standby DBs. Hence, we need this change. Signed-off-by: aginwala Acked-by: Han Zhou --- ovn/utilities/ovndb-servers.ocf | 72 - 1 file changed, 71 insertions

[ovs-dev] [PATCH v3 1/2] ovn-ctl: Allow passing ssl certs when starting OVN DBs in ssl mode.

2018-10-09 Thread aginwala
-create-insecure-remote=no start_nb_ovsdb When certs are passed in the command line, it will read certs from the path mentioned instead of default db configs. Certs can be generated based on ovs ssl docs: http://docs.openvswitch.org/en/latest/howto/ssl/ Signed-off-by: aginwala --- ovn/utilities

Re: [ovs-dev] [PATCH 2/2] ovndb-servers.ocf: Add ssl support for managing OVN DB resources with pacemaker using LB VIP.

2018-10-09 Thread aginwala aginwala
Thanks Numan for review. Just to update that V3 will only have changes for ovn-ctl as per Han's suggestion to add details in help section there. ocf script will remain unchanged. That is why I have added acked-by on this patch. :) On Mon, Oct 8, 2018 at 11:59 PM Numan Siddique wrote: > > > On

Re: [ovs-dev] [PATCH 1/2] ovn-ctl: Allow passing ssl certs when starting OVN DBs in ssl mode.

2018-10-08 Thread aginwala aginwala
Sure. I will add ssl usage example with some brief in the ovn-ctl.8.xml and send v3 for this patch . Does that sound good? On Mon, Oct 8, 2018 at 5:32 PM Han Zhou wrote: > > > On Mon, Oct 8, 2018 at 4:55 PM aginwala aginwala > wrote: > > > > > > > > On M

Re: [ovs-dev] [PATCH 1/2] ovn-ctl: Allow passing ssl certs when starting OVN DBs in ssl mode.

2018-10-08 Thread aginwala aginwala
On Mon, Oct 8, 2018 at 10:47 AM Han Zhou wrote: > > > On Fri, Oct 5, 2018 at 6:48 PM aginwala aginwala > wrote: > > > > Thanks for the review Han. Please find the comments inline below: > > On Thu, Oct 4, 2018 at 9:58 AM Han Zhou wrote: > >> > &

Re: [ovs-dev] [PATCH 2/2] ovndb-servers.ocf: Add ssl support for managing OVN DB resources with pacemaker using LB VIP.

2018-10-08 Thread aginwala aginwala
On Mon, Oct 8, 2018 at 2:17 PM Han Zhou wrote: > > > On Mon, Oct 8, 2018 at 11:55 AM aginwala aginwala > wrote: > > > > Yes, that's right. I will send out v2 in a bit with Han's ack. > > > > > > Regards, > > Aliasgar > > > > On Mon

Re: [ovs-dev] [PATCH 2/2] ovndb-servers.ocf: Add ssl support for managing OVN DB resources with pacemaker using LB VIP.

2018-10-08 Thread aginwala aginwala
Yes, that's right. I will send out v2 in a bit with Han's ack. Regards, Aliasgar On Mon, Oct 8, 2018 at 11:04 AM Ben Pfaff wrote: > On Mon, Oct 08, 2018 at 10:58:49AM -0700, Han Zhou wrote: > > On Fri, Oct 5, 2018 at 6:34 PM aginwala aginwala > wrote: > > > > >

Re: [ovs-dev] [PATCH 1/2] ovn-ctl: Allow passing ssl certs when starting OVN DBs in ssl mode.

2018-10-05 Thread aginwala aginwala
t=/etc/openvswitch/cacert.pem \ > > --db-nb-create-insecure-remote=no start_nb_ovsdb > > > > Certs can be generated based on ovs ssl docs: > > http://docs.openvswitch.org/en/latest/howto/ssl/ > > > > Signed-off-by: aginwala > > --- > > ovn/utilities/

Re: [ovs-dev] [PATCH 2/2] ovndb-servers.ocf: Add ssl support for managing OVN DB resources with pacemaker using LB VIP.

2018-10-05 Thread aginwala aginwala
pass > ssl > > certs for starting standby DBs. Hence, we need this change. > > > > Signed-off-by: aginwala > > --- > > ovn/utilities/ovndb-servers.ocf | 74 > - > > 1 file changed, 73 insertions(+), 1 deletion(-) > &g

Re: [ovs-dev] [PATCH v2] debian: Move libovn out from package libopenvswitch.

2018-08-27 Thread aginwala
Tested-by: aginwala wrote: > On Fri, Aug 24, 2018 at 06:07:24PM -0700, Han Zhou wrote: > > From: Han Zhou > > > > Since we are packaging OVN and OVS components separately, libovn > > shouldn't belong to OVS, so move it to ovn-common. Also, remove > > it from l

Re: [ovs-dev] [PATCH] debian: Add ovn-detrace to ovn-common package.

2018-07-30 Thread aginwala
Thanks for adding this. Acked-by: aginwala On Sun, Jul 29, 2018 at 4:27 PM Han Zhou wrote: > Signed-off-by: Han Zhou > --- > debian/ovn-common.install | 1 + > debian/ovn-common.manpages | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/debian/ovn-common

Re: [ovs-dev] [ovs-discuss] ovsdb-server core dump and ovsdb corruption using raft cluster

2018-07-24 Thread aginwala
Hi: Glad to see more people picking up on raft testing. Just to add on, you can also refer to https://mail.openvswitch.org/pipermail/ovs-dev/2018-May/347765.html and https://mail.openvswitch.org/pipermail/ovs-dev/2018-April/346375.html where there are couple of suggestions given by Ben too. See

Re: [ovs-dev] [PATCH] Introduce ovs-appctl command to monitor HVs sb connection status

2018-07-19 Thread aginwala
Signed-off-by: aginwala On Thu, Jul 19, 2018 at 4:01 AM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > Add 'connection-status' command to ovs-appctl utility in order to check > if a given chassis is currently connected to SB db > > Co-authored-by: aginwala > S

Re: [ovs-dev] [PATCH 2/2] ovndb-servers: Set connection table when using

2018-07-09 Thread aginwala
Cool! Thanks! On Mon, Jul 9, 2018 at 11:28 AM Ben Pfaff wrote: > OK, that did it. I backported all three. > > On Mon, Jul 09, 2018 at 11:04:12AM -0700, aginwala wrote: > > Hi Ben: > > > > I guess the cherry pick failed because of the dependency pa

Re: [ovs-dev] [PATCH 2/2] ovndb-servers: Set connection table when using

2018-07-09 Thread aginwala
:26 AM Ben Pfaff wrote: > On Thu, Jun 21, 2018 at 01:29:52AM +0530, Numan Siddique wrote: > > On Sat, Jun 9, 2018 at 7:03 AM, aginwala wrote: > > > > > load balancer to manage ovndb clusters via pacemaker. > > > > > > This is will allow s

Re: [ovs-dev] [PATCH 2/2] ovndb-servers.ocf: Set connections in NB and SB DB tables,

2018-06-19 Thread aginwala
Jun 8, 2018 at 12:32 PM, aginwala wrote: > > > > > > so that we can adjust inactivity_probe for master node, while still not > > > listening on TCP on slave node using use_remote_in_db in ovn-ctl. > > > > > > > Minor comment: the commit message

[ovs-dev] [PATCH 2/2] ovndb-servers: Set connection table when using

2018-06-19 Thread aginwala
for slave SB and NB dbs respectively by unsetting --db-sb-use-remote-in-db and --db-nb-use-remote-in-db in ovn-ctl. Signed-off-by: aginwala --- ovn/utilities/ovndb-servers.ocf | 39 +++ 1 file changed, 23 insertions(+), 16 deletions(-) diff --git a/ovn/utilities

Re: [ovs-dev] [PATCH v1] ovn-ctl and ovndb-servers set connection table

2018-06-18 Thread aginwala
wrote: > Hi Ali, thanks for the fix. I reviewed and have some minor improvements > suggested. > > On Sun, Jun 3, 2018 at 7:50 PM, aginwala wrote: > > > > only for master node with remote option when using load balancer to > manage > > ovndb clusters via pace

[ovs-dev] [PATCH 2/2] ovndb-servers.ocf: Set connections in NB and SB DB tables,

2018-06-18 Thread aginwala
so that we can adjust inactivity_probe for master node, while still not listening on TCP on slave node using use_remote_in_db in ovn-ctl. Signed-off-by: aginwala --- ovn/utilities/ovndb-servers.ocf | 39 +++ 1 file changed, 23 insertions(+), 16 deletions

[ovs-dev] [PATCH 1/2] ovn-ctl: Support NB and SB DBs to start without

2018-06-18 Thread aginwala
clusters. Signed-off-by: aginwala --- ovn/utilities/ovn-ctl | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/ovn/utilities/ovn-ctl b/ovn/utilities/ovn-ctl index 4b7eef5..2fce477 100755 --- a/ovn/utilities/ovn-ctl +++ b/ovn/utilities/ovn-ctl @@ -115,6 +115,7

Re: [ovs-dev] Make ofproto_port_open_type() faster

2018-06-11 Thread aginwala
Thanks. :) On Mon, Jun 11, 2018 at 3:40 PM, Ben Pfaff wrote: > On Mon, Jun 11, 2018 at 11:19:08AM -0700, aginwala wrote: > > Can you also apply > > https://github.com/openvswitch/ovs/commit/c381bca52f629f3d35f00471dcd10c > ba1a9a3d99 > > to branch-2.9 too. > > Su

[ovs-dev] Make ofproto_port_open_type() faster

2018-06-11 Thread aginwala
Hi Ben: Can you also apply https://github.com/openvswitch/ovs/commit/c381bca52f629f3d35f00471dcd10cba1a9a3d99 to branch-2.9 too. Wanted to know if its not yet done on purpose to avoid implications if any or you have any other thing in mind. 樂 Regards, Aliasgar

[ovs-dev] [PATCH v1] ovn-ctl and ovndb-servers set connection table

2018-06-08 Thread aginwala
=db:OVN_Northbound,NB_Global,connections will only be set on master node when using load balancer for sb and nb dbs respectively. Signed-off-by: aginwala --- ovn/utilities/ovn-ctl | 6 +- ovn/utilities/ovndb-servers.ocf | 31 ++- 2 files changed, 23 insertions(+), 14

Re: [ovs-dev] [PATCH v5] ovndb-servers.ocf: add LB support for managing ovndb cluster:

2018-06-05 Thread aginwala
Hi Ben: Numan and Han have helped review the same. Have sent a final version (v5) addressing Numan's comment post testing of v4 by him. Regards, On Tue, Jun 5, 2018 at 10:41 AM, Ben Pfaff wrote: > On Sat, Jun 02, 2018 at 09:11:56AM -0700, aginwala wrote: > > using pac

Re: [ovs-dev] [PATCH v4] ovndb-servers.ocf: add LB support for managing ovndb cluster:

2018-06-05 Thread aginwala
On Tue, Jun 5, 2018 at 3:36 AM, Numan Siddique wrote: > On Sat, Jun 2, 2018 at 12:37 AM, aginwala wrote: > > > using pacemaker so that controllers can be placed in different fault > > domains. > > More background about the discussions can be found on: > > https://

[ovs-dev] [PATCH v5] ovndb-servers.ocf: add LB support for managing ovndb cluster:

2018-06-05 Thread aginwala
using pacemaker so that controllers can be placed in different fault domains. More background about the discussions can be found on: https://mail.openvswitch.org/pipermail/ovs-discuss/2018-May/046770.html Signed-off-by: aginwala --- Documentation/topics/integration.rst | 34

Re: [ovs-dev] [PATCH v2] ovndb-servers.ocf: add support for managing cluster

2018-06-03 Thread aginwala
Hi: Have sent out V4 @ https://patchwork.ozlabs.org/patch/924734/ . Please take a look and let me know further. Regards, Aliasgar On Thu, May 31, 2018 at 9:12 AM, aginwala wrote: > > > On Wed, May 30, 2018 at 11:24 PM, Numan Siddique > wrote: > >> >> >> On

[ovs-dev] [PATCH v4] ovndb-servers.ocf: add LB support for managing ovndb cluster:

2018-06-03 Thread aginwala
using pacemaker so that controllers can be placed in different fault domains. More background about the discussions can be found on: https://mail.openvswitch.org/pipermail/ovs-discuss/2018-May/046770.html Signed-off-by: aginwala --- Documentation/topics/integration.rst | 34

Re: [ovs-dev] scale test testing requests (was: raft ovsdb clustering with scale test)

2018-05-31 Thread aginwala
On Fri, May 18, 2018 at 1:35 PM, Ben Pfaff wrote: > I've spent some time stressing the database yesterday and today. So > far, I can't reproduce these particular problems. I do see various ways > to improve OVS and OVN and their tests. > > Here are some suggestions I have for further testing:

Re: [ovs-dev] [PATCH v2] ovndb-servers.ocf: add support for managing cluster

2018-05-31 Thread aginwala
On Wed, May 30, 2018 at 11:24 PM, Numan Siddique wrote: > > > On Thu, May 31, 2018 at 4:06 AM, Han Zhou wrote: > >> >> >> On Wed, May 30, 2018 at 3:27 PM, aginwala wrote: >> >>> >>> >>> On Wed, May 30, 2018 at 2:52 PM, Han Zhou wr

Re: [ovs-dev] [PATCH v2] ovndb-servers.ocf: add support for managing cluster

2018-05-30 Thread aginwala
On Wed, May 30, 2018 at 2:52 PM, Han Zhou wrote: > > > On Tue, May 29, 2018 at 11:40 PM, Numan Siddique > wrote: > > > > On Wed, May 30, 2018 at 5:31 AM, aginwala wrote: > > > > > Thanks for the Review. > > > > > > On W

Re: [ovs-dev] [PATCH v2] ovndb-servers.ocf: add support for managing cluster

2018-05-30 Thread aginwala
Sounds good! Addressed the comments in V3 @ https://patchwork.ozlabs. org/patch/923040/ . Please help review the same and let me know further. On Tue, May 29, 2018 at 11:40 PM, Numan Siddique wrote: > > > On Wed, May 30, 2018 at 5:31 AM, aginwala wrote: > >> Thanks for the Re

[ovs-dev] [PATCH v3] ovndb-servers.ocf: add LB support for managing ovsdb cluster

2018-05-30 Thread aginwala
using pacemaker so that controllers can be placed in different fault domains. Signed-off-by: aginwala --- ovn/utilities/ovndb-servers.ocf | 82 - 1 file changed, 64 insertions(+), 18 deletions(-) diff --git a/ovn/utilities/ovndb-servers.ocf b/ovn

  1   2   >