Re: [ovs-dev] [PATCH] conntrack: Correct length check for tcp packet inside ICMP data.

2019-08-26 Thread Darrell Ball
On Fri, Aug 23, 2019 at 9:09 AM Darrell Ball wrote: > Thanks for the patch > > Goes back to release 2.6/day one :-). > > I'll provide more feedback after today. > I sent an alternative patch here https://mail.openvswitch.org/pipermail/ovs-dev/2019-August/362013.html pls take a look. > > On

Re: [ovs-dev] [PATCH] conntrack: Correct length check for tcp packet inside ICMP data.

2019-08-26 Thread Vishal Deep Ajmera
Hi Darrell, Can we get this merged into master as well as backports to affected branches? Warm Regards, Vishal Ajmera ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] conntrack: Correct length check for tcp packet inside ICMP data.

2019-08-23 Thread Darrell Ball
Thanks for the patch Goes back to release 2.6/day one :-). I'll provide more feedback after today. On Fri, Aug 23, 2019 at 6:20 AM Vishal Deep Ajmera < vishal.deep.ajm...@ericsson.com> wrote: > An ICMP packet with type destination or host not reachable also carries > 28 bytes of ICMP data

[ovs-dev] [PATCH] conntrack: Correct length check for tcp packet inside ICMP data.

2019-08-23 Thread Vishal Deep Ajmera
An ICMP packet with type destination or host not reachable also carries 28 bytes of ICMP data field. This data field contains IP header and TCP header (partial first 8 bytes) of the original packet for which ICMP is being generated. Conntrack module when processing these ICMP packets checks for