Re: [ovs-dev] [PATCH] conntrack: Do not use icmp reverse helper for icmpv6.

2024-03-28 Thread Paolo Valerio
Ilya Maximets writes: > On 3/12/24 11:02, Paolo Valerio wrote: >> In the flush tuple code path, while populating the conn_key, >> reverse_icmp_type() gets called for both icmp and icmpv6 cases, >> while, depending on the proto, its respective helper should be >> called, instead. > > Thanks for

Re: [ovs-dev] [PATCH] conntrack: Do not use icmp reverse helper for icmpv6.

2024-03-22 Thread Ilya Maximets
On 3/12/24 11:02, Paolo Valerio wrote: > In the flush tuple code path, while populating the conn_key, > reverse_icmp_type() gets called for both icmp and icmpv6 cases, > while, depending on the proto, its respective helper should be > called, instead. Thanks for the fix! Some minor nits below.

[ovs-dev] [PATCH] conntrack: Do not use icmp reverse helper for icmpv6.

2024-03-12 Thread Paolo Valerio
In the flush tuple code path, while populating the conn_key, reverse_icmp_type() gets called for both icmp and icmpv6 cases, while, depending on the proto, its respective helper should be called, instead. The above leads to an abort: [...] 0x7f3d461888ff in __GI_abort () at abort.c:79