Re: [ovs-dev] [PATCH] dpctl: fix segfault on ct-{set,del}-limits

2024-04-26 Thread Simon Horman
On Fri, Apr 26, 2024 at 09:59:50AM +0100, Simon Horman wrote: > On Thu, Apr 25, 2024 at 11:52:55AM +0100, Kevin Traynor wrote: > > On 22/04/2024 13:37, Paolo Valerio wrote: > > > When no parameters other than the datapath are specified a segfault > > > occurs. > > > > > > Fix it by checking the

Re: [ovs-dev] [PATCH] dpctl: fix segfault on ct-{set,del}-limits

2024-04-26 Thread Simon Horman
On Thu, Apr 25, 2024 at 11:52:55AM +0100, Kevin Traynor wrote: > On 22/04/2024 13:37, Paolo Valerio wrote: > > When no parameters other than the datapath are specified a segfault > > occurs. > > > > Fix it by checking the argument access is inside the bounds. > > > > Signed-off-by: Paolo Valerio

Re: [ovs-dev] [PATCH] dpctl: fix segfault on ct-{set,del}-limits

2024-04-25 Thread Kevin Traynor
On 22/04/2024 13:37, Paolo Valerio wrote: > When no parameters other than the datapath are specified a segfault > occurs. > > Fix it by checking the argument access is inside the bounds. > > Signed-off-by: Paolo Valerio > --- Acked-by: Kevin Traynor (nit: checkpatch complained about the

Re: [ovs-dev] [PATCH] dpctl: fix segfault on ct-{set,del}-limits

2024-04-23 Thread Simon Horman
On Mon, Apr 22, 2024 at 02:37:41PM +0200, Paolo Valerio wrote: > When no parameters other than the datapath are specified a segfault > occurs. > > Fix it by checking the argument access is inside the bounds. > > Signed-off-by: Paolo Valerio Acked-by: Simon Horman

Re: [ovs-dev] [PATCH] dpctl: fix segfault on ct-{set,del}-limits

2024-04-22 Thread 0-day Robot
Bleep bloop. Greetings Paolo Valerio, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: The subject summary should start with a capital. WARNING: The subject summary should

[ovs-dev] [PATCH] dpctl: fix segfault on ct-{set,del}-limits

2024-04-22 Thread Paolo Valerio
When no parameters other than the datapath are specified a segfault occurs. Fix it by checking the argument access is inside the bounds. Signed-off-by: Paolo Valerio --- lib/dpctl.c | 27 --- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/lib/dpctl.c