Re: [ovs-dev] [PATCH] ovs-ofctl: Avoid unnecessary flow replacement in "replace-flows" command.

2017-08-08 Thread Ben Pfaff
That's great, thanks for the note. On Tue, Aug 08, 2017 at 05:13:41PM -0700, Kevin Lin wrote: > Hi Ben, > > I’ve confirmed that the patch fixed my issue. > > —Kevin > > > On Aug 3, 2017, at 1:57 PM, Ben Pfaff wrote: > > > > On Thu, Aug 03, 2017 at 01:35:50PM -0700, Andy Zhou

Re: [ovs-dev] [PATCH] ovs-ofctl: Avoid unnecessary flow replacement in "replace-flows" command.

2017-08-08 Thread Kevin Lin
Hi Ben, I’ve confirmed that the patch fixed my issue. —Kevin > On Aug 3, 2017, at 1:57 PM, Ben Pfaff wrote: > > On Thu, Aug 03, 2017 at 01:35:50PM -0700, Andy Zhou wrote: >> On Wed, Aug 2, 2017 at 2:13 PM, Ben Pfaff wrote: >>> This bug fix still needs a review.

Re: [ovs-dev] [PATCH] ovs-ofctl: Avoid unnecessary flow replacement in "replace-flows" command.

2017-08-03 Thread Ben Pfaff
On Thu, Aug 03, 2017 at 01:35:50PM -0700, Andy Zhou wrote: > On Wed, Aug 2, 2017 at 2:13 PM, Ben Pfaff wrote: > > This bug fix still needs a review. Also, Kevin, if you can verify that > > it fixes the behavior you see, that would also be helpful. > > > > On Thu, Jul 06, 2017 at

Re: [ovs-dev] [PATCH] ovs-ofctl: Avoid unnecessary flow replacement in "replace-flows" command.

2017-08-03 Thread Andy Zhou
On Wed, Aug 2, 2017 at 2:13 PM, Ben Pfaff wrote: > This bug fix still needs a review. Also, Kevin, if you can verify that > it fixes the behavior you see, that would also be helpful. > > On Thu, Jul 06, 2017 at 04:40:30PM -0700, Ben Pfaff wrote: >> The ovs-ofctl "diff-flows" and

Re: [ovs-dev] [PATCH] ovs-ofctl: Avoid unnecessary flow replacement in "replace-flows" command.

2017-08-02 Thread Ben Pfaff
This bug fix still needs a review. Also, Kevin, if you can verify that it fixes the behavior you see, that would also be helpful. On Thu, Jul 06, 2017 at 04:40:30PM -0700, Ben Pfaff wrote: > The ovs-ofctl "diff-flows" and "replace-flows" command compare the flows > in two flow tables. Until

[ovs-dev] [PATCH] ovs-ofctl: Avoid unnecessary flow replacement in "replace-flows" command.

2017-07-06 Thread Ben Pfaff
The ovs-ofctl "diff-flows" and "replace-flows" command compare the flows in two flow tables. Until now, the "replace-flows" command has considered certain almost meaningless differences related to the version of OpenFlow used to add a flow as significant, which caused it to replace a flow by an